On Mon, Dec 11, 2023 at 8:19 PM Tyler Retzlaff
wrote:
>
> On Mon, Dec 11, 2023 at 09:23:22AM -0800, Stephen Hemminger wrote:
> > There are some places EAL logtype is being used in testpmd
> > and examples where it should not be. Lets reserve EAL
> > logtype to only be used by DPDK internals.
> >
>
On Tue, Dec 12, 2023 at 8:53 AM David Marchand
wrote:
>
> On Mon, Dec 11, 2023 at 9:33 PM Stephen Hemminger
> wrote:
> >
> > With a little setup in eventdev_pmd.h the eventdev drivers
> > and API can be converted to dynamic log type.
> >
> > Signed-off-by: Stephen Hemminger
>
> LGTM (with a comm
> From: Kaiwen Deng [mailto:kaiwenx.d...@intel.com]
> Sent: Tuesday, 12 December 2023 03.16
>
> IEEE 802 packets may have a minimum size limit. The data fields
> should be padded when necessary. In some cases, the padding data
> is not zero.
>
> In 'rte_ipv4_udptcp_cksum_mbuf()', as payload lengt
> On Mon, Dec 11, 2023 at 9:18 PM Stephen Hemminger
> wrote:
> >
> > The cryptodev logs are all referenced via rte_crytpodev.h
>
> crypto*
>
> > so make it dynamic there.
> >
> > Signed-off-by: Stephen Hemminger
>
> I would add a comment in the header that this exported logtype
> variable is f
On Thu, 2023-12-07 at 10:56 -0800, Stephen Hemminger wrote:
> All drivers should be using dynamic logtype.
>
> Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
> Signed-off-by: Stephen Hemminger
Tested-by: Martin Spinler
Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at init")
Cc: sta...@dpdk.org
Cc: vfia...@marvell.com
Signed-off-by: Radu Nicolau
Tested-by: Ting-Kai Ku
---
examples/ipsec-secgw/ipsec.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/examp
On Tue, Dec 5, 2023 at 3:51 PM Bruce Richardson
wrote:
>
> This set contains some small enhancements for the cmdline generation
> script introduced in the last release. Specifically:
>
> * Add support for commands with an optional variable parameter. This
> is needed to support command pairs lik
On Tue, Dec 5, 2023 at 12:31 PM Bruce Richardson
wrote:
>
> The C code generated for the tokens for matching IP addresses in
> commandlines was missing the "static" prefix present in the output for
> the other data-types.
>
> Fixes: 3791e9ed ("buildtools: add a tool to generate cmdline boilerp
On Tue, 12 Dec 2023 at 05:41, Xu, HailinX wrote:
>
> > -Original Message-
> > From: luca.bocca...@gmail.com
> > Sent: Friday, December 1, 2023 7:51 PM
> > To: sta...@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe ;
> > Ali Alnubani ; benjamin.wal...@intel.com; David
> > Christensen ; Hem
Replace pktmbuf pool with mempool, this allows increase in MOPS
especially in lower buffer size. Using Mempool, allows to reduce
the extra CPU cycles.
v1 changes:
1. pktmbuf pool create with mempool create.
2. create src & dst pointer array from the appropaite numa.
3. use get pool and put for
For configuration parameters `mem_size` and `buf_size` are represented
as megabytes and bytes respectively in application. Update the
documentation to represent the same.
Signed-off-by: Vipin Varghese
---
doc/guides/tools/dmaperf.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
dif
TB Attendees
Aaron
Bruce
Hemant
Honnappa
Jerin
Kevin
Konstantin
Maxime
Morten
Stephen
Thomas
NOTE: The technical board meetings are on every second Wednesday at 3 pm
UTC. Meetings are public, and DPDK community members are welcome to attend.
Link to join:
https://zoom-lfx.platform.l
On 11/12/2023 17:23, Stephen Hemminger wrote:
Be consistent for all the error printouts and use fprintf().
The EAL logtype is reserved for internal use by EAL.
Signed-off-by: Stephen Hemminger
---
examples/vm_power_manager/main.c | 11 ---
1 file changed, 4 insertions(+), 7 deletio
On Thu, Nov 23, 2023 at 09:37:58AM +0530, Jerin Jacob wrote:
> On Tue, Nov 21, 2023 at 5:25 PM Bruce Richardson
> wrote:
> >
> > Rather than requiring that any device advertising the
> > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag support all of atomic, ordered
> > and parallel scheduling, we can redef
The various eventdev drivers, while fitting under a common API, do not
all support all scheduling types. The eventdev API is missing some way
to query the particular scheduling support for a driver, a key piece of
information for application developers. This patchset adds the necessary
capability f
Not all eventdev's support all scheduling types, for example, some may
only support atomic scheduling or others only support ordered
scheduling. There is currently no clear indication for each driver what
sched types it supports, so add capability flags to be indicated on
return from rte_event_dev_
Rather than requiring that any device advertising the
RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag support all of atomic, ordered
and parallel scheduling, we can redefine the field so that it basically
means that you don't need to specify the queue scheduling type at config
time. Instead all types of sup
Document explicitly the scheduling types supported by this driver, both
via info_get() function, and via table in the documentation.
Signed-off-by: Bruce Richardson
---
doc/guides/eventdevs/features/cnxk.ini | 3 +++
drivers/event/cnxk/cnxk_eventdev.c | 5 -
2 files changed, 7 insertions
Document explicitly the scheduling types supported by this driver, both
via info_get() function, and via table in the documentation.
Signed-off-by: Bruce Richardson
Acked-by: Abdullah Sevincer
---
doc/guides/eventdevs/features/dlb2.ini | 3 +++
drivers/event/dlb2/dlb2.c | 5 -
Document explicitly the scheduling types supported by these drivers,
both via info_get() function, and via table in the documentation.
Signed-off-by: Bruce Richardson
Acked-by: Hemant Agrawal
---
doc/guides/eventdevs/features/dpaa.ini | 2 ++
doc/guides/eventdevs/features/dpaa2.ini | 2 ++
dri
Document explicitly the scheduling types supported by this driver, both
via info_get() function, and via table in the documentation.
Signed-off-by: Bruce Richardson
---
doc/guides/eventdevs/features/dsw.ini | 2 ++
drivers/event/dsw/dsw_evdev.c | 2 ++
2 files changed, 4 insertions(+)
d
Document explicitly the scheduling types supported by this driver, both
via info_get() function, and via table in the documentation.
Signed-off-by: Bruce Richardson
---
doc/guides/eventdevs/features/octeontx.ini | 3 +++
drivers/event/octeontx/ssovf_evdev.c | 3 +++
2 files changed, 6 inse
Document explicitly the scheduling types supported by this driver, both
via info_get() function, and via table in the documentation.
Signed-off-by: Bruce Richardson
---
doc/guides/eventdevs/features/opdl.ini | 3 +++
drivers/event/opdl/opdl_evdev.c| 3 +++
2 files changed, 6 insertions(+
Document explicitly the scheduling types supported by this driver, both
via info_get() function, and via table in the documentation.
Signed-off-by: Bruce Richardson
---
doc/guides/eventdevs/features/sw.ini | 3 +++
drivers/event/sw/sw_evdev.c | 3 +++
2 files changed, 6 insertions(+)
d
On 12/5/23 10:45, David Marchand wrote:
Now that a r/w lock is used, the access_ok field should only be updated
under a write lock.
Since the datapath code only takes a read lock on the virtqueue to check
access_ok, this lock must be released and a write lock taken before
calling vring_transl
> From: Vipin Varghese [mailto:vipin.vargh...@amd.com]
> Sent: Tuesday, 12 December 2023 11.38
>
> Replace pktmbuf pool with mempool, this allows increase in MOPS
> especially in lower buffer size. Using Mempool, allows to reduce
> the extra CPU cycles.
I get the point of this change: It tests th
With belows to changes,
Acked-by: Huisong Li
在 2023/12/12 1:23, Stephen Hemminger 写道:
Testpmd is misusing EAL logtype for its own errors.
Since the code directly calls fprintf in other places,
change to use that everywhere. This has the added benefit
of not having testpmd output clutter up sysl
Acked-by: Huisong Li
在 2023/12/12 1:23, Stephen Hemminger 写道:
EAL logtype should be reserved for EAL library.
This example is already using printf() so just print
errors to stderr.
Signed-off-by: Stephen Hemminger
---
examples/l2fwd-keepalive/shm.c | 21 +++--
1 file change
Acked-by: Huisong Li
在 2023/12/12 1:23, Stephen Hemminger 写道:
Be consistent for all the error printouts and use fprintf().
The EAL logtype is reserved for internal use by EAL.
Signed-off-by: Stephen Hemminger
---
examples/vm_power_manager/main.c | 11 ---
1 file changed, 4 insertio
> Subject: [RFC] ethdev: introduce entropy calculation
>
> When offloading rules with the encap action, the HW may calculate entropy
> based on the encap protocol.
> Each HW can implement a different algorithm.
>
> When the application receives packets that should have been encaped by the
> HW, b
Hi all,
Here is a new stable release:
https://fast.dpdk.org/rel/dpdk-20.11.10.tar.xz
The git tree is at:
https://dpdk.org/browse/dpdk-stable/?h=20.11
This is the final release of the 20.11 LTS branch, and it is now EOL.
So long, and thanks for all the packets.
Luca Boccassi
---
On Tue, Dec 12, 2023 at 4:58 PM Bruce Richardson
wrote:
>
> On Thu, Nov 23, 2023 at 09:37:58AM +0530, Jerin Jacob wrote:
> > On Tue, Nov 21, 2023 at 5:25 PM Bruce Richardson
> > wrote:
> > >
> > > Rather than requiring that any device advertising the
> > > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag s
On Mon, Dec 11, 2023 at 9:18 PM Stephen Hemminger
wrote:
>
> The cryptodev logs are all referenced via rte_crytpodev.h
> so make it dynamic there.
>
> Signed-off-by: Stephen Hemminger
Applied, thanks.
--
David Marchand
Release status meeting minutes 2023-12-07
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* Debian/Microsoft
* Intel
* Marvell
* Nvidia
* Red Hat
Release Dates
-
The following are the current working
Thank you Maryam updating the document.
I have added some comment below.
Also what do you think about changing the name of the document file
"af_xdp_cni.rst" to "af_xdp_dp.rst" ?
Regards,
Shibin
> -Original Message-
> From: Maryam Tahhan
> Sent: Monday, December 11, 2023 2:39 PM
> To:
Incorrect ptypes list causes buffer overflow for Address Sanitizer
run and a tap device. The last element in the ptypes lists to be
to "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes().
In rte_eth_dev_get_supported_ptypes(), the loop iterates until it
finds "RTE_PTYPE_UNKNOWN" to detect la
On 12/12/2023 11:40 AM, Morten Brørup wrote:
>> From: Vipin Varghese [mailto:vipin.vargh...@amd.com]
>> Sent: Tuesday, 12 December 2023 11.38
>>
>> Replace pktmbuf pool with mempool, this allows increase in MOPS
>> especially in lower buffer size. Using Mempool, allows to reduce
>> the extra CPU cy
On Fri, Dec 8, 2023 at 10:27 PM Tyler Retzlaff
wrote:
>
> On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote:
> > Signed-off-by: David Marchand
> > ---
>
> Reviewed-by: Tyler Retzlaff
>
> > lib/rcu/rte_rcu_qsbr.c | 62 --
> > lib/rcu/rte_rcu_q
+TO: Bruce, please stop me if I'm completely off track here.
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Tuesday, 12 December 2023 15.38
>
> On 12/12/2023 11:40 AM, Morten Brørup wrote:
> >> From: Vipin Varghese [mailto:vipin.vargh...@amd.com]
> >> Sent: Tuesday, 12 December 2023 1
On 12/12/2023 2:37 PM, Sivaramakrishnan Venkat wrote:
> Incorrect ptypes list causes buffer overflow for Address Sanitizer
> run and a tap device. The last element in the ptypes lists to be
> to "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes().
> In rte_eth_dev_get_supported_ptypes(), the
On 12/11/2023 3:08 AM, Chaoyong He wrote:
> This patch series add the support of link auto negotiation feature,
> including speed and FEC mode.
>
> Zerun Fu (7):
> net/nfp: set a new parameter to hwinfo
> net/nfp: support getting speed capability
> net/nfp: support setting port speed
> net
Currently IPsec MB provides both the JOB API and direct API.
AESNI_MB PMD is using the JOB API codepath while ZUC, KASUMI, SNOW3G,
CHACHA20_POLY1305 and AESNI_GCM are using the direct API.
Instead of using the direct API for these PMDs, they should now make
use of the JOB API codepath. This would r
On Tue, Dec 12, 2023 at 04:16:20PM +0100, Morten Brørup wrote:
> +TO: Bruce, please stop me if I'm completely off track here.
>
> > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Tuesday, 12
> > December 2023 15.38
> >
> > On 12/12/2023 11:40 AM, Morten Brørup wrote:
> > >> From: Vipin Va
The variable rte_cyptodev_names is unused and misspelled.
Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented")
Signed-off-by: Stephen Hemminger
---
lib/cryptodev/rte_cryptodev.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/crypt
The logtype does not need to be exported as API.
Fixes: be618b81545e ("cryptodev: convert to dynamic logtype")
Signed-off-by: Stephen Hemminger
---
lib/cryptodev/version.map | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
With a little setup in eventdev_pmd.h the eventdev drivers
and API can be converted to dynamic log type.
Signed-off-by: Stephen Hemminger
---
v2 - logtpe can be internal
lib/eventdev/eventdev_pmd.h | 3 +++
lib/eventdev/rte_eventdev.c | 2 ++
lib/eventdev/version.map| 1 +
lib/log/log.c
From: Sunil Kumar Kori
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate
structs and defines for the commandline part of the application.
Signed-off-by: Sunil Kumar Kori
Acked-by: Bruce Richardson
---
v1..v2:
- Rebase and remove Depends-On: tag as dependent series is applied
On Tue, 12 Dec 2023 06:25:12 +0200
Artemy Kovalyov wrote:
> +rte_atomic32_t g_count;
> +
> +static int
> +done(const struct rte_mp_msg *msg __rte_unused, const void *arg __rte_unused)
> +{
> + rte_atomic32_dec(&g_count);
> + return 0;
> +}
Local variable, should be static.
Also, assert
[Public]
Sharing a few critical points based on my exposure to the dma-perf application
below
On Tue, Dec 12, 2023 at 04:16:20PM +0100, Morten Brørup wrote:
> +TO: Bruce, please stop me if I'm completely off track here.
>
> > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Tuesday, 12
>
From: Varghese, Vipin [mailto:vipin.vargh...@amd.com]
Sent: Tuesday, 12 December 2023 18.14
Sharing a few critical points based on my exposure to the dma-perf application
below
On Tue, Dec 12, 2023 at 04:16:20PM +0100, Morten Brørup wrote:
> +TO: Bruce, please stop me if I'm completel
[AMD Official Use Only - General]
Thank you Morten for the understanding
From: Morten Brørup
Sent: 12 December 2023 23:39
To: Varghese, Vipin ; Bruce Richardson
Cc: Yigit, Ferruh ; dev@dpdk.org ;
sta...@dpdk.org ; honest.ji...@foxmail.com
; P, Thiyagarajan
Su
On Tue, Dec 12, 2023 at 04:00:35PM +0100, David Marchand wrote:
> On Fri, Dec 8, 2023 at 10:27 PM Tyler Retzlaff
> wrote:
> >
> > On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote:
> > > Signed-off-by: David Marchand
> > > ---
> >
> > Reviewed-by: Tyler Retzlaff
> >
> > > lib/rcu/r
The generic RTE_LOGTYPE_PMD is a leftover and should be removed.
As a first step, fix many drivers to not use it, and add a
helper for the RTE_LOG_DP().
Most of this patchset is boiler plate but there were some
places where use of PMD type snuck in with changes to
original driver and get fixed he
The macro does not return a numeric status, only void.
Fixes: 5d8f0baf69ea ("log: do not drop debug logs at compile time")
Signed-off-by: Stephen Hemminger
---
lib/log/rte_log.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h
index 4d207b8da2cd..05
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/atlantic/atl_logs.h | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/net/atlantic/atl_logs.h b/drivers/net/atlantic/atl_logs.h
index e3dba334fe92..c2a3a6320c58 10064
Add a new macro for logging in datapath using a logtype.
The existing macro RTE_LOG_DP() takes log type suffix (i.e. PMD)
like RTE_LOG(). This macro allows using a dynamic type.
Ideally, rte_log_dp() could be an always_inline function
but GCC and Clang will not inline a function with variable numb
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/avp/avp_logs.h | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/net/avp/avp_logs.h b/drivers/net/avp/avp_logs.h
index 6e297c7a4a81..0ae95a7685c5 100644
--- a/d
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/dpaa/dpaa_ethdev.c | 4 ++--
drivers/net/dpaa/dpaa_ethdev.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index ef4c06d
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt.h | 5 +
drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +--
drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 +--
drivers/net/bnxt/bnxt_txr.c | 4 +---
4 files changed, 8 insertions
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/enetc/enetc_logs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/enetc/enetc_logs.h b/drivers/net/enetc/enetc_logs.h
index 0976d42debd7..05a540f16490 100644
--- a/drivers/net
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
drivers/net/dpaa2/dpaa2_pmd_logs.h | 2 +-
drivers/net/dpaa2/dpaa2_sparser.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_et
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/enetfec/enet_pmd_logs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/enetfec/enet_pmd_logs.h
b/drivers/net/enetfec/enet_pmd_logs.h
index 72d1cb61c598..c0a226284c53 100644
-
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/igc/igc_logs.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/igc/igc_logs.h b/drivers/net/igc/igc_logs.h
index 11071a32b542..ffa1981bae32 100644
--- a/drivers/net/
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/mana/mana.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h
index 6836872dc257..8d60f9172d44 100644
--- a/drivers/net/mana/mana.h
+++ b/dr
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/octeon_ep/otx_ep_common.h | 7 +++
drivers/net/octeon_ep/otx_ep_rxtx.c | 5 ++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/octeon_ep/otx_ep_common.h
b/drivers/net/octe
The driver already has a logtype but it was not being used
in one place.
Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather")
Signed-off-by: Stephen Hemminger
---
drivers/net/mvpp2/mrvl_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mvpp2/mrv
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/octeontx/octeontx_logs.h | 3 +--
drivers/net/pfe/pfe_logs.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/octeontx/octeontx_logs.h
b/drivers/net/octeontx/octeo
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/qede/qede_logs.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h
index 3187d97bb7b0..097294be9c71 100644
--- a/driver
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/virtio/virtio_logs.h | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/net/virtio/virtio_logs.h b/drivers/net/virtio/virtio_logs.h
index 9b1b1defc5a6..0447ee961fb6 1
The driver used a slightly different (and older) format
for datapath logs. Remove PMD logtype here.
Signed-off-by: Stephen Hemminger
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
drivers/net/vmxnet3/vmxnet3_logs.h | 12
2 files changed, 9 insertions(+), 5 deletions(-)
diff --
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/common/cnxk/roc_platform.h | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/common/cnxk/roc_platform.h
b/drivers/common/cnxk/roc_platform.h
index ba23b2e
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/common/cpt/cpt_pmd_logs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/cpt/cpt_pmd_logs.h
b/drivers/common/cpt/cpt_pmd_logs.h
index 174326c6ce38..6b78fcb6b6fc 100644
--- a/d
This code was implemented in a slightly different manner
than all the other logging code (for no good reason).
Make it the same and handle errors in same way as
other drivers.
Signed-off-by: Stephen Hemminger
---
drivers/common/sfc_efx/sfc_efx.c | 11 ++-
drivers/common/sfc_efx/sfc_e
Use existing dpaax_logger log type instead of PMD.
Signed-off-by: Stephen Hemminger
---
drivers/common/dpaax/caamflib/compat.h | 5 -
drivers/common/dpaax/version.map | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/common/dpaax/caamflib/compat.h
b/drivers/
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h
b/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h
index
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/bus/cdx/cdx_logs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/cdx/cdx_logs.h b/drivers/bus/cdx/cdx_logs.h
index a1046ce544a6..e432fae00e4d 100644
--- a/drivers/bus/cdx/cdx_log
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/dma/dpaa/dpaa_qdma_logs.h | 5 +++--
drivers/dma/dpaa2/dpaa2_qdma_logs.h | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/dpaa/dpaa_qdma_logs.h
b/drivers/dma/dpaa/dpaa_qdma_l
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/bus/fslmc/fslmc_logs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h
index a1e14dd84e9a..edd74af04d7c 100644
--- a/drivers/bus
The driver already has a logtype, just not consistently used.
Signed-off-by: Stephen Hemminger
---
drivers/mempool/dpaa/dpaa_mempool.h | 2 +-
drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++--
drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 2 +-
3 files changed, 4 insertions(+),
> -Original Message-
> From: Stephen Hemminger
> Sent: Wednesday, December 13, 2023 09:42
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Guo, Junfeng
> ; Su, Simei
> Subject: [PATCH 10/26] net/igc: replace RTE_LOG_DP with rte_log_dp
>
> Want datapath logs to use own logtype.
>
> Signed
On Wed, Dec 13, 2023 at 7:14 AM Stephen Hemminger
wrote:
>
> Want datapath logs to use own logtype.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/bnxt/bnxt.h | 5 +
> drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +--
> drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 +--
> dr
This patch series aims to unify the usage of capacity and control,
and revise the related logics.
Chaoyong He (5):
net/nfp: complete the logic of print capacity
net/nfp: modify the logic of set promisc mode
net/nfp: modify the logic of set MAC address
net/nfp: use ctrl to check the mode of
Complete the logic of print capacity, print all the capacity and
extend capacity.
Signed-off-by: Chaoyong He
Reviewed-by: Peng Zhang
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_net_common.c | 59 ++--
1 file changed, 41 insertions(+), 18 deletions(-)
diff --git a/
Modify the logic of set promisc mode, add the check logic of
capacity.
Signed-off-by: Chaoyong He
Reviewed-by: Peng Zhang
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_net_common.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_ne
Modify the logic of set MAC address, add the check logic of MAC address.
Signed-off-by: Chaoyong He
Reviewed-by: Peng Zhang
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_net_common.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_
Use the 'ctrl' rather than 'cap' to check the switch mode of features.
Signed-off-by: Chaoyong He
Reviewed-by: Peng Zhang
Reviewed-by: Long Wu
---
drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 10 +-
drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 12 ++--
drivers/net/nfp/nfp_net_common.c | 2 +
Use the 'ctrl_extend' rather than 'cap_extend' to check the switch mode
of features.
Signed-off-by: Chaoyong He
Reviewed-by: Peng Zhang
Reviewed-by: Long Wu
---
drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 4 +---
drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 4 +---
drivers/net/nfp/nfp_ethdev.c | 5 +++-
The generic RTE_LOGTYPE_PMD is a leftover and should be removed.
As a first step, fix many drivers to not use it, and add a
helper for the RTE_LOG_DP().
Most of this patchset is boiler plate but there were some
places where use of PMD type snuck in with changes to
original driver and get fixed he
The macro does not return a numeric status, only void.
Fixes: 5d8f0baf69ea ("log: do not drop debug logs at compile time")
Signed-off-by: Stephen Hemminger
---
lib/log/rte_log.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h
index 4d207b8da2cd..05
Add a new macro for logging in datapath using a logtype.
The existing macro RTE_LOG_DP() takes log type suffix (i.e. PMD)
like RTE_LOG(). This macro allows using a dynamic type.
Ideally, rte_log_dp() could be an always_inline function
but GCC and Clang will not inline a function with variable numb
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/atlantic/atl_logs.h | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/net/atlantic/atl_logs.h b/drivers/net/atlantic/atl_logs.h
index e3dba334fe92..c2a3a6320c58 10064
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/avp/avp_logs.h | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/net/avp/avp_logs.h b/drivers/net/avp/avp_logs.h
index 6e297c7a4a81..0ae95a7685c5 100644
--- a/d
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
Acked-by: Somnath Kotur
---
drivers/net/bnxt/bnxt.h | 5 +
drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +--
drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 +--
drivers/net/bnxt/bnxt_txr.c | 4 +---
4 fi
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/dpaa/dpaa_ethdev.c | 4 ++--
drivers/net/dpaa/dpaa_ethdev.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index ef4c06d
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
drivers/net/dpaa2/dpaa2_pmd_logs.h | 2 +-
drivers/net/dpaa2/dpaa2_sparser.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_et
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/enetc/enetc_logs.h | 2 +-
drivers/net/enetfec/enet_pmd_logs.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/enetc/enetc_logs.h b/drivers/net/enetc/enetc_logs.h
index
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
Acked-by: Junfeng Guo
---
drivers/net/igc/igc_logs.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/igc/igc_logs.h b/drivers/net/igc/igc_logs.h
index 11071a32b542..ffa1981bae32 10
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/mana/mana.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h
index 6836872dc257..8d60f9172d44 100644
--- a/drivers/net/mana/mana.h
+++ b/dr
The driver already has a logtype but it was not being used
in one place.
Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather")
Signed-off-by: Stephen Hemminger
---
drivers/net/mvpp2/mrvl_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mvpp2/mrv
Want datapath logs to use own logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/octeon_ep/otx_ep_common.h | 7 +++
drivers/net/octeon_ep/otx_ep_rxtx.c | 5 ++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/octeon_ep/otx_ep_common.h
b/drivers/net/octe
1 - 100 of 118 matches
Mail list logo
