Re: [PATCH v8 12/21] dts: interactive remote session docstring update

On Thu, Nov 30, 2023 at 10:50 PM Jeremy Spewock wrote: > > > > On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš > wrote: >> >> Format according to the Google format and PEP257, with slight >> deviations. >> >> Signed-off-by: Juraj Linkeš >> --- >> .../interactive_remote_session.py | 3

Re: [PATCH v8 15/21] dts: os session docstring update

>> diff --git a/dts/framework/testbed_model/os_session.py >> b/dts/framework/testbed_model/os_session.py >> index 76e595a518..cfdbd1c4bd 100644 >> --- a/dts/framework/testbed_model/os_session.py >> +++ b/dts/framework/testbed_model/os_session.py >> @@ -201,69 +283,119 @@ def build_dpdk( >>

Re: [PATCH v8 18/21] dts: sut and tg nodes docstring update

On Fri, Dec 1, 2023 at 7:06 PM Jeremy Spewock wrote: > > > > On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš > wrote: >> >> Format according to the Google format and PEP257, with slight >> deviations. >> >> Signed-off-by: Juraj Linkeš >> --- >> dts/framework/testbed_model/sut_node.py | 230 +

Re: [PATCH v8 19/21] dts: base traffic generators docstring update

On Fri, Dec 1, 2023 at 7:05 PM Jeremy Spewock wrote: > > > > On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš > wrote: >> >> Format according to the Google format and PEP257, with slight >> deviations. >> >> Signed-off-by: Juraj Linkeš >> --- >> .../traffic_generator/__init__.py | 22

Re: [PATCH v8 20/21] dts: scapy tg docstring update

On Fri, Dec 1, 2023 at 7:18 PM Jeremy Spewock wrote: > > > > On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš > wrote: >> >> Format according to the Google format and PEP257, with slight >> deviations. >> >> Signed-off-by: Juraj Linkeš >> --- >> .../testbed_model/traffic_generator/scapy.py | 91

[PATCH v4] windows/virt2phys: fix block MDL not updated

The virt2phys_translate function previously scanned existing blocks, returning the physical address from the stored MDL info if present. This method was problematic when a virtual address pointed to a freed and reallocated memory segment, potentially changing the physical address mapping. Yet, virt

RE: [PATCH v7 1/2] vfio: add get device info API

> -Original Message- > From: Chenbo Xia > Sent: Wednesday, November 29, 2023 9:48 AM > To: Ye, MingjinX > Cc: dev@dpdk.org; Yang, Qiming ; Burakov, > Anatoly > Subject: Re: [PATCH v7 1/2] vfio: add get device info API > > On Nov 22, 2023, at 18:22, Mingjin Ye wrote: > > > > External

[PATCH v9 00/21] dts: docstrings update

The first commit makes changes to the code. These code changes mainly change the structure of the code so that the actual API docs generation works. There are also some code changes which get reflected in the documentation, such as making functions/methods/attributes private or public. The rest of

[PATCH v9 01/21] dts: code adjustments for doc generation

The standard Python tool for generating API documentation, Sphinx, imports modules one-by-one when generating the documentation. This requires code changes: * properly guarding argument parsing in the if __name__ == '__main__' block, * the logger used by DTS runner underwent the same treatment so

[PATCH v9 02/21] dts: add docstring checker

Python docstrings are the in-code way to document the code. The docstring checker of choice is pydocstyle which we're executing from Pylama, but the current latest versions are not complatible due to [0], so pin the pydocstyle version to the latest working version. [0] https://github.com/klen/pyla

[PATCH v9 03/21] dts: add basic developer docs

Expand the framework contribution guidelines and add how to document the code with Python docstrings. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 73 1 file changed, 73 insertions(+) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools

[PATCH v9 04/21] dts: exceptions docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/__init__.py | 12 - dts/framework/exception.py | 106 + 2 files changed, 83 insertions(+), 35 deletions(-) diff --git a/dts/framework

[PATCH v9 05/21] dts: settings docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/settings.py | 103 +- 1 file changed, 102 insertions(+), 1 deletion(-) diff --git a/dts/framework/settings.py b/dts/framework/settings.py i

[PATCH v9 06/21] dts: logger and utils docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/logger.py | 72 ++--- dts/framework/utils.py | 88 + 2 files changed, 113 insertions(+), 47 deletions(-) d

[PATCH v9 07/21] dts: dts runner and main docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/dts.py | 131 --- dts/main.py | 10 ++-- 2 files changed, 116 insertions(+), 25 deletions(-) diff --git a/dts/framework/dts.p

[PATCH v9 08/21] dts: test suite docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_suite.py | 231 +++- 1 file changed, 175 insertions(+), 56 deletions(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suit

[PATCH v9 09/21] dts: test result docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_result.py | 297 --- 1 file changed, 239 insertions(+), 58 deletions(-) diff --git a/dts/framework/test_result.py b/dts/framework/test_res

[PATCH v9 10/21] dts: config docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/config/__init__.py | 369 ++- dts/framework/config/types.py| 132 +++ 2 files changed, 444 insertions(+), 57 deletions(-) create mode 1

[PATCH v9 11/21] dts: remote session docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 39 +- .../remote_session/remote_session.py | 130 +- dts/framework/remote_session/ssh_session.py | 16 +-- 3

[PATCH v9 12/21] dts: interactive remote session docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../interactive_remote_session.py | 36 +++ .../remote_session/interactive_shell.py | 99 +++ dts/framework/remote_session/python_shell.py | 26 -

[PATCH v9 13/21] dts: port and virtual device docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/__init__.py | 17 -- dts/framework/testbed_model/port.py | 53 +++ dts/framework/testbed_model/virtual_device.py | 17 +-

[PATCH v9 14/21] dts: cpu docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/cpu.py | 196 + 1 file changed, 144 insertions(+), 52 deletions(-) diff --git a/dts/framework/testbed_model/cpu.py b/dts/framework/t

[PATCH v9 15/21] dts: os session docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/os_session.py | 272 -- 1 file changed, 205 insertions(+), 67 deletions(-) diff --git a/dts/framework/testbed_model/os_session.py b/dts/fram

[PATCH v9 16/21] dts: posix and linux sessions docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/linux_session.py | 64 +++- dts/framework/testbed_model/posix_session.py | 81 +--- 2 files changed, 114 insertions(+), 31 deletions(-

[PATCH v9 17/21] dts: node docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/node.py | 191 +++- 1 file changed, 131 insertions(+), 60 deletions(-) diff --git a/dts/framework/testbed_model/node.py b/dts/framework/

[PATCH v9 18/21] dts: sut and tg nodes docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/sut_node.py | 230 dts/framework/testbed_model/tg_node.py | 42 +++-- 2 files changed, 176 insertions(+), 96 deletions(-) diff --git a

[PATCH v9 19/21] dts: base traffic generators docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../traffic_generator/__init__.py | 22 - .../capturing_traffic_generator.py| 45 +++ .../traffic_generator/traffic_generator.py| 33 +

[PATCH v9 20/21] dts: scapy tg docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../testbed_model/traffic_generator/scapy.py | 91 +++ 1 file changed, 54 insertions(+), 37 deletions(-) diff --git a/dts/framework/testbed_model/traffic_generator/scapy.py

[PATCH v9 21/21] dts: test suites docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/tests/TestSuite_hello_world.py | 16 +--- dts/tests/TestSuite_os_udp.py | 20 ++ dts/tests/TestSuite_smoke_tests.py | 61 -- 3 files changed,

[v2] net/af_xdp: enable a sock path alongside use_cni

With the original 'use_cni' implementation, (using a hardcoded socket rather than a configurable one), if a single pod is requesting multiple net devices and these devices are from different pools, then the container attempts to mount all the netdev UDSes in the pod as /tmp/afxdp.sock. Which means

[PATCH v4] windows/virt2phys: fix block MDL not updated

The virt2phys_translate function previously scanned existing blocks, returning the physical address from the stored MDL info if present. This method was problematic when a virtual address pointed to a freed and reallocated memory segment, potentially changing the physical address mapping. Yet, virt

Re: [PATCH v8 18/21] dts: sut and tg nodes docstring update

On Mon, Dec 04, 2023 at 11:02:21AM +0100, Juraj Linkeš wrote: > On Fri, Dec 1, 2023 at 7:06 PM Jeremy Spewock wrote: > > > > > > > > On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš > > wrote: > >> > >> Format according to the Google format and PEP257, with slight > >> deviations. > >> > >> Signed-

RE: [PATCH v1] mbuf: remove the redundant code for mbuf prefree

> > For 'rte_pktmbuf_prefree_seg' function, 'rte_mbuf_refcnt_read(m) == 1' > > and '__rte_mbuf_refcnt_update(m, -1) == 0' are the same cases where > > mbuf's refcnt value should be 1. Thus we can simplify the code and > > remove the redundant part. > > > > Furthermore, according to [1], when the

Re: [PATCH v2 0/8] fix resource leak problems

On 12/4/2023 1:57 AM, Chaoyong He wrote: > This patch series fix some resource leak problems in NFP PMD. > > --- > V2: > * Add a new commit to change the process private data. > * Fix the secondary process problem found by reviewer. > --- > > Chaoyong He (8): > net/nfp: modify the process priva

Re: [PATCH v8 0/6] Convert use of RTE_LOGTYPE_USER1 in libraries

Hello Stephen, On Mon, Aug 14, 2023 at 6:31 PM Stephen Hemminger wrote: > > Libraries in DPDK should be using dynamic logtype instead > of overloading the static logtype RTE_LOGTYPE_USER1 > > v8 - rebase and add power library > > Stephen Hemminger (6): > ip_frag: use a dynamic logtype > reord

Re: [PATCH v13 00/21] Convert static log types in libraries to dynamic types

On Mon, Aug 21, 2023 at 6:09 PM Stephen Hemminger wrote: > > This patchset removes most of the uses of static LOGTYPE's in DPDK > libraries. It starts with the easy one and goes on to the more complex ones. > > There are several options on how to treat the old static types: > leave them there, mar

Re: [PATCH v2 0/2] app/testpmd: support set RSS hash algorithm

On 12/1/2023 8:52 AM, Jie Hai wrote: > This patch set supports setting RSS hash algorithm. > > -- > v2: > 1. fix misspelling and format. > 2. fix CI compile error. > 3. add reviewed-by for patch 1. > -- > > Jie Hai (2): > ethdev: add new API to get RSS hash algorithm by name > app/testpmd: su

Re: [dpdk-dev] [PATCH] net/af_xdp: fix memzone leak in error path

On 12/1/2023 8:03 AM, Yunjian Wang wrote: > In xdp_umem_configure() allocated memzone for the 'umem', we should > free it when xsk_umem__create() call fails, otherwise it will lead > to memory zone leak. > > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > Cc: sta...@dpdk.org > > Signed

Re: [RFC v2 1/6] argparse: add argparse library

On Mon, 4 Dec 2023 07:50:43 + Chengwen Feng wrote: > + static struct rte_argparse obj = { > + .prog_name = "test-demo", > + .usage = "[EAL options] -- [optional parameters] [positional > parameters]", > + .descriptor = NULL, > + .epilog = NULL, > + .exit_on_error =

RE: [v2] net/af_xdp: enable a sock path alongside use_cni

Hi Maryam, Apologies for asking this question bit late. The UDS sock name will be afxdp.sock only and addition director is created between the sock name and the uds filepath (/tmp/afxdp_dp//afxdp.sock). As per the command " --vdev net_af_xdp0,iface=,use_cni=1,uds_path=/tmp/afxdp_dp//afxdp.sock"

[PATCH v2 1/3] node: support to add next node to ethdev Rx node

By default all packets received on ethdev_rx node is forwarded to pkt_cls node.This patch provides library support to add a new node as next node to ethdev_rx node and forward packet to new node from rx node. Signed-off-by: Rakesh Kudurumalla --- V2: Addressed comments Splitted patches to ad

[PATCH v2 2/3] app/graph: add ethdev forward command

Adds a txport to forward packet for every rxport Mapping will be used to forward packets to txport received on rxport Following commands are exposed: - ethdev forward " Signed-off-by: Rakesh Kudurumalla --- app/graph/cli.c | 1 + app/graph/ethdev.c | 62 +

[PATCH v2 3/3] app/graph: implement port forward usecase

Added portforward usecase.In this usecase packets received Rx port is forwarded to respective Tx port. Signed-off-by: Rakesh Kudurumalla --- app/graph/ethdev.c | 12 ++ app/graph/ethdev.h | 1 + app/graph/examples/l2fwd.cli |

[PATCH 00/14] support new 5760X P7 devices

While some of the patches refactor and improve existing code, this series adds support for the new 5760X P7 device family. Follow-on patches will incrementally add more functionality. Ajit Khaparde (12): net/bnxt: refactor epoch setting net/bnxt: update HWRM API net/bnxt: use the correct COS

[PATCH 01/14] net/bnxt: refactor epoch setting

Fix epoch bit setting when we ring the doorbell. Epoch bit needs to toggle alreanately from 0 to 1 everytime the ring indices wrap. Currently its value is everything but an alternating 0 and 1. Remove unnecessary field db_epoch_shift from bnxt_db_info structure. Signed-off-by: Ajit Khaparde Revi

[PATCH 03/14] net/bnxt: log a message when multicast promisc mode changes

From: Kalesh AP When the user tries to add more number of Mcast MAC addresses than supported by the port, driver puts port into Mcast promiscuous mode. It may be useful to the user to know that Mcast promiscuous mode is turned on. Similarly added a log when Mcast promiscuous mode is turned off.

[PATCH 02/14] net/bnxt: update HWRM API

Update HWRM API to version 1.10.2.158 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c |3 - drivers/net/bnxt/hsi_struct_def_dpdk.h | 1531 ++-- 2 files changed, 1429 insertions(+), 105 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drive

[PATCH 04/14] net/bnxt: use the correct COS queue for Tx

Earlier the firmware was configuring single lossy COS profiles for Tx. But now more than one profiles is possible. Identify the profile a NIC driver should use based on the profile type hint provided in queue_cfg_info. If the firmware does not set the bit to use profile type, then we will use the

[PATCH 05/14] net/bnxt: refactor mem zone allocation

Currently we are allocating memzone for VNIC attributes per VNIC. In cases where the firmware supports a higher VNIC count, this could lead to a higher number of memzone segments than supported. Move the memzone for VNIC attributes per function instead of per VNIC. Divide the memzone per VNIC as n

[PATCH 06/14] net/bnxt: add support for p7 device family

Add support for the P7 device family. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 14 -- drivers/net/bnxt/bnxt_ethdev.c | 25 + 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnx

[PATCH 07/14] net/bnxt: refactor code to support P7 devices

Refactor code to support the P7 device family. The changes include support for RSS, VNIC allocation, TPA. Remove unnecessary check to disable vector mode support for some device families. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 6 +++--- drivers/net/bnxt/bnxt_ethdev.c

[PATCH 08/14] net/bnxt: fix array overflow

In some cases the number of elements in the context memory array can exceed the MAX_CTX_PAGES and that can cause the static members ctx_pg_arr and ctx_dma_arr to overflow. Allocate them dynamically to prevent this overflow. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- driv

[PATCH 09/14] net/bnxt: add support for backing store v2

Add backing store v2 changes. The firmware supports the new backing store scheme for P7 and newer devices. To support this, the driver queries the different types of chip contexts the firmware supports and allocates the appropriate size of memory for the firmware and hardware to use. The code then

[PATCH 10/14] net/bnxt: refactor the ulp initialization

From: Kishore Padmanabha Add new method to consider all the conditions to check before the ulp could be initialized. Signed-off-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde Reviewed-by: Mike Baucom --- drivers/net/bnxt/bnxt_ethdev.c | 28 +++- 1 file changed, 23

[PATCH 11/14] net/bnxt: modify sending new HWRM commands to firmware

If the firmware fails to respond a HWRM command in a certain time, it may be because the firmware is in a bad state. Do not send any new HWRM commands in such a scenario. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt

[PATCH 12/14] net/bnxt: retry HWRM ver get if the command fails

Retry HWRM ver get if the command timesout because of PCI FLR. When the PCI driver issues an FLR during device initialization, the firmware may have to block the PXP target traffic till the FLR is complete. HWRM_VER_GET command issued during that window may time out. So retry the command again in

[PATCH 13/14] net/bnxt: cap ring resources for P7 devices

Cap the NQ count for P7 devices. Driver does not need a high NQ ring count anyway since we operate in poll mode. Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_hwrm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) dif

[PATCH 14/14] net/bnxt: add support for v3 Rx completion

P7 devices support the newer Rx completion version. This Rx completion though similar to the previous generation, provides some extra information for flow offload scenarios apart from the normal information. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 87 ++

Re: [v2] net/af_xdp: enable a sock path alongside use_cni

Hi Shibin I'm not really sure what you are suggesting, is to make an assumption on the path part where the socket resides (aka hard code it) and then try to build the full UDS path in DPDK? Yes the plugin is using constants ATM for certain parts of the UDS path, but that's not say that it's

Re: [RFC v2 1/6] argparse: add argparse library

Hi Stephen, On 2023/12/5 1:10, Stephen Hemminger wrote: > On Mon, 4 Dec 2023 07:50:43 + > Chengwen Feng wrote: > >> + static struct rte_argparse obj = { >> + .prog_name = "test-demo", >> + .usage = "[EAL options] -- [optional parameters] [positional >> parameters]", >> + .d

RE: [dpdk-dev] [PATCH] net/af_xdp: fix memzone leak in error path

> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Monday, December 4, 2023 10:10 PM > To: wangyunjian ; dev@dpdk.org > Cc: ciara.lof...@intel.com; qi.z.zh...@intel.com; xudingke > ; Lilijun (Jerry) ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/af_

[PATCH 00/18] Convert static log types in libraries to dynamic

This patchset removes most of the uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. There are several options on how to treat the old static types: leave them there, mark as deprecated, or remove them. This version removes them since ther

[PATCH 01/18] gso: don't log message on non TCP/UDP

If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Reviewed-by: Jiayu Hu Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 4 +--- lib/gso

[PATCH 02/18] eal: drop no longer used GSO logtype

The message that used this was replaced in previous patch. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/log/log.c b/lib/log/log.c index b80725a5cf24..111a40932170 100644 --- a/lib/log/log

[PATCH 03/18] log: drop unused RTE_LOGTYPE_TIMER

The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/log/log.c b/lib/log/log.c index 111a40932170..c05a7cf5a2dd 100644 --- a/lib/log/log.c +++ b/lib/log/log.c

[PATCH 04/18] efd: convert RTE_LOGTYPE_EFD to dynamic type

Replace all uses of the global logtype with a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/efd/rte_efd.c | 4 lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index dad962ce2

[PATCH 05/18] mbuf: convert RTE_LOGTYPE_MBUF to dynamic type

Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/log/log.c| 1 - lib/log/rte_log.h| 2 +- lib/mbuf/mbuf_log.h | 4 lib/mbuf/rte_mbuf.c

[PATCH 06/18] acl: convert RTE_LOGTYPE_ACL to dynamic type

Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH 07/18] examples/power: replace use of RTE_LOGTYPE_POWER

Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 21304d661873..542f76cf9664 10

[PATCH 08/18] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- examples/l3fwd-power/main.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9c0

[PATCH 09/18] power: convert RTE_LOGTYPE_POWER to dynamic type

Use dynamic log type for power library. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- lib/log/log.c| 1 - lib/log/rte_log.h| 2 +- lib/power/power_common.c | 2 ++ lib/power/power_common.h | 2 ++ lib/power/power_kvm_vm.c | 1 + lib/power/rte_

[PATCH 11/18] mempool: convert RTE_LOGTYPE_MEMPOOL to dynamic type

Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 2 ++ lib/mempool/rte_mempool.h | 8 lib/mempool/version.map | 3 +++ 5 files changed, 14 insertions

[PATCH 10/18] ring: convert RTE_LOGTYPE_RING to dynamic type

The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/log/log.c b/lib/log/log.c index 70b3a0995e2e..f0ab92a3cb59 100644

[PATCH 12/18] lpm: convert RTE_LOGTYPE_LPM to dynamic types

Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/fib/fib_log.h | 4 lib/fib/rte_fib.c | 3 +++ lib/fib/rte_

[PATCH 13/18] sched: convert RTE_LOGTYPE_SCHED to dynamic type

Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/log/log.c | 2 -- lib/log/rte_log.h | 4 ++-- lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 + lib/sched/rte_sched_log.h | 4 5 files changed, 12 insertions(+), 4 delet

[PATCH 14/18] examples/ipsec-secgw: replace RTE_LOGTYPE_PORT

Looks like some code got copy/paste in to the IPSEC gateway example from another place. Shouldn't be using RTE_LOGTYPE_PORT here. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Acked-by: Akhil Goyal Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/sa.c | 6 +++--

[PATCH 15/18] app/test: remove use of RTE_LOGTYPE_PIPELINE

Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

[PATCH 16/18] hash: mover rte_thash_gfni stubs out of header file

Having stubs in header file makes it harder to update RTE_LOG(). Also modify to only print warning once. Signed-off-by: Stephen Hemminger --- lib/hash/meson.build | 8 ++- lib/hash/rte_thash_gfni.c | 47 +++ lib/hash/rte_thash_gfni.h | 23 +--

[PATCH 17/18] hash: move rte_hash_set_alg out of header file

The code for setting algorithm for hash is not at all perf sensitive, and doing it inline has a couple of problems. First, it means that if multiple files include the header, then the initialization gets done multiple times. But also, it makes it harder to fix usage of RTE_LOG(). Despite what the

[PATCH 18/18] hash: convert RTE_LOGTYPE_HASH to dynamic type

Use dynamic type for hash and add subtypes for crc and gfni. Signed-off-by: Stephen Hemminger --- lib/hash/rte_cuckoo_hash.c | 5 + lib/hash/rte_fbk_hash.c| 5 + lib/hash/rte_thash.c | 3 +++ lib/hash/rte_thash_gfni.c | 3 +++ lib/log/log.c | 1 - lib/log/rte_log.

Re: [PATCH v3 0/7] fix race-condition of proactive error handling mode

Hi Ferruh, I notice this patchset was delegated to you, so could you take a view? Thanks. On 2023/11/6 21:11, Chengwen Feng wrote: > This patch fixes race-condition of proactive error handling mode, the > discussion thread [1]. > > [1] > http://patchwork.dpdk.org/project/dpdk/patch/20230220060

[PATCH v2 00/11] Add basic flow support for corenic firmware

Add the very basic rte_flow support for corenic firmware. --- v2: * Update the 'nfp.ini' document. * Rebase to the latest main branch. --- Chaoyong He (11): net/nfp: move some source files net/nfp: add the structures and functions for flow offload net/nfp: add the control message channel

[PATCH v2 01/11] net/nfp: move some source files

Rename module 'nfp_flow' into 'nfp_flower_flow' and move the source files into the 'flower' sub-directory. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_conntrack.h | 2 +- drivers/net/nfp/flower/nfp_flower_cmsg.h

[PATCH v2 02/11] net/nfp: add the structures and functions for flow offload

Add the structures and functions to process flow table, which is used in the rte_flow offload logics. This module is used for the CoreNIC firmware. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h | 1 + drivers/net/nfp/meson.bu

Re: [PATCH 0/7] refactor kvargs test

Hi Thomas, Could you please apply the commits 1~6 ? There commits are independent and could use for current code. Thanks On 2023/11/3 17:53, Chengwen Feng wrote: > When developing patchset [1], I found the kvargs test is hard to > understand when tried to add some testcase. > > So refactor

[PATCH v2 03/11] net/nfp: add the control message channel

Using the mailbox, which serves as the control message channel between driver and CoreNIC firmware. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build| 1 + drivers/net/nfp/nfp_net_cmsg.c | 66 ++ drivers

[PATCH v2 04/11] net/nfp: support flow API for CoreNIC firmware

Add the flow validate/create/destroy/flush API of nfp PMD with CoreNIC firmware. The flow create API construct a control cmsg and send it to firmware, then add this flow to the hash table. The flow destroy API construct a control cmsg and send it to firmware, then delete this flow from the hash t

[PATCH v2 06/11] net/nfp: support drop flow action

Add the corresponding logics to support the offload of drop action. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_flow.c | 39 +- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/

[PATCH v2 05/11] net/nfp: support Ethernet flow item

Add the corresponding data structure and logics, to support the offload of ethernet item. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_cmsg.h | 13 +++ drivers/net/nfp/nfp_net_flow.c | 169 + 2 files change

[PATCH v2 07/11] net/nfp: support IPv4 flow item

Add the corresponding data structure and logics, to support the offload of IPv4 item. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_cmsg.h | 37 ++ drivers/net/nfp/nfp_net_flow.c | 58 --

[PATCH v2 08/11] net/nfp: support IPv6 flow item

Add the corresponding data structure and logics, to support the offload of IPv6 item. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_cmsg.h | 61 +++ drivers/net/nfp/nfp_net_flow.c | 76 +++

[PATCH v2 09/11] net/nfp: support TCP/UDP/SCTP flow items

Add the corresponding logics to support the offload of TCP/UDP/SCTP items. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_flow.c | 86 ++ 1 file changed, 86 insertions(+) diff --git a/drivers/net/nfp/nfp_net_

[PATCH v2 10/11] net/nfp: support MARK flow action

Add the corresponding logics to support the offload of MARK action. Also add the related logics to parse the mark id and put into the mbuf structure, and assigned the offload flags. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- doc/guides/nics/features/nfp.ini

[PATCH v2 11/11] net/nfp: support QUEUE flow action

Add the corresponding logics to support the offload of QUEUE action. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/nfp_net_flow.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/do

Re: [PATCH v1] mbuf: remove the redundant code for mbuf prefree

在 2023/12/4 15:41, Morten Brørup 写道: From: Feifei Wang [mailto:feifei.wa...@arm.com] Sent: Monday, 4 December 2023 03.39 For 'rte_pktmbuf_prefree_seg' function, 'rte_mbuf_refcnt_read(m) == 1' and '__rte_mbuf_refcnt_update(m, -1) == 0' are the same cases where mbuf's refcnt value should be 1. Thu

[PATCH v4 0/2] config changes for cross build

The patch series implement two changes for cross build. The first one is to correct cpu instruction set. And the second one is to use a common cpu arch for cross files. --- V4: * Add patch to correct cpu instruction set for cross build. v3: * Rebase the patch to use a common cpu arch for cross fi

[PATCH v4 1/2] config: correct cpu instruction set for cross build

The platform value would be 'native' only when not cross build. Move the operation about modifying cpu_instruction_set while platform equals 'native' to the not cross build branch. Fixes: bf66003b51ec ("build: use platform for generic and native builds") Cc: sta...@dpdk.org Signed-off-by: Joyce K

[PATCH v4 2/2] config/arm: use common cpu arch for cross files

The cpu info in some cross files is inconsistent with that in SoC flags. The mismatch doesn't cause any issue because the cpu field in the cross file takes no effect and machine_args in config/arm/meson.build actually works. Use a common one in cross files to remove any confusion. Reported-by: Hon

[PATCH v1] net/memif: fix segfault with Tx burst larger than 255

There will be a segfault when tx burst size is larger than 256. This is because eth_memif_tx uses an index i which is uint8_t to count transmitted nb_pkts. Extend i to uint16_t, the same size as nb_pkts. Fixes: b5613c8f9d0a ("net/memif: add a Tx fast path") Cc: sta...@dpdk.org Reported-by: Liangx

[PATCH v3 1/3] node: support to add next node to ethdev Rx node

By default all packets received on ethdev_rx node is forwarded to pkt_cls node.This patch provides library support to add a new node as next node to ethdev_rx node and forward packet to new node from rx node. Signed-off-by: Rakesh Kudurumalla --- V3: Resolve compilation Issue lib/node/ethdev_ct

  1   2   >