Re: [PATCH] ethdev: add extension keyword to statement expression macro

10/11/2023 18:22, Ferruh Yigit: > On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: > > add missing __extension__ keyword to macros using gcc statement > > expression extension. > > > > Signed-off-by: Tyler Retzlaff > > > > Acked-by: Ferruh Yigit > > > It seems there are a few more usage not marke

Re: [PATCH] ethdev: add extension keyword to statement expression macro

11/11/2023 00:25, Ferruh Yigit: > On 11/10/2023 8:49 PM, Tyler Retzlaff wrote: > > On Fri, Nov 10, 2023 at 05:22:52PM +, Ferruh Yigit wrote: > >> On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: > >>> add missing __extension__ keyword to macros using gcc statement > >>> expression extension. > >>> >

[PATCH v1 1/3] net/axgbe: packet size doesn't exceed the configured MTU

Signed-off-by: Jesna K E --- drivers/net/axgbe/axgbe_ethdev.c | 6 -- drivers/net/axgbe/axgbe_rxtx.c | 20 ++-- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index 3717166384..e12ee3e17a 1

[PATCH v1 2/3] net/axgbe: correct API call when offload enabled

Fixes: 9963b5131af8 ("net/axgbe: support multi-process") Signed-off-by: Jesna K E --- drivers/net/axgbe/axgbe_ethdev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index e12ee3e17a..e1cb60c1c3 1

[PATCH v1 3/3] net/axgbe: support TSO Implementation

Signed-off-by: Jesna K E --- drivers/net/axgbe/axgbe_common.h | 11 + drivers/net/axgbe/axgbe_dev.c | 19 ++ drivers/net/axgbe/axgbe_ethdev.c | 1 + drivers/net/axgbe/axgbe_ethdev.h | 1 + drivers/net/axgbe/axgbe_rxtx.c | 305 +++-- dri

BUILD bug hidden in SFC driver.

While examining the use of VLA in DPDK, ran into a bug in sfc driver. If DPDK is built with -Wvla, then the RTE_BUILD_BUG_ON() macro won't work as written. Experimenting with a better more portable version of that macro as: #define RTE_BUILD_BUG_ON(e) _Static_assert(!(e), #e) revealed th

[RFC] eal: use _Static_assert() for RTE_BUILD_BUG_ON

The method of doing sizeof a bad array element was an interesting hack but it has a couple of problems. First, it won't work if VLA checking is enabled. It doesn't enforce that the expression is constant. Replace that with the _Static_assert builtin available in Gcc, Clang, and MSVC. Signed-off-b

Re: BUILD bug hidden in SFC driver.

On Sat, 11 Nov 2023 08:56:34 -0800 Stephen Hemminger wrote: > While examining the use of VLA in DPDK, ran into a bug in sfc driver. > > If DPDK is built with -Wvla, then the RTE_BUILD_BUG_ON() macro won't work > as written. Experimenting with a better more portable version of that macro > as: >

RE: [RFC] eal: use _Static_assert() for RTE_BUILD_BUG_ON

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, 11 November 2023 18.22 > > The method of doing sizeof a bad array element was an interesting > hack but it has a couple of problems. First, it won't work if > VLA checking is enabled. It doesn't enforce that the expres

Re: [PATCH v4] eventdev: ensure 16-byte alignment for events

On Fri, 6 Oct 2023 11:29:32 +0100 Bruce Richardson wrote: > diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c > index 95373bbaad..adc9751cef 100644 > --- a/lib/eventdev/rte_eventdev.c > +++ b/lib/eventdev/rte_eventdev.c > @@ -9,6 +9,7 @@ > #include > #include > #include

[PATCH v3 0/2] example/l3fwd: relax l3fwd rx RSS/Offload if needed

This series try to relax l3fwd rx RSS/Offload mode requirement if they are not supported by underlying hw or virtual devices, there is an option named relax_rx_mode added to enable this option. Trevor Tao (2): examples/l3fwd: relax RSS requirement with option examples/l3fwd: relax the Offload

[PATCH v3 1/2] examples/l3fwd: relax RSS requirement with option

Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS by default, but some hw and/or virtual interface does not support the RSS and offload mode presupposed, e.g., some virtio interfaces in the cloud don't support RSS and the error msg may like: virtio_dev_configure(): RSS support requested bu

[PATCH v3 2/2] examples/l3fwd: relax the Offload requirement

Now the port Rx offload mode is set to RTE_ETH_RX_OFFLOAD_CHECKSUM by default, but some hw and/or virtual interface does not support the offload mode presupposed, e.g., some virtio interfaces in the cloud may only partly support RTE_ETH_RX_OFFLOAD_UDP_CKSUM/ RTE_ETH_RX_OFFLOAD_TCP_CKSUM, but not RT

RE: [PATCH] net/mlx5: fix checking for send to kernel action

Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Friday, November 3, 2023 5:26 PM > To: Suanming Mou ; Slava Ovsiienko > ; Matan Azrad ; Ori Kam > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: fix checking for send to kernel action > > This patch adds the