10/11/2023 18:22, Ferruh Yigit: > On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: > > add missing __extension__ keyword to macros using gcc statement > > expression extension. > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > > > Acked-by: Ferruh Yigit <ferruh.yi...@amd.com> > > > It seems there are a few more usage not marked in lib folder [1], and > more including drivers.
Please let's mark all at once. > Is this compiler extension causing any problem for the Windows build or > MSVC toolchain? I have the same question: is __extension__ supported in MSVC? > [1] > $ grep -r '({' lib/ | grep -v __extension__ > lib/port/rte_port_source_sink.c:({ > lib/port/rte_port_source_sink.c:({ > lib/pipeline/rte_swx_pipeline_internal.h:({ > lib/pipeline/rte_pipeline.c: ({ (p)->n_pkts_ah_drop = > lib/pipeline/rte_pipeline.c: ({ (counter) += (p)->n_pkts_ah_drop; > lib/pipeline/rte_pipeline.c: ({ (p)->pkts_drop_mask = > lib/pipeline/rte_pipeline.c:({ > lib/ethdev/rte_mtr.c:({ > lib/ethdev/rte_mtr.c:({ > lib/ethdev/rte_tm.c:({