[PATCH v2] lpm: improve performance with copious IPv4 peering routes

2023-11-09 Thread Warrington, Jeffrey
Minimize the performance impact of large numbers of BGP peering routes by updating LPM's IPv4 code to use a hash like the IPv6 code. Co-authored-by: Julien Charbon Signed-off-by: Julien Charbon Signed-off-by: Jeff Warrington Co-authored-by: Nicolas Witkowski Signed-off-by: Nicolas Witkowski C

[PATCH v3 0/1] dts: Add the ability to bind ports to drivers

2023-11-09 Thread jspewock
From: Jeremy Spewock Changes in this version address the comments on the last and change what was necessary. Now, we no longer modprobe the driver, but the decision was made to still make driver binding exclusive to the SUT for the time being due to the uncertainty of what binding drivers on the

[PATCH v3 1/1] dts: bind to DPDK driver before running test suites

2023-11-09 Thread jspewock
From: Jeremy Spewock Modifies the current process so that we bind to os_driver_for_dpdk from the configuration file before running test suites and bind back to the os_driver afterwards. This allows test suites to assume that the ports are bound to a DPDK supported driver or bind to either driver

[PATCH v2 0/7] dts: Port scatter suite over

2023-11-09 Thread jspewock
From: Jeremy Spewock This patch ports over the functionality of the scatter testing suite from "old dts." The idea of the suite is the coverage it provides should be parity with the ethdev testing suite in old DTS. This new version is just because of the update to the patch which it depends on.

[PATCH v2 1/7] dts: Add scatter test suite

2023-11-09 Thread jspewock
From: Jeremy Spewock This test suite provides testing the support of scattered packets by Poll Mode Drivers using testpmd. It incorporates 5 different test cases which test the sending and receiving of packets with lengths that are less than the mbuf data buffer size, the same as the mbuf data bu

[PATCH v2 2/7] dts: add waiting for port up in testpmd

2023-11-09 Thread jspewock
From: Jeremy Spewock Added a method within the testpmd interactive shell that polls the status of ports and verifies that the link status on a given port is "up." Polling will continue until either the link comes up, or the timeout is reached. Signed-off-by: Jeremy Spewock --- .../remote_sessi

[PATCH v2 3/7] dts: add scatter to the yaml schema

2023-11-09 Thread jspewock
From: Jeremy Spewock Allow for scatter to be specificed in the configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/conf

[PATCH v2 5/7] dts: add optional packet filtering to scapy sniffer

2023-11-09 Thread jspewock
From: Jeremy Spewock Added the options to filter out LLDP and ARP packets when sniffing for packets with scapy. This was done using BPF filters to ensure that the noise these packets provide does not interfere with test cases. Signed-off-by: Jeremy Spewock --- dts/framework/test_suite.py

[PATCH v2 4/7] dts: allow passing parameters into interactive apps

2023-11-09 Thread jspewock
From: Jeremy Spewock Modified interactive applications to allow for the ability to pass parameters into the app on start up. Also modified the way EAL parameters are handled so that the trailing "--" separator is added be default after all EAL parameters. Signed-off-by: Jeremy Spewock --- dts/

[PATCH v2 6/7] dts: add pci addresses to EAL parameters

2023-11-09 Thread jspewock
From: Jeremy Spewock Added allow list to the EAL parameters created in DTS to ensure that only the relevent PCI devices are considered when launching DPDK applications. Signed-off-by: Jeremy Spewock --- dts/framework/testbed_model/sut_node.py | 9 + 1 file changed, 9 insertions(+) dif

[PATCH v2 7/7] dts: allow configuring MTU of ports

2023-11-09 Thread jspewock
From: Jeremy Spewock Adds methods in both os_session and linux session to allow for setting MTU of port interfaces in an OS agnostic way. Signed-off-by: Jeremy Spewock --- dts/framework/remote_session/linux_session.py | 7 +++ dts/framework/remote_session/os_session.py| 9 + 2

[Bug 1308] meson_tests/driver:link_bonding_rssconf_autotest test failed

2023-11-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1308 Jiale Song (songx.ji...@intel.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|

[PATCH v2] examples/ethtool: fix pause configuration

2023-11-09 Thread Huisong Li
Currently, the pause command in ethtool to enable Rx/Tx pause has the following problem. Namely, Assume that the device supports flow control auto-negotiation to set pause parameters, which will the device that does not support flow control auto-negotiation fails to run this command. This patch su

[PATCH v2 3/6] net/hns3: refactor VF mailbox message struct

2023-11-09 Thread Jie Hai
From: Dengdui Huang The data region in VF to PF mbx message command is used to communicate with PF driver. And this data region exists as an array. As a result, some complicated feature commands, like setting promisc mode, map/unmap ring vector and setting VLAN id, have to use magic number to set

[PATCH v2 1/6] net/hns3: fix sync mailbox failure forever

2023-11-09 Thread Jie Hai
From: Dengdui Huang Currently, hns3 VF driver uses the following points to match the response and request message for the mailbox synchronous message between VF and PF. 1. req_msg_data which is consist of message code and subcode, is used to match request and response. 2. head means the number

[PATCH v2 4/6] net/hns3: refactor PF mailbox message struct

2023-11-09 Thread Jie Hai
From: Dengdui Huang The data region in PF to VF mbx message command is used to communicate with VF driver. And this data region exists as an array. As a result, some complicated feature commands, like mailbox response, link change event, close promisc mode, reset request and update pvid state, ha

[PATCH v2 0/6] net/hns3: fix and refactor some codes

2023-11-09 Thread Jie Hai
This patchset fixes the failure on sync mailbox and refactors some codes on mailbox, also replace gcc builtin __atomic_xxx with rte_atomic_xxx. -- v2: 1. fix misspelling error in commit log and codes. 2. replace __atomic_xxx with rte_atomic_xxx. -- Dengdui Huang (5): net/hns3: fix sync mailbox

[PATCH v2 5/6] net/hns3: refactor send mailbox function

2023-11-09 Thread Jie Hai
From: Dengdui Huang The 'hns3_send_mbx_msg' function has following problem: 1. the name is vague, missing caller indication. 2. too many input parameters because the filling messages are placed in commands the send command. Therefore, a common interface is encapsulated to fill in the mailbox

[PATCH v2 2/6] net/hns3: use stdatomic API

2023-11-09 Thread Jie Hai
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_cmd.c | 22 +++- drivers/net/hns3/hns3_dcb.c | 3 +- drivers/net/hns3/hns3_ethdev.c| 51 --

[PATCH v2 6/6] net/hns3: refactor handle mailbox function

2023-11-09 Thread Jie Hai
From: Dengdui Huang The mailbox messages of the PF and VF are processed in the same function. The PF and VF call the same function to process the messages. This code is excessive coupling and isn't good for maintenance. Therefore, this patch separates the interfaces that handle PF mailbox message

Re: [PATCH 0/5] net/hns3: fix and refactor mailbox code

2023-11-09 Thread Jie Hai
On 2023/11/10 2:50, Ferruh Yigit wrote: On 11/8/2023 3:44 AM, Jie Hai wrote: This patchset fixes failure on sync mailbox and refactors some codes on mailbox. Dengdui Huang (5): net/hns3: fix sync mailbox failure forever net/hns3: refactor VF mailbox message struct net/hns3: refactor PF

[PATCH 03/16] bus/fslmc: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: e67a61614d0b ("bus/fslmc: support device iteration") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/fslmc/fslmc_bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bu

[PATCH 00/16] verify strdup return value

2023-11-09 Thread Chengwen Feng
This patchset mainly fix the return value of strdup not checked which may lead to segment fault. It also include two commits which fix memory leak of strdup. Chengwen Feng (16): eal: verify strdup return value bus/dpaa: verify strdup return value bus/fslmc: verify strdup return value bus/v

[PATCH 01/16] eal: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup() return value logic. Fixes: 293c53d8b23c ("eal: add telemetry callbacks") Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- lib/eal/common/eal_common_options.c | 24 ++-- lib/eal/linux/eal_

[PATCH 04/16] bus/vdev: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/vdev/vdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index 7974b2

[PATCH 02/16] bus/dpaa: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/dpaa/dpaa_bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index e5

[PATCH 07/16] net/failsafe: fix memory leak when parse args

2023-11-09 Thread Chengwen Feng
Should free the memory which allocated by strdup(). Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe

[PATCH 08/16] net/nfp: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 3d21da66c06b ("net/nfp: create security session") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/nfp/nfp_ipsec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c inde

[PATCH 09/16] app/dumpcap: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/dumpcap/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 64294bbfb3

[PATCH 05/16] dma/idxd: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: e888bb1278c6 ("dma/idxd: add bus device probing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/dma/idxd/idxd_bus.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/dma/idxd/idxd_bus.c b/drivers/dm

[PATCH 06/16] event/cnxk: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 38c2e3240ba8 ("event/cnxk: add option to control SSO HWGRP QoS") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/event/cnxk/cnxk_eventdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/driv

[PATCH 11/16] app/test: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test/process.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test/process.h b/app/test/process.h index af7bc3e0de..c576c42349

[PATCH 12/16] app/test-crypto-perf: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-crypto-perf/cperf_options_parsing.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-crypto-perf/cp

[PATCH 15/16] examples/qos_sched: fix memory leak when parse args

2023-11-09 Thread Chengwen Feng
Should free the memory which allocated by strdup(). Fixes: 035b6a4f4bba ("examples/qos_sched: fix out-of-bounds option parsing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- examples/qos_sched/args.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/qos_sch

[PATCH 14/16] app/testpmd: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 912b

[PATCH 16/16] examples/vhost: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- examples/vhost/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index c

[PATCH 13/16] app/test-dma-perf: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-dma-perf/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c inde

[PATCH 10/16] app/pdump: verify strdup return value

2023-11-09 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/pdump/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 7a1c7bdf60..a9205e130b 10

RE: [PATCH 08/16] net/nfp: verify strdup return value

2023-11-09 Thread Chaoyong He
> [You don't often get email from fengcheng...@huawei.com. Learn why this > is important at https://aka.ms/LearnAboutSenderIdentification ] > > Add verify strdup return value logic. > > Fixes: 3d21da66c06b ("net/nfp: create security session") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen F

[PATCH v3] app/testpmd: fix indirect action list ID size

2023-11-09 Thread Gregory Etelson
Testpmd maps indirect action lists handlers into application IDs. Testpmd API defines indirect IDs as 32 bits values. The patch fixes indirect IDs size in ACTION_INDIRECT_LIST_HANDLE and ACTION_INDIRECT_LIST_CONF tokens Fixes: 72a3dec7126f ("ethdev: add indirect flow list action") Signed-off-by:

Re: [EXT] [PATCH] test/eventdev: avoid configuring port or queue twice

2023-11-09 Thread Jerin Jacob
On Wed, Nov 8, 2023 at 12:22 AM Pavan Nikhilesh Bhagavatula wrote: > > > > In the basic sanity tests of eventdev for queue and port setup, queue 0 > > was configured separately before running a loop to configure the rest of > > the queues. This loop started from 0, so reconfigured queue 0, and a >

Re: [PATCH] event/dlb2: fix missing queue ordering capability flag

2023-11-09 Thread Jerin Jacob
On Thu, Nov 9, 2023 at 11:14 PM Bruce Richardson wrote: > > The dlb2 driver did not advertise the fact that events could be enqueued > to it for any queues, not just those in numerical sequence. Add the > missing bit to the capabilities flag returned from the info_get() > function. > > Fixes: d39e

Re: [PATCH v2] lpm: improve performance with copious IPv4 peering routes

2023-11-09 Thread David Marchand
Hello Jeffrey, On Fri, Nov 10, 2023 at 12:11 AM Warrington, Jeffrey wrote: > > Minimize the performance impact of large numbers of BGP peering > routes by updating LPM's IPv4 code to use a hash like the IPv6 code. > > Co-authored-by: Julien Charbon > Signed-off-by: Julien Charbon > Signed-off-b

<    1   2