Hello Jeffrey, On Fri, Nov 10, 2023 at 12:11 AM Warrington, Jeffrey <jwarring...@verisign.com> wrote: > > Minimize the performance impact of large numbers of BGP peering > routes by updating LPM's IPv4 code to use a hash like the IPv6 code. > > Co-authored-by: Julien Charbon <jchar...@verisign.com> > Signed-off-by: Julien Charbon <jchar...@verisign.com> > Signed-off-by: Jeff Warrington <jwarring...@verisign.com> > Co-authored-by: Nicolas Witkowski <nwitkow...@verisign.com> > Signed-off-by: Nicolas Witkowski <nwitkow...@verisign.com> > Co-authored-by: Rohit Gupta <rogu...@verisign.com> > Signed-off-by: Rohit Gupta <rogu...@verisign.com>
Thanks for the patch. Cc: lpm maintainers. Don't forget to Cc: maintainers when sending patches. You can simply pass --cc-cmd devtools/get-maintainer.sh to git send-email. Can you provide performance numbers? After this patch, LPM and LPM6 implementations become close. Did you consider refactoring so that LPM and LPM6 can share more code? > --- > lib/lpm/rte_lpm.c | 306 ++++++++++++++++++++++------------------------ > lib/lpm/rte_lpm.h | 6 + Seeing how no other .c is touched and no exposed symbol use it, exposing the rte_lpm_rule_key structure in the public API is unneeded. > 2 files changed, 149 insertions(+), 163 deletions(-) -- David Marchand
