Ah - thanks Konstantin - I will go back and review.
Regards,
Garry.
On Tue, Oct 31, 2023 at 5:53 PM Konstantin Ananyev
wrote:
>
>
> Hi Garry,
>
> > Hi Konstantin, Akhil,
> >
> > The patch is based on an issue I encountered when using the CPU_CRYPTO
> > support - I was having problems where the
On 2023/11/1 21:42, Ferruh Yigit wrote:
On 11/1/2023 7:40 AM, Jie Hai wrote:
Add the command "show port X rss-hash algorithm" to display
the RSS hash algorithms of port X. An example is shown:
testpmd> show port 0 rss-hash algorithm
RSS algorithm:
toeplitz
Signed-off-by: Jie Hai
Acked-by:
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Thursday, 2 November 2023 02.05
>
> The first set of conversions missed the long 'l' versions of the
> builtins that were being used. This series completes the conversion
> of remaining libraries from __builtin_ctzl and __builtin
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Thursday, 2 November 2023 04.04
>
> Replace use of __atomic_thread_fence with __rte_atomic_thread_fence.
>
> It may be appropriate to use rte_atomic_thread_fence instead but it
> will be up to maintainers to evaluate and make th
In rte_eth_dev_rss_hash_conf_get(), the "rss_key_len" should be
greater than or equal to the "hash_key_size" which get from
rte_eth_dev_info_get() API. And the "rss_key" should contain at
least "hash_key_size" bytes. If these requirements are not met,
the query unreliable.
In rte_eth_dev_rss_hash_
The hns3 driver should reports RSS hash algorithm capability
to support updating RSS hash algorithm by
rte_eth_dev_rss_hash_update() or rte_eth_dev_configure().
Signed-off-by: Jie Hai
Acked-by: Huisong Li
Acked-by: Chengwen Feng
---
drivers/net/hns3/hns3_common.c | 4
1 file changed, 4 in
This patchset is to support setting and querying RSS algorithms.
For this purpose, field "rss_algo_capa" is added to ``rte_eth_dev_info``
and field "algorithm" is added to ``rte_eth_rss_conf``.
The drivers should reports their "rss_algo_capa" if they support
updating RSS algorithms. Otherwise, the
Command show-port should show RSS info (rss_key, len and rss_hf),
However, the information is shown only when rss_conf.rss_key is not
NULL. Since no memory is allocated for rss_conf.rss_key, rss_key
will always be NULL and the rss_info will never show. This patch
fixes it.
Fixes: 8a37f37fc243 ("ap
From: Huisong Li
Support setting and querying RSS hash function by ethdev ops.
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
Signed-off-by: Jie Hai
Acked-by: Chengwen Feng
---
drivers/net/hns3/hns3_rss.c | 47 +
1 file changed, 27 insertions(+), 2
This patch splits the length and value of RSS key into two parts,
removes spaces between RSS keys, and adds line breaks between RSS
key and RSS hf.
Before the adjustment, RSS info is shown as:
- RSS
-- RSS len 40 key (hex): 6d 5a 56 da 25 5b e c2 41 67 \
25 3d 43 a3 8f b0
Currently, rte_eth_rss_conf supports configuring and querying
RSS hash functions, rss key and it's length, but not RSS hash
algorithm.
The structure ``rte_eth_dev_info`` is extended by adding a new
field "rss_algo_capa". Drivers are responsible for reporting this
capa and configurations of RSS has
Display RSS hash algorithm with command show-port as below.
- RSS info
-- hash algorithm : toeplitz
Signed-off-by: Jie Hai
Signed-off-by: Dongdong Liu
Acked-by: Reshma Pattan
Acked-by: Huisong Li
Acked-by: Chengwen Feng
---
app/proc-info/main.c | 2 ++
1 file changed, 2 insertion
This patch adds new API rte_eth_dev_rss_algo_name() to get
name of a RSS algorithm and document it.
Signed-off-by: Jie Hai
Acked-by: Huisong Li
Acked-by: Chengwen Feng
---
app/test-pmd/config.c | 19 +--
doc/guides/rel_notes/release_23_11.rst | 5 +
lib/et
Add the command "show port X rss-hash algorithm" to display
the RSS hash algorithms of port X. An example is shown:
testpmd> show port 0 rss-hash algorithm
RSS algorithm:
toeplitz
Signed-off-by: Jie Hai
Acked-by: Huisong Li
Acked-by: Chengwen Feng
---
app/test-pmd/cmdline.c
From: Wenjing Qiao
Parse JSON file and generate rules that instruct PMD to map an
RTE_FLOW_ACTION_TYPE_PROG to a low-level FXP representation, the
matching follows below guidelines.
Use rte_flow_action_prog->name to match the name of a P4 action
type when provided in the JSON file. In cases wher
Hi Chengwen,
Thanks for the review and feedback. I will send v2 with suggested changes.
Thanks,
Amit Shukla
> -Original Message-
> From: fengchengwen
> Sent: Thursday, November 2, 2023 7:37 AM
> To: Amit Prakash Shukla ; Kevin Laatz
> ; Bruce Richardson
> Cc: dev@dpdk.org; Jerin Jacob
From: Wenjing Qiao
Refine vxlan encap content of all protocol headers with default
configuration.
Fixes: 6cc97c9971d7 ("net/cpfl: build action mapping rules from JSON")
Signed-off-by: Wenjing Qiao
---
drivers/net/cpfl/cpfl_flow_parser.c | 63 -
drivers/net/cpfl/cpf
Ruifeng Wang, Nov 01, 2023 at 08:20:
Telemetry iterates on lcore ID to collect info of a specific lcore.
Since only one lcore is processed at a time, the iteration can stop
when a matching lcore is found.
Fixes: f2b852d909f9 ("eal: add lcore info in telemetry")
Cc: rja...@redhat.com
Cc: sta...@d
On 10/31/23 15:57, Thomas Monjalon wrote:
When converting to rte_thread API, the SCHED_RR policy
has been translated into RTE_THREAD_PRIORITY_REALTIME_CRITICAL.
But SCHED_RR was not effective prior to this conversion because
PTHREAD_EXPLICIT_SCHED attribute was missing initially.
Using the de
Hi Jie,
What issue did you observe which the following patch resolves? Can you please
provide steps.
Because we are setting the respective queue state in
octeontx_dev_tx_queue_start/stop() ethdev_ops
Thanks
Harman
> -Original Message-
> From: Jie Hai
> Sent: Friday, September 8, 2023
Hello,
While looking at Seastar, I see it uses this patch on top of DPDK:
build: add meson options of max_memseg_lists
RTE_MAX_MEMSEG_LISTS = 128 is not enough for high-memory machines,
in our case, we need to increase it to 8192.
so add an option so user can over
On Tue, Oct 31, 2023 at 1:10 PM Yoan Picchi wrote:
>
> On 8/31/23 11:04, Juraj Linkeš wrote:
> > WIP: only one module is reformatted to serve as a demonstration.
> >
> > The google format is documented here [0].
> >
> > [0]: https://google.github.io/styleguide/pyguide.html
> >
> > Signed-off-by: J
Since the representor port needs to access the resource of the
associated DCF when it is closing. Therefore, all the representor
port should be closed first, and then close the associated DCF port.
If the DCF port is closed before the representor port on PMD exit.
This will result in accessing fre
On Wed, Nov 01, 2023 at 07:05:54PM +, Sevincer, Abdullah wrote:
>
> >++ PCIe maintainers.
>
> >+I will leave this up to @David Marchand / @Thomas as this patch has common
> >code changes and needs to come via main tree.
>
> >+Also in this case, The comment was given very early(Back in June
> -Original Message-
> From: Fengchengwen
> Sent: Friday, October 20, 2023 11:08 AM
> To: tho...@monjalon.net; ferruh.yi...@amd.com; Konstantin Ananyev
> ;
> ajit.khapa...@broadcom.com; haijie ; Zhuangyuzeng (Yisen)
>
> Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru;
> kalesh-anakk
> Use rte_eth_fp_ops_setup() instead of directly manipulating
> rte_eth_fp_ops variable.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Chengwen Feng
> ---
> drivers/net/bnxt/bnxt_cpr.c| 5 +
> drivers/net/bnxt/bnxt_ethdev.c | 5 +
> 2 files changed, 2 insertions(+), 8 deletions(-)
>
02/11/2023 11:23, Bruce Richardson:
> On Wed, Nov 01, 2023 at 07:05:54PM +, Sevincer, Abdullah wrote:
> >
> > >++ PCIe maintainers.
> >
> > >+I will leave this up to @David Marchand / @Thomas as this patch has
> > >common code changes and needs to come via main tree.
> >
> > >+Also in this
This change prevents certain configuration functions from being
called by the secondary process.
Signed-off-by: Arkadiusz Kusztal
---
v2:
- fixed incorrect function call
- rephrased comments
v3:
- fixed incorrect debug message
drivers/common/qat/qat_device.c | 115 +++---
Release status meeting minutes 2023-11-02
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* ARM
* Debian/Microsoft
* Intel
* Marvell
* Nvidia
* Red Hat
Release Dates
-
The following are the current w
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Thursday, November 2, 2023 9:42 AM
> To: dev@dpdk.org
> Cc: gak...@marvell.com; Ji, Kai ; Power, Ciara
> ; Kusztal, ArkadiuszX
>
> Subject: [PATCH v3] common/qat: limit configuration to the primary process
>
> This change preven
Dear Slava,
Thank you for looking at the patch. With the original code, I saw that
the application spent literally hours in this function during program
start up, if tens of gigabytes of GPU memory are registered. This was
due to qsort being invoked for every new added item (to keep the list
The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum
Rx buffer size supported by hardware. Actually, some engines also have
the maximum Rx buffer specification, like, hns3.
If mbuf data room size in mempool is greater then the maximum Rx buffer
size supported by HW, the data size
This patch reports the maximum buffer size hardware supported.
Signed-off-by: Huisong Li
Acked-by: Chengwen Feng
---
drivers/net/hns3/hns3_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c
index 9327adbdc1..4b0e38cf67 10
The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum
Rx buffer size supported by hardware. Actually, some engines also have
the maximum Rx buffer specification, like, hns3, i40e and so on. If mbuf
data room size in mempool is greater then the maximum Rx buffer size
per descriptor
Add maximum Rx buffer size display.
Signed-off-by: Huisong Li
Acked-by: Chengwen Feng
---
app/test-pmd/config.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index b9fdb7e8f1..2ac6f15773 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/
On 2023/11/2 17:59, Harman Kalra wrote:
Hi Jie,
What issue did you observe which the following patch resolves? Can you please
provide steps.
Because we are setting the respective queue state in
octeontx_dev_tx_queue_start/stop() ethdev_ops
Thanks
Harman
Hi, Harman,
If dev_start are called,
https://bugs.dpdk.org/show_bug.cgi?id=1307
Bug ID: 1307
Summary: mlx5_net: probe of PCI device 4790:00:02.0 aborted
after encountering an error: Operation not permitted
Product: DPDK
Version: 23.11
Hardware: x86
gcc [1] generates warning [2] about calloc usage, because calloc
parameter order is wrong, fixing it by replacing parameters.
[1]
gcc (GCC) 14.0.0 20231102 (experimental)
[2]
Compiling C object .../pipeline_rte_swx_pipeline_spec.c.o
.../rte_swx_pipeline_spec.c: In function ‘pipeline_spec_parse
gcc [1] generates warning [2] about calloc usage, because calloc
parameter order is wrong, fixing it by replacing parameters.
[1]
gcc (GCC) 14.0.0 20231102 (experimental)
[2]
Compiling C object .../net_nfp_nfpcore_nfp_mutex.c.o
.../net/nfp/nfpcore/nfp_mutex.c: In function ‘nfp_cpp_mutex_alloc
On 11/2/2023 8:20 AM, Jie Hai wrote:
> This patchset is to support setting and querying RSS algorithms.
> For this purpose, field "rss_algo_capa" is added to ``rte_eth_dev_info``
> and field "algorithm" is added to ``rte_eth_rss_conf``.
> The drivers should reports their "rss_algo_capa" if they sup
On 11/2/2023 5:37 AM, Chaoyong He wrote:
> From: Qin Ke
>
> Add support of dynamic config of allmulticast mode for NFP
> by adding enable and disable callback function.
>
> Signed-off-by: Qin Ke
> Reviewed-by: Chaoyong He
>
Applied to dpdk-next-net/main, thanks.
Hi,
> -Original Message-
> From: Rongwei Liu
> Sent: Wednesday, November 1, 2023 6:44 AM
> To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; Suanming Mou
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
>
> Subject: [PATCH v4 00/13] support IPv6 push remove action
>
> Support IPv6
On 11/2/2023 2:23 AM, Chaoyong He wrote:
> Up to now, the NFP card using only one PF (or BDF) for multiple physical
> ports, this force the PMD import the difference logic for 'PF' and
> 'physical port'. Which is not easy to understand and also not compatible
> with some DPDK applications.
> This p
On 11/1/2023 6:02 PM, Stephen Hemminger wrote:
> Rebuild with commit
> c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31)
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/tap/tap_bpf_insns.h | 2959 ---
> 1 file changed, 1503 insertions(+),
On 11/1/2023 6:02 PM, Stephen Hemminger wrote:
> Update the documentation and tools to build the BPF program used by
> tap device. And apply fix to the RSS algorithm to correctly
> handle non-IP protocols.
>
> v6 - cosmetic improvements to extract process
> add better boilerplate and fix pyth
On 11/1/2023 6:02 PM, Stephen Hemminger wrote:
> Update the documentation and tools to build the BPF program used by
> tap device. And apply fix to the RSS algorithm to correctly
> handle non-IP protocols.
>
> v6 - cosmetic improvements to extract process
> add better boilerplate and fix pyth
On Thu, Nov 02, 2023 at 08:39:04AM +0100, Morten Brørup wrote:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Thursday, 2 November 2023 02.05
> >
> > The first set of conversions missed the long 'l' versions of the
> > builtins that were being used. This series completes
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Thursday, 2 November 2023 16.28
>
> On Thu, Nov 02, 2023 at 08:39:04AM +0100, Morten Brørup wrote:
> > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > > Sent: Thursday, 2 November 2023 02.05
> > >
> > > The first
On Thu, Nov 02, 2023 at 04:33:57PM +0100, Morten Brørup wrote:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Thursday, 2 November 2023 16.28
> >
> > On Thu, Nov 02, 2023 at 08:39:04AM +0100, Morten Brørup wrote:
> > > > From: Tyler Retzlaff [mailto:roret...@linux.microso
On 11/2/2023 12:16 PM, Huisong Li wrote:
> Add maximum Rx buffer size display.
>
I think there is a value to show what is the intended usage of this new
field in application level,
that is why what do you think to use testpmd?
Testpmd can be updated to check if mbuf data size is bigger than devi
On Fri, Oct 20, 2023 at 3:11 AM Chengwen Feng wrote:
>
> If set data path functions to dummy functions before reports error
> recovering event, there maybe a race-condition with data path threads,
> this patch fixes it by setting data path functions to dummy functions
> only after reports such eve
On Thu, Nov 2, 2023 at 3:35 AM Konstantin Ananyev
wrote:
>
>
>
> > Use rte_eth_fp_ops_setup() instead of directly manipulating
> > rte_eth_fp_ops variable.
> >
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Chengwen Feng
> > ---
> > drivers/net/bnxt/bnxt_cpr.c| 5 +
> > drivers/net/bnxt/
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Thursday, 2 November 2023 17.24
>
> On 11/2/2023 1:59 AM, lihuisong (C) wrote:
> >
> > 在 2023/11/2 0:08, Stephen Hemminger 写道:
> >> On Wed, 1 Nov 2023 10:36:07 +0800
> >> "lihuisong (C)" wrote:
> >>
> Do we need to report this size?
On 11/2/2023 12:16 PM, Huisong Li wrote:
> The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum
> Rx buffer size supported by hardware. Actually, some engines also have
> the maximum Rx buffer specification, like, hns3, i40e and so on. If mbuf
> data room size in mempool is greate
On Thu, 2 Nov 2023 15:13:57 +
Ferruh Yigit wrote:
> On 11/1/2023 6:02 PM, Stephen Hemminger wrote:
> > Rebuild with commit
> > c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31)
> >
> > Signed-off-by: Stephen Hemminger
> > ---
> > drivers/net/tap/tap_bpf_insns.h | 2959 +
On 11/2/2023 4:51 PM, Morten Brørup wrote:
>> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
>> Sent: Thursday, 2 November 2023 17.24
>>
>> On 11/2/2023 1:59 AM, lihuisong (C) wrote:
>>>
>>> 在 2023/11/2 0:08, Stephen Hemminger 写道:
On Wed, 1 Nov 2023 10:36:07 +0800
"lihuisong (C)" wrote
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Thursday, 2 November 2023 15.57
>
> Hi all,
>
> looking to start a discussion and get some input here.
>
> There are a number of our examples in DPDK which still track core usage
> via
> a 64-bit bitmask, and, as such, cannot r
On Thu, 2 Nov 2023 15:11:10 +
Ferruh Yigit wrote:
> > Stephen Hemminger (2):
> > net/tap: support infrastructure to build the BPF filter
> > net/tap; rebuild and update the BPF flow program
> >
>
> Thanks Stephen for fixing this.
>
>
> But considering it was broken for a while and n
On Thu, Nov 02, 2023 at 06:05:59PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Thursday, 2 November 2023 15.57
> >
> > Hi all,
> >
> > looking to start a discussion and get some input here.
> >
> > There are a number of our examples in DPD
02/11/2023 15:56, Bruce Richardson:
> Hi all,
>
> looking to start a discussion and get some input here.
>
> There are a number of our examples in DPDK which still track core usage via
> a 64-bit bitmask, and, as such, cannot run on cores between 64 and
> RTE_MAX_LCORE. Two examples I have recent
Hi Nicolas,
On 10/27/23 22:02, Chautru, Nicolas wrote:
Hi Maxime,
Back on this discussion and there was some misunderstanding. This is really a
bug for the python script helper only.
The -t option is already reserved for bbdev-test application (and in doc) for
setting the iter_max (see main.c
> -Original Message-
> From: Karas, Krzysztof
> Sent: Wednesday, September 27, 2023 1:41 PM
> To: Ji, Kai ; De Lara Guarch, Pablo
> ; Cornu, Marcel D
> ; Power, Ciara
> Cc: dev@dpdk.org; Karas, Krzysztof ;
> sta...@dpdk.org
> Subject: [PATCH] crypto/ipsec_mb: Do not dequeue ops from ring
Add a new small library to make it easier for apps to work with cmdline
arguments and build up args to use when initializing EAL.
This library is optional, and can be disabled at build time using
the disable libraries meson option.
Signed-off-by: Bruce Richardson
---
doc/api/doxy-api-index.md |
Hi all,
looking to start a discussion and get some input here.
There are a number of our examples in DPDK which still track core usage via
a 64-bit bitmask, and, as such, cannot run on cores between 64 and
RTE_MAX_LCORE. Two examples I have recently come across with this issue are
"eventdev_pipel
DPDK has traditionally assumed that apps are written where argc/argv
parameters are passed directly to rte_eal_init() and then app arguments
are handled afterwards, as is done in the DPDK apps and examples.
However, based on other projects, like VPP and OVS, we know that this is
often not the case
Allow other libraries in DPDK to know about the options EAL takes, by
exporting the long and short getopt options via an internal-only
function.
Signed-off-by: Bruce Richardson
---
lib/eal/common/eal_common_options.c | 9 +
lib/eal/include/rte_eal.h | 14 ++
lib/ea
On 11/2/2023 5:12 PM, Morten Brørup wrote:
>> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
>> Sent: Thursday, 2 November 2023 18.06
>>
>> On 11/2/2023 4:51 PM, Morten Brørup wrote:
From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
Sent: Thursday, 2 November 2023 17.24
On 11/2
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Thursday, 2 November 2023 18.06
>
> On 11/2/2023 4:51 PM, Morten Brørup wrote:
> >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> >> Sent: Thursday, 2 November 2023 17.24
> >>
> >> On 11/2/2023 1:59 AM, lihuisong (C) wrote:
> >>>
> >>
On Thu, 2 Nov 2023 17:28:46 +
Bruce Richardson wrote:
> DPDK has traditionally assumed that apps are written where argc/argv
> parameters are passed directly to rte_eal_init() and then app arguments
> are handled afterwards, as is done in the DPDK apps and examples.
>
> However, based on ot
Add in functions which can be used to check for valid arguments for EAL
or for the application. This can be used to separate out mixed arguments.
Signed-off-by: Bruce Richardson
---
lib/args/args.c | 122 +++
lib/args/rte_args.h | 56 +++
On 11/2/2023 1:59 AM, lihuisong (C) wrote:
>
> 在 2023/11/2 0:08, Stephen Hemminger 写道:
>> On Wed, 1 Nov 2023 10:36:07 +0800
>> "lihuisong (C)" wrote:
>>
Do we need to report this size? It's a common feature for all PMDs.
It would make sense then to have max_rx_bufsize set to 16K by defa
Change the parameter type of argv parameter to rte_eal_init from
"char **" to "char * const *", since we don't modify the argv pointers
passed in.
Signed-off-by: Bruce Richardson
---
lib/eal/common/eal_common_options.c | 2 +-
lib/eal/common/eal_options.h| 2 +-
lib/eal/freebsd/eal.c
On Thu, Nov 02, 2023 at 10:50:29AM -0700, Stephen Hemminger wrote:
> On Thu, 2 Nov 2023 17:28:46 +
> Bruce Richardson wrote:
>
> > DPDK has traditionally assumed that apps are written where argc/argv
> > parameters are passed directly to rte_eal_init() and then app arguments
> > are handled
>+> WDYT, Jerin, Abdullah.
It is a good idea to make it internal, I will work on that and upstream a new
one.
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Thursday, November 2, 2023 10:00 AM
> To: Chautru, Nicolas ; Vargas, Hernan
> ; dev@dpdk.org; gak...@marvell.com; Rix, Tom
> ; Hemant Agrawal
> Cc: Zhang, Qi Z
> Subject: Re: [PATCH v1 02/11] test/bbdev: update python scri
From: Rahul Gupta
Initialization often requires rte_eal_init + rte_pktmbuf_pool_create
which can consume a total time of 500-600 ms:
a) For many devices FLR may take a significant chunk of time
(200-250 ms in our use-case), this FLR is triggered during device
probe in rte_eal_init().
b) rte
On 11/2/2023 4:53 PM, Stephen Hemminger wrote:
> On Thu, 2 Nov 2023 15:13:57 +
> Ferruh Yigit wrote:
>
>> On 11/1/2023 6:02 PM, Stephen Hemminger wrote:
>>> Rebuild with commit
>>> c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31)
>>>
>>> Signed-off-by: Stephen Hemminger
On Thu, Nov 02, 2023 at 05:28:42PM +0100, Thomas Monjalon wrote:
> 02/11/2023 15:56, Bruce Richardson:
> > Hi all,
> >
> > looking to start a discussion and get some input here.
> >
> > There are a number of our examples in DPDK which still track core usage via
> > a 64-bit bitmask, and, as such,
On 11/2/2023 4:52 PM, Stephen Hemminger wrote:
> On Thu, 2 Nov 2023 15:11:10 +
> Ferruh Yigit wrote:
>
>>> Stephen Hemminger (2):
>>> net/tap: support infrastructure to build the BPF filter
>>> net/tap; rebuild and update the BPF flow program
>>>
>>
>> Thanks Stephen for fixing this.
>
On Thu, 2 Nov 2023 11:19:24 -0700
Rahul Gupta wrote:
> From: Rahul Gupta
> To: dev@dpdk.org, tho...@monjalon.net
> Cc: sovar...@linux.microsoft.com, ok...@kernel.org,
> sujithsan...@microsoft.com, sowmini.varad...@microsoft.com,
> rahulrgupt...@gmail.com, Rahul Gupta , Rahul Gupta
>
> S
On Thu, 2 Nov 2023 18:35:08 +
Ferruh Yigit wrote:
> > The motivation was to allow use of rte_flow in the failsafe/tap/mlx model.
> > This is the legacy model for use in Hyper-V/Azure. Not aware of any
> > application using this.
> > The bug fix came from Oracle, perhaps they have more context
On Thu, 2 Nov 2023 18:11:48 +
Bruce Richardson wrote:
> From: Bruce Richardson
> To: dev@dpdk.org
> Cc: step...@networkplumber.org, Bruce Richardson
> Subject: [PATCH] eal: add const to init function parameter
> Date: Thu, 2 Nov 2023 18:11:48 +
> X-Mailer: git-send-email 2.39.2
>
>
On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
> IEEE 802 packets may have a minimum size limit. The data fields
> should be padded when necessary. In some cases, the padding data
> is not zero. Testpmd does not trim these IP packets to the true
> length of the frame, so errors will occur when calculating
On 11/2/2023 6:16 AM, Chaoyong He wrote:
> This patch series add the support of RX and TX pause frame switch mode.
>
> Zerun Fu (2):
> net/nfp: support getting pause frame switch mode
> net/nfp: support setting pause frame switch mode
>
Series applied to dpdk-next-net/main, thanks.
New script to find words that should not be used. Really just a wrapper
around git grep command. By default it prints matches but
can also display counts.
Uses the word lists from Inclusive Naming Initiative
see https://inclusivenaming.org/word-lists/
Note: the list has extra comma at end of lis
On 11/1/2023 6:02 PM, Stephen Hemminger wrote:
> Rebuild with commit
> c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31)
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/tap/tap_bpf_insns.h | 2959 ---
> 1 file changed, 1503 insertions(+),
On 9/29/2023 2:50 PM, Ferruh Yigit wrote:
> On 6/9/2023 3:20 PM, Ferruh Yigit wrote:
>> On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote:
>>> On 5/8/2023 4:11 PM, Tianli Lai wrote:
Caution: This is an external email. Please take care when clicking
links or opening attachments. When in doub
On 6/25/2023 4:45 PM, Thomas Monjalon wrote:
> 23/06/2023 16:00, Ferruh Yigit:
>> On 2/3/2023 1:28 PM, Thomas Monjalon wrote:
>>> The option RTE_LIBRTE_IEEE1588 has no effect on any library
>>> unlike its name.
>>>
>>> Also we are suppose to enable/disable features dynamically,
>>> not at compilati
On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote:
>
> On 6/25/2023 4:45 PM, Thomas Monjalon wrote:
> > 23/06/2023 16:00, Ferruh Yigit:
> >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote:
> >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library
> >>> unlike its name.
> >>>
> >>> Also we are
On Thu, 2 Nov 2023 21:00:31 +
Ferruh Yigit wrote:
> On 11/1/2023 6:02 PM, Stephen Hemminger wrote:
> > Rebuild with commit
> > c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31)
> >
> > Signed-off-by: Stephen Hemminger
> > ---
> > drivers/net/tap/tap_bpf_insns.h | 2959 +
02/11/2023 22:21, Ajit Khaparde:
> On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote:
> > On 6/25/2023 4:45 PM, Thomas Monjalon wrote:
> > > 23/06/2023 16:00, Ferruh Yigit:
> > >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote:
> > >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library
> > >>
Fix memory leaks in Asymmetric ops, as reported by valgrind.
Signed-off-by: Gowrishankar Muthukrishnan
---
v2:
- added more fixes.
---
drivers/crypto/openssl/rte_openssl_pmd.c | 38 ++--
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 15 ++--
2 files changed, 39 insertio
On Thu, 2 Nov 2023 14:08:31 +0530
Gowrishankar Muthukrishnan wrote:
> + if (pub_key)
> + BN_free(pub_key);
> + if (pkey)
> + EVP_PKEY_free(pkey);
>
All these checks for null are unnecessary:
EVP_PKEY_free() decrements the reference count of key and, if t
OpenSSL follows null free conventions
Stephen Hemminger (2):
nullfree: add matches for null free cases from OpenSSL
crypto/openssl: remove unnecessary NULL checks before free
devtools/cocci/nullfree.cocci| 9 +
drivers/crypto/openssl/rte_openssl_pmd.c | 36 +++---
OpenSSL functions follow the design parameter that free
of NULL is ok.
Signed-off-by: Stephen Hemminger
---
devtools/cocci/nullfree.cocci | 9 +
1 file changed, 9 insertions(+)
diff --git a/devtools/cocci/nullfree.cocci b/devtools/cocci/nullfree.cocci
index 9ca3fc2864..c58aad4fb7 100644
Found with nullfree.cocci
Signed-off-by: Stephen Hemminger
---
drivers/crypto/openssl/rte_openssl_pmd.c | 36 +++-
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 +-
2 files changed, 13 insertions(+), 26 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
The allocation of bitmap for aged flows should be done in
npc_aging_ctrl_thread_create() instead of roc_npc_init(), as the bitmap
free is being done in npc_aging_ctrl_thread_destroy().
Fixes: 357f5ebc8a24 ("common/cnxk: support flow aging")
Cc: sta...@dpdk.org
Signed-off-by: Ankur Dwivedi
---
d
On 11/2/2023 10:17 PM, Thomas Monjalon wrote:
> 02/11/2023 22:21, Ajit Khaparde:
>> On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote:
>>> On 6/25/2023 4:45 PM, Thomas Monjalon wrote:
23/06/2023 16:00, Ferruh Yigit:
> On 2/3/2023 1:28 PM, Thomas Monjalon wrote:
>> The option RTE_LIBRT
02.11.2023 18:11, Bruce Richardson пишет:
Change the parameter type of argv parameter to rte_eal_init from
"char **" to "char * const *", since we don't modify the argv pointers
passed in.
Signed-off-by: Bruce Richardson
---
lib/eal/common/eal_common_options.c | 2 +-
lib/eal/common/eal_opti
> gcc [1] generates warning [2] about calloc usage, because calloc parameter
> order is wrong, fixing it by replacing parameters.
>
> [1]
> gcc (GCC) 14.0.0 20231102 (experimental)
>
> [2]
> Compiling C object .../net_nfp_nfpcore_nfp_mutex.c.o
> .../net/nfp/nfpco
1 - 100 of 133 matches
Mail list logo
