02/11/2023 11:23, Bruce Richardson: > On Wed, Nov 01, 2023 at 07:05:54PM +0000, Sevincer, Abdullah wrote: > > > > >++ PCIe maintainers. > > > > >+I will leave this up to @David Marchand / @Thomas as this patch has > > >common code changes and needs to come via main tree. > > > > >+Also in this case, The comment was given very early(Back in June 7) for > > >the same. > > >+https://patches.dpdk.org/project/dpdk/patch/20230607210050.107944-1-abdullah.sevin...@intel.com/ > > > > Thanks Jerrin and Bruce for the comments. > > I will wait for opinion of PCI maintainers. > > Thinking on this more, any API for enable/disable pasid would be > internal-only, so therefore would not be subject to ABI/API change rules > AFAIK. This gives us more freedom to change it as more discovery > capabilities become available. > Therefore, an initial version of the function can take the offset as > parameter, and we can update it without API/ABI concerns later. I was > previously worried about trying to get the API correct first time, but for > internal functions, we don't need to.
It looks a good option. Better to add an internal PCI function than doing it in a PMD. > WDYT, Jerin, Abdullah.
