Re: [PATCH 0/8] net/hns3: add some bugfix for hns3

2023-10-27 Thread fengchengwen
Series-reviewed-by: Chengwen Feng On 2023/10/27 14:09, Jie Hai wrote: > This patchset contains some bugfix for hns3 pmd. > > Dengdui Huang (6): > net/hns3: fix unchecked Rx free threshold > net/hns3: fix double stats for IMP and global reset > net/hns3: remove reset log in secondary > ne

Re: [PATCH] net/iavf: fix crash on closing representor ports

2023-10-27 Thread David Marchand
On Thu, Oct 26, 2023 at 12:01 PM Mingjin Ye wrote: > Afaics, the patch title is wrong, this is a net/ice fix. > Since the representor port needs to access the resources of the > associated DCF when it is closed. Therefore, the correct close > port operation is to close all the representor ports

RE: [PATCH v3 0/2] allow creating thread with real-time priority

2023-10-27 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 26 October 2023 21.51 > > 26/10/2023 18:50, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Thursday, 26 October 2023 18.07 [...] > > > For average realtime thread, I suggest the API > > >

Re: [PATCH] testpmd: fix early exit from signal

2023-10-27 Thread David Marchand
On Thu, Oct 26, 2023 at 7:11 PM Stephen Hemminger wrote: > > Other signals may occur causing read to get interrupted. > Loop until quit flag is set by signal, a character is entered, > or end of file. This fixes bug where testpmd would exit early > because of signal used by TAP device. > > Bugzill

RE: [PATCH v2 1/3] ethdev: introduce maximum Rx buffer size

2023-10-27 Thread Morten Brørup
> From: Huisong Li [mailto:lihuis...@huawei.com] > Sent: Friday, 27 October 2023 06.15 > > The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum > Rx buffer size supported by hardware. Actually, some engines also have > the maximum Rx buffer specification, like, hns3. If mbuf data

[PATCH] eal/unix: lower log level for reading files

2023-10-27 Thread David Marchand
The eal_parse_sysfs_value helper both returns an error code and logs an error level message when something goes wrong. On the other hand, internal users of this helper either ignore this error code (like when trying to find out some numa information from the Linux sysfs, or discovering some optiona

[PATCH] mem: explicitly initialise shared locks

2023-10-27 Thread David Marchand
Locks in the DPDK shared memory were not initialised so far. This is not really a problem as the early_mem_config structure is stored in the bss section (and so set to 0 by default). Yet, for consistency, explicitly initialise those locks with relevant initialiser macros. Suggested-by: Thomas Monj

[PATCH v6 1/1] eal/unix: allow creating thread with real-time priority

2023-10-27 Thread Thomas Monjalon
When adding an API for creating threads, the real-time priority has been forbidden on Unix. There is a known issue with ring behaviour, but it should not be completely forbidden. Real-time thread can block some kernel threads on the same core, making the system unstable. That's why a sleep is add

RE: [PATCH v6 1/1] eal/unix: allow creating thread with real-time priority

2023-10-27 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, 27 October 2023 10.09 > > When adding an API for creating threads, > the real-time priority has been forbidden on Unix. > > There is a known issue with ring behaviour, > but it should not be completely forbidden. > > Real-time

Re: [PATCH 1/3] vhost: robustify virtqueue access lock asserts

2023-10-27 Thread Eelco Chaudron
On 23 Oct 2023, at 11:55, David Marchand wrote: > A simple comment in vhost_user_msg_handler() is not that robust. > > Add a lock_all_qps property to message handlers so that their > implementation can add a build check and assert a vq is locked. > > Signed-off-by: David Marchand This change

RE: [PATCH] eal/unix: lower log level for reading files

2023-10-27 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Friday, 27 October 2023 10.01 > > The eal_parse_sysfs_value helper both returns an error code and logs an > error level message when something goes wrong. > On the other hand, internal users of this helper either ignore this > error

Re: [PATCH 2/3] vhost: fix virtqueue access lock in datapath

2023-10-27 Thread Eelco Chaudron
On 23 Oct 2023, at 11:55, David Marchand wrote: > Now that a r/w lock is used, the access_ok field should only be updated > under a write lock. > > Since the datapath code only takes a read lock on the virtqueue to check > access_ok, this lock must be released and a write lock taken before > ca

Re: [PATCH 3/3] vhost: annotate virtqueue access checks

2023-10-27 Thread Eelco Chaudron
On 23 Oct 2023, at 11:55, David Marchand wrote: > Modifying vq->access_ok should be done with a write lock taken. > Annotate vring_translate() and vring_invalidate() and add missing locks. > > Signed-off-by: David Marchand The changes look good to me. Acked-by: Eelco Chaudron

Re: [PATCH v6 1/1] eal/unix: allow creating thread with real-time priority

2023-10-27 Thread Thomas Monjalon
27/10/2023 10:45, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Friday, 27 October 2023 10.09 > > > > When adding an API for creating threads, > > the real-time priority has been forbidden on Unix. > > > > There is a known issue with ring behaviour, > > but it sh

Re: [PATCH] eal/unix: lower log level for reading files

2023-10-27 Thread David Marchand
On Fri, Oct 27, 2023 at 11:00 AM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Friday, 27 October 2023 10.01 > > > > The eal_parse_sysfs_value helper both returns an error code and logs an > > error level message when something goes wrong. > > On the

[PATCH] ethdev: fix flow API support for P4-programmable devices

2023-10-27 Thread wenjing . qiao
From: Wenjing Qiao "program" action should also be added in structure rte_flow_desc_action. Fixes: 8f1953f1914d ("ethdev: add flow API for P4-programmable devices") Signed-off-by: Wenjing Qiao --- lib/ethdev/rte_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/rte_flow.

RE: release candidate 23.11-rc1

2023-10-27 Thread Xu, HailinX
> -Original Message- > From: Xu, HailinX > Sent: Thursday, October 19, 2023 3:58 PM > To: Thomas Monjalon ; annou...@dpdk.org > Cc: Kovacevic, Marko ; Mcnamara, John > ; Richardson, Bruce > ; Ferruh Yigit > Subject: RE: release candidate 23.11-rc1 > > > -Original Message-

Re: [PATCH v1] dts: add Dockerfile

2023-10-27 Thread Juraj Linkeš
On Thu, Oct 26, 2023 at 11:56 PM Jeremy Spewock wrote: > > I recently ran into issues using the above Dockerfile because of the version > of poetry. I found that installing poetry with pip3 rather than apt fixed my > issue with it. This is what have in DTS docs in doc/guides/tools/dts.rst: To i

Re: [PATCH 2/3] vhost: fix virtqueue access lock in datapath

2023-10-27 Thread David Marchand
On Fri, Oct 27, 2023 at 11:05 AM Eelco Chaudron wrote: > > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c > > index 759a78e3e3..4116f79d4f 100644 > > --- a/lib/vhost/virtio_net.c > > +++ b/lib/vhost/virtio_net.c > > @@ -1694,6 +1694,17 @@ virtio_dev_rx_packed(struct virtio_net *dev,

[PATCH 2/9] ethdev: support setting and querying RSS algorithm

2023-10-27 Thread Jie Hai
Currently, rte_eth_rss_conf supports configuring and querying RSS hash functions, rss key and it's length, but not RSS hash algorithm. The structure ``rte_eth_dev_info`` is extended by adding a new field "rss_algo_capa". Drivers are responsible for reporting this capa and configurations of RSS has

[PATCH 0/9] support setting and querying RSS algorithms

2023-10-27 Thread Jie Hai
This patchset is to support setting and querying RSS algorithms. For this purpose, field "rss_algo_capa" is added to ``rte_eth_dev_info`` and field "algorithm" is added to ``rte_eth_rss_conf``. The drivers should reports their "rss_algo_capa" if they support updating RSS algorithms. Otherwise, the

[PATCH 3/9] net/hns3: report RSS hash algorithms capability

2023-10-27 Thread Jie Hai
The hns3 driver should reports RSS hash algorithm capability to support updating RSS hash algorithm by rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(). Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_common.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/hns3/hns3

[PATCH 4/9] net/hns3: support setting and querying RSS hash function

2023-10-27 Thread Jie Hai
From: Huisong Li Support setting and querying RSS hash function by ethdev ops. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu Acked-by: Chengwen Feng --- drivers/net/hns3/hns3_rss.c | 47 + 1 file changed, 27 insertions(+), 20 deletions(-) diff --g

[PATCH 1/9] ethdev: overwrite some comment related to RSS

2023-10-27 Thread Jie Hai
1. overwrite the comments of fields of 'rte_eth_rss_conf'. 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.h | 33 ++--- lib/ethdev/rte_flow.h | 1 + 2 files changed, 19 insertions(+), 15 deletions(-) diff --git

[PATCH 5/9] app/proc-info: fix never show RSS info

2023-10-27 Thread Jie Hai
Command show-port should show RSS info (rss_key, len and rss_hf), However, the information is shown only when rss_conf.rss_key is not NULL. Since no memory is allocated for rss_conf.rss_key, rss_key will always be NULL and the rss_info will never show. This patch fixes it. Fixes: 8a37f37fc243 ("ap

[PATCH 6/9] app/proc-info: adjust the display format of RSS info

2023-10-27 Thread Jie Hai
This patch splits the length and value of RSS key into two parts, removes spaces between RSS keys, and adds line breaks between RSS key and RSS hf. Before the adjustment, RSS info is shown as: - RSS -- RSS len 40 key (hex): 6d 5a 56 da 25 5b e c2 41 67 \ 25 3d 43 a3 8f b0

[PATCH 7/9] lib/ethdev: add API to get RSS algorithm names

2023-10-27 Thread Jie Hai
This patch adds new API rte_eth_dev_rss_algo_name() to get name of a RSS algorithm and document it. Signed-off-by: Jie Hai --- doc/guides/rel_notes/release_23_11.rst | 3 +++ lib/ethdev/rte_ethdev.c| 25 + lib/ethdev/rte_ethdev.h| 4

[PATCH 8/9] app/proc-info: support querying RSS hash algorithm

2023-10-27 Thread Jie Hai
Display RSS hash algorithm with command show-port as below. - RSS info -- hash algorithm : toeplitz Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu Acked-by: Reshma Pattan --- app/proc-info/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/proc-info/main.c b/app/p

[PATCH 9/9] app/testpmd: add RSS hash algorithms display

2023-10-27 Thread Jie Hai
Add the command "show port X rss-hash algorithm" to display the RSS hash algorithms of port X. An example is shown: testpmd> show port 0 rss-hash algorithm RSS algorithms: toeplitz Signed-off-by: Jie Hai --- app/test-pmd/cmdline.c | 29 - app/test-pmd/config.c | 2

Re: [PATCH] mem: explicitly initialise shared locks

2023-10-27 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/10/27 16:00, David Marchand wrote: > Locks in the DPDK shared memory were not initialised so far. > This is not really a problem as the early_mem_config structure is stored > in the bss section (and so set to 0 by default). > Yet, for consistency, explicitly initia

[PATCH] net/cpfl: support action prog

2023-10-27 Thread wenjing . qiao
From: Wenjing Qiao Parse JSON file and generate rules that instruct PMD to map an RTE_FLOW_ACTION_TYPE_PROG to a low-level FXP representation, the matching follows below guidelines. Use rte_flow_action_prog->name to match the name of a P4 action type when provided in the JSON file. In cases wher

Re: [RFC PATCH v4 3/4] dts: add doc generation

2023-10-27 Thread Juraj Linkeš
Thanks for the comments, Yoan. > > diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst > > index 32c18ee472..98923b1467 100644 > > --- a/doc/guides/tools/dts.rst > > +++ b/doc/guides/tools/dts.rst > > @@ -335,3 +335,32 @@ There are three tools used in DTS to help with code > > checki

Re: [PATCH 2/3] vhost: fix virtqueue access lock in datapath

2023-10-27 Thread Eelco Chaudron
On 27 Oct 2023, at 11:22, David Marchand wrote: > On Fri, Oct 27, 2023 at 11:05 AM Eelco Chaudron wrote: >>> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c >>> index 759a78e3e3..4116f79d4f 100644 >>> --- a/lib/vhost/virtio_net.c >>> +++ b/lib/vhost/virtio_net.c >>> @@ -1694,6 +16

[PATCH v7 0/9] document and simplify use of cmdline

2023-10-27 Thread Bruce Richardson
The DPDK commandline library is widely used by apps and examples within DPDK, but it is not documented in our programmers guide and it requires a lot of boilerplate code definitions in order to used. We can improve this situation by creating a simple python script to automatically generate the boil

[PATCH v7 1/9] doc/prog_guide: new chapter on cmdline library

2023-10-27 Thread Bruce Richardson
The cmdline library was not documented in our programmers guide, so add a new chapter on it. This chapter covers step-by-step how to use the library, rather than focusing on the library internals. This complements the existing cmdline example app document, providing more details on the process of u

[PATCH v7 2/9] buildtools: script to generate cmdline boilerplate

2023-10-27 Thread Bruce Richardson
Provide a "dpdk-cmdline-gen.py" script for application developers to quickly generate the boilerplate code necessary for using the cmdline library. Example of use: The script takes an input file with a list of commands the user wants in the app, where the parameter variables are tagged with the ty

[PATCH v7 3/9] ci: allow use of DPDK tools when building examples

2023-10-27 Thread Bruce Richardson
To allow use of the DPDK python scripts (installed in $(prefix)/bin) from within the makefiles of our examples, we need to export the PATH variable with the location of our installed scripts from within our CI scripts. This matches what is already done for other paths e.g. the PKG_CONFIG_PATH varia

[PATCH v7 4/9] examples/simple_mp: auto-generate cmdline boilerplate

2023-10-27 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/multi_process/simple_mp/Makefile | 12 +- examples/multi_process/simple_mp/meson.build | 9 ++ .../multi_process/simpl

[PATCH v7 5/9] examples/hotplug_mp: auto-generate cmdline boilerplate

2023-10-27 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/multi_process/hotplug_mp/Makefile| 12 +- examples/multi_process/hotplug_mp/commands.c | 147 ++ example

[PATCH v7 6/9] examples/bond: auto-generate cmdline boilerplate

2023-10-27 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- Note: the original help text on some of the commands in this example were not useful "this command do not handle any arguments". Ther

[PATCH v7 7/9] examples/vdpa: auto-generate cmdline boilerplate

2023-10-27 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/vdpa/Makefile | 12 ++-- examples/vdpa/commands.list | 8 +++ examples/vdpa/main.c| 131 ++

[PATCH v7 8/9] buildtools/dpdk-cmdline-gen: support option strings

2023-10-27 Thread Bruce Richardson
Add support to the commandline generator for option strings, where there are only a limited number of acceptable values to be passed as a parameter. Signed-off-by: Bruce Richardson --- buildtools/dpdk-cmdline-gen.py| 7 +++ doc/guides/prog_guide/cmdline.rst | 7 +++ 2 files changed,

[PATCH v7 9/9] examples/ntb: auto-generate cmdline boilerplate

2023-10-27 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/ntb/Makefile | 12 ++- examples/ntb/commands.list | 11 ++ examples/ntb/meson.build | 7 ++ examples/ntb/ntb_fwd.c

RE: [PATCH v4] app/testpmd: enable cli for programmable action

2023-10-27 Thread Zhang, Qi Z
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 12, 2023 9:32 AM > To: Zhang, Qi Z > Cc: Ferruh Yigit ; Singh, Aman Deep > ; Zhang, Yuying ; > dev@dpdk.org; Dumitrescu, Cristian ; > or...@nvidia.com > Subject: Re: [PATCH v4] app/testpmd: enable cli for programm

Re: [PATCH] net/nfp: update the supported list of packet types

2023-10-27 Thread Ferruh Yigit
On 10/19/2023 7:17 AM, Chaoyong He wrote: > From: Qin Ke > > The NFP PMD supports reporting more packet types then previously > claimed, extend the list of supported types. > > While at it add a check to only list supported packet types if the > firmware supports the feature. > > Signed-off-by:

Re: [PATCH] testpmd: fix early exit from signal

2023-10-27 Thread Ferruh Yigit
On 10/27/2023 8:30 AM, David Marchand wrote: > On Thu, Oct 26, 2023 at 7:11 PM Stephen Hemminger > wrote: >> >> Other signals may occur causing read to get interrupted. >> Loop until quit flag is set by signal, a character is entered, >> or end of file. This fixes bug where testpmd would exit earl

Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env

2023-10-27 Thread Kelly, Karen
On 26/10/2023 16:19, Sivaprasad Tummala wrote: Updated the l3fwd-power app to configure the uncore env before invoking any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is too late because other APIs already called. Bugzilla ID: 1304 Fixes: ac1edcb6621a ("power: refactor unco

Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env

2023-10-27 Thread Hunt, David
Hi Sivaprasad, Karen, On 27/10/2023 13:36, Kelly, Karen wrote: On 26/10/2023 16:19, Sivaprasad Tummala wrote: Updated the l3fwd-power app to configure the uncore env before invoking any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is too late because other APIs already cal

Re: [PATCH v5] bus/pci: fix legacy device IO port map in secondary process

2023-10-27 Thread Gupta, Nipun
On 10/24/2023 7:30 AM, Wenwu Ma wrote: When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- v5:

Re: [PATCH v3 19/19] ring: use rte optional stdatomic API

2023-10-27 Thread Konstantin Ananyev
26.10.2023 01:31, Tyler Retzlaff пишет: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_hws_cnt.h | 4 ++-- lib/ring/rte_ring_c11_pvt.h | 47 +-

Re: [PATCH v3 06/19] ipsec: use rte optional stdatomic API

2023-10-27 Thread Konstantin Ananyev
26.10.2023 01:31, Tyler Retzlaff пишет: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/ipsec/ipsec_sqn.h | 2 +- lib/ipsec/sa.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: [PATCH v3 08/19] mempool: use rte optional stdatomic API

2023-10-27 Thread Konstantin Ananyev
26.10.2023 01:31, Tyler Retzlaff пишет: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/mempool/rte_mempool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/memp

Re: [PATCH v3 07/19] mbuf: use rte optional stdatomic API

2023-10-27 Thread Konstantin Ananyev
26.10.2023 01:31, Tyler Retzlaff пишет: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf.h | 20 ++-- lib/mbuf/rte_mbuf_core.h | 5 +++-- 2 files changed,

Re: [PATCH v3 16/19] ethdev: use rte optional stdatomic API

2023-10-27 Thread Konstantin Ananyev
26.10.2023 01:31, Tyler Retzlaff пишет: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/ethdev/ethdev_driver.h | 16 lib/ethdev/ethdev_private.c | 6 +++--- lib/ethdev/

Re: [PATCH v3 14/19] cryptodev: use rte optional stdatomic API

2023-10-27 Thread Konstantin Ananyev
26.10.2023 01:31, Tyler Retzlaff пишет: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/cryptodev/rte_cryptodev.c | 22 -- lib/cryptodev/rte_cryptodev.h | 16

Re: [PATCH] Add bus master enable/disable APIs for CDX devices

2023-10-27 Thread Gupta, Nipun
On 10/26/2023 8:50 AM, Shubham Rohila wrote: Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to enable or disable bus master functionality for cdx devices. Signed-off-by: Shubham Rohila --- drivers/bus/cdx/bus_cdx_driver.h | 25 drivers/bus/cdx/cdx_vfio.c | 97 +++

Re: [PATCH v4 00/24] add the NFP vDPA PMD

2023-10-27 Thread Ferruh Yigit
On 10/27/2023 3:59 AM, Chaoyong He wrote: > This patch series aims to add the NFP vDPA PMD, we also grab the common > logic into the `drivers/common/nfp` directory. > > --- > v4: > * Try to fix compile error in clang environment. > * Merge the modify of release notes into suitable commit. > * Rewr

Re: [PATCH v1 1/3] dmadev: add inter-domain operations

2023-10-27 Thread Medvedkin, Vladimir
Hi Satananda, Anoob, Chengwen, Jerin, all, After a number of internal discussions we have decided that we're going to postpone this feature/patchset till next release. >[Satananda] Have you considered extending  rte_dma_port_param and rte_dma_vchan_conf to represent interdomain memory transfe

RE: [PATCH v2] common/qat: limit configuration to the primary process

2023-10-27 Thread Power, Ciara
Hi Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, October 23, 2023 4:53 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Power, Ciara > ; Kusztal, ArkadiuszX > > Subject: [PATCH v2] common/qat: limit configuration to the primary process > > This change p

[PATCH] crypto/qat: fix build when no openssl exists

2023-10-27 Thread Ciara Power
Previously some compilation errors existed when no openssl was installed on the system, and intel-ipsec-mb was installed, due to missing headers and macros. This patch fixes the issue by adding in extra ifdefs around openssl specific code paths, and by adding the relevant macros explicitly in QAT

RE: [EXT] [PATCH v2] app/dma-perf: fix lcores array out of bounds access

2023-10-27 Thread Gowrishankar Muthukrishnan
Looks good to me. Acked-by: Gowrishankar Muthukrishnan

[PATCH] net/af_xdp: avoid error log for virtual interfaces

2023-10-27 Thread David Marchand
For virtual interfaces, like a veth or a tap used in OVS unit tests, plugging a af_xdp port on them results in an error level message: dpdk|ERR|EAL: eal_parse_sysfs_value(): cannot open sysfs value /sys/class/net/ovs-tap1/device/numa_node netdev_dpdk|INFO|Device 'net_af_xdptap1,iface=ovs-t

[PATCH 0/7] add Nitrox compress device support

2023-10-27 Thread Nagadheeraj Rottela
Add the Nitrox PMD to support Nitrox compress device. Nagadheeraj Rottela (7): crypto/nitrox: move nitrox common code to common folder compress/nitrox: add nitrox compressdev driver common/nitrox: add compress hardware queue management crypto/nitrox: set queue type during queue pair setup

[PATCH 1/7] crypto/nitrox: move nitrox common code to common folder

2023-10-27 Thread Nagadheeraj Rottela
- The common code will be shared by both crypto and compress Nitrox PMD's. Signed-off-by: Nagadheeraj Rottela --- MAINTAINERS | 1 + drivers/common/nitrox/meson.build | 35 +++ .../{crypto => common}/nitrox/nitrox_csr.h| 0 ..

[PATCH 2/7] compress/nitrox: add nitrox compressdev driver

2023-10-27 Thread Nagadheeraj Rottela
Introduce nitrox compressdev driver which implements below operations - dev_configure - dev_close - dev_infos_get - private_xform_create - private_xform_free Signed-off-by: Nagadheeraj Rottela --- MAINTAINERS | 7 + doc/guides/compressdevs/features/nitrox.ini

[PATCH 3/7] common/nitrox: add compress hardware queue management

2023-10-27 Thread Nagadheeraj Rottela
Add compress device ring initialization and cleanup code. Signed-off-by: Nagadheeraj Rottela --- drivers/common/nitrox/nitrox_csr.h | 12 +++ drivers/common/nitrox/nitrox_hal.c | 116 + drivers/common/nitrox/nitrox_hal.h | 115 drivers/co

[PATCH 4/7] crypto/nitrox: set queue type during queue pair setup

2023-10-27 Thread Nagadheeraj Rottela
Set queue type as SE to initialize symmetric hardware queue. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/nitrox_sym.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/nitrox/nitrox_sym.c b/drivers/crypto/nitrox/nitrox_sym.c index 1244317438..03652d3ade 100644

[PATCH 5/7] compress/nitrox: add software queue management

2023-10-27 Thread Nagadheeraj Rottela
Add software queue management code corresponding to queue pair setup and release functions. Signed-off-by: Nagadheeraj Rottela --- drivers/compress/nitrox/nitrox_comp.c | 116 +++--- 1 file changed, 105 insertions(+), 11 deletions(-) diff --git a/drivers/compress/nitrox/nitr

[PATCH 6/7] compress/nitrox: add stateless request support

2023-10-27 Thread Nagadheeraj Rottela
Implement enqueue and dequeue burst operations for stateless request support. Signed-off-by: Nagadheeraj Rottela --- drivers/compress/nitrox/nitrox_comp.c| 139 ++-- drivers/compress/nitrox/nitrox_comp_reqmgr.c | 789 +++ drivers/compress/nitrox/nitrox_comp_reqmgr.h | 61

[PATCH 7/7] compress/nitrox: add stateful request support

2023-10-27 Thread Nagadheeraj Rottela
Implement enqueue and dequeue burst operations for stateful request support. Signed-off-by: Nagadheeraj Rottela --- drivers/compress/nitrox/nitrox_comp.c| 187 +-- drivers/compress/nitrox/nitrox_comp_reqmgr.c | 555 --- drivers/compress/nitrox/nitrox_comp_reqmgr.h |

Re: [RFC PATCH v4 2/4] dts: add doc generation dependencies

2023-10-27 Thread Yoan Picchi
On 8/31/23 11:04, Juraj Linkeš wrote: Sphinx imports every Python module when generating documentation from docstrings, meaning all dts dependencies, including Python version, must be satisfied. By adding Sphinx to dts dependencies we make sure that the proper Python version and dependencies are

Re: [PATCH] crypto/qat: fix build when no openssl exists

2023-10-27 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 27 October 2023 15:23 To: dev@dpdk.org Cc: Power, Ciara ; Dooley, Brian ; sta...@dpdk.org ; Ji, Kai Subject: [PATCH] crypto/qat: fix build when no openssl exists Previously some compilation er

[PATCH] Add bus master enable/disable APIs for CDX devices

2023-10-27 Thread Ferruh Yigit
From: Shubham Rohila Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to enable or disable bus master functionality for cdx devices. Signed-off-by: Shubham Rohila --- drivers/bus/cdx/bus_cdx_driver.h | 25 drivers/bus/cdx/cdx_vfio.c | 97

Re: [PATCH] Add bus master enable/disable APIs for CDX devices

2023-10-27 Thread Ferruh Yigit
On 10/27/2023 5:22 PM, Ferruh Yigit wrote: > From: Shubham Rohila > > Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to > enable or disable bus master functionality for cdx devices. > > Signed-off-by: Shubham Rohila > Note: this is re-sent on behalf of Shubham to record the patch,

Re: [PATCH v3 0/5] net/ena: v2.8.0 driver release

2023-10-27 Thread Ferruh Yigit
On 10/26/2023 3:21 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Hi, > > This patchset contains alignment of the driver to the latest HAL version > which adds support for retrieving new metrics from the device and opens > a path to use additional device features that are not yet suppor

Re: [PATCH v6 1/1] eal/unix: allow creating thread with real-time priority

2023-10-27 Thread Stephen Hemminger
On Fri, 27 Oct 2023 10:45:03 +0200 Morten Brørup wrote: > Is it 100 % certain that the system becomes unstable if not sleeping or using > blocking system calls from a real-time thread? > And technically, it's not the thread itself that becomes unstable. My experience is that the goal of real ti

RE: [PATCH 0/2] Add AES-CCM support and fix application panic

2023-10-27 Thread Akhil Goyal
> Subject: [PATCH 0/2] Add AES-CCM support and fix application panic > > This patch set adds support for AES-CCM algorithm and fixes application > panic when source or destination mbuf segments are higher than max > supported by the driver. > > Nagadheeraj Rottela (2): > crypto/nitrox: fix pani

RE: [PATCH] app/test: validate shorter private key in ECDSA P521 test

2023-10-27 Thread Akhil Goyal
> Subject: [PATCH] app/test: validate shorter private key in ECDSA P521 test > > Update test vector of ECDSA P521 curve for validating private key > of length shorter than prime length. As prime length of this test > is not aligned by 8 bytes, this new test vector could test any > alignment issue

RE: [EXT] [PATCH v3] doc: update QAT cryptodev guide to run on aarch64

2023-10-27 Thread Akhil Goyal
> Update guide with instructions to run on Aarch64 based Ampere Altra > platform > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > --- > v3: > - Fix duplicate target warning by using anonymous reference > v2: > - Update driver guide with instructions to run on aarch64 instead >

RE: [EXT] [PATCH] crypto/qat: add sm2 ecdsa

2023-10-27 Thread Akhil Goyal
> Added SM2 ECDSA feature to the Intel QuickAssist Technology > symmetric crypto PMD. > > Signed-off-by: Arkadiusz Kusztal > --- The patch is not getting compiled on latest TOT. Please fix. ../drivers/crypto/qat/qat_asym.c: In function 'sm2_ecdsa_sign_set_input': ../drivers/crypto/qat/qat_asym.c:

Re: [PATCH 0/8] net/hns3: add some bugfix for hns3

2023-10-27 Thread Ferruh Yigit
On 10/27/2023 7:09 AM, Jie Hai wrote: > This patchset contains some bugfix for hns3 pmd. > > Dengdui Huang (6): > net/hns3: fix unchecked Rx free threshold > net/hns3: fix double stats for IMP and global reset > net/hns3: remove reset log in secondary > net/hns3: fix multiple reset detecte

RE: [PATCH v1 02/11] test/bbdev: update python script parameters

2023-10-27 Thread Chautru, Nicolas
Hi Maxime, Back on this discussion and there was some misunderstanding. This is really a bug for the python script helper only. The -t option is already reserved for bbdev-test application (and in doc) for setting the iter_max (see main.c). The problem is that the python script introduced -t by

Re: [PATCH] net/af_xdp: avoid error log for virtual interfaces

2023-10-27 Thread Ferruh Yigit
On 10/27/2023 3:32 PM, David Marchand wrote: > For virtual interfaces, like a veth or a tap used in OVS unit tests, > plugging a af_xdp port on them results in an error level message: > > dpdk|ERR|EAL: eal_parse_sysfs_value(): cannot open sysfs value > /sys/class/net/ovs-tap1/device/numa_nod

[PATCH v2 0/2] doc: update FlexRAN SDK links

2023-10-27 Thread Nicolas Chautru
v2: rebase typo fixed. Upstreaming SDK workaround for ACC100 and updating documentation for new SDK release. Hernan Vargas (2): baseband/acc: support ACC100 deRM corner case SDK doc: update FlexRAN SDK links doc/guides/bbdevs/turbo_sw.rst| 53 +--- drivers/baseba

[PATCH v2 1/2] baseband/acc: support ACC100 deRM corner case SDK

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Implement de-ratematch pre-processing for ACC100 SW corner cases. Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to t

[PATCH v2 2/2] doc: update FlexRAN SDK links

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Update FlexRAN SDK module link to use FEC_SDK_23.07. Update compiler links to use ICX. Update build SDK build instructions. Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/turbo_sw.rst | 53 +++--- 1 file changed, 30 insertions(+), 23 deletion

[PATCH v3 0/2] FlexRAN SDK update for 23.11

2023-10-27 Thread Nicolas Chautru
v3: rebase typo fixed. v2: rebase typo fixed. Upstreaming SDK workaround for ACC100 and updating documentation for new SDK release. Hernan Vargas (2): baseband/acc: support ACC100 deRM corner case SDK doc: update FlexRAN SDK links doc/guides/bbdevs/turbo_sw.rst| 53 +-

[PATCH v3 1/2] baseband/acc: support ACC100 deRM corner case SDK

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Implement de-ratematch pre-processing for ACC100 SW corner cases. Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to t

[PATCH v3 2/2] doc: update FlexRAN SDK links

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Update FlexRAN SDK module link to use FEC_SDK_23.07. Update compiler links to use ICX. Update build SDK build instructions. Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/turbo_sw.rst | 53 +++--- 1 file changed, 30 insertions(+), 23 deletion

[PATCH v2 00/10] test-bbdev changes for 23.11

2023-10-27 Thread Nicolas Chautru
v2: adding fixes for some of the commits requested by Maxime. Update test-bbdev for 23.11. Hernan Vargas (9): test/bbdev: fix python script subprocess test/bbdev: update python script parameters test/bbdev: handle exception for LLR generation test/bbdev: improve test log messages test/b

[PATCH v2 01/10] test/bbdev: fix python script subprocess

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas test-bbdev.py relying on non-recommended subprocess Popen. This can lead to instabilities where the process cannot be stopped with a sig TERM. Use subprocess run with proper timeout argument. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpd

[PATCH v2 02/10] test/bbdev: update python script parameters

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Update the timeout argument and default values. Update EAL help message and default value. Add iter_max and snr arguments. Signed-off-by: Hernan Vargas --- app/test-bbdev/test-bbdev.py | 22 ++ app/test-bbdev/test_bbdev_perf.c | 2 +- 2 files change

[PATCH v2 03/10] test/bbdev: rename macros from acc200 to vrb

2023-10-27 Thread Nicolas Chautru
Renaming ACC200 macros to use generic intel vRAN Boost (VRB). No functional impact. Fixes: 69a9d9e139d2 ("baseband/acc: rename files from acc200 to vrb") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 91 --

[PATCH v2 04/10] test/bbdev: handle exception for LLR generation

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Add range limit to prevent LLR generation greater than the data buffer size. Fixes: 7831a9684356 ("test/bbdev: support BLER for 4G") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 6 ++ 1 file changed, 6 insertions(+) diff --gi

[PATCH v2 06/10] test/bbdev: assert failed test for queue configure

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Stop test if rte_bbdev_queue_configure fails to configure queue. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev.c | 3 ++- 1 file changed, 2

[PATCH v2 05/10] test/bbdev: improve test log messages

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Add a print message for failure to retrieve stats on bbdev. Add vector name in logs. Remove unnecessary prints. Update code comments and cosmetic changes. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/main.c|

[PATCH v2 07/10] test/bbdev: ldpc encoder concatenation vector

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Add support for LDPC encoder concatenation configuration from the test vector. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_vector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_

[PATCH v2 08/10] test/bbdev: add MLD support

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Adding test-bbdev support for the MLD-TS processing specific to the VRB2 variant. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 519 + app/test-bbdev/test_bbdev_vector.c | 132 app/te

[PATCH v2 09/10] test/bbdev: support new FFT capabilities

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Adding support to test new FFT capabilities. Optional frequency domain dewindowing, frequency resampling, timing error correction and time offset per CS. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 26 ++--- ap

[PATCH v2 10/10] test/bbdev: support 4 bit LLR compression

2023-10-27 Thread Nicolas Chautru
From: Hernan Vargas Add support to test LDPC UL operation for new capability. Option to compress HARQ memory to 4 bits per LLR. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 3 ++- app/test-bbdev/test_bbdev_vector.c | 2 ++ 2 files changed,

  1   2   >