On 10/27/2023 8:30 AM, David Marchand wrote: > On Thu, Oct 26, 2023 at 7:11 PM Stephen Hemminger > <step...@networkplumber.org> wrote: >> >> Other signals may occur causing read to get interrupted. >> Loop until quit flag is set by signal, a character is entered, >> or end of file. This fixes bug where testpmd would exit early >> because of signal used by TAP device. >> >> Bugzilla ID: 1305 >> Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") > > We need this fix in LTS. > Cc: sta...@dpdk.org > > >> Signed-off-by: Stephen Hemminger <step...@networkplumber.org> >>
<...> > > Just a nit here. > Indent seems odd, I see an extra whitespace. > Empty line and indentation updated while merging. > Otherwise the fix lgtm and resolves the issue reported in bz. > Reviewed-by: David Marchand <david.march...@redhat.com> > > Applied to dpdk-next-net/main, thanks.