RE: [PATCH 1/4] net: calculate correct UDP pseudo header for UFO

2023-06-06 Thread Zeng, ZhichaoX
Hi Olivier, Could you please help to review this patch? Many thanks. Best Regards Zhichao > -Original Message- > From: Zeng, ZhichaoX > Sent: Thursday, April 13, 2023 1:34 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xu, Ke1 ; Zeng, > ZhichaoX ; Matz, Olivier > > Subject: [PATCH 1/4] net:

RE: [PATCH v6 1/4] ethdev: add API for mbufs recycle mode

2023-06-06 Thread Konstantin Ananyev
> > Thanks for the comments. > > From: Константин Ананьев > Sent: Monday, June 5, 2023 8:54 PM > To: Feifei Wang ; mailto:tho...@monjalon.net; > Ferruh Yigit ; > Andrew Rybchenko

RE: [PATCH] reorder: introduce API to obtain memory footprint

2023-06-06 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon > Subject: Re: [PATCH] reorder: introduce API to obtain memory footprint > > 02/06/2023 13:30, Volodymyr Fialko: > > Hi Thomas and Reshma, > > > > I would be interested in taking on the role of maintaining the reorder > > library. > > I

Re: Getting network port ID by ethdev port ID

2023-06-06 Thread Ivan Malov
Hi Stephen, On Mon, 5 Jun 2023, Stephen Hemminger wrote: On Tue, 6 Jun 2023 00:30:18 +0400 (+04) Ivan Malov wrote: Hi Stephen, Thomas, Thanks for responding. PSB. On Mon, 5 Jun 2023, Stephen Hemminger wrote: On Mon, 05 Jun 2023 18:03:14 +0200 Thomas Monjalon wrote: 05/06/2023 16:29, I

RE: [PATCH v6 2/4] net/i40e: implement mbufs recycle mode

2023-06-06 Thread Konstantin Ananyev
> > Define specific function implementation for i40e driver. > Currently, mbufs recycle mode can support 128bit > vector path and avx2 path. And can be enabled both in > fast free and no fast free mode. > > Suggested-by: Honnappa Nagarahalli > Signed-off-by:

RE: [EXT] [PATCH v5 3/5] eal/interrupts: add IRQ count in interrupt handle

2023-06-06 Thread Harman Kalra
> -Original Message- > From: Nipun Gupta > Sent: Thursday, May 25, 2023 3:38 PM > To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > Harman Kalra ; anatoly.bura...@intel.com; > step...@networkplumber.org > Cc: ferruh.yi...@amd.com; harpreet.an...@amd.com; > nikhil.agar.

Re: [EXT] [PATCH v5 3/5] eal/interrupts: add IRQ count in interrupt handle

2023-06-06 Thread Nipun Gupta
On 6/6/2023 12:48 PM, Harman Kalra wrote: -Original Message- From: Nipun Gupta Sent: Thursday, May 25, 2023 3:38 PM To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; Harman Kalra ; anatoly.bura...@intel.com; step...@networkplumber.org Cc: ferruh.yi...@amd.com; harpre

RE: [PATCH v6 1/4] ethdev: add API for mbufs recycle mode

2023-06-06 Thread Feifei Wang
[...] > > Probably I am missing something, but why it is not possible to do something > like that: > > > > rte_eth_recycle_mbufs(rx_port_id=X, rx_queue_id=Y, tx_port_id=N, > > tx_queue_id=M, ...); > > rte_eth_recycle_mbufs(rx_port_id=X, rx_queue_id=Y, tx_port_id=N, > > tx_queue_id=K, ...); > >

RE: [PATCH v6 2/4] net/i40e: implement mbufs recycle mode

2023-06-06 Thread Feifei Wang
> -Original Message- > From: Konstantin Ananyev > Sent: Tuesday, June 6, 2023 3:18 PM > To: Feifei Wang ; Константин Ананьев > ; Yuying Zhang > ; Beilei Xing > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; nd > Subject: RE: [PATCH v6 2/4] net/i40e: implement mbufs re

Re: [PATCH v4 26/26] vhost: add VDUSE device stop

2023-06-06 Thread Maxime Coquelin
On 6/5/23 09:56, Xia, Chenbo wrote: -Original Message- From: Maxime Coquelin Sent: Friday, June 2, 2023 4:08 AM To: dev@dpdk.org; Xia, Chenbo ; david.march...@redhat.com; m...@redhat.com; f...@redhat.com; jasow...@redhat.com; Liang, Cunming ; Xie, Yongji ; echau...@redhat.com; epere..

[PATCH v5 00/26] Add VDUSE support to Vhost library

2023-06-06 Thread Maxime Coquelin
This series introduces a new type of backend, VDUSE, to the Vhost library. VDUSE stands for vDPA device in Userspace, it enables implementing a Virtio device in userspace and have it attached to the Kernel vDPA bus. Once attached to the vDPA bus, it can be used either by Kernel Virtio drivers, li

[PATCH v5 01/26] vhost: fix IOTLB entries overlap check with previous entry

2023-06-06 Thread Maxime Coquelin
Commit 22b6d0ac691a ("vhost: fix madvise IOTLB entries pages overlap check") fixed the check to ensure the entry to be removed does not overlap with the next one in the IOTLB cache before marking it as DONTDUMP with madvise(). This is not enough, because the same issue is present when comparing wit

[PATCH v5 02/26] vhost: add helper of IOTLB entries coredump

2023-06-06 Thread Maxime Coquelin
This patch reworks IOTLB code to extract madvise-related bits into dedicated helper. This refactoring improves code sharing. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/iotlb.c | 77 +-- 1 file changed, 41 insertions(+), 36 de

[PATCH v5 03/26] vhost: add helper for IOTLB entries shared page check

2023-06-06 Thread Maxime Coquelin
This patch introduces a helper to check whether two IOTLB entries share a page. Signed-off-by: Maxime Coquelin Acked-by: Mike Pattrick Reviewed-by: Chenbo Xia --- lib/vhost/iotlb.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/lib/vhost/iotlb.c

[PATCH v5 04/26] vhost: don't dump unneeded pages with IOTLB

2023-06-06 Thread Maxime Coquelin
On IOTLB entry removal, previous fixes took care of not marking pages shared with other IOTLB entries as DONTDUMP. However, if an IOTLB entry is spanned on multiple pages, the other pages were kept as DODUMP while they might not have been shared with other entries, increasing needlessly the coredu

[PATCH v5 05/26] vhost: change to single IOTLB cache per device

2023-06-06 Thread Maxime Coquelin
This patch simplifies IOTLB implementation and improves IOTLB memory consumption by having a single IOTLB cache per device, instead of having one per queue. In order to not impact performance, it keeps an IOTLB lock per virtqueue, so that there is no contention between multiple queue trying to acq

[PATCH v5 06/26] vhost: add offset field to IOTLB entries

2023-06-06 Thread Maxime Coquelin
This patch is a preliminary work to prepare for VDUSE support, for which we need to keep track of the mmaped base address and offset in order to be able to unmap it later when IOTLB entry is invalidated. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/iotlb.c | 30

[PATCH v5 07/26] vhost: add page size info to IOTLB entry

2023-06-06 Thread Maxime Coquelin
VDUSE will close the file descriptor after having mapped the shared memory, so it will not be possible to get the page size afterwards. This patch adds an new page_shift field to the IOTLB entry, so that the information will be passed at IOTLB cache insertion time. The information is stored as a b

[PATCH v5 08/26] vhost: retry translating IOVA after IOTLB miss

2023-06-06 Thread Maxime Coquelin
Vhost-user backend IOTLB misses and updates are asynchronous, so IOVA address translation function just fails after having sent an IOTLB miss update if needed entry was not in the IOTLB cache. This is not the case for VDUSE, for which the needed IOTLB update is returned directly when sending an IO

[PATCH v5 10/26] vhost: add IOTLB cache entry removal callback

2023-06-06 Thread Maxime Coquelin
VDUSE will need to munmap() the IOTLB entry on removal from the cache, as it performs mmap() before insertion. This patch introduces a callback that VDUSE layer will implement to achieve this. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/iotlb.c | 12 lib/v

[PATCH v5 09/26] vhost: introduce backend ops

2023-06-06 Thread Maxime Coquelin
This patch introduces backend ops struct, that will enable calling backend specifics callbacks (Vhost-user, VDUSE), in shared code. This is an empty shell for now, it will be filled in later patches. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/socket.c | 2 +- lib

[PATCH v5 11/26] vhost: add helper for IOTLB misses

2023-06-06 Thread Maxime Coquelin
This patch adds a helper for sending IOTLB misses as VDUSE will use an ioctl while Vhost-user use a dedicated Vhost-user backend request. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vhost.c | 13 - lib/vhost/vhost.h | 4 lib/vhost/vhost_user.

[PATCH v5 12/26] vhost: add helper for interrupt injection

2023-06-06 Thread Maxime Coquelin
Vhost-user uses eventfd to inject IRQs, but VDUSE uses an ioctl. This patch prepares vhost_vring_call_split() and vhost_vring_call_packed() to support VDUSE by introducing a new helper. It also adds a new counter for guest notification failures, which could happen in case of uninitialized call fi

[PATCH v5 13/26] vhost: add API to set max queue pairs

2023-06-06 Thread Maxime Coquelin
This patch introduces a new rte_vhost_driver_set_max_queues API as preliminary work for multiqueue support with VDUSE. Indeed, with VDUSE we need to pre-allocate the vrings at device creation time, so we need such API not to allocate the 128 queue pairs supported by the Vhost library. Calling the

[PATCH v5 14/26] net/vhost: use API to set max queue pairs

2023-06-06 Thread Maxime Coquelin
In order to support multiqueue with VDUSE, we need to be able to limit the maximum number of queue pairs, to avoid unnecessary memory consumption since the maximum number of queue pairs need to be allocated at device creation time, as opposed to Vhost-user which allocate only when the frontend init

[PATCH v5 15/26] vhost: add control virtqueue support

2023-06-06 Thread Maxime Coquelin
In order to support multi-queue with VDUSE, having control queue support is required. This patch adds control queue implementation, it will be used later when adding VDUSE support. Only split ring layout is supported for now, packed ring support will be added later. Signed-off-by: Maxime Coquelin

[PATCH v5 16/26] vhost: add VDUSE device creation and destruction

2023-06-06 Thread Maxime Coquelin
This patch adds initial support for VDUSE, which includes the device creation and destruction. It does not include the virtqueues configuration, so this is not functionnal at this point. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/meson.build | 4 + lib/vhost/socket.

[PATCH v5 17/26] vhost: add VDUSE callback for IOTLB miss

2023-06-06 Thread Maxime Coquelin
This patch implements the VDUSE callback for IOTLB misses, which is done by using the VDUSE VDUSE_IOTLB_GET_FD ioctl. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vduse.c | 58 +++ 1 file changed, 58 insertions(+) diff --git a

[PATCH v5 18/26] vhost: add VDUSE callback for IOTLB entry removal

2023-06-06 Thread Maxime Coquelin
This patch implements the VDUSE callback for IOTLB entry removal, where it unmaps the pages from the invalidated IOTLB entry. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vduse.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/vhost/vduse.c b/lib/vhost/vdu

[PATCH v5 19/26] vhost: add VDUSE callback for IRQ injection

2023-06-06 Thread Maxime Coquelin
This patch implements the VDUSE callback for kicking virtqueues. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vduse.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c index 58c1b384a8..d39e39b9dc 100644 --- a/lib/vhost/vdus

[PATCH v5 20/26] vhost: add VDUSE events handler

2023-06-06 Thread Maxime Coquelin
This patch makes use of Vhost lib's FD manager to install a handler for VDUSE events occurring on the VDUSE device FD. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vduse.c | 101 ++ 1 file changed, 101 insertions(+) diff --git

[PATCH v5 21/26] vhost: add support for virtqueue state get event

2023-06-06 Thread Maxime Coquelin
This patch adds support for VDUSE_GET_VQ_STATE event handling, which consists in providing the backend last available index for the specified virtqueue. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vduse.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/v

[PATCH v5 22/26] vhost: add support for VDUSE status set event

2023-06-06 Thread Maxime Coquelin
This patch adds support for VDUSE_SET_STATUS event handling, which consists in updating the Virtio device status set by the Virtio driver. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vduse.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/vhost/vduse.c b/l

[PATCH v5 23/26] vhost: add support for VDUSE IOTLB update event

2023-06-06 Thread Maxime Coquelin
This patch adds support for VDUSE_UPDATE_IOTLB event handling, which consists in invaliding IOTLB entries for the range specified in the request. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vduse.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/vhost/vdu

[PATCH v5 24/26] vhost: add VDUSE device startup

2023-06-06 Thread Maxime Coquelin
This patch adds the device and its virtqueues initialization once the Virtio driver has set the DRIVER_OK in the Virtio status register. Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 126 ++ 1 file changed, 126 insertions(+) diff --git a/lib/

[PATCH v5 25/26] vhost: add multiqueue support to VDUSE

2023-06-06 Thread Maxime Coquelin
This patch enables control queue support in order to support multiqueue. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vduse.c | 83 +++ 1 file changed, 76 insertions(+), 7 deletions(-) diff --git a/lib/vhost/vduse.c b/lib/vhos

[PATCH v5 26/26] vhost: add VDUSE device stop

2023-06-06 Thread Maxime Coquelin
This patch adds VDUSE device stop and cleanup of its virtqueues. Signed-off-by: Maxime Coquelin --- doc/guides/rel_notes/release_23_07.rst | 7 +++ lib/vhost/vduse.c | 72 +++--- 2 files changed, 71 insertions(+), 8 deletions(-) diff --git a/doc/guides/

RE: [PATCH v6 2/4] net/i40e: implement mbufs recycle mode

2023-06-06 Thread Konstantin Ananyev
> > > Define specific function implementation for i40e driver. > > > Currently, mbufs recycle mode can support 128bit vector path and avx2 > > > path. And can be enabled both in fast free and no fast free mode. > > > > > > Suggested-by: Honnappa Nagarahalli > > >

RE: [PATCH v6 1/4] ethdev: add API for mbufs recycle mode

2023-06-06 Thread Konstantin Ananyev
> > [...] > > > Probably I am missing something, but why it is not possible to do > > > something > > like that: > > > > > > rte_eth_recycle_mbufs(rx_port_id=X, rx_queue_id=Y, tx_port_id=N, > > > tx_queue_id=M, ...); > > > rte_eth_recycle_mbufs(rx_port_id=X, rx_queue_id=Y, tx_port_id=N, >

Re: Getting network port ID by ethdev port ID

2023-06-06 Thread Ferruh Yigit
On 6/5/2023 9:30 PM, Ivan Malov wrote: > Hi Stephen, Thomas, > > Thanks for responding. PSB. > > On Mon, 5 Jun 2023, Stephen Hemminger wrote: > >> On Mon, 05 Jun 2023 18:03:14 +0200 >> Thomas Monjalon wrote: >> >>> 05/06/2023 16:29, Ivan Malov: Sorry, I missed your question. See below. >>>

RE: [PATCH v7 15/17] examples/l3fwd-graph: introduce multicore dispatch worker model

2023-06-06 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, June 6, 2023 1:55 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; step...@networkplumber.org; > pbhagavat...@marvell.com; Liang, Cunming ; Wang, > Haiyue ; mattias.

Re: [PATCH v6 1/4] bus/cdx: introduce AMD CDX bus

2023-06-06 Thread Thomas Monjalon
05/06/2023 15:26, Nipun Gupta: > +INTERNAL { > + global: > + > + rte_cdx_get_sysfs_path; Why exporting this function to the drivers? Another minor comment: please make sure all doxygen comments are ended with a dot.

Re: [PATCH v5 1/2] ethdev: add API to check if queue is valid

2023-06-06 Thread Ferruh Yigit
On 6/5/2023 3:27 AM, Dengdui Huang wrote: > The API rte_eth_dev_is_valid_rxq/txq which > is used to check if Rx/Tx queue is valid. > If the queue has been setup, it is considered valid. > > Signed-off-by: Dengdui Huang > Acked-by: Ferruh Yigit

Re: [PATCH v5 0/2] add Rx/Tx queue ID check API and use it to fix a bug

2023-06-06 Thread Ferruh Yigit
On 6/5/2023 3:27 AM, Dengdui Huang wrote: > This series add a commom API to check queue id > and use it to fix a bug. > > v4->v5 > update document order and correcting typos > > v3->v4 > update API name and uptate description in the API documentation > > v2->v3 > update API name and use the inte

Re: [PATCH v2] net/vmxnet3: fix return code in initializing

2023-06-06 Thread Ferruh Yigit
On 6/2/2023 5:44 PM, Kaijun Zeng wrote: > Improve error handling > > Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver > implementation") > Cc: sta...@dpdk.org > > Signed-off-by: Kaijun Zeng > --- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 12 +++- > 1 file changed, 11 ins

Re: [PATCH] doc: build manpages as well as html output

2023-06-06 Thread Bruce Richardson
On Mon, Jun 05, 2023 at 10:50:48AM +0530, Jerin Jacob wrote: > On Thu, Jun 1, 2023 at 9:08 PM Bruce Richardson > wrote: > > > > Doxygen can produce manpage output as well as html output for the DPDK > > APIs. However, we need to do this as a separate task as the manpage > > output needs to be plac

Re: [PATCH v1 1/1] doc: announce change in bbdev api related to operation extension

2023-06-06 Thread David Marchand
On Mon, Jun 5, 2023 at 10:08 PM Chautru, Nicolas wrote: > Wrt the MLD functions: these are new into the related serie but still the > break the ABI since the struct rte_bbdev includes these functions hence > causing offset changes. > > Should I then just rephrase as: > > +* bbdev: Will extend th

RE: [PATCH] net/ice/base: support customized DDP package

2023-06-06 Thread Su, Simei
This patch is for customized DDP package based on DPDK 23.03. Customer use a custom package and a custom kernel driver, so DPDK won't upstream it. > -Original Message- > From: Su, Simei > Sent: Monday, June 5, 2023 5:38 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Su, Simei

Re: [PATCH v6 3/4] bus/cdx: add support for MSI

2023-06-06 Thread David Marchand
On Mon, Jun 5, 2023 at 3:27 PM Nipun Gupta wrote: > +/* set up interrupt support (but not enable interrupts) */ > static int > -cdx_rte_vfio_setup_device(int vfio_dev_fd) > +cdx_vfio_setup_interrupts(struct rte_cdx_device *dev, int vfio_dev_fd, I had dropped a bit too much of the hunk in my prev

Re: [PATCH v3] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-06 Thread kumaraparameshwaran rathinavel
On Tue, Jun 6, 2023 at 10:05 AM Hu, Jiayu wrote: > Hi Kumara, > > The v3 patch is not complete and it seems to be a patch based on v2. > In addition, did you test the code for tcp4 and tcp6 after your change? > >> Will make sure that next patch contains the entire diff. >> > For others, please se

RE: [PATCH] app/testpmd: fix IPv6 tunnel packet checksum error

2023-06-06 Thread He, ShiyangX
>-Original Message- >From: Ferruh Yigit >Sent: Friday, June 2, 2023 6:10 AM >To: He, ShiyangX ; dev@dpdk.org >Cc: Zhou, YidingX ; sta...@dpdk.org; Singh, Aman >Deep ; Zhang, Yuying >; Somnath Kotur >; Andrew Rybchenko >; Matz, Olivier ; >Ajit Khaparde >Subject: Re: [PATCH] app/testpmd:

Re: [PATCH v6 3/4] bus/cdx: add support for MSI

2023-06-06 Thread Nipun Gupta
On 6/6/2023 3:00 PM, David Marchand wrote: On Mon, Jun 5, 2023 at 3:27 PM Nipun Gupta wrote: +/* set up interrupt support (but not enable interrupts) */ static int -cdx_rte_vfio_setup_device(int vfio_dev_fd) +cdx_vfio_setup_interrupts(struct rte_cdx_device *dev, int vfio_dev_fd, I had d

Re: [PATCH 0/2] report the outer L3 and L4 packet type

2023-06-06 Thread Ferruh Yigit
On 6/5/2023 4:12 AM, Chaoyong He wrote: > This patch series add the support of: > 1. Report the outer L3 packet type. > 2. Report the L4 packet type for VXLAN and GENEVE. > > Qin Ke (2): > net/nfp: report outer L3 packet type by Rx descriptor > net/nfp: add default process to report outer L4 p

[PATCH] maintainers: update for Reorder

2023-06-06 Thread Volodymyr Fialko
Update maintainer for Reorder lib. Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 42a5b20fb7..09befb116f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1488,7 +1488,7 @@ F: examples/distributor/

Re: [PATCH] doc: build manpages as well as html output

2023-06-06 Thread Jerin Jacob
On Tue, Jun 6, 2023 at 2:49 PM Bruce Richardson wrote: > > On Mon, Jun 05, 2023 at 10:50:48AM +0530, Jerin Jacob wrote: > > On Thu, Jun 1, 2023 at 9:08 PM Bruce Richardson > > wrote: > > > > > > Doxygen can produce manpage output as well as html output for the DPDK > > > APIs. However, we need to

RE: [PATCH] maintainers: update for Reorder

2023-06-06 Thread Pattan, Reshma
> -Original Message- > From: Volodymyr Fialko > Sent: Tuesday, June 6, 2023 10:43 AM > To: dev@dpdk.org; Pattan, Reshma ; Thomas > Monjalon > Cc: jer...@marvell.com; ano...@marvell.com; Volodymyr Fialko > > Subject: [PATCH] maintainers: update for Reorder > > Update maintainer for Re

[PATCH v7 0/4] Support AMD CDX bus

2023-06-06 Thread Nipun Gupta
The CDX devices are memory mapped on system bus for embedded CPUs. It uses sysfs interface and the vfio-cdx driver to discover and initialize the CDX devices. The CDX bus and VFIO support is available at Xilinx/AMD open source tree: https://github.com/Xilinx/linux-xlnx (drivers/cdx/ and drivers/v

[PATCH v7 1/4] bus/cdx: introduce AMD CDX bus

2023-06-06 Thread Nipun Gupta
AMD CDX bus supports multiple type of devices, which can be exposed to user-space via vfio-cdx. vfio-cdx provides the MMIO IO_MEMORY regions as well as the DMA interface for the device (IOMMU). This support aims to enable the DPDK to support the cdx devices in user-space using VFIO interface. Si

[PATCH v7 2/4] bus/cdx: add DMA map and unmap support

2023-06-06 Thread Nipun Gupta
AMD CDX bus can use VFIO interface for mapping and unmapping of DMA addresses in the IOMMU. This change adds the callback support for map and unmap APIs as well as fetching the IOMMU class. Signed-off-by: Nipun Gupta Acked-by: Ferruh Yigit --- drivers/bus/cdx/cdx.c | 30

[PATCH v7 3/4] bus/cdx: add support for MSI

2023-06-06 Thread Nipun Gupta
MSI's are exposed to the devices using VFIO (vfio-cdx). This patch uses the same to add support for MSI for the devices on the cdx bus. Signed-off-by: Nipun Gupta Acked-by: Ferruh Yigit --- drivers/bus/cdx/bus_cdx_driver.h | 25 + drivers/bus/cdx/cdx.c| 11 ++ drivers/bus/cdx/

[PATCH v7 4/4] bus/cdx: support plug unplug and dev iterator

2023-06-06 Thread Nipun Gupta
This change adds support for plugging and unplugging CDX devices on AMD CDX bus. Also, CDX dev iterator support has been added for the CDX bus. Signed-off-by: Nipun Gupta Acked-by: Ferruh Yigit --- drivers/bus/cdx/bus_cdx_driver.h | 1 + drivers/bus/cdx/cdx.c| 122

Re: [PATCH] net/nfp: remove unused struct fields

2023-06-06 Thread Ferruh Yigit
On 6/5/2023 6:45 AM, Chaoyong He wrote: > Remove the data fields of nfp structure which are not used by anyone, > and modify the corresponding logics. > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund > Applied to dpdk-next-net/main, thanks.

Re: [PATCH] doc: build manpages as well as html output

2023-06-06 Thread Bruce Richardson
On Tue, Jun 06, 2023 at 03:16:27PM +0530, Jerin Jacob wrote: > On Tue, Jun 6, 2023 at 2:49 PM Bruce Richardson > wrote: > > > > On Mon, Jun 05, 2023 at 10:50:48AM +0530, Jerin Jacob wrote: > > > On Thu, Jun 1, 2023 at 9:08 PM Bruce Richardson > > > wrote: > > > > > > > > Doxygen can produce manpa

[PATCH v5] crypto/qat: default to IPsec MB for computations

2023-06-06 Thread Brian Dooley
Pre and post computations currently use the OpenSSL library by default. This patch changes the default option to Intel IPsec MB library version 1.4 for the required computations. If this version of IPsec is not met it will fallback to use OpenSSL. Added version checks for libipsecmb and libcrypto

RE: [PATCH] maintainers: update ENA PMD maintainers list

2023-06-06 Thread Beider, Ron
-Original Message- From: Ferruh Yigit Sent: Wednesday, March 1, 2023 12:22 AM To: Brandes, Shai ; Michal Krawczyk ; m...@semihalf.com; Beider, Ron ; Thomas Monjalon Cc: dev@dpdk.org Subject: RE: [EXTERNAL][PATCH] maintainers: update ENA PMD maintainers list Hello Ferruh, Sorry for the

Re: [PATCH] doc: build manpages as well as html output

2023-06-06 Thread Jerin Jacob
On Tue, Jun 6, 2023 at 3:49 PM Bruce Richardson wrote: > > On Tue, Jun 06, 2023 at 03:16:27PM +0530, Jerin Jacob wrote: > > On Tue, Jun 6, 2023 at 2:49 PM Bruce Richardson > > wrote: > > > > > > On Mon, Jun 05, 2023 at 10:50:48AM +0530, Jerin Jacob wrote: > > > > On Thu, Jun 1, 2023 at 9:08 PM Br

[PATCH] ci: fix build for Arm cross compilation in GHA

2023-06-06 Thread David Marchand
We are hitting a storage limit when linking binaries statically. On the other hand, native builds are tested in other part of the CI and the chance of breaking static linking only is relatively low, so let's simply test linking against shared libraries. Cc: sta...@dpdk.org Signed-off-by: David Ma

Re: [PATCH] doc: build manpages as well as html output

2023-06-06 Thread Bruce Richardson
On Tue, Jun 06, 2023 at 04:19:27PM +0530, Jerin Jacob wrote: > On Tue, Jun 6, 2023 at 3:49 PM Bruce Richardson > wrote: > > > > On Tue, Jun 06, 2023 at 03:16:27PM +0530, Jerin Jacob wrote: > > > On Tue, Jun 6, 2023 at 2:49 PM Bruce Richardson > > > wrote: > > > > > > > > On Mon, Jun 05, 2023 at 1

Re: [PATCH] ci: fix build for Arm cross compilation in GHA

2023-06-06 Thread Bruce Richardson
On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote: > We are hitting a storage limit when linking binaries statically. > On the other hand, native builds are tested in other part of the CI and > the chance of breaking static linking only is relatively low, so let's > simply test linking

[PATCH v1 0/2] mlx5 supports InfiniBand BTH item match

2023-06-06 Thread Dong Zhou
mlx5 supports InfiniBand BTH item match by SWS and HWS. depends-on: http://patches.dpdk.org/project/dpdk/patch/20230531032653.3037946-1-dongz...@nvidia.com/ ("ethdev: add flow item for RoCE infiniband BTH") v1: - Update mlx5.ini and mlx5.rst doc in the first patch. Dong Zhou (2): net/mlx5: a

[PATCH v1 2/2] net/mlx5/hws: add support for infiniband BTH match

2023-06-06 Thread Dong Zhou
This patch adds support to match opcode and dst_qp fields in infiniband BTH. Currently, only the RoCEv2 packet is supported, the input BTH match item is defaulted to match one RoCEv2 packet. Signed-off-by: Dong Zhou Acked-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_definer.c | 76 ++

[PATCH v1 1/2] net/mlx5: add support for infiniband BTH match

2023-06-06 Thread Dong Zhou
This patch adds support to match opcode and dst_qp fields in infiniband BTH. Currently, only the RoCEv2 packet is supported, the input BTH match item is defaulted to match one RoCEv2 packet. Signed-off-by: Dong Zhou Acked-by: Ori Kam --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nic

Re: [PATCH] net/nfp: use common helper to trigger stats metering

2023-06-06 Thread Ferruh Yigit
On 6/5/2023 6:53 AM, Chaoyong He wrote: > From: Jin Liu > > Use rte_eal_alarm_set() function instead of clock cycle to > implement meter stats timer, to make code more standard. > > Signed-off-by: Jin Liu > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > Applied to dpdk-next-net/m

[PATCH] net/hns3: fix the way to trigger IMP reset

2023-06-06 Thread Dongdong Liu
From: Huisong Li Currently, driver sends the command with an unknown opcode to the firmware to trigger IMP reset when some hardware error happened. This unknown opcode cannot be parsed by the firmware. So this patch fixes the way by writing register to do it. Fixes: 2790c6464725 ("net/hns3: sup

[PATCH] doc: deprecation notice to add RSS hash algorithm field

2023-06-06 Thread Dongdong Liu
Deprecation notice to add "func" field to ``rte_eth_rss_conf`` structure for RSS hash algorithm. Signed-off-by: Dongdong Liu --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rs

Re: [PATCH v7 1/4] bus/cdx: introduce AMD CDX bus

2023-06-06 Thread Thomas Monjalon
06/06/2023 12:02, Nipun Gupta: > +/* Forward declarations */ > +struct rte_cdx_device; > +struct rte_cdx_driver; > +struct rte_cdx_bus; You should be very careful about what you export. > + > +#define CDX_BUS_DEVICES_PATH "/sys/bus/cdx/devices" This define is not needed in the .h file. > + > +#

Re: [PATCH] ci: fix build for Arm cross compilation in GHA

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 12:00 PM, Bruce Richardson wrote: > On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote: >> We are hitting a storage limit when linking binaries statically. >> On the other hand, native builds are tested in other part of the CI and >> the chance of breaking static linking onl

Re: [PATCH] maintainers: update ENA PMD maintainers list

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 11:40 AM, Beider, Ron wrote: >> >>> >>> The main driver maintenance is now handled by Amazon, and the new Amazon >>> maintainer has been added (Ron Beider). >>> >>> As Semihalf interaction with the ENA PMD is going to be limited, Marcin >>> Wojtas was removed from the maintainers lis

Re: [PATCH] maintainers: update for Reorder

2023-06-06 Thread Thomas Monjalon
> > Update maintainer for Reorder lib. > > > > Signed-off-by: Volodymyr Fialko > > Acked-by: Reshma Pattan Applied, thanks.

Re: [PATCH] ci: fix build for Arm cross compilation in GHA

2023-06-06 Thread Thomas Monjalon
06/06/2023 15:02, Ferruh Yigit: > On 6/6/2023 12:00 PM, Bruce Richardson wrote: > > On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote: > >> We are hitting a storage limit when linking binaries statically. > >> On the other hand, native builds are tested in other part of the CI and > >>

[PATCH v2] doc: build manpages as well as html output

2023-06-06 Thread Bruce Richardson
Doxygen can produce manpage output as well as html output for the DPDK APIs. However, we need to do this as a separate task as the manpage output needs to be placed in a different location post-install to the html output (/usr/local/share/man vs /usr/local/share/doc/). Changes required are: * Add

Re: [PATCH v7 1/4] bus/cdx: introduce AMD CDX bus

2023-06-06 Thread Nipun Gupta
On 6/6/2023 6:30 PM, Thomas Monjalon wrote: 06/06/2023 12:02, Nipun Gupta: +/* Forward declarations */ +struct rte_cdx_device; +struct rte_cdx_driver; +struct rte_cdx_bus; You should be very careful about what you export. + +#define CDX_BUS_DEVICES_PATH "/sys/bus/cdx/devices" This defi

Re: [PATCH v1 0/5] Implementation of revised ML xstats spec

2023-06-06 Thread Thomas Monjalon
23/04/2023 07:13, Srikanth Yalavarthi: > This series of patches introduces revised xstats specification for ML > device. The revised xstats spec is based on eventdev xstats and supports > DEVICE and MODEL modes to get xstats. This enables retrieving xstats for > device and each model separately. >

Re: [PATCH v7 1/4] bus/cdx: introduce AMD CDX bus

2023-06-06 Thread Thomas Monjalon
06/06/2023 15:38, Nipun Gupta: > > On 6/6/2023 6:30 PM, Thomas Monjalon wrote: > > > > 06/06/2023 12:02, Nipun Gupta: > >> +/* Forward declarations */ > >> +struct rte_cdx_device; > >> +struct rte_cdx_driver; > >> +struct rte_cdx_bus; > > > > You should be very careful about what you export. > >

Re: [PATCH 1/2] config/arm: update config for Neoverse N2

2023-06-06 Thread Thomas Monjalon
29/05/2023 07:57, Ruifeng Wang: > Updated maximum number of lcores and numa nodes to support platforms > with multiple numa nodes. > Added mcpu compiler option. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Feifei Wang Series applied, thanks.

Re: [PATCH] net/hns3: fix the way to trigger IMP reset

2023-06-06 Thread Ferruh Yigit
On 6/6/2023 1:10 PM, Dongdong Liu wrote: > From: Huisong Li > > Currently, driver sends the command with an unknown opcode to the > firmware to trigger IMP reset when some hardware error happened. > This unknown opcode cannot be parsed by the firmware. > > So this patch fixes the way by writing

Re: [PATCH v8] enhance NUMA affinity heuristic

2023-06-06 Thread Thomas Monjalon
01/06/2023 16:42, David Marchand: > On Fri, May 26, 2023 at 11:03 AM Kaisen You wrote: > > > > When a DPDK application is started on only one numa node, memory is > > allocated for only one socket. When interrupt threads use memory, > > memory may not be found on the socket where the interrupt thr

Re: [PATCH v3] app/testpmd: expand noisy neighbour forward mode support

2023-06-06 Thread Ferruh Yigit
On 6/1/2023 5:23 PM, Kevin Traynor wrote: > On 26/05/2023 18:32, Mike Pattrick wrote: >> On Fri, May 26, 2023 at 11:34 AM Kevin Traynor >> wrote: >>> >>> On 17/04/2023 19:55, Mike Pattrick wrote: Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding pack

Re: [PATCH] bus/vmbus: add cleanup support

2023-06-06 Thread Thomas Monjalon
21/03/2023 20:31, lon...@linuxonhyperv.com: > From: Long Li > > Implement VMBUS cleanup callback from eal_cleanup(). > > Signed-off-by: Long Li > --- > drivers/bus/vmbus/vmbus_common.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/drivers/bus/vmbus/vm

Re: [PATCH v4] app/testpmd: expand noisy neighbour forward mode support

2023-06-06 Thread Ferruh Yigit
On 6/2/2023 7:29 PM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswap

RE: [PATCH v2 0/6] changes for 23.07

2023-06-06 Thread Vargas, Hernan
Hi Maxime, Kind reminder to review this series when you have a chance: https://patchwork.dpdk.org/project/dpdk/list/?series=28189 Thanks, Hernan > -Original Message- > From: Vargas, Hernan > Sent: Thursday, May 25, 2023 1:28 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; gak...@marv

Re: [PATCH v2] bus/auxiliary: support cleanup callback

2023-06-06 Thread Thomas Monjalon
17/03/2023 16:24, Xueming Li: > The bus cleanup callback is used to sunset all devices on bus > gracefully. This patch supports the callback by unplug all > devices on auxiliary bus. > > Signed-off-by: Xueming Li Applied, thanks.

Re: [PATCH] pci: fix comment referencing renamed function

2023-06-06 Thread Thomas Monjalon
31/05/2023 08:02, Xia, Chenbo: > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, May 31, 2023 12:02 AM > > To: dev@dpdk.org > > Cc: sta...@dpdk.org; Gaetan Rivet ; David Marchand > > > > Subject: [PATCH] pci: fix comment referencing renamed function > > > > When renam

Re: [PATCH v3] app/test-pmd: fix not polling all queues without deferred starting

2023-06-06 Thread Ferruh Yigit
On 5/29/2023 3:26 AM, Jie Hai wrote: > > Each stream has a read-only "disabled" field that control if this > stream should be used to forward. This field depends on states > of Rx/Tx queues, please see > commit 3c4426db54fc ("app/testpmd: do not poll stopped queues"). > > Currently, the testpmd

[PATCH v8 00/17] graph enhancement for multi-core dispatch

2023-06-06 Thread Zhirun Yan
V8: No performance dorp for original l3fwd-graph and graph_perf_autotest. Update graph model set/get functions and add graph_model_is_valid() in patch 04. Update doc for new scheme usage(choose model in runtime or compile time). Update dispatch schedule struct into union. Change enum rte_graph_wor

[PATCH v8 01/17] graph: rename rte_graph_work as common

2023-06-06 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- MAINTAINERS | 3 ++- lib/graph/graph_pcap.c

[PATCH v8 02/17] graph: split graph worker into common and default model

2023-06-06 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_pcap.c

[PATCH v8 03/17] graph: move node process into inline function

2023-06-06 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33 +++

[PATCH v8 04/17] graph: add get/set graph worker model APIs

2023-06-06 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c| 21 ++ lib

[PATCH v8 05/17] graph: introduce graph node core affinity API

2023-06-06 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph_private.h | 2 + lib/graph

  1   2   >