On 6/2/2023 5:44 PM, Kaijun Zeng wrote:
> Improve error handling
>
> Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
> implementation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Kaijun Zeng <corez...@gmail.com>
> ---
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index 73ec1e4727..e615d40d09 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -1311,7 +1311,17 @@ vmxnet3_dev_rxtx_init(struct rte_eth_dev *dev)
> for (j = 0; j < VMXNET3_RX_CMDRING_SIZE; j++) {
> /* Passing 0 as alloc_num will allocate full ring */
> ret = vmxnet3_post_rx_bufs(rxq, j);
> - if (ret <= 0) {
> +
> + /* Zero number of descriptors in the configuration of
> the RX queue */
> + if (ret == 0) {
> + PMD_INIT_LOG(ERR,
> + "ERROR: Zero descriptor requirement in
> Rx queue: %d,"
> + "buffers ring: %d\n",
> + i, j);
> + return -EINVAL;
> + }
> + /* Return the errno */
> + if (ret < 0) {
> PMD_INIT_LOG(ERR,
> "ERROR: Posting Rxq: %d buffers
> ring: %d",
> i, j);
Looks good to me, @Jochen any objection?
