RE: [PATCH v1 2/8] app/testpmd: add IPv6 extension push remove cli

2023-05-24 Thread Ori Kam
Hi Rongwei, > -Original Message- > From: Rongwei Liu > Sent: Monday, April 17, 2023 12:26 PM > > Add command lines to generate IPv6 routing extension push and > remove patterns and follow the raw_encap/decap style. > > Add the new actions to the action template parsing. > > Generating

RE: [dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe

2023-05-24 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, January 5, 2023 4:34 PM > To: wangyunjian ; Thomas Monjalon > > Cc: dev@dpdk.org; qi.z.zh...@intel.com; anatoly.bura...@intel.com; > Huangshaozhang ; sta...@dpdk.org; > lianglipei > Subject: R

RE: [EXT] Re: [PATCH 02/13] security: add MACsec packet number threshold

2023-05-24 Thread Akhil Goyal
> On Wed, 24 May 2023 01:19:07 +0530 > Akhil Goyal wrote: > > > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > > index c7a523b6d6..30bac4e25a 100644 > > --- a/lib/security/rte_security.h > > +++ b/lib/security/rte_security.h > > @@ -399,6 +399,8 @@ struct rte_security_ma

Re: [PATCH v6 07/15] graph: introduce graph clone API for other worker core

2023-05-24 Thread Jerin Jacob
On Tue, May 9, 2023 at 11:35 AM Zhirun Yan wrote: > > This patch adds graph API for supporting to clone the graph object for > a specified worker core. The new graph will also clone all nodes. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > + >

RE: [EXT] Re: [PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning

2023-05-24 Thread Akhil Goyal
> On Tue, 23 May 2023 08:12:28 + > Akhil Goyal wrote: > > > > > > > This could happen if the passed in length to this routine was larger than > > > the amount of data in the mbuf. Should the function check and return an > error? > > > > > > Panic should only be reserved for seriously corrupte

Re: [PATCH v6 08/15] graph: add struct for stream moving between cores

2023-05-24 Thread Jerin Jacob
On Tue, May 9, 2023 at 11:35 AM Zhirun Yan wrote: > > Add graph_sched_wq_node to hold graph scheduling workqueue > node. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > + * @internal > + * > + * Structure that holds the graph scheduling workqueue node

Re: [PATCH v2 1/2] ethdev: add API to check queue ID validity

2023-05-24 Thread huangdengdui
On 2023/5/22 21:58, Andrew Rybchenko wrote: > On 5/22/23 16:09, Dengdui Huang wrote: >> The API rte_eth_dev_is_valid_rxq/txq checks >> the port ID validity and then the Rx/Tx queue ID is valid. > > What is valid Tx/Rx queue? It depends on on caller > expectations. Some functions are satisfied with

[PATCH v1 0/2] add IPv6 extension push remove

2023-05-24 Thread Rongwei Liu
Add new rte_actions to push and remove the specific type of IPv6 extension to and from original packets. v1: Split the PMD implementation, add a description into release notes. Rongwei Liu (2): ethdev: add IPv6 extension push remove action app/testpmd: add IPv6 extension push remove cli app

[PATCH v1 1/2] ethdev: add IPv6 extension push remove action

2023-05-24 Thread Rongwei Liu
Add new rte_actions to push and remove the specific type of IPv6 extension to and from original packets. A new extension to be pushed should be the last extension due to the next header awareness. Remove can support the IPv6 extension in any position. Signed-off-by: Rongwei Liu --- doc/guides/

[PATCH v1 2/2] app/testpmd: add IPv6 extension push remove cli

2023-05-24 Thread Rongwei Liu
Add command lines to generate IPv6 routing extension push and remove patterns and follow the raw_encap/decap style. Add the new actions to the action template parsing. Generating the action patterns 1. IPv6 routing extension push set ipv6_ext_push 1 ipv6_ext type is 43 / ipv6_routing_

Re: [PATCH v6 09/15] graph: introduce stream moving cross cores

2023-05-24 Thread Jerin Jacob
On Tue, May 9, 2023 at 11:35 AM Zhirun Yan wrote: > > This patch introduces key functions to allow a worker thread to > enable enqueue and move streams of objects to the next nodes over > different cores. different cores-> different cores for mcore dispatch model. > > Signed-off-by: Haiyue Wang

Re: [PATCH v6 13/15] graph: add stats for cross-core dispatching

2023-05-24 Thread Jerin Jacob
On Tue, May 9, 2023 at 11:35 AM Zhirun Yan wrote: > > Add stats for cross-core dispatching scheduler if stats collection is > enabled. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h > index

RE: [EXT] Re: [PATCH 02/13] security: add MACsec packet number threshold

2023-05-24 Thread Akhil Goyal
> Subject: RE: [EXT] Re: [PATCH 02/13] security: add MACsec packet number > threshold > > > On Wed, 24 May 2023 01:19:07 +0530 > > Akhil Goyal wrote: > > > > > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > > > index c7a523b6d6..30bac4e25a 100644 > > > --- a/lib/security

Re: [PATCH v6 15/15] doc: update multicore dispatch model in graph guides

2023-05-24 Thread Jerin Jacob
On Tue, May 9, 2023 at 11:35 AM Zhirun Yan wrote: > > Update graph documentation to introduce new multicore dispatch model. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > doc/guides/prog_guide/graph_lib.rst | 59 +++-- >

RE: [PATCH v4 1/7] common/idpf: fix 64b timestamp roll over issue

2023-05-24 Thread Liu, Mingxia
> -Original Message- > From: Qiao, Wenjing > Sent: Friday, May 19, 2023 4:31 PM > To: Wu, Jingjing ; Xing, Beilei > ; > Zhang, Qi Z > Cc: dev@dpdk.org; Liu, Mingxia ; Qiao, Wenjing > ; sta...@dpdk.org > Subject: [PATCH v4 1/7] common/idpf: fix 64b timestamp roll over issue > > Reading

Re: [PATCH v6 12/15] graph: enable graph multicore dispatch scheduler model

2023-05-24 Thread Jerin Jacob
On Tue, May 9, 2023 at 11:35 AM Zhirun Yan wrote: > > This patch enables to chose new scheduler model. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > rte_graph_walk(struct rte_graph *graph) > { > - rte_graph_walk_rtc(graph); > + int mo

[PATCH 1/2] event/cnxk: fix ns to ticks conversion

2023-05-24 Thread pbhagavatula
From: Pavan Nikhilesh The number of timeout ticks is dependent on the global dequeue timeout configured. Fixes: 6223ede20361 ("event/cnxk: add event port link and unlink") Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_eventdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH 2/2] event/cnxk: honor event limit set by config

2023-05-24 Thread pbhagavatula
From: Pavan Nikhilesh Honor the number of events configured during event device configuration. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_eventdev.c | 7 ++- drivers/event/cnxk/cnxk_eventdev.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/even

RE: [v1 1/3] net/mlx5/hws: support dest root table action

2023-05-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Hamdan Igbaria > Sent: Monday, March 20, 2023 4:12 PM > To: Hamdan Igbaria ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; Matan > Azrad > Cc: dev@dpdk.org; Ori Kam ; Alex Vesker > > Subject: [v1 1/3] net/mlx5/hws: support

Re: [PATCH v2 1/2] ethdev: add API to check queue ID validity

2023-05-24 Thread Andrew Rybchenko
On 5/24/23 10:38, huangdengdui wrote: On 2023/5/22 21:58, Andrew Rybchenko wrote: On 5/22/23 16:09, Dengdui Huang wrote: The API rte_eth_dev_is_valid_rxq/txq checks the port ID validity and then the Rx/Tx queue ID is valid. What is valid Tx/Rx queue? It depends on on caller expectations. Some

RE: [PATCH v3 05/10] net/cpfl: support hairpin queue setup and release

2023-05-24 Thread Liu, Mingxia
> +cpfl_tx_hairpin_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, > + uint16_t nb_desc, > + const struct rte_eth_hairpin_conf *conf) { > + struct cpfl_vport *cpfl_vport = > + (struct cpfl_vport *)dev->data->dev_private; > + > +

RE: [PATCH] examples/ipsec-secgw: fix zero address in ethernet header

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH] examples/ipsec-secgw: fix zero address in ethernet header > > > > During port init, src address stored in ethaddr_tbl is typecast > > which violates the stric-aliasing rule and not reflecting > > the updated source address in processed packets too. > > > > Fixes: 6eb3ba0399 ("e

RE: [RFC v2 1/3] ethdev: add frequency adjustment API

2023-05-24 Thread Su, Simei
Hi Thomas, Thanks a lot for your review. I have already sent RFC v3 patch based on your comments. https://patchwork.dpdk.org/project/dpdk/cover/20230522132332.102030-1-simei...@intel.com/ Thanks, Simei > -Original Message- > From: Thomas Monjalon > Sent: Monday, May 15, 2023 10:18 PM >

RE: [PATCH] app/crypto-perf: change buffer size based on optype

2023-05-24 Thread Akhil Goyal
> Subject: RE: [PATCH] app/crypto-perf: change buffer size based on optype > > > Adding digest size to buffer size in auth-then-cipher mode with auth_op set > > to > > generate as cipher length includes digest size also. > > > > Signed-off-by: Tejasree Kondoj > > --- > > app/test-crypto-perf/cp

Re: [PATCH v2 5/5] mempool/cnxk: add support for exchanging mbufs between pools

2023-05-24 Thread Jerin Jacob
On Tue, May 23, 2023 at 6:30 PM Ashwin Sekhar T K wrote: > > Add the following cnxk mempool PMD APIs to facilitate exchanging mbufs > between pools. > * rte_pmd_cnxk_mempool_is_hwpool() - Allows user to check whether a pool >is hwpool or not. > * rte_pmd_cnxk_mempool_range_check_disable() -

Re: [PATCH v2] ethdev: fix asynchronous destroy and push tracepoints

2023-05-24 Thread Ferruh Yigit
On 5/23/2023 6:39 PM, Alexander Kozyrev wrote: > The rte_flow_async_destroy() and rte_flow_push() API is > intended to be as fast as possible and tracepoints for > these functions must be marked as fast-path tracepoints. > > Fixes: 6679cf21d608 ("ethdev: add trace points") > > Signed-off-by: Alex

Re: [RFC v2 1/2] dts: add smoke tests

2023-05-24 Thread Juraj Linkeš
I'm sending the second part of the review separately. This is only about implementation-specific details, the other comments still apply (such as how I'd like to move/structure the code). In general, it really looks like we have to go this route. It's kind of a pexpect-lite approach, which seems f

RE: [EXT] [PATCH v4 0/2] crypto/qat: add cipher-crc offload feature

2023-05-24 Thread Akhil Goyal
> This patchset adds support to the QAT PMD for combined cipher-crc > processing for DOCSIS on the QAT device. The current QAT PMD > implementation of cipher-crc calculates CRC in software and uses QAT > for encryption/decryption offload. > > Note: The previous code-path is still retained for QAT

[PATCH v2 03/32] common/cnxk: fix CPT backpressure disable on LBK

2023-05-24 Thread Nithin Dabilpuram
From: Rahul Bhansali For LBK interfaces, roc_nix_inl_inb_is_enabled() is false, hence backpressure on CPT is disabled and causing CQ full interrupt. NIXX_AF_RX_CHAN[0x800]_CFG is global config for all PF, VF of RPM/LBK, hence backpressure disable on CPT is not required. Fixes: 0663a84524e ("comm

[PATCH v2 01/32] common/cnxk: allocate dynamic BPIDs

2023-05-24 Thread Nithin Dabilpuram
From: Satha Rao New mail box to allocate/free dynamic BPIDs based on NIX type. Added to new mail box APIs to get/set RX channel config with new BPIDs. Signed-off-by: Satha Rao --- v2: - Rebased on top of dpdk-next-net-mrvl - Handled comments from Jerin w.r.t commit messages - Added few more fix

[PATCH v2 04/32] common/cnxk: skip flow ctrl set on non-existent meta aura

2023-05-24 Thread Nithin Dabilpuram
Skip setting flow control on local meta aura if it is not yet created. Also in flow control mode set, do get to confirm if it is in same state to avoid a set and unnecessary mbox failures. Signed-off-by: Nithin Dabilpuram --- .mailmap | 1 + drivers/common/cnxk/roc_dev.

[PATCH v2 02/32] common/cnxk: add pool BPID to RQ while using common pool

2023-05-24 Thread Nithin Dabilpuram
From: Shijith Thotton When RQs of two different traffic classes are using the same mempool, BPIDs could differ between the RQs and BPID of only one RQ can be configured per pool. In such cases, a new BPID is configured on both RQs and pool or pool back-pressure is disabled. CN103xx and CN106xx B

[PATCH v2 05/32] common/cnxk: reduce sqes per sqb by one

2023-05-24 Thread Nithin Dabilpuram
From: Satha Rao Each SQB reserves last SQE to store pointer to next SQB. So each SQB will holds either 31 or 63 based on send descriptors selected. This patch also consider sqb_slack to maintain threshold buffers to sync between HW and SW. Threshold will be maximum of 30% of queue size or sqb_sl

[PATCH v2 06/32] common/cnxk: dump SW SSO work count as xstat

2023-05-24 Thread Nithin Dabilpuram
Dump SW SSO work count as xstat. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_inl_dev_irq.c | 1 + drivers/common/cnxk/roc_nix_inl_priv.h| 1 + drivers/common/cnxk/roc_nix_stats.c | 17 +++-- drivers/common/cnxk/roc_nix_xstats.h | 4 4 files

[PATCH v2 07/32] common/cnxk: add percent drop threshold to pool

2023-05-24 Thread Nithin Dabilpuram
From: Sunil Kumar Kori Currently hard coded drop threshold(95%) is configured to aura/pool as a threshold for drop limit. Patch adds a input parameter to RoC API so that user passed percentage value can be configured. Signed-off-by: Sunil Kumar Kori --- drivers/common/cnxk/roc_nix.h

[PATCH v2 08/32] common/cnxk: make aura flow control config more predictable

2023-05-24 Thread Nithin Dabilpuram
Restrict shared BPID config only when force BP is enabled and make aura flow control config more predictable by not disabling it if there is a collision but ignore new config and log the same. Also remove BPID setup from Rx adapter as it is now evaluated and configured every time ethdev is stopped

[PATCH v2 09/32] common/cnxk: update age drop statistics

2023-05-24 Thread Nithin Dabilpuram
From: Satha Rao Update age drop statistics. Added telemetry statistics for age drops. Signed-off-by: Satha Rao --- drivers/common/cnxk/cnxk_telemetry_nix.c | 4 drivers/common/cnxk/hw/nix.h | 2 ++ drivers/common/cnxk/roc_features.h | 6 ++ drivers/common/cnxk/roc_ni

[PATCH v2 10/32] common/cnxk: fetch eng caps for inl outb inst format

2023-05-24 Thread Nithin Dabilpuram
Fetch engine caps and use it along with model check to determine inline outbound instruction format with NIX Tx offset or address. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_cpt.h | 3 + drivers/common/cnxk/roc_nix_inl.c | 101 drivers/com

[PATCH v2 11/32] common/cnxk: add receive error mask

2023-05-24 Thread Nithin Dabilpuram
From: Rakesh Kudurumalla Adding support to configure receive error mask for 106B0 Signed-off-by: Rakesh Kudurumalla --- drivers/common/cnxk/roc_features.h | 6 ++ drivers/common/cnxk/roc_nix.h | 16 2 files changed, 22 insertions(+) diff --git a/drivers/common/cnxk/

[PATCH v2 12/32] common/cnxk: fix null pointer dereference

2023-05-24 Thread Nithin Dabilpuram
From: Gowrishankar Muthukrishnan Fix null pointer dereferences reported by klocwork. Fixes: 4398c4092f3d ("common/cnxk: dump inline device RQ context") Fixes: 79dc6f324e82 ("common/cnxk: add inline function for statistics") cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- dri

[PATCH v2 13/32] common/cnxk: fix parameter in NIX dump

2023-05-24 Thread Nithin Dabilpuram
From: Gowrishankar Muthukrishnan Fix parameter passed to nix_dump to what expected in format specifier. Fixes: d2f168dfa5de ("common/cnxk: support 10K B0 for inline IPsec") cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/roc_nix_debug.c | 4 ++-- 1 file ch

[PATCH v2 14/32] common/cnxk: set relchan in TL4 config for each SDP queue

2023-05-24 Thread Nithin Dabilpuram
From: Veerasenareddy Burru set distinct relchan in each TL4 queue connected to SDP. currently rechan in TL4 SDP config is getting set to 0 for all SDP-NIX queues. Each TL4 queues for SDP need to be configured with distinct channel for SDP to provide per channel backpressure to NIX. Signed-off-b

[PATCH v2 15/32] common/cnxk: avoid STALL with dual rate on CNF95N

2023-05-24 Thread Nithin Dabilpuram
From: Satha Rao Due to errata RED_ALGO STALL with dual shaper rate will hangs on platforms CNF95N and CNF95O. Set READ_ALGO to DISCARD with dual shaper rate on CNF95N and CNF95O. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix_tm_utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 del

[PATCH v2 16/32] common/cnxk: update errata info

2023-05-24 Thread Nithin Dabilpuram
Update errata info based on CN10KA B0 and CN10KB A0. Also remove duplicate model check roc_model_is_cn103xx() Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_errata.h | 20 drivers/common/cnxk/roc_features.h | 2 +- drivers/common/cnxk/roc_model.h| 6 ---

[PATCH v2 17/32] common/cnxk: sync between mbox up and down messages

2023-05-24 Thread Nithin Dabilpuram
From: Harman Kalra An issue is observed where if PF is with DPDK and VF as kernel netdev does not responds to link events. It was due to recent design change in kernel where sender checks whether previous interrupt is received before triggering current interrupt by waiting for mailbox data regist

[PATCH v2 18/32] common/cnxk: add more comments to mbox code

2023-05-24 Thread Nithin Dabilpuram
From: Harman Kalra Adding more comments to the mbox routines to understand the flow well. Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_dev.c | 20 +--- drivers/common/cnxk/roc_mbox.c | 5 + 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 19/32] common/cnxk: add CN105xxN B0 model

2023-05-24 Thread Nithin Dabilpuram
From: Harman Kalra Adding support for CN105xxN B0 pass Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_model.c | 1 + drivers/common/cnxk/roc_model.h | 9 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_model.c b/drivers/common/cnxk/roc_m

[PATCH v2 21/32] net/cnxk: add receive error mask

2023-05-24 Thread Nithin Dabilpuram
From: Rakesh Kudurumalla receive errors related to MACSEC and USXGMI are masked for cn10kb_b0 and cn10kb Signed-off-by: Rakesh Kudurumalla --- drivers/net/cnxk/cnxk_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c

[PATCH v2 20/32] common/cnxk: access valid pass value

2023-05-24 Thread Nithin Dabilpuram
From: Hanumanth Pothula There is a possibility of accessing an invalid pass value on rvu device look up failure, as the return value is dropped. Hence pass through the return value of rvu device look, to make sure valid pass value is accessed. Signed-off-by: Hanumanth Pothula --- drivers/comm

[PATCH v2 22/32] common/cnxk: support of 1-N pool-aura per NIX LF

2023-05-24 Thread Nithin Dabilpuram
From: Rahul Bhansali This will add the support of 1:N pool:aura per NIX LF when inl_cpt_channel devargs is set to inline device, otherwise it will create 1:1 pool:aura for CN103/CN106B0 SOCs. With 1:N, global pool will be created with Aura 0, and per NIX individual aura will be created and mappe

[PATCH v2 23/32] net/cnxk: support for inbound without inline dev mode

2023-05-24 Thread Nithin Dabilpuram
Support for inbound Inline IPsec without Inline device RQ i.e both first pass and second pass hitting same ethdev RQ in poll mode. Remove the switching from inline dev to non inline dev mode as inline dev mode is default and can only be overridden by devargs. Signed-off-by: Nithin Dabilpuram ---

[PATCH v2 24/32] common/cnxk: fix inline device VF identification

2023-05-24 Thread Nithin Dabilpuram
Fix inline device VF identification so that the right mbox region is used. Fixes: ee48f711f3b0 ("common/cnxk: support NIX inline inbound and outbound setup") cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 25/32] common/cnxk: avoid inline dev CPT lf detach multiple times

2023-05-24 Thread Nithin Dabilpuram
CPT LF detach is done along with all other LF's of inline device. Hence remove it from nix_inl_cpt_release(). Also provide ROC API for setup and release of CPT LF separately. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_inl.h | 2 + drivers/common/cnxk/roc_nix_inl_dev.c

[PATCH v2 26/32] common/cnxk: skip CGX promisc mode with NPC exact match

2023-05-24 Thread Nithin Dabilpuram
When NPC exact match is enabled, we cannot use CGX promisc mode as CGX filtering is permanently disabled. Hence skip calling it to avoid mbox errors. Signed-off-by: Nithin Dabilpuram Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/roc_nix_mac.c | 8 drivers/common/cnxk/roc_nix_pr

[PATCH v2 27/32] common/cnxk: configure PFC on SPB aura

2023-05-24 Thread Nithin Dabilpuram
From: Sunil Kumar Kori A RQ can be configured with lpb_aura and spb_aura at the same time and both can contribute to generate aura based back pressure from NIX to RPM. But currently PFC configuration are applied on lpb_aura only and spb_aura does not contribute to create back pressure. Patch ad

[PATCH v2 28/32] common/nix: check for null derefernce

2023-05-24 Thread Nithin Dabilpuram
From: Gowrishankar Muthukrishnan Check for NULL value return before dereferencing on it. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/roc_nix.c| 8 +++- drivers/common/cnxk/roc_nix_fc.c | 7 ++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v2 29/32] common/cnxk: fix receive queue with multiple mask

2023-05-24 Thread Nithin Dabilpuram
From: Rakesh Kudurumalla enable or disable RQ mask based on function parameter.This fix allocates different profile for different rq masks Fixes: ddf955d3917e ("common/cnxk: support CPT second pass") cc: sta...@dpdk.org Signed-off-by: Rakesh Kudurumalla --- drivers/common/cnxk/roc_nix_inl.c |

[PATCH v2 30/32] net/cnxk: handle extbuf completion on ethdev stop

2023-05-24 Thread Nithin Dabilpuram
From: Rakesh Kudurumalla During tranmissoin of packets, CQ corresponding to SQ is polled for transmit completion packets in transmit function, when last burst is transmitted corresponding transmit completion packets are left in CQ.This patch reads leftover packets in CQ on ethdev stop.Moved trans

[PATCH v2 31/32] net/cnxk: add aes-ccm to inline IPsec capabilities

2023-05-24 Thread Nithin Dabilpuram
From: Srujana Challa Declares AES-CCM support in inline IPsec capabilities. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn10k_ethdev_sec.c | 30 + drivers/net/cnxk/cn9k_ethdev_sec.c | 30 + 2 files changed, 60 insertions(+) diff

[PATCH v2 32/32] common/cnxk: add check for null auth and anti-replay

2023-05-24 Thread Nithin Dabilpuram
From: Srujana Challa As per IPsec RFC, the anti-replay service can be selected for an SA only if the integrity service is selected for that SA. This patch adds the validation check for the same. Signed-off-by: Srujana Challa --- drivers/common/cnxk/cnxk_security.c | 9 + 1 file changed

[PATCH v2 0/3] add support for infiniband BTH match

2023-05-24 Thread Dong Zhou
Add new rte item to match the infiniband BTH in RoCE packets. v2: - Change "ethernet" name to "Ethernet" in the commit log. - Add "RoCE" and "IB" 2 words to words-case.txt. - Add "rte_byteorder.h" header file in "rte_ib.h" to fix compile errors. - Add "Acked-by" labels in the first ethdev patc

[PATCH v2 1/3] ethdev: add flow item for RoCE infiniband BTH

2023-05-24 Thread Dong Zhou
IB(InfiniBand) is one type of networking used in high-performance computing with high throughput and low latency. Like Ethernet, IB defines a layered protocol (Physical, Link, Network, Transport Layers). IB provides native support for RDMA(Remote DMA), an extension of the DMA that allows direct acc

[PATCH v2 2/3] net/mlx5: add support for infiniband BTH match

2023-05-24 Thread Dong Zhou
This patch adds support to match opcode and dst_qp fields in infiniband BTH. Currently, only the RoCEv2 packet is supported, the input BTH match item is defaulted to match one RoCEv2 packet. Signed-off-by: Dong Zhou --- drivers/common/mlx5/mlx5_prm.h | 5 +- drivers/net/mlx5/mlx5_flow.h|

[PATCH v2 3/3] net/mlx5/hws: add support for infiniband BTH match

2023-05-24 Thread Dong Zhou
This patch adds support to match opcode and dst_qp fields in infiniband BTH. Currently, only the RoCEv2 packet is supported, the input BTH match item is defaulted to match one RoCEv2 packet. Signed-off-by: Dong Zhou --- drivers/net/mlx5/hws/mlx5dr_definer.c | 76 ++- driv

[PATCH v2] net/ice: DCF adds default RSS

2023-05-24 Thread Mingjin Ye
The default RSS configured by the kernel driver for the DCF port does not work properly when the DCF and iavf ports are used together. This patch clears the RSS configured by the kernel driver and reconfigures the default RSS for it when the DCF port is initialized. Signed-off-by: Mingjin Ye ---

RE: [PATCH v1 1/2] ethdev: add IPv6 extension push remove action

2023-05-24 Thread Ori Kam
Hi, > -Original Message- > From: Rongwei Liu > Sent: Wednesday, May 24, 2023 10:39 AM > > Add new rte_actions to push and remove the specific > type of IPv6 extension to and from original packets. > > A new extension to be pushed should be the last extension > due to the next header awa

RE: [PATCH] cryptodev: clarify error codes returned

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH] cryptodev: clarify error codes returned > > > > When symmetric sessions are created, it may fail due to non-critical > > errors. When PMD doesn't support the specific combination that > > application requested, it can return -ENOTSUP which can be handled so in > > application.

Re: [PATCH v4] ethdev: add flow rule actions update API

2023-05-24 Thread Ferruh Yigit
On 5/23/2023 7:39 PM, Alexander Kozyrev wrote: > Introduce the new rte_flow_actions_update() API allowing users > to update the action list in the already existing rule. > Flow rules can be updated now without the need to destroy > the rule first and create a new one instead. > A single API call en

Re: [PATCH v4 3/4] bus/cdx: add support for MSI

2023-05-24 Thread Thomas Monjalon
08/05/2023 13:18, Nipun Gupta: > MSI's are exposed to the devices using VFIO (vfio-cdx). This > patch uses the same to add support for MSI for the devices on > the cdx bus. > > A couple of API's have been introduced in the EAL interrupt > framework: > - rte_intr_irq_count_set: This API is used to

Re: [PATCH v4 1/4] bus/cdx: introduce cdx bus

2023-05-24 Thread Thomas Monjalon
Hello, If I understand well, it is very specific to AMD devices. So I suggest adding "AMD" in title and descriptions. 08/05/2023 13:18, Nipun Gupta: > CDX bus supports multiple type of devices, which can be > exposed to user-space via vfio-cdx. > > vfio-cdx provides the MMIO IO_MEMORY regions as

[PATCH] doc: deprecation notice to add new hash function

2023-05-24 Thread Xueming Li
Deprecation notice to annouce new RSS hash function type. The new symmetric hash function sort L3 address and L4 ports before Toeplitz calculation. Signed-off-by: Xueming Li --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/depr

RE: [PATCH v2 0/8] add AESNI_MB optimisations

2023-05-24 Thread Akhil Goyal
> Series-acked-by: Kai Ji > > > -Original Message- > > From: Power, Ciara > > Sent: Tuesday, May 16, 2023 4:24 PM > > To: dev@dpdk.org > > Cc: Ji, Kai ; gak...@marvell.com; Power, Ciara > > > > Subject: [PATCH v2 0/8] add AESNI_MB optimisations > > > > This patchset adds some optimisati

[PATCH] common/mlx5: adjust fork call with the new kernel API

2023-05-24 Thread erezf
From: Erez Ferber While doing process fork() the operating system remaps all the parent process's memory to the address space of the child process and activates the Copy-on-Write mechanics - it duplicates physical pages once memory writing happens in the child process. Sometimes memory duplicatio

RE: [PATCH] crypto/openssl: fix memory free issue

2023-05-24 Thread Akhil Goyal
> Acked-by: Kai Ji > > > Subject: [PATCH] crypto/openssl: fix memory free issue > > > > From: Saoirse O'Donovan > > > > Allocated memory was being freed using 'free' when it should have been > > freed using 'OPENSSL_free'. This has now been modified so that the correct > > method is used to free

RE: [PATCH] test/crypto: fix return value from session

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH] test/crypto: fix return value from session > > > > Fixing return value if session failure occurs due to unsupported feature. > > > > Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto > > operations") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Tejasree Kondoj >

RE: [PATCH v2] app/crypto-perf: check crypto result

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH v2] app/crypto-perf: check crypto result > > > > Check crypto result in latency tests. Checking result won't affect the test > > results as latency is calculated using timestamps which are done before > > enqueue and after dequeue. Ignoring result means the data can be false > >

RE: [EXT] [PATCH v2] crypto/ipsec_mb: enqueue counter fix

2023-05-24 Thread Akhil Goyal
> This patch removes enqueue op counter update from the process_op_bit > function where the process is now done in dequeue stage. The original > stats increment was incorrect as they shouldn't have been updated at all > in this function. > > Fixes: 4f1cfda59ad3 ("crypto/ipsec_mb: move snow3g PMD")

RE: [PATCH 1/2] test/crypto: use separate keys for auth and cipher

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH 1/2] test/crypto: use separate keys for auth and cipher > > > > The mixed test cases can have keys with different key lengths. The routine > > which prepares the session parameters uses same key length for both cipher > > & auth keys. Instead allow the caller to use same keys as

RE: [PATCH] test/crypto: remove redundant code

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH] test/crypto: remove redundant code > > > > Code for registering raw API tests for various PMDs are repeated. > > Add common routine to avoid duplication of code. > > > > Signed-off-by: Anoob Joseph > > --- > > app/test/test_cryptodev.c | 40 ++-

RE: [RFC PATCH 4/5] power: add eventdev support for power management

2023-05-24 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] Hi, > -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, May 17, 2023 8:14 PM > To: Tummala, Sivaprasad ; > david.h...@intel.com; jer...@marvell.com; harry.van.haa...@intel.com > Cc: dev@dpdk.org > Subject: Re: [RFC PATCH 4/5] power: add even

Re: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics

2023-05-24 Thread David Marchand
Hello Tyler, On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff wrote: > > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > This series covers the libraries and drivers that are built on Windows. > > The code has be converted to use the

RE: [PATCH v2] test/crypto: free memory in error and skip paths

2023-05-24 Thread Akhil Goyal
> Subject: [PATCH v2] test/crypto: free memory in error and skip paths > > In multi session tests, multiple sessions get created. So the handling > in ut_teardown won't guard against any memory that is not freed by the > test case. Test case should free sessions as well as local memory that > was

RE: [PATCH] doc: deprecation notice to add new hash function

2023-05-24 Thread Ori Kam
Hi Xueming, > -Original Message- > From: Xueming(Steven) Li > Sent: Wednesday, May 24, 2023 2:38 PM > > Deprecation notice to annouce new RSS hash function type. > The new symmetric hash function sort L3 address and L4 ports > before Toeplitz calculation. > > Signed-off-by: Xueming Li

[PATCH v2] test/crypto: fix IPsec AES CCM test vector

2023-05-24 Thread Tejasree Kondoj
Set IPsec AES-CCM test vector IV length to 11 instead of 12 as it includes only 3B salt and 8B per packet IV. Fixes: d314299950de ("test/crypto: add AES-CCM vectors") Cc: sta...@dpdk.org Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev_security_ipsec_test_vectors.h | 3 ++- 1 file cha

Re: [PATCH 0/3] use C11 memory model GCC builtin atomics

2023-05-24 Thread David Marchand
On Mon, Mar 27, 2023 at 4:30 PM Tyler Retzlaff wrote: > > Replace the use of __sync__and_fetch and __sync_fetch_and_ atomics > with GCC C11 memory model __atomic builtins. > > This series contributes to converging on standard atomics in 23.11 but is > kept separate as there may be sensitivity to c

RE: [PATCH v2 2/3] net/mlx5: add support for infiniband BTH match

2023-05-24 Thread Ori Kam
Hi Bill, > -Original Message- > From: Bill Zhou > Sent: Wednesday, May 24, 2023 1:08 PM > > This patch adds support to match opcode and dst_qp fields in > infiniband BTH. Currently, only the RoCEv2 packet is supported, > the input BTH match item is defaulted to match one RoCEv2 packet. >

Re: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-05-24 Thread David Marchand
Hello guys, On Fri, May 5, 2023 at 12:31 PM David Marchand wrote: > > As reported by Ilya [1], unconditionally calling > rte_flow_get_restore_info() impacts an application performance for drivers > that do not provide this ops. > It could also impact processing of packets that require no call to

RE: [PATCH v2] common/mlx5: enable operation in iova virtual address mode

2023-05-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, April 12, 2023 8:07 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH v2] common/mlx5: enable operation in iova virtual address > mode > > The ConnectX NIC series hardware provides

RE: [PATCH v1 0/2] disallow duplicated tag index

2023-05-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Tuesday, May 16, 2023 8:43 AM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Subject: [PATCH v1 0/2] disallow duplicated tag index > > Doesn't allow duplicated tag index mat

RE: [PATCH v2 0/3] Windows performance enhancements

2023-05-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Tal Shnaiderman > Sent: Tuesday, May 16, 2023 2:26 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh ; Pier > Damouny ; Tamer Hleihel > Subject: [PATCH v2 0/3] Windows performance enh

RE: [PATCH 0/2] net/mlx5: add modify field actions number validation

2023-05-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, May 17, 2023 11:25 PM > To: Ori Kam ; Suanming Mou ; > Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: [PATCH 0/2] net/mlx5: add modify field actions number validation > > This patchset adds validation f

Re: [dpdk-dev] [PATCH v2 2/2] net/cnxk: support Tx queue flow pattern item

2023-05-24 Thread Jerin Jacob
On Wed, May 24, 2023 at 10:24 AM wrote: > > From: Satheesh Paul > > Added support for Tx queue flow pattern item. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar K Series applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > doc/guides/nics/features/cnxk.ini | 1 + > do

RE: [PATCH v3 02/10] net/cpfl: support hairpin queue capbility get

2023-05-24 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Friday, May 19, 2023 3:31 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > ; Wang, Xiao W > Subject: [PATCH v3 02/10] net/cpfl: support hairpin queue capbility get > > From: Beilei Xing > > This patch adds hai

RE: [PATCH v3 04/10] net/cpfl: add haipin queue group during vport init

2023-05-24 Thread Wu, Jingjing
> static int > cpfl_dev_vport_init(struct rte_eth_dev *dev, void *init_params) > { > @@ -1306,6 +1414,8 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, void > *init_params) > struct cpfl_adapter_ext *adapter = param->adapter; > /* for sending create vport virtchnl msg prepare */ >

Re: [PATCH] doc: deprecation notice to add new hash function

2023-05-24 Thread Stephen Hemminger
On Wed, 24 May 2023 19:38:27 +0800 Xueming Li wrote: > + > +* ethdev: The enum ``rte_eth_hash_function`` will be extended to add > + new subtype value ``RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT`` in > + DPDK 23.11. Simple new additions like this don't need to clutter the deprecation part

Re: [PATCH] common/mlx5: adjust fork call with the new kernel API

2023-05-24 Thread Stephen Hemminger
On Wed, 24 May 2023 15:01:40 +0300 wrote: > From: Erez Ferber > > While doing process fork() the operating system remaps all the parent > process's memory to the address space of the child process and activates > the Copy-on-Write mechanics - it duplicates physical pages once memory > writing h

[PATCH v2] usertools/telemetry: fix unused parameter

2023-05-24 Thread Samina Arshad
This bug fix ensures that the runtime socket path is generated correctly, based on the user-specified file_prefix value, resolving the issue that occurred in the previous implementation. Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument") Cc: lihuis...@huawei.com Cc: sta...@dpdk.

AF_XDP performance

2023-05-24 Thread Alireza Sanaee
Hi everyone, I was looking at this deck of slides https://www.dpdk.org/wp-content/uploads/sites/35/2020/11/XDP_ZC_PMD-1.pdf I tried to reproduce the results with the testpmd application. I am working with BlueField 2 NIC and I could sustain ~10Mpps with testpmd with AF_XDP, and about 20Mpps

Re: seeking community input on adapting DPDK to P4Runtime backend

2023-05-24 Thread Jerin Jacob
On Mon, May 22, 2023 at 10:42 AM Zhang, Qi Z wrote: > > > > > -Original Message- > > From: Ori Kam > > Sent: Thursday, May 18, 2023 10:34 PM > > To: Zhang, Qi Z ; dev@dpdk.org > > Cc: techbo...@dpdk.org; Richardson, Bruce ; > > Burakov, Anatoly ; Wiles, Keith > > ; Liang, Cunming ; Wu, >

RE: [PATCH v14] app/procinfo: display eventdev xstats

2023-05-24 Thread Pattan, Reshma
> -Original Message- > From: Sevincer, Abdullah The code looks better now, however if you can make below changes that would be great. > + > +struct eventdev_params { > + uint32_t show_eventdev; Can't we get rid of the "show_eventdev", and just rely below flags > + uint8_

  1   2   >