Re: 21.11.4 patches review and test

2023-05-02 Thread Kevin Traynor
On 20/04/2023 11:32, Kevin Traynor wrote: On 20/04/2023 03:40, Xu, HailinX wrote: -Original Message- From: Xu, HailinX Sent: Thursday, April 13, 2023 2:13 PM To: Kevin Traynor ; sta...@dpdk.org Cc: dev@dpdk.org; Abhishek Marathe ; Ali Alnubani ; Walker, Benjamin ; David Christensen ; He

[v2] [RFC] dpaa2: replace system("echo ...") with file i/o

2023-05-02 Thread Sachin Saxena (OSS)
From: Stephen Hemminger Using system() is a bad idea in driver code because it introduces a number of potential security issues. The codeql analysis tool flags this a potential security issue. Instead just use normal stdio to do the same thing. Compile test only, do not have this hardware

Re: [PATCH 1/2] eventdev: add bulk type event ring operations

2023-05-02 Thread Jerin Jacob
On Tue, Apr 4, 2023 at 12:33 PM Jerin Jacob wrote: > > On Mon, Apr 3, 2023 at 6:49 PM Mattias Rönnblom > wrote: > > > > Introduce bulk enqueue and dequeue operations into the > > API, to supplement the already-existing burst > > calls. > > > > Signed-off-by: Mattias Rönnblom > > Looks good to m

Re: [RFC PATCH 1/5] eventdev: add power monitoring API on event port

2023-05-02 Thread Ferruh Yigit
On 4/25/2023 7:19 AM, Mattias Rönnblom wrote: > On 2023-04-24 18:06, Ferruh Yigit wrote: >> On 4/19/2023 11:15 AM, Jerin Jacob wrote: >>> On Wed, Apr 19, 2023 at 3:24 PM Sivaprasad Tummala >>> wrote: A new API to allow power monitoring condition on event port to optimize power when

Re: [RFC PATCH 1/5] eventdev: add power monitoring API on event port

2023-05-02 Thread Ferruh Yigit
On 4/25/2023 5:09 AM, Jerin Jacob wrote: > On Mon, Apr 24, 2023 at 9:36 PM Ferruh Yigit wrote: >> >> On 4/19/2023 11:15 AM, Jerin Jacob wrote: >>> On Wed, Apr 19, 2023 at 3:24 PM Sivaprasad Tummala >>> wrote: A new API to allow power monitoring condition on event port to optimize p

Re: [PATCH v2] dts: replace pexpect with fabric

2023-05-02 Thread Juraj Linkeš
On Fri, Apr 28, 2023 at 9:04 PM Jeremy Spewock wrote: > > > > On Mon, Apr 24, 2023 at 9:35 AM Juraj Linkeš > wrote: >> >> Pexpect is not a dedicated SSH connection library while Fabric is. With >> Fabric, all SSH-related logic is provided and we can just focus on >> what's DTS specific. >> >> Si

DPDK Release Status Meeting 2023-04-27

2023-05-02 Thread Mcnamara, John
Release status meeting minutes 2023-04-27 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed

[dpdk-dev] [PATCH v1] examples/ntb: fix build issue with GCC 13

2023-05-02 Thread jerinj
From: Jerin Jacob Fix the following build issue by not allowing nb_ids to be zero. nb_ids can be zero based on rte_rawdev_xstats_get() API documentation but it is not valid for the case when second argument is NULL. examples/ntb/ntb_fwd.c: In function 'ntb_stats_display': examples/ntb/ntb_fwd.c:

[dpdk-dev] [PATCH v1] examples/ip_pipeline: fix build issue with GCC 13

2023-05-02 Thread jerinj
From: Jerin Jacob Fix the following build issue by initializing req to NULL for the local variable. In function 'thread_msg_handle', inlined from 'thread_main' at ../examples/ip_pipeline/thread.c:3130:6: ../examples/ip_pipeline/thread.c:535:20: warning: 'req' may be used uninitialized [-Wmaybe-u

[dpdk-dev] [PATCH v1] examples/ip_pipeline: fix build issue with GCC 13

2023-05-02 Thread jerinj
From: Jerin Jacob Fix the following build issue by initializing req to NULL for the local variable. In function 'thread_msg_handle', inlined from 'thread_main' at ../examples/ip_pipeline/thread.c:3130:6: ../examples/ip_pipeline/thread.c:535:20: warning: 'req' may be used uninitialized [-Wmaybe-u

[dpdk-dev] [PATCH v1] examples/ntb: fix build issue with GCC 13

2023-05-02 Thread jerinj
From: Jerin Jacob Fix the following build issue by not allowing nb_ids to be zero. nb_ids can be zero based on rte_rawdev_xstats_get() API documentation but it is not valid for the case when second argument is NULL. examples/ntb/ntb_fwd.c: In function 'ntb_stats_display': examples/ntb/ntb_fwd.c:

Re: [dpdk-dev] [PATCH] net/liquidio: removed LiquidIO ethdev driver

2023-05-02 Thread Ferruh Yigit
On 4/28/2023 11:31 AM, jer...@marvell.com wrote: > From: Jerin Jacob > > The LiquidIO product line has been substituted with CN9K/CN10K > OCTEON product line smart NICs located at drivers/net/octeon_ep/. > > DPDK 20.08 has categorized the LiquidIO driver as UNMAINTAINED > because of the absence

Re: [PATCH v3] eventdev/eth_rx: fix invalid memory access

2023-05-02 Thread Jerin Jacob
On Mon, Apr 17, 2023 at 12:00 PM Naga Harish K, S V wrote: > > Acked-by: Naga Harish K S V Applied to dpdk-next-net-eventdev/for-main. Thanks > > > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Friday, April 7, 2023 12:18 PM > > To: jer...@marvell.com; Naga Harish K,

RE: [dpdk-dev] [PATCH v1] examples/ip_pipeline: fix build issue with GCC 13

2023-05-02 Thread Dumitrescu, Cristian
> -Original Message- > From: jer...@marvell.com > Sent: Tuesday, May 2, 2023 2:51 PM > To: dev@dpdk.org; Dumitrescu, Cristian ; > Singh, Jasvinder > Cc: tho...@monjalon.net; david.march...@redhat.com; > ferruh.yi...@xilinx.com; step...@networkplumber.org; Jerin Jacob > ; sta...@dpdk.or

Re: [RFC PATCH 1/3] ethdev: update documentation for API to set FEC

2023-05-02 Thread Ferruh Yigit
On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote: > The documentation for the rte_eth_fec_set() is updated > to provide more detailed information about how FEC modes are > handled. It also includes a description of the case when only > the AUTO bit is set. > > Signed-off-by: Denis Pryazhennikov >

Re: [RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified

2023-05-02 Thread Ferruh Yigit
On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote: > The behaviour is undefined in the rte_eth_fec_set() function > when the fec_capa parameter is equal to zero. > Add a check to handle this case. > > Signed-off-by: Denis Pryazhennikov > Acked-by: Ivan Malov > Acked-by: Viacheslav Galaktionov >

Re: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC

2023-05-02 Thread Ferruh Yigit
On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote: > Only one valid FEC mode can be get by rte_eth_fec_get(). > The previous name implied that more than one FEC mode > can be obtained. +1 and patch looks good. But isn't this valid for 'rte_eth_fec_set()', it gets 'fec_mode'. FEC capability has its

[RFC PATCH v2] ethdev: add indirect list flow action

2023-05-02 Thread Gregory Etelson
Indirect API creates a shared flow action with unique action handle. Flow rules can access the shared flow action and resources related to that action through the indirect action handle. In addition, the API allows to update existing shared flow action configuration. After the update completes, ne

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-05-02 Thread Ferruh Yigit
On 2/21/2023 8:42 PM, lon...@linuxonhyperv.com wrote: > From: Long Li > > Change all the logging statements on the datapath to use RTE_LOG_DP() to > reduce CPU overhead when logging is not enabled for datapath. > > Fixes: 517ed6e2d5 ("net/mana: add basic driver with build environment") > Cc: sta

Re: [RFC PATCH v2] ethdev: add indirect list flow action

2023-05-02 Thread Ivan Malov
Hi Gregory, Overall, the idea of action list indirection sounds good. But why deprecate the existing indirect action API? Are there any strong reasons for that? This action should probably stay. Well, at least, I wouldn't expect this patch to immediately introduce some transition period. Let's cr

Re: [PATCH] doc: fix event timer adapter guide

2023-05-02 Thread Jerin Jacob
On Thu, Apr 13, 2023 at 1:32 AM Carrillo, Erik G wrote: > > > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Friday, April 7, 2023 3:14 AM > > To: jer...@marvell.com; Carrillo, Erik G > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [PATCH] doc: fix event timer adapte

Re: [PATCH 2/2] net/mana: optimize completion queue polling by processing a batch at a time

2023-05-02 Thread Ferruh Yigit
On 3/17/2023 11:32 PM, lon...@linuxonhyperv.com wrote: > - while (pkt_received < pkts_n && > -gdma_poll_completion_queue(&rxq->gdma_cq, &comp) == 1) { > - struct mana_rxq_desc *desc; > - struct mana_rx_comp_oob *oob = > - (struct mana_rx_c

Re: [PATCH 1/2] net/mana: avoid unnecessary assignments in data path

2023-05-02 Thread Ferruh Yigit
On 3/17/2023 11:32 PM, lon...@linuxonhyperv.com wrote: > From: Long Li > > Unnecessary assignments involve memset and waste CPU cycles. > Removing them to reduce CPU usage. > > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") > Cc: sta...@dpdk.org > Signed-off-by: Long L

[PATCH] drivers: fix error CQE handling

2023-05-02 Thread Alexander Kozyrev
The completion queue element size can be independently configured to report either 64 or 128 bytes CQEs by programming cqe_sz parameter at CQ creation. This parameter depends on the cache line size and affects both regular CQEs and error CQEs. But the error handling assumes that an error CQE is 64

[PATCH] drivers: ignore non-critical syndromes for Tx queues

2023-05-02 Thread Alexander Kozyrev
Only 3 syndromes are considered critical and warrant a queue restart. All other syndromes can be safely ignored. We ignore them for Rx queues. Skip non-critical error CQEs for Tx queues as well. Fixes: 957e45fb7b ("net/mlx5: handle Tx completion with error") Cc: sta...@dpdk.org Signed-off-by: Ale

Re: [dpdk-dev] [PATCH v2] ring: fix use after free in ring release

2023-05-02 Thread Konstantin Ananyev
01/05/2023 20:06, Honnappa Nagarahalli пишет: -Original Message- From: Konstantin Ananyev Sent: Monday, May 1, 2023 7:32 AM To: wangyunj...@huawei.com Cc: dev@dpdk.org; Honnappa Nagarahalli ; konstantin.v.anan...@yandex.ru; luyi...@huawei.com; sta...@dpdk.org Subject: Re: [dpdk-dev] [

Reminder - DPDK Techboard Meeting Tomorrow 5/3/23 - 8am PDT/11am EDT/1500h UTC

2023-05-02 Thread Nathan Southern
Good evening, The DPDK Tech Board Meeting will be held tomorrow Wed. May 3, 2023, at 8am PDT/11am EDT/1500h UTC. The agenda will be posted here: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db And as always you may access the meeting by visiting: https://meet.jit.si/dpdk We l

RE: [PATCH v1] raw/ifpga: check afu device before unplug

2023-05-02 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Monday, March 27, 2023 5:42 AM > To: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v1] raw/ifpga: check afu device before

RE: [dpdk-dev] [PATCH v2] ring: fix use after free in ring release

2023-05-02 Thread Honnappa Nagarahalli
> >> > >> > >> > >>> After the memzone is freed, it is not removed from the 'rte_ring_tailq'. > >>> If rte_ring_lookup is called at this time, it will cause a > >>> use-after-free problem. This change prevents that from happening. > >>> > >>> Fixes: 4e32101f9b01 ("ring: support freeing") > >>> Cc

DPDK 22.11 Troubleshooting

2023-05-02 Thread Gilbert Carrillo
Hello, I installed DPDK version 22.11 and the QDMA DPDK driver. However, I am having trouble compiling the test applications. I have a c++ program that has an external buffer and my end goal is to attach/map an mbuf to my external buffer for zero-copy DMA. Currently I use CMAKE to compile my p