On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote: > Only one valid FEC mode can be get by rte_eth_fec_get(). > The previous name implied that more than one FEC mode > can be obtained.
+1 and patch looks good. But isn't this valid for 'rte_eth_fec_set()', it gets 'fec_mode'. FEC capability has its own type "struct rte_eth_fec_capa". Independent from being single FEC mode or not, I think both 'rte_eth_fec_get()' & 'rte_eth_fec_set()' should get 'fec_mode' as param, what do you think? > Documentation was updated accordingly. > > Signed-off-by: Denis Pryazhennikov <[email protected]> > Acked-by: Ivan Malov <[email protected]> > Acked-by: Viacheslav Galaktionov <[email protected]> <...>
