Re: [PATCH v2 1/3] eal: add x86 cpuid support for monitorx

On Thu, Apr 13, 2023 at 7:51 PM Tummala, Sivaprasad wrote: > > [AMD Official Use Only - General] > > Hi David, > > > -Original Message- > > From: David Marchand > > Sent: Thursday, April 13, 2023 5:30 PM > > To: Tummala, Sivaprasad > > Cc: david.h...@intel.com; dev@dpdk.org; Thomas Monja

Re: [PATCH] usertools: add tool to generate balanced rss traffic flows

13/04/2023 22:30, Robin Jarry: > From: 6WIND I don't remember drinking a beer with grumly. Maybe it is not his real name? > usage: dpdk-rss-flows.py [-h] [-s SPORT_RANGE] [-d DPORT_RANGE] [-r] > [-k RSS_KEY] [-t RETA_SIZE] [-j] > RX_QUEUES SRC DS

Re: [PATCH] usertools: add tool to generate balanced rss traffic flows

Thomas Monjalon, Apr 14, 2023 at 09:23: > I don't remember drinking a beer with grumly. > Maybe it is not his real name? Here he is with his co-worker, le poulpe. He was on a call with a customer: https://diabeteman.com/grumly-et-le-poulpe-de-ntf.jpg > How do you parse the JSON format? > Is ther

Re: 20.11.8 patches review and test

Hi Luca, RedHat QE does not find new issues about the v20.11.8-rc1 dpdk during the tests. We tested below 18 scenarios and all got PASS on RHEL9: - Guest with device assignment(PF) throughput testing(1G hugepage size): PASS - Guest with device assignment(PF) throughput testing(2M hugep

[PATCH] bitmap: add scan init at given position

Currently, in the case when we search for a bit set after a particular value, the bitmap has to be scanned from the beginning and rte_bitmap_scan() has to be called multiple times until we hit the value. Add a new __rte_bitmap_scan_init_at() function to initialize scan state at the given position,

[PATCH] reorder: improve buffer structure layout

Rearrange the reorder buffer structure to prevent padding to extra one cache line. Current layout: struct rte_reorder_buffer { char name[RTE_REORDER_NAMESIZE]; uint32_t min_seqn; unsigned int memsize; // -> padding to cache align (cir_buffer is also cache aligned) s

RE: [PATCH v2 1/3] eal: add x86 cpuid support for monitorx

[AMD Official Use Only - General] > -Original Message- > From: David Marchand > Sent: Friday, April 14, 2023 12:36 PM > To: Tummala, Sivaprasad > Cc: david.h...@intel.com; dev@dpdk.org; Thomas Monjalon > ; Burakov, Anatoly > Subject: Re: [PATCH v2 1/3] eal: add x86 cpuid support for m

[PATCH] reorder: introduce API to obtain memory footprint

At present, it is not easy to determine the memory requirement for the reorder buffer without delving into its implementation details. To facilitate the use of reorder buffer with user allocation, a new API `rte_reorder_memory_footprint_get()` is introduced. This API will provide the amount of requ

Minutes of Technical Board Meeting, 2023-April-22

Minutes of Technical Board Meeting, 2023-March-05 Members Attending - -Bruce -Hemant -Honnappa -Jerin -Kevin -Konstantin (Chair) -Stephen NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK communi

RE: [PATCH] net/gve: Check whether the driver is compatible with the device presented.

Hi Ferruh, Here is the summary of the dependency of related patches: P1: necessary headers update https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* P2: minor update for base code https://patchwork.dpdk.org/project/dpdk/list/?series=27653&state=* P3: gve PMD enhancement

Re: Regarding DPDK API's like rte_timer_subsystem_init/rte_hash_create etc. in VPP

On Fri, Apr 14, 2023 at 09:55:31AM +0530, Prashant Upadhyaya wrote: > On Fri, Mar 31, 2023 at 4:19 PM Bruce Richardson > wrote: > > > > On Fri, Mar 31, 2023 at 03:11:18PM +0530, Prashant Upadhyaya wrote: > > > On Thu, Mar 30, 2023 at 7:34 PM Bruce Richardson > > > wrote: > > > > > > > > On Thu, M

Re: [PATCH v5 06/14] eal: use prefetch intrinsics

On Thu, Apr 13, 2023 at 02:25:55PM -0700, Tyler Retzlaff wrote: > Inline assembly is not supported for MSVC x64 instead use _mm_prefetch > and _mm_cldemote intrinsics. > > Signed-off-by: Tyler Retzlaff > --- Acked-by: Bruce Richardson

[PATCH v2] dmadev: add tracepoints

Add tracepoints at important APIs for tracing support. Signed-off-by: Chengwen Feng --- v2: Address Morten's comment: Make stats_get as fast-path trace-points. Place fast-path trace-point functions behind in version.map. --- lib/dmadev/meson.build | 2 +- lib/dmadev/rte

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 13 April 2023 23.26 > > > > For now expand a lot of common rte macros empty. The catch here is we > > need to test that most of the macros do what they

Re: [PATCH] reorder: improve buffer structure layout

On Fri, Apr 14, 2023 at 10:43:43AM +0200, Volodymyr Fialko wrote: > Rearrange the reorder buffer structure to prevent padding to extra one > cache line. > > Current layout: > struct rte_reorder_buffer { > char name[RTE_REORDER_NAMESIZE]; > uint32_t min_seqn; > unsigned int

Re: 20.11.8 patches review and test

On Tue, 11 Apr 2023 at 06:17, Xu, HailinX wrote: > > > -Original Message- > > From: Xu, HailinX > > Sent: Thursday, April 6, 2023 3:19 PM > > To: luca.bocca...@gmail.com; sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Ali Alnubani ; Walker, Benjamin > > ; David Christensen ;

Re: [RFC 00/27] Add VDUSE support to Vhost library

On 4/13/2023 8:59 AM, Maxime Coquelin wrote: > Hi, > > On 4/13/23 09:08, Xia, Chenbo wrote: >>> -Original Message- >>> From: Morten Brørup >>> Sent: Thursday, April 13, 2023 3:41 AM >>> To: Maxime Coquelin ; Ferruh Yigit >>> ; dev@dpdk.org; david.march...@redhat.com; Xia, >>> Chenbo ; m..

Re: [PATCH 1/1] net/gve: update base code for DQO

On 4/14/2023 6:17 AM, Rushil Gupta wrote: > I want to highlight that we wish to keep license changes separate from > this patch (probably for 23.11). This patch is to simply support basic > structures for the DQO data path. > +1 to separate it license patch.

[PATCH v3] net/i40e: support enable/disable source pruning

VRRP advertisement packets are dropped on i40e PF device because when a MAC address is added to a device, packets originating from that MAC address are dropped. This patch adds a PMD specific API to enable/disable source pruning to fix above issue. Bugzilla ID: 648 Fixes: 94b3c1a72507 ("net/i40e:

[PATCH] net/e1000: report VLAN extend capability for 82576

82576 also has exended VLAN support. Signed-off-by: Akihiko Odaki --- drivers/net/e1000/igb_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index f32dee46df..25ad9eb4e5 100644 --- a/drivers/net/e1000/igb_rxt

Re: [PATCH v2 1/3] eal: add x86 cpuid support for monitorx

On 4/14/2023 8:05 AM, David Marchand wrote: > On Thu, Apr 13, 2023 at 7:51 PM Tummala, Sivaprasad > wrote: >> >> [AMD Official Use Only - General] >> >> Hi David, >> >>> -Original Message- >>> From: David Marchand >>> Sent: Thursday, April 13, 2023 5:30 PM >>> To: Tummala, Sivaprasad >>>

Re: [RFC 00/27] Add VDUSE support to Vhost library

On 4/14/23 12:48, Ferruh Yigit wrote: On 4/13/2023 8:59 AM, Maxime Coquelin wrote: Hi, On 4/13/23 09:08, Xia, Chenbo wrote: -Original Message- From: Morten Brørup Sent: Thursday, April 13, 2023 3:41 AM To: Maxime Coquelin ; Ferruh Yigit ; dev@dpdk.org; david.march...@redhat.com; Xi

[PATCH] crypto/qat: fix stack buffer overflow in SGL loop

The cvec pointer was incremented incorrectly in the case where the length of remaining_off equals cvec len, and there is no next cvec. This led to cvec->iova being invalid memory to access. Instead, only increment the cvec pointer when we know there is a next cvec to point to, by checking the i va

[PATCH] crypto/scheduler: fix last element for valid args

The list of valid arguments for Scheduler PMD should be terminated with a NULL entry, as expected by rte_kvargs_parse. Without this, if an invalid key name was used, a global buffer overflow occurred resulting in a segmentation fault. Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev drive

[PATCH v2] net/e1000: report VLAN extend capability for 82576

82576 also has extended VLAN support. Signed-off-by: Akihiko Odaki --- drivers/net/e1000/igb_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index f32dee46df..25ad9eb4e5 100644 --- a/drivers/net/e1000/igb_rx

RE: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 14 April 2023 11.22 > > On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Thursday, 13 April 2023 23.26 > > > > > > For now expand

[PATCH 0/2] Enable generic Arm build

I use Apple Silicon computer as development environment. This allows to run DPDK Test Suite on such Arm devices just as you can run DTS on x86 development machine. Akihiko Odaki (2): config/arm: Do not require processor information config/arm: Enable NUMA for generic Arm build config/arm/mes

[PATCH 2/2] config/arm: Enable NUMA for generic Arm build

We enable NUMA even if the presence of NUMA is unknown for the other architectures. Enable NUMA for generic Arm build too. Signed-off-by: Akihiko Odaki --- config/arm/meson.build | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.b

[PATCH 1/2] config/arm: Do not require processor information

DPDK can be built even without exact processor information for x86 and ppc so allow to build for Arm even if we don't know the targeted processor is unknown. Signed-off-by: Akihiko Odaki --- config/arm/meson.build | 36 +++- 1 file changed, 19 insertions(+), 17 de

RE: [PATCH v2] dmadev: add tracepoints

> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > Sent: Friday, 14 April 2023 11.09 > > Add tracepoints at important APIs for tracing support. > > Signed-off-by: Chengwen Feng > > --- > v2: Address Morten's comment: > Make stats_get as fast-path trace-points. > Place fast-path tr

RE: [PATCH] crypto/scheduler: fix last element for valid args

Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Friday, April 14, 2023 1:33 PM > To: Ji, Kai > Cc: dev@dpdk.org; Power, Ciara ; > fanzhang@gmail.com; sta...@dpdk.org > Subject: [PATCH] crypto/scheduler: fix last element for valid args > > The list of valid argume

RE: [PATCH] crypto/qat: fix stack buffer overflow in SGL loop

Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Friday, April 14, 2023 1:32 PM > To: Ji, Kai > Cc: dev@dpdk.org; Power, Ciara ; sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix stack buffer overflow in SGL loop > > The cvec pointer was incremented incorrectly in th

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

On Fri, Apr 14, 2023 at 02:39:03PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 14 April 2023 11.22 > > > > On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.c

RE: [PATCH] crypto/qat: fix stack buffer overflow in SGL loop

Hi Ciara, > -Original Message- > From: Ciara Power > Sent: Friday 14 April 2023 13:32 > To: Ji, Kai > Cc: dev@dpdk.org; Power, Ciara ; sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix stack buffer overflow in SGL loop > > The cvec pointer was incremented incorrectly in the case where

[PATCH] test/crypto: fix return value for snow3g testcase

Unit tests were failing due to the return value of the decryption and authentication functions not being handled correctly. This has now been modified to return the expected test status. Fixes: e23eccfd281e ("test/crypto: fix bitwise operator in a SNOW3G case") Cc: kai...@intel.com Cc: sta...@dpdk

RE: [PATCH] test/crypto: fix return value for snow3g testcase

Hi Saoirse, > -Original Message- > From: Saoirse O'Donovan > Sent: Friday 14 April 2023 14:55 > To: Akhil Goyal ; Fan Zhang > > Cc: dev@dpdk.org; O'Donovan, Saoirse ; Ji, > Kai ; sta...@dpdk.org > Subject: [PATCH] test/crypto: fix return value for snow3g testcase > > Unit tests were fai

Re: [RFC 00/27] Add VDUSE support to Vhost library

On 4/14/2023 1:06 PM, Maxime Coquelin wrote: > > > On 4/14/23 12:48, Ferruh Yigit wrote: >> On 4/13/2023 8:59 AM, Maxime Coquelin wrote: >>> Hi, >>> >>> On 4/13/23 09:08, Xia, Chenbo wrote: > -Original Message- > From: Morten Brørup > Sent: Thursday, April 13, 2023 3:41 AM >>

Re: [PATCH] reorder: improve buffer structure layout

On Fri, 14 Apr 2023 10:43:43 +0200 Volodymyr Fialko wrote: > diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c > index f55f383700..7418202b04 100644 > --- a/lib/reorder/rte_reorder.c > +++ b/lib/reorder/rte_reorder.c > @@ -46,9 +46,10 @@ struct rte_reorder_buffer { > char n

Re: [PATCH] reorder: improve buffer structure layout

On Fri, Apr 14, 2023 at 07:52:30AM -0700, Stephen Hemminger wrote: > On Fri, 14 Apr 2023 10:43:43 +0200 > Volodymyr Fialko wrote: > > > diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c > > index f55f383700..7418202b04 100644 > > --- a/lib/reorder/rte_reorder.c > > +++ b/lib/reor

[PATCH v2] kni: fix build with Linux 6.3

KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` flag, but `FOLL_TOUCH` is no more in public headers since v6.3, causing a build error. `FOLL_*` defines in Linux kernel first moved to another header [1], later some of them moved to memory subsystem internal header [2] for 6.3 `

Re: [PATCH] kni: fix build with Linux 6.3

On 3/20/2023 1:01 PM, David Marchand wrote: > On Mon, Mar 20, 2023 at 1:10 PM David Marchand > wrote: >> >> On Tue, Feb 28, 2023 at 9:45 PM David Marchand >> wrote: >>> >>> On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote: KNI calls `get_user_pages_remote()` API which is using `FOLL_

Re: [PATCH] reorder: improve buffer structure layout

On Fri, 14 Apr 2023 15:54:13 +0100 Bruce Richardson wrote: > On Fri, Apr 14, 2023 at 07:52:30AM -0700, Stephen Hemminger wrote: > > On Fri, 14 Apr 2023 10:43:43 +0200 > > Volodymyr Fialko wrote: > > > > > diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c > > > index f55f38370

Re: [PATCH] net/gve: Check whether the driver is compatible with the device presented.

On 4/14/2023 10:05 AM, Guo, Junfeng wrote: > Hi Ferruh, > > Here is the summary of the dependency of related patches: > > P1: necessary headers update > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > P2: minor update for base code > https://patchwork.dpdk.org/project

Re: [PATCH v2 1/6] bus/cdx: introduce cdx bus

On 4/13/2023 2:26 PM, Nipun Gupta wrote: > CDX bus supports multiple type of devices, which can be > exposed to user-space via vfio-cdx. > > vfio-cdx provides the MMIO IO_MEMORY regions as well as the > DMA interface for the device (IOMMU). > > This support aims to enable the DPDK to support the

Re: [PATCH v2 3/6] bus/cdx: add support for MSI

On 4/13/2023 2:27 PM, Nipun Gupta wrote: > MSI's are exposed to the devices using VFIO (vfio-cdx). This > patch uses the same to add support for MSI for the devices on > the cdx bus. > > Signed-off-by: Nipun Gupta This commit also adds two new internal eal APIs and extends "struct rte_intr_handl

Re: [PATCH v2 5/6] bus: enable cdx bus

On 4/13/2023 2:27 PM, Nipun Gupta wrote: > enable the compilation of cdx bus > > Signed-off-by: Nipun Gupta > --- > drivers/bus/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build > index 6d2520c543..a78b4283bf 100644 > --- a/dr

Re: [PATCH v2 0/6] add support for CDX bus

On 4/13/2023 2:26 PM, Nipun Gupta wrote: > Support AMD CDX bus, for FPGA based CDX devices. The CDX > devices are memory mapped on system bus for embedded CPUs. > > It uses sysfs interface and the vfio-cdx driver to discover > and initialize the CDX devices. > > The patches are intended for DPDK

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 13 April 2023 23.26 > > > > For now expand a lot of common rte macros empty. The catch here is we > > need to test that most of the macros do what they

Re: [PATCH] reorder: improve buffer structure layout

On Fri, Apr 14, 2023 at 10:26:26AM +0100, Bruce Richardson wrote: > On Fri, Apr 14, 2023 at 10:43:43AM +0200, Volodymyr Fialko wrote: > > Rearrange the reorder buffer structure to prevent padding to extra one > > cache line. > > > > Current layout: > > struct rte_reorder_buffer { > > char

[PATCH v2 01/22] net: add PDCP header

From: Volodymyr Fialko Add PDCP protocol header to be used for supporting PDCP protocol processing. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- doc/api/doxy-api-index.md | 3 +- lib/net/meson.build | 1 + lib/net/rte_pdcp_hdr.h|

[PATCH v2 00/22] lib: add pdcp protocol

Add Packet Data Convergence Protocol (PDCP) processing library. The library is similar to lib_ipsec which provides IPsec processing capabilities in DPDK. PDCP would involve roughly the following operations, 1. Transfer of user plane data 2. Transfer of control plane data 3. Header compression 4.

[PATCH v2 02/22] lib: add pdcp protocol

Add Packet Data Convergence Protocol (PDCP) processing library. The library is similar to lib_ipsec which provides IPsec processing capabilities in DPDK. PDCP would involve roughly the following options, 1. Transfer of user plane data 2. Transfer of control plane data 3. Header compression 4. Upl

[PATCH v2 03/22] pdcp: add pre and post-process

PDCP process is split into 2 parts. One before crypto processing (rte_pdcp_pkt_pre_process()) and one after crypto processing (rte_pdcp_pkt_post_process()). Functionality of pre-process & post-process varies based on the type of entity. Registration of entity specific function pointer allows skippi

[PATCH v2 04/22] pdcp: add packet group

Crypto processing in PDCP is performed asynchronously by rte_cryptodev_enqueue_burst() and rte_cryptodev_dequeue_burst(). Since cryptodev dequeue can return crypto operations belonging to multiple entities, rte_pdcp_pkt_crypto_group() is added to help grouping crypto operations belonging to same en

[PATCH v2 05/22] pdcp: add crypto session create and destroy

Add routines to create & destroy sessions. PDCP lib would take crypto transforms as input and creates the session on the corresponding device after verifying capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_crypto.c | 222 ++

[PATCH v2 06/22] pdcp: add pre and post process for UL

Add routines to perform pre & post processing based on the type of entity. To avoid checks in datapath, there are different function pointers registered based on the following, 1. Control plane v/s user plane 2. 12 bit v/s 18 bit SN For control plane only 12 bit SN need to be supported (as per PDC

[PATCH v2 07/22] pdcp: add pre and post process for DL

Add routines to perform pre & post processing for down link entities. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 2 + lib/pdcp/pdcp_process.c | 453 2 files changed, 455 inser

[PATCH v2 08/22] pdcp: add IV generation routines

For PDCP, IV generated has varying formats depending on the ciphering and authentication algorithm used. Add routines to populate IV accordingly. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 87 lib/pdcp/pdcp_process.c | 284 +++

[PATCH v2 09/22] app/test: add lib pdcp tests

Add tests to verify lib PDCP operations. Tests leverage existing PDCP test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/meson.build | 1 + app/test/test_cryptodev.h | 3 + app/test/test_pdcp.c | 729 ++ 3 fil

[PATCH v2 10/22] test/pdcp: pdcp HFN tests in combined mode

From: Volodymyr Fialko Add tests to verify HFN/SN behaviour. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 302 ++- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/app/test/test_pdcp.c b/app/test/

[PATCH v2 11/22] doc: add PDCP library guide

Add guide for PDCP library. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/pdcp_lib.rst| 246 +++

[PATCH v2 12/22] pdcp: add control PDU handling

Add control PDU handling and implement status report generation. Status report generation works only when RX_DELIV = RX_NEXT. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 1 + doc/guides/prog_guide/pdcp_lib.rst | 10 +++ lib/pdcp/meso

[PATCH v2 13/22] pdcp: implement t-Reordering and packet buffering

From: Volodymyr Fialko Add in-order delivery of packets in PDCP. Delivery of packets in-order relies on t-Reordering timer. When 'out-of-order delivery' is disabled, PDCP will buffer all received packets that are out of order. The t-Reordering timer determines the time period these packets would

[PATCH v2 14/22] test/pdcp: add in-order delivery cases

From: Volodymyr Fialko Add test cases to verify behaviour when in-order delivery is enabled and packets arrive in out-of-order. PDCP library is expected to buffer the packets and return packets in-order when the missing packet arrives. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko

[PATCH v2 15/22] pdcp: add timer callback handlers

From: Volodymyr Fialko PDCP has a windowing mechanism which allows only packets that fall in a reception window. The pivot point for this window is RX_REORD which happens to be the first missing or next expected packet. If the missing packet is not received after a specified time, then the RX_REO

[PATCH v2 16/22] pdcp: add timer expiry handle

From: Volodymyr Fialko The PDCP protocol requires usage of timers to keep track of how long an out-of-order packet should be buffered while waiting for missing packets. Applications can register a desired timer implementation with the PDCP library. Once the timer expires, the application will be

[PATCH v2 17/22] test/pdcp: add timer expiry cases

From: Volodymyr Fialko Add test cases for handling the expiry with rte_timer and rte_event_timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 325 +++ 1 file changed, 325 insertions(+) diff --git a/app/test/te

[PATCH v2 18/22] test/pdcp: add timer restart case

From: Volodymyr Fialko Add test to cover the case when t-reordering timer should be restarted on the same packet. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 67 1 file changed, 67 insertions(+) diff --gi

[PATCH v2 19/22] pdcp: add support for status report

From: Volodymyr Fialko Implement status report generation for PDCP entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 158 --- lib/pdcp/pdcp_cnt.h | 11 ++- lib/pdcp/pdcp_ctrl_pdu.c | 34 - lib/

[PATCH v2 20/22] pdcp: allocate reorder buffer alongside with entity

From: Volodymyr Fialko Instead of allocating reorder buffer separately on heap, allocate memory for it together with rest of entity, and then only initialize buffer via `rte_reorder_init()`. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 9 +++

[PATCH v2 21/22] pdcp: add thread safe processing

From: Volodymyr Fialko PDCP state has to be guarded for: - Uplink pre_process: - tx_next atomic increment - Downlink pre_process: - rx_deliv - read - Downlink post_process: - rx_deliv, rx_reorder, rx_next - read/write - bitmask/reorder buffer - read/write When application requ

[PATCH v2 22/22] test/pdcp: add PDCP status report cases

From: Volodymyr Fialko Test PDCP status report generation. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 310 +++ 1 file changed, 310 insertions(+) diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c index

[PATCH v3] dmadev: add tracepoints

Add tracepoints at important APIs for tracing support. Signed-off-by: Chengwen Feng Acked-by: Morten Brørup --- v3: Address Morten's comment: Move stats_get and vchan_status and to trace_fp.h. v2: Address Morten's comment: Make stats_get as fast-path trace-points. Place fast-path tr

Re: [PATCH v2] dmadev: add tracepoints

Hi Morten, Both fix in v3, thanks. On 2023/4/14 20:46, Morten Brørup wrote: >> From: Chengwen Feng [mailto:fengcheng...@huawei.com] >> Sent: Friday, 14 April 2023 11.09 >> >> Add tracepoints at important APIs for tracing support. >> >> Signed-off-by: Chengwen Feng >> >> --- >> v2: Address Mor

[PATCH v6 03/15] eal: use barrier intrinsics

Inline assembly is not supported for MSVC x64 instead expand rte_compiler_barrier as _ReadWriteBarrier and for rte_smp_mb _m_mfence intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson Acked-by: Konstantin Ananyev --- lib/eal/include/generic/rte_atomic.h | 4 lib/eal/x86/i

[PATCH v6 01/15] eal: use rdtsc intrinsic

Inline assembly is not supported for MSVC x64. Convert code to use __rdtsc intrinsic. Signed-off-by: Tyler Retzlaff Acked-by: Konstantin Ananyev --- lib/eal/x86/include/rte_cycles.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/eal/x86/include/rte_cycles

[PATCH v6 00/15] msvc integration changes

In accordance with draft plan http://mails.dpdk.org/archives/web/2023-February/002023.html introduces conditionally compiled code to enable building with MSVC that _does not_ require C99/C11 meaning it can be integrated now. This series covers minimal changes for item #2 in draft plan for EAL depe

[PATCH v6 02/15] eal: use rtm and xtest intrinsics

Inline assembly is not supported for MSVC x64. Convert code to use _xend, _xabort and _xtest intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson Acked-by: Konstantin Ananyev --- config/x86/meson.build| 6 ++ lib/eal/x86/include/rte_rtm.h | 18 +- 2

[PATCH v6 04/15] eal: use cpuid and cpuidex intrinsics

Inline assembly is not supported for MSVC x64 instead use __cpuid and __cpuidex intrinsics. Signed-off-by: Tyler Retzlaff --- lib/eal/x86/rte_cpuflags.c | 4 lib/eal/x86/rte_cpuid.h | 7 +++ lib/eal/x86/rte_cycles.c | 36 lib/eal/x86/rte

[PATCH v6 05/15] eal: use umonitor umwait and tpause intrinsics

Inline assembly is not supported for MSVC x64 instead use _umonitor, _umwait and _tpause intrinsics. Signed-off-by: Tyler Retzlaff --- lib/eal/x86/rte_power_intrinsics.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/eal/x86/rte_power_intrinsics.c b/lib/eal/x86/rte_power_

[PATCH v6 06/15] eal: use prefetch intrinsics

Inline assembly is not supported for MSVC x64 instead use _mm_prefetch and _mm_cldemote intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- lib/eal/x86/include/rte_prefetch.h | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/lib/

[PATCH v6 07/15] eal: use byte swap intrinsics

Inline assembly is not supported for MSVC x64 instead expand use _byteswap_u{ushort,ulong,uint64} intrinsics instead. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_byteorder.h | 11 +++ lib/eal/x86/include/rte_byteorder.h | 4 2 files changed, 15 insertions(+)

[PATCH v6 09/15] eal: hide GCC extension based alignment markers

When compiling with MSVC don't expose typedefs used as alignment markers. Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_common.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index 15765b4..2f464e3 100644 --- a/lib/eal

[PATCH v6 08/15] eal: typedef cpu flag enum as int

Forward declaration of a enum is a non-standard extension and is not supported by MSVC. Use an int instead. Abstract the use of the int/enum rte_cpu_flag_t in function parameter lists by re-typdefing the enum rte_cpu_flag_t to the rte_cpu_flag_t identifier. Remove the use of __extension__ on func

[PATCH v6 12/15] eal: exclude exposure of rte atomic APIs for MSVC builds

It's discouraged to use rte_atomics APIs instead standard APIs should be used from C11. Since MSVC is a new toolchain/platform combination block visibility of the rte_atomic APIs from day 1. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_atomic.h | 7 +++ lib/eal/x86/include/r

[PATCH v6 13/15] telemetry: avoid expanding versioned symbol macros on MSVC

Windows does not support versioned symbols. Fortunately Windows also doesn't have an exported stable ABI. Export rte_tel_data_add_array_int -> rte_tel_data_add_array_int_24 and rte_tel_data_add_dict_int -> rte_tel_data_add_dict_int_v24 functions. Windows does have a way to achieve similar version

[PATCH v6 10/15] eal: hide typedefs based on GCC vector extensions

When compiling with MSVC don't expose typedefs based on GCC vector extensions. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_vect.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/include/generic/rte_vect.h b/lib/eal/include/generic/rte_vect.h index 3fec2bf..7775

[PATCH v6 15/15] eal: do not define typeof macro when building with MSVC

When building with MSVC do not assume typeof is a macro and don't define a typeof macro that conflicts with C23 typeof keyword. Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_

[PATCH v6 14/15] eal: always define MSVC as little endian

The MSVC compiler does not target big endian platforms so define little endian always. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_byteorder.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/include/generic/rte_byteorder.h b/lib/eal/include/generic/rte_byteorder.

[PATCH v6 11/15] eal: expand most macros to empty when using MSVC

For now expand a lot of common rte macros empty. The catch here is we need to test that most of the macros do what they should but at the same time they are blocking work needed to bootstrap of the unit tests. Later we will return and provide (where possible) expansions that work correctly for msv

Re: [PATCH v2 00/44] fix segment fault when parse args

Hi Thomas, Ferruh, This patch-set get almost 30% ack by PMD's maintainer. Could it be applied? and squeeze the patch-set is okay. Another thread talk about a change in kvargs API, we could discuss here. My opinion: 1) the below PMD has the bug, but there are also many PMD take care of

RE: [PATCH v6 00/15] msvc integration changes

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Saturday, 15 April 2023 03.16 > > In accordance with draft plan > http://mails.dpdk.org/archives/web/2023-February/002023.html > introduces conditionally compiled code to enable building with MSVC that > _does not_ require C99/C1