RE: [RFC 00/27] Add VDUSE support to Vhost library

2023-04-13 Thread Xia, Chenbo
> -Original Message- > From: Morten Brørup > Sent: Thursday, April 13, 2023 3:41 AM > To: Maxime Coquelin ; Ferruh Yigit > ; dev@dpdk.org; david.march...@redhat.com; Xia, > Chenbo ; m...@redhat.com; f...@redhat.com; > jasow...@redhat.com; Liang, Cunming ; Xie, Yongji > ; echau...@redhat.co

Re: [EXT] Re: [PATCH] kni: fix build with Linux 6.3

2023-04-13 Thread David Marchand
On Fri, Mar 24, 2023 at 4:04 AM Vamsi Krishna Attunuru wrote: > > > So I think the dpdk commit e73831dc6c26 ("kni: support userspace VA") > > > uselessly introduced call to this flag and we can remove it. > > > Adding author and reviewers of this change. > > > > Alternatively, we could go with pas

Re: [PATCH v1 1/2] dts: fabric requirements

2023-04-13 Thread Juraj Linkeš
On Thu, Apr 13, 2023 at 8:50 AM Juraj Linkeš wrote: > > On Wed, Apr 12, 2023 at 5:38 PM Honnappa Nagarahalli > wrote: > > > > > > > > > -Original Message- > > > From: Thomas Monjalon > > > Sent: Wednesday, April 12, 2023 10:25 AM > > > To: Juraj Linkeš > > > Cc: Wathsala Wathawana Vitha

RE: [RFC 00/27] Add VDUSE support to Vhost library

2023-04-13 Thread Morten Brørup
> From: Xia, Chenbo [mailto:chenbo@intel.com] > Sent: Thursday, 13 April 2023 09.08 > > > From: Morten Brørup > > Sent: Thursday, April 13, 2023 3:41 AM > > > > > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > > > Sent: Wednesday, 12 April 2023 17.28 > > > > > > Hi Ferruh, > > >

Re: [RFC 00/27] Add VDUSE support to Vhost library

2023-04-13 Thread Maxime Coquelin
Hi, On 4/13/23 09:08, Xia, Chenbo wrote: -Original Message- From: Morten Brørup Sent: Thursday, April 13, 2023 3:41 AM To: Maxime Coquelin ; Ferruh Yigit ; dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo ; m...@redhat.com; f...@redhat.com; jasow...@redhat.com; Liang, Cunming ; Xie,

RE: [PATCH] dmadev: add tracepoints

2023-04-13 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Thursday, 13 April 2023 08.30 > > On 2023/4/12 19:00, Morten Brørup wrote: > >> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > >> Sent: Wednesday, 12 April 2023 04.48 > >> > >> Add tracepoints at important APIs for tracing suppo

Re: [PATCH] dmadev: add tracepoints

2023-04-13 Thread Bruce Richardson
On Thu, Apr 13, 2023 at 11:44:38AM +0800, fengchengwen wrote: > On 2023/4/12 17:52, Bruce Richardson wrote: > > On Wed, Apr 12, 2023 at 02:48:08AM +, Chengwen Feng wrote: > >> Add tracepoints at important APIs for tracing support. > >> > >> Signed-off-by: Chengwen Feng > >> --- > >> lib/dmade

[Bug 1189] rte_acl_classify returning mismatch result

2023-04-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1189 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Resolution|--- |WONTFIX

Re: [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03

2023-04-13 Thread Ferruh Yigit
On 2/18/2022 9:30 AM, Yanling Song wrote: > On Sun, 13 Feb 2022 19:07:09 +0100 > Thomas Monjalon wrote: > >> 12/02/2022 15:01, Yanling Song: >>> On Fri, 21 Jan 2022 10:22:10 + >>> Ferruh Yigit wrote: >>> On 1/21/2022 9:27 AM, Yanling Song wrote: > On Wed, 19 Jan 2022 16:56:52 +

[PATCH] net/ice: DCF adds default RSS

2023-04-13 Thread Mingjin Ye
When dcf and iavf ports are used together, the default configuration of ipv4[6] rss for dcf ports is lost. This patch adds RSS configuration to the dcf port. Any kernel PF-enabled default RSS will be disabled at initialization. In addition, the default RSS will be configured based on rte_eth_rss_

RE: [PATCH] eal: choose IOVA mode according to compilation flags

2023-04-13 Thread Slava Ovsiienko
> -Original Message- > From: Morten Brørup > Sent: среда, 12 апреля 2023 г. 22:12 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > david.march...@redhat.com > Subject: RE: [PATCH] eal: choose IOVA mode according to compilation flags > > > From: Viaches

[PATCH 00/18] update idpf shared code

2023-04-13 Thread Wenjing Qiao
This patch set updates idpf shared code. Wenjing Qiao (18): common/idpf: support flow subscription common/idpf: fix ctlq message send and receive common/idpf: fix ITR register definitions for AVF common/idpf: remove qregion struct variables common/idpf: move OEM capability to the last bi

[PATCH 01/18] common/idpf: support flow subscription

2023-04-13 Thread Wenjing Qiao
VF is able to subscribe a flow from PF by VIRTCHNL_FLOW_SUBSCRIBE. PF is expected to offload a rule to hardware which will redirect the packet that matching the required pattern to this VF. Only a flow with dst mac address as PF's mac address can be subscribed. VIRTCHNL_VF_OFFLOAD_FSUB_PF is use

[PATCH 02/18] common/idpf: fix ctlq message send and receive

2023-04-13 Thread Wenjing Qiao
Fixes the ctlq send and receive functions to not cast the cookie field to a u64 before programming. By doing a cast, it can cause endianness issues as LE will swap the lower 32 and higher 32 bits whereas BE will not. By treating this field as two 32 bit values, both BE and LE will place the retval

[PATCH 03/18] common/idpf: fix ITR register definitions for AVF

2023-04-13 Thread Wenjing Qiao
Fix ITR register definitions for AVF1.0 and AVF2.0 Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: sta...@dpdk.org Signed-off-by: Priyalee Kushwaha Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_lan_pf_regs.h | 9 +++-- drivers/common/idpf/base/idpf_lan_vf

[PATCH 04/18] common/idpf: remove qregion struct variables

2023-04-13 Thread Wenjing Qiao
Existing qregion variables are not well defined and cannot be used for TC related stuff. Remove them from create vport struct and add those freed bytes to a new reserved field. Add appropriate comments on how to use the dynctl and itrn register spacing variables. Only VF reference was used in get

[PATCH 05/18] common/idpf: move OEM capability to the last bit

2023-04-13 Thread Wenjing Qiao
Move the existing OEM capability in VIRTCHNL2_OTHER_CAPS to the last bit. This should not break any backward compatibility as it is not used yet. And VIRTCHNL2_MEV_DEVICE is no longer upstreamed. Signed-off-by: Pavan Kumar Linga Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/virtchnl

[PATCH 06/18] common/idpf: modify SSO/LSO and ITR fields

2023-04-13 Thread Wenjing Qiao
- Driver assumes minimum packet length for sso as 17 bytes but it should be a negotiated value from CP. - Similarly, the number of header buffers for lso that are supported by the device should also be a negotiated value. Add min_sso_packet_len, max_hdr_buf_per_lso to address the above. Also, the

[PATCH 07/18] common/idpf: add virtchnl2 error codes

2023-04-13 Thread Wenjing Qiao
Virtchnl2 error codes are required for meaningful failure information sharing between CP and PF/VF. Introduce the necessary error codes. New error codes were introduced removing the old ones. So the references to the old one should be modified to avoid CI build failures. Use appropriate error cod

[PATCH 08/18] common/idpf: swap opcode and retval location in msg struct

2023-04-13 Thread Wenjing Qiao
To make the code more readable and make it clearer that the opcode goes in cookie_high and retval goes in cookie_low. Add macro definitions for filling opcode and retval. Signed-off-by: Charles Stoll Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_controlq.c | 2 ++ drivers/c

[PATCH 09/18] common/idpf: fix idpf_send_msg_to_cp prototypes

2023-04-13 Thread Wenjing Qiao
Virtchnl2 opcodes are no longer in the enum virtchnl_ops. So change these parameters to allow int rather that compiler enum type checking. Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: sta...@dpdk.org Signed-off-by: Christopher Pau Signed-off-by: Wenjing Qiao --- drivers/co

[PATCH 10/18] common/idpf: fix memory leaks on ctrlq functions

2023-04-13 Thread Wenjing Qiao
idpf_init_hw needs to free it's q_info. idpf_clean_arq_element needs to return buffers via post_rx_buffs Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: sta...@dpdk.org Signed-off-by: Christopher Pau Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_common.c | 12

[PATCH 11/18] common/idpf: allocate static buffer at initialization

2023-04-13 Thread Wenjing Qiao
Some OSs don't allow allocating DMA memory at runtime. So create an initial static buffer at initialization to hold this data. Signed-off-by: Christopher Pau Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_common.c | 26 +++--- 1 file changed, 15 insertions(+),

[PATCH 12/18] common/idpf: add SyncE support over VF

2023-04-13 Thread Wenjing Qiao
This patch enables to VF access to all SyncE related operations. Most of the opcodes in this implementation map directly to the AQ commands. Additionally there is a VIRTCHNL_OP_SYNCE_GET_HW_INFO opcode which should be used by VF to discover all hardware related details required for Synce operation

[PATCH 13/18] common/idpf: replace MAKEMASK to IDPF_M

2023-04-13 Thread Wenjing Qiao
Replace MAKEMASK to IDPF_M to avoid conflicts with MAKEMASK redefinition from various subcomponents. Signed-off-by: Priyalee Kushwaha Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_controlq.h | 3 -- drivers/common/idpf/base/idpf_lan_pf_regs.h | 26 +-- drivers/co

[PATCH 14/18] common/idpf: add GNSS support over VF

2023-04-13 Thread Wenjing Qiao
This patch enables VF access to GNSS Console I2C. Most of the opcodes in this implementation map directly to the AQ commands for GNSS Console I2C Read and Write for GNSS status, configuration, and NMEA messages. Additionally there is VF and PF negotiation on GNSS Access Capability through Extende

[PATCH 15/18] common/idpf: add/delete queue groups commands

2023-04-13 Thread Wenjing Qiao
Add types for new two virtchnl commands: add & delete queue group Signed-off-by: Nizan Zorea Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/virtchnl2.h | 189 +++ 1 file changed, 189 insertions(+) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/co

[PATCH 16/18] common/idpf: add func to clean all DESCs on controlq

2023-04-13 Thread Wenjing Qiao
Add 'idpf_ctlq_clean_sq_force' which will clean all descriptors on given control queue. It is needed in case control plane is not running and we need to do proper driver cleanup. Signed-off-by: NorbertX Ciosek Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_controlq.c | 56 +++

[PATCH 17/18] common/idpf: fix cannot understand warnings

2023-04-13 Thread Wenjing Qiao
Fix cannot understand function prototype warning, it is due to missing "struct" keyword and not described parameter or member in comments. Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: sta...@dpdk.org Signed-off-by: Simei Su Signed-off-by: Wenjing Qiao --- drivers/common/id

[PATCH 18/18] common/idpf: update license and README

2023-04-13 Thread Wenjing Qiao
Update license and README Signed-off-by: Wenjing Qiao --- .mailmap | 8 drivers/common/idpf/base/README | 4 ++-- drivers/common/idpf/base/idpf_alloc.h| 2 +- drivers/common/idpf/base/idpf_common.c | 2 +- dr

[PATCH] net/virtio-user: fix leak when initialisation fails

2023-04-13 Thread David Marchand
Caught with ASan. If initialising a virtio_user port fails, we may leak the ifname passed via a devargs. Fixes: 4214a1b493f2 ("net/virtio-user: support changing tap interface name") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 ++

[PATCH v2 1/3] eal: add x86 cpuid support for monitorx

2023-04-13 Thread Sivaprasad Tummala
Add a new CPUID flag to indicate support for monitorx instruction on AMD Epyc processors. Signed-off-by: Sivaprasad Tummala --- lib/eal/include/generic/rte_cpuflags.h | 2 ++ lib/eal/x86/include/rte_cpuflags.h | 1 + lib/eal/x86/rte_cpuflags.c | 3 +++ 3 files changed, 6 insertio

[PATCH v2 3/3] power: amd power monitor support

2023-04-13 Thread Sivaprasad Tummala
mwaitx allows epyc processors to enter a implementation dependent power/performance optimized state (C1 state) for a specific period or until a store to the monitored address range. Signed-off-by: Sivaprasad Tummala --- lib/eal/x86/rte_power_intrinsics.c | 83 -- lib/

[PATCH v2 2/3] doc: announce new cpu flag added to rte_cpu_flag_t

2023-04-13 Thread Sivaprasad Tummala
A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in DPDK 23.07 release to support monitorx instruction on Epyc processors. This results in ABI breakage for legacy apps. Signed-off-by: Sivaprasad Tummala --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+)

Re: [PATCH v2 1/3] eal: add x86 cpuid support for monitorx

2023-04-13 Thread David Marchand
On Thu, Apr 13, 2023 at 1:54 PM Sivaprasad Tummala wrote: > > Add a new CPUID flag to indicate support for monitorx instruction > on AMD Epyc processors. > > Signed-off-by: Sivaprasad Tummala > --- > lib/eal/include/generic/rte_cpuflags.h | 2 ++ > lib/eal/x86/include/rte_cpuflags.h | 1 + >

RE: [PATCH 0/6] add support for CDX bus

2023-04-13 Thread Gupta, Nipun
> -Original Message- > From: Gupta, Nipun > Sent: Friday, April 7, 2023 1:00 PM > To: David Marchand > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Anand, Harpreet ; > Agarwal, Nikhil > Subject: Re: [PATCH 0/6] add support for CDX bus > > > > On 4/7/2023 12:48 PM, David M

[PATCH v2 3/6] bus/cdx: add support for MSI

2023-04-13 Thread Nipun Gupta
MSI's are exposed to the devices using VFIO (vfio-cdx). This patch uses the same to add support for MSI for the devices on the cdx bus. Signed-off-by: Nipun Gupta --- drivers/bus/cdx/bus_cdx_driver.h | 25 drivers/bus/cdx/cdx.c | 11 ++ drivers/bus/cdx/cdx_vfio.c

[PATCH v2 2/6] bus/cdx: add dma map and unmap support

2023-04-13 Thread Nipun Gupta
CDX bus can use VFIO interface for mapping and unmapping of DMA addresses in the IOMMU. This change adds the callback support for map and unmap APIs as well as fetching the IOMMU class. Signed-off-by: Nipun Gupta --- drivers/bus/cdx/cdx.c | 40 1 file cha

[PATCH v2 0/6] add support for CDX bus

2023-04-13 Thread Nipun Gupta
Support AMD CDX bus, for FPGA based CDX devices. The CDX devices are memory mapped on system bus for embedded CPUs. It uses sysfs interface and the vfio-cdx driver to discover and initialize the CDX devices. The patches are intended for DPDK 23.07 release, and have been sent as an RFC as patches

[PATCH v2 4/6] bus/cdx: support plug unplug and dev iterator

2023-04-13 Thread Nipun Gupta
This change adds support for plugging and unplugging CDX devices on the CDX bus. Also, CDX dev iterator support has been added for the CDX bus. Signed-off-by: Nipun Gupta --- drivers/bus/cdx/bus_cdx_driver.h | 1 + drivers/bus/cdx/cdx.c| 122 +++ 2 files

[PATCH v2 1/6] bus/cdx: introduce cdx bus

2023-04-13 Thread Nipun Gupta
CDX bus supports multiple type of devices, which can be exposed to user-space via vfio-cdx. vfio-cdx provides the MMIO IO_MEMORY regions as well as the DMA interface for the device (IOMMU). This support aims to enable the DPDK to support the cdx devices in user-space using VFIO interface. Signed

[PATCH v2 5/6] bus: enable cdx bus

2023-04-13 Thread Nipun Gupta
enable the compilation of cdx bus Signed-off-by: Nipun Gupta --- drivers/bus/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build index 6d2520c543..a78b4283bf 100644 --- a/drivers/bus/meson.build +++ b/drivers/bus/meson.build @@ -3,6 +

[PATCH v2 6/6] config/arm: add AMD CDX

2023-04-13 Thread Nipun Gupta
Adding support for AMD CDX devices Signed-off-by: Nipun Gupta --- config/arm/arm64_cdx_linux_gcc | 17 + config/arm/meson.build | 14 ++ 2 files changed, 31 insertions(+) create mode 100644 config/arm/arm64_cdx_linux_gcc diff --git a/config/arm/arm64_cdx_lin

RE: [PATCH v2 1/3] eal: add x86 cpuid support for monitorx

2023-04-13 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] Hi David, > -Original Message- > From: David Marchand > Sent: Thursday, April 13, 2023 5:30 PM > To: Tummala, Sivaprasad > Cc: david.h...@intel.com; dev@dpdk.org; Thomas Monjalon > ; Burakov, Anatoly > Subject: Re: [PATCH v2 1/3] eal: add x86 cpuid su

[RFC PATCH 0/1] add DTS smoke tests

2023-04-13 Thread jspewock
From: Jeremy Spewock This patch series adds a set of smoke tests to be run at the beginning of DTS execution. The point is to validate the user’s setup before running “real” tests. This helps save time by bailing out of DTS early when the setup is not valid, and also prevents DTS displaying “fals

[RFC PATCH 1/1] dts: add smoke tests

2023-04-13 Thread jspewock
From: Jeremy Spewock Adds a new test suite for running smoke tests that verify general configuration aspects of the system under test. If any of these tests fail, the DTS execution terminates as part of a "fail-fast" model. Signed-off-by: Jeremy Spewock --- dts/conf.yaml

[PATCH] usertools: add tool to generate balanced rss traffic flows

2023-04-13 Thread Robin Jarry
From: 6WIND usage: dpdk-rss-flows.py [-h] [-s SPORT_RANGE] [-d DPORT_RANGE] [-r] [-k RSS_KEY] [-t RETA_SIZE] [-j] RX_QUEUES SRC DST Craft IP{v6}/{TCP/UDP} traffic flows that will evenly spread over a given number of RX queues according to the RSS

[PATCH v5 02/14] eal: use rtm and xtest intrinsics

2023-04-13 Thread Tyler Retzlaff
Inline assembly is not supported for MSVC x64. Convert code to use _xend, _xabort and _xtest intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson Acked-by: Konstantin Ananyev --- config/x86/meson.build| 6 ++ lib/eal/x86/include/rte_rtm.h | 18 +- 2

[PATCH v5 03/14] eal: use barrier intrinsics

2023-04-13 Thread Tyler Retzlaff
Inline assembly is not supported for MSVC x64 instead expand rte_compiler_barrier as _ReadWriteBarrier and for rte_smp_mb _m_mfence intrinsics. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson Acked-by: Konstantin Ananyev --- lib/eal/include/generic/rte_atomic.h | 4 lib/eal/x86/i

[PATCH v5 00/14] msvc integration changes

2023-04-13 Thread Tyler Retzlaff
In accordance with draft plan http://mails.dpdk.org/archives/web/2023-February/002023.html introduces conditionally compiled code to enable building with MSVC that _does not_ require C99/C11 meaning it can be integrated now. This series covers minimal changes for item #2 in draft plan for EAL depe

[PATCH v5 01/14] eal: use rdtsc intrinsic

2023-04-13 Thread Tyler Retzlaff
Inline assembly is not supported for MSVC x64. Convert code to use __rdtsc intrinsic. Signed-off-by: Tyler Retzlaff Acked-by: Konstantin Ananyev --- lib/eal/x86/include/rte_cycles.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/eal/x86/include/rte_cycles

[PATCH v5 04/14] eal: use cpuid and cpuidex intrinsics

2023-04-13 Thread Tyler Retzlaff
Inline assembly is not supported for MSVC x64 instead use __cpuid and __cpuidex intrinsics. Signed-off-by: Tyler Retzlaff --- lib/eal/x86/rte_cpuflags.c | 4 lib/eal/x86/rte_cpuid.h | 7 +++ lib/eal/x86/rte_cycles.c | 36 lib/eal/x86/rte

[PATCH v5 05/14] eal: use umonitor umwait and tpause intrinsics

2023-04-13 Thread Tyler Retzlaff
Inline assembly is not supported for MSVC x64 instead use _umonitor, _umwait and _tpause intrinsics. Signed-off-by: Tyler Retzlaff --- lib/eal/x86/rte_power_intrinsics.c | 12 1 file changed, 12 insertions(+) diff --git a/lib/eal/x86/rte_power_intrinsics.c b/lib/eal/x86/rte_power_

[PATCH v5 07/14] eal: use byte swap intrinsics

2023-04-13 Thread Tyler Retzlaff
Inline assembly is not supported for MSVC x64 instead expand use _byteswap_u{ushort,ulong,uint64} intrinsics instead. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_byteorder.h | 11 +++ lib/eal/x86/include/rte_byteorder.h | 4 2 files changed, 15 insertions(+)

[PATCH v5 06/14] eal: use prefetch intrinsics

2023-04-13 Thread Tyler Retzlaff
Inline assembly is not supported for MSVC x64 instead use _mm_prefetch and _mm_cldemote intrinsics. Signed-off-by: Tyler Retzlaff --- lib/eal/x86/include/rte_prefetch.h | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/lib/eal/x86/include/rte_prefetch

[PATCH v5 09/14] eal: hide GCC extension based alignment markers

2023-04-13 Thread Tyler Retzlaff
When compiling with MSVC don't expose typedefs used as alignment markers. Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_common.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index 15765b4..2f464e3 100644 --- a/lib/eal

[PATCH v5 10/14] eal: hide typedefs based on GCC vector extensions

2023-04-13 Thread Tyler Retzlaff
When compiling with MSVC don't expose typedefs based on GCC vector extensions. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_vect.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/include/generic/rte_vect.h b/lib/eal/include/generic/rte_vect.h index 3fec2bf..7775

[PATCH v5 08/14] eal: typedef cpu flag enum as int

2023-04-13 Thread Tyler Retzlaff
Forward declaration of a enum is a non-standard extension and is not supported by MSVC. Use an int instead. Abstract the use of the int/enum rte_cpu_flag_t in function parameter lists by re-typdefing the enum rte_cpu_flag_t to the rte_cpu_flag_t identifier. Remove the use of __extension__ on func

[PATCH v5 12/14] eal: exclude exposure of rte atomic APIs for MSVC builds

2023-04-13 Thread Tyler Retzlaff
It's discouraged to use rte_atomics APIs instead standard APIs should be used from C11. Since MSVC is a new toolchain/platform combination block visibility of the rte_atomic APIs from day 1. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_atomic.h | 7 +++ lib/eal/x86/include/r

[PATCH v5 14/14] eal: always define MSVC as little endian

2023-04-13 Thread Tyler Retzlaff
The MSVC compiler does not target big endian platforms so define little endian always. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_byteorder.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/include/generic/rte_byteorder.h b/lib/eal/include/generic/rte_byteorder.

[PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-13 Thread Tyler Retzlaff
For now expand a lot of common rte macros empty. The catch here is we need to test that most of the macros do what they should but at the same time they are blocking work needed to bootstrap of the unit tests. Later we will return and provide (where possible) expansions that work correctly for msv

[PATCH v5 13/14] telemetry: avoid expanding versioned symbol macros on MSVC

2023-04-13 Thread Tyler Retzlaff
Windows does not support versioned symbols. Fortunately Windows also doesn't have an exported stable ABI. Export rte_tel_data_add_array_int -> rte_tel_data_add_array_int_24 and rte_tel_data_add_dict_int -> rte_tel_data_add_dict_int_v24 functions. Windows does have a way to achieve similar version

[PATCH v1 0/5] fix RX data buffer size

2023-04-13 Thread Wenjun Wu
This patch set fixes RX data buffer size in ice, i40e, iavf and idpf driver. 1. Limit the maximum buffer size to no more than 16K - 128. 2. Align max buffer size to 128, or replace RTE_ALIGN with RTE_ALIGN_FLOOR according to [1]. [1] Commit c9c45beb1b97 ("net/iavf: fix Rx queue buffer size alignm

[PATCH v1 1/5] net/i40e: fix RX data buffer size

2023-04-13 Thread Wenjun Wu
No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/net/i40e/i40e_rxtx.c | 2 ++ drivers/net/i40e/i40e_rxtx.h | 3 +++ 2 files changed, 5 insertion

[PATCH v1 2/5] net/ice: fix RX data buffer size

2023-04-13 Thread Wenjun Wu
This patch does two fixes. 1. No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. 2. Replace RTE_ALIGN with RTE_ALIGN_FLOOR according to [1]. [1] Commit c9c45beb1b97 ("net/iavf: fix Rx queue buffer size alignment") Fixes: 50370662b727 ("net/ice: support d

[PATCH v1 3/5] net/iavf: fix RX data buffer size

2023-04-13 Thread Wenjun Wu
No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf_rxtx.c | 1 + drivers/net/iavf/iavf_rxtx.h | 3 +++ 2 files changed, 4 inse

[PATCH v1 4/5] net/idpf: fix RX data buffer size

2023-04-13 Thread Wenjun Wu
This patch does two fixes. 1. No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. 2. Align data buffer size to 128. Fixes: 9c47c29739a1 ("net/idpf: add Rx queue setup") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/common/idpf/idpf_common_rxt

[PATCH v1 5/5] net/cpfl: fix RX data buffer size

2023-04-13 Thread Wenjun Wu
This patch does two fixes. 1. No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. 2. Align data buffer size to 128. Signed-off-by: Wenjun Wu --- drivers/net/cpfl/cpfl_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ne

Re: Regarding DPDK API's like rte_timer_subsystem_init/rte_hash_create etc. in VPP

2023-04-13 Thread Prashant Upadhyaya
On Fri, Mar 31, 2023 at 4:19 PM Bruce Richardson wrote: > > On Fri, Mar 31, 2023 at 03:11:18PM +0530, Prashant Upadhyaya wrote: > > On Thu, Mar 30, 2023 at 7:34 PM Bruce Richardson > > wrote: > > > > > > On Thu, Mar 30, 2023 at 07:07:23PM +0530, Prashant Upadhyaya wrote: > > > > On Thu, Mar 30, 2

[PATCH] examples/ipsec-secgw: fix AES-CTR IV length

2023-04-13 Thread Tejasree Kondoj
Set AES-CTR IV length to 8 in SA config as it is used for per packet IV length and set it to 16 in xform since the application populates 16B IV in the datapath. AES-CTR requires 16B IV constructed from nonce and counter. Fixes: 5ff7502f345e ("examples/ipsec-secgw: set AES-CTR IV length to 16") Si

RE: [PATCH] examples/ipsec-secgw: fix AES-CTR IV length

2023-04-13 Thread Anoob Joseph
> Subject: [PATCH] examples/ipsec-secgw: fix AES-CTR IV length > > Set AES-CTR IV length to 8 in SA config as it is used for per packet IV > length and > set it to 16 in xform since the application populates 16B IV in the datapath. > AES- > CTR requires 16B IV constructed from nonce and counter.

[PATCH] Check whether the driver is compatible with the device presented.

2023-04-13 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. This patch is dependent on https://patchwork.dpdk.org/project/dpdk/list/?series=27687&state=* Signed-off-by: Rushil Gupta Signed

[PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-04-13 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. This patch is dependent on https://patchwork.dpdk.org/project/dpdk/list/?series=27687&state=* Signed-off-by: Rushil Gupta Signed

Re: [PATCH 1/1] net/gve: update base code for DQO

2023-04-13 Thread Rushil Gupta
I want to highlight that we wish to keep license changes separate from this patch (probably for 23.11). This patch is to simply support basic structures for the DQO data path. On Wed, Apr 12, 2023 at 11:04 AM Rushil Gupta wrote: > Sorry for the confusion. I was talking about the same patch (titl

[PATCH] net/ice: support link speed change

2023-04-13 Thread Kaiwen Deng
Support link speed change functions for ice, and when start the ice, apply link speed to hardware. This feature supports changing the link speed via the testpmd command "port config speed 10|100|1000|1|25000|4|5|10 |20|40|auto duplex half|full|auto". Signed-off-by: Kaiwen

[PATCH v2 0/5] fix Rx data buffer size

2023-04-13 Thread Wenjun Wu
This patch set fixes RX data buffer size in ice, i40e, iavf and idpf driver. 1. Limit the maximum buffer size to no more than 16K - 128. 2. Align max buffer size to 128, or replace RTE_ALIGN with RTE_ALIGN_FLOOR according to [1]. [1] Commit c9c45beb1b97 ("net/iavf: fix Rx queue buffer size alignm

[PATCH v2 1/5] net/i40e: fix Rx data buffer size

2023-04-13 Thread Wenjun Wu
No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/net/i40e/i40e_rxtx.c | 2 ++ drivers/net/i40e/i40e_rxtx.h | 3 +++ 2 files changed, 5 insertion

[PATCH v2 2/5] net/ice: fix Rx data buffer size

2023-04-13 Thread Wenjun Wu
This patch does two fixes. 1. No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. 2. Replace RTE_ALIGN with RTE_ALIGN_FLOOR according to [1]. [1] Commit c9c45beb1b97 ("net/iavf: fix Rx queue buffer size alignment") Fixes: 50370662b727 ("net/ice: support d

[PATCH v2 3/5] net/iavf: fix Rx data buffer size

2023-04-13 Thread Wenjun Wu
No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf_rxtx.c | 1 + drivers/net/iavf/iavf_rxtx.h | 3 +++ 2 files changed, 4 inse

[PATCH v2 4/5] net/idpf: fix Rx data buffer size

2023-04-13 Thread Wenjun Wu
This patch does two fixes. 1. No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. 2. Align data buffer size to 128. Fixes: 9c47c29739a1 ("net/idpf: add Rx queue setup") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/common/idpf/idpf_common_rxt

[PATCH v2 5/5] net/cpfl: fix Rx data buffer size

2023-04-13 Thread Wenjun Wu
This patch does two fixes. 1. No matter what the mbuf size is, the data buffer size should not be greater than 16K - 128. 2. Align data buffer size to 128. Fixes: 119834846e93 ("net/cpfl: support Rx queue setup") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/net/cpfl/cpfl_rxtx.c |

RE: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-13 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 13 April 2023 23.26 > > For now expand a lot of common rte macros empty. The catch here is we > need to test that most of the macros do what they should but at the same > time they are blocking work needed to bootstrap