On Thu, Apr 13, 2023 at 11:44:38AM +0800, fengchengwen wrote:
> On 2023/4/12 17:52, Bruce Richardson wrote:
> > On Wed, Apr 12, 2023 at 02:48:08AM +0000, Chengwen Feng wrote:
> >> Add tracepoints at important APIs for tracing support.
> >>
> >> Signed-off-by: Chengwen Feng <fengcheng...@huawei.com>
> >> ---
> >> lib/dmadev/meson.build | 2 +-
> >> lib/dmadev/rte_dmadev.c | 39 ++++++--
> >> lib/dmadev/rte_dmadev.h | 56 ++++++++---
> >> lib/dmadev/rte_dmadev_trace.h | 133 +++++++++++++++++++++++++++
> >> lib/dmadev/rte_dmadev_trace_fp.h | 113 +++++++++++++++++++++++
> >> lib/dmadev/rte_dmadev_trace_points.c | 59 ++++++++++++
> >> lib/dmadev/version.map | 10 ++
> >> 7 files changed, 391 insertions(+), 21 deletions(-)
> >> create mode 100644 lib/dmadev/rte_dmadev_trace.h
> >> create mode 100644 lib/dmadev/rte_dmadev_trace_fp.h
> >> create mode 100644 lib/dmadev/rte_dmadev_trace_points.c
> >>
> > For completeness, do you have any numbers for the performance impact (if
> > any) to the DMA dataplane APIs with this tracing added?
>
> No, because:
>
> The dataplane trace points was disable default (unless the
> RTE_ENABLE_TRACE_FP is set),
> so there will no trace-points code default.
>
> So I think it will not impact performance default.
>
Right, I'd missed that bit. Thanks.
