[PATCH v6] net/i40e: rework maximum frame size configuration

2023-02-20 Thread Simei Su
One issue is reported by David Marchand that error occurs in OVS due to the fix patch in mentioned changes below. The detailed reproduce step and result are in https://patchwork.dpdk.org/project/dpdk/patch/ 20211207085946.121032-1-dapengx...@intel.com/. This patch removes unnecessary link status c

RE: [PATCH v1 00/13] graph enhancement for multi-core dispatch

2023-02-20 Thread Yan, Zhirun
Hi Thomas, Jerin and Kiran gave some comments before. And @jer...@marvell.com @kirankum...@marvell.com could you help to review it? Thanks. > -Original Message- > From: Thomas Monjalon > Sent: Monday, February 20, 2023 8:22 AM > To: jer...@marvell.com; kirankum...@marvell.com; > ndabilp

[PATCH v2 0/3] update NFP documentation

2023-02-20 Thread Chaoyong He
In response to the reviewer's comments, this patch series is split into three different commits. --- v2: * Split into three commits. --- Walter Heymans (3): doc: wrap nfp doc to 80 characters and improve grammar doc: update outdated information for the nfp PMD doc: add Corigine information

[PATCH v2 1/3] doc: wrap nfp doc to 80 characters and improve grammar

2023-02-20 Thread Chaoyong He
From: Walter Heymans Wrap the nfp.rst documentation to 80 characters to improve readability in raw format. Also fix some grammatical errors. Signed-off-by: Walter Heymans Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/nfp.rst | 76 +

[PATCH v2 2/3] doc: update outdated information for the nfp PMD

2023-02-20 Thread Chaoyong He
From: Walter Heymans Update nfp documentation with new information and remove outdated information. The most significant changes that are updated include: - Previously the NFP PMD did not support functionality to control VFs, it now does. - Previously the PF had to be bound to the kernel driver

[PATCH v2 3/3] doc: add Corigine information to nfp documentation

2023-02-20 Thread Chaoyong He
From: Walter Heymans Add Corigine information to the nfp documentation. The Network Flow Processor (NFP) PMD is used by products from both Netronome and Corigine. Signed-off-by: Walter Heymans Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/nfp.rst | 78 +++

RE: [PATCH v2 2/4] config/arm: add NVIDIA BlueField-3 platform

2023-02-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ruifeng Wang > Sent: Monday, February 20, 2023 4:51 AM > To: Raslan Darawsheh ; NBU-Contact-Thomas > Monjalon (EXTERNAL) > Cc: dev@dpdk.org; Bruce Richardson ; nd > > Subject: RE: [PATCH v2 2/4] config/arm: add NVIDIA BlueField-3 platform > > > -Ori

[PATCH v3 2/4] config/arm: add NVIDIA BlueField-3 platform

2023-02-20 Thread Raslan Darawsheh
Add meson build configuration for NVIDIA BlueField-3 platform with Cortex-A78AE cores. Signed-off-by: Raslan Darawsheh --- config/arm/arm64_bluefield3_linux_gcc | 16 config/arm/meson.build| 16 2 files changed, 32 insertions(+) create mode 1006

[PATCH v3 3/4] crypto/mlx5: add Bluefield-3 and ConnectX-7 device IDs

2023-02-20 Thread Raslan Darawsheh
This adds the Bluefield-3 and ConnectX-7 device IDs to the list of supported NVIDIA devices that run the MLX5 compress PMD. The BlueField-3 device is still in development stage. Signed-off-by: Raslan Darawsheh --- drivers/crypto/mlx5/mlx5_crypto.c | 8 1 file changed, 8 insertions(+) d

[PATCH v3 4/4] doc: update supported devices for NVIDIA NICs

2023-02-20 Thread Raslan Darawsheh
This update the supproted list of devices to include missing ConnectX-7 in some drivers and add BlueFeild-3 Signed-off-by: Raslan Darawsheh --- doc/guides/compressdevs/mlx5.rst | 5 +++-- doc/guides/cryptodevs/mlx5.rst | 12 doc/guides/nics/mlx5.rst | 33 +

[PATCH v3 1/4] mlx: update PCI device IDs names for NVIDIA BlueField NICs

2023-02-20 Thread Raslan Darawsheh
This updates the PCI device names for all NVIDIA BlueField family. Signed-off-by: Raslan Darawsheh --- drivers/common/mlx5/mlx5_common.h | 8 drivers/common/mlx5/mlx5_common_pci.c | 2 +- drivers/compress/mlx5/mlx5_compress.c | 4 ++-- drivers/crypto/mlx5/mlx5_crypto.c | 2 +

[PATCH v3 0/4] support NVIDIA Bluefield-3 device

2023-02-20 Thread Raslan Darawsheh
this series is intentioned to update missing docs, drivers and config for supporting NVIDIA BlueField-3 device. --- v2: send cover letter fix patches order v3: add missing cross build file --- Raslan Darawsheh (4): mlx: update PCI device IDs names for NVIDIA BlueField NICs config/arm: ad

[PATCH v6 0/2] Enable PMD power management on Arm

2023-02-20 Thread Feifei Wang
For Arm aarch, use WFE instructions to enable PMD power management. Test Results: dynamic instructions over 1sec without wfe with wfepercentage ampere-altra6,298,483,712 9,117,624 -99.855% thunderx2 6,990,909,373 3,247,226 -99.

[PATCH v6 1/2] eal: add 8 bits case for wait scheme

2023-02-20 Thread Feifei Wang
For wait scheme generic helper, add 8 bits case. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/eal/arm/include/rte_pause_64.h | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/lib/eal/arm/include/rte_pause_64.h b/lib/eal/arm/include

[PATCH v6 2/2] eal: add power mgmt support on Arm

2023-02-20 Thread Feifei Wang
For Arm arch, use WFE instruction to enable power monitor API, and use SEV instruction to enable wake up API. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Acked-by: David Hunt --- doc/guides/rel_notes/release_23_03.rst | 4 ++ lib/eal/arm/include/rte_pause_64.h | 5 ++- lib/eal/a

[PATCH v2] net/nfp: fix 48-bit DMA address support for NFDk

2023-02-20 Thread Chaoyong He
From: Peng Zhang Initializing of the NFP PMD fails when a NFDk device is used in a PCIe slot that supports 48-bit DMA address. The failure is due to an incorrect check by the PMD that limits the support to 40-bit DMA address. While this check is correct for NFD3 devices, it is incorrect for NFDk

[PATCH v2] net/hns3: support IOVA as VA

2023-02-20 Thread Chengwen Feng
Claim PMD supports pmd_supports_disable_iova_as_pa. Signed-off-by: Chengwen Feng Reviewed-by: Ruifeng Wang Acked-by: Dongdong Liu --- v2: modify commit head which address Thomas's comment add reviewed and acked by of v1. --- drivers/net/hns3/hns3_rxtx_vec_neon.h | 2 +- drivers/net/hns3

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread fengchengwen
On 2023/2/20 15:44, Thomas Monjalon wrote: > 16/02/2023 09:36, Ruifeng Wang: >> From: Chengwen Feng >>> Subject: [PATCH] net/hns3: support disable IOVA as PA mode > > Could we change the title to "support IOVA as VA" ? v2 fix it, please review, thanks. > >>> >>> Claim PMD supports pmd_supports

Re: [PATCH v1 00/13] graph enhancement for multi-core dispatch

2023-02-20 Thread Jerin Jacob
On Mon, Feb 20, 2023 at 1:58 PM Yan, Zhirun wrote: > > Hi Thomas, > > Jerin and Kiran gave some comments before. > And @jer...@marvell.com @kirankum...@marvell.com > could you help to review it? Sure. I will do the next level. > Thanks. > > > -Original Message- > > From: Thomas Monjalo

RE: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 20 February 2023 08.45 > > 16/02/2023 09:36, Ruifeng Wang: > > From: Chengwen Feng > > > Subject: [PATCH] net/hns3: support disable IOVA as PA mode > > Could we change the title to "support IOVA as VA" ? The underlying problem

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-20 Thread Konstantin Ananyev
> If ethdev enqueue or dequeue function is called during > eth_dev_fp_ops_setup(), it may get pre-empted after setting > the function pointers, but before setting the pointer to port data. > In this case the newly registered enqueue/dequeue function will use > dummy port data and end up in seg f

[RFC] net/ice: CVL support double vlan

2023-02-20 Thread Mingjin Ye
Aligned with kernel driver, optimized for inner and outer VLAN handling in DPDK, and implemented double vlan insertion and stripping support. 1.adjust vlan stripping Remove the judgment on dvm, vlan stripping only operates inner vlan. 2.support QinQ stripping This patch support ice outer vlan str

RE: [PATCH v4 07/12] app/mldev: enable support for burst inferences

2023-02-20 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:20 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [PATCH v4 07/12] app/m

Re: [PATCH 2/3] net/nfp: get rid of the usage of RTE log level type

2023-02-20 Thread Ferruh Yigit
On 2/20/2023 1:36 AM, Chaoyong He wrote: >> On 2/17/2023 2:45 AM, Chaoyong He wrote: >>> Register the own RX/TX debug log level type, and get rid of the usage >>> of RTE_LOGTYPE_*. Then we can control the log by a independent switch. >>> >>> Signed-off-by: Chaoyong He >>> Reviewed-by: Niklas Söder

Re: [PATCH v4 00/10] dts: add hello world testcase

2023-02-20 Thread Juraj Linkeš
Thanks for the comments, Bruce. On Fri, Feb 17, 2023 at 6:26 PM Bruce Richardson wrote: > > On Mon, Feb 13, 2023 at 04:28:36PM +0100, Juraj Linkeš wrote: > > Add code needed to run the HelloWorld testcase which just runs the hello > > world dpdk application. > > > > The patchset currently heavily

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Thomas Monjalon
20/02/2023 10:43, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday, 20 February 2023 08.45 > > > > 16/02/2023 09:36, Ruifeng Wang: > > > From: Chengwen Feng > > > > Subject: [PATCH] net/hns3: support disable IOVA as PA mode > > > > Could we change the title

Re: [PATCH v3 0/4] support NVIDIA Bluefield-3 device

2023-02-20 Thread Thomas Monjalon
> Raslan Darawsheh (4): > mlx: update PCI device IDs names for NVIDIA BlueField NICs > config/arm: add NVIDIA BlueField-3 platform > crypto/mlx5: add Bluefield-3 and ConnectX-7 device IDs > doc: update supported devices for NVIDIA NICs Applied, thanks.

[PATCH v2 0/2] reorder: introduce new APIs

2023-02-20 Thread Volodymyr Fialko
This patch series provides new APIs for reorder library and test cases for them. v2: - squash tests with corresponding API patches - address minor comments Volodymyr Fialko (2): reorder: add new drain up to seq number API reorder: add ability to set min sequence number app/test/test_reorder

[PATCH v2 1/2] reorder: add new drain up to seq number API

2023-02-20 Thread Volodymyr Fialko
Introduce new reorder drain API: `rte_reorder_drain_up_to_seqn` - exhaustively drain all inserted mbufs up to the given sequence number. Currently there's no ability to force the drain from reorder buffer, i.e. only consecutive ordered or ready packets could be drained. New function would give use

[PATCH v2 2/2] reorder: add ability to set min sequence number

2023-02-20 Thread Volodymyr Fialko
Add API `rte_reorder_min_seqn_set` to allow user to specify minimum sequence number. Currently sequence number of first inserted packet is used as minimum sequence number. But for case when we want to wait for packets before the received one this will not work. Signed-off-by: Volodymyr Fialko ---

Re: [PATCH v3] bus: add platform bus

2023-02-20 Thread Thomas Monjalon
15/02/2023 12:10, Tomasz Duszynski: > Platform bus is a software bus under Linux that manages devices which > generally do not have built-in discovery mechanisms. Linux normally > learns about platform devices directly from device-tree during > boot-up phase. > > Up to this point, whenever some us

Re: [PATCH] malloc: fix malloc performance may becomes worse as the number of malloc increases

2023-02-20 Thread David Marchand
On Fri, Feb 10, 2023 at 7:30 AM Fengnan Chang wrote: > > Here is a simple test case: > " > uint64_t entry_time, time; > size_t size = 4096; > unsigned align = 4096; > for (int j = 0; j < 10; j++) { > entry_time = rte_get_timer_cycles(); > for (int i = 0; i < 2000; i++) { >

Re: [PATCH v2 0/2] reorder: introduce new APIs

2023-02-20 Thread Thomas Monjalon
20/02/2023 11:48, Volodymyr Fialko: > This patch series provides new APIs for reorder library and test cases for > them. > > v2: > - squash tests with corresponding API patches > - address minor comments Thanks In absence of review, I will just wait for the CI to complete before merging.

Re: [PATCH 0/2] *** Memory Allocation: Fixes ignore_msk during find_next_n() in fb_array library***

2023-02-20 Thread Thomas Monjalon
Anatoly, please could you look at this? 13/01/2023 14:14, Vipin P R: > *** > In the lookahead logic, let's say after the Right-Shift-And operation to > check for contiguity, we hit case > http://code.dpdk.org/dpdk/latest/source/lib/eal/common/eal_common_fbarray.c#L235 > > /* if fi

Re: [PATCH v7] mem: telemetry support for memseg and element information

2023-02-20 Thread Thomas Monjalon
25/10/2022 15:02, Amit Prakash Shukla: > Changes adds telemetry support to display memory occupancy > in memseg and the information of the elements allocated from > a memseg based on arguments provided by user. There was no comment since October. Can we merge?

RE: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 20 February 2023 11.17 > > 20/02/2023 10:43, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Monday, 20 February 2023 08.45 > > > > > > 16/02/2023 09:36, Ruifeng Wang: > > > > From: Chengwen Fe

Re: [PATCH] examples/cmdline: fix build error with gcc 12

2023-02-20 Thread Thomas Monjalon
10/02/2023 12:26, Olivier Matz: > Hi, > > Sorry for the late reply. > > On Thu, Jan 19, 2023 at 08:59:10AM +, Bruce Richardson wrote: > > On Wed, Jan 18, 2023 at 06:53:33PM +, Ferruh Yigit wrote: > > > On 1/18/2023 4:11 PM, Bruce Richardson wrote: > > > > When building the example without

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Bruce Richardson
On Mon, Feb 20, 2023 at 12:12:50PM +0100, Morten Brørup wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday, 20 February 2023 11.17 > > > > 20/02/2023 10:43, Morten Brørup: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Sent: Monday, 20 February 2023

Re: [PATCH v4 00/10] dts: add hello world testcase

2023-02-20 Thread Bruce Richardson
On Mon, Feb 20, 2023 at 11:13:45AM +0100, Juraj Linkeš wrote: > Thanks for the comments, Bruce. > > On Fri, Feb 17, 2023 at 6:26 PM Bruce Richardson > wrote: > > > > On Mon, Feb 13, 2023 at 04:28:36PM +0100, Juraj Linkeš wrote: > > > Add code needed to run the HelloWorld testcase which just runs

Re: [PATCH 0/3] refactor the nfp log subsystem

2023-02-20 Thread Ferruh Yigit
On 2/17/2023 2:45 AM, Chaoyong He wrote: > Follow the advice from community reviewer, we get rid of the use of > RTE log level type and RTE_LOG_*() macro, and also wrap the rte_log() > with our own log macro. > > Chaoyong He (3): > net/nfp: add the log source file > net/nfp: get rid of the usa

RE: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 20 February 2023 12.53 > > On Mon, Feb 20, 2023 at 12:12:50PM +0100, Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Monday, 20 February 2023 11.17 > > > > > > 20/02/2023 10:43, M

Re: [PATCH v6 0/2] Enable PMD power management on Arm

2023-02-20 Thread David Marchand
On Mon, Feb 20, 2023 at 9:51 AM Feifei Wang wrote: > > For Arm aarch, use WFE instructions to enable PMD power management. > > Test Results: > dynamic instructions over 1sec without wfe with wfepercentage > ampere-altra6,298,483,712 9,117,624 -99.855% > thu

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Bruce Richardson
On Mon, Feb 20, 2023 at 01:04:02PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Monday, 20 February 2023 12.53 > > > > On Mon, Feb 20, 2023 at 12:12:50PM +0100, Morten Brørup wrote: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] >

Re: [PATCH v2 2/3] doc: update outdated information for the nfp PMD

2023-02-20 Thread Ferruh Yigit
On 2/20/2023 8:41 AM, Chaoyong He wrote: > From: Walter Heymans > > Update nfp documentation with new information and remove outdated > information. The most significant changes that are updated include: > - Previously the NFP PMD did not support functionality to control VFs, > it now does. Wh

Re: [PATCH] app/testpmd: fix secondary process not forwarding

2023-02-20 Thread lihuisong (C)
在 2022/12/30 15:55, Shiyang He 写道: Under multi-process scenario, the secondary process gets queue state from the wrong location (the global variable 'ports'). Therefore, the secondary process can not forward since "stream_init" is not called. This commit fixes the issue by calling 'rte_eth_rx/

RE: [PATCH v3 1/1] app/test-flow-perf: fix division or module by zero

2023-02-20 Thread Wisam Monther
Hi, > -Original Message- > From: Mohammad Iqbal Ahmad > Sent: Tuesday, January 24, 2023 12:38 PM > To: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Wisam Monther ; Jack > Min > Cc: jer...@marvell.com; sk...@marvell.com; skotesh...@marvell.com; > pbhagavat...@marvell.com; kir

RE: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > On Mon, Feb 20, 2023 at 01:04:02PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Monday, 20 February 2023 12.53 > > > > > > On Mon, Feb 20, 2023 at 12:12:50PM +0100, Morten B

Re: [PATCH v3 1/1] app/test-flow-perf: fix division or module by zero

2023-02-20 Thread Thomas Monjalon
20/02/2023 13:46, Wisam Monther: > > --- a/.mailmap > > +++ b/.mailmap > > @@ -912,6 +912,7 @@ Mitch Williams Mit > > Matelske Mohamad Noor Alim Hussin > > > > Mohammad Abdul Awal > > +Mohammad Iqbal Ahmad > > Why you added such change in flow-perf related patch? That's because when it is

Re: [PATCH v4 3/3] ring: add telemetry cmd for ring info

2023-02-20 Thread David Marchand
On Fri, Feb 10, 2023 at 3:50 AM Jie Hai wrote: > > This patch supports dump of ring information by its name. > An example using this command is shown below: > > --> /ring/info,MP_mb_pool_0 > { > "/ring/info": { > "name": "MP_mb_pool_0", > "socket": 0, > "flags": "0x0", > "produce

Re: [PATCH v5 2/2] ethdev: support xstats reset telemetry command

2023-02-20 Thread Thomas Monjalon
17/02/2023 10:44, fengchengwen: > On 2023/2/16 20:54, Bruce Richardson wrote: > > On Thu, Feb 16, 2023 at 08:42:34PM +0800, fengchengwen wrote: > >> On 2023/2/16 20:06, Ferruh Yigit wrote: > >>> On 2/16/2023 11:53 AM, fengchengwen wrote: > On 2023/2/15 11:19, Dongdong Liu wrote: > > Hi Che

Re: [PATCH v4 01/10] dts: add node and os abstractions

2023-02-20 Thread Juraj Linkeš
On Fri, Feb 17, 2023 at 6:44 PM Bruce Richardson wrote: > > On Mon, Feb 13, 2023 at 04:28:37PM +0100, Juraj Linkeš wrote: > > The abstraction model in DTS is as follows: > > Node, defining and implementing methods common to and the base of SUT > > (system under test) Node and TG (traffic generator

Re: [PATCH v1 01/13] graph: split graph worker into common and default model

2023-02-20 Thread Jerin Jacob
On Thu, Nov 17, 2022 at 10:39 AM Zhirun Yan wrote: > > To support multiple graph worker model, split graph into common > and default. Naming the current walk function as rte_graph_model_rtc > cause the default model is RTC(Run-to-completion). There CI issues with this series. Please check https:/

Re: [PATCH v1 02/13] graph: move node process into inline function

2023-02-20 Thread Jerin Jacob
On Thu, Nov 17, 2022 at 10:40 AM Zhirun Yan wrote: > > Node process is a single and reusable block, move the code into an inline > function. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob > --- > lib/graph/rte_graph_model_rtc

Re: [PATCH] mempool:Add monitor dump for memory pool

2023-02-20 Thread Thomas Monjalon
01/01/2023 12:28, Morten Brørup: > > From: wushao...@chinatelecom.cn [mailto:wushao...@chinatelecom.cn] > > Sent: Sunday, 1 January 2023 06.18 > > > > From: Shaohua Wu > > > > rte_mempool_dump add dump for monitoring available and > > used memory blocks > > > > Signed-off-by: Shaohua Wu > > --

Re: [PATCH v1 03/13] graph: add macro to walk on graph circular buffer

2023-02-20 Thread Jerin Jacob
On Thu, Nov 17, 2022 at 10:40 AM Zhirun Yan wrote: > > It is common to walk on graph circular buffer and use macro to make > it reusable for other worker models. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > lib/graph/rte_graph_model_rtc.h

Re: [PATCH v3] hash: add XOR32 hash function

2023-02-20 Thread Thomas Monjalon
15/02/2023 12:06, Bili Dong: > An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its > use case in P4. We implement it in this patch so it could be easily > registered in the pipeline later. > > Signed-off-by: Bili Dong > --- > +/** > + * Calculate XOR32 hash on user-supplied byte

Re: [PATCH v1 04/13] graph: add get/set graph worker model APIs

2023-02-20 Thread Jerin Jacob
On Thu, Nov 17, 2022 at 10:40 AM Zhirun Yan wrote: > > Add new get/set APIs to configure graph worker model which is used to > determine which model will be chosen. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > lib/graph/rte_graph_worker.h

Re: [PATCH v2 2/2] test/mempool: add zero-copy API's

2023-02-20 Thread Thomas Monjalon
10/02/2023 08:33, Morten Brørup: > > From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > > Sent: Friday, 10 February 2023 07.54 > > > > Added mempool test cases with zero-copy get and put API's > > > > Signed-off-by: Kamalakshitha Aligeri > > Reviewed-by: Ruifeng Wang > > Revie

Re: [PATCH v2] net/nfp: fix 48-bit DMA address support for NFDk

2023-02-20 Thread Ferruh Yigit
On 2/20/2023 9:02 AM, Chaoyong He wrote: > From: Peng Zhang > > Initializing of the NFP PMD fails when a NFDk device is used in a PCIe > slot that supports 48-bit DMA address. The failure is due to an > incorrect check by the PMD that limits the support to 40-bit DMA > address. While this check i

Re: [PATCH v1 05/13] graph: introduce core affinity API

2023-02-20 Thread Jerin Jacob
On Thu, Nov 17, 2022 at 10:40 AM Zhirun Yan wrote: > > 1. add lcore_id for node to hold affinity core id. > 2. impl rte_node_model_generic_set_lcore_affinity to affinity node >with one lcore. > 3. update version map for graph public API. No need to explicitly tell 3. Rewrite 1 and 2 , one or

Re: [PATCH v1 06/13] graph: introduce graph affinity API

2023-02-20 Thread Jerin Jacob
On Thu, Nov 17, 2022 at 10:40 AM Zhirun Yan wrote: > > Add lcore_id for graph to hold affinity core id where graph would run on. > Add bind/unbind API to set/unset graph affinity attribute. lcore_id will > be set as MAX by default, it means not enable this attribute. > > Signed-off-by: Zhirun Yan

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Bruce Richardson
On Mon, Feb 20, 2023 at 01:47:13PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > > On Mon, Feb 20, 2023 at 01:04:02PM +0100, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > > Sent: Monday, 20 February

Re: [PATCH v2 1/3] net/ark: support secondary process

2023-02-20 Thread Ferruh Yigit
On 2/17/2023 9:59 PM, Ed Czeck wrote: > From: John Miller > > disable device configuration for secondary processes > > Signed-off-by: John Miller > --- > v2: > * Use standard logging > --- > drivers/net/ark/ark_ethdev.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > d

Re: [PATCH v1 08/13] graph: introduce stream moving cross cores

2023-02-20 Thread Jerin Jacob
On Thu, Nov 17, 2022 at 10:40 AM Zhirun Yan wrote: > > This patch introduces key functions to allow a worker thread to > enable enqueue and move streams of objects to the next nodes over > different cores. > > 1. add graph_sched_wq_node to hold graph scheduling workqueue node > stream > 2. add wor

Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

2023-02-20 Thread David Marchand
On Tue, Feb 14, 2023 at 12:37 PM Ankur Dwivedi wrote: > > >Subject: Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints > >from version map > > > >On Fri, Feb 10, 2023 at 7:54 PM David Marchand > > wrote: > >> > >> On Fri, Feb 10, 2023 at 8:06 AM Jerin Jacob wrote: > >> > > >> > On

Re: [PATCH v1 13/13] examples/l3fwd-graph: introduce generic worker model

2023-02-20 Thread Jerin Jacob
On Thu, Nov 17, 2022 at 10:41 AM Zhirun Yan wrote: > > Add new parameter "model" to choose generic or rtc worker model. > And in generic model, the node will affinity to worker core successively. > > Note: > only support one RX node for remote model in current implementation. > > ./dpdk-l3fwd-grap

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-20 Thread Konstantin Ananyev
> >> >> diff --git a/lib/pmu/rte_pmu.h b/lib/pmu/rte_pmu.h new file mode > >> >> 100644 index 00..6b664c3336 > >> >> --- /dev/null > >> >> +++ b/lib/pmu/rte_pmu.h > >> >> @@ -0,0 +1,212 @@ > >> >> +/* SPDX-License-Identifier: BSD-3-Clause > >> >> + * Copyright(c) 2023 Marvell > >> >> + */ >

Re: [PATCH v3 0/5] remove internal tracepoints from version map

2023-02-20 Thread Thomas Monjalon
> Ankur Dwivedi (5): > mempool: remove internal tracepoints from version map > cryptodev: remove internal tracepoints from version map > eal: remove internal tracepoints from version map > ethdev: remove internal tracepoints from version map > eventdev: remove internal tracepoints from ve

[PATCH] doc: fix reference to event timer header

2023-02-20 Thread David Marchand
The event timer header is rte_event_timer_adapter.h. Besides, we don't need to detail the full path to such a header. Fixes: 30e7fbd62839 ("doc: add event timer adapter guide") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- doc/guides/prog_guide/event_timer_adapter.rst | 2 +- 1 file cha

Re: [PATCH v2 2/3] net/ark: support for single function with multiple port

2023-02-20 Thread Ferruh Yigit
On 2/17/2023 9:59 PM, Ed Czeck wrote: > allows the creation of multiple ports from one ark device via > the use of ark pmd extension, though the splitting of queues Hi Ed, As far as I can see "single function with multiple port" support was already there but this commit is fixing queue index usag

Re: [PATCH 0/6] Testpmd code cleanup

2023-02-20 Thread David Marchand
Hi Robin, Ferruh, On Tue, Feb 14, 2023 at 7:22 PM Ferruh Yigit wrote: > > On 1/25/2023 1:50 PM, Robin Jarry wrote: > > David Marchand, Jan 24, 2023 at 11:47: > >> Here is a series to reduce code duplication in testpmd. > >> > >> This work started from looking at Robin series on reporting lcore bu

RE: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 20 February 2023 15.13 > > On Mon, Feb 20, 2023 at 01:47:13PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > > > > On Mon, Feb 20, 2023 at 01:04:02PM +0100, Morten Brøru

[PATCH v2] net/gve: fix Rx no mbufs stats counter update

2023-02-20 Thread Levend Sayar
rx no_mbufs stats counter update is added for another error case. Fixes: 4f6b1dd8240c ("net/gve: support basic statistics") Cc: junfeng@intel.com Signed-off-by: Levend Sayar --- drivers/net/gve/gve_rx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/gve/

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Thomas Monjalon
20/02/2023 16:07, Morten Brørup: > With the new viewing angle, the current define RTE_IOVA_AS_PA makes more > sense to me now than before. So we should probably stick with it, rather than > introduce something that might confuse developers who already have the same > viewing angle. > > But it s

Re: [PATCH v2 00/16] test/bbdev: changes for 23.03

2023-02-20 Thread Maxime Coquelin
Hi Hernan, In order to make reviewers and maintainers task easier, please apply the R-by and A-by given on previous revisions for patches that haven't changed. You can do it automatically when initiating a new revision by applying the previous one from patchwork, which takes care of adding them.

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Bruce Richardson
On Mon, Feb 20, 2023 at 04:30:20PM +0100, Thomas Monjalon wrote: > 20/02/2023 16:07, Morten Brørup: > > With the new viewing angle, the current define RTE_IOVA_AS_PA makes more > > sense to me now than before. So we should probably stick with it, rather > > than introduce something that might con

Re: [PATCH v2 2/2] baseband/acc: add check for empty queue

2023-02-20 Thread Maxime Coquelin
Hi Hernan, On 2/8/23 03:00, Hernan Vargas wrote: Add optimization to return early if there are no available descriptors in ring to dequeue. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH v2 1/2] baseband/acc: fix check after deref and dead code

2023-02-20 Thread Maxime Coquelin
On 2/8/23 03:00, Hernan Vargas wrote: Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Cc: sta...@dpdk.org Signed-off-by: H

Re: [PATCH v1 04/13] test/bbdev: early termination not explicit set

2023-02-20 Thread Maxime Coquelin
On 2/10/23 18:15, Vargas, Hernan wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, January 31, 2023 4:04 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v1 04/13] test/bbdev: early t

Re: [PATCH v1 08/13] test/bbdev: extend support for large TB

2023-02-20 Thread Maxime Coquelin
On 2/13/23 21:20, Vargas, Hernan wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, January 31, 2023 5:29 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v1 08/13] test/bbdev: extend s

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread Thomas Monjalon
20/02/2023 16:35, Bruce Richardson: > On Mon, Feb 20, 2023 at 04:30:20PM +0100, Thomas Monjalon wrote: > > 20/02/2023 16:07, Morten Brørup: > > > With the new viewing angle, the current define RTE_IOVA_AS_PA makes more > > > sense to me now than before. So we should probably stick with it, rather

Re: [PATCH 0/4] small fixes and improvements for qos_sched example

2023-02-20 Thread Thomas Monjalon
03/02/2023 11:05, Bruce Richardson: > This patchset contains a set of fixes and improvements for the qos_sched > application. After this patchset the code is shorter, and also seems a > little faster in my performance tests. > > Bruce Richardson (4): > examples/qos_sched: fix errors when TX port

Re: [PATCH v1 07/13] test/bbdev: add support for BLER for 4G

2023-02-20 Thread Maxime Coquelin
On 2/13/23 21:59, Vargas, Hernan wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, January 31, 2023 4:20 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v1 07/13] test/bbdev: add support for BL

Re: [PATCH 1/2] net/gve: change offloading capability

2023-02-20 Thread Ferruh Yigit
On 2/17/2023 9:11 AM, Guo, Junfeng wrote: > > >> -Original Message- >> From: Levend Sayar >> Sent: Friday, February 17, 2023 02:58 >> To: Guo, Junfeng >> Cc: dev@dpdk.org; Levend Sayar >> Subject: [PATCH 1/2] net/gve: change offloading capability >> >> Google Virtual NIC is not doing I

Re: [PATCH v2 0/2] reorder: introduce new APIs

2023-02-20 Thread Thomas Monjalon
20/02/2023 12:01, Thomas Monjalon: > 20/02/2023 11:48, Volodymyr Fialko: > > This patch series provides new APIs for reorder library and test cases for > > them. > > > > v2: > > - squash tests with corresponding API patches > > - address minor comments > > Thanks > In absence of review, I will ju

Re: [PATCH 1/2] net/mana: add version information for dependencies

2023-02-20 Thread Ferruh Yigit
On 1/20/2023 2:19 AM, lon...@linuxonhyperv.com wrote: > From: Long Li > > The required dependencies for mana from rdma-core and Linux kernel have > been released. Add those information to the doc. > > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") > Signed-off-by: Lon

Re: [PATCH v2 01/16] test/bbdev: fix seg fault for non supported HARQ len

2023-02-20 Thread Maxime Coquelin
On 2/15/23 18:09, Hernan Vargas wrote: Fix segmentation fault happening in corner case in test-bbdev. This fault could happen when running some specific vectors which size are not supported by the PMD. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: sta...@dpdk.org Signed-off-b

Re: [PATCH v2 02/16] test/bbdev: extend HARQ tolerance

2023-02-20 Thread Maxime Coquelin
On 2/15/23 18:09, Hernan Vargas wrote: HARQ memory implementation could have different size assumptions. Extending HARQ tolerance to cover different implementations. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbd

Re: [PATCH v2 03/16] test/bbdev: refactor TB throughput report

2023-02-20 Thread Maxime Coquelin
On 2/15/23 18:09, Hernan Vargas wrote: Refactor calculation for tb_size. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 38 ++-- 1 file changed, 16 insertions(+), 22 deletions(-) Reviewed-by: Maxime Coquelin Thank

Re: [PATCH 2/3] net/nfp: get rid of the usage of RTE log level type

2023-02-20 Thread Stephen Hemminger
On Mon, 20 Feb 2023 10:09:51 + Ferruh Yigit wrote: > On 2/20/2023 1:36 AM, Chaoyong He wrote: > >> On 2/17/2023 2:45 AM, Chaoyong He wrote: > >>> Register the own RX/TX debug log level type, and get rid of the usage > >>> of RTE_LOGTYPE_*. Then we can control the log by a independent switch

Re: [PATCH 1/2] net/bonding: add independent LACP sending function

2023-02-20 Thread Stephen Hemminger
On Mon, 20 Feb 2023 10:46:16 +0100 Simon Horman wrote: > On Thu, Feb 16, 2023 at 11:47:27AM -0800, Stephen Hemminger wrote: > > On Thu, 16 Feb 2023 15:15:13 +0800 > > Chaoyong He wrote: > > > > > +void > > > +rte_eth_bond_8023ad_lacp_send_one(void *queue) > > > +{ > > > + uint32_t i; > >

Re: [PATCH 2/3] net/nfp: get rid of the usage of RTE log level type

2023-02-20 Thread Ferruh Yigit
On 2/20/2023 4:16 PM, Stephen Hemminger wrote: > On Mon, 20 Feb 2023 10:09:51 + > Ferruh Yigit wrote: > >> On 2/20/2023 1:36 AM, Chaoyong He wrote: On 2/17/2023 2:45 AM, Chaoyong He wrote: > Register the own RX/TX debug log level type, and get rid of the usage > of RTE_LOGTYPE_

Re: [PATCH v2 04/16] test/bbdev: add timeout for latency tests

2023-02-20 Thread Maxime Coquelin
On 2/15/23 18:09, Hernan Vargas wrote: Add a timeout to force exit the latency tests in case dequeue never happens. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/app/test-bbde

Re: [PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-02-20 Thread David Marchand
On Tue, Feb 14, 2023 at 7:16 PM Ferruh Yigit wrote: > > On 1/24/2023 10:47 AM, David Marchand wrote: > > Reduce code duplication by introducing a helper that takes care of > > transmitting, retrying if enabled and incrementing tx counter. > > > > Signed-off-by: David Marchand > > <...> > > > diff

[PATCH v2 0/9] Testpmd code cleanup

2023-02-20 Thread David Marchand
Here is a series to reduce code duplication in testpmd. This work started from looking at Robin series on reporting lcore busy cycles in telemetry, which is then added in testpmd [1]. While looking at the forward engines code, I saw way too much duplicated code. Warning: this is only compile test

[PATCH v2 1/9] app/testpmd: fix Tx preparation in checksum engine

2023-02-20 Thread David Marchand
"unprepared" packets could get to the wire in the retry loop. Split packets freeing in two stages: one for preparation failure, and one for transmission failure. Adjust dropped counter update accordingly. Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum engine") Cc: sta...@dpdk.o

[PATCH v2 2/9] app/testpmd: fix packet count in ieee15888 engine

2023-02-20 Thread David Marchand
Don't count a packet has been transmitted before it is done. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test-pmd/ieee1588fwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/ieee1588fwd.c b/app/test-pm

[PATCH v2 3/9] app/testpmd: rework ieee1588 engine fwd configuration

2023-02-20 Thread David Marchand
This fwd engine currently ignores the forwarding configuration. Force it explicitly when initialising the stream. The code is then more consistent with other fwd engines (i.e. receiving on fs->rx_port, transmitting on fs->tx_port). Signed-off-by: David Marchand --- app/test-pmd/ieee1588fwd.c | 9

[PATCH v2 4/9] app/testpmd: fix packet transmission in noisy VNF engine

2023-02-20 Thread David Marchand
nb_rx relates to the number of packets received from the driver. nb_tx is the total number of packets transmitted by this forward engine. Fix the retry stage, for dequeued packets, as it was incorrectly passing nb_rx / nb_tx as bounds of the tmp_pkts[] array, and fix tx stats accordingly. Fixes:

[PATCH v2 5/9] app/testpmd: bulk free mbufs

2023-02-20 Thread David Marchand
Use the bulk free helper. Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit --- app/test-pmd/5tswap.c | 4 +--- app/test-pmd/csumonly.c | 4 +--- app/test-pmd/flowgen.c| 8 ++-- app/test-pmd/icmpecho.c | 4 +--- app/test-pmd/iofwd.c | 4 +--- app/t

  1   2   3   >