Here is a series to reduce code duplication in testpmd. This work started from looking at Robin series on reporting lcore busy cycles in telemetry, which is then added in testpmd [1]. While looking at the forward engines code, I saw way too much duplicated code.
Warning: this is only compile tested. 1: https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rja...@redhat.com/ -- David Marchand --- Changes since v1: - rebased now that Robin series was merged, - reordered patches (putting fixes first in the series), - fixed more issues in separate patches for ieee1588 and noisy VNF fwd engines, - removed unneeded helpers for cycles counting, --- David Marchand (9): app/testpmd: fix Tx preparation in checksum engine app/testpmd: fix packet count in ieee15888 engine app/testpmd: rework ieee1588 engine fwd configuration app/testpmd: fix packet transmission in noisy VNF engine app/testpmd: bulk free mbufs app/testpmd: factorize core cycles record app/testpmd: factorize fwd engine init app/testpmd: factorize fwd engine Rx app/testpmd: factorize fwd engine Tx app/test-pmd/5tswap.c | 54 +++---------------- app/test-pmd/csumonly.c | 61 ++++------------------ app/test-pmd/flowgen.c | 53 +++---------------- app/test-pmd/icmpecho.c | 60 +++------------------- app/test-pmd/ieee1588fwd.c | 39 ++++++-------- app/test-pmd/iofwd.c | 54 +++---------------- app/test-pmd/macfwd.c | 53 +++---------------- app/test-pmd/macswap.c | 58 +++------------------ app/test-pmd/noisy_vnf.c | 97 ++++++----------------------------- app/test-pmd/rxonly.c | 20 ++------ app/test-pmd/shared_rxq_fwd.c | 18 +++---- app/test-pmd/testpmd.c | 33 +++++++++--- app/test-pmd/testpmd.h | 53 ++++++++++++------- app/test-pmd/txonly.c | 31 ++--------- 14 files changed, 154 insertions(+), 530 deletions(-) -- 2.39.2