On Thursday, February 9, 2023 5:00 PM, Jiawen Wu wrote:
> On Wednesday, February 8, 2023 6:28 PM, Ferruh Yigit wrote:
> > On 2/2/2023 9:21 AM, Jiawen Wu wrote:
> > > When buffer size is less than 1K, round down makes it 0, which is an
> > > error value.
> > >
> > > Fixes: 62fc35e63d0e ("net/ngbe: s
Hi,
> -Original Message-
> From: Hamdan Igbaria
> Sent: Thursday, February 2, 2023 6:03 PM
> To: Hamdan Igbaria ; Slava Ovsiienko
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Suanming Mou ;
> Matan Azrad
> Cc: dev@dpdk.org; Ori Kam ; Alex Vesker
>
> Subject: [v2 1/5] net/mlx5/hws: fix
> From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com]
> Sent: Monday, 13 February 2023 19.18
>
> Integrated zero-copy put API in mempool cache in i40e PMD.
> On Ampere Altra server, l3fwd single core's performance improves by 5%
> with the new API
>
> Signed-off-by: Kamalakshitha A
Hi Ori Kam & dpdk dev team,
For the below rte flow action types, the description sounds a bit confusing to
me. Description says the data must start with ETH header up to the tunnel item.
But the next following statement(that describes MPLSoGRE example) mentions data
just holds layer 2 header. S
Hi,
> -Original Message-
> From: Ferruh Yigit
> Sent: Friday, February 10, 2023 3:45 AM
> To: Jiawei(Jonny) Wang ; Slava Ovsiienko
> ; Ori Kam ; NBU-Contact-
> Thomas Monjalon (EXTERNAL) ;
> andrew.rybche...@oktetlabs.ru; Aman Singh ;
> Yuying Zhang
> Cc: dev@dpdk.org; Raslan Darawsheh
On 2/14/2023 8:15 AM, Jiawen Wu wrote:
> On Thursday, February 9, 2023 5:00 PM, Jiawen Wu wrote:
>> On Wednesday, February 8, 2023 6:28 PM, Ferruh Yigit wrote:
>>> On 2/2/2023 9:21 AM, Jiawen Wu wrote:
When buffer size is less than 1K, round down makes it 0, which is an
error value.
On 2/14/2023 9:38 AM, Jiawei(Jonny) Wang wrote:
> Hi,
>
>> -Original Message-
>> From: Ferruh Yigit
>> Sent: Friday, February 10, 2023 3:45 AM
>> To: Jiawei(Jonny) Wang ; Slava Ovsiienko
>> ; Ori Kam ; NBU-Contact-
>> Thomas Monjalon (EXTERNAL) ;
>> andrew.rybche...@oktetlabs.ru; Aman Sin
13/02/2023 08:16, Ke Zhang:
> --- a/lib/eal/windows/include/pthread.h
> +++ b/lib/eal/windows/include/pthread.h
> +static inline void
> +pthread_exit(__rte_unused void *__retval)
> +{
> +}
Please don't add more shim layer.
There is a new layer rte_thread_* in lib/eal/include/rte_thread.h
On 1/24/2023 4:17 PM, David Marchand wrote:
Reduce code duplication by introducing a helper that takes care of
transmitting, retrying if enabled and incrementing tx counter.
Signed-off-by: David Marchand
---
app/test-pmd/5tswap.c| 22 +
app/test-pmd/csumonly.c | 23 +--
Hi Chengwen
On 2023/2/14 15:11, Chengwen Feng wrote:
Claim PMD supports pmd_supports_disable_iova_as_pa.
Signed-off-by: Chengwen Feng
This patch looks good to me. Many thanks for your work.
Acked-by: Dongdong Liu
Thanks,
Dongdong
13/02/2023 17:36, Raslan Darawsheh:
> From: Morten Brørup
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > On Mon, Feb 13, 2023 at 03:44:55PM +0100, David Marchand wrote:
> > > > Venerable RHEL7 clang 3.4.2 has (at least) two issues with lock
> > > > annotations.
> > > >
> > >
>Subject: Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints
>from version map
>
>On Fri, Feb 10, 2023 at 7:54 PM David Marchand
> wrote:
>>
>> On Fri, Feb 10, 2023 at 8:06 AM Jerin Jacob wrote:
>> >
>> > On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi
>wrote:
>> > >
>> > > >On Thu,
On 2/11/2023 9:18 AM, Dongdong Liu wrote:
> This patchset is to do some code optimization for Rx/Tx function.
>
> Huisong Li (6):
> net/hns3: fix querying dummy function failed
> net/hns3: add debug info for Rx/Tx dummy function
> net/hns3: remove debug condition for Tx prepare
> net/hns3:
This patchset add the support of port to port feature.
Port-to-port packets are looped back through the
host/NIC memory, without software involvement, using
the LAN RX and LAN TX DMA engines.
And this patchset only support the same port for Tx and Rx queue.
This patchset is based on the cpfl PMD
This patch add some structure for hairpin queue,
cpfl_rx_queue/cpfl_tx_queue/cpfl_vport.
Signed-off-by: Mingxia Liu
---
drivers/net/cpfl/cpfl_ethdev.c | 102 +++-
drivers/net/cpfl/cpfl_ethdev.h | 8 +-
drivers/net/cpfl/cpfl_rxtx.c| 196 +---
This patch update device initialization for hairpin queue.
Signed-off-by: Beilei Xing
Signed-off-by: Xiao Wang
Signed-off-by: Junfeng Guo
Signed-off-by: Mingxia Liu
---
drivers/common/idpf/idpf_common_device.c | 51
drivers/common/idpf/idpf_common_device.h | 2 +
drivers
This patch add hairpin queue ops
- hairpin_cap_get
- rx_hairpin_queue_setup
- tx_hairpin_queue_setup
Signed-off-by: Mingxia Liu
---
drivers/net/cpfl/cpfl_ethdev.c | 15 ++
drivers/net/cpfl/cpfl_rxtx.c | 443 -
drivers/net/cpfl/cpfl_rxtx.h | 22 +-
3 files
This patch add hairpin queue start and stop.
Signed-off-by: Beilei Xing
Signed-off-by: Xiao Wang
Signed-off-by: Junfeng Guo
Signed-off-by: Mingxia Liu
---
drivers/common/idpf/idpf_common_device.c | 1 +
drivers/common/idpf/idpf_common_virtchnl.c | 72 ++-
drivers/common/idpf/idpf_com
RSS should direct traffic only to the normal data Rx queues,
so when hairpin queue configured, RSS LUT should be adjusted
to exclude the hairpin queue.
Signed-off-by: Xiao Wang
Signed-off-by: Junfeng Guo
Signed-off-by: Mingxia Liu
---
drivers/net/cpfl/cpfl_ethdev.c | 38 ---
Per newest PRM definition, sample_id stands for 3 parts
of information instead of single uint32_t id: sample_id +
modify_filed_id + format_select_dw.
Also new FW capability bits have been introduces to identify
the new capability.
Signed-off-by: Rongwei Liu
Acked-by: Viacheslav Ovsiienko
---
d
Add IPv6 routing extension matching and IPv6 protocol modify filed
support.
This patch relies on the preceding ethdev one:
http://patches.dpdk.org/project/dpdk/patch/20230202100021.2445976-2-rongw...@nvidia.com/
Including one commit from Gregory to pass the compilation.
v3: add more sentences in
From: Gregory Etelson
New mlx5dr_context member replaces mlx5dr_cmd_query_caps.
Capabilities structure is a member of mlx5dr_context.
Signed-off-by: Gregory Etelson
Signed-off-by: Rongwei Liu
Reviewed-by: Alex Vesker
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/hws/mlx5dr_definer.c |
Add HWS modify IPv6 protocol implementation.
Signed-off-by: Rongwei Liu
Acked-by: Viacheslav Ovsiienko
---
drivers/common/mlx5/mlx5_prm.h | 1 +
drivers/net/mlx5/mlx5_flow_dv.c | 10 ++
2 files changed, 11 insertions(+)
diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx
Add mlx5 HWS logic to match IPv6 routing extension header.
Once detecting IPv6 matching extension items in pattern template
create callback, PMD allocates a flex parser to sample the first
dword of srv6 header.
Only support next_hdr/segments_left/type for now.
Signed-off-by: Rongwei Liu
Reviewe
Update mlx5 related document on IPv6 routing extension header
matching.
Signed-off-by: Rongwei Liu
Acked-by: Viacheslav Ovsiienko
---
doc/guides/nics/features/default.ini | 1 +
doc/guides/nics/features/mlx5.ini| 1 +
doc/guides/nics/mlx5.rst | 10 ++
3 files changed,
On 2/14/2023 1:35 AM, Chengwen Feng wrote:
> The number of xstats may be large, after the hide zero option is added,
> only non-zero values can be displayed.
>
> So display xstats with hide zero:
> /ethdev/xstats,0,hide_zero=true
> and without hide zero:
> /ethdev/xstats,0,hide_zero=fa
Introduce new flow action to skip congestion management configuration
This feature helps to skip the congestion management processing
based on per flow or the packet color identified by
rte_flow meter object. For example, If one Rx queue configured as
RED congestion and application wants tobypass t
added support for testpmd application to accept
skip_cman action while configuring policy action
Signed-off-by: Rakesh Kudurumalla
---
app/test-pmd/cmdline_flow.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 88108498
Dropping of packets is based on action configured
to meter.If both skip_red and drop actions are configured
then tail dropping in invoked else if only drop action is
configured then RED drop is invoked.This action is supported
only when RED is configured using rte_eth_cman_config_set()
Signed-off-
Updated release notes on new action to skip
congestion management configuration
Signed-off-by: Rakesh Kudurumalla
---
doc/guides/rel_notes/release_23_03.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/rel_notes/release_23_03.rst
b/doc/guides/rel_notes/release_23_
When the action parsing helper discovers it can "attach" to
an existing action set, it must invoke "delete" on the MAC
address(es) that it has "attached" to during parsing. That
is because the action set itself (i.e. not the flow rule
entry) holds a reference of the address(es).
Fixes: 4c6005999e4
On 2/10/2023 11:08 PM, Ferruh Yigit wrote:
> On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote:
>> added support for testpmd application to accept
>> skip_cman action while configuring policy action
>>
>
> Can you please give some sample testpmd commands with new action in
> commit log, it helps.
>
According to DPDK documentation, not specifying a
fate action in a flow rule results in undefined
behaviour. Define right behaviour in the driver.
Fixes: 0839236d0391 ("net/sfc: support flow action drop in transfer rules")
Cc: sta...@dpdk.org
Signed-off-by: Ivan Malov
Reviewed-by: Viacheslav Gal
On 2/14/2023 1:04 PM, Rakesh Kudurumalla wrote:
> Introduce new flow action to skip congestion management configuration
> This feature helps to skip the congestion management processing
> based on per flow or the packet color identified by
> rte_flow meter object. For example, If one Rx queue confi
On 2/14/2023 1:04 PM, Rakesh Kudurumalla wrote:
> Updated release notes on new action to skip
> congestion management configuration
>
> Signed-off-by: Rakesh Kudurumalla
please distribute this patch to relevant patches, like flow api update
can go into first patch (ethdev one), driver update to
On 2/14/2023 1:04 PM, Rakesh Kudurumalla wrote:
> added support for testpmd application to accept
> skip_cman action while configuring policy action
>
> Signed-off-by: Rakesh Kudurumalla
> ---
> app/test-pmd/cmdline_flow.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/app/te
Currently, the code tries to look up a user-provided item
by traversing those known to the PMD. Avoid the traversal
since it is easier to access items directly by their IDs,
with necessary checks to avoid reading past the buffer.
Signed-off-by: Ivan Malov
Reviewed-by: Viacheslav Galaktionov
Revi
On 2/14/23 16:27, Ivan Malov wrote:
Currently, the code tries to look up a user-provided item
by traversing those known to the PMD. Avoid the traversal
since it is easier to access items directly by their IDs,
with necessary checks to avoid reading past the buffer.
Signed-off-by: Ivan Malov
Rev
On 2/14/23 16:12, Ivan Malov wrote:
According to DPDK documentation, not specifying a
fate action in a flow rule results in undefined
behaviour. Define right behaviour in the driver.
Fixes: 0839236d0391 ("net/sfc: support flow action drop in transfer rules")
Cc: sta...@dpdk.org
Signed-off-by: I
On 2/14/23 16:06, Ivan Malov wrote:
When the action parsing helper discovers it can "attach" to
an existing action set, it must invoke "delete" on the MAC
address(es) that it has "attached" to during parsing. That
is because the action set itself (i.e. not the flow rule
entry) holds a reference o
On 2/3/2023 3:13 AM, Chaoyong He wrote:
> From: Zerun Fu
>
> Fix sections where the documentation have gone out of sync with the
> function names. While at it add documentation for functions to
> make it clear on what device they operate on.
>
> Signed-off-by: Zerun Fu
> Reviewed-by: Chaoyong H
On 2/13/23 13:25, Morten Brørup wrote:
From: Olivier Matz [mailto:olivier.m...@6wind.com]
Sent: Monday, 13 February 2023 10.37
Hello,
Thank you for this work, and sorry for the late feedback too.
Better late than never. And it's a core library, so important to get it right!
On Mon, Feb 13,
> -Original Message-
> From: Koikkara Reeny, Shibin
> Sent: Friday, February 10, 2023 3:48 PM
> To: dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly
> ; Richardson, Bruce
> ; Mcnamara, John
> Cc: Loftus, Ciara ; Koikkara Reeny, Shibin
>
> Subject: [PATCH v5] net/af_xdp: support CNI Integr
On 2/3/2023 7:05 AM, Chaoyong He wrote:
> This patch series mainly add the VXLAN inner TSO support with noudpcsum
> for NFP cards, includes:
> - Update related macrio definitions in Tx flag
> - Add the support for VXLAN inner TSO with noudpcsum
>
> Fei Qin (2):
> net/nfp: update macro definitio
When multiple ports are aggregated into a single DPDK port,
(example: Linux bonding, DPDK bonding, failsafe, etc.),
we want to know which port is used for Rx and Tx.
This patch introduces the new ethdev API
rte_eth_dev_map_aggr_tx_affinity(), it's used to map a Tx queue
with an aggregated port of
When multiple ports are aggregated into a single DPDK port,
(example: Linux bonding, DPDK bonding, failsafe, etc.),
we want to know which port use for Tx via a queue.
This patch introduces the new ethdev API
rte_eth_dev_map_aggr_tx_affinity(), it's used to map a Tx queue
with an aggregated port of
When multiple ports are aggregated into a single DPDK port,
(example: Linux bonding, DPDK bonding, failsafe, etc.),
we want to know which port is used for Rx and Tx.
This patch allows to map a Rx queue with an aggregated port by using
a flow rule. The new item is called RTE_FLOW_ITEM_TYPE_AGGR_AFF
On 16/01/2023 17:37, Bruce Richardson wrote:
The DMA device stop API can return an error value so check that return
value when running dmadev unit tests.
Signed-off-by: Bruce Richardson
---
app/test/test_dmadev.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
Acked-by: Kevin Laa
On 16/01/2023 17:37, Bruce Richardson wrote:
When the DMA device was stopped and restarted by the driver, the control
register specifying the behaviour on error was not getting correctly
reset. This caused unit tests to fail as explicitly introduced errors
were got getting reported back.
Fix by
On 16/01/2023 17:37, Bruce Richardson wrote:
Validate device operation when a device is stopped or restarted.
The only complication - and gap in the dmadev ABI specification - is
what happens to the job ids on restart. Some drivers reset them to 0,
while others continue where things left off. Ta
On 16/01/2023 17:37, Bruce Richardson wrote:
The HW DMA devices supported by IOAT driver do not transition to
the "active" state until the first operation is started by the HW.
Therefore, if the user calls "rte_dma_stop()" on a device without
triggering any operations, the sequence of commands to
On 16/01/2023 17:37, Bruce Richardson wrote:
As part of the process of restarting a dma instance, the IOAT driver
will reset the HW addresses and state values. The read and write
indexes for SW use need to be similarly reset to keep HW and SW in
sync.
Fixes: 583f046dd404 ("dma/ioat: add start an
On 16/01/2023 17:37, Bruce Richardson wrote:
The copy tests for dmadev had separate blocks in the test function for
single copy and burst copies. Separate out the single-copy block to its
own function so that it can be re-used if necessary.
Signed-off-by: Bruce Richardson
---
app/test/test_dm
On Monday, 13 February 2023 9:29, Akhil Goyal wrote:
>
> > Add a command line option `algo` to select the compress algorithm
> > supported by the compress API: null (DMA), deflate and lzs.
> >
> > Default for deflate.
> >
> > Signed-off-by: Matan Azrad
> > Signed-off-by: Michael Baum
> > ---
>
On Monday, 13 February 2023 9:23, Akhil Goyal wrote:
>
> From the description it seems to be a bug in previous implementation.
> Can we back port it? And update the patch title accordingly?
I'll update and send a new version.
> Also, release note update is not required for this fix.
I'll remove
Add support for LZ4 compression algorithm for both API and app.
In addition, enable app to test de/comp only. This option already
exists in both app doc and arguments but isn't implemented inside the
application.
LZ4: https://github.com/lz4/lz4
RFC:
https://patchwork.dpdk.org/project/dpdk/patch/2
Add support for LZ4 algorithm:
- Add Lz4 param structure to XFORM structures.
- Add capabilities flags for LZ4 params.
- Add xxHash-32 checksum and capabilities flag.
Signed-off-by: Michael Baum
---
doc/guides/compressdevs/features/default.ini | 7 ++
doc/guides/rel_notes/release_23_03.rst
Part of the application options is to test only compress and only
decompress but actually the application ignores this user option and
tries to test always both compress and decompress.
Allow testing only compress and only decompress.
Fixes: e0b6287c035d ("app/compress-perf: add parser")
Cc: toma
Fix some typos in comments and prints in this app.
Fixes: e0b6287c035d ("app/compress-perf: add parser")
Fixes: 2695db95a147 ("test/compress: add cycle-count mode to perf tool")
Fixes: 971d89f5116b ("app/compress-perf: prevent output buffer overflow")
Cc: tomaszx.jozw...@intel.com
Cc: arturx.tryb.
Add a command line option `algo` to select the compress algorithm
supported by the compress API: null (DMA), deflate, lz4 and lzs.
Default for deflate.
Signed-off-by: Matan Azrad
Signed-off-by: Michael Baum
---
app/test-compress-perf/comp_perf_options.h| 3 +
.../comp_perf_options_parse.c
> -Original Message-
> From: Akhil Goyal
> Sent: Thursday, February 2, 2023 11:49 AM
> To: Kinsella, Ray ; Kusztal, ArkadiuszX
> ; dev@dpdk.org
> Cc: tho...@monjalon.net; david.march...@redhat.com;
> hemant.agra...@nxp.com; Anoob Joseph ; De Lara
> Guarch, Pablo ; Trahe, Fiona
> ; Doherty
On 1/24/2023 10:47 AM, David Marchand wrote:
> Rather than have each forward engines deal with core cycles recording,
> move this to testpmd common code.
> fwd engines just need to report that they did some busy work.
>
> Signed-off-by: David Marchand
Reviewed-by: Ferruh Yigit
On 1/24/2023 10:47 AM, David Marchand wrote:
> "unprepared" packets could get to the wire in the retry loop.
>
> Split packets freeing in two stages: one for preparation failure, and
> one for transmission failure.
> Adjust dropped counter update accordingly.
>
> Fixes: 6b520d54ebfe ("app/testpmd
On 1/24/2023 10:47 AM, David Marchand wrote:
> Use the bulk free helper.
>
> Signed-off-by: David Marchand
Reviewed-by: Ferruh Yigit
On 1/24/2023 10:47 AM, David Marchand wrote:
> Reduce code duplication by introducing a helper that takes care of
> initialising the fs object.
>
> While at it, remove unneeded initialisation of fwd_engine empty fields.
>
> Signed-off-by: David Marchand
Reviewed-by: Ferruh Yigit
On 1/24/2023 10:47 AM, David Marchand wrote:
> Reduce code duplication by introducing a helper that takes care of
> receiving packets and incrementing rx counter.
>
> Signed-off-by: David Marchand
Reviewed-by: Ferruh Yigit
<...>
> @@ -857,6 +857,18 @@ inc_tx_burst_stats(struct fwd_stream *f
On 1/24/2023 10:47 AM, David Marchand wrote:
> Reduce code duplication by introducing a helper that takes care of
> transmitting, retrying if enabled and incrementing tx counter.
>
> Signed-off-by: David Marchand
<...>
> diff --git a/app/test-pmd/noisy_vnf.c b/app/test-pmd/noisy_vnf.c
> index 9
On 2/14/2023 11:03 AM, Singh, Aman Deep wrote:
>
> On 1/24/2023 4:17 PM, David Marchand wrote:
>> Reduce code duplication by introducing a helper that takes care of
>> transmitting, retrying if enabled and incrementing tx counter.
>>
>> Signed-off-by: David Marchand
<...>
>> diff --git a/app/te
On 1/25/2023 1:50 PM, Robin Jarry wrote:
> David Marchand, Jan 24, 2023 at 11:47:
>> Here is a series to reduce code duplication in testpmd.
>>
>> This work started from looking at Robin series on reporting lcore busy
>> cycles in telemetry, which is then added in testpmd [1]. While looking
>> at t
On 2/14/2023 1:41 PM, Andrew Rybchenko wrote:
> On 2/14/23 16:06, Ivan Malov wrote:
>> When the action parsing helper discovers it can "attach" to
>> an existing action set, it must invoke "delete" on the MAC
>> address(es) that it has "attached" to during parsing. That
>> is because the action set
This patchset removes the main uses of static LOGTYPE's in DPDK
libraries. It starts with the easy one and goes on to the more complex ones.
Note: there is one patch in this series that will get
flagged incorrectly as an ABI change.
v6 - fix typo in kni port
v5 - fix use of LOGTYPE PORT and POW
If a large packet is passed into GSO routines of unknown protocol
then library would log a message.
Better to tell the application instead of logging.
Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO")
Cc: jiayu...@intel.com
Signed-off-by: Stephen Hemminger
---
lib/gso/rte_gso.c | 5 ++---
1 file
The message that used this was replaced in previous patch.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common
The timer code does not use rte_log.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c
index 894701e8c
Replace all uses of the global logtype with a dynamic log type.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/efd/rte_efd.c | 3 +++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/eal/comm
Introduce a new dynamic logtype for mbuf related messages.
Since this is used in multiple files put one macro in mbuf_log.h
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/mbuf/mbuf_log.h | 4
lib/mbuf/rte_m
Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC.
For ACL library use a dynamic type.
The one message using RTE_LOGTYPE_MALLOC should have been
under the ACL logtype anyway.
The test code should not have been using fixed log type
so just change that to stderr.
Signed-off-by: Stephen Hemminger
-
Don't use static static logtype in sample application.
Signed-off-by: Stephen Hemminger
---
examples/distributor/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/distributor/main.c b/examples/distributor/main.c
index 21304d661873..542f76cf9664 100644
--- a/exam
Convert to using a dynamic logtype for the application.
Signed-off-by: Stephen Hemminger
---
examples/l3fwd-power/main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index caf26b373e8d..8e094c1bdda5
Use dynamic log type for power library.
Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h| 2 +-
lib/power/guest_channel.c| 3 ++-
lib/power/power_common.c | 2
The logtype for ring only used in library.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/ring/rte_ring.c | 3 +++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_log.c b
Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/mempool/rte_mempool.c | 3 +++
lib/mempool/rte_mempool_log.h | 4
lib/mempool/rte_mempool_ops.c | 1 +
5 fil
Even though KNI will eventually disappear, fix the
logtype now.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/kni/rte_kni.c | 3 +++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/eal/comm
Also can remove unused RTE_LOGTYPE_METER
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 2 --
lib/eal/include/rte_log.h | 4 ++--
lib/sched/rte_pie.c | 1 +
lib/sched/rte_sched.c | 5 +
lib/sched/rte_sched_log.h | 4
5 files chan
Split lpm and lpm6 into separate log types since they
are in different files and user may want to change log
levels for IPv4 vs IPv6.
For rib and fib libraries give them own types as well.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h
Looks like some code got copy/paste in to the IPSEC gateway
example from another place. Shouldn't be using RTE_LOGTYPE_PORT
here.
Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload")
Cc: akhil.go...@nxp.com
Signed-off-by: Stephen Hemminger
---
examples/ipsec-secgw/sa.c | 6 +++-
Split up the single static RTE_LOGTYPE_PORT into separate
sub types for each component: port.ethdev, port.evendev, ...
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/port/rte_port_ethdev.c | 3 +++
lib/port/rte_port_ev
Use logtype suffixes for various components of this library.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/table/rte_table_acl.c | 3 +++
lib/table/rte_table_array.c | 3 +++
lib/table/rte_table_hash_cuck
Instead of using static type PIPELINE for logging in test application
use stderr instead. If not testing RTE_LOG() better to not use
it since log also goes to syslog.
Signed-off-by: Stephen Hemminger
---
app/test/test_table_acl.c | 50 --
app/test/test_table
Use a dynamically allocated logtype.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/pipeline/rte_pipeline.c | 3 +++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_log.c b/lib/e
Having stubs in header file makes it harder to update
RTE_LOG(). Also modify to only print warning once.
Signed-off-by: Stephen Hemminger
---
lib/hash/meson.build | 8 +++-
lib/hash/rte_thash_gfni.c | 43 +++
lib/hash/rte_thash_gfni.h | 28 +-
The code for setting algorithm for hash is not at all perf sensitive,
and doing it inline has a couple of problems. First, it means that if
multiple files include the header, then the initialization gets done
multiple times. But also, it makes it harder to fix usage of RTE_LOG().
Despite what the
Use dynamic type for hash and add subtypes for crc and gfni.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_log.c | 1 -
lib/eal/include/rte_log.h | 2 +-
lib/hash/rte_cuckoo_hash.c | 5 +
lib/hash/rte_fbk_hash.c | 3 +++
lib/hash/rte_hash_crc.c | 3
10/02/2023 02:48, Jie Hai пишет:
This patch supports dump of ring information by its name.
An example using this command is shown below:
--> /ring/info,MP_mb_pool_0
{
"/ring/info": {
"name": "MP_mb_pool_0",
"socket": 0,
"flags": "0x0",
"producer_type": "MP",
"consumer
Sorry late to see.
On 2023/1/17 1:37, Bruce Richardson wrote:
> The DMA device stop API can return an error value so check that return
> value when running dmadev unit tests.
>
> Signed-off-by: Bruce Richardson
> ---
> app/test/test_dmadev.c | 6 +-
> 1 file changed, 5 insertions(+), 1 dele
On 2023/1/17 1:37, Bruce Richardson wrote:
> The copy tests for dmadev had separate blocks in the test function for
> single copy and burst copies. Separate out the single-copy block to its
> own function so that it can be re-used if necessary.
>
> Signed-off-by: Bruce Richardson
Acked-by: Cheng
On 2023/1/17 1:37, Bruce Richardson wrote:
> Validate device operation when a device is stopped or restarted.
>
> The only complication - and gap in the dmadev ABI specification - is
> what happens to the job ids on restart. Some drivers reset them to 0,
> while others continue where things left o
When round up buffer size to 1K, to configure the register, hardware will
receive packets exceeding the buffer size in LRO mode. It will cause a
segment fault in the receive function.
Fixes: be797cbf4582 ("net/txgbe: add Rx and Tx init")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/
LGTM
Series-acked-by: Chengwen Feng
On 2023/2/10 10:48, Jie Hai wrote:
> This patch set supports telemetry cmd to list rings and dump information
> of a ring by its name.
>
> v1->v2:
> 1. Add space after "switch".
> 2. Fix wrong strlen parameter.
>
> v2->v3:
> 1. Remove prefix "rte_" for static
1 - 100 of 107 matches
Mail list logo
