On 1/25/2023 1:50 PM, Robin Jarry wrote:
> David Marchand, Jan 24, 2023 at 11:47:
>> Here is a series to reduce code duplication in testpmd.
>>
>> This work started from looking at Robin series on reporting lcore busy
>> cycles in telemetry, which is then added in testpmd [1]. While looking
>> at the forward engines code, I saw way too much duplicated code.
>>
>> Warning: this is only compile tested.
>>
>> 1:
>> https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/
>
> Hi David,
>
> The code looks good to me. I have made some basic testing, it seems not
> to break obvious things.
>
> Reviewed-by: Robin Jarry <[email protected]>
>
Hi Robin,
This set conflicts with your set which is merged [1], I guess your test
was before your patch merged. Can you please check again after rebase?
[1]
Commit 99a4974aa569 ("app/testpmd: report lcore usage")
