Re: [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 9:51 AM wrote: > > From: Satheesh Paul > > Fix channel mask of SDP interfaces on CN10K. > > Fixes: f137566333 ("common/cnxk: support setting channel mask for SDP > interfaces") > Cc: sta...@dpdk.org > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar K Please r

[PATCH v5 2/3] app/testpmd: add skip cman support for testpmd

2023-02-10 Thread Rakesh Kudurumalla
added support for testpmd application to accept skip_cman action while configuring policy action Signed-off-by: Rakesh Kudurumalla --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498

[PATCH v5 3/3] net/cnxk: skip red drop for ingress policer

2023-02-10 Thread Rakesh Kudurumalla
Dropping of packets is based on action configured to meter.If both skip_red and drop actions are configured then tail dropping in invoked else if only drop action is configured then RED drop is invoked.This action is supported only when RED is configured using rte_eth_cman_config_set() Signed-off-

[PATCH v5 1/3] ethdev: skip congestion management configuration

2023-02-10 Thread Rakesh Kudurumalla
Introduce new flow action to skip congestion management configuration This feature helps to skip the congestion management processing based on per flow or the packet color identified by rte_flow meter object. For example, If one Rx queue configured as RED congestion and application wants tobypass t

Re: [PATCH v5 1/3] ethdev: skip congestion management configuration

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 1:44 PM Rakesh Kudurumalla wrote: > > Introduce new flow action to skip congestion management configuration > This feature helps to skip the congestion management processing > based on per flow or the packet color identified by > rte_flow meter object. For example, If one R

Re: [PATCH v1 1/9] baseband/acc: protection for TB negative scenario

2023-02-10 Thread Maxime Coquelin
On 2/9/23 23:19, Nicolas Chautru wrote: Adding handling of negative scenario for malformed Transport Block mode operations. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 20 +++

[RFC] usertools: enhance CPU layout

2023-02-10 Thread Wenzhuo Lu
CPU is becoming more and more complex. Some CPUs are made up of several dies. The cores in different dies may be different. The user tool can be updated to show more about CPU components. This patch addes below informantion, 1, Group the cores based on the die. 2, A core is either a performance co

[dpdk-dev] [PATCH v2 1/3] common/cnxk: fix channel mask for SDP interfaces

2023-02-10 Thread psatheesh
From: Satheesh Paul Fix channel mask of SDP interfaces on CN10K. Fixes: f1375660 ("common/cnxk: support setting channel mask for SDP interfaces") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- v2: * Corrected "Fixes:" tag with 12 char sha1 drivers/commo

[dpdk-dev] [PATCH v2 2/3] common/cnxk: fix printing IPsec flow rules

2023-02-10 Thread psatheesh
From: Satheesh Paul When dumping flow data, dump preallocated IPsec rules also. Fixes: 1aa86a170e27 ("drivers: support IPsec rule reservation scheme") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Jerin Jacob Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc.c

[PATCH v6 1/3] ethdev: skip congestion management configuration

2023-02-10 Thread Rakesh Kudurumalla
Introduce new flow action to skip congestion management configuration This feature helps to skip the congestion management processing based on per flow or the packet color identified by rte_flow meter object. For example, If one Rx queue configured as RED congestion and application wants tobypass t

[dpdk-dev] [PATCH v2 3/3] common/cnxk: fix inline IPsec rule creation

2023-02-10 Thread psatheesh
From: Satheesh Paul Use inline IPsec device to create IPsec rules irrespective of RTE_ETH_RX_OFFLOAD_SECURITY offload flag. Fixes: 1aa86a170e27 ("drivers: support IPsec rule reservation scheme") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Nithin Dabilpuram Reviewed-by: Kiran

[PATCH v6 2/3] app/testpmd: add skip cman support for testpmd

2023-02-10 Thread Rakesh Kudurumalla
added support for testpmd application to accept skip_cman action while configuring policy action Signed-off-by: Rakesh Kudurumalla --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498

[PATCH v6 3/3] net/cnxk: skip red drop for ingress policer

2023-02-10 Thread Rakesh Kudurumalla
Dropping of packets is based on action configured to meter.If both skip_red and drop actions are configured then tail dropping in invoked else if only drop action is configured then RED drop is invoked.This action is supported only when RED is configured using rte_eth_cman_config_set() Signed-off-

Re: [PATCH v1 2/9] baseband/acc: add support for 4GUL with SO and TB

2023-02-10 Thread Maxime Coquelin
On 2/9/23 23:19, Nicolas Chautru wrote: Implementation to support the case when using LTE decoder with soft output and transport block mode. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Cc: sta...@dpdk.org Should it really be a fix and be backported? It looks like a new featur

Re: [PATCH v1 3/9] baseband/acc: remove interrupt support on VRB1

2023-02-10 Thread Maxime Coquelin
On 2/9/23 23:19, Nicolas Chautru wrote: Not enabling interrupt in VRB1 PMD variant to avoid potential corner case. Fixes: 3cabc8eaf524 ("baseband/acc200: support interrupt") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 8 1 file cha

Re: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-10 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/2/9 22:58, Morten Brørup wrote: > Zero-copy access to mempool caches is beneficial for PMD performance, and > must be provided by the mempool library to fix [Bug 1052] without a > performance regression. > > [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052 >

Re: [PATCH v1 4/9] baseband/acc: add explicit mbuf apend for soft output

2023-02-10 Thread Maxime Coquelin
On 2/9/23 23:19, Nicolas Chautru wrote: Adding an explicit mbuf append in the case of soft output mbuf being provided. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 4 1 file c

RE: [PATCH v7 3/4] net/mlx5: fix warning about rte_memcpy length

2023-02-10 Thread Slava Ovsiienko
> -Original Message- > From: Morten Brørup > Sent: Thursday, February 9, 2023 6:54 PM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Xueming(Steven) Li > Cc: ruifeng.w...@arm.com; zhou...@loongson.cn; d...@linux.vnet.ibm.com; > k...@semihalf.com; bruce.richard...@intel.com; > konst

Re: [PATCH v6 1/3] ethdev: skip congestion management configuration

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 1:56 PM Rakesh Kudurumalla wrote: > > Introduce new flow action to skip congestion management configuration > This feature helps to skip the congestion management processing > based on per flow or the packet color identified by > rte_flow meter object. For example, If one R

Re: [PATCH v2] bus: fix leak for devices without driver

2023-02-10 Thread Kevin Laatz
On 09/02/2023 13:22, Volodymyr Fialko wrote: During the bus scan, memory for device configuration is allocated. Currently, if a driver wasn't attached to the device during initialization, memory for that device will not be released at bus cleanup. This patch address this issue and releases the me

Re: [PATCH] net/octeon_ep: support SDP packet mode

2023-02-10 Thread Jerin Jacob
On Thu, Feb 9, 2023 at 6:01 PM Sathesh Edara wrote: > > Add SDP packet mode to support EP driver in loop > and NIC mode. > > Signed-off-by: Sathesh Edara > --- > +/* These arrays indexed by otx_ep_device->sdp_packet_mode */ > +static uint8_t front_size[2] = {OTX2_EP_FSZ_NIC, OTX2_EP_FSZ_LOOP}; >

Re: [PATCH v1 5/9] baseband/acc: prevent to dequeue more than requested

2023-02-10 Thread Maxime Coquelin
On 2/9/23 23:19, Nicolas Chautru wrote: Add support for corner-case when more operations are requested than expected, in the case of encoder muxing operations. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseb

Re: [PATCH v1 6/9] baseband/acc: fix iteration counter in TB mode

2023-02-10 Thread Maxime Coquelin
On 2/9/23 23:19, Nicolas Chautru wrote: The iteration count was not using correct structure (4G vs 5G) in TB mode. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 10 +++--- 1 file

Re: [PATCH v1 7/9] baseband/acc: fix potential arithmetic overflow Fix potential issue of overflow causing coverity warning.

2023-02-10 Thread Maxime Coquelin
There seems to be formatting issue of the commit log, the commit message is appended to the title. On 2/9/23 23:19, Nicolas Chautru wrote: Coverity issue: 383154 Fixes: 8e16839937 ("baseband/acc: extension of the device structure") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- dr

Re: [PATCH v1 8/9] baseband/acc: add support for 4GUL CRC drop in VRB PMD

2023-02-10 Thread Maxime Coquelin
On 2/9/23 23:19, Nicolas Chautru wrote: Adding support for the capability to drop the CRC24B when using the turbo-decoder. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/ac

Re: [PATCH v1 9/9] baseband/acc: remove printf from PMD function

2023-02-10 Thread Maxime Coquelin
On 2/9/23 23:19, Nicolas Chautru wrote: Replacing usage of printf in companion function for bbdev-test by rte_log. I think it could be backported. If you agree please add Fixes tag and Cc stable. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_acc100_pmd.c | 18 +

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-10 Thread lihuisong (C)
在 2023/2/9 20:45, Ferruh Yigit 写道: On 2/4/2023 2:57 AM, lihuisong (C) wrote: 在 2023/2/3 20:58, Ferruh Yigit 写道: On 2/3/2023 1:56 AM, lihuisong (C) wrote: 在 2023/2/3 5:10, Thomas Monjalon 写道: 02/02/2023 19:09, Ferruh Yigit: On 2/2/2023 12:36 PM, Huisong Li wrote: The dev->data->mac_addrs[0

Re: [PATCH v3 4/5] vhost: use logtype instead of RTE_LOGTYPE_USER1

2023-02-10 Thread Maxime Coquelin
On 2/10/23 01:22, Stephen Hemminger wrote: Fix instances of USER1 logtype in fdset and crypto sections. Acked-by: Chenbo Xia Signed-off-by: Stephen Hemminger --- lib/vhost/fd_man.c | 16 +--- lib/vhost/vhost_crypto.c | 25 +++-- 2 files changed, 20

[PATCH v2 0/5] remove internal tracepoints from version map

2023-02-10 Thread Ankur Dwivedi
The internal tracepoints of a library are not needed to be exported in version.map file, as they will not be called from outside the library. The fast path tracepoints which are called from outside the library needs to be exported in version.map. This patch removes the internal tracepoints from ver

[PATCH v2 2/5] cryptodev: remove internal tracepoints from version map

2023-02-10 Thread Ankur Dwivedi
The file rte_cryptodev_trace.h contains tracepoints which are internal to the cryptodev library. This file is renamed to cryptodev_trace.h, and is made an internal header. The tracepoints in this file are removed from the experimental and internal section in version.map file. Signed-off-by: Ankur

[PATCH v2 1/5] mempool: remove internal tracepoints from version map

2023-02-10 Thread Ankur Dwivedi
The file rte_mempool_trace.h contains tracepoints which are internal to the mempool library. This file is renamed to mempool_trace.h, and is made an internal header. The tracepoints in this file are removed from the experimental section in version.map file. Signed-off-by: Ankur Dwivedi --- .../{

[PATCH v2 3/5] eal: remove internal tracepoints from version map

2023-02-10 Thread Ankur Dwivedi
The file rte_eal_trace.h contains some tracepoints which are internal to the eal library. Those tracepoints are moved to a new file eal_trace_internal.h. The internal tracepoints are removed from the version.map file. Signed-off-by: Ankur Dwivedi --- doc/guides/prog_guide/trace_lib.rst | 1

[PATCH v2 4/5] ethdev: remove internal tracepoints from version map

2023-02-10 Thread Ankur Dwivedi
The internal tracepoints are removed from the version.map file. Signed-off-by: Ankur Dwivedi Acked-by: Ferruh Yigit --- lib/ethdev/version.map | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index 17201fbe0f..d8e9941356 100644 --- a/lib/e

[PATCH v2 5/5] eventdev: remove internal tracepoints from version map

2023-02-10 Thread Ankur Dwivedi
The internal tracepoints are removed from the version.map file. Signed-off-by: Ankur Dwivedi --- lib/eventdev/version.map | 30 -- 1 file changed, 30 deletions(-) diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map index 3add5e3088..9153c09b42 100644 ---

Re: [PATCH v4 1/1] eal/linux: reject mountpt not parent of --huge-dir

2023-02-10 Thread David Marchand
On Mon, Jan 9, 2023 at 2:52 AM Ashish Sadanandan wrote: > > The code added for allowing --huge-dir to specify hugetlbfs > sub-directories has a bug where it incorrectly matches mounts that > contain a prefix of the specified --huge-dir. > > Consider --huge-dir=/dev/hugepages1G is passed to rte_eal

Re: [PATCH v4 1/1] eal/linux: reject mountpt not parent of --huge-dir

2023-02-10 Thread David Marchand
On Mon, Jan 16, 2023 at 7:26 PM Ashish Sadanandan wrote: > On Wed, Jan 11, 2023 at 5:11 AM John Levon wrote: >> On Sun, Jan 08, 2023 at 06:52:39PM -0700, Ashish Sadanandan wrote: >> >> > The code added for allowing --huge-dir to specify hugetlbfs >> > sub-directories has a bug where it incorrectl

Re: [PATCH] examples/cmdline: fix build error with gcc 12

2023-02-10 Thread Olivier Matz
Hi, Sorry for the late reply. On Thu, Jan 19, 2023 at 08:59:10AM +, Bruce Richardson wrote: > On Wed, Jan 18, 2023 at 06:53:33PM +, Ferruh Yigit wrote: > > On 1/18/2023 4:11 PM, Bruce Richardson wrote: > > > When building the example without libbsd and using the DPDK-provided > > > strlcp

Re: [PATCH] eal: have unregistered non-EAL threads use dedicated PRNG

2023-02-10 Thread David Marchand
On Mon, Dec 5, 2022 at 11:08 AM Mattias Rönnblom wrote: > > Prior to this change, unregistered non-EAL threads shared a PRNG > instance with the main lcore. The main lcore may well be used for fast > path processing, potentially making rte_rand() calls in the > process. It should not need to synch

Re: [PATCH v2] bus: fix leak for devices without driver

2023-02-10 Thread David Marchand
On Fri, Feb 10, 2023 at 10:29 AM Kevin Laatz wrote: > > On 09/02/2023 13:22, Volodymyr Fialko wrote: > > During the bus scan, memory for device configuration is allocated. > > Currently, if a driver wasn't attached to the device during initialization, > > memory for that device will not be release

Re: [PATCH] ethdev: telemetry xstats support hide zero

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 1:23 AM, fengchengwen wrote: > On 2023/2/10 7:30, Ferruh Yigit wrote: >> On 2/9/2023 3:07 AM, Chengwen Feng wrote: >>> The number of xstats may be large, after the hide zero option is added, >>> only non-zero values can be displayed. >>> >> >> Hi Chengwen, >> >> No objection on the fun

Re: [PATCH] test/mbuf: fix mbuf_autotest retest fail

2023-02-10 Thread David Marchand
On Tue, Feb 7, 2023 at 2:21 PM David Marchand wrote: > On Tue, Jan 31, 2023 at 3:52 AM Jie Hai wrote: > > > > Retest "mbuf_autotest" will fail because the mbuf pool was > > not freed after previous test successful done. > > This patch fixes it. > > > > Fixes: efc6f9104c80 ("mbuf: fix reset on mbu

Re: [PATCH v7 3/3] examples/l3fwd-graph: changes to configure pcap capture

2023-02-10 Thread David Marchand
On Thu, Feb 9, 2023 at 6:28 PM Jerin Jacob wrote: > > On Thu, Feb 9, 2023 at 3:54 PM Amit Prakash Shukla > wrote: > > > > Added support to configure pcap capture. > > > > Signed-off-by: Amit Prakash Shukla > Acked-by: Jerin Jacob Series applied, thanks. -- David Marchand

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 9:54 AM, lihuisong (C) wrote: > > 在 2023/2/9 20:45, Ferruh Yigit 写道: >> On 2/4/2023 2:57 AM, lihuisong (C) wrote: >>> 在 2023/2/3 20:58, Ferruh Yigit 写道: On 2/3/2023 1:56 AM, lihuisong (C) wrote: > 在 2023/2/3 5:10, Thomas Monjalon 写道: >> 02/02/2023 19:09, Ferruh Yigit: >>>

Re: [PATCH v4] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-10 Thread Ferruh Yigit
On 2/9/2023 12:05 PM, Shibin Koikkara Reeny wrote: > Integrate support for the AF_XDP CNI and device plugin [1] so that the > DPDK AF_XDP PMD can work in an unprivileged container environment. > Part of the AF_XDP PMD initialization process involves loading > an eBPF program onto the given netdev.

[PATCH 1/2] net/gve: change offloading capability

2023-02-10 Thread Levend Sayar
Google Virtual NIC is not doing IPv4 checksummimg. Removed that capability from PMD. Signed-off-by: Levend Sayar --- drivers/net/gve/gve_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index 97781f0ed3..e357f16e16 100644 ---

[PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Levend Sayar
Google Virtual NIC PMD is enriched with statistics info. Signed-off-by: Levend Sayar --- drivers/net/gve/gve_ethdev.c | 147 ++- drivers/net/gve/gve_ethdev.h | 11 +++ drivers/net/gve/gve_rx.c | 18 - drivers/net/gve/gve_tx.c | 6 ++ 4 files change

Re: [PATCH v2 5/5] eventdev: remove internal tracepoints from version map

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 4:05 PM Ankur Dwivedi wrote: > > The internal tracepoints are removed from the version.map file. > > Signed-off-by: Ankur Dwivedi >From Trace change PoV, Series-Acked-by: Jerin Jacob > --- > lib/eventdev/version.map | 30 -- > 1 file change

Re: [PATCH] lib/net: support UDP pseudo-header for UFO

2023-02-10 Thread Olivier Matz
Hello Zhichao, Sorry for the delayed response. On Thu, Jan 12, 2023 at 05:26:08PM +0800, Zhichao Zeng wrote: > Add UDP pseudo-header processing for UDP segmentation offload > by adding the UDP_SEG flag. > > Signed-off-by: Zhichao Zeng > --- > lib/net/rte_ip.h | 2 +- > 1 file changed, 1 insert

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-10 Thread lihuisong (C)
在 2023/2/10 20:27, Ferruh Yigit 写道: On 2/10/2023 9:54 AM, lihuisong (C) wrote: 在 2023/2/9 20:45, Ferruh Yigit 写道: On 2/4/2023 2:57 AM, lihuisong (C) wrote: 在 2023/2/3 20:58, Ferruh Yigit 写道: On 2/3/2023 1:56 AM, lihuisong (C) wrote: 在 2023/2/3 5:10, Thomas Monjalon 写道: 02/02/2023 19:09, F

Re: [PATCH v10 0/5] lcore telemetry improvements

2023-02-10 Thread David Marchand
Hello Robin, On Thu, Feb 9, 2023 at 10:45 AM Robin Jarry wrote: > > This is a follow up on previous work by Kevin Laatz: > > http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* > > This series is aimed at allowing DPDK applications to expose their CPU > usage stats in the DPDK telemet

[PATCH v5 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter configuration parameters defined in the struct rte_event_eth_rx_adapter_runtime_params can be configured and retrieved using rte_event_eth_rx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test/test_ev

[PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_eth_tx_adapter_runtime_params can be configured and retrieved using rte_event_eth_tx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test

[PATCH v5 3/3] eventdev/crypto: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_crypto_adapter_runtime_params can be configured and retrieved using rte_event_crypto_adapter_runtime_params_set and rte_event_eth_rx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test

Re: [PATCH v4] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-10 Thread Ferruh Yigit
On 2/9/2023 12:05 PM, Shibin Koikkara Reeny wrote: > Integrate support for the AF_XDP CNI and device plugin [1] so that the > DPDK AF_XDP PMD can work in an unprivileged container environment. > Part of the AF_XDP PMD initialization process involves loading > an eBPF program onto the given netdev.

[PATCH v5 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter configuration parameters defined in the struct rte_event_eth_rx_adapter_runtime_params can be configured and retrieved using rte_event_eth_rx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test/test_ev

[PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_eth_tx_adapter_runtime_params can be configured and retrieved using rte_event_eth_tx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test

[PATCH v5 3/3] eventdev/crypto: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_crypto_adapter_runtime_params can be configured and retrieved using rte_event_crypto_adapter_runtime_params_set and rte_event_eth_rx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test

Re: [PATCH v5 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 7:03 PM Naga Harish K S V wrote: > > The adapter configuration parameters defined in the > struct rte_event_eth_rx_adapter_runtime_params can be configured > and retrieved using rte_event_eth_rx_adapter_runtime_params_set and rte_event_eth_rx_adapter_runtime_params_set()

Re: [PATCH v1 13/13] test/bbdev: remove iteration count check

2023-02-10 Thread Maxime Coquelin
Hi Nicolas, On 2/9/23 17:59, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Thursday, February 9, 2023 1:11 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v1 13/13] test/bbd

Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 7:17 PM Naga Harish K S V wrote: > > The adapter runtime configuration parameters defined in the > struct rte_event_eth_tx_adapter_runtime_params can be > configured and retrieved using > rte_event_eth_tx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_param

RE: [PATCH v4 1/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-10 Thread Jiawei(Jonny) Wang
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Friday, February 10, 2023 3:45 AM > To: Jiawei(Jonny) Wang ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; > andrew.rybche...@oktetlabs.ru; Aman Singh ; > Yuying Zhang > Cc: dev@dpdk.org; Raslan Darawsheh

Re: [PATCH v2 4/5] ethdev: remove internal tracepoints from version map

2023-02-10 Thread David Marchand
On Fri, Feb 10, 2023 at 11:35 AM Ankur Dwivedi wrote: > > The internal tracepoints are removed from the version.map file. > > Signed-off-by: Ankur Dwivedi > Acked-by: Ferruh Yigit rte_ethdev_trace.h does not need to be exported. I suggest the following addition: diff --git a/lib/ethdev/rte_et

Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

2023-02-10 Thread David Marchand
On Fri, Feb 10, 2023 at 8:06 AM Jerin Jacob wrote: > > On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi wrote: > > > > >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi > > >wrote: > > >> > > >> The file rte_mempool_trace.h contains tracepoints which are internal > > >> to the mempool library. This fi

Re: [PATCH v2 1/9] ethdev: sharing indirect actions between ports

2023-02-10 Thread Ferruh Yigit
On 2/7/2023 2:01 PM, Viacheslav Ovsiienko wrote: > The RTE Flow API implements the concept of shared objects, > known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). > An application can create the indirect action of desired > type and configuration with rte_flow_action_handle_create > call an

Re: [PATCH v2 9/9] doc: update cross-port indirect shared action

2023-02-10 Thread Ferruh Yigit
On 2/7/2023 2:02 PM, Viacheslav Ovsiienko wrote: > The patch updates the Release Notes and documentation > for the indirect RTE Flow actions as shared ones between > ports on the same physical NIC. > > Signed-off-by: Viacheslav Ovsiienko > --- > doc/guides/rel_notes/release_23_03.rst | 6 ++

RE: [PATCH v2 1/9] ethdev: sharing indirect actions between ports

2023-02-10 Thread Slava Ovsiienko
Hi, Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Friday, February 10, 2023 4:35 PM > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Ori Kam ; Raslan Darawsheh ; > Matan Azrad ; arybche...@solarflare.com > Subject: Re: [PATCH v2 1/9] ethdev: sharing indirect actions between ports >

Re: [dpdk-dev] [RFC] ethdev: improve link speed to string

2023-02-10 Thread Ferruh Yigit
On 1/19/2023 4:45 PM, Stephen Hemminger wrote: > On Thu, 19 Jan 2023 11:41:12 + > Ferruh Yigit wrote: > >> Nothing good will happen if you try to use the function to >> print two different link speeds in one log message. > You are right. > And use malloc for "name" will resu

Re: [RFC PATCH 0/1] Specify C-standard requirement for DPDK builds

2023-02-10 Thread Ben Magistro
Adding Tyler Sort of following along on the RFC: introduce atomics [1] it seems like the decision to use 99 vs 11 here could make an impact on the approach taken in that thread. 1) http://mails.dpdk.org/archives/dev/2023-February/262042.html On Fri, Feb 3, 2023 at 1:00 PM Bruce Richardson wrote

RE: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Friday, February 10, 2023 7:36 PM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; > Jayatheerthan, Jay > Subject: Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs >

[PATCH] net/virtio-user: fix number of vrings calculation

2023-02-10 Thread Maxime Coquelin
When moving to dynamic allocation of vrings metadata, the number of vrings to allocate was incremented if the backend supports control queue. The problem is that the control queue metadata have to be allocated even if the backend does not use it directly, since the control queue is managed by the

[PATCH v3 1/3] ethdev: sharing indirect actions between ports

2023-02-10 Thread Viacheslav Ovsiienko
The RTE Flow API implements the concept of shared objects, known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). An application can create the indirect action of desired type and configuration with rte_flow_action_handle_create call and then specify the obtained action handle in multiple flows

[PATCH v3 0/3] *ethdev: sharing indirect actions between port*

2023-02-10 Thread Viacheslav Ovsiienko
The RTE Flow API implements the concept of shared objects, known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). An application can create the indirect action of desired type and configuration with rte_flow_action_handle_create call and then specify the obtained action handle in multiple flows

[PATCH v3 3/3] app/testpmd: add shared indirect action support

2023-02-10 Thread Viacheslav Ovsiienko
The shared indirect action can be shared between ports, action should be created on single port and the handle can be used in the templates and flows on multiple ports, example: flow configure 0 queues_number 1 queues_size 64 counters_number 64 flow configure 1 queues_number 1 queues_size 64 c

[PATCH v3 2/3] app/testpmd: add host port parameter into flow config

2023-02-10 Thread Viacheslav Ovsiienko
Host port id parameter is added to "flow configure" command. Signed-off-by: Viacheslav Ovsiienko Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 3b846ae73f..77788289

RE: [PATCH v2 1/2] net/i40e: replace put function

2023-02-10 Thread Honnappa Nagarahalli
[ > > > From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > > Sent: Friday, 10 February 2023 07.54 > > > > Integrated zero-copy put API in mempool cache in i40e PMD. > > On Ampere Altra server, l3fwd single core's performance improves by 5% > > with the new API > > > > Signed-off

Re: [PATCH] net/virtio-user: fix number of vrings calculation

2023-02-10 Thread David Marchand
On Fri, Feb 10, 2023 at 4:10 PM Maxime Coquelin wrote: > > When moving to dynamic allocation of vrings metadata, the > number of vrings to allocate was incremented if the backend > supports control queue. > > The problem is that the control queue metadata have to be > allocated even if the backend

Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 8:32 PM Naga Harish K, S V wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Friday, February 10, 2023 7:36 PM > > To: Naga Harish K, S V > > Cc: jer...@marvell.com; Carrillo, Erik G ; > > Gujjar, > > Abhinandan S ; dev@dpdk.org; > > Jayatheerth

Re: [PATCH] net/virtio-user: fix number of vrings calculation

2023-02-10 Thread Maxime Coquelin
On 2/10/23 16:10, Maxime Coquelin wrote: When moving to dynamic allocation of vrings metadata, the number of vrings to allocate was incremented if the backend supports control queue. The problem is that the control queue metadata have to be allocated even if the backend does not use it direct

Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 7:54 PM David Marchand wrote: > > On Fri, Feb 10, 2023 at 8:06 AM Jerin Jacob wrote: > > > > On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi wrote: > > > > > > >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi > > > >wrote: > > > >> > > > >> The file rte_mempool_trace.h conta

RE: [PATCH v4] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-10 Thread Koikkara Reeny, Shibin
> -Original Message- > From: Ferruh Yigit > Sent: Friday, February 10, 2023 1:04 PM > To: Koikkara Reeny, Shibin ; > dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly > ; Richardson, Bruce > ; Mcnamara, John > > Cc: Loftus, Ciara > Subject: Re: [PATCH v4] net/af_xdp: AF_XDP PMD CNI Integrat

[PATCH v5] net/af_xdp: support CNI Integration

2023-02-10 Thread Shibin Koikkara Reeny
Integrate support for the AF_XDP CNI and device plugin [1] so that the DPDK AF_XDP PMD can work in an unprivileged container environment. Part of the AF_XDP PMD initialization process involves loading an eBPF program onto the given netdev. This operation requires privileges, which prevents the PMD

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

2023-02-10 Thread David Marchand
Hello Mike, On Wed, Dec 7, 2022 at 5:54 PM Mike Pattrick wrote: > > Currently if an application wants to include shared hugepages in > coredumps in conjunction with the vhost library, the coredump will be > larger than expected and include unneeded virtual machine memory. > > This patch will mark

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

2023-02-10 Thread Maxime Coquelin
Thanks David for the report. On 2/10/23 16:53, David Marchand wrote: Hello Mike, On Wed, Dec 7, 2022 at 5:54 PM Mike Pattrick wrote: Currently if an application wants to include shared hugepages in coredumps in conjunction with the vhost library, the coredump will be larger than expected and

Re: [PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Stephen Hemminger
On Fri, 10 Feb 2023 16:06:06 +0300 Levend Sayar wrote: > +gve_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +{ > + uint16_t i; > + struct rte_eth_stats tmp; > + > + memset(&tmp, 0, sizeof(tmp)) Why do you need tmp? The stats pointer passed in is already available

DPDK Release Status Meeting 2023-02-09

2023-02-10 Thread Mcnamara, John
Release status meeting minutes 2023-02-09 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * Intel * Red Hat Release Dates - The following are the proposed current dates for 23.03: * V1: 25 D

[PATCH v4 0/5] Replace use of RTE_LOGTYPE_USER1 in library

2023-02-10 Thread Stephen Hemminger
The DPDK libraries and drivers should not be using the USER1 logtype. v4 - fix build compile error with debug enabled v3 - fix typo in ip_frag v2 - fix some compiler warnings Stephen Hemminger (5): ip_frag: use a dynamic logtype reorder: use a dynamic logtype latencystats: use dynamic logty

[PATCH v4 1/5] ip_frag: use a dynamic logtype

2023-02-10 Thread Stephen Hemminger
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in lieu of doing proper logtype registration. Acked-by: Konstantin Ananyev Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library") Signed-off-by: Stephen Hemminger --- lib/ip_frag/ip_frag_common.h | 16 ++- lib

[PATCH v4 2/5] reorder: use a dynamic logtype

2023-02-10 Thread Stephen Hemminger
Libraries should not be reusing RTE_LOGTYPE_USER1 instead of doing proper logtype registration. Fixes: b70b56032bff ("reorder: new library") Cc: sergio.gonzalez.mon...@intel.com Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 35 +++ 1 file change

[PATCH v4 3/5] latencystats: use dynamic logtype

2023-02-10 Thread Stephen Hemminger
Libraries should not reuse RTE_LOGTYPE_USER1 for their logging. Instead they should register their own type. Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats") Cc: reshma.pat...@intel.com Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 55

[PATCH v4 4/5] vhost: use logtype instead of RTE_LOGTYPE_USER1

2023-02-10 Thread Stephen Hemminger
Fix instances of USER1 logtype in fdset and crypto sections. Acked-by: Chenbo Xia Reviewed-by: Maxime Coquelin Signed-off-by: Stephen Hemminger --- lib/vhost/fd_man.c | 16 +--- lib/vhost/vhost_crypto.c | 25 +++-- 2 files changed, 20 insertions(+), 21 del

[PATCH v4 5/5] ipsec: fix usage of RTE_LOGTYPE_USER1

2023-02-10 Thread Stephen Hemminger
There already is a logtype in this driver, use it! Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler") Cc: kai...@intel.com Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

RE: [PATCH v1 04/13] test/bbdev: early termination not explicit set

2023-02-10 Thread Vargas, Hernan
Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, January 31, 2023 4:04 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v1 04/13] test/bbdev: early termination not explicit set On 1/17/23 17

Re: [PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Levend Sayar
Accessing a stack variable is faster. So copying to given stats pointer will be done at once. But of course, given stats pointer can also be used. > On 10 Feb 2023, at 19:34, Stephen Hemminger > wrote: > > On Fri, 10 Feb 2023 16:06:06 +0300 > Levend Sayar wrote: > >> +gve_stats_get(struct rt

RE: [PATCH v1 1/9] baseband/acc: protection for TB negative scenario

2023-02-10 Thread Chautru, Nicolas
Hi Maxime, Thanks, will do in v2. > -Original Message- > From: Maxime Coquelin > Sent: Friday, February 10, 2023 12:17 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: Vargas, Hernan ; sta...@dpdk.org > Subject: Re: [PATCH v1 1/9] baseband/acc: protection for TB negative scenario > > >

RE: [PATCH v1 2/9] baseband/acc: add support for 4GUL with SO and TB

2023-02-10 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, February 10, 2023 12:31 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: Vargas, Hernan ; sta...@dpdk.org > Subject: Re: [PATCH v1 2/9] baseband/acc: add support for 4GUL with SO and > TB > > > > On 2/9/23 23:19, Ni

RE: [PATCH v1 4/9] baseband/acc: add explicit mbuf apend for soft output

2023-02-10 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, February 10, 2023 12:41 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: Vargas, Hernan ; sta...@dpdk.org > Subject: Re: [PATCH v1 4/9] baseband/acc: add explicit mbuf apend for soft > output > > > > On 2/9/23 23:19

[PATCH v6 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_eth_rx_adapter_runtime_params can be configured and retrieved using rte_event_eth_rx_adapter_runtime_params_set() and rte_event_eth_tx_adapter_runtime_params_get() respectively. Signed-off-by: Naga Harish K S V --- v6: *

[PATCH v6 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_eth_tx_adapter_runtime_params can be configured and retrieved using rte_event_eth_tx_adapter_runtime_params_set() and rte_event_eth_tx_adapter_runtime_params_get() respectively. Signed-off-by: Naga Harish K S V --- v6: *

[PATCH v6 3/3] eventdev/crypto: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_crypto_adapter_runtime_params can be configured and retrieved using rte_event_crypto_adapter_runtime_params_set() and rte_event_eth_rx_adapter_runtime_params_get() respectively. Signed-off-by: Naga Harish K S V --- v6: *

Re: [PATCH v4 0/4] ethdev: add template table insertion and matching types

2023-02-10 Thread Ferruh Yigit
On 2/8/2023 3:06 AM, Alexander Kozyrev wrote: > Bring more flexibility and control over both flow rule insertion > and packet matching mechanisms. Introduce 2 new flow table types: > > 1. Allow a user to specify the insertion type used in template tables. > The insertion type is responsible for ch

  1   2   >