Re: [PATCH v1 4/9] baseband/acc: add explicit mbuf apend for soft output

[Maxime Coquelin]

On 2/9/23 23:19, Nicolas Chautru wrote:

Adding an explicit mbuf append in the case of soft output
mbuf being provided.

Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing")
Cc: sta...@dpdk.org

Signed-off-by: Nicolas Chautru <nicolas.chau...@intel.com>
---
  drivers/baseband/acc/rte_vrb_pmd.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/drivers/baseband/acc/rte_vrb_pmd.c 
b/drivers/baseband/acc/rte_vrb_pmd.c
index a111836e51..8540e3d31c 100644
--- a/drivers/baseband/acc/rte_vrb_pmd.c
+++ b/drivers/baseband/acc/rte_vrb_pmd.c
@@ -2067,6 +2067,10 @@ vrb_enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, 
struct rte_bbdev_dec_op *op,
                }
        }

+ if (op->ldpc_dec.soft_output.length > 0)

+               mbuf_append(op->ldpc_dec.soft_output.data, 
op->ldpc_dec.soft_output.data,
+                               op->ldpc_dec.soft_output.length);

No need to check the return value?
IOW, are we sure the buffer we try to append fits into the mbuf?

+
  #ifdef RTE_LIBRTE_BBDEV_DEBUG
        rte_memdump(stderr, "FCW", &desc->req.fcw_ld,
                        sizeof(desc->req.fcw_ld) - 8);