Re: [PATCH v1 6/6] doc: updated naming convention for acc200 PMD

2023-02-07 Thread David Marchand
Hello, On Tue, Jan 31, 2023 at 4:12 PM Maxime Coquelin wrote: > On 1/17/23 23:36, Nicolas Chautru wrote: > > The documentation for the Intel vRAN Boost PMD > > is being updated in term of filename and content > > to match with new branding and product name. > > > > Signed-off-by: Nicolas Chautru

[PATCH] doc: fix 22.11 release notes after acc200 driver rename

2023-02-07 Thread David Marchand
Renaming this driver and its associated doc was not properly handled with regard to the previous 22.11 release notes. Fixes: 5f1565617a9d ("doc: update naming for Intel baseband acc200") Signed-off-by: David Marchand --- doc/guides/rel_notes/release_22_11.rst | 4 ++-- 1 file changed, 2 inserti

Re: [PATCH v1 6/6] doc: updated naming convention for acc200 PMD

2023-02-07 Thread David Marchand
On Tue, Feb 7, 2023 at 9:00 AM David Marchand wrote: > > Hello, > > On Tue, Jan 31, 2023 at 4:12 PM Maxime Coquelin > wrote: > > On 1/17/23 23:36, Nicolas Chautru wrote: > > > The documentation for the Intel vRAN Boost PMD > > > is being updated in term of filename and content > > > to match with

RE: [PATCH] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

2023-02-07 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 6 February 2023 18.40 > > Introduce a new dynamic logtype for mbuf related messages. > Since this is used in multiple files put one macro in mbuf_log.h > > Signed-off-by: Stephen Hemminger > --- Acked-by: Morten Brøru

Re: [PATCH] doc: fix 22.11 release notes after acc200 driver rename

2023-02-07 Thread Maxime Coquelin
On 2/7/23 09:05, David Marchand wrote: Renaming this driver and its associated doc was not properly handled with regard to the previous 22.11 release notes. As discussed, ninja did not try again to build the release note after having fixed the initial issue. Forcing its rebuild I could repr

Re: [PATCH] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

2023-02-07 Thread David Marchand
On Mon, Feb 6, 2023 at 6:39 PM Stephen Hemminger wrote: > > Introduce a new dynamic logtype for mbuf related messages. > Since this is used in multiple files put one macro in mbuf_log.h > > Signed-off-by: Stephen Hemminger > --- > lib/mbuf/mbuf_log.h | 10 ++ > lib/mbuf/rte_mbuf

Re: [PATCH v2] net/i40e: support enabling/disabling source pruning

2023-02-07 Thread Thomas Monjalon
07/02/2023 02:40, Zhang, Ke1X: > From: Thomas Monjalon > > 31/01/2023 04:28, Zhang, Ke1X: > > > From: David Marchand > > > > On Mon, Jan 30, 2023 at 9:23 AM Ke Zhang > > wrote: > > > > > > > > > > VRRP advertisement packets are dropped on i40e PF devices because > > > > when > > > > > a MAC addr

Re: [PATCH] doc: fix 22.11 release notes after acc200 driver rename

2023-02-07 Thread David Marchand
On Tue, Feb 7, 2023 at 9:27 AM Maxime Coquelin wrote: > On 2/7/23 09:05, David Marchand wrote: > > Renaming this driver and its associated doc was not properly handled > > with regard to the previous 22.11 release notes. > > As discussed, ninja did not try again to build the release note after > h

[PATCH v11 0/1] Add support AVX512 split queue datapath

2023-02-07 Thread Wenjun Wu
This patchset enables AVX512 data path for split queue model. It is based on the below pathset 1. https://patches.dpdk.org/project/dpdk/list/?series=26809&state=* v3: fix logical error. v4: rebase to the new baseline. v5: fix compilation error. v6: remove unexpected changes. v7: rebase to the ne

[PATCH v11 1/1] common/idpf: add AVX512 data path for split queue model

2023-02-07 Thread Wenjun Wu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Reviewed-by: Wenjing Qiao Acked-by: Wenzhuo Lu --- drivers/common/idpf/idpf_common_rxtx.c| 22 +- drivers/common/idpf/idpf_common_rxtx.h| 21 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 799

Re: [PATCH] doc: fix 22.11 release notes after acc200 driver rename

2023-02-07 Thread David Marchand
On Tue, Feb 7, 2023 at 9:27 AM Maxime Coquelin wrote: > On 2/7/23 09:05, David Marchand wrote: > > Renaming this driver and its associated doc was not properly handled > > with regard to the previous 22.11 release notes. > > > Fixes: 5f1565617a9d ("doc: update naming for Intel baseband acc200") >

[PATCH] doc: rebuild all Sphinx guides

2023-02-07 Thread Thomas Monjalon
On some systems, Sphinx is lazy enough to not recompile an RST file, even if it contains a link pointing to a file which has been removed. In order to detect such broken links, the option "-a" is used to always rebuild all. Signed-off-by: Thomas Monjalon --- doc/guides/meson.build | 2 +- 1 fil

[PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL

2023-02-07 Thread Robin Jarry
The doc string was left to its previous definition. Make it explicit that RTE_TEL_INT_VAL is a 64-bit signed integer. Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API") Signed-off-by: Robin Jarry --- lib/telemetry/rte_telemetry.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH] doc: rebuild all Sphinx guides

2023-02-07 Thread David Marchand
On Tue, Feb 7, 2023 at 9:44 AM Thomas Monjalon wrote: > > On some systems, Sphinx is lazy enough to not recompile an RST file, > even if it contains a link pointing to a file which has been removed. > > In order to detect such broken links, > the option "-a" is used to always rebuild all. I can't

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-02-07 Thread Gupta, Nipun
[AMD Official Use Only - General] Hi David, I agree that change is not straightforward to review, but it should not cause any functional issue as we are still creating all the memory mappings, but one by one for each segment. For hot plug case this causes issue as mentioned, that VFIO does not

RE: [PATCH v2] net/iavf: add check for mbuf

2023-02-07 Thread Ye, MingjinX
Hi All, Could you please review and provide suggestions if any. Thanks, Mingjin > -Original Message- > From: Ye, MingjinX > Sent: 2023年2月2日 18:04 > To: dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX > ; Ye, MingjinX ; Wu, > Jingjing ; Xing, Beilei > Subject: [PATCH v2

RE: [PATCH] sched: fix for tc_ov_enable flag position in subport structure.

2023-02-07 Thread Ajmera, Megha
> > > > 10/01/2023 12:27, David Marchand: > > > On Mon, Jan 9, 2023 at 3:59 PM Megha Ajmera > > wrote: > > > > > > > > Current position of "tv_ov_enable" variable in > > > > > > tc_ov_enabled* > > > > > > > > > > rte_sched_subport structure makes the "memory" variable unused. > > > > > > I did not

Re: [PATCH] doc: rebuild all Sphinx guides

2023-02-07 Thread Thomas Monjalon
07/02/2023 09:54, David Marchand: > On Tue, Feb 7, 2023 at 9:44 AM Thomas Monjalon wrote: > > > > On some systems, Sphinx is lazy enough to not recompile an RST file, > > even if it contains a link pointing to a file which has been removed. > > > > In order to detect such broken links, > > the opt

Re: [PATCH 1/2] event/cnxk: fix burst timer arm routine

2023-02-07 Thread Jerin Jacob
On Thu, Feb 2, 2023 at 1:40 PM wrote: > > From: Pavan Nikhilesh > > Fix timer burst arm routine writing improper updates to > the bucket. > > Fixes: 5f644e1bd14c ("event/cnxk: add timer arm timeout burst") > > Signed-off-by: Pavan Nikhilesh > --- Series applied to dpdk-next-net-eventdev/for-ma

Re: [PATCH] event/cnxk: fix timer ops init in secondary

2023-02-07 Thread Jerin Jacob
On Sun, Feb 5, 2023 at 12:04 PM wrote: > > From: Pavan Nikhilesh > > Fix event timer fast-path ops not being initialized in secondary > process. > > Fixes: dd519f83dd96 ("event/cnxk: add timer adapter capabilities") > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-net-eventdev/for-main.

RE: [PATCH v4 1/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-07 Thread Ori Kam
Hi Jiawei, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Friday, 3 February 2023 15:34 > > When multiple physical ports are connected to a single DPDK port, > (example: kernel bonding, DPDK bonding, failsafe, etc.), > we want to know which physical port is used for Rx and Tx.

RE: [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL

2023-02-07 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Tuesday, 7 February 2023 09.47 > > The doc string was left to its previous definition. Make it explicit > that RTE_TEL_INT_VAL is a 64-bit signed integer. > > Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API") > > Signed-off-

Re: [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL

2023-02-07 Thread Bruce Richardson
On Tue, Feb 07, 2023 at 09:46:36AM +0100, Robin Jarry wrote: > The doc string was left to its previous definition. Make it explicit > that RTE_TEL_INT_VAL is a 64-bit signed integer. > > Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API") > > Signed-off-by: Robin Jarry > --- > li

RE: [PATCH v1 3/3] doc/power: remove empty poll documentation

2023-02-07 Thread Pattan, Reshma
> -Original Message- > From: David Hunt --snip-- > This API is no longer needed as it is superceded by the monitor/pause/scale Nitpick. monitor/pause/scale => "PMD Power Managment modes monitor/pause/scale" > Signed-off-by: David Hunt Acked-By: Reshma Pattan

Re: [PATCH v1 00/21] Add control queue & MQ support to Virtio-user vDPA

2023-02-07 Thread Maxime Coquelin
On 1/30/23 06:57, Xia, Chenbo wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Wednesday, November 30, 2022 11:56 PM To: dev@dpdk.org; Xia, Chenbo ; david.march...@redhat.com; epere...@redhat.com Cc: Maxime Coquelin Subject: [PATCH v1 00/21] Add control queue & MQ s

Re: [PATCH] app/testpmd: fix forwarding stats for Tx dropped

2023-02-07 Thread Singh, Aman Deep
On 1/31/2023 5:26 PM, Ferruh Yigit wrote: There is an inconsistency at displaying Tx dropped value for per port forwarding stats and accumulated forwarding stats. While displaying per port TX-dropped value, it only takes 'ports_stats[pt_id].tx_dropped' into account, but for accumulated TX-drop

Re: [PATCH v1 10/21] net/virtio: alloc Rx SW ring only if vectorized path

2023-02-07 Thread Maxime Coquelin
On 1/30/23 08:49, Xia, Chenbo wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Wednesday, November 30, 2022 11:56 PM To: dev@dpdk.org; Xia, Chenbo ; david.march...@redhat.com; epere...@redhat.com Cc: Maxime Coquelin Subject: [PATCH v1 10/21] net/virtio: alloc Rx SW

Re: [PATCH v2] vhost: decrease log level for unimplemented requests

2023-02-07 Thread Kevin Traynor
On 06/02/2023 15:07, Maxime Coquelin wrote: This patch changes VHOST_USER_SET_VRING_ERR and VHOST_USER_SET_LOG_FD "not implemented" log levels from INFO to DEBUG, as implementing these requests is not mandatory. Having them being displayed at INFO level may induce some confusion to the end-user.

[PATCH v6 0/9] Lock annotations

2023-02-07 Thread David Marchand
vhost internals involves multiple locks to protect data access by multiple threads. This series uses clang thread safety checks [1] to catch issues during compilation: EAL spinlock, seqlock and rwlock are annotated and vhost code is instrumented so that clang can statically check correctness. Tho

[PATCH v6 1/9] eal: annotate spinlock, rwlock and seqlock

2023-02-07 Thread David Marchand
clang offers some thread safety checks, statically verifying that locks are taken and released in the code. To use those checks, the full code leading to taking or releasing locks must be annotated with some attributes. Wrap those attributes into our own set of macros. rwlock, seqlock and the "no

[PATCH v6 2/9] vhost: simplify need reply handling

2023-02-07 Thread David Marchand
Dedicate send_vhost_slave_message() helper to the case when no reply is needed. Add a send_vhost_slave_message_process_reply() helper for the opposite. This new helper merges both send_vhost_slave_message() and the code previously in process_slave_message_reply(). The slave_req_lock lock is then o

[PATCH v6 3/9] vhost: terminate when access lock is not taken

2023-02-07 Thread David Marchand
Be a bit more strict when a programmatic error is detected with regards to the access_lock not being taken. Mark the new helper with __rte_assert_exclusive_lock so that clang understands where locks are expected to be taken. Signed-off-by: David Marchand Acked-by: Morten Brørup Reviewed-by: Maxi

[PATCH v6 4/9] vhost: annotate virtqueue access lock

2023-02-07 Thread David Marchand
vhost_user_lock/unlock_all_queue_pairs must be waived since clang annotations can't express taking a runtime number of locks. vhost_queue_stats_update() requirement can be expressed with a required tag. Signed-off-by: David Marchand Acked-by: Morten Brørup Reviewed-by: Maxime Coquelin --- Chan

[PATCH v6 5/9] vhost: annotate async accesses

2023-02-07 Thread David Marchand
vq->async is initialised and must be accessed under vq->access_lock. Signed-off-by: David Marchand Acked-by: Morten Brørup Reviewed-by: Maxime Coquelin --- Changes since v5: - rebased after packed support was added to async code, Changes since RFC v3: - rebased, - fixed annotations vq->access_

[PATCH v6 6/9] vhost: always take IOTLB lock

2023-02-07 Thread David Marchand
clang does not support conditionally held locks when statically analysing taken locks with thread safety checks. Always take iotlb locks regardless of VIRTIO_F_IOMMU_PLATFORM feature. Signed-off-by: David Marchand Acked-by: Morten Brørup Reviewed-by: Maxime Coquelin --- lib/vhost/vhost.c

[PATCH v6 7/9] vhost: annotate IOTLB lock

2023-02-07 Thread David Marchand
The starting point for this is __vhost_iova_to_vva() which requires the lock to be taken. Annotate all the code leading to a call to it. vdpa and vhost_crypto code are annotated but they end up not taking a IOTLB lock and have been marked with a FIXME at the top level. Signed-off-by: David Marcha

[PATCH v6 8/9] vhost: annotate vDPA device list accesses

2023-02-07 Thread David Marchand
Access to vdpa_device_list must be protected with vdpa_device_list_lock spinlock. Signed-off-by: David Marchand Acked-by: Morten Brørup Reviewed-by: Maxime Coquelin --- Changes since RFC v3: - rebased, --- lib/vhost/vdpa.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletion

[PATCH v6 9/9] vhost: enable lock check

2023-02-07 Thread David Marchand
Now that all locks in this library are annotated, we can enable the check. Signed-off-by: David Marchand Acked-by: Morten Brørup Reviewed-by: Maxime Coquelin --- lib/vhost/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build index bc72

RE: [PATCH] dma/ioat: remove printf within ioat driver

2023-02-07 Thread Walsh, Conor
> On Fri, Feb 03, 2023 at 04:35:14PM +, Conor Walsh wrote: > > rte_log should be used instead of printf within the drivers this patch > > changes a printf within the ioat dma driver's start function to an rte log. > > The printfs within ioat's dump function will be retained. > > > > Signed-off-

RE: [PATCH v1 1/3] examples/power: remove empty poll mode from l3fwd-power

2023-02-07 Thread Pattan, Reshma
> -Original Message- > From: David Hunt > /* only legacy and empty poll mode rely on power library */ You can remove empty poll mode reference in above comment. Can we check, inside print_usage() function , we need to remove below lines " --empty-poll: enabl

[PATCH v2] dma/ioat: remove printf within ioat driver

2023-02-07 Thread Conor Walsh
rte_log should be used instead of printf within the drivers. This patch changes a printf within the ioat dma driver's start function to an rte log. The printfs within ioat's dump function will be retained Signed-off-by: Conor Walsh Acked-by: Bruce Richardson --- v2: fix whitespace issue --- d

[PATCH v4 0/6] add idpf pmd enhancement features

2023-02-07 Thread Mingxia Liu
This patchset add several enhancement features of idpf pmd. Including the following: - add hw statistics, support stats/xstats ops - add rss configure/show ops - add event handle: link status - add scattered data path for single queue This patchset is based on the refactor idpf PMD code: http://pa

[PATCH v4 1/6] common/idpf: add hw statistics

2023-02-07 Thread Mingxia Liu
This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.c | 17 + drivers/common/idpf/idpf_common_device.h | 4 + drivers/common/idpf/idpf_common_virtchnl.c | 27 +++ drivers/common/idpf/idpf_common_virtchnl.h | 3 + d

[PATCH v4 2/6] common/idpf: add RSS set/get ops

2023-02-07 Thread Mingxia Liu
Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.h | 1 + drivers/common/idpf/idpf_common_virtchnl.c | 119 + drivers/common/idpf/idpf_common_virtchnl.h |

[PATCH v4 3/6] common/idpf: support single q scatter RX datapath

2023-02-07 Thread Mingxia Liu
This patch add single q recv scatter rx function. Signed-off-by: Mingxia Liu Signed-off-by: Wenjun Wu --- drivers/common/idpf/idpf_common_rxtx.c | 135 + drivers/common/idpf/idpf_common_rxtx.h | 3 + drivers/common/idpf/version.map| 1 + drivers/net/idpf/idpf

[PATCH v4 4/6] common/idpf: add rss_offload hash in singleq rx

2023-02-07 Thread Mingxia Liu
This patch add rss valid flag and hash value parsing of rx descriptor. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_rxtx.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c inde

[PATCH v4 5/6] common/idpf: add alarm to support handle vchnl message

2023-02-07 Thread Mingxia Liu
Handle virtual channel message. Refine link status update. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Ling --- drivers/common/idpf/idpf_common_device.h | 5 + drivers/common/idpf/idpf_common_virtchnl.c | 33 ++-- drivers/common/idpf/idpf_common_virtchnl.h | 6 + drivers/common/idpf

[PATCH v4 6/6] common/idpf: add xstats ops

2023-02-07 Thread Mingxia Liu
Add support for these device ops: -idpf_dev_xstats_get -idpf_dev_xstats_get_names -idpf_dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/idpf/idpf_ethdev.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/

RE: [PATCH v1 2/3] libs/power: remove experimental empty poll API

2023-02-07 Thread Pattan, Reshma
> -Original Message- > From: David Hunt > Subject: [PATCH v1 2/3] libs/power: remove experimental empty poll API Typo: libs=>lib > This API is no longer needed as it is superceded by the monitor/pause/scale > callback mechanism. monitor/pause/scale => "PMD Power Management Mode monit

[PATCH v4 0/6] add idpf pmd enhancement features

2023-02-07 Thread Mingxia Liu
This patchset add several enhancement features of idpf pmd. Including the following: - add hw statistics, support stats/xstats ops - add rss configure/show ops - add event handle: link status - add scattered data path for single queue This patchset is based on the refactor idpf PMD code: http://pa

[PATCH v5 1/6] common/idpf: add hw statistics

2023-02-07 Thread Mingxia Liu
This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.c | 17 + drivers/common/idpf/idpf_common_device.h | 4 + drivers/common/idpf/idpf_common_virtchnl.c | 27 +++ drivers/common/idpf/idpf_common_virtchnl.h | 3 + d

[PATCH v5 2/6] common/idpf: add RSS set/get ops

2023-02-07 Thread Mingxia Liu
Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.h | 1 + drivers/common/idpf/idpf_common_virtchnl.c | 119 + drivers/common/idpf/idpf_common_virtchnl.h |

[PATCH v5 3/6] common/idpf: support single q scatter RX datapath

2023-02-07 Thread Mingxia Liu
This patch add single q recv scatter rx function. Signed-off-by: Mingxia Liu Signed-off-by: Wenjun Wu --- drivers/common/idpf/idpf_common_rxtx.c | 135 + drivers/common/idpf/idpf_common_rxtx.h | 3 + drivers/common/idpf/version.map| 1 + drivers/net/idpf/idpf

[PATCH v5 4/6] common/idpf: add rss_offload hash in singleq rx

2023-02-07 Thread Mingxia Liu
This patch add rss valid flag and hash value parsing of rx descriptor. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_rxtx.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c inde

[PATCH v5 5/6] common/idpf: add alarm to support handle vchnl message

2023-02-07 Thread Mingxia Liu
Handle virtual channel message. Refine link status update. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 5 + drivers/common/idpf/idpf_common_virtchnl.c | 33 ++-- drivers/common/idpf/idpf_common_virtchnl.h | 6 + drivers/common/idpf

[PATCH v5 6/6] common/idpf: add xstats ops

2023-02-07 Thread Mingxia Liu
Add support for these device ops: -idpf_dev_xstats_get -idpf_dev_xstats_get_names -idpf_dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/idpf/idpf_ethdev.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/

[PATCH v6 0/6] add idpf pmd enhancement features

2023-02-07 Thread Mingxia Liu
This patchset add several enhancement features of idpf pmd. Including the following: - add hw statistics, support stats/xstats ops - add rss configure/show ops - add event handle: link status - add scattered data path for single queue This patchset is based on the refactor idpf PMD code: http://pa

[PATCH v6 1/6] common/idpf: add hw statistics

2023-02-07 Thread Mingxia Liu
This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.c | 17 + drivers/common/idpf/idpf_common_device.h | 4 + drivers/common/idpf/idpf_common_virtchnl.c | 27 +++ drivers/common/idpf/idpf_common_virtchnl.h | 3 + d

[PATCH v6 2/6] common/idpf: add RSS set/get ops

2023-02-07 Thread Mingxia Liu
Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_device.h | 1 + drivers/common/idpf/idpf_common_virtchnl.c | 119 + drivers/common/idpf/idpf_common_virtchnl.h |

[PATCH v6 3/6] common/idpf: support single q scatter RX datapath

2023-02-07 Thread Mingxia Liu
This patch add single q recv scatter rx function. Signed-off-by: Mingxia Liu Signed-off-by: Wenjun Wu --- drivers/common/idpf/idpf_common_rxtx.c | 135 + drivers/common/idpf/idpf_common_rxtx.h | 3 + drivers/common/idpf/version.map| 1 + drivers/net/idpf/idpf

[PATCH v6 4/6] common/idpf: add rss_offload hash in singleq rx

2023-02-07 Thread Mingxia Liu
This patch add rss valid flag and hash value parsing of rx descriptor. Signed-off-by: Mingxia Liu --- drivers/common/idpf/idpf_common_rxtx.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c inde

[PATCH v6 6/6] common/idpf: add xstats ops

2023-02-07 Thread Mingxia Liu
Add support for these device ops: -idpf_dev_xstats_get -idpf_dev_xstats_get_names -idpf_dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/idpf/idpf_ethdev.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/

[PATCH v6 5/6] common/idpf: add alarm to support handle vchnl message

2023-02-07 Thread Mingxia Liu
Handle virtual channel message. Refine link status update. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 5 + drivers/common/idpf/idpf_common_virtchnl.c | 33 ++-- drivers/common/idpf/idpf_common_virtchnl.h | 6 + drivers/common/idpf

Re: [PATCH] lpm: use SVE for bulk lookup

2023-02-07 Thread Thomas Monjalon
09/01/2023 10:28, Ruifeng Wang: > SVE was used for lookupx4 where four entries are looked up at a time. > It is not an ideal case for SVE implementation which does not bound > to vector length. > Changed to use SVE implementation in bulk lookup when the feature is > available. And optimized the SVE

Re: [PATCH 0/2] lib/reorder: fix drain/free issues

2023-02-07 Thread Thomas Monjalon
Pïng for review 26/01/2023 16:47, David Marchand: > Hi Reshma, > > On Sat, Jan 7, 2023 at 4:20 PM Volodymyr Fialko wrote: > > > > This patch address issues with reorder drain/free, > > discovered with enabled `RTE_LIBRTE_MEMPOOL_DEBUG`. > > > > Volodymyr Fialko (2): > > reorder: invalidate buf

Re: [PATCH v2] net/i40e: don't check link status on device start

2023-02-07 Thread Thomas Monjalon
16/01/2023 12:02, Su, Simei: > From: David Marchand > > On Fri, Jan 13, 2023 at 2:51 PM Zhang, Helin wrote: > > > From: David Marchand > > > > On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin > > > > > From: David Marchand > > > > > > Hello i40e maintainers, John, > > > > > > > > > > > > On Mon, J

[PATCH v2] net/mlx5/hws: support match on ESP item

2023-02-07 Thread Viacheslav Ovsiienko
From: Hamdan Igbaria Add the support to match on SPI and sequence number fields of ESP header. The match on ESP header in hardware steering is supported only if firmware reports the device supports IPsec offload. Signed-off-by: Hamdan Igbaria Acked-by: Viacheslav Ovsiienko --- drivers/common

Re: [PATCH v3 2/4] crypto/cnxk: restructure for cn10k datapath

2023-02-07 Thread Jerin Jacob
On Wed, Jan 25, 2023 at 5:02 PM Rahul Bhansali wrote: > > From: Anoob Joseph > > Inclusion of roc_api.h in all files would mean any change in RoC API > would result in recompilation of all cnxk drivers. Address this issue in > crypto_cnxk drivers by including only the headers that are required. >

Re: [dpdk-dev] [PATCH] common/cnxk: fix second pass flow rule layer type

2023-02-07 Thread Jerin Jacob
On Tue, Jan 31, 2023 at 9:07 AM wrote: > > From: Satheesh Paul > > When installing flow rule for second pass packets, set the > LA LTYPE to LA_CPT_HDR. > > Fixes: 4968b362b63 ("common/cnxk: support CPT second pass flow rules") Fixes: 4968b362b639 ("common/cnxk: support CPT second pass flow rules

RE: [PATCH v3 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match support

2023-02-07 Thread Alex Vesker
Hi, > -Original Message- > From: Leo Xu > Sent: Sunday, 5 February 2023 15:42 > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH v3 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match > support > > This patch adds ICMPv6 ID and sequence match support for HWS. > S

Re: [PATCH v5 1/3] eal: add rte control thread create API

2023-02-07 Thread David Marchand
On Tue, Jan 31, 2023 at 9:30 PM Tyler Retzlaff wrote: > > Add rte_control_thread_create API as a replacement for > rte_ctrl_thread_create to allow deprecation of the use of platform > specific types in DPDK public API. > > Duplicate the rte_ctrl_thread_create test adapted to use > rte_control_thre

RE: [PATCH v5 2/4] eal: allow applications to report their cpu usage

2023-02-07 Thread Konstantin Ananyev
> > > Ok I see. But what should we do to prevent this? Simply ignore the > > > request and log a warning? > > > > That's seems like simplest choice to me... Or if you still prefer to > > allow it - put a special comment that it is user responsibility to > > handle such possible race-condition (in

Re: [PATCH] test/mbuf: fix mbuf_autotest retest fail

2023-02-07 Thread David Marchand
On Tue, Jan 31, 2023 at 3:52 AM Jie Hai wrote: > > Retest "mbuf_autotest" will fail because the mbuf pool was > not freed after previous test successful done. > This patch fixes it. Good catch. > > Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free") > Cc: sta...@dpdk.org > > Signed-off-by: Jie

Re: [PATCH] test/graph: initialize graph param variable

2023-02-07 Thread David Marchand
On Fri, Feb 3, 2023 at 9:49 AM Amit Prakash Shukla wrote: > > Initializing rte_graph_param variable with 0 to avoid any > garbage value in structure elements which are not populated > as part of this function. Something looks strange to me. I fail to see which part of this object is not initialis

Re: [PATCH] bus: fix leak for devices without driver

2023-02-07 Thread David Marchand
On Sat, Jan 7, 2023 at 4:12 PM Volodymyr Fialko wrote: > > For devices not assigned to any driver, we leak a pci device object since > it is never freed from the PCI bus device list, reported by ASAN. > > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Worth copying stable. > > Signed-o

RE: [PATCH v3 2/3] net/mlx5: add ICMPv6 ID and sequence match support

2023-02-07 Thread Slava Ovsiienko
> -Original Message- > From: Leo Xu (Networking SW) > Sent: Sunday, February 5, 2023 3:42 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH v3 2/3] net/mlx5: add ICMPv6 ID and sequence match support > > This patch adds ICMPv6 ID and sequence match support. > S

RE: [PATCH v3 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match support

2023-02-07 Thread Slava Ovsiienko
> -Original Message- > From: Leo Xu (Networking SW) > Sent: Sunday, February 5, 2023 3:42 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH v3 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match > support > > This patch adds ICMPv6 ID and sequence match suppor

[PATCH v2] doc: update cross-port indirect shared action

2023-02-07 Thread Viacheslav Ovsiienko
The patch updates the Release Notes and documentation for the indirect RTE Flow actions as shared ones between ports on the same physical NIC. Signed-off-by: Viacheslav Ovsiienko --- doc/guides/rel_notes/release_23_03.rst | 6 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +++- 2 f

[PATCH v2 1/9] ethdev: sharing indirect actions between ports

2023-02-07 Thread Viacheslav Ovsiienko
The RTE Flow API implements the concept of shared objects, known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). An application can create the indirect action of desired type and configuration with rte_flow_action_handle_create call and then specify the obtained action handle in multiple flows

[PATCH v2 2/9] app/testpmd: add host port parameter into flow config

2023-02-07 Thread Viacheslav Ovsiienko
Host port id parameter is added to "flow configure" command. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline_flow.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498e0..b88756903b 100644 --- a/app

[PATCH v2 3/9] app/testpmd: add shared indirect action support

2023-02-07 Thread Viacheslav Ovsiienko
The shared indirect action can be shared between ports, action should be created on single port and the handle can be used in the templates and flows on multiple ports, example: flow configure 0 queues_number 1 queues_size 64 counters_number 64 flow configure 1 queues_number 1 queues_size 64 c

[PATCH v2 5/9] net/mlx5/hws: fix disconnecting matcher

2023-02-07 Thread Viacheslav Ovsiienko
From: Erez Shitrit This patch fixes the matcher disconnection handling, by removing the RTC references from flow table if the currently removed matcher was the last one for the given table. As a result RTC in this matcher can be correctly freed, since there are no dangling references to the RTC.

[PATCH v2 4/9] net/mlx5/hws: free FT from RTC id before set the new value

2023-02-07 Thread Viacheslav Ovsiienko
From: Erez Shitrit While matcher is being connect/disconnect in shared gvmi flow we set the first ft in the table to point on the first matcher, The FW is increasing the refcount on the first matcher RTC because of that no matcher if it is the same RTC that was set before, and when we will try to

[PATCH v2 6/9] common/mlx5: add cross port object sharing capability

2023-02-07 Thread Viacheslav Ovsiienko
Add query port capabilities to share steering objects between multiple ports of the same physical NIC. Signed-off-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 13 + drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 14 insertions(+) diff --git a/dri

[PATCH v2 7/9] net/mlx5: add cross port shared mode for HW steering

2023-02-07 Thread Viacheslav Ovsiienko
Add host port option for sharing steering objects between multiple ports of the same physical NIC. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 6 +++ drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow_hw.c | 78 +++-- dri

[PATCH v2 9/9] doc: update cross-port indirect shared action

2023-02-07 Thread Viacheslav Ovsiienko
The patch updates the Release Notes and documentation for the indirect RTE Flow actions as shared ones between ports on the same physical NIC. Signed-off-by: Viacheslav Ovsiienko --- doc/guides/rel_notes/release_23_03.rst | 6 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +++- 2 f

[PATCH v2 8/9] net/mlx5: support counters in cross port shared mode

2023-02-07 Thread Viacheslav Ovsiienko
In the cross vHCA sharing mode the host counter pool should be used in counter related routines. The local port pool is used to store the dedicated DR action handle, per queue counter caches and query data are ignored and not allocated on local pool. Signed-off-by: Viacheslav Ovsiienko --- drive

RE: [PATCH v2] net/i40e: don't check link status on device start

2023-02-07 Thread Su, Simei
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, February 7, 2023 7:32 PM > To: Zhang, Helin ; Su, Simei > Cc: David Marchand ; dev@dpdk.org; Zhang, > Yuying ; Xing, Beilei ; > Mcnamara, John ; sta...@dpdk.org; Zhang, Qi Z > ; Dapeng Yu ; Wenxuan Wu > > Subject:

RE: [EXT] Re: [PATCH v2] bus: add platform bus

2023-02-07 Thread Tomasz Duszynski
Hi David, >-Original Message- >From: David Marchand >Sent: Monday, February 6, 2023 3:29 PM >To: Tomasz Duszynski >Cc: dev@dpdk.org; Thomas Monjalon ; chenbo@intel.com; >Jerin Jacob >Kollanukkaran ; step...@networkplumber.org >Subject: [EXT] Re: [PATCH v2] bus: add platform bus > >

Re: [PATCH v1 21/21] net/virtio-user: remove max queues limitation

2023-02-07 Thread Maxime Coquelin
On 1/31/23 06:19, Xia, Chenbo wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Wednesday, November 30, 2022 11:57 PM To: dev@dpdk.org; Xia, Chenbo ; david.march...@redhat.com; epere...@redhat.com Cc: Maxime Coquelin Subject: [PATCH v1 21/21] net/virtio-user: remove

[PATCH v1] Remove Owen Hilyard as a DTS Maintainer

2023-02-07 Thread ohilyard
From: Owen Hilyard I (Owen Hilyard) am stepping down as a DTS maintainer. Signed-off-by: Owen Hilyard --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3495946d0f..e78bed6da1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1765,7 +1765,6 @@ F: do

Re: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling

2023-02-07 Thread Ferruh Yigit
On 2/3/2023 7:14 PM, Stephen Hemminger wrote: > This patchset keeps uncovering bad practices in the cmdline library > around end of file and signal handling. > > Stephen Hemminger (3): > cmdline: make rdline status not private > cmdline: handle EOF in cmdline_poll > testpmd: cleanup cleanly

Re: [PATCH v11 3/3] testpmd: cleanup cleanly from signal

2023-02-07 Thread Ferruh Yigit
On 2/3/2023 7:14 PM, Stephen Hemminger wrote: > Do a clean shutdown of testpmd when a signal is received; instead of > having testpmd kill itself. This fixes the problem where a signal could > be received in the middle of a PMD and then the signal handler would > call PMD's close routine leading t

Re: [PATCH v7 0/7] start cleanup of rte_flow_item_*

2023-02-07 Thread Thomas Monjalon
03/02/2023 17:48, Ferruh Yigit: > There was a plan to have structures from lib/net/ at the beginning > of corresponding flow item structures. > Unfortunately this plan has not been followed up so far. > This series is a step to make the most used items, > compliant with the inheritance design expla

RE: [PATCH v2 1/4] ethdev: add template table insertion type

2023-02-07 Thread Alexander Kozyrev
> > Allow user to specify insertion type used in template tables. > > The insertion type is responsible for choosing the appropriate key > > value used to map inserted flow rules into a template table. > > > > Flow rules can be inserted by calculating the hash value for > > the pattern or inserted

[dpdk-dev] [PATCH v3 00/12] mldev: introduce machine learning device library

2023-02-07 Thread jerinj
From: Jerin Jacob Machine learning inference library == Definition of machine learning inference Inference in machine learning is the process of making an output prediction based on new input data using a pre-trained machin

[dpdk-dev] [PATCH v3 01/12] mldev: introduce machine learning device library

2023-02-07 Thread jerinj
From: Jerin Jacob Add mldev API specification to standardize and use the machine learning device and inference operations in vendor neutral way. Following operations are abstracted through APIs - ML device capability probe - ML device configuration - ML device queue pair configuration - ML devi

[dpdk-dev] [PATCH v3 02/12] mldev: support PMD functions for ML device

2023-02-07 Thread jerinj
From: Srikanth Yalavarthi Added PMD functions to handle ML devices. The rte_mldev_pmd.* files are for drivers only and should be private to DPDK, and are not installed for application use. Added implementation for rte_ml_dev_init. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob -

[dpdk-dev] [PATCH v3 03/12] mldev: support ML device handling functions

2023-02-07 Thread jerinj
From: Srikanth Yalavarthi Added ML device handling APIs. These APIs are used to get device information, configure, start, stop and close ML devices. Added function prototypes to PMD layer which are used by the ML driver implementations in the poll mode driver. Signed-off-by: Srikanth Yalavarthi

[dpdk-dev] [PATCH v3 04/12] mldev: support ML device queue-pair setup

2023-02-07 Thread jerinj
From: Srikanth Yalavarthi Added APIs to create a queue-pair attached to ML device. Queue pairs are created with a user specified ID. Added function prototypes to be used by ML drivers for queue pair create and destroy. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Jerin Jacob --- lib/mlde

  1   2   3   4   >