Hi Thomas, > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Tuesday, February 7, 2023 7:32 PM > To: Zhang, Helin <helin.zh...@intel.com>; Su, Simei <simei...@intel.com> > Cc: David Marchand <david.march...@redhat.com>; dev@dpdk.org; Zhang, > Yuying <yuying.zh...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; > Mcnamara, John <john.mcnam...@intel.com>; sta...@dpdk.org; Zhang, Qi Z > <qi.z.zh...@intel.com>; Dapeng Yu <dapengx...@intel.com>; Wenxuan Wu > <wenxuanx...@intel.com> > Subject: Re: [PATCH v2] net/i40e: don't check link status on device start > > 16/01/2023 12:02, Su, Simei: > > From: David Marchand <david.march...@redhat.com> > > > On Fri, Jan 13, 2023 at 2:51 PM Zhang, Helin <helin.zh...@intel.com> > wrote: > > > > From: David Marchand <david.march...@redhat.com> > > > > > On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin > > > > > <helin.zh...@intel.com> > > > > > > From: David Marchand <david.march...@redhat.com> > > > > > > > Hello i40e maintainers, John, > > > > > > > > > > > > > > On Mon, Jan 9, 2023 at 10:21 AM David Marchand > > > > > > > <david.march...@redhat.com> wrote: > > > > > > > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand > > > > > > > <david.march...@redhat.com> wrote: > > > > > > > > > Hi i40e maintainers, > > > > > > > > > > > > > > > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand > > > > > > > > > <david.march...@redhat.com> wrote: > > > > > > > > > > > > > > > > > > > > The mentioned changes broke existing applications when > > > > > > > > > > the link status of i40e ports is down at the time the port > > > > > > > > > > is > started. > > > > > > > > > > Revert those changes, the original issue will need a > > > > > > > > > > different > fix. > > > > > > Hi David > > > > > > > > > > > > Does it break all the application or just a specific application? > > > > > > > > > > I don't see how it would not affect all applications seeing how > > > > > the original patch is dumb. > > > > > > > > > > > We may need to understand the issue you met, and try to fix it > > > > > > later. > > > > > > > > > > Just unplug the cable or fake a link down on your i40e port, > > > > > start your application or port, then plug the cable back. > > > > > The max frame size will never get applied to hw. > > > > > > > > Got it, I will forward to a right expert to check. Thank you very > > > > much for > > > reaching out to us! > > > > > > I hope I get a reply _soon_. > > > Or I will just apply those reverts. > > > > If applying those reverts, some issues still exist on our side. I sent one > > patch > to patchwork: > > > https://patchwork.dpdk.org/project/dpdk/patch/20230116105318.19412-1-si > mei...@intel.com/. > > You can try this patch to see whether it can solve the issue on your side. > > At the same time, on our side, we need to do regression test further > > to check if this patch will affect other cases, the regression takes some > > time. > > > > Thanks, > > Simei > > Simei, do you have any update in this thread? > Last reply was 3 weeks ago. I hope regression test don't take so much time. > > The latest patch for this issue is https://patchwork.dpdk.org/project/dpdk/patch/20230202123632.56730-1-simei...@intel.com/ which needs to be reworked further.
Thanks, Simei
