[PATCH v5 1/4] eventdev/eth_rx: change eventdev reconfig logic

2022-12-20 Thread Naga Harish K S V
When rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_with_params() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_conf

[PATCH v5 2/4] eventdev/eth_tx: change eventdev reconfig logic

2022-12-20 Thread Naga Harish K S V
When rte_event_eth_tx_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH v5 3/4] eventdev/crypto: change eventdev reconfig logic

2022-12-20 Thread Naga Harish K S V
When rte_event_crypto_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH v5 4/4] eventdev/timer: change eventdev reconfig logic

2022-12-20 Thread Naga Harish K S V
When rte_event_timer_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter i

[PATCH v5 1/4] eventdev/eth_rx: change eventdev reconfig logic

2022-12-20 Thread Naga Harish K S V
When rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_with_params() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_conf

[PATCH v5 2/4] eventdev/eth_tx: change eventdev reconfig logic

2022-12-20 Thread Naga Harish K S V
When rte_event_eth_tx_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH v5 3/4] eventdev/crypto: change eventdev reconfig logic

2022-12-20 Thread Naga Harish K S V
When rte_event_crypto_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH v5 4/4] eventdev/timer: change eventdev reconfig logic

2022-12-20 Thread Naga Harish K S V
When rte_event_timer_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter i

RE: [PATCH v4 4/4] eventdev/timer: change eventdev reconfig logic

2022-12-20 Thread Naga Harish K, S V
Hi Gabe, > -Original Message- > From: Carrillo, Erik G > Sent: Monday, December 19, 2022 10:48 PM > To: Naga Harish K, S V ; jer...@marvell.com; > Gujjar, Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: RE: [PATCH v4 4/4] eventdev/timer: change eventdev reconfig logic >

Re: [PATCH] net/iavf:fix slow memory allocation

2022-12-20 Thread David Marchand
On Tue, Dec 20, 2022 at 7:52 AM You, KaisenX wrote: > > >> As to the reason for not using rte_malloc_socket. I thought > > >> rte_malloc_socket() could solve the problem too. And the appropriate > > >> parameter should be the socket_id that created the memory pool for > > >> DPDK initialization. A

RE: [PATCH] net/iavf:fix slow memory allocation

2022-12-20 Thread You, KaisenX
> -Original Message- > From: David Marchand > Sent: 2022年12月20日 17:34 > To: You, KaisenX > Cc: Ferruh Yigit ; dev@dpdk.org; Burakov, Anatoly > ; sta...@dpdk.org; Yang, Qiming > ; Zhou, YidingX ; Wu, > Jingjing ; Xing, Beilei ; Zhang, > Qi Z ; Luca Boccassi ; Mcnamara, > John ; Kevin Tra

Re: [PATCH] net/iavf:fix slow memory allocation

2022-12-20 Thread David Marchand
On Tue, Dec 20, 2022 at 11:12 AM You, KaisenX wrote: > > I tried to play a bit with a E810 nic on a dual numa and I can't see > > anything > > wrong for now. > > Can you provide a simple and small reproducer of your issue? > > > > Thanks. > > > This is my environment: > Enter "lscpu" on the comma

RE: [RFC 0/1] lib: add pdcp protocol

2022-12-20 Thread Anoob Joseph
Hi Akhil, Thanks for the review. Please see inline. Thanks Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, December 13, 2022 12:32 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; M

Re: [PATCH v3 1/2] vhost: check for nr_vec == 0 in desc_to_mbuf, mbuf_to_desc

2022-12-20 Thread Claudio Fontana
On 11/2/22 11:34, Claudio Fontana wrote: > On 10/5/22 17:06, Maxime Coquelin wrote: >> >> >> On 8/2/22 02:49, Claudio Fontana wrote: >>> in virtio_dev_split we cannot currently call desc_to_mbuf with >>> nr_vec == 0, or we end up trying to rte_memcpy from a source address >>> buf_vec[0] that is an

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

2022-12-20 Thread Maxime Coquelin
Hi Mike, On 12/7/22 17:54, Mike Pattrick wrote: Currently if an application wants to include shared hugepages in coredumps in conjunction with the vhost library, the coredump will be larger than expected and include unneeded virtual machine memory. This patch will mark all vhost huge pages as D

power: remove experimental empty poll API

2022-12-20 Thread David Hunt
The empty poll mechanism was an experimental API added in commit id 450f0791312c. It aimed to allow power saving depending on the traffic profile. However, it required a training phase and required the user to adjust magic numbers depending on their workload. A new and improved mechanism was added

[PATCH v1 1/3] examples/power: remove empty poll mode from l3fwd-power

2022-12-20 Thread David Hunt
Remove calls to the experimental empty poll API. l3fwd-power is the only app that uses this. This API is no longer needed as it is superceded by the monitor/pause/scale callback mechanism. Signed-off-by: David Hunt --- examples/l3fwd-power/main.c | 266 +--- 1 fi

[PATCH v1 2/3] libs/power: remove experimental empty poll API

2022-12-20 Thread David Hunt
This patchset removes the empty poll experimental API, which has been in an experimental state since it was added. This API is no longer needed as it is superceded by the monitor/pause/scale callback mechanism. Signed-off-by: David Hunt --- lib/power/meson.build| 2 - lib/power/rt

[PATCH v1 3/3] doc/power: remove empty poll documentation

2022-12-20 Thread David Hunt
Remove the documentation for the removed experimental empty poll API, as it is no longer needed. This API is no longer needed as it is superceded by the monitor/pause/scale callback mechanism. Signed-off-by: David Hunt --- doc/guides/prog_guide/power_man.rst | 94 ---

Re: [PATCH v1 1/3] examples/power: remove empty poll mode from l3fwd-power

2022-12-20 Thread Hunt, David
On 20/12/2022 12:56, David Hunt wrote: Remove calls to the experimental empty poll API. l3fwd-power is the only app that uses this. This API is no longer needed as it is superceded by the monitor/pause/scale callback mechanism. I did check the spelling against my spellchecker with checkpatc

Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0

2022-12-20 Thread Kevin Traynor
On 24/06/2022 11:23, Ciara Loftus wrote: libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd functions. Use meson to detect if libbpf >= v0.7.0 is linked and if so, use the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach and bpf_xdp_detach which are availab

[PATCH 00/17] fixes and improvements to cnxk crytpo PMD

2022-12-20 Thread Tejasree Kondoj
This series adds improvements and support for SHA3, IPsec scatter gather mode in cnxk crypto PMD. Aakash Sasidharan (1): common/cnxk: generate opad and ipad in driver Anoob Joseph (3): common/cnxk: perform LF fini ops only when allocated crypto/cnxk: remove null check of session priv comm

[PATCH 01/17] common/cnxk: perform LF fini ops only when allocated

2022-12-20 Thread Tejasree Kondoj
From: Anoob Joseph If LFs are not attached, LF detach and free ops should not be attempted. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_cpt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c index fb97ec89b2..bf216

[PATCH 02/17] common/cnxk: generate opad and ipad in driver

2022-12-20 Thread Tejasree Kondoj
From: Aakash Sasidharan Generate opad and ipad in driver for SHA based crypto algos Signed-off-by: Aakash Sasidharan --- drivers/common/cnxk/cnxk_security.c | 4 +-- drivers/common/cnxk/roc_hash.c | 12 --- drivers/common/cnxk/roc_hash.h | 2 +- drivers/common/cnxk/roc_se.c

[PATCH 03/17] crypto/cnxk: update resp len calculation for IPv6

2022-12-20 Thread Tejasree Kondoj
From: Vidya Sagar Velumuri In IPsec lookaside path, response length for an encryption is pre calculated and updated in the mbuf as the packet length. Response length dpepends on the layer-3 header length. As IPsec security context does not provide any information about the IP version, the layer-3

[PATCH 04/17] crypto/cnxk: add context to passthrough instruction

2022-12-20 Thread Tejasree Kondoj
From: Volodymyr Fialko Attach valid context of last packet instruction to the passthrough instruction to match hardware requirements. Signed-off-by: Volodymyr Fialko --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a

[PATCH 05/17] crypto/cnxk: support truncated digest length

2022-12-20 Thread Tejasree Kondoj
Adding truncated digest length support. Signed-off-by: Tejasree Kondoj --- .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 48 +-- drivers/crypto/cnxk/cnxk_se.h | 19 2 files changed, 35 insertions(+), 32 deletions(-) diff --git a/drivers/crypto/cnxk/cnx

[PATCH 06/17] crypto/cnxk: add queue pair check to meta set

2022-12-20 Thread Tejasree Kondoj
From: Volodymyr Fialko Check that queue pair provided by metadata information is enabled (added to crypto adapter). Signed-off-by: Volodymyr Fialko --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/

[PATCH 07/17] crypto/cnxk: update crypto completion code handling

2022-12-20 Thread Tejasree Kondoj
From: Vidya Sagar Velumuri Update crypto and IPsec completion handling as per microcode version OCPT-04-IE-IPSEC-MC-30-01-28-00 ci: skip_checkformat Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 18 +- drivers/crypto/cnxk/cn10k_ipsec.c

[PATCH 08/17] crypto/cnxk: fix incorrect digest for an empty input data

2022-12-20 Thread Tejasree Kondoj
From: Gowrishankar Muthukrishnan For an empty input data, digest value is incorrectly generated from previous auth op, in case executed. This is due to incorrect gather component used. Fixes: 7c19abdd0cf1 ("common/cnxk: support 103XX CPT") Signed-off-by: Anoob Joseph Signed-off-by: Gowrishanka

[PATCH 09/17] crypto/cnxk: add CN9K IPsec SG support

2022-12-20 Thread Tejasree Kondoj
From: Archana Muniganti Added IPsec SG support in CN9K Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/roc_api.h| 1 + drivers/common/cnxk/roc_cpt_sg.h | 37 +++ drivers/common/cnxk/roc_ie_on.h | 9 +- drivers/common/cn

[PATCH 10/17] crypto/cnxk: add support for SHA3 hash

2022-12-20 Thread Tejasree Kondoj
From: Volodymyr Fialko Add support for SHA3 family hash and hmac operations. Signed-off-by: Volodymyr Fialko --- doc/guides/cryptodevs/cnxk.rst| 8 + doc/guides/cryptodevs/features/cn10k.ini | 8 + doc/guides/cryptodevs/features/cn9k.ini | 8 + drivers/crypto/c

[PATCH 11/17] common/cnxk: skip hmac hash precomputation

2022-12-20 Thread Tejasree Kondoj
From: Volodymyr Fialko Operations with FC opcode requires precomputed ipad and opad hashes, but for auth only (HMAC opcode) this is not required, thus could be skipped. Signed-off-by: Volodymyr Fialko --- drivers/common/cnxk/roc_se.c | 33 - 1 file changed, 20 i

[PATCH 12/17] crypto/octeontx: support truncated digest size

2022-12-20 Thread Tejasree Kondoj
Support truncated digest size for auth only mode. Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_ucode.h| 17 --- .../octeontx/otx_cryptodev_capabilities.c | 48 +-- 2 files changed, 34 insertions(+), 31 deletions(-) diff --git a/drivers/common

[PATCH 13/17] crypto/cnxk: set device ops to null in PCI remove

2022-12-20 Thread Tejasree Kondoj
Setting dev_ops to NULL in pci_remove to avoid device close after removal. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev.c | 1 + drivers/crypto/cnxk/cn9k_cryptodev.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev.c b/drivers/

[PATCH 15/17] crypto/cnxk: set salt in dptr as part of IV

2022-12-20 Thread Tejasree Kondoj
Set salt as part of 16B IV in dptr to avoid race condition. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/roc_se.c | 7 +++- drivers/crypto/cnxk/cnxk_se.h | 76 +++ 2 files changed, 47 insertions(+), 36 deletions(-) diff --git a/drivers/common/cnxk/roc

[PATCH 14/17] crypto/cnxk: add CTX for non IPsec operations

2022-12-20 Thread Tejasree Kondoj
Support context cache with non IPsec operations. Signed-off-by: Tejasree Kondoj Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_platform.h| 3 +- drivers/common/cnxk/roc_se.c | 47 +++ drivers/common/cnxk/roc_se.h | 42 +

[PATCH 16/17] crypto/cnxk: remove null check of session priv

2022-12-20 Thread Tejasree Kondoj
From: Anoob Joseph Session private data is at an offset of session. This can never be NULL. Remove check for the same. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/d

[PATCH 17/17] common/cnxk: remove salt from session

2022-12-20 Thread Tejasree Kondoj
From: Anoob Joseph Complete 16B IV can be passed in DPTR to microcode. Passing salt in CPTR cannot be supported as the salt need to be given in different formats when CTX is enabled. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_se.c | 17 +++-- drivers/common/cnxk/roc_s

Re: [PATCH] net/iavf: add lock for vf commands

2022-12-20 Thread David Marchand
Hello Mike, On Tue, Dec 20, 2022 at 12:24 AM Mike Pattrick wrote: > > iavf admin queue commands aren't thread-safe. Bugs surrounding this > issue can manifest in a variety of ways but frequently pend_cmd is > over written. Simultaneously executing commands can result in a > misconfigured device o

Re: [PATCH v2] IGC: Remove I225_I_PHY_ID checking

2022-12-20 Thread Kevin Traynor
On 19/10/2022 09:34, Kevin Traynor wrote: On 18/10/2022 23:45, Mah, Yock Gen wrote: -Original Message- From: Kevin Traynor Sent: Tuesday, 18 October, 2022 8:54 PM To: Mah, Yock Gen ; IOTG DPDK Ref App ; Zhang, Qi Z Cc: dev@dpdk.org Subject: Re: [PATCH v2] IGC: Remove I225_I_PHY_ID c

[PATCH v2] net/iavf: add lock for vf commands

2022-12-20 Thread Mike Pattrick
iavf admin queue commands aren't thread-safe. Bugs surrounding this issue can manifest in a variety of ways but frequently pend_cmd is over written. Simultaneously executing commands can result in a misconfigured device or DPDK sleeping in a thread for 2 second. Despite this limitation, vf command

DPDK 21.11.3 released

2022-12-20 Thread Kevin Traynor
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-21.11.3.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=21.11 Release notes can be found here: http://doc.dpdk.org/guides-21.11/rel_notes/release_21_11.html#id5 This LTS release contai

[PATCH v3 0/4] implementation of ML common code

2022-12-20 Thread Srikanth Yalavarthi
Machine Learning common code This patch series implements the common ML code that can be used by ML drivers. Common code include functions to convert ML IO type to string, IO format type to string, function get size of ML IO type, and functions for converting data type

[PATCH v3 1/4] common/ml: add initial files for ML common code

2022-12-20 Thread Srikanth Yalavarthi
Added ML common header files and skeleton code. Common ML code includes utility routines to convert ML IO type and format to string, IO type to size and routines to convert data types. Signed-off-by: Srikanth Yalavarthi --- Depends-on: series-26046 ("app/mldev: implement test framework for mldev"

[PATCH v3 2/4] common/ml: add common utility functions

2022-12-20 Thread Srikanth Yalavarthi
Implemented ML common utility functions to convert IO data type to name, IO format to name and routine to get the size of an IO data type in bytes. Signed-off-by: Srikanth Yalavarthi --- v2: * Implemented common utility functions as part of the patch * Dropped use of driver routines for data conv

[PATCH v3 3/4] common/ml: add scalar type conversion functions

2022-12-20 Thread Srikanth Yalavarthi
Added scalar implementations to support conversion of data types. Support is enabled to handle int8, uint8, int16, uint16, float16, float32 and bfloat16 types. Signed-off-by: Srikanth Yalavarthi --- v2: * Updated internal function names * Updated function attributes to __rte_weak drivers/common

[PATCH v3 4/4] common/ml: add Arm NEON type conversion routines

2022-12-20 Thread Srikanth Yalavarthi
Added ARM NEON intrinsic based implementations to support conversion of data types. Support is enabled to handle int8, uint8, int16, uint16, float16, float32 and bfloat16 types. Signed-off-by: Srikanth Yalavarthi --- v2: * Dropped use of driver routines to call neon functions * Optimization of ne

Re: [PATCH v3 1/4] common/ml: add initial files for ML common code

2022-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2022 09:52:53 -0800 Srikanth Yalavarthi wrote: > diff --git a/drivers/common/ml/meson.build b/drivers/common/ml/meson.build > new file mode 100644 > index 00..b0ecc42668 > --- /dev/null > +++ b/drivers/common/ml/meson.build > @@ -0,0 +1,20 @@ > +# SPDX-License-Identifier: B

Re: [PATCH v3 0/4] implementation of ML common code

2022-12-20 Thread Stephen Hemminger
On Tue, 20 Dec 2022 09:52:52 -0800 Srikanth Yalavarthi wrote: > Machine Learning common code > > > This patch series implements the common ML code that can be used by > ML drivers. Common code include functions to convert ML IO type to > string, IO format type to str

RE: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2022-12-20 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 21 December 2022 00:37 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu > Subject: [EXT] Re: [PATCH v3 0/4] implementation of ML common code > > External

RE: [EXT] Re: [PATCH v3 1/4] common/ml: add initial files for ML common code

2022-12-20 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 21 December 2022 00:35 > To: Srikanth Yalavarthi > Cc: Thomas Monjalon ; dev@dpdk.org; Shivah > Shankar Shankar Narayan Rao ; Jerin Jacob > Kollanukkaran ; Anup Prabhu > Subject: [EXT] Re: [PATCH v3 1/4] common/ml: add initial files

[PATCH v3 00/38] Implementation of ML CNXK driver

2022-12-20 Thread Srikanth Yalavarthi
Marvell ML CNXK Driver -- This patch series implements common Machine Learning (ML) ROC code and driver for Marvell Octeon 10 (cnxk) platform. ML inferencing is supported on cnxk platform through an integrated ML inferencing processor. The current driver supports programming th

[PATCH v3 01/38] common/cnxk: add ML headers and ROC code for cnxk

2022-12-20 Thread Srikanth Yalavarthi
Added ML cnxk headers for register, structure definitions and ROC layer. Implemented ROC functions, registered logtype for ML module with the name pmd.ml.cnxk and defined ML hardware ID. Signed-off-by: Srikanth Yalavarthi --- Depends-on: series-26198 ("implementation of ML common code") MAINTAI

[PATCH v3 02/38] ml/cnxk: add skeleton for ML cnxk driver

2022-12-20 Thread Srikanth Yalavarthi
Added initial source files and build files for ML cnxk driver. Signed-off-by: Srikanth Yalavarthi --- MAINTAINERS| 2 ++ drivers/meson.build| 1 + drivers/ml/cnxk/cn10k_ml_dev.c | 8 drivers/ml/cnxk/cn10k_ml_dev.h | 8 drivers/ml/cnxk/meson.b

[PATCH v3 03/38] ml/cnxk: enable probe and remove of ML device

2022-12-20 Thread Srikanth Yalavarthi
ML inference engine on cn10k platform is a PCI based device. Added driver support to probe and remove the device for cn10k poll mode driver. The device is named by the PMD as "ml_cn10k". Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 114 +

[PATCH v3 04/38] ml/cnxk: add driver support to get device info

2022-12-20 Thread Srikanth Yalavarthi
Added support to get the cn10k ML device information. This is a driver implementation for the RTE function rte_ml_dev_info_get. ML device on cn10k supports one queue-pair in lock-free mode and does not support segmented input output data. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn

[PATCH v3 06/38] ml/cnxk: parse ML firmware path from device args

2022-12-20 Thread Srikanth Yalavarthi
Enabled parsing ML firmware path for cn10k. Default path is set as "/lib/firmware/mlip-fw.bin", when args are not provided. Added internal structures for ML firmware. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 71 ++ drivers/ml/cnxk/cn

[PATCH v3 05/38] ml/cnxk: add support for configure and close

2022-12-20 Thread Srikanth Yalavarthi
Implemented driver functions to configure and close ML devices. Added skeleton code and support to reconfigure ML device. PCI device remove is enabled in device close. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 2 ++ drivers/ml/cnxk/cn10k_ml_dev.h | 21

[PATCH v3 08/38] ml/cnxk: enable support for simulator environment

2022-12-20 Thread Srikanth Yalavarthi
Enabled device initialization and firmware load on simulator platform. Firmware load stage on simulator would involve launching a firmware handshake request only. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 119 + 1 file changed, 107 in

[PATCH v3 07/38] ml/cnxk: enable firmware load and device reset

2022-12-20 Thread Srikanth Yalavarthi
Enabled support to load ML firmware on cn10ka ROC model. Reset MLIP device during dev_close driver operation. Device can't be reconfigured after a call to close. Job execution is disabled after firmware load, execution is enabled in device start state. Added internal request structure. Signed-off-

[PATCH v3 09/38] ml/cnxk: enable support for device start and stop

2022-12-20 Thread Srikanth Yalavarthi
Implemented ML driver functions to start and stop ML device. Start / Stop would enable or disable ML device to accept inference requests. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-

[PATCH v3 12/38] ml/cnxk: enable validity checks for model metadata

2022-12-20 Thread Srikanth Yalavarthi
Added model metadata structure and enabled metadata check during model load. Remap cnxk IO types with RTE IO types. Store and update model metadata in model structure. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 196 +++ drivers/ml/cnxk/cn10k_ml_mode

[PATCH v3 10/38] ml/cnxk: add support to create device queue-pairs

2022-12-20 Thread Srikanth Yalavarthi
Enabled support to create and destroy device queue-pairs. Updated configure stage to create array to store queue-pair handles. Added internal structure for queue-pair, queue and ML inference requests. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 207 +++

[PATCH v3 11/38] ml/cnxk: add functions to load and unload models

2022-12-20 Thread Srikanth Yalavarthi
Added cnxk driver implementations to load and unload ML models. Enabled support in configure stage to allocate model handles array. Assign model ID and allocate resources per each model during load stage and release resources during model unload. Added internal structures to handle ML models. Sign

[PATCH v3 13/38] ml/cnxk: add internal structures for derived info

2022-12-20 Thread Srikanth Yalavarthi
Added internal structures to handle derived address fields and enabled support to compute DMA addresses for model start. Enabled updating internal model fields. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 88 drivers/ml/cnxk/cn10k_ml

[PATCH v3 14/38] ml/cnxk: add internal structures for tiles and OCM

2022-12-20 Thread Srikanth Yalavarthi
Added internal structures to handle tile and OCM information and OCM to model memory mapping. Initialize the fields to platform specific defaults and compute the OCM / tile requirements for model. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 5 ++ drivers/ml/cnxk/cn

[PATCH v3 15/38] ml/cnxk: add structures for slow and fast path JDs

2022-12-20 Thread Srikanth Yalavarthi
Added JD structures for load, unload and run jobs. Initialize job command and allocate memory for request structures for slow path jobs. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 99 drivers/ml/cnxk/cn10k_ml_model.h | 4 ++ driver

[PATCH v3 16/38] ml/cnxk: find OCM mask and page slots for a model

2022-12-20 Thread Srikanth Yalavarthi
Added support to compute OCM tilemask and page start for a model. The computed tilemask and page start are used during model start to copy model weights and bias to OCM. OCM slot for a model is allocated from the tiles with maximum amount of free memory. Signed-off-by: Srikanth Yalavarthi --- dr

[PATCH v3 18/38] ml/cnxk: enable support to start an ML model

2022-12-20 Thread Srikanth Yalavarthi
Implemented model start driver function. A model start job is checked for completion in synchronous mode. Tilemask and OCM slot is calculated before starting the model. Model start is enqueued through scratch registers. OCM pages are reserved after model start completion. Signed-off-by: Srikanth

[PATCH v3 17/38] ml/cnxk: add support to reserve and free OCM pages

2022-12-20 Thread Srikanth Yalavarthi
Added support to reserve and free OCM pages for a model. OCM pages are reserved upon completion of model start and are released after model stop. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 131 - drivers/ml/cnxk/cn10k_ml_ocm.h | 3 +

[PATCH v3 19/38] ml/cnxk: enable support to stop an ML models

2022-12-20 Thread Srikanth Yalavarthi
Implemented model stop driver function. A model stop job is enqueued through scratch registers and is checked for completion through polling in a synchronous mode. OCM pages are released after model stop completion. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 115

[PATCH v3 20/38] ml/cnxk: enable support to get model information

2022-12-20 Thread Srikanth Yalavarthi
Added driver functions to get model information. Added internal functions to set and get model info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 55 drivers/ml/cnxk/cn10k_ml_model.h | 9 ++ drivers/ml/cnxk/cn10k_ml_ops.c | 37

[PATCH v3 21/38] ml/cnxk: enable support to update model params

2022-12-20 Thread Srikanth Yalavarthi
Added cnxk driver functions to update model params or weights and bias after a models is loaded. Updating model params would not require reloading the model. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 31 +++ 1 file changed, 31 insertions(

[PATCH v3 22/38] ml/cnxk: add support to get IO buffer sizes

2022-12-20 Thread Srikanth Yalavarthi
Added driver functions to get input and output buffer sizes for a given batch size. This function would compute the buffer size based on specific requirements of the device. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 52 ++ 1 file chan

[PATCH v3 23/38] ml/cnxk: enable quantization and dequantization

2022-12-20 Thread Srikanth Yalavarthi
Implemented driver functions to quantize / dequantize input and output data. Support is enabled for multiple batches. Quantization / dequantization use the type conversion functions defined in ML common code. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 150 +++

[PATCH v3 26/38] ml/cnxk: enqueue a burst of inference requests

2022-12-20 Thread Srikanth Yalavarthi
Enabled driver support to enqueue a burst of inference requests to ML device. Enqueue uses internal ML request structure to queue the inferences and job completion through polling. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 96 ++ driv

[PATCH v3 24/38] ml/cnxk: enable support to dump device debug info

2022-12-20 Thread Srikanth Yalavarthi
Added support to dump device debug information. Debug info on cn10k device includes model state info, OCM usage info, firmware debug and exception buffer. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 51 + drivers/ml/cnxk/cn10k_ml_ocm.h | 1 + drivers/ml/cnx

[PATCH v3 25/38] ml/cnxk: add driver support for device selftest

2022-12-20 Thread Srikanth Yalavarthi
Added support for device selftest. Device selftest includes checking the status of firmware. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 57 ++ 1 file changed, 57 insertions(+) diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/c

[PATCH v3 27/38] ml/cnxk: dequeue a burst of inference requests

2022-12-20 Thread Srikanth Yalavarthi
Enabled driver support to dequeue inference requests from internal queue. Dequeue checks for request completion by polling the status field of the job request. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 61 ++ drivers/ml/cnxk/cn10k_ml_

[PATCH v3 28/38] ml/cnxk: add internal function for sync mode run

2022-12-20 Thread Srikanth Yalavarthi
Added internal function to execute ML inference requests in synchronous mode. Sync mode inference execution is used to launch inference requests without using a queue-pair. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 53 ++ drivers/ml/c

[PATCH v3 29/38] ml/cnxk: enable support for firmware error codes

2022-12-20 Thread Srikanth Yalavarthi
Enabled support for error handling. Added error types and subtypes supported by ML firmware. Enabled support to get device specific error code and message for a completed ML request. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 4 +- drivers/ml/cnxk/cn10k_ml_dev.h |

[PATCH v3 30/38] ml/cnxk: add support to get and reset device stats

2022-12-20 Thread Srikanth Yalavarthi
Enabled support to get and reset ML device stats. Device stats include number of requests enqueued/dequeued and error count. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 55 -- drivers/ml/cnxk/cn10k_ml_ops.h | 3 ++ 2 files changed, 55

[PATCH v3 31/38] ml/cnxk: add support to handle extended dev stats

2022-12-20 Thread Srikanth Yalavarthi
Added support to handle ML device extended stats. Support is enabled to get xstats names and stats values and reset xstats. Supported xstats include avg, min and max hardware and firmware latency. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 3 + drivers/ml/cnxk/cn

[PATCH v3 32/38] ml/cnxk: enable support to get xstats in cycles

2022-12-20 Thread Srikanth Yalavarthi
Enabled support to retrieve xstats in either cycles or ns. Access to sclk is enabled only if an RVU device is probed during initialization. Driver would return the xstats in nanoseconds only when an RVU device is probed, else would fallback to cycles. Signed-off-by: Srikanth Yalavarthi --- drive

[PATCH v3 33/38] ml/cnxk: add support to report DPE FW warnings

2022-12-20 Thread Srikanth Yalavarthi
Enabled support to enable and report DPE warnings from ML firmware. Configure firmware load flags based on the device arguments. Default values: enable_dpe_errors = 1 report_dpe_errors = 0 Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 94 +++

[PATCH v3 34/38] ml/cnxk: add support to enable model data caching

2022-12-20 Thread Srikanth Yalavarthi
Added device argument 'cache_model_data' to enable model data caching. An inference request would be executed with dummy data in synchronous mode during model start stage. This run would cache the model weights and bias in the memory and result in improved inference throughput. cache_model_data =

[PATCH v3 36/38] ml/cnxk: add support to use lock during jcmd enq

2022-12-20 Thread Srikanth Yalavarthi
Added device argument "hw_queue_lock" to select the JCMDQ enqueue ROC function to be used in fast path. hw_queue_lock: 0: Disable, use lock free version of JCMDQ enqueue ROC function for job queuing. To avoid race condition in request queuing to hardware, disabling hw_queue_lock

[PATCH v3 35/38] ml/cnxk: add support to select OCM allocation mode

2022-12-20 Thread Srikanth Yalavarthi
Added device argument "ocm_alloc_mode" to select OCM allocation method during model start. Two modes are supported by the driver. Added implementation for ocm_alloc_mode lowest as default. ocm_alloc_mode: lowest: Allocate from first available free slot / lowest tile ID in OCM (default)

[PATCH v3 37/38] ml/cnxk: add support to select poll memory region

2022-12-20 Thread Srikanth Yalavarthi
Added device argument "poll_mem" to select the memory region to be used for polling in fast-path requests. Implemented support to use scratch registers for polling. Available pool of scratch registers one-to-one mapped with the internal request queue. poll_mem: ddr: Use DDR memory location f

[PATCH v3 38/38] ml/cnxk: add user guide for marvell cnxk ml driver

2022-12-20 Thread Srikanth Yalavarthi
Added user guide for Marvell cnxk ML driver for Marvell Octeon cnxk Soc family. Added details about device initialization, debug options and runtime device args supported by the driver. Signed-off-by: Srikanth Yalavarthi --- MAINTAINERS | 1 + doc/guides/index.rst| 1

[PATCH v4 1/2] ethdev: control Rx metadata negotiation

2022-12-20 Thread Hanumanth Pothula
Presently, Rx metadata is sent to PMD by default, leading to a performance drop as processing for the same in Rx path takes extra cycles. Hence, adding a new eth port configuration filed, 'nic_to_pmd_rx_metadata', to control NIC to PMD Rx metadata negotiation. Also, reset dev_configured flag as p

[PATCH v4 2/2] app/testpmd: add command to process Rx metadata negotiation

2022-12-20 Thread Hanumanth Pothula
Presently, Rx metadata is sent to PMD by default, leading to a performance drop as processing for the same in Rx path takes extra cycles. Hence, add new testpmd command, 'enable port nic_to_pmd_rx_metadata' This command helps in sending Rx metadata to PMD and thereby Rx metadata flow command r

Re: [PATCH v4 2/2] app/testpmd: add command to process Rx metadata negotiation

2022-12-20 Thread Stephen Hemminger
On Wed, 21 Dec 2022 01:32:50 +0530 Hanumanth Pothula wrote: > @@ -12851,6 +12908,7 @@ static cmdline_parse_ctx_t builtin_ctx[] = { > (cmdline_parse_inst_t *)&cmd_show_capability, > (cmdline_parse_inst_t *)&cmd_set_flex_is_pattern, > (cmdline_parse_inst_t *)&cmd_set_flex_spec_pat

[PATCH v5 1/2] ethdev: fix ethdev configuration state on reset

2022-12-20 Thread Hanumanth Pothula
Presently, on device reset, ethdev configuration state, dev_configured, is not reset. On device reset, reset ethdev configuration state to make sure device reconfiguration happens cleanly. Signed-off-by: Hanumanth Pothula --- v5: - Move nic-to-pmd-rx-metadata declaration to struct rte_port. v4:

[PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2022-12-20 Thread Hanumanth Pothula
Presently, Rx metadata is sent to PMD by default, leading to a performance drop as processing for the same in Rx path takes extra cycles. Hence, add new testpmd command, 'enable port nic_to_pmd_rx_metadata' This command helps in sending Rx metadata to PMD and thereby Rx metadata flow command r

[PATCH v1 1/2] net/axgbe: add multi-process support

2022-12-20 Thread Jesna K E
Added multi-process support for axgbe PMD To achieve multi-process support separate out TX and RX function inside the axgbe driver and call that from a secondary process when it is attaching to an already-configured NIC Signed-off-by: Jesna K E --- doc/guides/nics/features/axgbe.ini | 1 + driv

[PATCH v1 2/2] net/axgbe: move offloads to Rx/Tx queue setup

2022-12-20 Thread Jesna K E
For Multiprocess dpdk applications retrieving the offload parameter for receive packet directly from struct eth_dev giving segmentation fault since rxmode.offloads from eth_dev was null duirng recv_pkts. So retrieved offload from rx/tx_queue_setup() Signed-off-by: Jesna K E --- drivers/net/axgbe

[Bug 1155] DPDK 22.07 RTE flow: Segmentation fault seen in i40e_flow_parse_fdir_filter() for raw item type

2022-12-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1155 Bug ID: 1155 Summary: DPDK 22.07 RTE flow: Segmentation fault seen in i40e_flow_parse_fdir_filter() for raw item type Product: DPDK Version: 22.07 Hardware: x86 OS:

[PATCH v1 2/2] net/axgbe: move offloads to Rx/Tx queue setup

2022-12-20 Thread Jesna K E
For Multiprocess dpdk applications retrieving the offload parameter for receive packet directly from struct eth_dev giving segmentation fault since rxmode.offloads from eth_dev was null duirng recv_pkts. So retrieved offload from rx/tx_queue_setup() Signed-off-by: Jesna K E --- drivers/net/axgbe

  1   2   >