> -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: 21 December 2022 00:37 > To: Srikanth Yalavarthi <syalavar...@marvell.com> > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > <sshankarn...@marvell.com>; Jerin Jacob Kollanukkaran > <jer...@marvell.com>; Anup Prabhu <apra...@marvell.com> > Subject: [EXT] Re: [PATCH v3 0/4] implementation of ML common code > > External Email > > ---------------------------------------------------------------------- > On Tue, 20 Dec 2022 09:52:52 -0800 > Srikanth Yalavarthi <syalavar...@marvell.com> wrote: > > > Machine Learning common code > > ---------------------------- > > > > This patch series implements the common ML code that can be used by ML > > drivers. Common code include functions to convert ML IO type to > > string, IO format type to string, function get size of ML IO type, and > > functions for converting data types from higher precision to lower > > precision and vice-versa. > > > > Data type conversion functions support handling float32, float16, > > bfloat16, uint8, int8, uint16 and int16. Two versions of conversion > > functions are implemented in the series, generic scalar version and > > vector version using Arm NEON intrinsics. When compiling DPDK for > > platform supporting Arm NEON, vector NEON version of the routines > > would be enabled. Compilation would fall back to generic scalar > > versions on platform like x86_64 / PowerPC etc., that don't support Arm > NEON. > > > > > > Srikanth Yalavarthi (4): > > common/ml: add initial files for ML common code > > common/ml: add common utility functions > > common/ml: add scalar type conversion functions > > common/ml: add Arm NEON type conversion routines > > > Ok, but much more is needed. > > Where is the documentation? Documentation related to the functions is part of the header files. Doxygen documentation is not added as the functions / macros part of common/ml is non RTE code.
> Where are the tests? > Where is an example? We don't intend to implement unit tests or examples for the common/ml code as it is intended for driver use only. > > Need a driver that uses it ml/cnxk driver uses the functions part of common/ml code. Driver is pushed as part of a separate patch series http://patches.dpdk.org/project/dpdk/list/?series=26050 http://patches.dpdk.org/project/dpdk/patch/20221208201806.21893-23-syalavar...@marvell.com/
