On Wed, 9 Nov 2022 22:46:55 +0100
Mattias Rönnblom wrote:
> On 2022-11-09 05:10, Stephen Hemminger wrote:
> > Do a clean shutdown of testpmd when a signal is received;
> > instead of having testpmd kill itself.
> > This fixes problem where a signal could be received
> > in the middle of a PMD and
The DPDK standard now enforced through checkpatch is to use
a space after keywords. Much of the older code that was grandfathered
in doesn't follow that, so fix it.
No urgency to this patchset, and it might just be viewed as churn.
But I prefer to read code that looks all the same.
“A foolish con
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
lib/eal/include/generic/rte_cycles.h | 4 ++--
lib/eal/linux/eal_hugepage_info.c| 6 +++---
lib/eal/linux/eal_interrupts.c | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/eal/include/generic/rte_c
Add space after keywords.
Remove unnecessary spaces in if expressions.
Signed-off-by: Stephen Hemminger
---
lib/cmdline/cmdline_parse_string.c | 17 +++--
lib/cmdline/cmdline_rdline.c | 12 ++--
2 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/lib/cmdlin
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
lib/timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c
index 85d67573eb9e..9eb73f1fed13 100644
--- a/lib/timer/rte_timer.c
+++ b/lib/timer/rte_timer.c
@
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
lib/ip_frag/rte_ipv4_reassembly.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ip_frag/rte_ipv4_reassembly.c
b/lib/ip_frag/rte_ipv4_reassembly.c
index 4a89a5f5365a..88ee0aa63f62 100644
--- a/lib/ip_frag/rt
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
app/test-pmd/cmdline.c| 31 ---
app/test-pmd/parameters.c | 10 ++
app/test-pmd/testpmd.c| 2 +-
3 files changed, 23 insertions(+), 20 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/a
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
app/test/test_cmdline_cirbuf.c | 4 ++--
app/test/test_debug.c | 4 ++--
app/test/test_hash.c | 6 +++---
app/test/test_lpm6_perf.c | 2 +-
app/test/test_malloc.c | 14 +++---
app/test/test
Add space after keywords.
Acked-by: Cristian Dumitrescu
Signed-off-by: Stephen Hemminger
---
examples/qos_sched/app_thread.c | 6 +++---
examples/qos_sched/args.c | 2 +-
examples/qos_sched/init.c | 2 +-
examples/qos_sched/main.c | 4 ++--
4 files changed, 7 insertions(+), 7
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
examples/vhost/main.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 42e53a0f9a4f..9fee966916e9 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/m
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
examples/l3fwd-power/main.c | 7 ---
examples/l3fwd/main.c | 7 ---
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index fd3ade330f82..7bd5d8cb22
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
examples/cmdline/parse_obj_list.c | 2 +-
examples/ip_reassembly/main.c | 2 +-
examples/multi_process/symmetric_mp/main.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/examples/cmdl
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
drivers/bus/pci/bsd/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c
index 7459d15c7e31..056e2eda2d5f 100644
--- a/drivers/bus/pci/bsd/pci.c
+++ b/drivers
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
drivers/net/i40e/i40e_pf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c
index 15d9ff868f3a..7050e0057d8e 100644
--- a/drivers/net/i40e/i40e_pf.c
+
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
drivers/net/e1000/em_ethdev.c | 4 ++--
drivers/net/e1000/igb_ethdev.c | 8
drivers/net/e1000/igb_pf.c | 2 +-
drivers/net/e1000/igb_rxtx.c | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/driver
Add space after keywords.
Signed-off-by: Stephen Hemminger
---
drivers/net/bnx2x/bnx2x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
index 89414ac88a93..9cb927e25449 100644
--- a/drivers/net/bnx2x/bnx2x.h
+++ b/drivers
This patch set is from running the null_free coccinelle
script on the current main branch.
Stephen Hemminger (4):
gve: remove unnecessary null checks
mlx5: remove unnecessary null checks
idpf: remove unnecessary null checks
examples: remove unnecessary null checks
drivers/net/gve/gve_eth
The function rte_free() already handles NULL argument;
therefore the checks in this code are unnecessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/gve/gve_ethdev.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve
The function rte_free() already handles NULL argument;
therefore the checks in this code are unnecessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/mlx5/hws/mlx5dr_pool.c | 3 +--
drivers/net/mlx5/mlx5_flow_hw.c| 6 ++
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a
The function rte_free() already handles NULL argument;
therefore the checks in this code are unnecessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/idpf/idpf_rxtx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_r
The function rte_free() already handles NULL argument;
therefore the checks in this code are unnecessary.
Signed-off-by: Stephen Hemminger
---
examples/distributor/main.c | 3 +--
examples/fips_validation/main.c | 15 +--
2 files changed, 6 insertions(+), 12 deletions(-)
diff -
https://bugs.dpdk.org/show_bug.cgi?id=1087
jinag (853048...@qq.com) changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|---
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, November 10, 2022 7:25 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Maxime Coquelin
> ; Xia, Chenbo
> Subject: [PATCH v3 08/14] examples/vhost: fix whitespace
>
> Add space after keywords.
>
> Signed-off-by: Stephen Hem
Hi Kim,
> -Original Message-
> From: Taekyung Kim
> Sent: Tuesday, November 8, 2022 4:56 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo ; Pei, Andy ;
> kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpdk.org;
> Wang, Xiao W
> Subject: [PATCH v4] vdpa/ifc: fix update_datapath er
> -Original Message-
> From: Mingjin Ye
> Sent: Wednesday, November 9, 2022 8:56 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX
> ; Ye, MingjinX ; Zhang, Qi
> Z ; Lu, Wenzhuo ; Wu,
> Jingjing ; Li, Xiaoyun ; Ferruh
> Yigit
> Subject: [PATCH v2] net/ice: fix scal
> > Subject: [PATCH v3] net/iavf: revert fix VLAN insertion
> >
> > The vector Tx path does not support VLAN insertion via the L2TAG2
> > field, but the scalar path supports. The previous commit was to force
> > to select scalar path as soon as kernel driver requests to use L2TAG2.
>
> In which si
If HW Steering is enabled, Rx queues were configured to receive MARKs
when a table with MARK actions was created. After stopping the port,
Rx queue configuration is released, but during starting the port
the mark flag was not updated in the Rx queue configuration.
This patch introduces a reference
Hi, Qi
I will prepare v2 as this patch have one typo.
Qiming
> -Original Message-
> From: Yang, Qiming
> Sent: Wednesday, November 9, 2022 9:47 AM
> To: dev@dpdk.org; Zhang, Qi Z
> Cc: Yang, Qiming
> Subject: [PATCH] doc: update matching list for i40e and ice driver
>
> Add recommended
For NIC I40E_10G-10G_BASE_T_X722, when the port is configured with
link speed, it cannot receive jumbo frame packets.
Because it set maximum frame size failed when starts the port that
the port link status is still down.
This patch fix the error that starts the port will force set maximum
frame s
On Thu, Nov 10, 2022 at 01:53:50AM +, Xia, Chenbo wrote:
> Hi Kim,
>
> > -Original Message-
> > From: Taekyung Kim
> > Sent: Tuesday, November 8, 2022 4:56 PM
> > To: dev@dpdk.org
> > Cc: Xia, Chenbo ; Pei, Andy ;
> > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpd
Stop and return the error code when update_datapath fails.
update_datapath prepares resources for the vdpa device.
The driver should not perform any further actions
if update_datapath returns an error.
Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc: sta...@dpdk.org
Signed-off-by: Tae
https://bugs.dpdk.org/show_bug.cgi?id=747
jiang,yu (yux.ji...@intel.com) changed:
What|Removed |Added
Resolution|--- |WONTFIX
Status|CONFIR
Update Broadcom NIC documentation.
Signed-off-by: Ajit Khaparde
Reviewed-by: Kalesh AP
---
v1->v2:
Updated commit message & incorrect information in the documentation.
---
doc/guides/nics/bnxt.rst | 477 +++
1 file changed, 283 insertions(+), 194 deletions(-
On Wed, Nov 9, 2022 at 8:55 PM Ajit Khaparde wrote:
>
> Update Broadcom NIC documentation.
>
> Signed-off-by: Ajit Khaparde
> Reviewed-by: Kalesh AP
>
> ---
> v1->v2:
> Updated commit message & incorrect information in the documentation.
> ---
> doc/guides/nics/bnxt.rst | 477 ++
Hi All,
Update the test status for Intel part. Till now dpdk22.11-rc2 test is almost
finished. No new critical issue is found.
Known Critical bug: [22.11-rc1]iavf macfwd performance drop 40%, Intel dev has
reverted the patch, but no acked-by.
Meson test bugs:
1, https://bugs.dpdk.org/show_bug.
> -Original Message-
> From: Jie Wang
> Sent: 2022年11月10日 11:45
> To: dev@dpdk.org
> Cc: Yang, SteveX ; Zhang, Qi Z
> ; Yang, Qiming ; Xing, Beilei
> ; Zhang, Yuying ; Wang,
> Jie1X ; sta...@dpdk.org
> Subject: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets
>
> For NIC I40E_1
> -Original Message-
> From: Taekyung Kim
> Sent: Thursday, November 10, 2022 12:10 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo ; Pei, Andy ;
> kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpdk.org;
> Wang, Xiao W
> Subject: [PATCH v5] vdpa/ifc: fix update_datapath error ha
On 11/9/22 13:39, Andrew Rybchenko wrote:
On 11/9/22 11:04, Singh, Aman Deep wrote:
On 11/7/2022 11:01 AM, Hanumanth Pothula wrote:
Some of the HW has support for choosing memory pools based on
the packet's size. The pool sort capability allows PMD/NIC to
choose a memory pool based on the packe
On 11/9/22 04:37, Yuan Wang wrote:
The "show config rxhdrs" cmd displays the configured protocol headers
that are used for protocol-based buffer split.
However, it shows inner-ipv6 as inner-ipv4.
This patch fixes that by redefining rx_pkt_hdr_protos to hold
the full ptypes, and the show and set
Currently there's limitation for Drop action that can only co-exist with
Count action.
Sample and Age actions are also able to exist with Drop within the same
flow, and this patch includes them in the Drop action validation.
Fixes: acb67cc8 ("net/mlx5: fix action flag data type")
Cc: sta...@dpdk.
> -Original Message-
> From: Maheshwari, Abhishek
> Sent: Thursday, November 3, 2022 5:35 PM
> To: maxime.coque...@redhat.com; Wang, Xiao W
> Cc: dev@dpdk.org; sta...@dpdk.org; Xia, Chenbo ;
> Mandal, Purna Chandra ; Maheshwari,
> Abhishek
> Subject: [PATCH v5] vdpa/ifc/base: wait for qu
> -Original Message-
> From: Taekyung Kim
> Sent: Thursday, November 10, 2022 12:10 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo ; Pei, Andy ;
> kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpdk.org;
> Wang, Xiao W
> Subject: [PATCH v5] vdpa/ifc: fix update_datapath error ha
On 11/9/22 20:29, Stephen Hemminger wrote:
Do a clean shutdown of testpmd when a signal is received;
instead of having testpmd kill itself.
This fixes problem where a signal could be received
in the middle of a PMD and then the signal handler would call
PMD's close routine which could cause a dea
tainted_data_downcast: Downcasting match_item->meta from void * to
struct virtchnl_proto_hdrs implies that the data that this pointer points
to is tainted.
var_assign_var: Assigning: proto_hdrs = match_item->meta.
Both are now tainted.
var_assign_var: Assigning: rss_meta->proto_hdrs = *proto_hdrs
Hi Andrew,
> -Original Message-
> From: Andrew Rybchenko
> Sent: Thursday, November 10, 2022 2:56 PM
> To: Wang, YuanX ; Singh, Aman Deep
> ; Zhang, Yuying
> Cc: Ding, Xuan ; Tang, Yaqi ;
> dev@dpdk.org
> Subject: Re: [PATCH v4] app/testpmd: fix protocol header display for Rx
> buffer sp
On 2022-11-09 23:53, Stephen Hemminger wrote:
On Wed, 9 Nov 2022 22:46:55 +0100
Mattias Rönnblom wrote:
On 2022-11-09 05:10, Stephen Hemminger wrote:
Do a clean shutdown of testpmd when a signal is received;
instead of having testpmd kill itself.
This fixes problem where a signal could be rec
101 - 146 of 146 matches
Mail list logo
