The function rte_free() already handles NULL argument;
therefore the checks in this code are unnecessary.

Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
---
 drivers/net/mlx5/hws/mlx5dr_pool.c | 3 +--
 drivers/net/mlx5/mlx5_flow_hw.c    | 6 ++----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mlx5/hws/mlx5dr_pool.c 
b/drivers/net/mlx5/hws/mlx5dr_pool.c
index 2bfda5b4a5be..fdbd3d438d08 100644
--- a/drivers/net/mlx5/hws/mlx5dr_pool.c
+++ b/drivers/net/mlx5/hws/mlx5dr_pool.c
@@ -537,8 +537,7 @@ static void mlx5dr_onesize_element_db_uninit(struct 
mlx5dr_pool *pool)
        for (i = 0; i < MLX5DR_POOL_RESOURCE_ARR_SZ; i++) {
                elem = pool->db.element_manager->elements[i];
                if (elem) {
-                       if (elem->bitmap)
-                               rte_free(elem->bitmap);
+                       rte_free(elem->bitmap);
                        simple_free(elem);
                        pool->db.element_manager->elements[i] = NULL;
                }
diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
index 2d275ad11127..bea7805ee267 100644
--- a/drivers/net/mlx5/mlx5_flow_hw.c
+++ b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -7063,10 +7063,8 @@ flow_hw_configure(struct rte_eth_dev *dev,
        if (dr_ctx)
                claim_zero(mlx5dr_context_close(dr_ctx));
        for (i = 0; i < nb_q_updated; i++) {
-               if (priv->hw_q[i].indir_iq)
-                       rte_ring_free(priv->hw_q[i].indir_iq);
-               if (priv->hw_q[i].indir_cq)
-                       rte_ring_free(priv->hw_q[i].indir_cq);
+               rte_ring_free(priv->hw_q[i].indir_iq);
+               rte_ring_free(priv->hw_q[i].indir_cq);
        }
        mlx5_free(priv->hw_q);
        priv->hw_q = NULL;
-- 
2.35.1

Reply via email to