[Bug 1096] lib/member build failure with gcc 5.4.0

2022-10-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1096 Bug ID: 1096 Summary: lib/member build failure with gcc 5.4.0 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH v2] net/iavf: support raw packet for flow subscription

2022-10-10 Thread Jie Wang
Add Protocol Agnostic Flow (raw flow) support for flow subscription in AVF. For example, testpmd creates a flow subscription raw packet rule: rule: eth + ipv4 src is 1.1.1.1 dst is 2.2.2.2 cmd: flow create 0 ingress pattern raw pattern spec \ 0800451401

Re: [PATCH v5 0/2] introduce NitroSketch Mode into membership library

2022-10-10 Thread Thomas Monjalon
10/10/2022 04:36, Rong, Leyi: > From: Thomas Monjalon > > 16/09/2022 05:03, Leyi Rong: > > > This patchset introduce a brand new NitroSketch Mode into membership > > > library. This algorithm provides high-fidelity approximate > > > measurements and appears as a promissing alternative to tridition

RE: [PATCH] eal: non-temporal memcpy

2022-10-10 Thread Morten Brørup
Mattias, Konstantin, Honnappa, Stephen, In my patch for non-temporal memcpy, I have been aiming for using as much non-temporal store as possible. E.g. copying 16 byte to a 16 byte aligned address will be done using non-temporal store instructions. Now, I am seriously considering this alternativ

Re: [EXT] [PATCH v12 0/7] bbdev changes for 22.11

2022-10-10 Thread Thomas Monjalon
06/10/2022 19:31, Akhil Goyal: > There were many formatting issues in this patch. This has been a practice in > whole of bbdev. > Please take a diff of what is applied on the tree and what was submitted to > take care of the > formatting in future patches and please plan to fix the rest of bbdev

Re: [PATCH 1/2] drivers: suggestion on meson without version file

2022-10-10 Thread Omer Yamac
On 07.10.2022 13:30, Bruce Richardson wrote: The title of this patch needs an update - I would suggest something like: "build: make version file optional for drivers" Thank you, it will make more sense More comments inline below. On Thu, Oct 06, 2022 at 10:19:22AM +0300, Abdullah Ömer Yam

Re: [PATCH v2] build: increase minimum meson version to 0.53.2

2022-10-10 Thread David Marchand
On Mon, Oct 10, 2022 at 7:23 AM Tu, Lijuan wrote: > > It seems the "intel-Testing" test is in ... berserk mode and spewing errors > > for all > > patches since 10/03. > > No clue if we have an issue in the main branch, and this test logs are > > useless. > > > > I'll wait for Intel PRC to be bac

RE: [PATCH v2 03/14] net/idpf: add support for device initialization

2022-10-10 Thread Wu, Wenjun1
> -Original Message- > From: Junfeng Guo > Sent: Monday, September 5, 2022 6:58 PM > To: Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Guo, Junfeng > ; Li, Xiaoyun > Subject: [PATCH v2 03/14] net/idpf: add support for device initialization > > Support

Re: [PATCH v2] buildtools: ensure the NUMA nodes are counted correct

2022-10-10 Thread Niklas Söderlund
Hi, Genteel ping on this. On 2022-09-22 10:06:42 +0200, Niklas Söderlund wrote: > From: Peng Zhang > > The method to fetch, sort and read the last entry of a list to figure > out the total number of NUMA nodes in the system fails with 10 or more > nodes. The reason being the usage of string com

RE: [PATCH v2 14/14] net/idpf: add support for timestamp offload

2022-10-10 Thread Wu, Wenjun1
> -Original Message- > From: Junfeng Guo > Sent: Monday, September 5, 2022 6:58 PM > To: Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Guo, Junfeng > ; Qiao, Wenjing > Subject: [PATCH v2 14/14] net/idpf: add support for timestamp offload > > Add suppo

RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-10 Thread Akhil Goyal
Hi Zhangfei, I see below compilation error after executing the steps mentioned in UADK README. It would be better if you could add compilation steps for UADK in uadk.rst as well. gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make make all-recursive make[1]: Entering directory '/home/gakhil/up/u

Re: [PATCH 1/2] mempool: make event callbacks process-private

2022-10-10 Thread Andrew Rybchenko
On 8/28/22 21:33, Slava Ovsiienko wrote: -Original Message- From: Dmitry Kozlyuk Sent: Monday, August 8, 2022 12:43 To: dev@dpdk.org Cc: Olivier Matz ; Andrew Rybchenko ; sta...@dpdk.org Subject: [PATCH 1/2] mempool: make event callbacks process-private Callbacks for mempool events were

RE: [PATCH v2 13/14] net/idpf: add AVX512 data path for single queue model

2022-10-10 Thread Wu, Wenjun1
> -Original Message- > From: Guo, Junfeng > Sent: Monday, September 5, 2022 6:58 PM > To: Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Guo, Junfeng > ; Wu, Wenjun1 > Subject: [PATCH v2 13/14] net/idpf: add AVX512 data path for single queue > model >

Re: [PATCH] net/mana: fix dependencies

2022-10-10 Thread Ferruh Yigit
On 10/9/2022 3:03 PM, Thomas Monjalon wrote: Long, For the reasons below, we should not have merged the MANA PMD in DPDK 22.11. We must not assume dependencies until they are upstream. This is a red flag on the PMD, a revert is possible. I missed that dependencies are not ready :( What do yo

[PATCH] member: fix build failure with GCC 5.4.0

2022-10-10 Thread Leyi Rong
This patch fixes the build failure by typecasting to match _mm512_i32gather_epi64() definition. Bugzilla ID: 1096 Fixes: db354bd2e1f8 ("member: add NitroSketch mode") Signed-off-by: Leyi Rong --- lib/member/rte_member_sketch_avx512.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

RE: [PATCH v5 0/2] introduce NitroSketch Mode into membership library

2022-10-10 Thread Rong, Leyi
> -Original Message- > From: Thomas Monjalon > Sent: Monday, October 10, 2022 3:30 PM > To: Rong, Leyi > Cc: ferruh.yi...@xilinx.com; Richardson, Bruce ; > david.march...@redhat.com; suanmi...@nvidia.com; Wang, Yipeng1 > ; zaoxing...@gmail.com; Gobriel, Sameh > ; dev@dpdk.org > Subject:

Re: [PATCH 1/2] drivers: suggestion on meson without version file

2022-10-10 Thread Bruce Richardson
On Mon, Oct 10, 2022 at 10:41:57AM +0300, Omer Yamac wrote: > > > Beware that the shared_lib calls use both lk_deps and lk_args > > parameters, > > which are only set inside the "if" block you added. > > This will cause problems in that: > > 1. If the first driver doesn't have a version.map file,

Re: [PATCH v11 1/5] ethdev: support get port error handling mode

2022-10-10 Thread Andrew Rybchenko
On 10/9/22 12:10, Chengwen Feng wrote: This patch support gets port's error handling mode by rte_eth_dev_info_get() API. Just: "Add error handling mode to device info." Currently, the defined modes include: 1) NONE: it means no error handling modes are supported by this port. 2) PASSIVE: pas

RE: [PATCH] member: fix build failure with GCC 5.4.0

2022-10-10 Thread Ali Alnubani
> -Original Message- > From: Leyi Rong > Sent: Monday, October 10, 2022 11:23 AM > To: Ali Alnubani ; NBU-Contact-Thomas Monjalon > (EXTERNAL) > Cc: dev@dpdk.org; Leyi Rong > Subject: [PATCH] member: fix build failure with GCC 5.4.0 > > This patch fixes the build failure by typecasting

Re: [PATCH v11 1/5] ethdev: support get port error handling mode

2022-10-10 Thread Andrew Rybchenko
On 10/9/22 12:10, Chengwen Feng wrote: This patch support gets port's error handling mode by rte_eth_dev_info_get() API. Currently, the defined modes include: 1) NONE: it means no error handling modes are supported by this port. 2) PASSIVE: passive error handling, after the PMD detect that a res

Re: [PATCH v11 2/5] ethdev: support proactive error handling mode

2022-10-10 Thread Andrew Rybchenko
On 10/9/22 12:10, Chengwen Feng wrote: From: Kalesh AP Some PMDs (e.g. hns3) could detect hardware or firmware errors, and try to recover from the errors. In this process, the PMD sets the data path pointers to dummy functions (which will prevent the crash), and also make sure the control path

Re: [PATCH v10 00/13] preparation for the rte_flow offload of nfp PMD

2022-10-10 Thread Niklas Söderlund
Hi Ferruh, Thanks for your feedback. On 2022-10-05 17:52:14 +0100, Ferruh Yigit wrote: > > > > Series applied to dpdk-next-net/main, thanks. > > > > Ahh, this has a small conflict with other set [1], and other one is fix. > To keep fix patch backportable to stable trees, I will get that series

Re: [PATCH] eal: non-temporal memcpy

2022-10-10 Thread Mattias Rönnblom
On 2022-10-10 09:35, Morten Brørup wrote: Mattias, Konstantin, Honnappa, Stephen, In my patch for non-temporal memcpy, I have been aiming for using as much non-temporal store as possible. E.g. copying 16 byte to a 16 byte aligned address will be done using non-temporal store instructions. Now

RE: [PATCH v9 7/8] app/procinfo: support descriptor dump

2022-10-10 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > +static void > +nic_descriptor_display(uint16_t port_id, struct desc_param *desc, > +desc_dump_t desc_dump) > +{ > + static const char *nic_desc_border = "###"; > + uint16_t queue_id = desc->queue_id; > + uint16

Re: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-10 Thread Zhangfei Gao
On 2022/10/10 下午3:55, Akhil Goyal wrote: Hi Zhangfei, I see below compilation error after executing the steps mentioned in UADK README. It would be better if you could add compilation steps for UADK in uadk.rst as well. Sure Will add something like this Build & Install UADK on ARM -

RE: [PATCH] eal: non-temporal memcpy

2022-10-10 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Monday, 10 October 2022 10.59 > > On 2022-10-10 09:35, Morten Brørup wrote: > > Mattias, Konstantin, Honnappa, Stephen, > > > > In my patch for non-temporal memcpy, I have been aiming for using as > much non-temporal store as possible

RE: [PATCH v4 7/9] net/gve: add support for Rx/Tx

2022-10-10 Thread Li, Xiaoyun
Hi > -Original Message- > From: Guo, Junfeng > Sent: Sunday, October 9, 2022 10:15 > To: Ferruh Yigit ; Zhang, Qi Z > ; Wu, Jingjing > Cc: ferruh.yi...@xilinx.com; dev@dpdk.org; Li, Xiaoyun > ; awogbem...@google.com; Richardson, Bruce > ; Lin, Xueqin > Subject: RE: [PATCH v4 7/9] net/gv

Re: [PATCH v9 09/14] baseband/acc: add LTE processing functions

2022-10-10 Thread Maxime Coquelin
On 10/7/22 23:38, Nicolas Chautru wrote: From: Nic Chautru Added functions and capability for 4G FEC Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 851 +- 1 file changed, 846 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/ac

Re: [PATCH v9 10/14] baseband/acc: add support for FFT operations

2022-10-10 Thread Maxime Coquelin
On 10/7/22 23:38, Nicolas Chautru wrote: From: Nic Chautru Added functions and capability for FFT processing Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 240 +- 1 file changed, 238 insertions(+), 2 deletions(-) Reviewed-by: Maxime Co

Re: [PATCH v9 11/14] baseband/acc: support interrupt

2022-10-10 Thread Maxime Coquelin
On 10/7/22 23:38, Nicolas Chautru wrote: From: Nic Chautru Added support for capability and functions for MSI/MSI-X interrupt and underlying information ring. Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 302 +- 1 file changed, 299 inser

Re: [PATCH] eal: non-temporal memcpy

2022-10-10 Thread Bruce Richardson
On Mon, Oct 10, 2022 at 10:58:57AM +0200, Mattias Rönnblom wrote: > On 2022-10-10 09:35, Morten Brørup wrote: > > Mattias, Konstantin, Honnappa, Stephen, > > > > In my patch for non-temporal memcpy, I have been aiming for using as much > > non-temporal store as possible. E.g. copying 16 byte to a

RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-10 Thread Akhil Goyal
> > gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make > > make all-recursive > > make[1]: Entering directory '/home/gakhil/up/uadk' > > Making all in . > > make[2]: Entering directory '/home/gakhil/up/uadk' > > depbase=`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ > > /bin/bash ./libtool --t

Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function

2022-10-10 Thread Maxime Coquelin
On 10/7/22 23:38, Nicolas Chautru wrote: From: Nic Chautru Added configure function notably to configure the device from the PF within DPDK and bbdev-test (without external dependency). Signed-off-by: Nic Chautru Acked-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 71 ++

Re: [PATCH v9 14/14] baseband/acc: simplify meson dependency

2022-10-10 Thread Maxime Coquelin
On 10/7/22 23:38, Nicolas Chautru wrote: From: Nic Chautru Removed some of libraries from the external dependency captured in meson build file which are not required. Signed-off-by: Nic Chautru --- drivers/baseband/acc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function

2022-10-10 Thread Akhil Goyal
> > diff --git a/drivers/baseband/acc/version.map > b/drivers/baseband/acc/version.map > > index b4ff13e38f..27fbbe3de5 100644 > > --- a/drivers/baseband/acc/version.map > > +++ b/drivers/baseband/acc/version.map > > @@ -6,4 +6,5 @@ EXPERIMENTAL { > > global: > > > > rte_acc10x_configure; >

Re: [EXT] [PATCH v4] baseband/turbo_sw: remove Flexran SDK meson option

2022-10-10 Thread Thomas Monjalon
22/09/2022 18:40, Akhil Goyal: > Hi Thomas, > > Do you have more comments on this patch? > > > The related dependency to build the PMD based on the > > SDK libraries is now enabled through pkgconfig. > > > > Signed-off-by: Nicolas Chautru This patch looks OK. Thank you for switching to pkgconf

RE: [PATCH v4 7/9] net/gve: add support for Rx/Tx

2022-10-10 Thread Guo, Junfeng
Thanks Xiaoyun for helping explain, it helps a lot! > -Original Message- > From: Li, Xiaoyun > Sent: Monday, October 10, 2022 17:40 > To: Guo, Junfeng ; Ferruh Yigit > ; Zhang, Qi Z ; Wu, > Jingjing > Cc: ferruh.yi...@xilinx.com; dev@dpdk.org; awogbem...@google.com; > Richardson, Bruce ;

[PATCH v5 0/8] introduce GVE PMD

2022-10-10 Thread Junfeng Guo
Introduce a new PMD for Google Virtual Ethernet (GVE). This patch set requires an exception for MIT license for GVE base code. And the base code includes the following files: - gve_adminq.c - gve_adminq.h - gve_desc.h - gve_desc_dqo.h - gve_register.h It's based on GVE kernel driver v1.3.0 a

[PATCH v5 1/8] net/gve/base: introduce GVE PMD base code

2022-10-10 Thread Junfeng Guo
The following base code is based on Google Virtual Ethernet (gve) driver v1.3.0 under MIT license. - gve_adminq.c - gve_adminq.h - gve_desc.h - gve_desc_dqo.h - gve_register.h - gve.h The original code is in: https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-linux/\ tree/v1.3.0/googl

[PATCH v5 2/8] net/gve/base: add OS specific implementation

2022-10-10 Thread Junfeng Guo
Add some MACRO definitions and memory operations which are specific for DPDK. Signed-off-by: Haiyue Wang Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/gve/base/gve_adminq.h | 2 + drivers/net/gve/base/gve_desc.h | 2 + drivers/net/gve/base/gve_desc_dqo.h | 2

[PATCH v5 3/8] net/gve: add support for device initialization

2022-10-10 Thread Junfeng Guo
Support device init and add following devops skeleton: - dev_configure - dev_start - dev_stop - dev_close Note that build system (including doc) is also added in this patch. Signed-off-by: Haiyue Wang Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- MAINTAINERS

[PATCH v5 4/8] net/gve: add support for link update

2022-10-10 Thread Junfeng Guo
Support dev_ops link_update. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 1 + doc/guides/nics/gve.rst | 3 +++ drivers/net/gve/gve_ethdev.c | 30 ++ 3 files changed, 34 insertions(+) diff --git a/doc/gui

[PATCH v5 5/8] net/gve: add support for MTU setting

2022-10-10 Thread Junfeng Guo
Support dev_ops mtu_set. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 1 + drivers/net/gve/gve_ethdev.c | 29 + 2 files changed, 30 insertions(+) diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/feat

[PATCH v5 6/8] net/gve: add support for dev info get and dev configure

2022-10-10 Thread Junfeng Guo
Add dev_ops dev_infos_get. Complete dev_configure with RX offloads configuration. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 2 + doc/guides/nics/gve.rst | 1 + drivers/net/gve/gve_ethdev.c | 65 +++- 3

[PATCH v5 7/8] net/gve: add support for queue operations

2022-10-10 Thread Junfeng Guo
Add support for queue operations: - setup rx/tx queue - release rx/tx queue - start rx/tx queues - stop rx/tx queues Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/gve/gve_ethdev.c | 204 + drivers/net/gve/gve_ethdev.h | 52 + drive

[PATCH v5 8/8] net/gve: add support for Rx/Tx

2022-10-10 Thread Junfeng Guo
Add Rx/Tx of GQI_QPL queue format and GQI_RDA queue format. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 2 + doc/guides/nics/gve.rst | 4 + drivers/net/gve/gve_ethdev.c | 7 + drivers/net/gve/gve_ethdev.h | 18 ++ drivers/n

Re: [PATCH] member: fix build failure with GCC 5.4.0

2022-10-10 Thread Thomas Monjalon
10/10/2022 10:43, Ali Alnubani: > From: Leyi Rong > > > > This patch fixes the build failure by typecasting to match > > _mm512_i32gather_epi64() definition. > > > > Bugzilla ID: 1096 > > Fixes: db354bd2e1f8 ("member: add NitroSketch mode") > > > > Signed-off-by: Leyi Rong > > --- > > Thanks

[Bug 1096] lib/member build failure with gcc 5.4.0

2022-10-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1096 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

[Bug 734] memif driver crashes when there's different N of TX and RX queues

2022-10-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=734 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|U

[Bug 1060] GCC 12 build errors with -Dcpu_instruction_set=nehalem

2022-10-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1060 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

[Bug 1037] Telemetry library does not JSON encode strings

2022-10-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1037 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resoluti

[Bug 1035] __rte_raw_cksum() crash with misaligned pointer

2022-10-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1035 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

[PATCH v3 2/3] kni: add deprecation warning at runtime

2022-10-10 Thread Bruce Richardson
When KNI is being used at runtime, output a warning message about its deprecated status. This is part of the deprecation process for KNI agreed by the DPDK technical board.[1] [1] http://mails.dpdk.org/archives/dev/2022-June/243596.html Signed-off-by: Bruce Richardson Reviewed-by: David Marchand

[PATCH v3 1/3] kni: flag deprecated status at build time

2022-10-10 Thread Bruce Richardson
To ensure all users are aware of KNI's deprecated status at build time we can take the following actions: 1. disable the library by default. It can be re-enabled by setting disabled_libs to the empty string (or other string not including 'kni') 2. add support for a list of deprecated libs t

[PATCH v3 3/3] devtools: enable kni library for test builds

2022-10-10 Thread Bruce Richardson
While KNI (or any other deprecated library) may be disabled by default, for build testing we need it enabled. Therefore explicitly set "disable_libs" build parameter to empty for any DPDK build where the value is not being explicitly set by the script. Signed-off-by: Bruce Richardson --- V3: Add

Re: [PATCH] eal: non-temporal memcpy

2022-10-10 Thread Stanislaw Kardach
On Mon, Oct 10, 2022 at 11:36:11AM +0200, Morten Brørup wrote: > > For large copies, which I'm guessing is what non-temporal stores are > > usually used for, this is hair splitting. For DPDK applications, it > > might well be at least somewhat relevant, because such an application > > may make an

[PATCH v2 0/6] examples/ipsec-secgw: add lookaside event mode

2022-10-10 Thread Volodymyr Fialko
Add support for lookaside event mode for ipsec-secgw example application. * Changes since v1 - Resolve issue with ipv6 free packet in case of error - Rebase on top of dpdk-next-crypto - Update release note Volodymyr Fialko (6): examples/ipsec-secgw: add event crypto adapter init examples/ipse

[PATCH v2 1/6] examples/ipsec-secgw: add event crypto adapter init

2022-10-10 Thread Volodymyr Fialko
Create, configure and start an event crypto adapter. This adapter will be used in lookaside event mode processing. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/event_helper.c | 144 examples/ipsec-secgw/event_helper.h | 2 + examples/ipsec-secgw/ipsec-s

[PATCH v2 2/6] examples/ipsec-secgw: add queue for event crypto adapter

2022-10-10 Thread Volodymyr Fialko
Add separate event queue for event crypto adapter processing, to resolve queue contention between new and already processed events. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/event_helper.c | 95 + examples/ipsec-secgw/event_helper.h | 2 + 2 files chan

[PATCH v2 3/6] examples/ipsec-secgw: add lookaside event mode

2022-10-10 Thread Volodymyr Fialko
Add base support for lookaside event mode. Events that are coming from ethdev will be enqueued to the event crypto adapter, processed and enqueued back to ethdev for the transmission. Signed-off-by: Volodymyr Fialko --- doc/guides/rel_notes/release_22_11.rst | 5 + doc/guides/sample_app_ug/i

[PATCH v2 4/6] examples/ipsec-secgw: add stats for event mode

2022-10-10 Thread Volodymyr Fialko
Add per core statistic(rx/tx) counters for event mode worker. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec_worker.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c index 074c7

[PATCH v2 5/6] examples/ipsec-secgw: add event vector support for lookaside

2022-10-10 Thread Volodymyr Fialko
Add vector support for event crypto adapter in lookaside mode. Once --event-vector enabled, event crypto adapter will group processed crypto operation into rte_event_vector event with type RTE_EVENT_TYPE_CRYPTODEV_VECTOR. Signed-off-by: Volodymyr Fialko --- doc/guides/sample_app_ug/ipsec_secgw.r

[PATCH v2 6/6] examples/ipsec-secgw: reduce number of QP for event lookaside

2022-10-10 Thread Volodymyr Fialko
Limit number of queue pairs to one for event lookaside mode, since all cores are using same queue in this mode. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 56 +++--- 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/examples/ips

Re: [PATCH v9 1/3] power: add Intel uncore frequency control API to power library

2022-10-10 Thread Thomas Monjalon
06/10/2022 11:38, Tadhg Kearney: > +API Overview for Intel Uncore > +~ > + > +Overview of each function in the Intel Uncore API, with explanation of what > +they do. Each function should not be called in the fast path. > + > +* **Uncore Power Init** > +Initialize unc

Re: [PATCH v9 0/3] add Intel uncore api to be called through l3fwd-power

2022-10-10 Thread Thomas Monjalon
06/10/2022 11:38, Tadhg Kearney: > This is targeting 22.11 and aims to add an API to DPDK power library to > allow uncore frequency adjustment. This will be called through the l3fwd-power > app and gives the ability to set the minimum and maximum uncore frequency to > both min, max or specific freq

RE: [PATCH v2] pci: read amd iommu virtual address width

2022-10-10 Thread Varghese, Vipin
[Public] Hi Michael, Thank you for looking into the change, please find my comments shared below > > > > Add code to read the virtual address width for AMD processors. > > > > Signed-off-by: Michael Piszczek > > --- > > drivers/bus/pci/linux/pci.c | 43 > > +++

Re: [PATCH v9 7/8] app/procinfo: support descriptor dump

2022-10-10 Thread Dongdong Liu
Hi Reshma Many thanks for your review. On 2022/10/10 17:08, Pattan, Reshma wrote: -Original Message- From: Dongdong Liu +static void +nic_descriptor_display(uint16_t port_id, struct desc_param *desc, + desc_dump_t desc_dump) +{ + static const char *nic_desc

Re: [PATCH 0/2] common/mlx5: fix multi-process mempool registration

2022-10-10 Thread Thomas Monjalon
08/08/2022 11:42, Dmitry Kozlyuk: > Dmitry Kozlyuk (2): > mempool: make event callbacks process-private > common/mlx5: fix multi-process mempool registration Applied, thanks.

RE: [EXT] [PATCH v4] examples/fips_validation: add parsing for AES CTR

2022-10-10 Thread Dooley, Brian
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Friday, October 7, 2022 11:49 AM > To: Dooley, Brian > Cc: dev@dpdk.org; Gowrishankar Muthukrishnan > ; roy.fan.zh...@intel.com; Ji, Kai > > Subject: RE: [EXT] [PATCH v4] examples/fips_validation: add parsing for AES > CTR > >

Re: [PATCH v2 01/24] net/nfp: add the stats process logic in ctrl VNIC service

2022-10-10 Thread Ferruh Yigit
On 10/10/2022 7:08 AM, Chaoyong He wrote: Add the flow stats process logic in the ctrl VNIC service. The flower firmware pass the flow stats to nfp driver through control message, we store them in the flow_priv structure. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund <...> +stat

Re: [PATCH v2 02/24] net/nfp: add the structures and functions for flow offload

2022-10-10 Thread Ferruh Yigit
On 10/10/2022 7:08 AM, Chaoyong He wrote: Add the structures and functions to process mask table, flow table, and flow stats id, which are used in the rte_flow offload logics. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund <...> +__rte_unused static int +nfp_flow_table_delete(str

Re: [PATCH v2 03/24] net/nfp: add the flow APIs of nfp PMD

2022-10-10 Thread Ferruh Yigit
On 10/10/2022 7:08 AM, Chaoyong He wrote: Add the flow validate/create/query/destroy/flush API of nfp PMD. The flow create API construct a control cmsg and send it to firmware, then add this flow to the hash table. The flow query API get flow stats from the flow_priv structure. Note there exis

Re: [PATCH v2 05/24] net/nfp: add the offload support of basic actions

2022-10-10 Thread Ferruh Yigit
On 10/10/2022 7:08 AM, Chaoyong He wrote: Add the offload support of very basic actions: mark, rss, count, drop and output. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 6 ++ doc/guides/rel_notes/release_22_11.rst | 6 ++ dri

Re: [PATCH v2 08/24] net/nfp: add the offload support of IPv6 item

2022-10-10 Thread Ferruh Yigit
On 10/10/2022 7:08 AM, Chaoyong He wrote: Add the corresponding data structure and logics, to support the offload of IPv6 item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 2 + doc/guides/rel_notes/release_22_11.rst | 1 + dri

Re: [PATCH v2] build: increase minimum meson version to 0.53.2

2022-10-10 Thread David Marchand
On Fri, Oct 7, 2022 at 9:13 PM David Marchand wrote: > > On Fri, Oct 7, 2022 at 6:24 PM Bruce Richardson > wrote: > > > > This patchset bumps the minimum meson version from 0.49.2 to 0.53.2. > > Ideally, the minimum version should be 0.53 without a point release, but > > some DPDK builds (mingw)

[PATCH 0/4] Have event adapters report idle status

2022-10-10 Thread Mattias Rönnblom
This series updates the event adapters' service functions to report back to the service cores framework, whether or not any useful work was performed. This in turn makes it possible to use the service core statistics to compute service lcore load (i.e., the fraction of time its EAL thread is doing

[PATCH 1/4] eventdev: have crypto adapter appropriately report idle

2022-10-10 Thread Mattias Rönnblom
Update the event crypto adapter's service function to report as idle (i.e., return -EAGAIN) in case no crypto operations were performed. Signed-off-by: Mattias Rönnblom --- lib/eventdev/rte_event_crypto_adapter.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/li

[PATCH 2/4] eventdev: have ethernet Rx adapter appropriately report idle

2022-10-10 Thread Mattias Rönnblom
Update the Event Ethernet Rx Adapter's service function to report as idle (i.e., return -EAGAIN) in case no Ethernet frames were received from the ethdev and no events were enqueued to the event device. Signed-off-by: Mattias Rönnblom --- lib/eventdev/rte_event_eth_rx_adapter.c | 56

[PATCH 4/4] eventdev: have timer adapter appropriately report idle

2022-10-10 Thread Mattias Rönnblom
Update the Event Timer Adapter's service function to report as idle (i.e., return -EAGAIN) in case no timer events were enqueued to the event device. Signed-off-by: Mattias Rönnblom --- lib/eventdev/rte_event_timer_adapter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/l

[PATCH 3/4] eventdev: have ethernet Tx adapter appropriately report idle

2022-10-10 Thread Mattias Rönnblom
Update the Event Ethernet Tx Adapter's service function to report as idle (i.e., return -EAGAIN) in case no events were dequeued from the event device and no Ethernet frames were sent out on the wire. Signed-off-by: Mattias Rönnblom --- lib/eventdev/rte_event_eth_tx_adapter.c | 13 +

Re: [PATCH v3 1/3] kni: flag deprecated status at build time

2022-10-10 Thread David Marchand
On Mon, Oct 10, 2022 at 12:45 PM Bruce Richardson wrote: > > To ensure all users are aware of KNI's deprecated status at build time > we can take the following actions: > > 1. disable the library by default. It can be re-enabled by setting >disabled_libs to the empty string (or other string no

Re: DPDK 19.11.5 Legacy Memory Design Query

2022-10-10 Thread Dmitry Kozlyuk
Hi Umakiran, Please quote what is needed and reply below the quotes. 2022-09-26 13:06 (UTC+), Umakiran Godavarthi (ugodavar): > Hi Dimitry > > We know If the application does unmap, DPDK native heaps are not getting > cleaned up in “native: use regular DPDK memory” memory type. > > Can w

Re: [PATCH v6 0/4] mempool: fix mempool cache flushing algorithm

2022-10-10 Thread Thomas Monjalon
> Andrew Rybchenko (3): > mempool: check driver enqueue result in one place > mempool: avoid usage of term ring on put > mempool: flush cache completely on overflow > > Morten Brørup (1): > mempool: fix cache flushing algorithm Applied only first 2 "cosmetic" patches as discussed with And

RE: [PATCH v7 0/4] Add lcore poll busyness telemetry

2022-10-10 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Thursday, 6 October 2022 17.27 > > On 2022-10-06 15:25, Morten Brørup wrote: > >> From: Kevin Laatz [mailto:kevin.la...@intel.com] > >> Sent: Wednesday, 5 October 2022 15.45 > >> > >> On 14/09/2022 10:29, Kevin Laatz wrote: >

Re: [EXT] [PATCH v2] graph: fix out of bounds access when re-allocate node objs

2022-10-10 Thread Thomas Monjalon
> > For __rte_node_enqueue_prologue(), If the number of objs is more than the > > node->size * 2, the extra objs will write out of bounds memory. > > It should use __rte_node_stream_alloc_size() to request enough memory. > > > > And for rte_node_next_stream_put(), it will re-allocate a small size,

[PATCH] vhost: promote per-queue stats API to stable

2022-10-10 Thread Maxime Coquelin
This patch promotes the per-queue stats API to stable. The API has been used by the Vhost PMD since v22.07, and David Marchand posted a patch to make use of it in next OVS release[0]. [0]: http://patchwork.ozlabs.org/project/openvswitch/patch/20221007111613.1695524-4-david.march...@redhat.com/ S

Re: [PATCH] lib: Check for the NULL pointer after calling malloc

2022-10-10 Thread Thomas Monjalon
07/07/2022 11:23, 835703...@qq.com: > From: Shiqi Liu <835703...@qq.com> > > As the possible failure of the malloc(), the not_checked and > checked could be NULL pointer. > Therefore, it should be better to check it in order to avoid > the dereference of the NULL pointer. > > Fixes: fa8054c8c88 (

Re: [PATCH V2] raw/ioat: Check for the NULL pointer after calling malloc

2022-10-10 Thread Thomas Monjalon
06/07/2022 11:07, Bruce Richardson: > On Wed, Jul 06, 2022 at 02:55:48PM +0800, 835703...@qq.com wrote: > > From: Shiqi Liu <835703...@qq.com> > > > > As the possible failure of the malloc(), the not_checked and > > checked could be NULL pointer. > > Therefore, it should be better to check it in o

RE: [EXT] [PATCH v4] examples/fips_validation: add parsing for AES CTR

2022-10-10 Thread Akhil Goyal
> Hi Akhil, > > > Hi Brian, > > > Added functionality to parse algorithm for AES CTR test > > > > > > Signed-off-by: Brian Dooley > > > Acked-by: Kai Ji > > > Acked-by: Gowrishankar Muthukrishnan > > > --- > > > v2: fix clang warning for int-in-bool-context > > > --- > > > v3: in reply to fix a

Re: [PATCH] bus/pci: remove VFIO status log in scan

2022-10-10 Thread Thomas Monjalon
04/10/2022 10:00, David Marchand: > Linux EAL triggers a scan on all buses, PCI included. > Once done, it configures VFIO. > Checking for VFIO status in the PCI bus scan is pointless. > > Signed-off-by: David Marchand Applied, thanks.

Re: [PATCH v5 01/10] memarea: introduce memarea library

2022-10-10 Thread Mattias Rönnblom
On 2022-10-08 09:53, fengchengwen wrote: Hi Mattias, Thanks for your review, most will fix in v6. On 2022/10/7 4:15, Mattias Rönnblom wrote: On 2022-10-05 06:09, datshan wrote: From: Chengwen Feng The memarea library is an allocator of variable-size object which based on a memory region. Th

[PATCH v3 1/6] examples/ipsec-secgw: add event crypto adapter init

2022-10-10 Thread Volodymyr Fialko
Create, configure and start an event crypto adapter. This adapter will be used in lookaside event mode processing. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/event_helper.c | 144 examples/ipsec-secgw/event_helper.h | 2 + examples/ipsec-secgw/ipsec-s

[PATCH v3 0/6] examples/ipsec-secgw: add lookaside event mode

2022-10-10 Thread Volodymyr Fialko
Add support for lookaside event mode for ipsec-secgw example application. * Changes since v1 - Resolve issue with ipv6 free packet in case of error - Rebase on top of dpdk-next-crypto - Update release note * Changes since v2 - Fix compilation with old gcc Volodymyr Fialko (6): examples/ipsec-s

[PATCH v3 2/6] examples/ipsec-secgw: add queue for event crypto adapter

2022-10-10 Thread Volodymyr Fialko
Add separate event queue for event crypto adapter processing, to resolve queue contention between new and already processed events. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/event_helper.c | 95 + examples/ipsec-secgw/event_helper.h | 2 + 2 files chan

[PATCH v3 3/6] examples/ipsec-secgw: add lookaside event mode

2022-10-10 Thread Volodymyr Fialko
Add base support for lookaside event mode. Events that are coming from ethdev will be enqueued to the event crypto adapter, processed and enqueued back to ethdev for the transmission. Signed-off-by: Volodymyr Fialko --- doc/guides/rel_notes/release_22_11.rst | 5 + doc/guides/sample_app_ug/i

[PATCH v3 4/6] examples/ipsec-secgw: add stats for event mode

2022-10-10 Thread Volodymyr Fialko
Add per core statistic(rx/tx) counters for event mode worker. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec_worker.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c index 6c1ff

[PATCH v3 5/6] examples/ipsec-secgw: add event vector support for lookaside

2022-10-10 Thread Volodymyr Fialko
Add vector support for event crypto adapter in lookaside mode. Once --event-vector enabled, event crypto adapter will group processed crypto operation into rte_event_vector event with type RTE_EVENT_TYPE_CRYPTODEV_VECTOR. Signed-off-by: Volodymyr Fialko --- doc/guides/sample_app_ug/ipsec_secgw.r

[PATCH v3 6/6] examples/ipsec-secgw: reduce number of QP for event lookaside

2022-10-10 Thread Volodymyr Fialko
Limit number of queue pairs to one for event lookaside mode, since all cores are using same queue in this mode. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 56 +++--- 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/examples/ips

[PATCH v1] bbdev: prevent clang 3.4.2 compilation error

2022-10-10 Thread Nicolas Chautru
Casting explicitly from enum to uint8_t to avoid compilation warning with clang 3.4.2 -Wtautological-constant-out-of-range-compare Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/

RE: [EXT] [PATCH v12 0/7] bbdev changes for 22.11

2022-10-10 Thread Chautru, Nicolas
Hi Thomas, Akhil, I put a fix here : https://patches.dpdk.org/project/dpdk/patch/20221010170403.21201-1-nicolas.chau...@intel.com/ I did not reproduce that issue on gcc or recent clang, only with clang 3.4.2 on Centos7. Thanks Nic > -Original Message- > From: Thomas Monjalon > Sent:

  1   2   >