Re: [PATCH] pipeline: fix comparison

2022-06-15 Thread Thomas Monjalon
13/06/2022 13:52, Cristian Dumitrescu: > From: Harshad Narayane > > Fix comparison used to check against the maximum number of learner > table timeouts. > > Fixes: e2ecc53582fb ("pipeline: improve learner table timers") The title is not informative about what is fixed. Please give a bit of scop

Re: [PATCH] drivers: wait optionally when counting allocated pointers

2022-06-15 Thread Jerin Jacob
On Fri, Jun 10, 2022 at 9:37 PM Ashwin Sekhar T K wrote: > > When counting the batch allocated pointers in cnxk mempool driver, > currently it always waits for in-flight batch operations to finish. > Add a provision to make this waiting optional. > > Signed-off-by: Ashwin Sekhar T K Applied to d

[Bug 1037] Telemetry library does not JSON encode strings

2022-06-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1037 Bug ID: 1037 Summary: Telemetry library does not JSON encode strings Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

RE: [PATCH 1/5] usertools: use non-strict when json-loads in telemetry

2022-06-15 Thread Morten Brørup
> From: Morten Brørup > Sent: Wednesday, 15 June 2022 20.01 > > +CC Ciara Power, Telemetry lib maintainer > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Wednesday, 15 June 2022 18.55 > > > > On Wed, Jun 15, 2022 at 03:54:57PM +0200, Morten Brørup wrote: > > > > From: C

RE: [PATCH 0/5] support telemetry dump dev

2022-06-15 Thread Morten Brørup
> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > Sent: Wednesday, 15 June 2022 09.39 > > This patchset contains five patch which support telemetry dump > dmadev/eventdev/rawdev/ethdev. > > Chengwen Feng (5): > usertools: use non-strict when json-loads in telemetry > dmadev: support te

RE: [PATCH v2] mempool: fix get objects from mempool with cache

2022-06-15 Thread Morten Brørup
+CC: Beilei Xing , i40e maintainer, may be interested in the performance improvements achieved by this patch. > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Wednesday, 2 February 2022 09.14 > > A flush threshold for the mempool cache was introduced in DPDK version > 1.3, but r

[PATCH] app/testpmd: cleanup port resources after implicit close

2022-06-15 Thread Dmitry Kozlyuk
When a port was closed implicitly closed by the PMD, for example, if it was a representor port and its master port was detached, flow indirect actions could remain with their handles no longer valid. If a newly attached device was assigned the same ID as the closed port, those indirect actions beca

RE: [PATCH v7 2/5] raw/ifpga: add N3000 AFU driver

2022-06-15 Thread Huang, Wei
> -Original Message- > From: Xu, Rosen > Sent: Wednesday, June 15, 2022 15:08 > To: Huang, Wei ; dev@dpdk.org; > tho...@monjalon.net; nipun.gu...@nxp.com; hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Zhang, Tianfei ; Zhang, Qi Z > > Subject: RE: [PATCH v7 2/5] raw/ifpga: add N3000 AFU

[PATCH v2 02/15] vdpa/mlx5: support pre create virtq resource

2022-06-15 Thread Li Zhang
From: Yajun Wu The motivation of this change is to reduce vDPA device queue creation time by create some queue resource in vDPA device probe stage. In VM live migration scenario, this can reduce 0.8ms for each queue creation, thus reduce LM network downtime. To create queue resource(umem/counte

[PATCH v2 06/15] vdpa/mlx5: pre-create virtq in the prob

2022-06-15 Thread Li Zhang
dev_config operation is called in LM progress. LM time is very critical because all the VM packets are dropped directly at that time. Move the virtq creation to probe time and only modify the configuration later in the dev_config stage using the new ability to modify virtq. This optimization acce

[PATCH v2 00/15] mlx5/vdpa: optimize live migration time

2022-06-15 Thread Li Zhang
Allow the driver to use internal threads to obtain fast configuration. All the threads will be open on the same core of the event completion queue scheduling thread. Add max_conf_threads parameter to configure the maximum number of internal threads in addition to the caller thread (8 is suggested)

[PATCH v2 10/15] vdpa/mlx5: add MT task for VM memory registration

2022-06-15 Thread Li Zhang
The driver creates a direct MR object of the HW for each VM memory region, which maps the VM physical address to the actual physical address. Later, after all the MRs are ready, the driver creates an indirect MR to group all the direct MRs into one virtual space from the HW perspective. Create di

[PATCH v2 03/15] common/mlx5: add DevX API to move QP to reset state

2022-06-15 Thread Li Zhang
From: Yajun Wu Support set QP to RESET state. Signed-off-by: Yajun Wu Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++ drivers/common/mlx5/mlx5_prm.h | 17 + 2 files changed, 24 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c

[PATCH v2 07/15] vdpa/mlx5: optimize datapath-control synchronization

2022-06-15 Thread Li Zhang
The driver used a single global lock for any synchronization needed for the datapath and control path. It is better to group the critical sections with the other ones that should be synchronized. Replace the global lock with the following locks: 1.virtq locks(per virtq) synchronize datapath polli

[PATCH v2 08/15] vdpa/mlx5: add multi-thread management for configuration

2022-06-15 Thread Li Zhang
The LM process includes a lot of objects creations and destructions in the source and the destination servers. As much as LM time increases, the packet drop of the VM increases. To improve LM time need to parallel the configurations for mlx5 FW. Add internal multi-thread management in the driver fo

[PATCH v2 12/15] vdpa/mlx5: add virtq LM log task

2022-06-15 Thread Li Zhang
Split the virtqs LM log between the configuration threads. This accelerates the LM process and reduces its time by 20%. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.h | 3 + drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 34 +++ drivers/vdpa/mlx5/mlx5_

[PATCH v2 11/15] vdpa/mlx5: add virtq creation task for MT management

2022-06-15 Thread Li Zhang
The virtq object and all its sub-resources use a lot of FW commands and can be accelerated by the MT management. Split the virtqs creation between the configuration threads. This accelerates the LM process and reduces its time by 20%. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/vd

[PATCH v2 04/15] vdpa/mlx5: support event qp reuse

2022-06-15 Thread Li Zhang
From: Yajun Wu To speed up queue create time, event qp and cq will create only once. Each virtq creation will reuse same event qp and cq. Because FW will set event qp to error state during virtq destroy, need modify event qp to RESET state, then modify qp to RTS state as usual. This can save abo

[PATCH v2 14/15] vdpa/mlx5: add virtq sub-resources creation

2022-06-15 Thread Li Zhang
pre-created virt-queue sub-resource in device probe stage and then modify virtqueue in device config stage. Steer table also need to support dummy virt-queue. This accelerates the LM process and reduces its time by 40%. Signed-off-by: Li Zhang Signed-off-by: Yajun Wu Acked-by: Matan Azrad ---

[PATCH v2 05/15] common/mlx5: extend virtq modifiable fields

2022-06-15 Thread Li Zhang
A virtq configuration can be modified after the virtq creation. Added the following modifiable fields: 1.address fields: desc_addr/used_addr/available_addr 2.hw_available_index 3.hw_used_index 4.virtio_q_type 5.version type 6.queue mkey 7.feature bit mask: tso_ipv4/tso_ipv6/tx_csum/rx_csum 8.event

[PATCH v2 01/15] vdpa/mlx5: fix usage of capability for max number of virtqs

2022-06-15 Thread Li Zhang
The driver wrongly takes the capability value for the number of virtq pairs instead of just the number of virtqs. Adjust all the usages of it to be the number of virtqs. Fixes: c2eb33a ("vdpa/mlx5: manage virtqs by array") Cc: sta...@dpdk.org Signed-off-by: Li Zhang Acked-by: Matan Azrad ---

[PATCH v2 15/15] vdpa/mlx5: prepare virtqueue resource creation

2022-06-15 Thread Li Zhang
Split the virtqs virt-queue resource between the configuration threads. Also need pre-created virt-queue resource after virtq destruction. This accelerates the LM process and reduces its time by 30%. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- doc/guides/rel_notes/release_22_07.rst | 1

[PATCH v2 09/15] vdpa/mlx5: add task ring for MT management

2022-06-15 Thread Li Zhang
The configuration threads tasks need a container to support multiple tasks assigned to a thread in parallel. Use rte_ring container per thread to manage the thread tasks without locks. The caller thread from the user context opens a task to a thread and enqueue it to the thread ring. The thread pol

[PATCH v2 13/15] vdpa/mlx5: add device close task

2022-06-15 Thread Li Zhang
Split the virtqs device close tasks after stopping virt-queue between the configuration threads. This accelerates the LM process and reduces its time by 50%. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.c | 56 +-- drivers/vdpa/ml

[PATCH v2 00/15] Add support of NFP3800 chip and firmware with NFDk

2022-06-15 Thread Jin Liu
NFD is part of NFP firmware, and there only exist a NFD3 version before this patch series. This patch series mainly add the support of the new NFP3800 chip use firmware with NFD3/NFDk. * Changes since v1 - Added updated documentation for NFP to cover NFD. - Documented the addition of NFD in the re

[PATCH v2 01/15] doc: update release note

2022-06-15 Thread Jin Liu
Add support for a new type NFP NIC NFP3800 and firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- doc/guides/rel_notes/release_22_07.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/g

[PATCH v2 02/15] doc: update nfp documentation

2022-06-15 Thread Jin Liu
This set patches add support for a new type of NFP nic NFP3800 and the firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- doc/guides/nics/nfp.rst | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/doc/guides/nic

[PATCH v2 03/15] net/nfp: change the coding style

2022-06-15 Thread Jin Liu
Change the coding style of some logics, to make it more compatible with the DPDK coding style. Signed-off-by: Chaoyong He Signed-off-by: Jin Liu Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 149 drivers/net/nfp/nfp_ethdev_vf.c | 8 +-

[PATCH v2 04/15] net/nfp: remove unnecessary forward function declaration

2022-06-15 Thread Jin Liu
This commit remove some unnecessary forward function declarations. Signed-off-by: Chaoyong He Signed-off-by: Jin Liu Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 22 -- drivers/net/nfp/nfp_ethdev_vf.c | 12 drivers/net/nfp/nfp_rxtx.c

[PATCH v2 05/15] net/nfp: remove pessimistic limit

2022-06-15 Thread Jin Liu
Multiple writes cause intermediate pointer values that do not end on complete TX descriptors. The QCP peripheral on the NFP provides a number of access modes. In some access modes, the maximum amount to add must be restricted to a 6bit value. The particular access mode used by _nfp_qcp_ptr_add() h

[PATCH v2 06/15] net/nfp: rename set MAC function

2022-06-15 Thread Jin Liu
The NFP eth driver function name start with 'nfp_net', but set_mac function start with 'nfp' only, rename it, be consistent with others. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/n

[PATCH v2 07/15] net/nfp: rename function and struct

2022-06-15 Thread Jin Liu
Add 'nfd3' into the firmware with NFD3 eth driver function name, preparation for the next work, as we will support another version firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- dri

[PATCH v2 08/15] net/nfp: support NFP3800 card

2022-06-15 Thread Jin Liu
Add support for a new type of NIC NFP3800 card, and update some network card data acquisition interface functions. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.h |

[PATCH v2 09/15] net/nfp: support firmware with NFDk

2022-06-15 Thread Jin Liu
Modify nfp driver logic, add firmware version (NFD3 or NFDK) judgment, will according to the firmware version, mount different driver functions. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/n

[PATCH v2 10/15] net/nfp: structure adjustment

2022-06-15 Thread Jin Liu
Add and modify the nfp PMD struct and macro that will be used by firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.h | 58 +

[PATCH v2 11/15] net/nfp: nfdk netdev option and queue function

2022-06-15 Thread Jin Liu
Add ethdev option for firmware with NFDk, implement tx_queue setup function for firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 32 - drive

[PATCH v2 12/15] net/nfp: add queue stop and close helper function

2022-06-15 Thread Jin Liu
This commit does not introduce new features, just integrate some common logic into helper functions to reduce the same logic and increase code reuse, include queue stop and queue close logic, will be used when NFP net stop and close. queue stop: reset queue queue close: reset and release queue Mo

[PATCH v2 13/15] net/nfp: move macro from C file to head file

2022-06-15 Thread Jin Liu
Move macro __round_mask, round_up and round_down from C file to corresponding head file, will be used by TX function of nfp net firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- driver

[PATCH v2 14/15] net/nfp: nfdk packet xmit function

2022-06-15 Thread Jin Liu
Implement NFP3800 card packet transmit function for firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 3 +- drivers/net/nfp/nfp_ethdev_vf.c | 3 +-

[PATCH v2 15/15] net/nfp: modify RSS logic

2022-06-15 Thread Jin Liu
Now NFP NIC support two type of RSS logic, NFP_NET_CFG_CTRL_RSS and NFP_NET_CFG_CTRL_RSS2, use NFP_NET_CFG_CTRL_RSS2 if NIC capability support, otherwise use NFP_NET_CFG_CTRL_RSS. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-b

RE: [PATCH] net/igc: fix segmentation fault in secondary dpdk-symmetric_mp

2022-06-15 Thread Guo, Junfeng
> -Original Message- > From: Zeng, ZhichaoX > Sent: Wednesday, June 15, 2022 15:39 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zeng, ZhichaoX > ; Guo, Junfeng ; Su, > Simei > Subject: [PATCH] net/igc: fix segmentation fault in secondary dpdk- > symmetric_mp > > From: Zhichao Zeng > > In

[PATCH v8 0/5] introduce AFU PMD driver of FPGA

2022-06-15 Thread Wei Huang
The first patch implements the framework of the AFU PMD driver based on raw device interfaces. The subsequent patches implement the driver of some AFUs. Changes from v7: 1. move driver description to ifpga.rst per Rosen comment. 2. rename function name according to DPDK program guide per Rosen com

[PATCH v8 1/5] raw/ifpga: introduce AFU driver framework

2022-06-15 Thread Wei Huang
AFU (Acceleration Function Unit) is part of FPGA and enumerated by ifpga driver. This driver implements common AFU device interfaces and exposes them to application as standard raw device APIs. Normally application can operate specified AFU as below, 1. call rte_rawdev_pmd_get_named_dev() to find A

[PATCH v8 2/5] raw/ifpga: add N3000 AFU driver

2022-06-15 Thread Wei Huang
N3000 AFU includes NLB0 and DMA modules, NLB0 is used to test PCI bus and DMA is used to test local memory. This driver initialize the modules and report test result. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Reviewed-by: Rosen Xu --- v2: move source files to ifpga and rename, refine cod

[PATCH v8 3/5] raw/ifpga: add HE-LPBK AFU driver

2022-06-15 Thread Wei Huang
HE-LPBK and HE-MEM-LPBK are host exerciser modules in OFS FPGA, HE-LPBK is used to test PCI bus and HE-MEM-LPBK is used to test local memory. This driver initialize the modules and report test result. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Reviewed-by: Rosen Xu --- v2: move source fil

[PATCH v8 4/5] raw/ifpga: add HE-MEM AFU driver

2022-06-15 Thread Wei Huang
HE-MEM is one of the host exerciser modules in OFS FPGA, which is used to test local memory with built-in traffic generator. This driver initialize the module and report test result. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Reviewed-by: Rosen Xu --- v2: move source files to ifpga and re

[PATCH v8 5/5] raw/ifpga: add HE-HSSI AFU driver

2022-06-15 Thread Wei Huang
HE-HSSI is one of the host exerciser modules in OFS FPGA, which is used to test HSSI (High Speed Serial Interface). This driver initialize the module and report test result. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Reviewed-by: Rosen Xu --- v2: move source files to ifpga and rename, ref

[PATCH] eventdev/eth_tx: fix adapter create

2022-06-15 Thread Naga Harish K S V
During adapter create, memory is allocated for storing event port configuration which is freed during adapter free. The following error is seen during free "EAL: Error: Invalid memory" The service data pointer storage for txa_service_data_array is allocated during adapter create with incorrect siz

[PATCH v2] eventdev/eth_tx: fix adapter create

2022-06-15 Thread Naga Harish K S V
During adapter create, memory is allocated for storing event port configuration which is freed during adapter free. The following error is seen during free "EAL: Error: Invalid memory" The service data pointer storage for txa_service_data_array is allocated during adapter create with incorrect siz

RE: [PATCH v2] eventdev/eth_tx: fix adapter create

2022-06-15 Thread Jayatheerthan, Jay
Looks good. Acked-by: Jay Jayatheerthan -Jay > -Original Message- > From: Naga Harish K, S V > Sent: Thursday, June 16, 2022 10:45 AM > To: Naga Harish K, S V ; Jayatheerthan, Jay > ; jer...@marvell.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] eventdev/eth_tx: fix a

RE: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer

2022-06-15 Thread Morten Brørup
+CC Olivier Matz , Network Headers maintainer > From: Morten Brørup > Sent: den 15 juni 2022 16:41 > > > From: bugzi...@dpdk.org [mailto:bugzi...@dpdk.org] > > Sent: Wednesday, 15 June 2022 09.16 > > > > https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af- > 45444 > > 731-2e92ae

RE: ask for TXA_FLUSH_THRESHOLD change

2022-06-15 Thread Jayatheerthan, Jay
Hi Jaeeun, See my responses inline below. -Jay From: Jaeeun Ham Sent: Monday, June 13, 2022 5:51 AM To: dev@dpdk.org Cc: Jerin Jacob ; Jayatheerthan, Jay Subject: ask for TXA_FLUSH_THRESHOLD change Hi, There were latency delay when I increase dpdk(20.11.1) core. (one worker core was okay.)

RE: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer

2022-06-15 Thread Morten Brørup
+CC Olivier Matz , Network Headers maintainer > -Original Message- > From: Morten Brørup > Sent: den 15 juni 2022 16:41 > To: Emil Berg ; bugzi...@dpdk.org > Cc: dev@dpdk.org > Subject: RE: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer > > > From: bugzi...@dpdk.org [mailto:b

<    1   2