Re: [PATCH v6] ethdev: introduce available Rx descriptors threshold

2022-06-09 Thread Thomas Monjalon
09/06/2022 02:17, fengchengwen: > Hi Thomas, > >Could it possible accept the patch ' [dpdk-dev] [PATCH v7 1/4] ethdev: > support device reset and recovery events' > which was delayed by ABI exceptions like this patch ? I suppose you refer to this explanation: +; Ignore ethdev event enum upd

RE: [PATCH v4 1/2] vhost: support clear in-flight packets for async dequeue

2022-06-09 Thread Hu, Jiayu
Hi Yuan, > -Original Message- > From: Wang, YuanX > Sent: Tuesday, June 7, 2022 1:45 AM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; Ding, Xuan ; Pai > G, Sunil ; Wang, YuanX > Subject: [PATCH v4 1/2] vhost: support clear in-flight packets for async >

RE: [RFC 8/8] ip_frag: fix gcc-12 warnings

2022-06-09 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 8 June 2022 17.27 > > On Wed, 8 Jun 2022 09:19:20 +0100 > Konstantin Ananyev wrote: > > > 07/06/2022 18:17, Stephen Hemminger пишет: > > > The function rte_memcpy can derference past source buffer which > > > will c

RE: [RFC] eal/x86: disable array bounds checks in rte_memcpy_generic with gcc-12

2022-06-09 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 9 June 2022 00.49 > > Gcc 12 adds more array bounds checking (good); but it is not smart > enough to realize that for small fixed sizes, the bigger move options > are not used. > > An example is using rte_memcpy() on

[PATCH v7 0/5] introduce AFU PMD driver of FPGA

2022-06-09 Thread Wei Huang
The first patch implements the framework of the AFU PMD driver based on raw device interfaces. The subsequent patches implement the driver of some AFUs. Changes from v6: 1. Fix Ubuntu 20.04 ARM build. Wei Huang (5): raw/ifpga: introduce AFU driver framework raw/ifpga: add N3000 AFU driver r

[PATCH v7 1/5] raw/ifpga: introduce AFU driver framework

2022-06-09 Thread Wei Huang
AFU (Acceleration Function Unit) is part of FPGA and enumerated by ifpga driver. This driver implements common AFU device interfaces and exposes them to application as standard raw device APIs. Normally application can operate specified AFU as below, 1. call rte_rawdev_pmd_get_named_dev() to find A

[PATCH v7 2/5] raw/ifpga: add N3000 AFU driver

2022-06-09 Thread Wei Huang
N3000 AFU includes NLB0 and DMA modules, NLB0 is used to test PCI bus and DMA is used to test local memory. This driver initialize the modules and report test result. Signed-off-by: Wei Huang --- v2: move source files to ifpga and rename, refine code --- v3: fix Ubuntu 20.04 ARM build --- driver

[PATCH v7 3/5] raw/ifpga: add HE-LPBK AFU driver

2022-06-09 Thread Wei Huang
HE-LPBK and HE-MEM-LPBK are host exerciser modules in OFS FPGA, HE-LPBK is used to test PCI bus and HE-MEM-LPBK is used to test local memory. This driver initialize the modules and report test result. Signed-off-by: Wei Huang --- v2: move source files to ifpga and rename, refine code --- drivers

[PATCH v7 4/5] raw/ifpga: add HE-MEM AFU driver

2022-06-09 Thread Wei Huang
HE-MEM is one of the host exerciser modules in OFS FPGA, which is used to test local memory with built-in traffic generator. This driver initialize the module and report test result. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang --- v2: move source files to ifpga and rename --- drivers/raw/i

[PATCH v7 5/5] raw/ifpga: add HE-HSSI AFU driver

2022-06-09 Thread Wei Huang
HE-HSSI is one of the host exerciser modules in OFS FPGA, which is used to test HSSI (High Speed Serial Interface). This driver initialize the module and report test result. Signed-off-by: Wei Huang --- v2: move source files to ifpga and rename, refine code --- drivers/raw/ifpga/afu_pmd_he_hssi.

[PATCH v4] net/ice: support dump DDP runtime configure

2022-06-09 Thread Steve Yang
Dump DDP runtime configure into a binary(package) file from ice PF port. Add command line: ddp dump Parameters: the PF Port ID dumped runtime configure file, if not a absolute path, it will be dumped to testpmd running directory. For example: testpmd>

RE: [PATCH v4 1/2] vhost: support clear in-flight packets for async dequeue

2022-06-09 Thread Wang, YuanX
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Thursday, June 9, 2022 3:06 PM > To: Wang, YuanX ; maxime.coque...@redhat.com; > Xia, Chenbo ; dev@dpdk.org > Cc: Ding, Xuan ; Pai G, Sunil > Subject: RE: [PATCH v4 1/2] vhost: support clear in-flight packets for async > dequeue >

Re: [PATCH v4] doc: announce changes in bbdev related to enum extension

2022-06-09 Thread Maxime Coquelin
Hi Nicolas, On 6/9/22 02:34, Nicolas Chautru wrote: Intent to resolve in DPDK 22.11 historical usage which prevents graceful extension of enum and API without troublesome ABI breakage as well as extending API RTE_BBDEV_OP_FFT for new operation type in bbdev as well as other new members in existi

Re: [PATCH v5 7/7] app/testpmd: add Host Shaper command

2022-06-09 Thread Andrew Rybchenko
Since ethdev patch is factored out from the patch series the rest could go to mlx5 maintainers. On 6/7/22 15:59, Spike Du wrote: Add command line options to support host shaper configure. - Command syntax: mlx5 set port host_shaper avail_thresh_triggered <0|1> rate - Example commands: To e

[PATCH] bus/vmbus: add support allow/block scan mode

2022-06-09 Thread Xiaoming Jiang
Signed-off-by: Xiaoming Jiang --- drivers/bus/vmbus/vmbus_common.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index 367727367e..c583c3df8b 100644 --- a/drivers/bus/vmbus/vm

[PATCH] bus/vmbus: add support allow/block scan mode

2022-06-09 Thread Xiaoming Jiang
bus/vmbus: add support allow/block scan mode Signed-off-by: Xiaoming Jiang --- drivers/bus/vmbus/vmbus_common.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index 367727367e

Re: UDP-GRO not working

2022-06-09 Thread Thomas Monjalon
Jiayu, please could you comment the explanation below? 10/03/2022 13:52, kumaraparameshwaran rathinavel: > Hi , > > I tried using the UDP GRO feature in DPDK recently and it did not see > working. I understand the GRO for UDP is applicable only for fragmented > packets, there is the following ch

Re: [PATCH v4] gro: bug fix in identifying fragmented packets

2022-06-09 Thread Thomas Monjalon
Jiayu, please could you review this patch? 08/06/2022 11:57, Kumara Parameshwaran: > From: Kumara Parameshwaran > > A packet with RTE_PTYPE_L4_FRAG(0x300) contains both RTE_PTYPE_L4_TCP > (0x100) & RTE_PTYPE_L4_UDP (0x200). A fragmented packet as defined in > rte_mbuf_ptype.h cannot be recogniz

[PATCH] bus/vmbus: add support allow/block scan mode

2022-06-09 Thread Xiaoming Jiang
bus/vmbus: add support allow/block scan mode Signed-off-by: Xiaoming Jiang --- drivers/bus/vmbus/vmbus_common.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index 367727367e

Re: [PATCH v2] net/bonding: failover of LACP with mode 4 takes long time

2022-06-09 Thread Andrew Rybchenko
On 6/6/22 17:34, Gaoxiang Liu wrote: When the primary port of bond slaves with bond mode 4 linked down, the system id of the other slave ports channged. It may cause some switches to renegotiate, and the process takes a few seconds. It is not acceptable for any Telcos. We need sub-second switchov

RE: [PATCH] net/ice: fix race condition for multi-cores

2022-06-09 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Wednesday, June 8, 2022 10:46 AM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix race condition for multi-cores > > In multi-cores cases for Rx timestamp o

RE: [PATCH v4] net/ice: support dump DDP runtime configure

2022-06-09 Thread Zhang, Qi Z
> -Original Message- > From: Yang, SteveX > Sent: Thursday, June 9, 2022 3:40 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX > Subject: [PATCH v4] net/ice: support dump DDP runtime configure > > Dump DDP runtime configure into a binary(package) file from ice P

[PATCH v1] raw/ifpga: free file handle before function return

2022-06-09 Thread Wei Huang
Coverity issue: 379064 Fixes: 673c897f4d73 ("raw/ifpga: support OFS card probing") Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_enumerate.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/raw/ifpga/base/ifpga_enumerate.c b/d

[PATCH] bus/vmbus: add support allow/block scan mode

2022-06-09 Thread Xiaoming Jiang
bus/vmbus: add support allow/block scan mode Signed-off-by: Xiaoming Jiang --- drivers/bus/vmbus/vmbus_common.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index 367727367e

Re: [PATCH v4] app/testpmd: fix slave device isn't released

2022-06-09 Thread Ferruh Yigit
On 6/9/2022 8:50 AM, Dongdong Liu wrote: Hi Ferruh Many thanks for your review. On 2022/6/7 22:31, Ferruh Yigit wrote: On 6/7/2022 9:10 AM, Dongdong Liu wrote: From: Huisong Li Currently, some eth devices are added to bond device, these devices are not released when the quit command is execu

[PATCH] net/cxgbe: fix warnings when using optimization=1 flag

2022-06-09 Thread Rahul Lakkireddy
Initialize maddr and mtype to fix following warnings when using optimization=1 compilation flag. In file included from ../drivers/net/cxgbe/base/common.h:13, from ../drivers/net/cxgbe/cxgbe_main.c:37: ../drivers/net/cxgbe/cxgbe_main.c: In function ‘cxgbe_probe’: ../drivers/net/cxg

Re: [PATCH 1/2] net/bonding: fix RSS inconsistent between bonded and slaves

2022-06-09 Thread Andrew Rybchenko
On 6/8/22 14:45, Dongdong Liu wrote: From: Huisong Li Currently, RSS configuration of slave is set only when RSS is enabled for bonded port. If RSS is enabled for the slaves port before adding to the bonded port with disabling RSS, it will run into that the RSS enabled state of bonded and slave

Re: [PATCH 0/2] app/test: fix bonding RSS test when disable RSS

2022-06-09 Thread Andrew Rybchenko
On 6/8/22 14:45, Dongdong Liu wrote: This patch is to fix bonding RSS test when disable RSS. The below link show the detail infomaintion of the failed testcase. https://bugs.dpdk.org/show_bug.cgi?id=1013 Huisong Li (2): net/bonding: fix RSS inconsistent between bonded and slaves app/test:

[PATCH] crypto/cnxk: fix condition check

2022-06-09 Thread Volodymyr Fialko
The value of ec_mdata cannot be NULL, instead check that value of private_data_offset was set. Fixes: c3a498c01121 ("crypto/cnxk: add event metadata set operation") Coverity issue: 378861 Coverity issue: 378865 Signed-off-by: Volodymyr Fialko --- drivers/crypto/cnxk/cn10k_cryptodev_ops.

[PATCH v5 0/2] support to clear in-flight packets for async

2022-06-09 Thread Yuan Wang
These patches support to clear in-flight packets for async dequeue and introduce thread-safe version of this function. v5: - Add dma_id check v4: - Rebase to latest DPDK v3: - Rebase to latest DPDK v2: - Use the thread-safe version in destroy_device v1: - Protect vq access with splitlock Yuan

[PATCH v5 1/2] vhost: support clear in-flight packets for async dequeue

2022-06-09 Thread Yuan Wang
rte_vhost_clear_queue_thread_unsafe() supports to clear in-flight packets for async enqueue only. But after supporting async dequeue, this API should support async dequeue too. This patch also adds the thread-safe version of this API, the difference between the two API is that thread safety uses l

[PATCH v5 2/2] example/vhost: support to clear in-flight packets for async dequeue

2022-06-09 Thread Yuan Wang
This patch allows vring_state_changed() to clear in-flight dequeue packets. It also clears the in-flight packets in a thread-safe way in destroy_device(). Signed-off-by: Yuan Wang --- examples/vhost/main.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --

RE: [PATCH] crypto/cnxk: fix condition check

2022-06-09 Thread Anoob Joseph
> Subject: [PATCH] crypto/cnxk: fix condition check > > The value of ec_mdata cannot be NULL, instead check that value of > private_data_offset was set. > > > Fixes: c3a498c01121 ("crypto/cnxk: add event metadata set operation") > Coverity issue: 378861 Coverity issue: 378865 > > Signed-off-b

Re: [PATCH v2 00/11] bugfix for hns3 PMD

2022-06-09 Thread Andrew Rybchenko
On 6/1/22 06:52, Min Hu (Connor) wrote: This patch set contains 11 bugfix for hns3 PMD. Chengwen Feng (1): net/hns3: fix TM capability incorrectly defined Huisong Li (9): net/hns3: add check for deferred start queue when rollback net/hns3: remove redundant parentheses net/hns3: adju

[PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-09 Thread Stanislaw Kardach
As David noticed in [1] there is an issue with C++ compilation of the rte_vect.h header in RISC-V. Upon closer inspection, the problem appears on all architectures due to the type conversion rules in C++. More precisely a union type rte_xmm_t requires a conversion constructor from xmm_t type. The m

[PATCH 2/3] lpm: fix xmm_t casting for C++ in scalar version

2022-06-09 Thread Stanislaw Kardach
rte_xmm_t is a union type which wraps around xmm_t and maps its contents to scalar structures. Since C++ has stricter type conversion rules than C, the rte_xmm_t::x has to be used instead of C-casting. The generated assembly is identical to the code without the fix (checked both on x86 and RISC-V)

[PATCH 1/3] eal/riscv: fix xmm_t casting for C++

2022-06-09 Thread Stanislaw Kardach
rte_xmm_t is a union type which wraps around xmm_t and maps its contents to scalar structures. Since C++ has stricter type conversion rules than C, the rte_xmm_t::x has to be used instead of C-casting. Signed-off-by: Stanislaw Kardach --- lib/eal/riscv/include/rte_vect.h | 4 ++-- 1 file changed

[PATCH 3/3] ci: use crossbuild-essential-riscv64 for compiling

2022-06-09 Thread Stanislaw Kardach
The current packages installed for RISC-V build check do not contain a C++ compiler, which hid an issue with C++ type conversion in the rte_vect.h header on RISC-V or in the scalar implementation of the LPM x4 lookup. Now that this issue is fixed, use the full toolchain install to enable the C++ te

[PATCH] doc: fix formatting in RISC-V release notes entry

2022-06-09 Thread Stanislaw Kardach
There was an extra * in the title of the RISC-V entry. It gets rendered in the documentation output giving an impression that there will be a footnote for this entry, which is not the case. Signed-off-by: Stanislaw Kardach --- doc/guides/rel_notes/release_22_07.rst | 2 +- 1 file changed, 1 inse

Re: [PATCH v3 1/7] ethdev: add meter color flow matching item

2022-06-09 Thread Andrew Rybchenko
On 6/1/22 06:44, Alexander Kozyrev wrote: Provide an ability to use a Color Marker set by a Meter as a matching item in Flow API. The Color Marker reflects the metering result by setting the metadata for a packet to a particular codepoint: green, yellow or red. Signed-off-by: Alexander Kozyrev

Re: [PATCH v3 2/7] ethdev: allow meter color marker modification

2022-06-09 Thread Andrew Rybchenko
On 6/1/22 06:44, Alexander Kozyrev wrote: Extend modify_field Flow API with support of Meter Color Marker modifications. It allows setting the packet's metadata to any color marker: green, yellow or red. A user is able to specify an initial packet color for Meter API or create simple Metering and

Re: [PATCH v3 3/7] ethdev: get meter profile/policy objects

2022-06-09 Thread Andrew Rybchenko
On 6/1/22 06:44, Alexander Kozyrev wrote: Introduce a new Meter API to retrieve a Meter profile and policy objects using the profile/policy ID previously created with meter_profile_add() and meter_policy_create() functions. That allows to save the pointer and avoid any lookups in the correspondin

Re: [PATCH v3 4/7] ethdev: add meter color mark flow action

2022-06-09 Thread Andrew Rybchenko
On 6/1/22 06:44, Alexander Kozyrev wrote: Create a new Flow API action: METER_MARK. It Meters an IP packet stream and marks its packets with colors. Is it really required to be *IP* packet? IPv4 or IPv6 or both? Unlike the METER action, it performs no policing at all. A user has the flexibili

RE: Lgtm scan of DPDK

2022-06-09 Thread Mcnamara, John
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, June 9, 2022 3:36 AM > To: Mcnamara, John > Cc: Thomas Monjalon ; dev@dpdk.org; > david.march...@redhat.com > Subject: Re: Lgtm scan of DPDK > > On Wed, 8 Jun 2022 08:35:45 + > "Mcnamara, John" wrote: > > > > -

[Bug 1030] rte_malloc() and rte_free() get stuck when used with signal handler

2022-06-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1030 Bug ID: 1030 Summary: rte_malloc() and rte_free() get stuck when used with signal handler Product: DPDK Version: 22.03 Hardware: All OS: Linux Status: U

[PATCH 1/1] examples/ipsec-secgw: add option for descriptors per QP

2022-06-09 Thread Volodymyr Fialko
Added option to configure number of queue pair descriptors via command line (--desc-nb NUMBER_OF_DESC). When the crypto processing takes longer durations, small queue pair size would result in cryptodev enqueue failures. Larger queue pair size would allow more packets to stay in flight simultaneou

Re: [RFC v3] add support for async vhost packed ring dequeue

2022-06-09 Thread Maxime Coquelin
Hi Cheng, On 5/30/22 06:56, Cheng Jiang wrote: This RFC patch implements packed ring dequeue data path for asynchronous vhost. Please remove RFC in the next revision. Signed-off-by: Cheng Jiang --- lib/vhost/virtio_net.c | 217 - 1 file changed, 19

RE: [RFC v3] add support for async vhost packed ring dequeue

2022-06-09 Thread Jiang, Cheng1
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, June 9, 2022 9:04 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; Wang, > YuanX ; Yang, YvonneX > Subject: Re: [RFC v3] add support for async vhost packed ring dequeue > >

Re: [PATCH] doc: fix formatting in RISC-V release notes entry

2022-06-09 Thread Thomas Monjalon
09/06/2022 14:17, Stanislaw Kardach: > There was an extra * in the title of the RISC-V entry. It gets rendered > in the documentation output giving an impression that there will be a > footnote for this entry, which is not the case. > > Signed-off-by: Stanislaw Kardach > --- > -* **Added initial

Re: [PATCH] doc: fix formatting in RISC-V release notes entry

2022-06-09 Thread Stanisław Kardach
On Thu, Jun 9, 2022 at 3:30 PM Thomas Monjalon wrote: > > 09/06/2022 14:17, Stanislaw Kardach: > > There was an extra * in the title of the RISC-V entry. It gets rendered > > in the documentation output giving an impression that there will be a > > footnote for this entry, which is not the case. >

[PATCH 1/1] doc: expand description of no-huge and PMD issue

2022-06-09 Thread Stanislaw Kardach
Add more details to the description of a known issue of PMDs not being usable when --no-huge EAL command line parameter is used. The issue actually happens whenever there is a need for physical addresses, even when there is no PMD attached. Signed-off-by: Stanislaw Kardach --- doc/guides/rel_not

[PATCH 0/6] add thread lifetime and attributes API

2022-06-09 Thread Tyler Retzlaff
add rte thread lifetime and attributes api. with these api additions there is now sufficient platform abstracted thread api to remove the use of pthread in the unit tests. Tyler Retzlaff (6): eal: add thread attributes eal: add thread lifetime management eal: add basic rte thread ID equal AP

[PATCH 3/6] eal: add basic rte thread ID equal API

2022-06-09 Thread Tyler Retzlaff
Add rte_thread_equal() that tests if two rte_thread_id are equal. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- lib/eal/common/rte_thread.c | 6 ++ lib/eal/include/rte_thread.h | 19 +++ lib/eal/version.map | 1 + 3 files changed, 26 insertions(

[PATCH 4/6] test/threads: add tests for thread lifetime API

2022-06-09 Thread Tyler Retzlaff
test basic functionality and demonstrate use of following thread lifetime api. * rte_thread_create * rte_thread_detach * rte_thread_join Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- app/test/test_threads.c | 50 + 1

[PATCH 1/6] eal: add thread attributes

2022-06-09 Thread Tyler Retzlaff
Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: * RTE_THREAD_PRIORITY_NORMAL * RTE_THREAD_PRIORITY_REALTIME_CRITICAL Affinity is desc

[PATCH 2/6] eal: add thread lifetime management

2022-06-09 Thread Tyler Retzlaff
The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is passed (parameter is NULL), the default affinity and priority are used. On Wi

[PATCH 6/6] test/threads: remove unit test use of pthread

2022-06-09 Thread Tyler Retzlaff
now that rte_thread provides thread lifetime functions stop using pthread in unit tests. Signed-off-by: Tyler Retzlaff --- app/test/test_threads.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/test/test_threads.c b/app/test/test_threads.c index 92a149a..034f82d 1

[PATCH 5/6] test/threads: add tests for thread attributes API

2022-06-09 Thread Tyler Retzlaff
test basic functionality and demonstrate use of following thread attributes api. additionally, test attributes are processed when supplied to rte_thread_create(). * rte_thread_attr_init * rte_thread_attr_set_affinity * rte_thread_attr_get_affinity * rte_thread_attr_set_priority Si

Re: [PATCH] net/cxgbe: fix warnings when using optimization=1 flag

2022-06-09 Thread Ferruh Yigit
On 6/9/2022 9:49 AM, Rahul Lakkireddy wrote: Initialize maddr and mtype to fix following warnings when using optimization=1 compilation flag. In file included from ../drivers/net/cxgbe/base/common.h:13, from ../drivers/net/cxgbe/cxgbe_main.c:37: ../drivers/net/cxgbe/cxgbe_main.

Re: [PATCH v6] app/testpmd: add help messages for multi-process

2022-06-09 Thread Ferruh Yigit
On 6/9/2022 9:52 AM, Dongdong Liu wrote: From: Huisong Li This patch adds help messages for multi-process. --num-procs=N: set the total number of multi-process instances. --proc-id=id: set the id of the current process from multi-process instances(0 <= id < num-procs). Fixes: a550baf24af9 (

RE: [PATCH v4] gro: bug fix in identifying fragmented packets

2022-06-09 Thread Hu, Jiayu
Sure. Will review soon. Thanks, Jiayu > -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 9, 2022 4:14 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Kumara Parameshwaran > ; sta...@dpdk.org > Subject: Re: [PATCH v4] gro: bug fix in identifying fragmented packets > > Jiayu, ple

[PATCH v2] ip_frag: add IPv4 fragment copy packet API

2022-06-09 Thread Huichao Cai
Some NIC drivers support MBUF_FAST_FREE(Device supports optimization for fast release of mbufs. When set application must guarantee that per-queue all mbufs comes from the same mempool and has refcnt = 1) offload. In order to adapt to this offload function, add this API. Add some test data for this

Re: [PATCH v6] app/testpmd: add help messages for multi-process

2022-06-09 Thread Ferruh Yigit
On 6/9/2022 3:06 PM, Ferruh Yigit wrote: On 6/9/2022 9:52 AM, Dongdong Liu wrote: From: Huisong Li This patch adds help messages for multi-process. --num-procs=N: set the total number of multi-process instances. --proc-id=id:  set the id of the current process from multi-process instances(0

Re: [PATCH v4 0/4] clean up zero-length arrays

2022-06-09 Thread Tyler Retzlaff
does this mean we now *require* a C99 compiler? (which i have no problem with) Series-acked-by: Tyler Retzlaff On Fri, Jun 03, 2022 at 12:16:21PM +0100, Bruce Richardson wrote: > This patchset adds a coccinelle script to clean-up zero-length > arrays in structures. The final patches are the res

[PATCH] net/octeontx_ep: updated ethdev ops

2022-06-09 Thread Sathesh B Edara
Updated ethdev ops support for link_update(), stats_get() and stats_reset() Signed-off-by: Sathesh B Edara --- drivers/net/octeontx_ep/otx_ep_ethdev.c | 69 + 1 file changed, 69 insertions(+) diff --git a/drivers/net/octeontx_ep/otx_ep_ethdev.c b/drivers/net/octeontx_ep

RE: UDP-GRO not working

2022-06-09 Thread Hu, Jiayu
Hi Param, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 9, 2022 4:11 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; olivier.m...@6wind.com; krag...@vmware.com; > kumaraparameshwaran rathinavel > Subject: Re: UDP-GRO not working > > Jiayu, please could you comment the expl

Re: 【rte_malloc & free】the issue of crashing at malloc_elem_free

2022-06-09 Thread Stephen Hemminger
On Thu, 9 Jun 2022 09:17:33 + "halsey.p...@longsys.com" wrote: > Dear All, > > I am suffering an crash issue recently. My app based on SPDK/DPDK uses > rte_malloc_socket and rte_free to use hugepage feature in multi-threads and > async programming environment. > > Unfortunately, It would

Re: [Bug 1030] rte_malloc() and rte_free() get stuck when used with signal handler

2022-06-09 Thread Stephen Hemminger
On Thu, 09 Jun 2022 12:47:43 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=1030 > > Bug ID: 1030 >Summary: rte_malloc() and rte_free() get stuck when used with > signal handler >Product: DPDK >Version: 22

Re: [PATCH v3 01/11] event/octeontx: fix SSO fastpath

2022-06-09 Thread Jerin Jacob
On Tue, May 24, 2022 at 2:13 PM Harman Kalra wrote: > > Segmentation fault is observed as soon as any dpdk application > with ethdev event is launched. Handling the event types > appropriately. > > Also fixing sub event type violation as in OCTEONTX event device we > use sub_event_type to store th

Re: [PATCH v3 11/11] net/thunderx: populate max and min MTU values

2022-06-09 Thread Jerin Jacob
On Tue, May 24, 2022 at 2:14 PM Harman Kalra wrote: > > From: Hanumanth Pothula > > Populate maximum and minimum MTU values while retrieving > device information. > > Signed-off-by: Hanumanth Pothula Series applied to dpdk-next-net-mrvl/for-next-net. Thanks. > --- > drivers/net/thunderx/nicv

Re: [PATCH v3 08/11] net/octeontx: implement xstats

2022-06-09 Thread Jerin Jacob
On Tue, May 24, 2022 at 2:13 PM Harman Kalra wrote: > > Adding support for xstats eth operations. > > Signed-off-by: Harman Kalra +++ b/drivers/net/octeontx/octeontx_stats.h > @@ -0,0 +1,41 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2017 Cavium, Inc Fixed copyright and C

Re: [PATCH] event/dlb2: improve enqueue efficiency

2022-06-09 Thread Jerin Jacob
On Mon, Jun 6, 2022 at 9:15 PM Timothy McDaniel wrote: > > Validate credit configuration. Remove the above line on applying. Applied to dpdk-next-net-eventdev/for-main. Thanks > > If user tried to send 64 events, it will take 64 credits. Enqueue API > only gets 32 credits each time. If it does

Re: [PATCH] event/dlb2: fix advertized capabilities

2022-06-09 Thread Jerin Jacob
On Mon, Jun 6, 2022 at 9:31 PM Timothy McDaniel wrote: > Be more descriptive, > 1) Remove RTE_EVENT_DEV_CAP_QUEUE_QOS. DLB/DLB2 do not support > queue priority > 2) Add RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT > 3) Add RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK file doc/guides/eventdevs/features/dlb2.ini

Re: [PATCH] event/dlb2: rework queue drain handling

2022-06-09 Thread Jerin Jacob
On Mon, Jun 6, 2022 at 9:36 PM Timothy McDaniel wrote: > > Previously, anything that prevented the CQs from being drained > would hang the PMD for an unacceptably long time. This commit updates > the drain logic to be resource and time based, thus eliminating > the potential for a long hang when d

Does the vhost-user driver ensures the distribution of traffic between multiple RX queues?

2022-06-09 Thread Adel Belkhiri
Hi guys, I have a question for you. I know that vhost-user NICs can be configured with many RX/TX queues, but does the vhost-user driver ensures the distribution of traffic between RX queues? I used the sample application l3fdw to switch traffic between two vhost-user NICs, each with 4 queues. T

Re: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs

2022-06-09 Thread Jerin Jacob
On Mon, May 23, 2022 at 10:25 PM Bruce Richardson wrote: > > On Mon, May 23, 2022 at 05:52:06PM +0100, McDaniel, Timothy wrote: > > > > > > > > > > Instead, I'd recommend doing as other places in DPDK - such as in ACL > > > library, or i40e or ice net drivers - where we not only check the current

Re: [PATCH] event/dlb2: fix QID inflight exploit

2022-06-09 Thread Jerin Jacob
On Mon, Jun 6, 2022 at 9:33 PM Timothy McDaniel wrote: > > If QID inflights is set to an invalid value it can cause the > PMD to hang. This commit adds checks to make sure that the > value is valid before programming the hardware. > > Fixes: 1857f1922ce2 ("event/dlb2: use new implementation of re

RE: [PATCH] event/dlb2: fix advertized capabilities

2022-06-09 Thread McDaniel, Timothy
I will update both the description and doc/guides/eventdevs/features/dlb2.ini Thanks, Tim > -Original Message- > From: Jerin Jacob > Sent: Thursday, June 9, 2022 12:06 PM > To: McDaniel, Timothy > Cc: Jerin Jacob ; dpdk-dev ; dpdk stable > > Subject: Re: [PATCH] event/dlb2: fix adverti

RE: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs

2022-06-09 Thread McDaniel, Timothy
I will submit the changes requested by Bruce. Thanks, Tim > -Original Message- > From: Jerin Jacob > Sent: Thursday, June 9, 2022 12:40 PM > To: Richardson, Bruce > Cc: McDaniel, Timothy ; jer...@marvell.com; > dev@dpdk.org; Wires, Kent > Subject: Re: [PATCH v4] event/dlb2: add support

DPDK Release Status Meeting 2022-06-09

2022-06-09 Thread Mcnamara, John
Release status meeting minutes 2022-06-09 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Debian/Microsoft * Marvell * Nvidia * Red Hat * Xilinx/AMD Release Dates - The following are the p

Re: Does the vhost-user driver ensures the distribution of traffic between multiple RX queues?

2022-06-09 Thread Maxime Coquelin
Hi Adel, On 6/9/22 19:33, Adel Belkhiri wrote: Hi guys, I have a question for you. I know that vhost-user NICs can be configured with many  RX/TX queues, but does the vhost-user driver ensures the distribution of traffic between RX queues? No, not yet. I used the sample application l3fdw t

Re: [PATCH 3/6] eal: add basic rte thread ID equal API

2022-06-09 Thread Konstantin Ananyev
09/06/2022 14:58, Tyler Retzlaff пишет: Add rte_thread_equal() that tests if two rte_thread_id are equal. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- lib/eal/common/rte_thread.c | 6 ++ lib/eal/include/rte_thread.h | 19 +++ lib/eal/version.map

Re: [RFC] eal/x86: disable array bounds checks in rte_memcpy_generic with gcc-12

2022-06-09 Thread Konstantin Ananyev
08/06/2022 23:49, Stephen Hemminger пишет: Gcc 12 adds more array bounds checking (good); but it is not smart enough to realize that for small fixed sizes, the bigger move options are not used. An example is using rte_memcpy() on a RSS key of 40 bytes may trigger rte_memcpy complaints from rte_m

RE: [PATCH v4] net/i40e: add outer VLAN processing

2022-06-09 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Liu > Sent: Thursday, June 9, 2022 10:43 PM > To: dev@dpdk.org > Cc: Zhang, Yuying ; Xing, Beilei > ; Yang, SteveX ; Zhang, > RobinX ; Liu, KevinX > Subject: [PATCH v4] net/i40e: add outer VLAN processing > > From: Robin Zhang > > Outer VLAN proces

RE: [PATCH v4] net/ice: support dump DDP runtime configure

2022-06-09 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, June 9, 2022 4:41 PM > To: Yang, SteveX ; dev@dpdk.org > Cc: Yang, Qiming > Subject: RE: [PATCH v4] net/ice: support dump DDP runtime configure > > > > > -Original Message- > > From: Yang, SteveX > > Sent: Thursday,

[PATCH v5] net/ice: support dump DDP runtime configure

2022-06-09 Thread Steve Yang
Dump DDP runtime configure into a binary(package) file from ice PF port. Add command line: ddp dump Parameters: the PF Port ID dumped runtime configure file, if not a absolute path, it will be dumped to testpmd running directory. For example: testpmd>

[PATCH v2 0/2] update rsu implementation

2022-06-09 Thread Wei Huang
The first patch introduce PMCI driver to provide interface to access PMCI functions which include flash controller. The second patch update RSU (Remote System Update) implementation to adapt with PMCI controller. Changes from v1: 1. rebase code to 22.07-rc1 Wei Huang (2): raw/ifpga/base: add pm

[PATCH v2 1/2] raw/ifpga/base: add pmci driver

2022-06-09 Thread Wei Huang
PMCI (Platform Management Control Interface) is a new module in FPGA, which is designed to cooperate with BMC chip to fulfill board management functions. This driver provide interfaces to access registers of BMC chip and external flash of FPGA. Signed-off-by: Wei Huang --- drivers/raw/ifpga/base

[PATCH v2 2/2] raw/ifpga: update secure rsu

2022-06-09 Thread Wei Huang
Update secure RSU (Remote System Update) driver to adapt the changes introduced by OFS. Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_api.c | 39 +- drivers/raw/ifpga/base/ifpga_feature_dev.h |2 + drivers/raw/ifpga/base/ifpga_fme.c |8 + drivers/raw/ifpga/b

RE: [PATCH v5 7/7] app/testpmd: add Host Shaper command

2022-06-09 Thread Spike Du
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, June 9, 2022 3:55 PM > To: Spike Du ; Matan Azrad ; > Slava Ovsiienko ; Ori Kam ; > NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Xiaoyun Li ; Aman Singh > ; Yuying Zhang > Cc: step...@networkplumber.org; m...@smartsharesystem

RE: [PATCH v5] net/ice: support dump DDP runtime configure

2022-06-09 Thread Zhang, Qi Z
> -Original Message- > From: Yang, SteveX > Sent: Friday, June 10, 2022 9:14 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX > Subject: [PATCH v5] net/ice: support dump DDP runtime configure > > Dump DDP runtime configure into a binary(package) file from ice PF

RE: [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path

2022-06-09 Thread Xia, Chenbo
+ Cheng for review > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 8, 2022 8:50 PM > To: dev@dpdk.org; jasow...@redhat.com; Xia, Chenbo ; > david.march...@redhat.com; Matz, Olivier ; Ma, > WenwuX ; Zhang, Yuying ; > Singh, Aman Deep > Cc: Maxime Coquelin > Subject:

RE: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path

2022-06-09 Thread Xia, Chenbo
+Cheng for review > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 8, 2022 8:50 PM > To: dev@dpdk.org; jasow...@redhat.com; Xia, Chenbo ; > david.march...@redhat.com; Matz, Olivier ; Ma, > WenwuX ; Zhang, Yuying ; > Singh, Aman Deep > Cc: Maxime Coquelin > Subject: [

RE: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path

2022-06-09 Thread Xia, Chenbo
+Cheng > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 8, 2022 8:50 PM > To: dev@dpdk.org; jasow...@redhat.com; Xia, Chenbo ; > david.march...@redhat.com; Matz, Olivier ; Ma, > WenwuX ; Zhang, Yuying ; > Singh, Aman Deep > Cc: Maxime Coquelin > Subject: [PATCH v2 6/

RE: [PATCH v6 1/7] eventdev/eth_rx: add adapter instance get API

2022-06-09 Thread Naga Harish K, S V
> -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 8, 2022 5:44 PM > To: jerinjac...@gmail.com; dev@dpdk.org; Jayatheerthan, Jay > > Cc: Naga Harish K, S V > Subject: [PATCH v6 1/7] eventdev/eth_rx: add adapter instance get API > > Added rte_event_eth_rx_adapter

RE: [PATCH v6 4/7] eventdev/eth_tx: add instance get API

2022-06-09 Thread Naga Harish K, S V
> -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 8, 2022 5:44 PM > To: jerinjac...@gmail.com; dev@dpdk.org; Jayatheerthan, Jay > > Cc: Naga Harish K, S V > Subject: [PATCH v6 4/7] eventdev/eth_tx: add instance get API > > Added rte_event_eth_tx_adapter_instanc

Re: [Bug 1030] rte_malloc() and rte_free() get stuck when used with signal handler

2022-06-09 Thread Sarosh Arif
On Thu, Jun 9, 2022 at 8:26 PM Stephen Hemminger wrote: > > On Thu, 09 Jun 2022 12:47:43 + > bugzi...@dpdk.org wrote: > > > https://bugs.dpdk.org/show_bug.cgi?id=1030 > > > > Bug ID: 1030 > >Summary: rte_malloc() and rte_free() get stuck when used with > >

RE: [PATCH v7 1/5] raw/ifpga: introduce AFU driver framework

2022-06-09 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Thursday, June 9, 2022 3:37 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v7 1/5] raw/ifpga: in

RE: [PATCH v7 2/5] raw/ifpga: add N3000 AFU driver

2022-06-09 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Thursday, June 9, 2022 3:37 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v7 2/5] raw/ifpga: ad

RE: [PATCH v7 3/5] raw/ifpga: add HE-LPBK AFU driver

2022-06-09 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Thursday, June 9, 2022 3:37 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v7 3/5] raw/ifpga: ad

  1   2   >