On Mon, May 23, 2022 at 10:25 PM Bruce Richardson <bruce.richard...@intel.com> wrote: > > On Mon, May 23, 2022 at 05:52:06PM +0100, McDaniel, Timothy wrote: > > > >
> > > > > > Instead, I'd recommend doing as other places in DPDK - such as in ACL > > > library, or i40e or ice net drivers - where we not only check the current > > > build support, but also check the compiler support. That way, even if we > > > are building for e.g. a target of AVX2, we can still build the AVX-512 > > > parts using the appropriate compiler flags, and choose them > > > opportunistically at runtime. > > > > I do not understand what you are getting at here. > > > Check out net/i40e/meson.build and hopefully things may become clearer. I am updating the patchwork status as "Changes requested" for this patch. @McDaniel, Timothy Please send the updated version. Also, the following patch depends on this. I will wait for the merging below after this patch is merged. https://patches.dpdk.org/project/dpdk/patch/20220410225602.1524724-1-timothy.mcdan...@intel.com/ https://patches.dpdk.org/project/dpdk/patch/20220410224755.1524117-1-timothy.mcdan...@intel.com/ > > /Bruce
