Re: [PATCH] Fix RISC-V builds

Hello, On Mon, May 30, 2022 at 4:11 PM Heinrich Schuchardt wrote: > > Building on RISC-V results in an error > > cc: error: ‘-march=native’: ISA string must begin with rv32 or rv64 > > As GCC does not support -march=native on RISC-V avoid this argument. > > Signed-off-by: Heinrich Schuchardt

Re: [PATCH 1/2] docs/bpf: fix formatting and link

28/05/2022 13:09, Konstantin Ananyev: > 27/05/2022 14:45, Harry van Haaren пишет: > > Small improvements to the documentation based on Sphinx HTML doc output. > > > > Signed-off-by: Harry van Haaren > > Acked-by: Konstantin Ananyev Fixes: 14b8f0bbe519 ("doc: add BPF library guide") Fixes: b901

Re: [PATCH 6/6] net/vhost: perform SW checksum in Tx path

Hi Wenwu, On 6/6/22 11:44, Ma, WenwuX wrote: -Original Message- From: Maxime Coquelin Sent: 2022年6月2日 17:07 To: Ma, WenwuX ; dev@dpdk.org; jasow...@redhat.com; Xia, Chenbo ; david.march...@redhat.com; Matz, Olivier Cc: sta...@dpdk.org Subject: Re: [PATCH 6/6] net/vhost: perform SW c

Re: [RFC 8/8] ip_frag: fix gcc-12 warnings

07/06/2022 18:17, Stephen Hemminger пишет: The function rte_memcpy can derference past source buffer which will cause array out of bounds warnings. But there is no good reason to use rte_memcpy instead of memcpy in this code. Memcpy is just as fast for these small inputs, and compiler will optimi

Re: [PATCH 3/6] net/vhost: enable compliant offloading mode

Hi Wenwu, On 6/7/22 03:19, Ma, WenwuX wrote: Hi Maxime, -Original Message- From: Xia, Chenbo Sent: 2022年5月16日 21:40 To: Maxime Coquelin ; dev@dpdk.org; jasow...@redhat.com; david.march...@redhat.com; olivier.m...@6wind.com Cc: sta...@dpdk.org Subject: RE: [PATCH 3/6] net/vhost: enable

Re: Lgtm scan of DPDK

28/05/2022 01:12, Stephen Hemminger: > I just discovered that there is another tool similar to Coverity for scanning. > It gives different results, and might be useful. > The scans of github open source projects is already done. > > See: https://lgtm.com/projects/g/DPDK/dpdk > > Shows 19 errors,

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob wrote: > > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon wrote: > > > > 02/06/2022 11:43, Jerin Jacob: > > > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson > > > wrote: > > > > > > > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jer...@marvell.com wrote

[PATCH] vdpa/ifc: fix null pointer dereference

Fix null pointer dereference reported in coverity scan. Coverity issue: 378882 Fixes: 8162a4a9 ("vdpa/ifc/base: access correct register for blk device") Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/vdpa/ifc/base/if

RE: [PATCH] vdpa/ifc: fix null pointer dereference

Hi > -Original Message- > From: Pei, Andy > Sent: Wednesday, June 8, 2022 3:34 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; > Wang, Xiao W ; Xu, Rosen ; > Xiao, QimaiX > Subject: [PATCH] vdpa/ifc: fix null pointer dereference > > Fix null pointer dereference rep

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

08/06/2022 10:22, Jerin Jacob: > On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob wrote: > > > > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon wrote: > > > > > > 02/06/2022 11:43, Jerin Jacob: > > > > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson > > > > wrote: > > > > > > > > > > On Thu, Jun 02, 2

RE: Lgtm scan of DPDK

> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 8, 2022 9:23 AM > To: Stephen Hemminger > Cc: dev@dpdk.org; Mcnamara, John ; > david.march...@redhat.com > Subject: Re: Lgtm scan of DPDK > > 28/05/2022 01:12, Stephen Hemminger: > > I just discovered that there is anot

Re: [PATCH v4 1/7] devtools: add Atomic Rules acronyms for commit checks

On 6/7/2022 10:31 PM, Ed Czeck wrote: DDM -> Downstream Data Mover MPU -> Mbuf Prefetch Unit UDM -> Upstream Data Mover Signed-off-by: Ed Czeck Acked-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks.

Re: [PATCH v4 0/8] Introduce support for RISC-V architecture

On Tue, May 31, 2022 at 4:14 PM Stanislaw Kardach wrote: > > This patchset adds support for building and running DPDK on 64bit RISC-V > architecture. The initial support targets rv64gc (rv64imafdc) ISA and > was tested on SiFive Unmatched development board with the Freedom U740 > SoC running Linux

Re: [PATCH] dma/idxd: fix return value for pci device commands

07/06/2022 12:56, Walsh, Conor: > > > Subject: [PATCH] dma/idxd: fix return value for pci device commands > > > > When sending a command to an idxd device via pci bar, the response from > > HW is checked to ensure it was successful. The response was incorrectly > > being negated before being retu

Re: [PATCH] dma/idxd: fix return value for pci device commands

On 08/06/2022 09:54, Thomas Monjalon wrote: 07/06/2022 12:56, Walsh, Conor: Subject: [PATCH] dma/idxd: fix return value for pci device commands When sending a command to an idxd device via pci bar, the response from HW is checked to ensure it was successful. The response was incorrectly being n

Re: [PATCH] raw/cnxk_gpio: allow controlling existing GPIO

04/06/2022 16:03, Tomasz Duszynski: > Controlling existing GPIO should be normally frowned upon because > we want to avoid situation where multiple contenders modify GPIO > state simultaneously. > > Still there might be situations where this is actually needed. > Restarting killed application bein

RE: [PATCH 11/12] app/flow-perf: fix build with GCC 12

Hi David, > -Original Message- > From: David Marchand > Sent: Wednesday, May 18, 2022 1:17 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > ferruh.yi...@xilinx.com; sta...@dpdk.org; Wisam Monther > > Subject: [PATCH 11/12] app/flow-perf: fix build with GCC 12 > > G

Re: [PATCH] mempool/cnxk: avoid batch op free for empty mempools

28/04/2022 11:59, Ashwin Sekhar T K: > Batch op data is initialized inside mempool alloc. But > in case of empty mempools, the alloc function is not > called and hence the initialization of batch op data is > also not done. So ensure the validity of batch op data > inside mempool free. > > Signed-

Re: [PATCH v4 0/8] Introduce support for RISC-V architecture

On Wed, Jun 8, 2022 at 10:41 AM David Marchand wrote: > On Tue, May 31, 2022 at 4:14 PM Stanislaw Kardach wrote: > > > > This patchset adds support for building and running DPDK on 64bit RISC-V > > architecture. The initial support targets rv64gc (rv64imafdc) ISA and > > was tested on SiFive Unma

[PATCH v3] sched: enable CMAN at runtime

Added changes to enable CMAN (RED or PIE) at init from profile configuration file. By default CMAN code is enable but not in use, when there is no RED or PIE profile configured. Signed-off-by: Marcin Danilewicz --- Log: v2 change in rte_sched.h to avoid ABI breakage. v3 changes from comment

Re: [PATCH v5 0/7] introduce per-queue available descriptor threshold and host shaper

@Matan, @Viacheslav, could you review mlx5 patches of the series, please. On 6/7/22 15:59, Spike Du wrote: available descriptor threshold(ADT for short) is per RX queue attribute, when RX queue available descriptors for HW is below ADT, HW sends an event to application. Host shaper can configu

[PATCH v3] gro: bug fix in identifying fragmented packets

From: Kumara Parameshwaran A packet with RTE_PTYPE_L4_FRAG(0x300) contains both RTE_PTYPE_L4_TCP (0x100) & RTE_PTYPE_L4_UDP (0x200). A fragmented packet as defined in rte_mbuf_ptype.h cannot be recognized as other L4 types and hence the GRO layer should not use IS_IPV4_TCP_PKT or IS_IPV4_UDP_PKT

Re: [PATCH v4 0/8] Introduce support for RISC-V architecture

On Wed, Jun 8, 2022 at 11:32 AM David Marchand wrote: > > On Wed, Jun 8, 2022 at 10:41 AM David Marchand > wrote: > > On Tue, May 31, 2022 at 4:14 PM Stanislaw Kardach wrote: > > > > > > This patchset adds support for building and running DPDK on 64bit RISC-V > > > architecture. The initial supp

Re: [PATCH v6] examples/l3fwd: merge l3fwd-acl into l3fwd

22/04/2022 11:57, Sean Morrissey: > l3fwd-acl contains duplicate functions to l3fwd. > For this reason we merge l3fwd-acl code into l3fwd > with '--lookup acl' cmdline option to run ACL. > > Signed-off-by: Sean Morrissey > Acked-by: Konstantin Ananyev With few text improvements, applied, thanks

Re: [PATCH v4 0/8] Introduce support for RISC-V architecture

On 6/8/22 10:41, David Marchand wrote: On Tue, May 31, 2022 at 4:14 PM Stanislaw Kardach wrote: This patchset adds support for building and running DPDK on 64bit RISC-V architecture. The initial support targets rv64gc (rv64imafdc) ISA and was tested on SiFive Unmatched development board with t

Re: [PATCH] Fix RISC-V builds

On 6/8/22 09:23, David Marchand wrote: Hello, On Mon, May 30, 2022 at 4:11 PM Heinrich Schuchardt wrote: Building on RISC-V results in an error cc: error: ‘-march=native’: ISA string must begin with rv32 or rv64 As GCC does not support -march=native on RISC-V avoid this argument. Sign

[PATCH v4] gro: bug fix in identifying fragmented packets

From: Kumara Parameshwaran A packet with RTE_PTYPE_L4_FRAG(0x300) contains both RTE_PTYPE_L4_TCP (0x100) & RTE_PTYPE_L4_UDP (0x200). A fragmented packet as defined in rte_mbuf_ptype.h cannot be recognized as other L4 types and hence the GRO layer should not use IS_IPV4_TCP_PKT or IS_IPV4_UDP_PKT

Re: [PATCH] Fix RISC-V builds

On Wed, Jun 8, 2022 at 11:56 AM Heinrich Schuchardt wrote: > > On 6/8/22 09:23, David Marchand wrote: > > Hello, > > > > On Mon, May 30, 2022 at 4:11 PM Heinrich Schuchardt > > wrote: > >> > >> Building on RISC-V results in an error > >> > >> cc: error: ‘-march=native’: ISA string must begin

Re: [PATCH v3 1/4] ethdev: introduce ethdev HW desc dump PI

Cc various driver maintainers looking for opinion about API discussion below On 6/7/22 16:59, Dongdong Liu wrote: Hi Andrew Many thanks for your review. On 2022/6/2 3:53, Andrew Rybchenko wrote: On 6/1/22 10:49, Min Hu (Connor) wrote: Added the ethdev HW Rx desc dump API which provides funct

Re: [PATCH] eal: fix segment fault when exit trace

On Tue, Jun 7, 2022 at 5:36 PM Chengwen Feng wrote: > > Bug scenario: > 1. start testpmd: > dpdk-testpmd -l 4-6 -a :7d:00.0 --trace=.* -- -i > 2. quit testpmd and then observed segment fault: > Bye... > Segmentation fault (core dumped) > > The root cause is that rte_tra

Re: [PATCH] Fix RISC-V builds

On 6/8/22 12:01, David Marchand wrote: On Wed, Jun 8, 2022 at 11:56 AM Heinrich Schuchardt wrote: @Keith Maybe CONTRIBUTING.txt in that package should suggest a title prefix for PktGen patches to avoid future confusion. Yes, and I marked the patch as Not applicable in patchwork. See https:

[PATCH v4 0/2] kni: fix build warnings with Linux 5.17+

v4: - restore original patch author - resend with cover letter to address patchwork recognition as a series v3: - split single patch into two - clarify patches summary and description Ke Zhang (2): kni: use dedicated function to set random MAC address kni: fix warning ab

[PATCH v4 1/2] kni: use dedicated function to set random MAC address

From: Ke Zhang eth_hw_addr_random() sets address type correctly. eth_hw_addr_random() is available since Linux v3.4, so no compat is required. Also fix the warning: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const inten

[PATCH v4 2/2] kni: fix warning about discarding const qualifier

From: Ke Zhang The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const intentionally in v5.17 to prevent using it directly. See kernel series [1] for more information. [1] https://lore.kernel.org/netdev/YZYAb4

[PATCH v5 1/7] eventdev/eth_rx: add adapter instance get API

Added rte_event_eth_rx_adapter_instance_get() to get adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index bf8741d..d1b4874 100644 --- a/lib/

[PATCH v5 2/7] eventdev/eth_rx: add telemetry callback for instance get

Added telemetry handler for rte_event_eth_rx_adapter_instance_get() to retrieve adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index d1b4874

[PATCH v5 3/7] test/eth_rx: add test case for instance get API

Added test case for rte_event_eth_rx_adapter_instance_get() Signed-off-by: Ganapati Kundapura diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c index e358a70..878004b 100644 --- a/app/test/test_event_eth_rx_adapter.c +++ b/app/test/test_event_eth_rx_adapte

[PATCH v5 4/7] eventdev/eth_tx: add instance get API

Added rte_event_eth_tx_adapter_instance_get() to get the adapter instance id for specified ethernet device id and tx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h index f56938d..45140a6 100644 --- a/

[PATCH v5 7/7] doc/eth_tx: update instance get API

Added rte_event_eth_tx_adapter_instance_get() details. Signed-off-by: Ganapati Kundapura diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst index f80d226..dc3e6a1 100644 --- a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst

[PATCH v5 6/7] doc/eth_rx: update instance get API

Added rte_event_eth_rx_adapter_instance_get() details Signed-off-by: Ganapati Kundapura diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst index 3b4ef50..5b9d0cf 100644 --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst

[PATCH v5 5/7] test/eth_tx: add testcase for instance get API

Added testcase for rte_event_eth_tx_adapter_instance_get() Signed-off-by: Ganapati Kundapura diff --git a/app/test/test_event_eth_tx_adapter.c b/app/test/test_event_eth_tx_adapter.c index 2900532..ebbc622 100644 --- a/app/test/test_event_eth_tx_adapter.c +++ b/app/test/test_event_eth_tx_adapter

Re: [PATCH v2 06/11] net/hns3: fix coverity codecheck

Hi Dongdong, On 6/6/22 10:48, Dongdong Liu wrote: Hi Andrew Many thanks for your review. I will take over Hu Min's current work and continue to do the upstream work. On 2022/6/1 16:32, Andrew Rybchenko wrote: On 6/1/22 06:52, Min Hu (Connor) wrote: In bitwise operation, "val" should be an

RE: [PATCH v4] eventdev: add adapter instance get API

Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: 08 June 2022 09:57 > To: Kundapura, Ganapati ; > jerinjac...@gmail.com; dev@dpdk.org; Jayatheerthan, Jay > > Subject: RE: [PATCH v4] eventdev: add adapter instance get API > > Hi Ganapati, >Some comments inline. > >

RE: [PATCH v3] eventdev: add adapter instance get API

Hi Jay, Patch is split into 7 patch sets in V5 as suggested. Thanks, Ganapati > -Original Message- > From: Jayatheerthan, Jay > Sent: 07 June 2022 18:49 > To: Kundapura, Ganapati ; > jerinjac...@gmail.com; dev@dpdk.org > Subject: RE: [PATCH v3] eventdev: add adapter instance get API >

Re: [PATCH] app/testpmd: fix packets segments allocation

On 6/2/22 15:59, Raja Zidane wrote: When --mbuf-size cmdln parameter is specified, the segments to scatter packets on are allocated sequentially from these extra memory pools (the mbuf for the first segment is allocated from the first pool, the second one from the second pool, and so on, if segme

RE: [PATCH v3 0/7] ethdev: separate metering and marking from policing

> -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 4:44 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; > jerinjac...@gmail.com; or...@nvidia.com; tho...@monjalon.net; > ivan.ma...@oktetlabs.ru; andrew.rybche...@oktetlabs.ru; > ferruh.yi...@xilinx.com; Awa

[PATCH v2] eal: remove unused arch specific headers for locks

MCS lock, PF lock and Ticket lock have no arch specific implementation, there is no need for the extra redirection in headers. Signed-off-by: David Marchand Acked-by: Stephen Hemminger --- Note: this was mentionned during the seqlock patch review, and I spotted it again, while reviewing the RISC

[PATCH 1/2] common/mlx5: update log format after devx_general_cmd error

Application can fetch syndrome value after FW operation failure starting from Mellanox OFED-5.6. The patch updates log data issued after devx_general_cmd error. Signed-off-by: Gregory Etelson Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 103 --- 1 fil

[PATCH 2/2] common/mlx5: update log format after devx_obj_create error

Application can fetch syndrome value after FW operation failure starting from Mellanox OFED-5.6. The patch updates log data after devx_obj_create error. Signed-off-by: Gregory Etelson Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 77 ++-- 1 file change

RE: [PATCH v3] sched: enable CMAN at runtime

> -Original Message- > From: Danilewicz, MarcinX > Sent: Wednesday, June 8, 2022 10:42 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v3] sched: enable CMAN at runtime > > Added changes to enable CMAN (RED or PIE) at init > from

Re: [PATCH v3] app/testpmd: fix issue with memory leaks when quit testpmd

On 4/4/2022 4:34 PM, Zhang, Yuying wrote: Hi Ke, -Original Message- From: Zhang, Ke1X Sent: Friday, March 25, 2022 4:36 PM To: Li, Xiaoyun ; Singh, Aman Deep ; Zhang, Yuying ; dev@dpdk.org Cc: Zhang, Ke1X Subject: [PATCH v3] app/testpmd: fix issue with memory leaks when quit testpmd

Re: [PATCH v3 1/1] app/testpmd: support different input color method

On 6/3/22 16:06, sk...@marvell.com wrote: From: Sunil Kumar Kori To enable input coloring, based on VLAN or DSCP, patch adds command line interface to configure the following: - configuring input coloring using VLAN or DSCP while creating meter i.e. during rte_mtr_create() - Update VL

[PATCH v5 0/2] kni: fix build warnings with Linux 5.17+

v5: - fix broken build v4: - restore original patch author - resend with cover letter to address patchwork recognition as a series v3: - split single patch into two - clarify patches summary and description Ke Zhang (2): kni: use dedicated function to set random MAC a

[PATCH v5 1/2] kni: use dedicated function to set random MAC address

From: Ke Zhang eth_hw_addr_random() sets address type correctly. eth_hw_addr_random() is available since Linux v3.4, so no compat is required. Also fix the warning: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const inten

[PATCH v5 2/2] kni: fix warning about discarding const qualifier

From: Ke Zhang The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const intentionally in v5.17 to prevent using it directly. See kernel series [1] for more information. [1] https://lore.kernel.org/netdev/YZYAb4

[PATCH v6 1/7] eventdev/eth_rx: add adapter instance get API

Added rte_event_eth_rx_adapter_instance_get() to get adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura --- v6: * rx adapter changes removed from patch4 and moved to patch1 v5: * patch is split into saperate patches v4: * Moved instance ar

[PATCH v6 2/7] eventdev/eth_rx: add telemetry callback for instance get

Added telemetry handler for rte_event_eth_rx_adapter_instance_get() to retrieve adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index d1b4874

[PATCH v6 3/7] test/eth_rx: add test case for instance get API

Added test case for rte_event_eth_rx_adapter_instance_get() Signed-off-by: Ganapati Kundapura diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c index e358a70..878004b 100644 --- a/app/test/test_event_eth_rx_adapter.c +++ b/app/test/test_event_eth_rx_adapte

[PATCH v6 4/7] eventdev/eth_tx: add instance get API

Added rte_event_eth_tx_adapter_instance_get() to get the adapter instance id for specified ethernet device id and tx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c index 1b304f0..d9de6e5 100644 --- a/

[PATCH v6 5/7] test/eth_tx: add testcase for instance get API

Added testcase for rte_event_eth_tx_adapter_instance_get() Signed-off-by: Ganapati Kundapura diff --git a/app/test/test_event_eth_tx_adapter.c b/app/test/test_event_eth_tx_adapter.c index 2900532..ebbc622 100644 --- a/app/test/test_event_eth_tx_adapter.c +++ b/app/test/test_event_eth_tx_adapter

[PATCH v6 6/7] doc/eth_rx: update instance get API

Added rte_event_eth_rx_adapter_instance_get() details Signed-off-by: Ganapati Kundapura diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst index 3b4ef50..5b9d0cf 100644 --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst

[PATCH v6 7/7] doc/eth_tx: update instance get API

Added rte_event_eth_tx_adapter_instance_get() details. Signed-off-by: Ganapati Kundapura diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst index f80d226..dc3e6a1 100644 --- a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst

Re: [PATCH 11/12] app/flow-perf: fix build with GCC 12

On Wed, Jun 8, 2022 at 11:03 AM Wisam Monther wrote: > > Hi David, > > > -Original Message- > > From: David Marchand > > Sent: Wednesday, May 18, 2022 1:17 PM > > To: dev@dpdk.org > > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > > ferruh.yi...@xilinx.com; sta...@dpdk.org; Wisam Monther

Re: [PATCH v4 0/8] Introduce support for RISC-V architecture

On Wed, Jun 8, 2022 at 10:42 AM David Marchand wrote: > > On Tue, May 31, 2022 at 4:14 PM Stanislaw Kardach wrote: > > > > This patchset adds support for building and running DPDK on 64bit RISC-V > > architecture. The initial support targets rv64gc (rv64imafdc) ISA and > > was tested on SiFive Un

Re: [RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12

wt., 7 cze 2022 o 19:17 Stephen Hemminger napisał(a): > > Rte_memcpy is not needed for small objects only used on control > path. Regular memcpy is as fast or faster and there is more > robust since static analysis etc knows what it does. > > In this driver it was redefining all memcpy as rte_memc

Re: [dpdk-dev] [PATCH 0/2] fixes for failsafe/tap

On 6/7/22 09:49, Yunjian Wang wrote: This series include two fixes patches for failsafe/tap Yunjian Wang (2): net/failsafe: fix freeing after device release net/tap: fix use after free on error path drivers/net/failsafe/failsafe.c | 2 +- drivers/net/tap/rte_eth_tap.c | 2 +- 2 file

[PATCH v2 0/6] Vhost checksum offload improvements

This series aims at improving Vhost checksum offloading support. The first patch reverts overwritting MAC address in testpmd CSUM forward mode. This is required to be able to test checksum offloading with real traffic. MAC forwarding mode should be used if the MAC addresses need to be changed. Se

[PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding"

This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"), as the checksum forwarding is expected to only perform checksum and not also overwrites the source and destination MAC addresses. Doing so, we can test checksum offloading with real traffic without breaking bro

[PATCH v2 2/6] vhost: fix missing enqueue pseudo-header calculation

The Virtio specification requires that in case of checksum offloading, the pseudo-header checksum must be set in the L4 header. When received from another Vhost-user port, the packet checksum might already contain the pseudo-header checksum but we have no way to know it. So we have no other choice

[PATCH v2 3/6] net/vhost: enable compliant offloading mode

This patch enables the compliant offloading flags mode by default, which prevents the Rx path to set Tx offload flags, which is illegal. A new legacy-ol-flags devarg is introduced to enable the legacy behaviour. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- doc/guides/nics/vhost.rs

[PATCH v2 4/6] net/vhost: make VLAN stripping flag a boolean

This trivial patch makes the vlan_strip field of the pmd_internal struct a boolean, since it is handled as such. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/vhost/rte_eth_vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vhost/rte

[PATCH v2 5/6] net/vhost: perform SW checksum in Rx path

Virtio specification supports host checksum offloading for L4, which is enabled with VIRTIO_NET_F_CSUM feature negotiation. However, the Vhost PMD does not advertise Rx checksum offload capabilities, so we can end-up with the VIRTIO_NET_F_CSUM feature being negotiated, implying the Vhost library re

[PATCH v2 6/6] net/vhost: perform SW checksum in Tx path

Virtio specification supports guest checksum offloading for L4, which is enabled with VIRTIO_NET_F_GUEST_CSUM feature negotiation. However, the Vhost PMD does not advertise Tx checksum offload capabilities. Advertising these offload capabilities at the ethdev level is not enough, because we could

Re: [PATCH v5 1/2] kni: use dedicated function to set random MAC address

On 6/8/2022 1:11 PM, Andrew Rybchenko wrote: From: Ke Zhang eth_hw_addr_random() sets address type correctly. eth_hw_addr_random() is available since Linux v3.4, so no compat is required. Also fix the warning: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer tar

Re: [PATCH v5 2/2] kni: fix warning about discarding const qualifier

On 6/8/2022 1:11 PM, Andrew Rybchenko wrote: From: Ke Zhang The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const intentionally in v5.17 to prevent using it directly. See kernel series [1] for more inform

Re: [PATCH v5 2/2] kni: fix warning about discarding const qualifier

On 6/8/2022 1:54 PM, Ferruh Yigit wrote: On 6/8/2022 1:11 PM, Andrew Rybchenko wrote: From: Ke Zhang The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const intentionally in v5.17 to prevent using it direc

Re: [PATCH v2] eal: remove unused arch specific headers for locks

On Wed, Jun 8, 2022 at 1:57 PM David Marchand wrote: > > MCS lock, PF lock and Ticket lock have no arch specific implementation, > there is no need for the extra redirection in headers. > > Signed-off-by: David Marchand > Acked-by: Stephen Hemminger > --- > Note: this was mentionned during the s

Re: [PATCH v2] eal: remove unused arch specific headers for locks

08/06/2022 15:16, Stanisław Kardach: > On Wed, Jun 8, 2022 at 1:57 PM David Marchand > wrote: > > > > MCS lock, PF lock and Ticket lock have no arch specific implementation, > > there is no need for the extra redirection in headers. > > > > Signed-off-by: David Marchand > > Acked-by: Stephen Hem

Re: [PATCH 0/4] clean up zero-length arrays

On Thu, 2 Jun 2022 16:08:30 +0100 Bruce Richardson wrote: > This patchset adds a coccinelle script to clean-up zero-length > arrays in structures. The final patches are the result of running > that script on the DPDK repository. > > Bruce Richardson (4): > cocci: add script for zero-length ar

Re: [RFC 8/8] ip_frag: fix gcc-12 warnings

On Wed, 8 Jun 2022 09:19:20 +0100 Konstantin Ananyev wrote: > 07/06/2022 18:17, Stephen Hemminger пишет: > > The function rte_memcpy can derference past source buffer which > > will cause array out of bounds warnings. But there is no good reason > > to use rte_memcpy instead of memcpy in this cod

RE: [PATCH v3] sched: enable CMAN at runtime

Hi Cristian, Ok, let me check. BR, /Marcin > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, June 8, 2022 1:59 PM > To: Danilewicz, MarcinX ; dev@dpdk.org; > Singh, Jasvinder > Cc: Ajmera, Megha ; Liu, Yu Y > > Subject: RE: [PATCH v3] sched: enable CMAN at runtime >

Re: [RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12

On Wed, 8 Jun 2022 14:29:58 +0200 Michał Krawczyk wrote: > wt., 7 cze 2022 o 19:17 Stephen Hemminger > napisał(a): > > > > Rte_memcpy is not needed for small objects only used on control > > path. Regular memcpy is as fast or faster and there is more > > robust since static analysis etc knows wh

Re: [PATCH v2] build: try to get kernel version from kernel source

On Tue, Mar 8, 2022 at 4:55 PM Ferruh Yigit wrote: > > On 3/3/2022 1:15 PM, Ferdinand Thiessen wrote: > > When building the kernel modules, try to get the kernel > > version from the kernel sources first. This fixes the > > kernel modules installation directory if the target kernel > > version dif

[PATCH] devtools: unify cross-compilation tests

Reduce the number of Arm builds from 3 to 1: only generic armv8 with GCC. The specific PPC builds on Ubuntu are skipped. The build directories for PPC and RISC-V are also renamed for consistency: - build-arm64-generic-gcc - build-ppc64-power8-gcc - build-riscv64-generic-gcc

[PATCH v6] pcap: support MTU set for linux interafces

Support rte_eth_dev_set_mtu for pcap ifaces vdevs by setting the underlying OS network interface's MTU. Support is for pcap ifaces only and not for pcap files. Support is for Linux only. Bugzilla ID: 961 Signed-off-by: Ido Goshen --- v6: Fixes for v5 approach 1. freebsd compilation fix 2. checkp

Re: [PATCH v6] pcap: support MTU set for linux interafces

On Wed, 8 Jun 2022 19:04:19 +0300 Ido Goshen wrote: > +int > +osdep_iface_mtu_set(const char *if_name, uint16_t mtu) > +{ > + struct ifreq ifr; > + int if_fd = socket(AF_INET, SOCK_DGRAM, 0); > + > + if (if_fd == -1) > + return -1; > + > + rte_strscpy(ifr.ifr_name, if

Re: [PATCH] devtools: unify cross-compilation tests

On Wed, Jun 8, 2022 at 5:50 PM Thomas Monjalon wrote: > > Reduce the number of Arm builds from 3 to 1: > only generic armv8 with GCC. > The specific PPC builds on Ubuntu are skipped. > > The build directories for PPC and RISC-V > are also renamed for consistency: > - build-arm64-generic-gc

[PATCH v6] ethdev: introduce available Rx descriptors threshold

From: Spike Du A new event RTE_ETH_EVENT_RX_AVAIL_THRESH should be generated by HW when number of available descriptors in Rx queue goes below the threshold. The threshold is defined as a percentage of an Rx queue size with valid values from 0 to 99 (inclusive). Zero (default) value disables it.

[dpdk-dev] [PATCH v2] build: ccache support for cross build

From: Jerin Jacob By default, ccache is not used for cross build[1]. Update all cross files to use ccache if it is available in build machine. Also, updated devtools/test-meson-builds.sh script to find the correct DPDK_TARGET due to change in cross file syntax. [1] https://mesonbuild.com/Machin

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

On Wed, Jun 8, 2022 at 2:00 PM Thomas Monjalon wrote: > > 08/06/2022 10:22, Jerin Jacob: > > On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob wrote: > > > > > > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon > > > wrote: > > > > > > > > 02/06/2022 11:43, Jerin Jacob: > > > > > On Thu, Jun 2, 2022 at

Re: [PATCH] devtools: unify cross-compilation tests

08/06/2022 18:34, David Marchand: > On Wed, Jun 8, 2022 at 5:50 PM Thomas Monjalon wrote: > > > > Reduce the number of Arm builds from 3 to 1: > > only generic armv8 with GCC. > > The specific PPC builds on Ubuntu are skipped. > > > > The build directories for PPC and RISC-V > > are also renamed f

Re: [PATCH v6] ethdev: introduce available Rx descriptors threshold

08/06/2022 18:35, Andrew Rybchenko: > From: Spike Du > > A new event RTE_ETH_EVENT_RX_AVAIL_THRESH should be generated by HW > when number of available descriptors in Rx queue goes below the > threshold. > > The threshold is defined as a percentage of an Rx queue size with valid > values from 0

Re: [PATCH v5 0/2] kni: fix build warnings with Linux 5.17+

On 6/8/22 15:11, Andrew Rybchenko wrote: v5: - fix broken build v4: - restore original patch author - resend with cover letter to address patchwork recognition as a series v3: - split single patch into two - clarify patches summary and description Ke Zhang (2):

Re: [PATCH v6] ethdev: introduce available Rx descriptors threshold

08/06/2022 19:22, Thomas Monjalon: > 08/06/2022 18:35, Andrew Rybchenko: > > From: Spike Du > > > > A new event RTE_ETH_EVENT_RX_AVAIL_THRESH should be generated by HW > > when number of available descriptors in Rx queue goes below the > > threshold. > > > > The threshold is defined as a percent

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

On Wed, Jun 8, 2022 at 7:17 PM Jerin Jacob wrote: > > On Wed, Jun 8, 2022 at 2:00 PM Thomas Monjalon wrote: > > > > 08/06/2022 10:22, Jerin Jacob: > > > On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob wrote: > > > > > > > > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon > > > > wrote: > > > > > > >

Re: [RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12

śr., 8 cze 2022 o 17:32 Stephen Hemminger napisał(a): > > On Wed, 8 Jun 2022 14:29:58 +0200 > Michał Krawczyk wrote: > > > wt., 7 cze 2022 o 19:17 Stephen Hemminger > > napisał(a): > > > > > > Rte_memcpy is not needed for small objects only used on control > > > path. Regular memcpy is as fast o

Re: [PATCH v5 1/7] net/mlx5: add LWM support for Rxq

Series-acked-by: Matan Azrad mailto:ma...@nvidia.com>> קבל ‏Outlook עבור Android‏ From: Spike Du Sent: Tuesday, June 7, 2022 3:59:36 PM To: Matan Azrad ; Slava Ovsiienko ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) Cc: andrew.rybch

release candidate 22.07-rc1

A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v22.07-rc1 There are 576 new patches in this snapshot, constituting what the reviewers and maintainers were able to handle. Release notes: https://doc.dpdk.org/guides/rel_notes/release_22_07.html

Re: [RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12

On Wed, 8 Jun 2022 21:18:15 +0200 Michał Krawczyk wrote: > śr., 8 cze 2022 o 17:32 Stephen Hemminger > napisał(a): > > > > On Wed, 8 Jun 2022 14:29:58 +0200 > > Michał Krawczyk wrote: > > > > > wt., 7 cze 2022 o 19:17 Stephen Hemminger > > > napisał(a): > > > > > > > > Rte_memcpy is not ne

RE: [PATCH v1] bbdev: add device status info

Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, June 7, 2022 9:43 AM > To: Maxime Coquelin > Cc: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com; hemant.agra...@nxp.com; Vargas, > Hernan > Subject: Re: [PATCH v1] bbdev: add device stat

  1   2   >