RE: [PATCH v4 0/3] introduce random floating point function

2022-05-26 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 25 May 2022 22.31 > > Introduce a new random number function to get a floating > point value. Then use it to fix PIE scheduler. > > v4 >- use slower divide method in rte_drand() if library > does not have ie

[PATCH v9 0/5] add telemetry command for show module EEPROM

2022-05-26 Thread Robin Zhang
Introduce a new telemetry command /ethdev/module_eeprom to show module EEPROM for each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/ QSFP+(Quad Small Formfactor Pluggable)/

[PATCH v9 1/5] ethdev: add telemetry command for module EEPROM

2022-05-26 Thread Robin Zhang
Add a new telemetry command /ethdev/module_eeprom to dump the module EEPROM of each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- devtools/words-case.txt| 1 + lib/ethdev/m

[PATCH v9 2/5] ethdev: add common code for different SFF specs

2022-05-26 Thread Robin Zhang
Add support for SFF-8024 Rev 4.0 of pluggable I/O configuration and some common utilities for SFF-8436/8636 and SFF-8472/8079. Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- lib/ethdev/meson.build | 1 + lib/ethdev/sff_common.c | 319 lib/eth

[PATCH v9 3/5] ethdev: support SFF-8079 module information telemetry

2022-05-26 Thread Robin Zhang
Add support for module EEPROM information format defined in SFF-8079 Rev 1.7. Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- lib/ethdev/meson.build | 1 + lib/ethdev/sff_8079.c | 401 + lib/ethdev/sff_telemetry.c | 3 + 3 files changed,

[PATCH v9 4/5] ethdev: support SFF-8472 module information telemetry

2022-05-26 Thread Robin Zhang
Add support for module EEPROM information format defined in SFF-8472 Rev 12.0 Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- lib/ethdev/meson.build | 1 + lib/ethdev/sff_8472.c | 280 + lib/ethdev/sff_telemetry.c | 4 + 3 files changed,

[PATCH v9 5/5] ethdev: support SFF-8636 module information telemetry

2022-05-26 Thread Robin Zhang
Add support for module EEPROM information format defined in SFF-8636 Rev 2.7. Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- lib/ethdev/meson.build | 1 + lib/ethdev/sff_8636.c | 764 + lib/ethdev/sff_8636.h | 590

[v7, 00/11] Add JSON vector set support to fips validation

2022-05-26 Thread Gowrishankar Muthukrishnan
Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. v7: * Fixed individual patches

[v7, 01/11] examples/fips_validation: add jansson dependency

2022-05-26 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added a check for RTE_HAS_JANSSON into the meson configuration file for JSON support. Signed-off-by: Brandon Lo --- examples/fips_validation/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/meson.build b/examples/fips_validation/mes

[v7, 02/11] examples/fips_validation: add json info to header

2022-05-26 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added json-specific functions and other information needed to test the new FIPS test vectors. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan --- v7: * fix switch clause for info.file_type. v5: * fix typo in macro name for prefixes. v2: * fix type of pref

[v7, 03/11] examples/fips_validation: add json parsing

2022-05-26 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added functions to parse the required information from a vector set given in the new json format. Signed-off-by: Brandon Lo --- v7: * pulled json_info define from next patch. v3: * fix checkpatch warnings v2: * fix for loop initialization --- examples/fips_validation/fips_va

[v7, 04/11] examples/fips_validation: allow json file as input

2022-05-26 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added the ability to use the json format as the input and output of the example application. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v5: * fix to check info.file_type in json file type as well. v3: * fix checkpatch warnings v2: * remove use_jso

[v7, 05/11] examples/fips_validation: add json to gcm test

2022-05-26 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds json-specific testing and writeback function. Allows the user to test AES-GCM vector sets. Signed-off-by: Brandon Lo --- v3: * fix checkpatch warnings --- examples/fips_validation/fips_validation.h| 3 + .../fips_validation/fips_validation_gcm.c | 151 ++

[v7, 06/11] examples/fips_validation: add json to hmac

2022-05-26 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds JSON support for the HMAC algorithm. Signed-off-by: Brandon Lo --- examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 6 ++ .../fips_validation/fips_validation_hmac.c| 93 +++ examples/fips_validation

[v7, 07/11] examples/fips_validation: implement json cmac test

2022-05-26 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Implemented JSON support for the CMAC test. Signed-off-by: Brandon Lo -- v5: * parser_read_cmac_direction_str is static. --- examples/fips_validation/fips_validation.h| 3 + .../fips_validation/fips_validation_cmac.c| 80 +++ 2 files changed, 83 insert

[v7, 08/11] examples/fips_validation: add parsing for cmac

2022-05-26 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added function to parse algorithm for CMAC test. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v5: * parser_read_cmac_direction_str implementation moved to static. --- examples/fips_validation/fips_validation.c | 19 --- examples/fips_

[v7, 09/11] examples/fips_validation: cleanup bypass tests in response file

2022-05-26 Thread Gowrishankar Muthukrishnan
Remove garbage entries for bypassed tests in response file. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 74 - 1 file changed, 35 insertions(+), 39 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_valida

[v7, 10/11] examples/fips_validation: reset IV generation in every test group

2022-05-26 Thread Gowrishankar Muthukrishnan
Reset IV generation in every test group. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_gcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c index 3604b21

[v7, 11/11] examples/fips_validation: add parsing for aes_cbc

2022-05-26 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES_CBC test. Signed-off-by: Gowrishankar Muthukrishnan -- v6: * fixed local variable initialization in fips_mct_aes_test. --- examples/fips_validation/fips_validation.c| 8 +- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/

[PATCH] event/cnxk: add free for Tx adapter

2022-05-26 Thread Volodymyr Fialko
Tx adapter allocate data during eth_tx_adapter_queue_add() call and it's only cleaned but not freed during eth_tx_adapter_queue_del(). Implemented eth_tx_adapter_free() callback to free adapter data. Signed-off-by: Volodymyr Fialko --- drivers/event/cnxk/cn10k_eventdev.c | 3 +++ drivers/e

RE: [dpdk-dev v2] crypto/qat: fix of offset and length assignment

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Wednesday, April 6, 2022 2:45 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v2] crypto/qat: fix of offset and length assignment > > This patch fix the cipher & auth offset and length values when convert > mbuf to

Re: [PATCH v5] eal: add bus cleanup to eal cleanup

2022-05-26 Thread Kevin Laatz
On 25/05/2022 12:12, Bruce Richardson wrote: On Wed, May 25, 2022 at 11:39:53AM +0100, Kevin Laatz wrote: During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be

RE: [dpdk-dev v3] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-26 Thread Zhang, Roy Fan
Hi Kai, > -Original Message- > From: Ji, Kai > Sent: Wednesday, May 25, 2022 5:52 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Richardson, Bruce > ; gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v3] crypto/qat: use intel-ipsec-mb for partial hash & aes > > Since openssl 3.0 now depre

[PATCH 1/3] common/sfc_efx/base: convert EFX PCIe INTF to MCDI value

2022-05-26 Thread Ivan Malov
When the driver queries its PCIe interface type via MCDI, the value from the response is translated to an EFX enum. When the driver passes this enum value back to any other MCDI helper, the inverse translation has to be conducted. Fixes: 1bf9ff57ccb3 ("common/sfc_efx/base: allow getting VNIC MCDI

[PATCH 2/3] common/sfc_efx/base: manage VNIC MAC address by MCDI handle

2022-05-26 Thread Ivan Malov
The board admin may need to assign a MAC address to a guest VNIC identified by its MCDI handle. Provide an API for that. In the case when a libefx-based driver is used at the guest, it will need to check its MAC address using the symmetrical API if the admin has tweaked it by means of its represen

[PATCH 3/3] net/sfc: allow to control the represented entity MAC address

2022-05-26 Thread Ivan Malov
The MAC address is accessed via the representor ethdev's one. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_port.c | 1 + drivers/net/sfc/sfc_repr.c | 29 -- drivers/net/sfc/sfc_repr_proxy.c |

Re: [PATCH 1/3] app/testpmd: fix displaying RSS info

2022-05-26 Thread Ferruh Yigit
On 5/26/2022 4:52 AM, lihuisong (C) wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Hi, Ferruh This patch is the same as the following patch: https://nam11.safe

RE: [PATCH] examples/vhost: Fix retry logic on Rx

2022-05-26 Thread Ling, WeiX
> -Original Message- > From: Wang, YuanX > Sent: Thursday, May 19, 2022 12:25 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Ling, WeiX ; Wang, YuanX > ; sta...@dpdk.org > Subject: [PATCH] examples/vhost: Fix retry logic on Rx > > drain

RE: [EXT] [PATCH v2 01/14] cryptodev: redefine ec group enum

2022-05-26 Thread Akhil Goyal
> - EC enum was renamed to rte_crypto_curve_id. > Elliptic curve enum name was incorrectly associated > with group (it comes from current tls registry name). > - Clarified comments about TLS deprecation. > Some curves included are deprecated with TLS 1.3. > Comments to address it were added. > - Cl

RE: [v7, 01/11] examples/fips_validation: add jansson dependency

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 01/11] examples/fips_validation:

RE: [v7, 02/11] examples/fips_validation: add json info to header

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo ; > Gowrishankar Muthukrishnan > Subject: [v7, 0

RE: [v7, 03/11] examples/fips_validation: add json parsing

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 03/11] examples/fips_validation:

RE: [v7, 04/11] examples/fips_validation: allow json file as input

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo ; > Gowrishankar Muthukrishnan > Subject: [v7, 0

RE: [v7, 05/11] examples/fips_validation: add json to gcm test

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 05/11] examples/fips_validation:

RE: [v7, 06/11] examples/fips_validation: add json to hmac

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 06/11] examples/fips_validation:

RE: [v7, 07/11] examples/fips_validation: implement json cmac test

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 07/11] examples/fips_validation:

RE: [v7, 08/11] examples/fips_validation: add parsing for cmac

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo ; > Gowrishankar Muthukrishnan > Subject: [v7, 0

RE: [EXT] [PATCH v2 02/14] cryptodev: reduce number of comments in asym xform

2022-05-26 Thread Akhil Goyal
> - Reduced number of comments in asymmetric xform. > Information describing basic functionality of well known > algorithms are unnecessary. > - Removed NONE asymetric xform. I commented on v1 not to remove this and I do not see comment from your side for removing it. > > Signed-off-by: Arek Kus

Re: [PATCH 2/3] common/sfc_efx/base: manage VNIC MAC address by MCDI handle

2022-05-26 Thread Ray Kinsella
Ivan Malov writes: > The board admin may need to assign a MAC address to a guest > VNIC identified by its MCDI handle. Provide an API for that. > > In the case when a libefx-based driver is used at the guest, > it will need to check its MAC address using the symmetrical > API if the admin has t

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Ray Kinsella
Stephen Hemminger writes: > The PIE code and other applications can benefit from having a > fast way to get a random floating point value. This new function > is equivalent to drand() in the standard library. > > Signed-off-by: Stephen Hemminger > --- > app/test/test_rand_perf.c

RE: [EXT] [PATCH v2 02/14] cryptodev: reduce number of comments in asym xform

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 11:52 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 02/14] cryptodev: reduce number of comments in > asym xform > > > - Reduced number of comments in asymmetric xf

Re: [PATCH v3 5/5] ethdev: fix dev state when stop

2022-05-26 Thread Thomas Monjalon
25/05/2022 19:44, Ferruh Yigit: > On 5/3/2022 11:02 AM, Min Hu (Connor) wrote: > > Currently, 'dev_started' is always set to be 0 when dev stop, whether > > it succeeded or failed. This is unreasonable and this patch fixed it. > > > > Fixes: 62024eb82756 ("ethdev: change stop operation callback to

Re: [PATCH] eal/ppc: undefine AltiVec keyword vector

2022-05-26 Thread Thomas Monjalon
25/05/2022 20:34, Tyler Retzlaff: > On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: > > Thomas Monjalon writes: > > > 25/05/2022 13:48, Ray Kinsella: > > >> Thomas Monjalon writes: > > >> > > >> > The AltiVec header file is defining "vector", except in C++ build. > > >> > The keywo

[dpdk-dev v4] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-26 Thread Kai Ji
Since openssl 3.0 now deprecates the low level API QAT required to perform partial hash & aes operation when creating the session. This patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to switch APIs between openssl and intel ipsec-mb library. Signed-off-by: Kai Ji Signed-off-by: F

RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-26 Thread Akhil Goyal
> /** > + * Asymmetric crypto key exchange operation type > + */ > +enum rte_crypto_asym_ke_type { > + RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE, Is it better to shorten it to RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE > + /**< Private Key generation operatio

RE: [EXT] [PATCH v2 04/14] cryptodev: remove comment about using ephemeral key in dsa

2022-05-26 Thread Akhil Goyal
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, May 25, 2022 9:23 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; roy.fan.zh...@intel.com; Arek Kusztal > > Subject: [EXT] [PATCH v2 04/14] cryptodev: remove comment about using > ephemeral key in dsa > > External Email > > -

Re: [PATCH] eal/ppc: undefine AltiVec keyword vector

2022-05-26 Thread Ray Kinsella
Thomas Monjalon writes: > 25/05/2022 20:34, Tyler Retzlaff: >> On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: >> > Thomas Monjalon writes: >> > > 25/05/2022 13:48, Ray Kinsella: >> > >> Thomas Monjalon writes: >> > >> >> > >> > The AltiVec header file is defining "vector", exc

RE: [EXT] [PATCH v2 05/14] cryptodev: clarify usage of private key in dh

2022-05-26 Thread Akhil Goyal
> - Clarified usage of private key in Diffie-Hellman. > CSRNG capable device should generate private key and then > use it for public key generation. > > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/lib/cryptod

RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 12:58 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange > operation enum > > > /** > > + * Asymmetric crypto key exchange oper

RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-26 Thread Akhil Goyal
> > > /** > > > + * Asymmetric crypto key exchange operation type */ enum > > > +rte_crypto_asym_ke_type { > > > + RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE, > > > > Is it better to shorten it to > > RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE > > RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE > +1, Actually I am no

RE: [EXT] [PATCH v2 06/14] cryptodev: move dh type from xform to dh op

2022-05-26 Thread Akhil Goyal
> - Moved dh operation type to dh operation struct. > Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should > be free to choose for any operation. One xform/session should > be enough to perform both DH operations, if op_type would be xform > member, session would have to be to be created tw

RE: [EXT] [PATCH v2 07/14] cryptodev: add elliptic curve diffie hellman

2022-05-26 Thread Akhil Goyal
> - Added elliptic curve Diffie-Hellman parameters. > Point multiplication allows the user to process every phase of > ECDH, but for phase 1, user should not really care about the generator. > The user does not even need to know what the generator looks like, > therefore setting ec xform would make

RE: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option

2022-05-26 Thread Akhil Goyal
> - Added key exchange public key verify option. > For some elliptic curves public point in DH exchange > needs to be checked, if it lays on the curve. > Modular exponentiation needs certain checks as well, though > mathematically much easier. > This commit adds verify option to asym_op operations.

RE: [EXT] [PATCH v2 07/14] cryptodev: add elliptic curve diffie hellman

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 1:29 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 07/14] cryptodev: add elliptic curve diffie > hellman > > > - Added elliptic curve Diffie-Hellman parameters. >

RE: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 1:34 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option > > > - Added key exchange public key verify option. > > For some

RE: [EXT] [PATCH v2 09/14] cryptodev: add asym op flags

2022-05-26 Thread Akhil Goyal
> - Added flags to rte_crypto_asym_op struct. > It may be shared between different algorithms. > - Added Diffie-Hellman padding flags. > Diffie-Hellman padding is used in certain protocols, > in others, leading zero bytes need to be stripped. > Even same protocol may use a different approach - most

RE: [EXT] [PATCH v2 10/14] cryptodev: clarify usage of rsa padding hash

2022-05-26 Thread Akhil Goyal
> - Clarified usage of RSA padding hash. > It was not specified how to use hash for PKCS1_5 > padding. This could lead to incorrect implementation. > > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 25 + > 1 file changed, 21 insertions(+), 4 deleti

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Akhil Goyal
> /** > + * RSA padding type > + */ > +struct rte_crypto_rsa_padding { > + enum rte_crypto_rsa_padding_type type; > + /**< RSA padding scheme to be used for transform */ > + enum rte_crypto_auth_algorithm md; > + /**< > + * RSA padding hash function > + * > + * When

RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none padding

2022-05-26 Thread Akhil Goyal
> - Clarified where should output be stored of signature > decryption with padding none. > PMD is not able to know what padding algorithm was used, > therefore decrypted signature should be returned to the user. > > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 7 ++-

RE: [EXT] [PATCH v2 13/14] cryptodev: add salt length and optional label

2022-05-26 Thread Akhil Goyal
> - Added salt length and optional label. > Common parameters to PSS and OAEP padding for RSA. > - Fixed hash API in RSA padding. > Now it is specified how hash should be used with > particular RSA padding modes. > > Signed-off-by: Arek Kusztal > --- Acked-by: Akhil Goyal

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:05 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate > struct > > > /** > > + * RSA padding type > > + */ > > +stru

RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none padding

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:07 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none > padding > > > - Clarified where should output be stored of sign

RE: [PATCH v2 1/4] ethdev: add meter color flow matching item

2022-05-26 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, May 22, 2022 1:51 PM > Subject: [PATCH v2 1/4] ethdev: add meter color flow matching item > > Provide an ability to use a Color Marker set by a Meter > as a matching item in Flow API. The Color Marker reflects >

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Akhil Goyal
> > > /** > > > + * RSA padding type > > > + */ > > > +struct rte_crypto_rsa_padding { > > > + enum rte_crypto_rsa_padding_type type; > > > + /**< RSA padding scheme to be used for transform */ > > > + enum rte_crypto_auth_algorithm md; > > > + /**< > > > + * RSA padding hash function > > > + *

RE: [PATCH v2 2/4] ethdev: allow meter color marker modification

2022-05-26 Thread Ori Kam
Hi Alex, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, May 22, 2022 1:51 PM > Subject: [PATCH v2 2/4] ethdev: allow meter color marker modification > > Extend modify_field Flow API with support of Meter Color Marker > modifications. It allows setting the packet's metadat

RE: [PATCH v2 3/4] ethdev: get meter profile/policy objects

2022-05-26 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, May 22, 2022 1:51 PM > Subject: [PATCH v2 3/4] ethdev: get meter profile/policy objects > > Introduce a new Meter API to retrieve a Meter profile and policy > objects using the profile/policy ID previously creat

RE: [PATCH v2 4/4] ethdev: add meter color mark flow action

2022-05-26 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, May 22, 2022 1:51 PM > Subject: [PATCH v2 4/4] ethdev: add meter color mark flow action > > Create a new Flow API action: METER_MARK. > It Meters an IP packet stream and marks its packets with colors. > Unlike

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:20 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate > struct > > > > > /** > > > > + * RSA padding type > > > > +

RE: [PATCH v2 0/4] ethdev: separate metering and marking from policing

2022-05-26 Thread Ori Kam
Please add testpmd implenetation for this patch set. It can be part of each patch or just one patch. Best, Ori

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Akhil Goyal
> > > > > /** > > > > > + * RSA padding type > > > > > + */ > > > > > +struct rte_crypto_rsa_padding { > > > > > + enum rte_crypto_rsa_padding_type type; > > > > > + /**< RSA padding scheme to be used for transform */ > > > > > + enum rte_crypto_auth_algorithm md; > > > > > + /**

RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms capabilities

2022-05-26 Thread Akhil Goyal
> - Added asymmetric crypto algorithm specific capability struct. > Included fields like random number capability, padding flags etc. > > Signed-off-by: Arek Kusztal > --- > app/test-crypto-perf/main.c | 12 +- > app/test-eventdev/test_perf_common.c | 2 +- > app/test

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Mattias Rönnblom
On 2022-05-25 22:31, Stephen Hemminger wrote: The PIE code and other applications can benefit from having a fast way to get a random floating point value. This new function is equivalent to drand() in the standard library. Signed-off-by: Stephen Hemminger --- app/test/test_rand_perf.c

Re: [PATCH v2 0/4] ethdev: separate metering and marking from policing

2022-05-26 Thread Jerin Jacob
On Sun, May 22, 2022 at 4:21 PM Alexander Kozyrev wrote: > > Extend Metering and Marking support in the Flow API: > 1. Add METER_COLOR item to match Color Marker set by a Meter. > 2. Add the ability to set Color Marker via modify_field Flow API. > 3. Add Meter API to get profile/policy objects. >

Re: [PATCH v2 0/4] ethdev: separate metering and marking from policing

2022-05-26 Thread Jerin Jacob
On Thu, May 26, 2022 at 6:51 PM Jerin Jacob wrote: > > On Sun, May 22, 2022 at 4:21 PM Alexander Kozyrev wrote: > > > > Extend Metering and Marking support in the Flow API: > > 1. Add METER_COLOR item to match Color Marker set by a Meter. > > 2. Add the ability to set Color Marker via modify_fiel

RE: [EXT] [dpdk-dev v4] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-26 Thread Akhil Goyal
> Since openssl 3.0 now deprecates the low level API QAT required to > perform partial hash & aes operation when creating the session. This > patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to > switch APIs between openssl and intel ipsec-mb library. > > Signed-off-by: Kai Ji > Si

RE: [EXT] [dpdk-dev v4] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-26 Thread Akhil Goyal
> > > Since openssl 3.0 now deprecates the low level API QAT required to > > perform partial hash & aes operation when creating the session. This > > patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to > > switch APIs between openssl and intel ipsec-mb library. > > > > Signed-off-

RE: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP operations

2022-05-26 Thread Akhil Goyal
> Add a command line option "--enable-sdap" to enable > Service Data Adaptation Protocol. > > example command: > ./dpdk-test-crypto-perf -c 0xc --log-level=8 -- > --devtype crypto_dpaa2_sec --optype pdcp --cipher-algo aes-ctr > --cipher-op encrypt --auth-algo zuc-eia3 --auth-op generate > --auth-

RE: [EXT] [PATCH v3 2/7] examples/ipsec-secgw: support XCBC-MAC/DES-CBC

2022-05-26 Thread Akhil Goyal
> ipsec-secgw application is updated to support > DES-CBC ciphering and XCBC-MAC authentication > based IPsec functionality. > > Signed-off-by: Gagandeep Singh > --- Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 3/7] examples/l2fwd-crypto: add signal handler for exit

2022-05-26 Thread Akhil Goyal
Hi Stephen, > Handle SIGINT and SIGTERM signals. > > Signed-off-by: Gagandeep Singh > --- Do you have more comments on this? If not, can you please ack? > examples/l2fwd-crypto/main.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/examples/l2fwd-crypto/main.c b/exa

RE: [EXT] [PATCH v3 4/7] test/crypto: fix PMD name for dpaa raw buffer crypto driver

2022-05-26 Thread Akhil Goyal
> PMD name for DPAA raw buffer crypto driver test cases is > updated with correct name. > > Fixes: cd8166c28cd1 ("test/crypto: add raw API test for dpaax") > Cc: sta...@dpdk.org > > Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 5/7] test/crypto: support raw buffer APIs for PDCP

2022-05-26 Thread Akhil Goyal
> This patch supports raw buffer APIs testing for > PDCP test cases. > > Signed-off-by: Gagandeep Singh > --- Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 6/7] test/crypto: add short MAC-I test vector for zuc

2022-05-26 Thread Akhil Goyal
> Add a ZUC based short MAC-I test vector. > > Signed-off-by: Gagandeep Singh > --- Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 7/7] doc: add missing authentication algorithm

2022-05-26 Thread Akhil Goyal
> Adding the missing SHA256-HMAC authentication algorithm > in ipsec-secgw guide. > > Fixes: b5350285ce6e ("examples/ipsec-secgw: support SHA256 HMAC") > Cc: sta...@dpdk.org > > Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal

RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms capabilities

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:54 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms > capabilities > > > - Added asymmetric crypto algorithm specific capabil

[PATCH v2] net/nfp: fix bug of disable VLAN strip

2022-05-26 Thread Peng Zhang
"vlan set strip off 0" can't work, due to the incorrect usage of the mask, it just represent that the status is changed or not, not represent offloaded or not, so that the driver send the error control message to the nic. Now, by first inspect the mask of things that changed, and then change the r

RE: [PATCH v5 1/4] lib/ethdev: introduce protocol type based buffer split

2022-05-26 Thread Ding, Xuan
Hi, > -Original Message- > From: Ding, Xuan > Sent: Thursday, May 19, 2022 10:40 PM > To: Thomas Monjalon ; Wang, YuanX > ; Wu, WenxuanX > Cc: andrew.rybche...@oktetlabs.ru; Li, Xiaoyun ; > ferruh.yi...@xilinx.com; Singh, Aman Deep ; > dev@dpdk.org; Zhang, Yuying ; Zhang, Qi Z > ; jerinj

RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms capabilities

2022-05-26 Thread Akhil Goyal
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, May 26, 2022 7:49 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms > capabilities > > > > > -Original Message- > > From: Akhil Goy

Re: [PATCH v3 1/2] eal: get/set thread priority per thread identifier

2022-05-26 Thread Stephen Hemminger
On Wed, 25 May 2022 23:29:57 -0700 Tyler Retzlaff wrote: > On Tue, May 24, 2022 at 07:51:05AM -0700, Stephen Hemminger wrote: > > On Tue, 24 May 2022 04:08:36 -0700 > > Tyler Retzlaff wrote: > > > > > +static int > > > +thread_map_priority_to_os_value(enum rte_thread_priority eal_pri, > > > +

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Stephen Hemminger
On Thu, 26 May 2022 15:20:29 +0200 Mattias Rönnblom wrote: > > @@ -55,6 +58,9 @@ test_rand_perf_type(enum rand_type rand_type) > > case rand_type_64: > > sum += rte_rand(); > > break; > > + case rand_type_float: > > +

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Stephen Hemminger
On Thu, 26 May 2022 15:20:29 +0200 Mattias Rönnblom wrote: > > +#else > > + /* Slower method requiring floating point divide > > +* > > Do you know how much slower? I ran rand_perf_test on two of my systems. > >AMD 5900X Pi4 (ARM Cortex-A72) > IEEE754 version

RE: [EXT] [PATCH v2 0/2] add partial SGL support to AESNI_MB

2022-05-26 Thread Akhil Goyal
> This patchset adds SGL support for GCM and CHACHA20-POLY1305 algorithms, > using the IPSec-MB JOB API. > > Supported SGL types: > - INPLACE SGL > - OOP SGL IN, LB OUT > - OOP SGL IN, SGL OUT > > The SGL Feature Flags for AESNI_MB PMD are not added, > as it does not yet support SGL for all ot

RE: [EXT] Re: [PATCH 1/1] drivers: define OPENSSL_API_COMPAT

2022-05-26 Thread Akhil Goyal
> On Tue, May 10, 2022 at 5:06 PM Heinrich Schuchardt > wrote: > > > > The API of the OpenSSL library has changed with version 3.0. This results > > in a lot of compiler warnings like > > > > ../dpdk/drivers/crypto/ccp/ccp_crypto.c:182:9: > > warning: ‘SHA256_Transform’ is deprecated: > >

RE: [dpdk-dev v2] crypto/qat: fix of offset and length assignment

2022-05-26 Thread Akhil Goyal
> > > > This patch fix the cipher & auth offset and length values when convert > > mbuf to vector chain for QAT build op. > > > > Fixes: a815a04cea05 ("crypto/qat: support symmetric build op request") > > > > Signed-off-by: Kai Ji > > --- > Acked-by: Fan Zhang Applied to dpdk-next-crypto Thanks

RE: [PATCH] crypto/qat: enable asymmetric crypto on gen4 device

2022-05-26 Thread Akhil Goyal
> Acked-by: Ji, Kai Please be consistent in Acks Corrected this to Acked-by: Kai Ji > > > This commit enables asymmetric crypto in generation four devices (4xxx). > > > > Signed-off-by: Arek Kusztal Applied to dpdk-next-crypto

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-26 Thread Akhil Goyal
> > > This commit adds support for following elliptic curves: > > > 1) Curve25519 > > > 2) Curve448 > > > > > > Signed-off-by: Arek Kusztal > > > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto

RE: [PATCH v2 0/2] crypto/qat: add secp384r1 curve support

2022-05-26 Thread Akhil Goyal
> > This patchset adds secp384r1 (P-384) elliptic > > curve to Intel QuickAssist Technology crypto PMD. > > > > v2: > > - added release notes > > > > Arek Kusztal (2): > > crypto/qat: refactor asym algorithm macros and logs > > crypto/qat: add secp384r1 curve > > > > doc/guides/rel_notes/relea

[Bug 1018] Segfault in debug_autotest on Alpine

2022-05-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1018 Bug ID: 1018 Summary: Segfault in debug_autotest on Alpine Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

Re: [PATCH 1/2] doc: update required kernel version to 4.9

2022-05-26 Thread Stephen Hemminger
On Thu, 17 Feb 2022 08:45:16 -0800 Stephen Hemminger wrote: > The 4.4 kernel has passed its end of life date (after 6 years). > It is no longer supported and therefore DPDK should update > its minimum required kernel version. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/linux_gsg/sy

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Stephen Hemminger
On Thu, 26 May 2022 15:20:29 +0200 Mattias Rönnblom wrote: > On 2022-05-25 22:31, Stephen Hemminger wrote: > > The PIE code and other applications can benefit from having a > > fast way to get a random floating point value. This new function > > is equivalent to drand() in the standard library. >

[PATCH v5 0/3] introduce random floating point function

2022-05-26 Thread Stephen Hemminger
Introduce a new random number function to get a floating point value. Then use it to fix PIE scheduler. v5 - use divide method (similar to FreeBSD) it takes same number of cycles (after optimization) and works on all platforms. Stephen Hemminger (3): random: add rte_drand() functio

  1   2   >