RE: [PATCH v7] net/bonding: another fix to LACP mempool size

2022-05-01 Thread Matan Azrad
Hi Ferruh, Gaoxiang From: Ferruh Yigit > On 3/28/2022 4:16 PM, Gaoxiang Liu wrote: > > The following log message may appear after a slave is idle(or nearly > > idle) > > for a few minutes:"PMD: Failed to allocate LACP packet from pool". > > And bond mode 4 negotiation may fail. > > > > Problem:Wh

Re: [PATCH v4 1/3] eal: add basic thread ID and current thread identifier API

2022-05-01 Thread Dmitry Kozlyuk
2022-04-26 00:50 (UTC-0700), Tyler Retzlaff: > Provide a portable type-safe thread identifier. > Provide rte_thread_self for obtaining current thread identifier. > > Signed-off-by: Narcisa Vasile > Signed-off-by: Tyler Retzlaff Acked-by: Dmitry Kozlyuk

Re: [PATCH v4 2/3] eal: implement functions for get/set thread affinity

2022-05-01 Thread Dmitry Kozlyuk
2022-04-26 00:50 (UTC-0700), Tyler Retzlaff: > Implement functions for getting/setting thread affinity. > Threads can be pinned to specific cores by setting their > affinity attribute. > > Windows error codes are translated to errno-style error codes. > The possible return values are chosen so tha

Re: [PATCH v4 3/3] test/threads: add unit test for thread API

2022-05-01 Thread Dmitry Kozlyuk
2022-04-26 00:50 (UTC-0700), Tyler Retzlaff: > Establish unit test for testing thread api. Initial unit tests > for rte_thread_{get,set}_affinity_by_id(). > > Signed-off-by: Narcisa Vasile > Signed-off-by: Tyler Retzlaff > --- > app/test/meson.build| 2 ++ > app/test/test_threads.c | 89 >

[PATCH] crypto/mlx5: support plaintext keys

2022-05-01 Thread Raja Zidane
Using crypto devs requires the user to log in and the supplied DEK to be encrypted with a KEK (keys encryption key). KEK is burned once on the nic, along with credentials for users, and for a user to log in, he is needed to supply his creds wrapped with the KEK. A device comes out of the Mellanox f

RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-05-01 Thread Gujjar, Abhinandan S
> -Original Message- > From: Akhil Goyal > Sent: Friday, April 29, 2022 5:47 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Jayatheerthan, Jay ; > Vangati, Narender ; Volodymyr Fialko > > Subject: RE: [PATCH v3 1/7] cryptodev: add APIs to

RE: [PATCH v3 6/7] test/event: add asymmetric cases for crypto adapter

2022-05-01 Thread Gujjar, Abhinandan S
> -Original Message- > From: Akhil Goyal > Sent: Friday, April 29, 2022 5:53 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Jayatheerthan, Jay ; > Vangati, Narender ; Volodymyr Fialko > > Subject: RE: [PATCH v3 6/7] test/event: add asymm

Re: [RFC 0/6] net/mlx5: introduce limit watermark and host shaper

2022-05-01 Thread Jerin Jacob
On Tue, Apr 26, 2022 at 8:12 AM Spike Du wrote: > > Hi Jerin, Hi Spike, > Thanks for your comments and sorry for the late response. > > For case one, I think I can refine the design and add LWM(limit > watermark) in rte_eth_rxconf, and add a new rte_eth_event_type event. OK. >

Re: [dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-05-01 Thread Jerin Jacob
On Tue, Apr 26, 2022 at 3:49 PM Ray Kinsella wrote: > > > jer...@marvell.com writes: > > > From: Jerin Jacob > > > > Currently, meter object supports only DSCP based on input color table, > > The patch enhance that to support VLAN based input color table, > > color table based on inner field for

Re: [dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-05-01 Thread Jerin Jacob
On Tue, Apr 26, 2022 at 5:38 PM Dumitrescu, Cristian wrote: > > Hi Jerin, Hi Cristian > > Thank you for implementing according to our agreement, I am happy to see that > we are converging. :-) > > Here are some comments below: > > > > > diff --git a/lib/ethdev/rte_mtr.h b/lib/ethdev/rte_mtr.

RE: [PATCH v3 7/7] test-eventdev: support asym ops for crypto adapter

2022-05-01 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 8:07 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subje

RE: [PATCH v3 2/7] crypto/cnxk: add event metadata set operation

2022-05-01 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar Minor comment below > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 8:07 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; A

RE: [PATCH v3 3/7] crypto/octeontx: use new API for event metadata

2022-05-01 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 8:07 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subje

Re: [PATCH 1/4] common/cnxk: add CN103XX platform support

2022-05-01 Thread Jerin Jacob
On Fri, Mar 25, 2022 at 6:34 PM Rahul Bhansali wrote: > > Added support for CN103XX (cn10kb) platform. Since 2/4. 3/4, 4/4 patches do not have any special description. Please squash all patches and send v2. It can go through the main tree as it touches all driver's PCI ID values. > > Signed-off

Re: [PATCH v4] eal: add seqlock

2022-05-01 Thread Mattias Rönnblom
On 2022-04-28 12:28, David Marchand wrote: Hello Mattias, On Fri, Apr 8, 2022 at 4:25 PM Mattias Rönnblom wrote: A sequence lock (seqlock) is synchronization primitive which allows for data-race free, low-overhead, high-frequency reads, especially for data structures shared across many cores

[PATCH v5] eal: add seqlock

2022-05-01 Thread Mattias Rönnblom
A sequence lock (seqlock) is synchronization primitive which allows for data-race free, low-overhead, high-frequency reads, especially for data structures shared across many cores and which are updated relatively infrequently. A seqlock permits multiple parallel readers. The variant of seqlock imp

Re: [PATCH v5] eal: add seqlock

2022-05-01 Thread Mattias Rönnblom
On 2022-05-01 16:03, Mattias Rönnblom wrote: A sequence lock (seqlock) is synchronization primitive which allows "/../ is a /../" David, maybe you can fix this typo? Unless there is a need for a new version.

[dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input color selection

2022-05-01 Thread jerinj
From: Jerin Jacob Currently, meter object supports only DSCP based on input color table, The patch enhance that to support VLAN based input color table, color table based on inner field for the tunnel use case, and support for fallback color per meter if packet based on a different field. All of

[dpdk-dev] [PATCH] doc: fix build error with sphinx 4.5.0

2022-05-01 Thread jerinj
From: Jerin Jacob Latest sphinx checks c language syntax more aggressively. Fix the following warning by correcting c language syntax. doc/guides/prog_guide/event_ethernet_rx_adapter.rst:243: WARNING: Could not lex literal_block as "c". Highlighting skipped. Fixes: 3c838062b91f ("eventdev: intr

when dpdk-process is running, server machine breakdown while offload igb_uio or vfio_pci.

2022-05-01 Thread ????
    hi??i'm so sorry to disturb, but i got a question which stuck me for a long time. when dpdk-process is running, assuming that dpdk use a NIC named eth0, and eth0 insmod a i40e drivers before, then when i offload the NIC from igb_uio/vfio_pci to i40e, and stop the dpdk-process . my server mac

Re: [PATCH v4 2/7] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-05-01 Thread Konstantin Ananyev
29/04/2022 21:44, Nithin Dabilpuram пишет: Enable Tx IPv4 checksum offload only when Tx inline crypto, lookaside crypto/protocol or cpu crypto is needed. For Tx Inline protocol offload, checksum computation is implicitly taken care by HW. Signed-off-by: Nithin Dabilpuram Acked-by: Akhil Goyal

RE: [PATCH v3 2/7] crypto/cnxk: add event metadata set operation

2022-05-01 Thread Akhil Goyal
> > -uint16_t > > -cn10k_cpt_crypto_adapter_enqueue(uintptr_t tag_op, struct rte_crypto_op > > *op) > > +static int > > +cn10k_cpt_crypto_adapter_ev_mdata_set(struct rte_cryptodev *dev > > __rte_unused, > > + void *sess, > > + enum rte

RE: [PATCH v3 6/7] test/event: add asymmetric cases for crypto adapter

2022-05-01 Thread Akhil Goyal
Hi Abhinandan, > > > > > This is failing with asym changes. Please look into this. > > > > Thanks for pointing this out. It is failing as null crypto does not support > > asym > > And asym_session_create would need an op from driver which is NULL for null > > crypto > > > > Please check if below c

RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-05-01 Thread Akhil Goyal
> > > > + > > > > +void * > > > > +rte_cryptodev_session_event_mdata_get(struct rte_crypto_op *op) { > > > Null check for op? > > > > Null check can be added, but this a datapath dpdk internal API. > > We do not normally add checks in datapath. > > If you insist, I can add, but before calling this

[PATCH v4 0/7] Add new cryptodev op for event metadata

2022-05-01 Thread Akhil Goyal
For using event crypto metadata, event metadata need to be set in session. For this session user data was used for symmetric crypto sessions and no support was present for asymmetric and security sessions. The use of userdata to store event metadata (which is dereferenced in PMD) is not correct as

[PATCH v4 1/7] cryptodev: add APIs to get/set event metadata

2022-05-01 Thread Akhil Goyal
From: Volodymyr Fialko Currently, crypto session userdata is used to set event crypto metadata from the application and the driver is dereferencing it in driver which is not correct. User data is meant to be opaque to the driver. To support this, new API is added to get and set event crypto metad

[PATCH v4 2/7] crypto/cnxk: add event metadata set operation

2022-05-01 Thread Akhil Goyal
From: Volodymyr Fialko Added cryptodev operation for setting event crypto metadata for all supported sessions - sym/asym/security. Signed-off-by: Volodymyr Fialko Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 144 +

[PATCH v4 3/7] crypto/octeontx: use new API for event metadata

2022-05-01 Thread Akhil Goyal
For getting event crypto metadata from crypto_op, the new API rte_cryptodev_get_session_event_mdata can be used directly instead of getting userdata inside PMD. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 20 +

[PATCH v4 4/7] test/event: use new API to set event crypto metadata

2022-05-01 Thread Akhil Goyal
Used the new API rte_cryptodev_set_session_event_mdata to set event crypto metadata from the applications (app/test and app/test-eventdev) instead of using session userdata. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar --- app/test-eventdev/test_perf_common.c | 8

[PATCH v4 5/7] eventdev: use new API to get event crypto metadata

2022-05-01 Thread Akhil Goyal
For getting event crypto metadata from crypto_op, the new API rte_cryptodev_get_session_event_mdata is used instead of getting userdata inside PMD. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar --- lib/eventdev/rte_event_crypto_adapter.c | 55 ++

[PATCH v4 6/7] test/event: add asymmetric cases for crypto adapter

2022-05-01 Thread Akhil Goyal
Test app is updated to add cases for asymmetric crypto sessions for event crypto adapter. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang --- app/test/test_event_crypto_adapter.c | 499 ++- 1 file changed, 493 insertions(+), 6 deletions(-) diff --git a/app/test/test_even

[PATCH v4 7/7] test-eventdev: support asym ops for crypto adapter

2022-05-01 Thread Akhil Goyal
Test eventdev app is updated to add new option for asymmetric crypto ops for event crypto adapter. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar --- app/test-eventdev/evt_common.h | 2 + app/test-eventdev/evt_options.c | 17 ++ app/test-eventdev/evt_o

Re: [PATCH v5] eal: add seqlock

2022-05-01 Thread Stephen Hemminger
On Sun, 1 May 2022 16:03:27 +0200 Mattias Rönnblom wrote: > +struct data { > + rte_seqlock_t lock; > + > + uint64_t a; > + uint64_t b __rte_cache_aligned; > + uint64_t c __rte_cache_aligned; > +} __rte_cache_aligned; This will end up taking 192 bytes per lock. Which is a lot espe

回复: [PATCH v1 3/5] ethdev: add API for direct rearm mode

2022-05-01 Thread Feifei Wang
> -邮件原件- > 发件人: Jerin Jacob > 发送时间: Wednesday, April 20, 2022 6:50 PM > 收件人: Feifei Wang > 抄送: tho...@monjalon.net; Ferruh Yigit ; Andrew > Rybchenko ; Ray Kinsella > ; dpdk-dev ; nd ; > Honnappa Nagarahalli ; Ruifeng Wang > > 主题: Re: [PATCH v1 3/5] ethdev: add API for direct rearm mod

RE: [RFC 0/6] net/mlx5: introduce limit watermark and host shaper

2022-05-01 Thread Spike Du
Hi Jerin, > > For case two(host shaper), I think we can't use RX meter, because > > it's > actually TX shaper on a remote system. It's quite specific to Mellanox/Nvidia > BlueField 2(BF2 for short) NIC. The NIC contains an ARM system. We have > two terms here: Host-system stands f

Re: [PATCH v5] eal: add seqlock

2022-05-01 Thread Mattias Rönnblom
On 2022-05-01 22:17, Stephen Hemminger wrote: > On Sun, 1 May 2022 16:03:27 +0200 > Mattias Rönnblom wrote: > >> +struct data { >> +rte_seqlock_t lock; >> + >> +uint64_t a; >> +uint64_t b __rte_cache_aligned; >> +uint64_t c __rte_cache_aligned; >> +} __rte_cache_aligned; > > This

Re: [PATCH v5] eal: add seqlock

2022-05-01 Thread David Marchand
On Sun, May 1, 2022 at 4:22 PM Mattias Rönnblom wrote: > > On 2022-05-01 16:03, Mattias Rönnblom wrote: > > A sequence lock (seqlock) is synchronization primitive which allows > > "/../ is a /../" > > > > David, maybe you can fix this typo? Unless there is a need for a new > version. Noted. No n