> > > > + > > > > +void * > > > > +rte_cryptodev_session_event_mdata_get(struct rte_crypto_op *op) { > > > Null check for op? > > > > Null check can be added, but this a datapath dpdk internal API. > > We do not normally add checks in datapath. > > If you insist, I can add, but before calling this API, PMD/lib would have > > already > > checked for null op. > It is ok for get API. It is better to add the check for set API as it exposed > to user > application. > Currently, the set API is validating dev_id. It is better to add a null check > only for > set API. Ok. Will do that.
- [PATCH v2 4/7] test/event: use new API to set event c... Akhil Goyal
- [PATCH v2 5/7] eventdev: use new API to get event cry... Akhil Goyal
- [PATCH v2 6/7] test/event: add asymmetric cases for c... Akhil Goyal
- [PATCH v2 7/7] test-eventdev: support asym ops for cr... Akhil Goyal
- [PATCH v3 0/7] Add new cryptodev op for event metadat... Akhil Goyal
- [PATCH v3 1/7] cryptodev: add APIs to get/set ev... Akhil Goyal
- RE: [PATCH v3 1/7] cryptodev: add APIs to ge... Zhang, Roy Fan
- RE: [PATCH v3 1/7] cryptodev: add APIs to ge... Gujjar, Abhinandan S
- RE: [PATCH v3 1/7] cryptodev: add APIs t... Akhil Goyal
- RE: [PATCH v3 1/7] cryptodev: add AP... Gujjar, Abhinandan S
- RE: [PATCH v3 1/7] cryptodev: a... Akhil Goyal
- [PATCH v3 2/7] crypto/cnxk: add event metadata s... Akhil Goyal
- RE: [PATCH v3 2/7] crypto/cnxk: add event me... Zhang, Roy Fan
- RE: [PATCH v3 2/7] crypto/cnxk: add event me... Gujjar, Abhinandan S
- RE: [PATCH v3 2/7] crypto/cnxk: add even... Akhil Goyal
- [PATCH v3 3/7] crypto/octeontx: use new API for ... Akhil Goyal
- RE: [PATCH v3 3/7] crypto/octeontx: use new ... Zhang, Roy Fan
- RE: [PATCH v3 3/7] crypto/octeontx: use new ... Gujjar, Abhinandan S
- [PATCH v3 4/7] test/event: use new API to set ev... Akhil Goyal
- RE: [PATCH v3 4/7] test/event: use new API t... Zhang, Roy Fan
- RE: [PATCH v3 4/7] test/event: use new API t... Gujjar, Abhinandan S