> > > > +
> > > > +void *
> > > > +rte_cryptodev_session_event_mdata_get(struct rte_crypto_op *op) {
> > > Null check for op?
> >
> > Null check can be added, but this a datapath dpdk internal API.
> > We do not normally add checks in datapath.
> > If you insist, I can add, but before calling this API, PMD/lib would have 
> > already
> > checked for null op.
> It is ok for get API. It is better to add the check for set API as it exposed 
> to user
> application.
> Currently, the set API is validating dev_id. It is better to add a null check 
> only for
> set API.
Ok. Will do that.


Reply via email to