[PATCH] examples/fips_validation: cleanup bypass tests in response file

2022-04-21 Thread Gowrishankar Muthukrishnan
Remove garbage entries for bypassed tests in response file. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 74 - 1 file changed, 35 insertions(+), 39 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_valida

[PATCH] examples/fips_validation: disable iv_gen for decrypt tests

2022-04-21 Thread Gowrishankar Muthukrishnan
Disable iv_gen for decrypt tests. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_gcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c index 5c72dbf790..6b

[PATCH] crypto/cnxk: prevent out of bound access in crypto_caps

2022-04-21 Thread Gowrishankar Muthukrishnan
In a situation where crypto_caps elements are checked only for RTE_CRYPTO_OP_TYPE_UNDEFINED until valid op defined, there is possibility for an out of bound access. Add this array by one element for current capabilities. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cnxk_cryp

RE: [EXT] Re: [PATCH v3 0/5] Add JSON vector set support to fips validation

2022-04-21 Thread Gowrishankar Muthukrishnan
Hi Brandon, Following some cleanup patches I have posted against examples/fips, I would like to take enabling AES_CBC in fips validation. Please let me know if you/anyone have already have WIP for the same, before I proceed. Thanks, Gowrishankar > -Original Message- > From: Brandon Lo

RE: [PATCH v5 03/16] vhost: add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG

2022-04-21 Thread Pei, Andy
HI Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, April 20, 2022 9:53 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v5 03/16] vhost: add support for

Re: [PATCH 2/3] ethdev: fix memory leak when telemetry xstats

2022-04-21 Thread David Marchand
On Sat, Apr 16, 2022 at 3:14 AM Chengwen Feng wrote: > > The 'eth_xstats' should be freed after setup telemetry dictionary. This > patch fixes it. > > Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > --- > lib/ethdev/rte_ethdev.c |

Re: [PATCH v2 6/7] vdpa/mlx5: support device cleanup callback

2022-04-21 Thread Maxime Coquelin
On 2/24/22 16:51, Xueming Li wrote: This patch supports device cleanup callback API which called when device disconnected with VM. "This patch supports device cleanup callback API which is called when the device is disconnected from the VM." Cached resources like VM MR and VQ memory are re

Re: [PATCH v2 7/7] vdpa/mlx5: make statistics counter persistent

2022-04-21 Thread Maxime Coquelin
"vdpa/mlx5: make statistics counters persistent" On 2/24/22 16:51, Xueming Li wrote: To speed the device suspend and resume time, make counter persitent in reconfiguration until the device gets removed. "In order to speed-up the device suspend and resume, make the statistics counters persisten

Re: [PATCH v2] kni: update kernel API to receive packets

2022-04-21 Thread Ferruh Yigit
On 4/21/2022 4:45 AM, Gagandeep Singh wrote: API 'netif_rx_ni()' has been removed in kernel with commit: baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.") The API netif_rx() can be used for any context to receive packets from device drivers. This patch replaces th

RE: [PATCH] crypto/cnxk: prevent out of bound access in crypto_caps

2022-04-21 Thread Anoob Joseph
> > In a situation where crypto_caps elements are checked only for > RTE_CRYPTO_OP_TYPE_UNDEFINED until valid op defined, there is possibility > for an out of bound access. Add this array by one element for current > capabilities. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > drivers/cr

[PATCH v3] kni: update kernel API to receive packets

2022-04-21 Thread Gagandeep Singh
API 'netif_rx_ni()' has been removed in kernel with commit: baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.") The API netif_rx() can be used for any context to receive packets from device drivers. This patch replaces the API netif_rx_ni() with netif_rx() for kernel

[PATCH] net/iavf: fix segfaults when calling API after VF reset failed

2022-04-21 Thread Yiding Zhou
Some pointers will be set to NULL when iavf_dev_reset() failed, for example vf->vf_res, vf->vsi_res vf->rss_key and etc. APIs access these NULL pointers will trigger segfault. This patch adds closed flag to indicate that the VF is closed, and rejects API calls in this state to avoid coredump. Sig

Re: [PATCH 2/3] ethdev: fix memory leak when telemetry xstats

2022-04-21 Thread Bruce Richardson
On Thu, Apr 21, 2022 at 10:09:56AM +0200, David Marchand wrote: > On Sat, Apr 16, 2022 at 3:14 AM Chengwen Feng wrote: > > > > The 'eth_xstats' should be freed after setup telemetry dictionary. This > > patch fixes it. > > > > Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks") > > Cc: sta...@

RE: [PATCH v1 2/3] maintainers: update for Intel ixgbe

2022-04-21 Thread Yang, Qiming
> -Original Message- > From: Wang, Haiyue > Sent: 2022年4月8日 13:58 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Guo, Junfeng ; Su, > Simei ; Wu, Wenjun1 ; > Wang, Haiyue ; Thomas Monjalon > > Subject: [PATCH v1 2/3] maintainers: update for Intel ixgbe > > Qiming and Wenjun have

RE: [PATCH v1 1/3] maintainers: update for Intel e1000

2022-04-21 Thread Su, Simei
> -Original Message- > From: Wang, Haiyue > Sent: Friday, April 8, 2022 1:58 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Guo, Junfeng ; Su, Simei > ; Wu, Wenjun1 ; Wang, Haiyue > ; Thomas Monjalon > Subject: [PATCH v1 1/3] maintainers: update for Intel e1000 > > Simei an

[PATCH v6 00/16] add virtio_blk device support to vdpa/ifc

2022-04-21 Thread Andy Pei
This patch set add virtio_blk device support to vdpa/ifc driver. With a lot of similarities, I re-use part of vdpa/ifc driver. Distinguish the virtio net and blk device by device id, and implement specific features and ops. Add example to vdpa to support virtio_blk device. To support blk device li

[PATCH v6 01/16] vdpa/ifc: add support for virtio blk device

2022-04-21 Thread Andy Pei
Re-use the vdpa/ifc code, distinguish blk and net device by pci_device_id. Blk and net device are implemented with proper feature and ops. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/base/ifcvf.h | 16 +++- drivers/vdpa/ifc/ifcvf_vdpa.c | 92 +++

[PATCH v6 02/16] vhost: add vDPA ops for blk device

2022-04-21 Thread Andy Pei
Get_config and set_config are necessary ops for blk device. Add get_config and set_config ops to vDPA ops. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- lib/vhost/vdpa_driver.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vdpa_driver.h b/lib/v

[PATCH v6 03/16] vhost: add vhost msg support

2022-04-21 Thread Andy Pei
Add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG. VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG message is only supported by virtio blk VDPA device. Signed-off-by: Andy Pei --- lib/vhost/vhost_user.c | 69 ++ lib/vhost/vhost_user.h

[PATCH v6 04/16] vdpa/ifc: add blk ops for ifc device

2022-04-21 Thread Andy Pei
For virtio blk device, re-use part of ifc driver ops. Implement ifcvf_blk_get_config for virtio blk device. Support VHOST_USER_PROTOCOL_F_CONFIG feature for virtio blk device. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/base/ifcvf.h | 4 ++ drivers/vdpa/ifc/ifcvf_

[PATCH v6 05/16] vdpa/ifc: add vDPA interrupt for blk device

2022-04-21 Thread Andy Pei
For the block device type, we have to relay the commands on all queues. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 46 --- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifc

[PATCH v6 06/16] vdpa/ifc: add block device SW live-migration

2022-04-21 Thread Andy Pei
Add SW live-migration support to block device. Add dirty page logging to block device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 4 +- drivers/vdpa/ifc/base/ifcvf.h | 6 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 128 +++--- 3 files changed, 115

[PATCH v6 07/16] examples/vdpa: add vDPA blk support in example

2022-04-21 Thread Andy Pei
Add virtio blk device support to vDPA example. Signed-off-by: Andy Pei --- examples/vdpa/main.c | 61 +- examples/vdpa/vdpa_blk_compact.h | 72 + examples/vdpa/vhost_user.h | 169 +++ 3 files changed, 301 inserti

[PATCH v6 08/16] usertools: add support for virtio blk device

2022-04-21 Thread Andy Pei
Add virtio blk device support to devbind. Signed-off-by: Andy Pei --- usertools/dpdk-devbind.py | 8 1 file changed, 8 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index ace4627..cbe336f 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-dev

[PATCH v6 09/16] vdpa/ifc: add set vring state for blk device

2022-04-21 Thread Andy Pei
Set_vring_state op is mandatory, add set_vring_state for blk device. Currently set_vring_state for blk device is not implemented. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa

[PATCH v6 10/16] vdpa/ifc: add some log at vDPA launch before qemu connect

2022-04-21 Thread Andy Pei
Add some log of virtio blk device config space information at VDPA launch before qemu connects. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.

[PATCH v6 11/16] vdpa/ifc: read virtio max queues from hardware

2022-04-21 Thread Andy Pei
Original code max_queues is set to IFCVF_MAX_QUEUES. New code max_queues is the min of IFCVF_MAX_QUEUES and hardware num_queues. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcv

[PATCH v6 12/16] vdpa/ifc: add interrupt and handle for virtio blk

2022-04-21 Thread Andy Pei
Create a thread to poll and relay config space change interrupt. Use VHOST_USER_SLAVE_CONFIG_CHANGE_MSG to info qemu. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 112 ++ 1 file changed, 112 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf

[PATCH v6 13/16] vdpa/ifc: add is blk flag to ifcvf HW struct

2022-04-21 Thread Andy Pei
Add is_blk flag to ifcvf_hw, and init is_blk during probe. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 1 + drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h index 6dd7925..8e602af 10

[PATCH v6 14/16] vdpa/ifc/base: access correct register for blk device

2022-04-21 Thread Andy Pei
1.last_avail_idx is lower 16 bit of the register. 2.address of ring_state register is different between net and blk device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 36 +--- drivers/vdpa/ifc/base/ifcvf.h | 1 + 2 files changed, 30 insertions(+)

[PATCH v6 15/16] vdpa/ifc: blk device pause without no inflight IO

2022-04-21 Thread Andy Pei
When virtio blk device is pause, make sure hardware last_avail_idx and last_used_idx are the same. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 2 +- drivers/vdpa/ifc/base/ifcvf.h | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c | 32 +++- 3 files changed, 27 i

[PATCH v6 16/16] vhost: make sure each queue callfd is configured

2022-04-21 Thread Andy Pei
During the vhost data path building process, qemu will create a call fd at first, and create another call fd in the end. The final call fd will be used to relay notify. In the original code, after kick fd is set, dev_conf will set the first call fd. Even though the actual call fd will set, the data

RE: [PATCH v1 1/3] maintainers: update for Intel e1000

2022-04-21 Thread Wu, Wenjun1
> -Original Message- > From: Su, Simei > Sent: Thursday, April 21, 2022 5:19 PM > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Guo, Junfeng ; Wu, > Wenjun1 ; Thomas Monjalon > > Subject: RE: [PATCH v1 1/3] maintainers: update for Intel e1000 > > > > -Origi

RE: [PATCH v1 3/3] maintainers: update for Intel igc

2022-04-21 Thread Su, Simei
> -Original Message- > From: Wang, Haiyue > Sent: Friday, April 8, 2022 1:58 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Guo, Junfeng ; Su, Simei > ; Wu, Wenjun1 ; Wang, Haiyue > ; Thomas Monjalon > Subject: [PATCH v1 3/3] maintainers: update for Intel igc > > Junfeng an

RE: [PATCH v1 2/3] maintainers: update for Intel ixgbe

2022-04-21 Thread Wu, Wenjun1
> -Original Message- > From: Yang, Qiming > Sent: Thursday, April 21, 2022 5:13 PM > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; Guo, Junfeng > ; Su, Simei ; Wu, Wenjun1 > ; Thomas Monjalon > Subject: RE: [PATCH v1 2/3] maintainers: update for Intel ixgbe > > > -Original M

[PATCH v2] eal/linux: skip attaching to external memory chunk

2022-04-21 Thread Deepak Khandelwal
Currently, EAL init in secondary processes will attach all fbarrays in the memconfig to have access to primary process' page tables. However, fbarrays corresponding to external memory segments should not be attached at initialization, because this will happen as part of `rte_extmem_attach` or `rte_

Re: [PATCH 2/3] mem: fix ASan shadow for remapped memory segments

2022-04-21 Thread David Marchand
On Wed, Apr 20, 2022 at 4:47 PM Burakov, Anatoly wrote: > > On 15-Apr-22 6:31 PM, David Marchand wrote: > > When releasing some memory, the allocator can choose to return some > > pages to the OS. At the same time, this memory was poisoned in ASAn > > shadow. Doing the latter made it impossible to

Re: [PATCH 2/3] mem: fix ASan shadow for remapped memory segments

2022-04-21 Thread David Marchand
On Thu, Apr 21, 2022 at 11:37 AM David Marchand wrote: > > On Wed, Apr 20, 2022 at 4:47 PM Burakov, Anatoly > wrote: > > > > On 15-Apr-22 6:31 PM, David Marchand wrote: > > > When releasing some memory, the allocator can choose to return some > > > pages to the OS. At the same time, this memory w

Re: [v4 1/3] ethdev: introduce protocol type based header split

2022-04-21 Thread Thomas Monjalon
12/04/2022 18:15, Ding, Xuan: > From: Andrew Rybchenko > > On 4/2/22 13:41, wenxuanx...@intel.com wrote: > > > From: Xuan Ding > > > > > > Header split consists of splitting a received packet into two separate > > > regions based on the packet content. The split happens after the > > > packet hea

Re: [v4 1/3] ethdev: introduce protocol type based header split

2022-04-21 Thread Thomas Monjalon
20/04/2022 16:39, Andrew Rybchenko: > On 4/12/22 19:40, Ding, Xuan wrote: > > From: Jerin Jacob > >> On Sat, Apr 2, 2022 at 4:33 PM wrote: > >>> From: Xuan Ding > >>> > >>> Header split consists of splitting a received packet into two separate > >>> regions based on the packet content. The split

RE: [PATCH] net/mlx5: fix gtp handling in header modify action

2022-04-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, April 13, 2022 2:19 PM > To: Matan Azrad ; Slava Ovsiienko > ; Suanming Mou > Cc: dev@dpdk.org; Suanming Mou ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix gtp handling in header modify action > > GTP items were

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-04-21 Thread Mcnamara, John
-Original Appointment- From: Stokes, Ian Sent: Thursday, March 24, 2022 3:37 PM To: Stokes, Ian; Pai G, Sunil; Hu, Jiayu; Ferriter, Cian; Van Haaren, Harry; Ilya Maximets; Maxime Coquelin (maxime.coque...@redhat.com); ovs-...@openvswitch.org; dev@dpdk.org

[PATCH 0/6] move DPAA2 QDMA driver freom raw to dma

2022-04-21 Thread nipun . gupta
From: Nipun Gupta This change removes the DPAA2 QDMA raw driver and adds the QDMA driver in dma set of drivers. The underlying I/O framework remains intact, whereas the configuration part is done as per the DMA API support. Nipun Gupta (6): raw/dpaa2_qdma: remove dpaa2 QDMA driver from raw d

[PATCH 2/6] dma/dpaa2: introduce DPAA2 DMA driver skeleton

2022-04-21 Thread nipun . gupta
From: Nipun Gupta The DPAA2 DMA driver is an implementation of the dmadev APIs, that provide means to initiate a DMA transaction from CPU. Earlier this was part of RAW driver, but with DMA drivers added as seprate flavor of drivers, this driver is being moved to DMA drivers. Signed-off-by: Nipu

[PATCH 1/6] raw/dpaa2_qdma: remove dpaa2 QDMA driver from raw

2022-04-21 Thread nipun . gupta
From: Nipun Gupta With DMA devices supported as a separate flavor of devices, the DPAA2 QDMA driver is moved in the DMA devices. This change removes the DPAA2 QDMA driver from raw devices. Signed-off-by: Nipun Gupta --- MAINTAINERS |5 - doc/guides/rawdevs/

[PATCH 3/6] dma/dpaa2: support basic operations

2022-04-21 Thread nipun . gupta
From: Nipun Gupta This patch support basic DMA operations which includes device capability and channel setup. Signed-off-by: Nipun Gupta --- drivers/dma/dpaa2/dpaa2_qdma.c | 182 + 1 file changed, 182 insertions(+) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/

[PATCH 4/6] dma/dpaa2: add PMD apis for additional configuration

2022-04-21 Thread nipun . gupta
From: Nipun Gupta Add additional PMD APIs for DPAA2 QDMA driver for configuring RBP, Ultra Short format, and Scatter Gather support Signed-off-by: Nipun Gupta --- drivers/dma/dpaa2/dpaa2_qdma.c | 38 ++ drivers/dma/dpaa2/rte_pmd_dpaa2_qdma.h | 96 ++ dri

[PATCH 5/6] dma/dpaa2: support DMA operations

2022-04-21 Thread nipun . gupta
From: Nipun Gupta This patch support copy, submit, completed and completed status functionality of DMA driver. Signed-off-by: Nipun Gupta --- drivers/dma/dpaa2/dpaa2_qdma.c | 1173 drivers/dma/dpaa2/dpaa2_qdma.h | 71 +- drivers/dma/dpaa2/rte_pmd_dpaa

[PATCH 6/6] dma/dpaa2: support statistics

2022-04-21 Thread nipun . gupta
From: Nipun Gupta This patch support DMA read and reset statistics operations. Signed-off-by: Nipun Gupta --- drivers/dma/dpaa2/dpaa2_qdma.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c i

Re: [PATCH 2/3] mem: fix ASan shadow for remapped memory segments

2022-04-21 Thread Burakov, Anatoly
On 21-Apr-22 10:37 AM, David Marchand wrote: On Wed, Apr 20, 2022 at 4:47 PM Burakov, Anatoly wrote: On 15-Apr-22 6:31 PM, David Marchand wrote: When releasing some memory, the allocator can choose to return some pages to the OS. At the same time, this memory was poisoned in ASAn shadow. Doin

[PATCH v2 1/7] examples/ipsec-secgw: move fast path helper functions

2022-04-21 Thread Nithin Dabilpuram
Move fast path helper functions to header file for easy access. Signed-off-by: Nithin Dabilpuram --- v2: - Moved this patch from 4/7 to 1/7 to keep all moving as first patch without any change in function. - In patch 1/7, handled comments from Konstantin to check for capabilities before usin

[PATCH v2 2/7] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-04-21 Thread Nithin Dabilpuram
Enable Tx IPv4 checksum offload only when Tx inline crypto, lookaside crypto/protocol or cpu crypto is needed. For Tx Inline protocol offload, checksum computation is implicitly taken care by HW. Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/ipsec-secgw.c | 3 --- examples/ipsec-sec

[PATCH v2 3/7] examples/ipsec-secgw: use HW parsed packet type in poll mode

2022-04-21 Thread Nithin Dabilpuram
Use HW parsed packet type when ethdev supports necessary protocols. If packet type is not supported, then register ethdev callbacks for parse packet in SW. This is better for performance as it effects fast path. Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/ipsec-secgw.c | 157 +

[PATCH v2 4/7] examples/ipsec-secgw: allow larger burst size for vectors

2022-04-21 Thread Nithin Dabilpuram
Allow larger burst size of vector event mode instead of restricting to 32. Also restructure traffic type struct to have num pkts first so that it is always in first cacheline. Also cache align traffic type struct. Since MAX_PKT_BURST is not used by vector event mode worker, define another macro for

[PATCH v2 5/7] examples/ipsec-secgw: get security context from lcore conf

2022-04-21 Thread Nithin Dabilpuram
Store security context pointer in lcore Rx queue config and get it from there in fast path for better performance. Currently rte_eth_dev_get_sec_ctx() which is meant to be control path API is called per packet basis. For every call to that API, ethdev port status is checked. Signed-off-by: Nithin

[PATCH v2 6/7] examples/ipsec-secgw: update eth header during route lookup

2022-04-21 Thread Nithin Dabilpuram
Update ethernet header during route lookup instead of doing way later while performing Tx burst. Advantages to doing is at route lookup is that no additional IP version checks based on packet data are needed and packet data is already in cache as route lookup is already consuming that data. This i

[PATCH v2 7/7] examples/ipsec-secgw: add poll mode worker for inline proto

2022-04-21 Thread Nithin Dabilpuram
Add separate worker thread when all SA's are of type inline protocol offload and librte_ipsec is enabled in order to make it more optimal for that case. Current default worker supports all kinds of SA leading to doing lot of per-packet checks and branching based on SA type which can be of 5 types o

Re: [RFC PATCH v3 1/8] eal: annotate spinlock and rwlock

2022-04-21 Thread Maxime Coquelin
Hi David, On 4/11/22 13:00, David Marchand wrote: clang offers some thread safety checks, statically verifying that locks are taken and released in the code. To use those checks, the full code leading to taking or releasing locks must be annotated with some attributes. Wrap those attributes int

RE: [PATCH 2/5] vhost: add per-virtqueue statistics support

2022-04-21 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, January 27, 2022 10:57 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 2/5] vhost: add per-virtqueue statistics support > > This patch introduces new APIs f

Re: kni: check abi version between kmod and lib

2022-04-21 Thread Ray Kinsella
Stephen Coleman writes: > KNI ioctl functions copy data from userspace lib, and this interface > of kmod is not compatible indeed. If the user use incompatible rte_kni.ko > bad things happen: sometimes various fields contain garbage value, > sometimes it cause a kmod soft lockup. > > Some commo

[PATCH] examples/l3fwd: fix issue with MTU set on event mode

2022-04-21 Thread Nithin Dabilpuram
MTU configuration is missing for ethdev when using eventmode when user provides it via "--max-pkt-len" config. It is only done in poll mode setup. Fix the event mode setup code to do the same. Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") Cc: ferruh.yi...@intel.com Cc: sta...@dpdk.org

[PATCH v3 0/7] Add new cryptodev op for event metadata

2022-04-21 Thread Akhil Goyal
For using event crypto metadata, event metadata need to be set in session. For this session user data was used for symmetric crypto sessions and no support was present for asymmetric and security sessions. The use of userdata to store event metadata (which is dereferenced in PMD) is not correct as

[PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-04-21 Thread Akhil Goyal
From: Volodymyr Fialko Currently, crypto session userdata is used to set event crypto metadata from the application and the driver is dereferencing it in driver which is not correct. User data is meant to be opaque to the driver. To support this, new API is added to get and set event crypto metad

[PATCH v3 2/7] crypto/cnxk: add event metadata set operation

2022-04-21 Thread Akhil Goyal
From: Volodymyr Fialko Added cryptodev operation for setting event crypto metadata for all supported sessions - sym/asym/security. Signed-off-by: Volodymyr Fialko Signed-off-by: Akhil Goyal --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 144 +++--- drivers/crypto/cnxk/cn10k_i

[PATCH v3 3/7] crypto/octeontx: use new API for event metadata

2022-04-21 Thread Akhil Goyal
For getting event crypto metadata from crypto_op, the new API rte_cryptodev_get_session_event_mdata can be used directly instead of getting userdata inside PMD. Signed-off-by: Akhil Goyal --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 20 +--- 1 file changed, 1 insertion(+), 1

[PATCH v3 4/7] test/event: use new API to set event crypto metadata

2022-04-21 Thread Akhil Goyal
Used the new API rte_cryptodev_set_session_event_mdata to set event crypto metadata from the applications (app/test and app/test-eventdev) instead of using session userdata. Signed-off-by: Akhil Goyal --- app/test-eventdev/test_perf_common.c | 8 ++-- app/test/test_event_crypto_adapter.c |

[PATCH v3 5/7] eventdev: use new API to get event crypto metadata

2022-04-21 Thread Akhil Goyal
For getting event crypto metadata from crypto_op, the new API rte_cryptodev_get_session_event_mdata is used instead of getting userdata inside PMD. Signed-off-by: Akhil Goyal --- lib/eventdev/rte_event_crypto_adapter.c | 55 ++--- 1 file changed, 12 insertions(+), 43 deletion

[PATCH v3 6/7] test/event: add asymmetric cases for crypto adapter

2022-04-21 Thread Akhil Goyal
Test app is updated to add cases for asymmetric crypto sessions for event crypto adapter. Signed-off-by: Akhil Goyal --- app/test/test_event_crypto_adapter.c | 491 ++- 1 file changed, 485 insertions(+), 6 deletions(-) diff --git a/app/test/test_event_crypto_adapter.c b

[PATCH v3 7/7] test-eventdev: support asym ops for crypto adapter

2022-04-21 Thread Akhil Goyal
Test eventdev app is updated to add new option for asymmetric crypto ops for event crypto adapter. Signed-off-by: Akhil Goyal --- app/test-eventdev/evt_common.h | 2 + app/test-eventdev/evt_options.c | 17 ++ app/test-eventdev/evt_options.h | 4 + app/test-eventdev/test_perf

Re: kni: check abi version between kmod and lib

2022-04-21 Thread Stephen Hemminger
On Thu, 21 Apr 2022 12:38:26 +0800 Stephen Coleman wrote: > KNI ioctl functions copy data from userspace lib, and this interface > of kmod is not compatible indeed. If the user use incompatible rte_kni.ko > bad things happen: sometimes various fields contain garbage value, > sometimes it cause a

Re: [PATCH v1 3/5] ethdev: add API for direct rearm mode

2022-04-21 Thread Stephen Hemminger
On Wed, 20 Apr 2022 16:16:48 +0800 Feifei Wang wrote: > Add API for enabling direct rearm mode and for mapping RX and TX > queues. Currently, the API supports 1:1(txq : rxq) mapping. > > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > Reviewed-by:

OVS DPDK DMA-Dev library/Design Discussion

2022-04-21 Thread Mcnamara, John
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:GMT Standard Time BEGIN:STANDARD DTSTART:16010101T02 TZOFFSETFROM:+0100 TZOFFSETTO:+ RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T01 T

[PATCH 01/10] doc/guides/bbdevs: add ark baseband device documentation

2022-04-21 Thread John Miller
Add new ark baseband device documentation. This is the first patch in the series that introduces the Arkville baseband PMD. First we create a common/ark directory and move common files from net/ark to share with the new baseband/ark device. Next we create baseband/ark and introduce the Arkville

[PATCH 02/10] common/ark: create common subdirectory for baseband support

2022-04-21 Thread John Miller
Create a common directory in drivers/common and move common ark files to prepare support for Arkville baseband device. Signed-off-by: John Miller --- MAINTAINERS | 1 + drivers/{net => common}/ark/ark_ddm.c | 2 +- drivers/{net => common}/ark/ark_ddm.h | 1

[PATCH 03/10] common/ark: move common files to common subdirectory

2022-04-21 Thread John Miller
Add common ark files to drivers/common directory in preparation to support Arkville baseband device. Signed-off-by: John Miller --- drivers/common/ark/ark_common.c | 7 ++ drivers/common/ark/ark_common.h | 48 ++ drivers/common/ark/meson.build | 13 drivers/common/ark/versi

[PATCH 04/10] common/meson.build:

2022-04-21 Thread John Miller
Add common ark to build system. Signed-off-by: John Miller --- drivers/common/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/common/meson.build b/drivers/common/meson.build index ea261dd70a..5514f4ba83 100644 --- a/drivers/common/meson.build +++ b/drivers/common/meson.bu

[PATCH 05/10] baseband/ark: add ark baseband device

2022-04-21 Thread John Miller
Add new ark baseband device. Signed-off-by: John Miller --- drivers/baseband/ark/ark_bbdev.c| 1064 +++ drivers/baseband/ark/ark_bbdev_common.c | 125 +++ drivers/baseband/ark/ark_bbdev_common.h | 92 ++ drivers/baseband/ark/ark_bbdev_custom.c | 201 + drivers

[PATCH 06/10] net/ark: add ark PMD log interface

2022-04-21 Thread John Miller
Added ark PMD log interface for use in arkville devices. Signed-off-by: John Miller --- drivers/net/ark/ark_ethdev.c | 93 --- drivers/net/ark/ark_ethdev_logs.c | 7 +++ drivers/net/ark/ark_ethdev_logs.h | 25 + drivers/net/ark/ark_ethdev_rx.c | 40 +++

[PATCH 07/10] maintainers: add baseband ark maintainers

2022-04-21 Thread John Miller
Add Atomic Rules ARK baseband device. Signed-off-by: John Miller --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4716c92e78..380dd204a6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1330,6 +1330,13 @@ F: drivers/baseband/la12xx/ F: doc

[PATCH 08/10] baseband/ark: add ark baseband user extensions

2022-04-21 Thread John Miller
Add ark baseband user extensions. Signed-off-by: John Miller --- drivers/baseband/ark/ark_bbdev.c| 146 +++-- drivers/baseband/ark/ark_bbdev_common.h | 8 ++ drivers/baseband/ark/ark_bbext.h| 163 3 files changed, 306 insertions(+), 11 d

[PATCH 09/10] baseband/meson.build:

2022-04-21 Thread John Miller
Add ark baseband device to build system. Signed-off-by: John Miller --- drivers/baseband/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build index 686e98b2ed..084ff46155 100644 --- a/drivers/baseband/meson.build +++ b/driver

[PATCH 10/10] net/ark: repair meson dependency format

2022-04-21 Thread John Miller
Repair meson dependency format. Signed-off-by: John Miller --- drivers/net/ark/meson.build | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/ark/meson.build b/drivers/net/ark/meson.build index 8d87744c22..c48044b8ee 100644 --- a/drivers/net/ark/meson.bu

[PATCH] maintainers: update email address

2022-04-21 Thread Konstantin Ananyev
Use new email address. Signed-off-by: Konstantin Ananyev --- MAINTAINERS | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7c4f541dba..2177839da3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -298,7 +298,7 @@ F: examples/*/*_altivec.

Re: [RFC PATCH v3 2/8] vhost: annotate virtqueue access lock

2022-04-21 Thread Maxime Coquelin
On 4/11/22 13:00, David Marchand wrote: This change simply annotates existing paths of the code leading to manipulations of the vq->access_lock. One small change is required: vhost_poll_enqueue_completed was getting a queue_id to get hold of the vq, while its callers already knew of the vq. F

Re: kni: check abi version between kmod and lib

2022-04-21 Thread Ray Kinsella
Stephen Hemminger writes: > On Thu, 21 Apr 2022 12:38:26 +0800 > Stephen Coleman wrote: > >> KNI ioctl functions copy data from userspace lib, and this interface >> of kmod is not compatible indeed. If the user use incompatible rte_kni.ko >> bad things happen: sometimes various fields contain

Re: kni: check abi version between kmod and lib

2022-04-21 Thread Stephen Hemminger
On Thu, 21 Apr 2022 11:40:00 -0400 Ray Kinsella wrote: > Stephen Hemminger writes: > > > On Thu, 21 Apr 2022 12:38:26 +0800 > > Stephen Coleman wrote: > > > >> KNI ioctl functions copy data from userspace lib, and this interface > >> of kmod is not compatible indeed. If the user use incompat

[PATCH 1/3] table: improve learner table timers

2022-04-21 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 3 +- lib/pipeline/rte_swx_pipeline_internal.h | 3 +- lib/table/rte_swx_table_learner.c| 109 --- lib/table/rte_swx_table_learner.h| 90 +-- lib/table/versio

[PATCH 2/3] pipeline: improve learner table timers

2022-04-21 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_ctl.h | 3 + lib/pipeline/rte_swx_pipeline.c | 164 --- lib/pipeline/rte_swx_pipeline.h | 7 +- lib/pipeline/rte_swx_pipeline_internal.h | 70 +- lib/pipeline/rte_swx_pipel

[PATCH 3/3] examples/pipeline: improve learner table timers

2022-04-21 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 2 ++ examples/pipeline/examples/learner.spec | 15 +-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index d52ad6b61e..0334616bd9 1006

DPDK Release Status Meeting 2022-04-20

2022-04-21 Thread Mcnamara, John
Release status meeting minutes 2022-04-20 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Marvell * Nvidia * Red Hat * Xilinx/AMD Release Dates - The following are the proposed current dat

RE: [PATCH] maintainers: update email address

2022-04-21 Thread Mcnamara, John
> -Original Message- > From: Konstantin Ananyev > Sent: Thursday, April 21, 2022 4:21 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net > Subject: [PATCH] maintainers: update email address > > Use new email address. Acked-by: John McNamara

[PATCH v2] kni: check abi version between kmod and lib

2022-04-21 Thread youcai
KNI ioctl functions copy data from userspace lib, and this interface of kmod is not compatible indeed. If the user use incompatible rte_kni.ko bad things happen: sometimes various fields contain garbage value, sometimes it cause a kmod soft lockup. Some common distros ship their own rte_kni.ko, so

RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug

2022-04-21 Thread Jeff Daly
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, April 19, 2022 9:09 PM > To: Jeff Daly ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > hotplug > > Caution: This is an external email. Please take

[PATCH] app/test: fix buffer overflow in table unit tests

2022-04-21 Thread Vladimir Medvedkin
This patch fixes stack buffer overflow reported by ASAN. Bugzilla ID: 820 Fixes: 5205954791cb ("app/test: packet framework unit tests") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_table_tables.c | 10 +- 1 file changed, 5 ins

[dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-04-21 Thread jerinj
From: Jerin Jacob Currently, meter object supports only DSCP based on input color table, The patch enhance that to support VLAN based input color table, color table based on inner field for the tunnel use case, and support for fallback color per meter if packet based on a different field. All of

[PATCH v1 01/19] cmdline: remove unneeded header includes

2022-04-21 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cmdline/cmdline_cirbuf.h| 1 - lib/cmdline/cmdline_parse_num.c | 3 --- lib/cmdline/cmdline_socket.c| 5 - lib/cmdline/cmdline_socket.h| 1 - 4 files changed, 10 deletions(

[PATCH v1 00/19] remove IWYU flagged headers

2022-04-21 Thread Sean Morrissey
This patchset removes unused header includes flagged by the IWYU tool for the 22.07 release. Sean Morrissey (19): cmdline: remove unneeded header includes eal: remove unneeded header includes ethdev: remove unneeded header includes gpudev: remove unneeded header includes gso: remove unne

[PATCH v1 02/19] eal: remove unneeded header includes

2022-04-21 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/eal/common/eal_common_config.c | 1 - lib/eal/common/eal_common_launch.c | 1 - lib/eal/common/eal_common_log.c| 1 - lib/eal/common/malloc_heap.h | 1 - lib/eal/linux/eal.c

[PATCH v1 03/19] ethdev: remove unneeded header includes

2022-04-21 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ethdev/rte_class_eth.c | 2 -- lib/ethdev/rte_ethdev.c| 9 - lib/ethdev/rte_ethdev.h| 1 - lib/ethdev/rte_flow.c | 2 -- lib/ethdev/rte_flow.h | 3 --- lib/ethdev

[PATCH v1 04/19] gpudev: remove unneeded header includes

2022-04-21 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index 56033f4a5f..ee3ae80f82 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/

  1   2   >