[PATCH v3 0/5] add telemetry command for show module EEPROM

2022-04-20 Thread Robin Zhang
Introduce a new telemetry command /ethdev/module_eeprom to show module EEPROM for each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/ QSFP+(Quad Small Formfactor Pluggable)/

[PATCH v3 1/5] ethdev: add telemetry command for module EEPROM

2022-04-20 Thread Robin Zhang
Add a new telemetry command /ethdev/module_eeprom to dump the module EEPROM of each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/ QSFP+(Quad Small Formfactor Pluggable)/QSF

[PATCH v3 2/5] ethdev: common utilities for different SFF specs

2022-04-20 Thread Robin Zhang
This patch implements SFF-8024 Rev 4.0 of pluggable I/O configuration and some common utilities for SFF-8436/8636 and SFF-8472/8079. Signed-off-by: Robin Zhang --- lib/ethdev/sff_common.c | 414 lib/ethdev/sff_common.h | 191 ++ 2 files ch

[PATCH v3 3/5] ethdev: format module EEPROM for SFF-8079

2022-04-20 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8079 Rev 1.7 Signed-off-by: Robin Zhang --- lib/ethdev/sff_8079.c | 672 ++ 1 file changed, 672 insertions(+) create mode 100644 lib/ethdev/sff_8079.c diff --git a/lib/ethdev/sff_8079.c b/lib

[PATCH v3 4/5] ethdev: format module EEPROM for SFF-8472

2022-04-20 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8472 Rev 12.0 Signed-off-by: Robin Zhang --- lib/ethdev/sff_8472.c | 301 ++ 1 file changed, 301 insertions(+) create mode 100644 lib/ethdev/sff_8472.c diff --git a/lib/ethdev/sff_8472.c b/li

[PATCH v3 5/5] ethdev: format module EEPROM for SFF-8636

2022-04-20 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8636 Rev 2.7 Signed-off-by: Robin Zhang --- lib/ethdev/sff_8636.c | 1004 + lib/ethdev/sff_8636.h | 592 2 files changed, 1596 insertions(+) create mode 100644 lib/et

RE: [PATCH] kni: update kernel API to receive packets

2022-04-20 Thread Wang, Haiyue
> -Original Message- > From: Gagandeep Singh > Sent: Wednesday, April 20, 2022 13:03 > To: dev@dpdk.org > Cc: Gagandeep Singh > Subject: [PATCH] kni: update kernel API to receive packets > > API 'netif_rx_ni()' has been removed in kernel with commit: > baebdf48c3600 ("net: dev: Makes sur

[PATCH v1 0/5] Direct re-arming of buffers on receive side

2022-04-20 Thread Feifei Wang
Currently, the transmit side frees the buffers into the lcore cache and the receive side allocates buffers from the lcore cache. The transmit side typically frees 32 buffers resulting in 32*8=256B of stores to lcore cache. The receive side allocates 32 buffers and stores them in the receive side so

[PATCH v1 1/5] net/i40e: remove redundant Dtype initialization

2022-04-20 Thread Feifei Wang
The Dtype field is set to 0xf by the NIC to indicate DMA completion, only after the CPU requests to be informed by setting the RS bit. Hence, it is not required to set Dtype to 0xf during initialization. Not setting the Dtype field to 0xf helps to know that a given descriptor is not sent to the NI

[PATCH v1 2/5] net/i40e: enable direct rearm mode

2022-04-20 Thread Feifei Wang
For i40e driver, enable direct re-arm mode. This patch supports the case of mapping Rx/Tx queues from the same single lcore. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- drivers/net/i40e/i40e_rxtx.h|

[PATCH v1 3/5] ethdev: add API for direct rearm mode

2022-04-20 Thread Feifei Wang
Add API for enabling direct rearm mode and for mapping RX and TX queues. Currently, the API supports 1:1(txq : rxq) mapping. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- lib/ethdev/ethdev_driver.h | 15 ++

[PATCH v1 4/5] net/i40e: add direct rearm mode internal API

2022-04-20 Thread Feifei Wang
For direct rearm mode, add two internal functions. One is to enable direct rearm mode in Rx queue. The other is to map Tx queue with Rx queue to make Rx queue take buffers from the specific Tx queue. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Revie

[PATCH v1 5/5] examples/l3fwd: enable direct rearm mode

2022-04-20 Thread Feifei Wang
Enable direct rearm mode. The mapping is decided in the data plane based on the first packet received. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- examples/l3fwd/l3fwd_lpm.c | 16 +++- 1 file changed

Re: DPDK:20.11.1: net/ena crash while fetching xstats

2022-04-20 Thread Amiya Mohakud
Hi Stephen and Michal Thanks a lot for all the discussions and progress made on this.Appreciate it. Sorry for the late reply. To answer your questions: *1. Is the application you're using the single-process or multiprocess?If so, from which process are you probing for the xstats?* >> System has

RE: [PATCH v3 0/5] add telemetry command for show module EEPROM

2022-04-20 Thread Morten Brørup
> From: Robin Zhang [mailto:robinx.zh...@intel.com] > Sent: Wednesday, 20 April 2022 09.00 > > Introduce a new telemetry command /ethdev/module_eeprom to show module > EEPROM for each port. The format of module EEPROM information follows > the SFF(Small Form Factor) Committee specifications. > >

Re: [PATCH v3 1/5] ethdev: add telemetry command for module EEPROM

2022-04-20 Thread Andrew Rybchenko
On 4/20/22 10:00, Robin Zhang wrote: Add a new telemetry command /ethdev/module_eeprom to dump the module EEPROM of each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/ QSF

RE: [PATCH v3] raw/ifpga: remove vdev when ifpga is closed

2022-04-20 Thread Huang, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, March 29, 2022 10:15 > To: Huang, Wei ; dev@dpdk.org; > tho...@monjalon.net; Xu, Rosen ; > nipun.gu...@nxp.com; hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > > Subject: RE: [PATCH v3] raw/ifpga: rem

RE: [PATCH v1 3/5] ethdev: add API for direct rearm mode

2022-04-20 Thread Morten Brørup
> From: Feifei Wang [mailto:feifei.wa...@arm.com] > Sent: Wednesday, 20 April 2022 10.17 > > Add API for enabling direct rearm mode and for mapping RX and TX > queues. Currently, the API supports 1:1(txq : rxq) mapping. > > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Feifei Wang > Revie

RE: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode

2022-04-20 Thread Morten Brørup
> From: Feifei Wang [mailto:feifei.wa...@arm.com] > Sent: Wednesday, 20 April 2022 10.17 > > Enable direct rearm mode. The mapping is decided in the data plane > based > on the first packet received. I usually don't care much about l3fwd, but putting configuration changes in the fast path is jus

Re: [PATCH v2 2/7] vdpa/mlx5: fix dead loop when process interrupted

2022-04-20 Thread Maxime Coquelin
On 2/24/22 16:50, Xueming Li wrote: In Ctrl+C handling, sometimes kick handling thread gets endless EGAIN error and fall into dead lock. Kick happens frequently in real system due to busy traffic or retry mechanism. This patch simplifies kick firmware anyway and skip setting hardware notifier

RE: [PATCH] kni: update kernel API to receive packets

2022-04-20 Thread Gagandeep Singh
> -Original Message- > From: Wang, Haiyue > Sent: Wednesday, April 20, 2022 1:15 PM > To: Gagandeep Singh ; dev@dpdk.org > Subject: RE: [PATCH] kni: update kernel API to receive packets > > > -Original Message- > > From: Gagandeep Singh > > Sent: Wednesday, April 20, 2022 13:0

Re: [PATCH v2 1/7] vdpa/mlx5: fix interrupt trash that leads to segment fault

2022-04-20 Thread Maxime Coquelin
On 2/24/22 16:50, Xueming Li wrote: Disable interrupt unregister timeout to avoid invalid FD caused interrupt thread segment fault. Fixes: 62c813706e41 ("vdpa/mlx5: map doorbell") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c

Re: [PATCH v1 3/5] ethdev: add API for direct rearm mode

2022-04-20 Thread Andrew Rybchenko
On 4/20/22 11:16, Feifei Wang wrote: Add API for enabling direct rearm mode and for mapping RX and TX queues. Currently, the API supports 1:1(txq : rxq) mapping. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- li

RE: [PATCH 1/7] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-04-20 Thread Ananyev, Konstantin
Hi Nithin, > >> Enable Tx IPv4 checksum offload only when Tx inline crypto, lookaside > >> crypto/protocol or cpu crypto is needed. > >> For Tx Inline protocol offload, checksum computation > >> is implicitly taken care by HW. > > > > The thing is that right now it is not stated explicitly that >

Re: [PATCH v1 3/5] ethdev: add API for direct rearm mode

2022-04-20 Thread Jerin Jacob
On Wed, Apr 20, 2022 at 1:47 PM Feifei Wang wrote: > > Add API for enabling direct rearm mode and for mapping RX and TX > queues. Currently, the API supports 1:1(txq : rxq) mapping. > > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > Reviewed-by: Ho

[PATCH] net/iavf: fix device initialization

2022-04-20 Thread Radu Nicolau
When the inline crypto feature VF capability flag is set also check if the feature is enabled, otherwise the initialization will fail even when the inline crypto is not required. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- dr

[PATCH] net/tap: Fixed RSS algorithm to support fragmented packets

2022-04-20 Thread madhuker . mythri
From: Madhuker Mythri As per analysis on Tap PMD, the existing RSS algorithm considering 4-tuple(Src-IP, Dst-IP, Src-port and Dst-port) and identification of fragment packets is not done, thus we are seeing all the fragmented chunks of single packet differs in RSS hash value and distributed acros

RE: [PATCH v4 1/2] net/ice: fix DCF ACL flow engine

2022-04-20 Thread Zhang, Qi Z
> -Original Message- > From: Liu, KevinX > Sent: Wednesday, April 20, 2022 12:02 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Alvin Zhang > ; Liu, KevinX > Subject: [PATCH v4 1/2] net/ice: fix DCF ACL flow engine > > From: Alvin Zhang > > ACL is not a ne

Re: [PATCH v2 3/7] vdpa/mlx5: no kick handling during shutdown

2022-04-20 Thread Maxime Coquelin
On 2/24/22 16:50, Xueming Li wrote: When Qemu suspend a VM, hw notifier is un-mmapped while vCPU thread may suspends still active and write notifier through kick socket. still be active PMD kick handler thread tries to install hw notifier through client socket in such case will timeout a

RE: [PATCH] net/iavf: remove extra copy step in Rx bulk path

2022-04-20 Thread Zhang, Qi Z
> -Original Message- > From: Kathleen Capella > Sent: Friday, March 25, 2022 6:12 AM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; n...@arm.com; honnappa.nagaraha...@arm.com; > dharmik.thak...@arm.com; Kathleen Capella > Subject: [PATCH] net/iavf: remove extra copy step in Rx

RE: [PATCH v2 3/7] vdpa/mlx5: no kick handling during shutdown

2022-04-20 Thread Xueming(Steven) Li
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, April 20, 2022 8:38 PM > To: Xueming(Steven) Li ; dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > Subject: Re: [PATCH v2 3/7] vdpa/mlx5: no kick handling during shutdown > > > > On 2/24/22 16:50, Xueming Li wrote: > >

RE: [PATCH] net/ice: promote dynflag API

2022-04-20 Thread Zhang, Qi Z
> -Original Message- > From: Ray Kinsella > Sent: Tuesday, April 19, 2022 11:56 PM > To: Zhang, Peng1X > Cc: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > ; Richardson, Bruce > Subject: Re: [PATCH] net/ice: promote dynflag API > > > peng1x.zh...@intel.com writes: > > > From: Peng Zhan

[PATCH v2] net/nfp: update how MAX MTU is read

2022-04-20 Thread Walter Heymans
The 'max_rx_pktlen' value was previously read from hardware, which was set by the running firmware. This caused confusion due to different meanings of 'MAX_MTU'. This patch updates the 'max_rx_pktlen' to the maximum value that the NFP NIC can support. The 'max_mtu' value that is read from hardware,

RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-20 Thread Akhil Goyal
Hi Ray, > >> > > > +RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > >> > > > +/** Hard byte expiry of SA */ > >> > > > +RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > >> > > > +/** Hard packet expiry of SA */ > >> > > > +RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, > >> > > > >> > > Same comment fo

RE: [PATCH v5 03/16] vhost: add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG

2022-04-20 Thread Xia, Chenbo
Hi Andy, > -Original Message- > From: Pei, Andy > Sent: Monday, March 28, 2022 3:17 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v5 03/16] vhost: add support for VHOST_USER_GET_CONFIG and > VHOST_USER_SET_CONFIG Let

Re: [v4 1/3] ethdev: introduce protocol type based header split

2022-04-20 Thread Andrew Rybchenko
On 4/12/22 19:40, Ding, Xuan wrote: Hi Jacob, -Original Message- From: Jerin Jacob Sent: Thursday, April 7, 2022 9:27 PM To: Wu, WenxuanX Cc: Thomas Monjalon ; Andrew Rybchenko ; Li, Xiaoyun ; Singh, Aman Deep ; Zhang, Yuying ; Zhang, Qi Z ; dpdk-dev ; Stephen Hemminger ; Morten Brøru

Re: [PATCH 2/3] mem: fix ASan shadow for remapped memory segments

2022-04-20 Thread Burakov, Anatoly
On 15-Apr-22 6:31 PM, David Marchand wrote: When releasing some memory, the allocator can choose to return some pages to the OS. At the same time, this memory was poisoned in ASAn shadow. Doing the latter made it impossible to remap this same page later. On the other hand, without this poison, th

Re: [PATCH 1/3] test/mem: disable ASan when accessing unallocated mem

2022-04-20 Thread Burakov, Anatoly
On 15-Apr-22 6:31 PM, David Marchand wrote: As described in bugzilla, ASan reports accesses to all memory segment as invalid, since those parts have not been allocated. Move __rte_no_asan to rte_common.h and disable ASan on a part of the test. Bugzilla ID: 880 Fixes: 6cc51b1293ce ("mem: instrume

Re: [PATCH v2 4/7] vdpa/mlx5: reuse resources in reconfiguration

2022-04-20 Thread Maxime Coquelin
On 2/24/22 16:50, Xueming Li wrote: To speed up device resume, create reuseable resources during device probe state, release when device remove. Reused resources includes TIS, "when device is removed" TD, VAR Doorbell mmap, error handling event channel and interrupt handler, UAR, Rx event

Re: [PATCH v2 5/7] vdpa/mlx5: cache and reuse hardware resources

2022-04-20 Thread Maxime Coquelin
On 2/24/22 16:50, Xueming Li wrote: During device suspend and resume, resources are not changed normally. When huge resources allocated to VM, like huge memory size or lots of "When huge resources were allocated" queues, time spent on release and recreate became significant. To speed up,

[PATCH] net/mlx5: fix rxq/txq stats memory access sync

2022-04-20 Thread Raja Zidane
Queue statistics are being continuously updated in Rx/Tx burst routines while handling traffic. In addition to that, statistics can be reset (written with zeroes) on statistics reset in other threads, causing a race condition, which in turn could result in wrong stats. The patch provides an approa

Re: [PATCH] eal: fix data race in multi-process support

2022-04-20 Thread Burakov, Anatoly
On 17-Dec-21 6:29 PM, Stephen Hemminger wrote: If DPDK is built with thread sanitizer it reports a race in setting of multiprocess file descriptor. The fix is to use atomic operations when updating mp_fd. Simple example: $ dpdk-testpmd -l 1-3 --no-huge ... EAL: Error - exiting with code: 1 Ca

Re: [PATCH] eal/linux: skip attaching to external memory chunk

2022-04-20 Thread Burakov, Anatoly
On 04-Apr-22 1:32 PM, Deepak Khandelwal wrote: when secondary process is initialized(rte_eal_init), external memroy segments should not be attached. These segments will be attached by explicitly invoking rte_malloc_heap_memory_attach API Fixes: ff3619d6244b ("malloc: allow attaching to external

Re: [v4 1/3] ethdev: introduce protocol type based header split

2022-04-20 Thread Andrew Rybchenko
Hi Xuan, On 4/12/22 19:15, Ding, Xuan wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Thursday, April 7, 2022 6:48 PM To: Wu, WenxuanX ; tho...@monjalon.net; Li, Xiaoyun ; Singh, Aman Deep ; Zhang, Yuying ; Zhang, Qi Z Cc: dev@dpdk.org; step...@networkplumber.org; m

Re: [PATCH] eal/linux: skip attaching to external memory chunk

2022-04-20 Thread Burakov, Anatoly
On 04-Apr-22 1:32 PM, Deepak Khandelwal wrote: when secondary process is initialized(rte_eal_init), external memroy segments should not be attached. These segments will be attached by explicitly invoking rte_malloc_heap_memory_attach API Fixes: ff3619d6244b ("malloc: allow attaching to external

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-04-20 Thread Mcnamara, John
> -Original Message- > From: Ilya Maximets > Sent: Friday, April 8, 2022 10:58 AM > To: Hu, Jiayu ; Maxime Coquelin > ; Van Haaren, Harry > ; Morten Brørup ; > Richardson, Bruce > Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, > Ian ; Ferriter, Cian ; > ovs-...@openvswitch.org; dev@dpdk.o

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-04-20 Thread Mcnamara, John
> -Original Message- > From: Ilya Maximets > Sent: Friday, April 8, 2022 10:58 AM > To: Hu, Jiayu ; Maxime Coquelin > ; Van Haaren, Harry > ; Morten Brørup ; > Richardson, Bruce > Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, Ian > ; Ferriter, Cian ; ovs- > d...@openvswitch.org; dev@dpdk

Re: [PATCH] net/pcap: add snaplen argument

2022-04-20 Thread Ferruh Yigit
On 3/13/2022 11:26 AM, Tianli Lai wrote: snaplen argument would set the length of each packet that will save to pcap file. Signed-off-by: Tianli Lai --- doc/guides/nics/pcap_ring.rst | 16 +- drivers/net/pcap/pcap_ethdev.c | 58 +- 2 files changed, 5

Re: [PATCH] doc: fix support table for ETH and VLAN flow items

2022-04-20 Thread Ferruh Yigit
On 3/16/2022 12:01 PM, Ilya Maximets wrote: 'has_vlan' attribute is only supported by sfc, mlx5 and cnxk. Other drivers doesn't support it. Most of them (like i40e) just ignore it silently. Some drivers (like mlx4) never had a full support of the eth item even before introduction of 'has_vlan'

Re: [External] : [PATCH] crypto/qat: use intel-ipsec-mb for partial hash

2022-04-20 Thread Changchun Zhang
Hello, Can I know the status of this patch, and the possible impact on any existing applications because the partial hash is switched from OpenSSL to intel-ipsec-mb which is not under FIPS certification? Thanks! Changchun From: Changchun Zhang Date: Thursday, April 14, 2022 at 2:46 PM To: Fan

Re: [PATCH 1/1] ethdev: add packet expiry event subtype

2022-04-20 Thread Ferruh Yigit
On 3/23/2022 3:04 AM, Vamsi Krishna Attunuru wrote: Ping.. -Original Message- From: Vamsi Attunuru Sent: Thursday, March 17, 2022 1:28 PM To: dev@dpdk.org Cc: Jerin Jacob Kollanukkaran ; Nithin Kumar Dabilpuram ; Akhil Goyal ; Vamsi Krishna Attunuru Subject: [PATCH 1/1] ethdev: add pa

Re: [PATCH v3] net/nfp: fix mtu settings

2022-04-20 Thread Ferruh Yigit
On 3/30/2022 4:17 AM, Peng Zhang wrote: 1.When the setting mtu is higher than flbufsz, the mtu doesn't work. But it doesn't have any notice about this restrict. 2.add the min_mtu and max_mtu in the nfp_net_infos_get() to avoid the setting mtu isn't in the range This patch will add these restrict

RE: [PATCH v3] net/nfp: fix mtu settings

2022-04-20 Thread Nole Zhang
Thanks for your advice. > -Original Message- > From: Ferruh Yigit > Sent: 2022年4月21日 2:55 > To: Nole Zhang ; dev@dpdk.org; Niklas > Soderlund > Cc: Heinrich Kuhn ; sta...@dpdk.org; > Chaoyong He ; Louis Peens > > Subject: Re: [PATCH v3] net/nfp: fix mtu settings > > On 3/30/2022 4:17

[PATCH v4] raw/ifpga: remove vdev when ifpga is closed

2022-04-20 Thread Wei Huang
Virtual devices created on ifpga raw device are not removed when ifpga is closed. To avoid such problem, ifpga virtual device remove function is implemented, virtual device is removed in raw device close function. Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: sta...@dpdk.

RE: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode

2022-04-20 Thread Honnappa Nagarahalli
> > > From: Feifei Wang [mailto:feifei.wa...@arm.com] > > Sent: Wednesday, 20 April 2022 10.17 > > > > Enable direct rearm mode. The mapping is decided in the data plane > > based on the first packet received. > > I usually don't care much about l3fwd, but putting configuration changes in > th

[PATCH v5 01/12] net/ice: enable RSS RETA ops for DCF hardware

2022-04-20 Thread Kevin Liu
From: Steve Yang RSS RETA should be updated and queried by application, Add related ops ('.reta_update', '.reta_query') for DCF. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c| 2 +- drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_et

[PATCH v5 00/12] complete common VF features for DCF

2022-04-20 Thread Kevin Liu
The DCF PMD support the below dev ops, dev_supported_ptypes_get dev_link_update xstats_get xstats_get_names xstats_reset promiscuous_enable promiscuous_disable allmulticast_enable allmulticast_disable mac_addr_add mac_addr_remove set_mc_addr_list vlan_filter_set vlan_offload_set mac_addr_set reta_u

[PATCH v5 02/12] net/ice: enable RSS HASH ops for DCF hardware

2022-04-20 Thread Kevin Liu
From: Steve Yang RSS HASH should be updated and queried by application, Add related ops ('.rss_hash_update', '.rss_hash_conf_get') for DCF. Because DCF doesn't support configure RSS HASH, only HASH key can be updated within ops '.rss_hash_update'. Signed-off-by: Steve Yang Signed-off-by: Kevin

[PATCH v5 03/12] net/ice: cleanup Tx buffers

2022-04-20 Thread Kevin Liu
From: Robin Zhang Add support for ops rte_eth_tx_done_cleanup in dcf Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index ccad7fc30

[PATCH v5 04/12] net/ice: add ops MTU-SET to dcf

2022-04-20 Thread Kevin Liu
From: Jie Wang add API "mtu_set" to dcf, and it can configure the port mtu through cmdline. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 14 ++ drivers/net/ice/ice_dcf_ethdev.h | 6 ++ 2 files changed, 20 insertions(+) diff --git a/

[PATCH v5 05/12] net/ice: add ops dev-supported-ptypes-get to dcf

2022-04-20 Thread Kevin Liu
From: Jie Wang add API "dev_supported_ptypes_get" to dcf, that dcf pmd can get ptypes through the new API. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 80 +++- 1 file changed, 49 insertions(+), 31 deletions(-) diff --git

[PATCH v5 06/12] net/ice: support dcf promisc configuration

2022-04-20 Thread Kevin Liu
From: Alvin Zhang Support configuration of unicast and multicast promisc on dcf. Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 77 ++-- drivers/net/ice/ice_dcf_ethdev.h | 3 ++ 2 files changed, 76 insertions(+), 4 delet

[PATCH v5 07/12] net/ice: support dcf MAC configuration

2022-04-20 Thread Kevin Liu
Below PMD ops are supported in this patch: .mac_addr_add = dcf_dev_add_mac_addr .mac_addr_remove = dcf_dev_del_mac_addr .set_mc_addr_list = dcf_set_mc_addr_list .mac_addr_set = dcf_dev_set_default_mac_addr Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- driv

[PATCH v5 08/12] net/ice: support dcf VLAN filter and offload configuration

2022-04-20 Thread Kevin Liu
From: Alvin Zhang Below PMD ops are supported in this patch: .vlan_filter_set = dcf_dev_vlan_filter_set .vlan_offload_set = dcf_dev_vlan_offload_set Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 101 +++ 1 file

[PATCH v5 09/12] net/ice: add extended stats

2022-04-20 Thread Kevin Liu
Add implementation of xstats() functions in DCF PMD. Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.h| 22 ++ drivers/net/ice/ice_dcf_ethdev.c | 75 2 files changed, 97 insertions(+) diff --git a/drivers/net/ice/ice_dcf.h b/drivers/net/ice/

[PATCH v5 10/12] net/ice: support queue information getting

2022-04-20 Thread Kevin Liu
Add below ops, rxq_info_get txq_info_get Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index 6503700e02..9217392d04 100644 --- a/drivers/net/ice/ice_dcf_ethde

[PATCH v5 11/12] net/ice: implement power management

2022-04-20 Thread Kevin Liu
Implement support for the power management API by implementing a 'get_monitor_addr' function that will return an address of an RX ring's status bit. Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c

[PATCH v5 12/12] doc: update for ice DCF datapath configuration

2022-04-20 Thread Kevin Liu
Update "ice_dcf" driver feature list. Signed-off-by: Kevin Liu --- doc/guides/nics/features/ice_dcf.ini | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/nics/features/ice_dcf.ini b/doc/guides/nics/features/ice_dcf.ini index 54073f0b88..2f3e14a24e 100644 --- a/doc/

[PATCH] net/virtio: unmap PCI device in secondary process

2022-04-20 Thread Yuan Wang
In multi-process, the secondary process will remap PCI during initialization, but the mapping is not removed in the uninit path, the device is not closed, and the device busy error will be reported when the device is hotplugged. This patch unmap PCI device at secondary process uninitialization bas

[PATCH v4 0/4] Enable Protocol Agnostic Flow Offloading in AVF

2022-04-20 Thread Junfeng Guo
This patch set enabled Protocol Agnostic Flow (raw flow) Offloading for FDIR and RSS in AVF. [PATCH v4 1/4] common/iavf: support raw packet in protocol header [PATCH v4 2/4] net/iavf: align with proto hdr struct change [PATCH v4 3/4] net/iavf: enable Protocol Agnostic Flow Offloading FDIR [PATCH v

[PATCH v4 1/4] common/iavf: support raw packet in protocol header

2022-04-20 Thread Junfeng Guo
The patch extends existing virtchnl_proto_hdrs structure to allow VF to pass a pair of buffers as packet data and mask that describe a match pattern of a filter rule. Then the kernel PF driver is requested to parse the pair of buffer and figure out low level hardware metadata (ptype, profile, field

[PATCH v4 2/4] net/iavf: align with proto hdr struct change

2022-04-20 Thread Junfeng Guo
Structure virtchnl_proto_headrs is extended with a union struct for proto_hdr table and raw struct. Thus update the proto_hdrs template init to align the virtchnl changes. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_hash.c | 180 ++- 1 file changed, 92 in

[PATCH v4 3/4] net/iavf: enable Protocol Agnostic Flow Offloading FDIR

2022-04-20 Thread Junfeng Guo
This patch enabled Protocol Agnostic Flow Offloading FDIR in AVF. Signed-off-by: Junfeng Guo --- doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/iavf/iavf_fdir.c | 67 ++ drivers/net/iavf/iavf_generic_flow.c | 6 +++ drivers/net/iavf/iavf_generic_f

[PATCH v4 4/4] net/iavf: support Protocol Agnostic Flow Offloading VF RSS

2022-04-20 Thread Junfeng Guo
From: Ting Xu Enable Protocol Agnostic Flow Offloading RSS hash for VF. Signed-off-by: Ting Xu --- drivers/net/iavf/iavf_hash.c | 96 1 file changed, 96 insertions(+) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index 278e75117d

[PATCH v2] kni: update kernel API to receive packets

2022-04-20 Thread Gagandeep Singh
API 'netif_rx_ni()' has been removed in kernel with commit: baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.") The API netif_rx() can be used for any context to receive packets from device drivers. This patch replaces the API netif_rx_ni() with netif_rx() for kernel

[Bug 998] kni: corruption when using incompatible version of rte_kni.ko

2022-04-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=998 Bug ID: 998 Summary: kni: corruption when using incompatible version of rte_kni.ko Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCON

kni: check abi version between kmod and lib

2022-04-20 Thread Stephen Coleman
KNI ioctl functions copy data from userspace lib, and this interface of kmod is not compatible indeed. If the user use incompatible rte_kni.ko bad things happen: sometimes various fields contain garbage value, sometimes it cause a kmod soft lockup. Some common distros ship their own rte_kni.ko, so

RE: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode

2022-04-20 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, 21 April 2022 04.35 > > > > > From: Feifei Wang [mailto:feifei.wa...@arm.com] > > > Sent: Wednesday, 20 April 2022 10.17 > > > > > > Enable direct rearm mode. The mapping is decided in the data plane > > > based on

RE: [EXT] Re: [PATCH 1/1] ethdev: add packet expiry event subtype

2022-04-20 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, April 20, 2022 11:46 PM > To: Vamsi Krishna Attunuru ; dev@dpdk.org; > Anoob Joseph ; Konstantin Ananyev > > Cc: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Akhil Goyal > > Subject: [EXT] Re: [PATCH 1/1] ethdev: a

Re: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs

2022-04-20 Thread Andrew Rybchenko
On 4/16/22 04:38, Stephen Hemminger wrote: On Sat, 16 Apr 2022 09:07:45 +0800 Chengwen Feng wrote: Currently the telemetry xstats uses rte_eth_xstats_get() to retrieve the number of elements. But the value to be returned when the parameter 'xstats' is NULL is not specified, some PMDs (eg. hns3

Re: [PATCH 2/3] ethdev: fix memory leak when telemetry xstats

2022-04-20 Thread Andrew Rybchenko
On 4/16/22 04:07, Chengwen Feng wrote: The 'eth_xstats' should be freed after setup telemetry dictionary. This patch fixes it. Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Reviewed-by: Andrew Rybchenko