> -----Original Message----- > From: Maxime Coquelin <maxime.coque...@redhat.com> > Sent: Wednesday, April 20, 2022 8:38 PM > To: Xueming(Steven) Li <xuemi...@nvidia.com>; dev@dpdk.org > Cc: Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com> > Subject: Re: [PATCH v2 3/7] vdpa/mlx5: no kick handling during shutdown > > > > On 2/24/22 16:50, Xueming Li wrote: > > When Qemu suspend a VM, hw notifier is un-mmapped while vCPU thread > > may > suspends > > still active and write notifier through kick socket. > still be active > > > > > PMD kick handler thread tries to install hw notifier through client > > socket in such case will timeout and slow down device close. > socket. In such case, it will > > > > > This patch skips hw notifier install if VQ or device in middle of > > shutdown. > > > > Signed-off-by: Xueming Li <xuemi...@nvidia.com> > > --- > > drivers/vdpa/mlx5/mlx5_vdpa.c | 17 ++++++++++------- > > drivers/vdpa/mlx5/mlx5_vdpa.h | 8 +++++++- > > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 12 +++++++++++- > > 3 files changed, 28 insertions(+), 9 deletions(-) > > > > Other than the commit messages comments: > > Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> > > If you are fine with my suggestions and no other revision needed, I can fixup > while applying.
Hi Maxime, No further changes so far, please continue, thanks for taking care of this series! > > Thanks, > Maxime
