dev@dpdk.org

2022-03-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=744 gaodaxue (daxuex@intel.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|---

[PATCH v3] app/testpmd: fix issue with memory leaks when quit testpmd

2022-03-25 Thread Ke Zhang
A multicast address pool is allocated for a port when using mcast_addr testpmd commands. When closing a port or stopping testpmd, this pool was not freed, resulting in a leak.This issue has been caught using ASan. Free this pool when closing the port. Error info as following: ERROR: LeakSanitize

[PATCH v3] app/testpmd: fix issue with memory leaks when quit testpmd

2022-03-25 Thread Ke Zhang
A multicast address pool is allocated for a port when using mcast_addr testpmd commands. When closing a port or stopping testpmd, this pool was not freed, resulting in a leak.This issue has been caught using ASan. Free this pool when closing the port. Error info as following: ERROR: LeakSanitize

[Bug 981] vhost: avoid sleeping under mutex

2022-03-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=981 Bug ID: 981 Summary: vhost: avoid sleeping under mutex Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Prio

RE: [PATCH v1] dmadev: add telemetry support

2022-03-25 Thread Pai G, Sunil
> -Original Message- > From: Sean Morrissey > Sent: Wednesday, March 23, 2022 10:19 PM > To: Chengwen Feng ; Laatz, Kevin > ; Richardson, Bruce > Cc: dev@dpdk.org; Morrissey, Sean > Subject: [PATCH v1] dmadev: add telemetry support > > Telemetry commands are now registered through the

RE: [PATCH] eventdev: fix telemetry Rx adapters stats reset

2022-03-25 Thread Jayatheerthan, Jay
Looks good, thanks for posting this change. Acked-by: Jay Jayatheerthan -Jay > -Original Message- > From: David Marchand > Sent: Thursday, March 24, 2022 8:59 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Jayatheerthan, Jay ; Jerin > Jacob ; Naga Harish K, S V > ; Kundapura, Ganapati

[PATCH v4] net/ixgbe: retry SFP ID read to handle misbehaving SFPs

2022-03-25 Thread jeffd
From: Stephen Douthit Some XGS-PON SFPs have been observed ACKing I2C reads and returning uninitialized garbage while their uC boots. This can lead to the SFP ID code marking an otherwise working SFP module as unsupported if a bogus ID value is read while its internal PHY/microcontroller is stil

[PATCH] event/cnxk: fix base pointer for SSO head wait

2022-03-25 Thread Volodymyr Fialko
Function roc_sso_hws_head_wait() expects a base as input pointer, and it will itself get tag_op from the base. By passing tag_op instead of base pointer to this function will add SSOW_LF_GWS_TAG register offset twice, which will lead to accessing wrong register. Fixes: 1f5b3d55c041 ("event/cnxk: s

[Bug 982] [dpdk-20.11.5-rc1] ieee1588/ieee1588_enable: ninja build failed with support RTE_LIBRTE_IEEE1588

2022-03-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=982 Bug ID: 982 Summary: [dpdk-20.11.5-rc1] ieee1588/ieee1588_enable: ninja build failed with support RTE_LIBRTE_IEEE1588 Product: DPDK Version: 20.11 Hardware: x86 OS:

[PATCH 0/2] Session crypto event metadata api

2022-03-25 Thread Volodymyr Fialko
Implement API to set/get crypto event meta data per security session. Volodymyr Fialko (2): security: introduce per session event metadata crypto/cnxk: support for security session enqueue .../prog_guide/event_crypto_adapter.rst | 4 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.h |

[PATCH 1/2] security: introduce per session event metadata

2022-03-25 Thread Volodymyr Fialko
Implement API to set/get event data per security session. Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal Acked-by: Anoob Joseph --- .../prog_guide/event_crypto_adapter.rst | 4 +- lib/security/rte_security.h | 43 +++ 2 files changed, 45 insertio

[PATCH 2/2] crypto/cnxk: support for security session enqueue

2022-03-25 Thread Volodymyr Fialko
Add support for enqueue security session to event crypto adapter. Event metadata is used to store request/response information that is needed to enqueue an event after the crypto operation completed. Signed-off-by: Volodymyr Fialko --- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 5 + 1 file c

[dpdk-dev v1] crypto/qat: fix of cipher offset and length assignment

2022-03-25 Thread Kai Ji
This patch fix the cipher offset and length values when convert mbuf to vector chain for QAT build op. Fixes: a815a04cea05 ("crypto/qat: support symmetric build op request") Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 12 ++-- 1 file changed, 6 insertions(+)

[PATCH] examples/ipsec-secgw: fix uninitialized memory access

2022-03-25 Thread Volodymyr Fialko
rte_flow_validate and rte_flow_create not always initialize flow error. Using error.message in some error cases will cause read from uninitialized memory. Fixes: 6738c0a9569 ("examples/ipsec-secgw: support flow director") Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/flow.c | 2 +-

[dpdk-dev] [PATCH] maintainers: update for NFP

2022-03-25 Thread heinrich . kuhn
From: Heinrich Kuhn Niklas has been appointed the new maintainer for the NFP PMD. Update the MAINTAINERS file to reflect this Signed-off-by: Heinrich Kuhn --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index fdea1c623f..2ae2f8ffb4

Re:Re: [PATCH v4] net/bonding: another fix to LACP mempool size

2022-03-25 Thread Gaoxiang Liu
Hi, Stephen, Min Hu, I will fix the issues. Thanks. Gaoxiang. At 2022-03-09 10:53:15, "Min Hu (Connor)" wrote: >Hi, Stephen, > >在 2022/3/9 9:25, Stephen Hemminger 写道: >> On Tue, 8 Mar 2022 22:24:02 +0800 >> Gaoxiang Liu wrote: >> >>> diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_m

[PATCH v5] net/bonding: another fix to LACP mempool size

2022-03-25 Thread Gaoxiang Liu
The following log message may appear after a slave is idle(or nearly idle) for a few minutes:"PMD: Failed to allocate LACP packet from pool". And bond mode 4 negotiation may fail. Problem:When bond mode 4 has been chosed and delicated queue has not been enable, all mbufs from a slave' private pool

Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread Tyler Retzlaff
On Thu, Mar 24, 2022 at 03:44:23PM +0100, David Marchand wrote: > On Thu, Mar 24, 2022 at 9:31 AM Tyler Retzlaff > wrote: > > > diff --git a/lib/eal/common/eal_common_thread.c > > > b/lib/eal/common/eal_common_thread.c > > > index 684bea166c..256de91abc 100644 > > > --- a/lib/eal/common/eal_commo

Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread Tyler Retzlaff
On Wed, Mar 23, 2022 at 10:30:01AM +0100, David Marchand wrote: > All OS implementations provide the same main loop. > Introduce helpers (shared for Linux and FreeBSD) to handle synchronisation > between main and threads and factorize the rest as common code. > Thread id are now logged as string in

[PATCH 1/4] common/cnxk: add CN103XX platform support

2022-03-25 Thread Rahul Bhansali
Added support for CN103XX (cn10kb) platform. Signed-off-by: Rahul Bhansali --- doc/guides/platform/cnxk.rst| 1 + drivers/common/cnxk/roc_constants.h | 1 + drivers/common/cnxk/roc_model.c | 4 drivers/common/cnxk/roc_model.h | 11 ++- 4 files changed, 16 insertio

[PATCH 2/4] net/cnxk: add CN103XX platform support

2022-03-25 Thread Rahul Bhansali
Added PCI device ID for CN103XX (cn10kb) platform. Signed-off-by: Rahul Bhansali --- drivers/net/cnxk/cn10k_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/cnxk/cn10k_ethdev.c b/drivers/net/cnxk/cn10k_ethdev.c index 15dbea2180..ce3707be6f 100644 --- a/drivers/net/cnxk

[PATCH 4/4] mempool/cnxk: add CN103XX platform support

2022-03-25 Thread Rahul Bhansali
Added PCI device ID for CN103XX (cn10kb) platform. Signed-off-by: Rahul Bhansali --- drivers/mempool/cnxk/cnxk_mempool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mempool/cnxk/cnxk_mempool.c b/drivers/mempool/cnxk/cnxk_mempool.c index ea473552dd..a28fe5406d 100644 --- a/driv

[PATCH 3/4] event/cnxk: add CN103XX platform support

2022-03-25 Thread Rahul Bhansali
Added PCI device ID for CN103XX (cn10kb) platform. Signed-off-by: Rahul Bhansali --- drivers/event/cnxk/cn10k_eventdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/event/cnxk/cn10k_eventdev.c b/drivers/event/cnxk/cn10k_eventdev.c index 9b4d2895ec..75c748f611 100644 --- a/driv

RE: [PATCH v5] net/bonding: another fix to LACP mempool size

2022-03-25 Thread Morten Brørup
+CC mempool maintainers > From: Gaoxiang Liu [mailto:gaoxiangl...@163.com] > Sent: Friday, 25 March 2022 14.02 > > The following log message may appear after a slave is idle(or nearly > idle) > for a few minutes:"PMD: Failed to allocate LACP packet from pool". > And bond mode 4 negotiation may fa

RE: DPDK for Windows with MSVC compiler

2022-03-25 Thread Dmitry Kozlyuk
> Is there a way to integrate DPDK module, built with clang/mingw, to our > MSVC application ? > I know both are different compilers, but in case if you are aware of a > way/tweak that will be of our help. > OR > If porting our application is the only option available then which > compiler (clang o

[PATCH v6] net/bonding: another fix to LACP mempool size

2022-03-25 Thread Gaoxiang Liu
The following log message may appear after a slave is idle(or nearly idle) for a few minutes:"PMD: Failed to allocate LACP packet from pool". And bond mode 4 negotiation may fail. Problem:When bond mode 4 has been chosed and delicated queue has not been enable, all mbufs from a slave' private pool

[PATCH v5] net/bonding: another fix to LACP mempool size

2022-03-25 Thread Gaoxiang Liu
The following log message may appear after a slave is idle(or nearly idle) for a few minutes:"PMD: Failed to allocate LACP packet from pool". And bond mode 4 negotiation may fail. Problem:When bond mode 4 has been chosed and delicated queue has not been enable, all mbufs from a slave' private pool

Re: [PATCH v3] examples/vm_power: add support for list_foreach_safe

2022-03-25 Thread David Hunt
Hi Shibin, On 22/3/2022 2:43 PM, Shibin Koikkara Reeny wrote: Asan tool reported LIST_FOREACH should be replaced with LIST_FOREACH_SAFE. Added support for LIST_FOREACH_SAFE macro in rte_os.h file as Linux header file sys/queue.h don't support LIST_FOREACH_SAFE macro. RTE_LIST_FOREACH_SAFE is ali

RE: [PATCH v6] net/bonding: another fix to LACP mempool size

2022-03-25 Thread Morten Brørup
> From: Gaoxiang Liu [mailto:gaoxiangl...@163.com] > Sent: Friday, 25 March 2022 14.34 > > The following log message may appear after a slave is idle(or nearly > idle) > for a few minutes:"PMD: Failed to allocate LACP packet from pool". > And bond mode 4 negotiation may fail. > > Problem:When bon

Re: [PATCH] ci: run more checks in private repositories

2022-03-25 Thread Aaron Conole
David Marchand writes: > Though devtools/checkpatches.sh is run as part of our CI, some other > (not well known) checks could help when run in private repositories > before submitting to the mailing list and even when run from the > ovsrobot. > > Most of them require a git history or checked sour

Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread Thomas Monjalon
25/03/2022 13:11, Tyler Retzlaff: > On Thu, Mar 24, 2022 at 03:44:23PM +0100, David Marchand wrote: > > On Thu, Mar 24, 2022 at 9:31 AM Tyler Retzlaff > > wrote: > > > > diff --git a/lib/eal/common/eal_common_thread.c > > > > b/lib/eal/common/eal_common_thread.c > > > > index 684bea166c..256de91a

Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread David Marchand
On Fri, Mar 25, 2022 at 3:58 PM Thomas Monjalon wrote: > > > But seeing how this code has been there from day 1, I would not > > > request a backport. > > > > this looks better to me it ends up being a bit less code and it solves > > the problem in a general fashion for platforms including windows

[PATCH v1] examples/l3fwd: merge l3fwd-acl into l3fwd

2022-03-25 Thread Sean Morrissey
l3fwd-acl contains duplicate functions to l3fwd. For this reason we merge l3fwd-acl code into l3fwd with '--lookup acl' cmdline option to run ACL. Signed-off-by: Sean Morrissey --- examples/l3fwd-acl/Makefile | 51 - examples/l3fwd-acl/main.c | 2272 -

[PATCH] net/tap: Fixed RSS algorithm to support fragmented packets

2022-03-25 Thread madhuker . mythri
From: Madhuker Mythri As per analysis on DPDK Tap PMD, the existing RSS algorithm considering 4-tuple(Src-IP, Dst-IP, Src-port and Dst-port) and identification of fragment packets is not done, thus we are seeing all the fragmented chunks of single packet differs RSS hash value and distributed

[Bug 983] [21.11] net/mlx5: increase in number of required hugepages

2022-03-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=983 Bug ID: 983 Summary: [21.11] net/mlx5: increase in number of required hugepages Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status: UNCONFIRMED

Re: DPDK for Windows with MSVC compiler

2022-03-25 Thread Tyler Retzlaff
On Fri, Mar 25, 2022 at 01:25:51PM +, Dmitry Kozlyuk wrote: > > Is there a way to integrate DPDK module, built with clang/mingw, to our > > MSVC application ? > > I know both are different compilers, but in case if you are aware of a > > way/tweak that will be of our help. > > OR > > If porting

Re: [PATCH] eal: factorize lcore main loop

2022-03-25 Thread Tyler Retzlaff
On Fri, Mar 25, 2022 at 04:09:50PM +0100, David Marchand wrote: > On Fri, Mar 25, 2022 at 3:58 PM Thomas Monjalon wrote: > > > > But seeing how this code has been there from day 1, I would not > > > > request a backport. > > > > > > this looks better to me it ends up being a bit less code and it s

[RFC] eal: add seqlock

2022-03-25 Thread Mattias Rönnblom
A sequence lock (seqlock) is synchronization primitive which allows for data-race free, low-overhead, high-frequency reads, especially for data structures shared across many cores and which are updated with relatively low frequency. A seqlock permits multiple parallel readers. The variant of seqlo

Re: [RFC] eal: add seqlock

2022-03-25 Thread Stephen Hemminger
On Fri, 25 Mar 2022 21:24:28 +0100 Mattias Rönnblom wrote: > diff --git a/lib/eal/include/rte_seqlock.h b/lib/eal/include/rte_seqlock.h > new file mode 100644 > index 00..b975ca848a > --- /dev/null > +++ b/lib/eal/include/rte_seqlock.h > @@ -0,0 +1,84 @@ > +/* SPDX-License-Identifier: BSD

[PATCH] meson: update doc logic for Windows

2022-03-25 Thread Vipin Varghese
Support for shell scripts doxy-html-custom, generate_doxygen and generate_examples are absent. The current patch address the same by disabling document build notifying the user. Steps to reproduce the error: - Install dependencies doxygen & sphinix build on Windwos server 2019. - Build DPDK with