RE: [PATCH] net/txgbe: fix a bit with boolean operator

2022-03-02 Thread Jiawen Wu
On March 1, 2022 2:09 PM, Weiguo Li wrote: > Since boolean value is in 0 and 1, it's strange to combines a boolean value with > a bit operator. > > Thus it's highly possible a typo error with "if (A & !B)", and more probably to > use "if (A & ~B)" instead. > > Fixes: c1d4e9d37abdc6 ("net/txgbe: a

RE: [PATCH] app/testpmd: fix flow creation parsing

2022-03-02 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Subject: [PATCH] app/testpmd: fix flow creation parsing > > A pattern template creation shares the parsing mechanism with > a simple flow creation. The pattern template creation only consists > of pattern items while the flo

Re: [PATCH] app/testpmd: remove invalid ports when other process detach

2022-03-02 Thread Thomas Monjalon
02/03/2022 03:33, Chengwen Feng: > Start main and secondary process: > ./dpdk-testpmd -a BDF0 -a BDF1 --proc-type=auto -- -i --rxq=8 --txq=8 > --num-procs=2 --proc-id=0 > ./dpdk-testpmd -a BDF0 -a BDF1 --proc-type=auto -- -i --rxq=8 --txq=8 > --num-procs=2 --proc-id=1 > Execute followin

RE: [PATCH] app/testpmd: fix flow creation parsing

2022-03-02 Thread Huang, ZhiminX
> -Original Message- > From: Ori Kam > Sent: Wednesday, March 2, 2022 4:13 PM > To: Alexander Kozyrev ; dev@dpdk.org > Cc: Suanming Mou > Subject: RE: [PATCH] app/testpmd: fix flow creation parsing > > Hi Alexander, > > > > -Original Message- > > From: Alexander Kozyrev > > Su

[PATCH] app/compress-perf: fix socket ID type during init

2022-03-02 Thread Raja Zidane
Socket ID is obtained by function rte_compressdev_socket_id, which returns it as integer, but is interpreted as unsigned byte integer. change type from uint8_t to int. Fixes: ed7dd94f7f66 ("compressdev: add basic device management") Cc: fiona.tr...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ra

[PATCH] app/compress-perf: fix number of QPs to setup

2022-03-02 Thread Raja Zidane
The number of QPs is limited by the number of cores, such that in case the user requests more QPs than possible, the number of QPs actually configured on the device is equal to the number of cores, but the app tries to setup the original number of QPs. Align the number of QPs setup'ed to the limit

RE: MTU and frame size filtering inaccuracy

2022-03-02 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, 1 March 2022 18.50 > > Hi all, > > There is a problem in MTU setting in DPDK. Yes, and the root cause is the unclear definition of what "MTU" means in DPDK! This is causing the confusion about L3 packet size, L2 raw packet si

RE: [PATCH v2 0/2] fix udp checksum error

2022-03-02 Thread Huang, ZhiminX
> -Original Message- > From: Kevin Liu > Sent: Wednesday, December 29, 2021 5:37 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Yigit, Ferruh > ; Liu, KevinX > Subject: [PATCH v2 0/2] fix udp checksum error > > This patchset fixes two related issues: > * When o

RE: [PATCH v1] net/vhost: clear data of packet mbuf after sending pkts

2022-03-02 Thread Zhang, Yuying
Hi Marchand, > -Original Message- > From: David Marchand > Sent: Tuesday, March 1, 2022 5:48 PM > To: Zhang, Yuying > Cc: dev ; Maxime Coquelin ; > Xia, Chenbo ; dpdk stable > Subject: Re: [PATCH v1] net/vhost: clear data of packet mbuf after sending > pkts > > On Tue, Mar 1, 2022 at

RE: [PATCH v3] net/mlx5: fix the NIC egress flow mismatch in switchdev mode

2022-03-02 Thread Ori Kam
Hi Jiawei, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Friday, November 12, 2021 2:43 PM > Subject: [PATCH v3] net/mlx5: fix the NIC egress flow mismatch in switchdev > mode > > When E-Switch mode was enabled, the NIC egress flows was implicitly > appended with source vport

Re: [PATCH v6 1/4] net/ice: add support for setting promisc by DCF

2022-03-02 Thread David Marchand
On Wed, Mar 2, 2022 at 7:35 AM Ke Zhang wrote: > > From: Yiding Zhou > > allow to enable/disable VFs promisc mode over VF0. > this feature need to update ice kernel driver (newer than v1.8.0) I guess v1.8.0 is about the out of tree driver Intel maintains. If so, please state it clearly. I had

[PATCH] app/pdump: close program if --pdump argument is missing

2022-03-02 Thread usman.tanveer
--pdump is a mandatory argument in pdump application. It should print usage and exit if --pdump argument is missing. The application is not closing and geting stuck. Made the change to print usage and exit when this argument is missing. Signed-off-by: usman.tanveer --- app/pdump/main.c | 19

[PATCH] app/pdump: close program if --pdump argument is missing

2022-03-02 Thread usman.tanveer
--pdump is a mandatory argument in pdump application. It should print usage and exit if --pdump argument is missing. The application is not closing and getting stuck. Made the change to print usage and exit when this argument is missing. Signed-off-by: usman.tanveer --- app/pdump/main.c | 19 +++

[PATCH] net/virtio: support NAPI when using vhost_net backend

2022-03-02 Thread Harold Huang
In patch [1], NAPI has been supported in kernel tun driver to accelerate packet processing received from vhost_net. This will greatly improve the throughput of the tap device in the vhost_net backend. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=fb3f903769e8

Re: [PATCH 1/2] devtools: remove event/dlb exception in ABI check

2022-03-02 Thread Ray Kinsella
David Marchand writes: > The event/dlb driver exception can be removed, as this rule made sense > for changes in DPDK_21 ABI and is obsolete for DPDK_22. > > Fixes: fdab8f2e1749 ("version: 21.11-rc0") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Ray Kinsella --

Re: [PATCH 2/2] devtools: use libabigail rule for mlx glue drivers

2022-03-02 Thread Ray Kinsella
David Marchand writes: > Convert the existing exception in the ABI script into a libabigail > suppression rule. > > Note: file_name_regexp could be used to achive the same with versions of > libabigail < 1.7 but soname_regexp has been preferred here since it is > already used with a recent chan

RE: [PATCH] crypto/qat: fix smaller modulus cases for mod exp

2022-03-02 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, March 1, 2022 2:16 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH] crypto/qat: fix smaller modulus cases for mod exp > > This patches fixes not working cases when m

RE: [PATCH] net/mlx5: fix indexed pool fetch overlap issue

2022-03-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, February 23, 2022 8:26 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix indexed pool fetch overlap issue > > For indexed pool with local cac

RE: [PATCH] net/mlx5: fix destroying empty matchers list

2022-03-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Adham Masarwah > Sent: Wednesday, February 23, 2022 11:32 AM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Matan Azrad ; Slava Ovsiienko > ; Tal Shnaiderman ; Tamer > Hleihel ; erfri...@microsoft.com; sta...@dpdk.org > Subject: [PATCH

RE: [PATCH 0/2] net/mlx5: fix validation of count and AGE actions combination

2022-03-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Monday, February 28, 2022 9:10 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 0/2] net/mlx5: fix validation of count and AGE actions > combination > > Fix mistakes done in floe_dv_val

[PATCH v1] net/mlx5: fix meter policy creation assert

2022-03-02 Thread Shun Hao
The meter policy creation doesn't belong to RTE flow creation process, so thread workspace was not initialized and there will be assert error when using it. This patch removes the incorrect using of thread workspace in meter policy creation, and adds a flag in policy instead. When creating RTE flo

RE: [DPDK] /lib/eal: fix failed to stop device monitor error

2022-03-02 Thread Long Li
> Subject: Re: [DPDK] /lib/eal: fix failed to stop device monitor error > > Hello, > > > The title should start with eal/linux: > > On Fri, Feb 11, 2022 at 10:01 AM wrote: > > > > From: Wenxuan Wu > > > > The ret value in rte_dev_event_monitor_stop stands for whether the > > monitor has been

[PATCH] net/mlx5: fix flex item availability

2022-03-02 Thread Gregory Etelson
Flex item availability is restricted to Blue Field 2 and Blue Field 3 PF ports. The patch validates port type compliance before proceeding to flex item creation. Cc: sta...@dpdk.org Fixes: db25cadc0887 ("net/mlx5: add flex item operations") Signed-off-by: Gregory Etelson Acked-by: Viacheslav O

[PATCH v2] net/mlx5: fix shared RSS destroy failure

2022-03-02 Thread Rongwei Liu
When both shared and non-shared RSS actions are present in single flow rule shared RSS index is unset by mistake. For example: 1. flow indirect_action 0 create action_id 3 ingress action RSS ... 2. set sample_actions 0 mark id 43690 / queue index 0 / end 3. flow create 0 ingress group 107 pattern

Re: [PATCH 1/6] net/hns3: remove duplicate macro definition

2022-03-02 Thread Ferruh Yigit
On 2/28/2022 5:46 PM, Ferruh Yigit wrote: On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: From: Jie Hai This patch fixes duplicate macro definition of HNS3_RSS_CFG_TBL_SIZE. Fixes: 737f30e1c3ab ("net/hns3: support command interface with firmware") Cc: sta...@dpdk.org Signed-off-by: Jie Hai E

Re: [PATCH v2] net/hns3: fix the time waiting for PF reset completion

2022-03-02 Thread Ferruh Yigit
On 3/2/2022 12:35 AM, Min Hu (Connor) wrote: From: Huisong Li On the case that PF and VF need to be reset, after the hardware reset is complete, VF needs wait for 1 second to restore the configuration so that VF does not fail to recover because PF reset isn't complete. But the estimated time is

[PATCH 1/1] common/cnxk: fix static assertion failure

2022-03-02 Thread Vamsi Attunuru
use dynamically allocated memory for storing soft expiry ring base addresses which fixes the static assertion failure, size of this dynamic allocation depends on RTE_MAX_ETHPORTS which varies based on the build config. Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry notification") Si

[Bug 946] async flow rules affects pmd power management

2022-03-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=946 Bug ID: 946 Summary: async flow rules affects pmd power management Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH] net/kni: initialize rte_kni_conf to 0 before using it

2022-03-02 Thread Harold Huang
When kni driver calls eth_kni_start to start device, some fields such as min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu value. This is unexpected and in some time we could not change the kni device mtu

Re: [PATCH 1/1] common/cnxk: fix static assertion failure

2022-03-02 Thread Jerin Jacob
On Wed, Mar 2, 2022 at 5:37 PM Vamsi Attunuru wrote: > > use dynamically allocated memory for storing soft expiry Use > ring base addresses which fixes the static assertion failure, > size of this dynamic allocation depends on RTE_MAX_ETHPORTS as the size of > which varies based on the build c

[PATCH v2 1/1] common/cnxk: fix static assertion failure

2022-03-02 Thread Vamsi Attunuru
Use dynamically allocated memory for storing soft expiry ring base addresses which fixes the static assertion failure, as the size of dynamic allocation depends on RTE_MAX_ETHPORTS which varies based on the build config. Bugzilla ID: 940 Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry

RE: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-03-02 Thread Ori Kam
Hi Lihuisong, > -Original Message- > From: lihuisong (C) > Sent: Wednesday, March 2, 2022 4:10 AM > Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior > > > 在 2022/3/1 0:42, Ferruh Yigit 写道: > > On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: > >> From: Huisong Li >

Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-03-02 Thread Thomas Monjalon
02/03/2022 15:07, Ori Kam: > From: lihuisong (C) > > 在 2022/3/1 0:42, Ferruh Yigit 写道: > > > On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: > > >> From: Huisong Li > > >> > > >> RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be set in > > >> dev_configure phase. However, if this flag i

[DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Thierry Herbelot
Hello, I would like to start testpmd with bnxt ports, when running on an Arm server. This is the log at startup (with testpmd from DPDK v20.11.4): dpdk-devbind.py -b vfio-pci 03:00.0 dpdk-devbind.py -b vfio-pci 03:00.1 dpdk-testpmd -l 1,3,5 --main-lcore 1 EAL: Detected 48 lcore(s) EAL: Detec

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Ajit Khaparde
> > Is this a know issue ? No. We have tried the Broadcom PMD on ARM server(s) and have been able to use it without any issues. But we can try it again and get back to you. > > Thanks > > Thierry Herbelot > > PS: a similar error is seen for the Ethernet ports, when handled by the

[PATCH] event/dlb2: fix invalid shift value

2022-03-02 Thread Timothy McDaniel
Add a check to ensure that all shift counts are valid. Shifting by more than 63 bits may result in undefined behavior, as noted during coverity scan. Fixes: e697f35dbdd1 ("event/dlb2: update rolling mask used for dequeue") Coverity issue: 376527 Signed-off-by: Timothy McDaniel --- drivers/event

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Thierry Herbelot
Hello Ajit Thanks for the quick response. Please keep me posted when you check on your side. Best regards Thierry On 3/2/22 16:08, Ajit Khaparde wrote: Is this a know issue ? No. We have tried the Broadcom PMD on ARM server(s) and have been able to use it without any issues

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread David Marchand
On Wed, Mar 2, 2022 at 3:51 PM Thierry Herbelot wrote: > EAL: Probe PCI driver: net_bnxt (14e4:1750) device: :03:00.0 (socket 0) > bnxt_hwrm_send_message(): Error(timeout) sending msg 0x, seq_id 0 > bnxt_hwrm_ver_get(): failed rc:-110 > ethdev initialisation failed > EAL: Releasing pci map

[PATCH v4] net/mlx5: fix the NIC egress flow mismatch in switchdev mode

2022-03-02 Thread Jiawei Wang
When E-Switch mode was enabled, the NIC egress flows was implicitly appended with source vport to match on. If the metadata register C0 was used to maintain the source vport, it was initialized to zero on packet steering engine entry, the flow could be hit only if source vport was zero, the registe

Re: [PATCH v2 1/3] common/mlx5: add Netlink event helpers

2022-03-02 Thread Ferruh Yigit
On 3/1/2022 12:15 PM, Dmitry Kozlyuk wrote: Introduce mlx5_nl_read_events() to read Netlink events (technically, messages) from a socket that was configured to listen for them via a new mlx5_nl_init() parameter. Add mlx5_nl_parse_link_status_update() helper to extract information from link-relate

RE: [PATCH v2 1/3] common/mlx5: add Netlink event helpers

2022-03-02 Thread Dmitry Kozlyuk
Hi Ferruh, > -Original Message- > From: Ferruh Yigit [...] > Hi Dmitry, > > For clarification, this patch is not fix, but it is requested > to be backported to be able to backport fixes in this patchset, > right? Yes.

Re: MTU and frame size filtering inaccuracy

2022-03-02 Thread Stephen Hemminger
On Wed, 2 Mar 2022 09:53:42 +0100 Morten Brørup wrote: > > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > Sent: Tuesday, 1 March 2022 18.50 > > > > Hi all, > > > > There is a problem in MTU setting in DPDK. > > Yes, and the root cause is the unclear definition of what "MTU" means in

RE: [PATCH] net/mlx5: fix GRE item translation in Verbs API

2022-03-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Monday, February 28, 2022 11:53 AM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; > sta...@dpdk.org; Slava Ovsiienko > Subject: [PATCH] net/mlx5: fix GRE item translation in Verbs API > > GRE item tr

RE: [PATCH] net/mlx5: fix flex item flow handle size

2022-03-02 Thread Raslan Darawsheh
Hi > -Original Message- > From: Gregory Etelson > Sent: Monday, February 28, 2022 12:01 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; > sta...@dpdk.org; Slava Ovsiienko > Subject: [PATCH] net/mlx5: fix flex item flow handle size > > Reduce flex item fl

RE: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6

2022-03-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, February 28, 2022 1:42 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; Jack Min > > Subject: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6 > > On TCP/IP-based layered network, ICMP i

RE: [PATCH v2] common/mlx5: fix missing default devargs initialization

2022-03-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Tuesday, March 1, 2022 1:10 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH v2] common/mlx5: fix missing default devargs initialization > > Device arguments list is provided along with

RE: [PATCH] net/mlx5: fix flex item header length translation

2022-03-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Tuesday, March 1, 2022 2:28 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; > sta...@dpdk.org; Slava Ovsiienko > Subject: [PATCH] net/mlx5: fix flex item header length translation > > Flex item API

RE: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6

2022-03-02 Thread Raslan Darawsheh
> -Original Message- > From: Raslan Darawsheh > Sent: Wednesday, March 2, 2022 6:32 PM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad > Cc: dev@dpdk.org; Jack Min > Subject: RE: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6 > > Hi, > > > -Original Message- > >

RE: [PATCH 1/2] net/mlx5: fix next protocol RSS expansion

2022-03-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Tuesday, March 1, 2022 5:19 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; > sta...@dpdk.org; Slava Ovsiienko > Subject: [PATCH 1/2] net/mlx5: fix next protocol RSS expansion > > RSS expansion sch

RE: MTU and frame size filtering inaccuracy

2022-03-02 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 2 March 2022 17.22 > > On Wed, 2 Mar 2022 09:53:42 +0100 > Morten Brørup wrote: > > > > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > > Sent: Tuesday, 1 March 2022 18.50 > > > > > > Hi all, > > > > > > Ther

Re: [PATCH] app/pdump: close program if --pdump argument is missing

2022-03-02 Thread Stephen Hemminger
On Wed, 2 Mar 2022 14:26:14 +0500 "usman.tanveer" wrote: > --pdump is a mandatory argument in pdump application. > It should print usage and exit if --pdump argument > is missing. The application is not closing and getting > stuck. Made the change to print usage and exit when > this argument is

Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-03-02 Thread Stephen Hemminger
On Wed, 02 Mar 2022 15:46:37 +0100 Thomas Monjalon wrote: > 02/03/2022 15:07, Ori Kam: > > From: lihuisong (C) > > > 在 2022/3/1 0:42, Ferruh Yigit 写道: > > > > On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: > > > >> From: Huisong Li > > > >> > > > >> RSS will not be enabled if the RTE_ETH_MQ

[PATCH v2] net/mlx5: fix MPLS/GRE Verbs spec ordering

2022-03-02 Thread Dariusz Sosnowski
When using Verbs flow engine to create flows, GRE Verbs spec was put at the end of specs list. This created problems for flows matching MPLSoGRE packets. In generated specs list MPLS spec was put before GRE spec, but Verbs API requires that MPLS spec must be put in its exact location in protocol st

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Ajit Khaparde
On Wed, Mar 2, 2022 at 7:13 AM Thierry Herbelot wrote: > > Hello Ajit > > Thanks for the quick response. > > Please keep me posted when you check on your side. Can you tell what is the firmware version on the card? > > Best regards > > Thierry > > On 3/2/22 16:08, Ajit Khaparde wr

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Thierry Herbelot
Hello Ajit The card is not correctly probed by the kernel, and so the FW version is not visible. I see this in the kernel dmesg: bnxt_en :03:00.0 (unnamed net_device) (uninitialized): Error (timeout: 500015) msg {0x0 0x0} len:0 bnxt_en :03:00.0 (unnamed net_device) (uninitialized): Fi

Re: [PATCH] net/txgbe: fix a bit with boolean operator

2022-03-02 Thread Ferruh Yigit
On 3/2/2022 8:02 AM, Jiawen Wu wrote: On March 1, 2022 2:09 PM, Weiguo Li wrote: Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a typo error with "if (A & !B)", and more probably to use "if (A & ~B)" instead. Fixes

[PATCH 0/9] Improve linux drivers GSG section

2022-03-02 Thread Bruce Richardson
This patchset reworks large parts of the linux drivers section of the Linux Getting Started Guide, so as to make it clearer and easier to read. The overall flow of the page is adjusted so that more important information is nearer the top, and so that all information on VFIO is consolidated into a s

[PATCH 1/9] doc/linux_gsg: replace special characters for (R) symbol

2022-03-02 Thread Bruce Richardson
Some IDEs, such as eclipse, complained on save about the use of special characters in the (R) symbol in linux GSG doc. We can replace those with the equivalent "|reg|" text, and including isonum.txt. Signed-off-by: Bruce Richardson --- doc/guides/linux_gsg/enable_func.rst | 16 +---

[PATCH 2/9] doc/linux_gsg: fix missing note on UIO module

2022-03-02 Thread Bruce Richardson
The docs on binding drivers was updated as part of the removal of the igb_uio module from the main DPDK repo. As part of that update, a note about uio_pci_generic requiring legacy interrupts was removed, but should have been kept. Fixes: 56bb5841fd06 ("kernel/linux: remove igb_uio") Cc: tho...@mon

[PATCH 3/9] doc/linux_gsg: make UIO safety warning more visible

2022-03-02 Thread Bruce Richardson
The GSG has a note warning that use of UIO is inherently unsafe due to lack of IOMMU protection. However, this was only flagged as a "NOTE", meaning it could easily be missed. Changing the rst tag from "note" to "warning" and moving it to the top of the UIO subsection makes this a lot more visible

[PATCH 4/9] doc/linux_gsg: move section on binding drivers up the page

2022-03-02 Thread Bruce Richardson
While the details of VFIO and UIO may be of interest to some, most users of the doc are likely primarily interested in how to bind their devices to the kernel driver and then move on to running the app. Therefore, the most important part of the "Linux Drivers" section of the GSG is the subsection o

[PATCH 5/9] doc/linux_gsg: emphasise VFIO over UIO-based modules

2022-03-02 Thread Bruce Richardson
VFIO is to be strongly preferred over uio-based modules, so update our text and examples to only refer to vfio, giving an initial reference at the start to uio as a fallback option. Signed-off-by: Bruce Richardson --- doc/guides/linux_gsg/linux_drivers.rst | 47 +++--- 1 file

[PATCH 6/9] doc/linux_gsg: split VFIO section into subsections

2022-03-02 Thread Bruce Richardson
The VFIO section of the page about linux drivers was rather long and unstructured. This can be improved by splitting it up into subsections, to cover the specifics of memory limits and creating VFs. When moving the various text notes into the relevant subsections, we can drop the note about kernels

[PATCH 7/9] doc/linux_gsg: move UIO section to the end

2022-03-02 Thread Bruce Richardson
To further de-emphasise UIO over the alternatives, we can move the UIO section of the drivers page to the end of the document, giving more prominence to VFIO and bifurcated drivers. Signed-off-by: Bruce Richardson --- doc/guides/linux_gsg/linux_drivers.rst | 104 - 1 file

[PATCH 8/9] doc/linux_gsg: consolidate all VFIO content

2022-03-02 Thread Bruce Richardson
Rather than having separate sections for VFIO and VFIO no-iommu mode, as well as a separate section further down the document on troubleshooting VFIO, we can consolidate all these as subsections into a primary VFIO section. This section starts with the basics of VFIO use, then covers no-iommu mode,

[PATCH 9/9] doc/linux_gsg: change informational warnings to notes

2022-03-02 Thread Bruce Richardson
There are two warnings in the VFIO section about limitations of VFIO and limitations on who can bind/unbind devices. Since these don't actually describe any unsafe conditions, and are more informational, we can change these to notes. This also helps emphasise the other warnings in the documents whi

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Ajit Khaparde
On Wed, Mar 2, 2022 at 9:16 AM Thierry Herbelot wrote: > > Hello Ajit > > The card is not correctly probed by the kernel, and so the FW version is > not visible. Thanks Thierry. I thought it was just the PMD running into trouble. Can you give details of the ARM server? Make, Vendor, etc..? > >

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Thierry Herbelot
On 3/2/22 18:26, Ajit Khaparde wrote: On Wed, Mar 2, 2022 at 9:16 AM Thierry Herbelot wrote: Hello Ajit The card is not correctly probed by the kernel, and so the FW version is not visible. Thanks Thierry. I thought it was just the PMD running into trouble. Can you give details of the ARM s

Re: [PATCH] net/txgbe: fix a bit with boolean operator

2022-03-02 Thread Ferruh Yigit
On 3/2/2022 8:02 AM, Jiawen Wu wrote: On March 1, 2022 2:09 PM, Weiguo Li wrote: Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a typo error with "if (A & !B)", and more probably to use "if (A & ~B)" instead. Fixes

Re: MTU and frame size filtering inaccuracy

2022-03-02 Thread Stephen Hemminger
On Wed, 2 Mar 2022 17:50:13 +0100 Morten Brørup wrote: > Again, Postel's Law makes perfect sense on a server. > > On a network appliance, I would prefer discarding oversize packets at > ingress, rather than process them and discard them at egress. > > I do admit that my viewpoint is quite acad

Re: [PATCH] net/kni: initialize rte_kni_conf to 0 before using it

2022-03-02 Thread Ferruh Yigit
On 3/2/2022 12:33 PM, Harold Huang wrote: When kni driver calls eth_kni_start to start device, some fields such as min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu value. This is unexpected and in some

[PATCH] net/mlx5: fix E-Switch disabling when DV flow disable

2022-03-02 Thread Michael Baum
E-Switch DV flow is supported only when DV flow is supported and enabled. The mlx5_shared_dev_ctx_args_config() function ensures that when the environment does not support DV, the "dv_esw_en" flag is turned off. However, when the environment is supportive but the user has requested to disable it,

[PATCH v2] net/ark: support multi-port pkt generation

2022-03-02 Thread John Miller
Added support for packet generation in multi-port Arkville implementations. The packet generator is a singleton within the device but is capable of generating packets for any port within one device. Signed-off-by: John Miller --- v2: - Incorporated changes from Ferruh's comments. --- drivers/ne

mlx5_pci Decompression Error

2022-03-02 Thread Shafiqul Abedin
Hi, I am new to dpdk development in general and have been trying some development on Nvidia BF2 but ran into some problems. I am using Compress device: mlx5_pci to do compression/decompression and it appears that compression is fine but when I try to decompress, I get the following error: mlx5

[PATCH v1] net/i40e: remove redundant number of packets check

2022-03-02 Thread Feifei Wang
For i40e_xmit_pkts_vec_xx function, it checks nb_pkts to ensure nb_pkts does not cross rs_thresh. However, in i40e_xmit_fixed_burst_vec_xx function, this check will be performed again. To improve code, delete this redundant check. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Re

Re: [PATCH] net/kni: initialize rte_kni_conf to 0 before using it

2022-03-02 Thread Harold Huang
On Thu, Mar 3, 2022 at 2:16 AM Ferruh Yigit wrote: > > On 3/2/2022 12:33 PM, Harold Huang wrote: > > When kni driver calls eth_kni_start to start device, some fields such as > > min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause > > kni_ioctl_create create a kni netdevice with

[PATCH] net/kni: initialize rte_kni_conf to 0 before using it

2022-03-02 Thread Harold Huang
When kni driver calls eth_kni_start to start device, some fields such as min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu value. This is unexpected and sometimes we could not change the kni device mtu wi

RE: [PATCH v1] net/i40e: remove redundant number of packets check

2022-03-02 Thread Zhang, Qi Z
> -Original Message- > From: Feifei Wang > Sent: Thursday, March 3, 2022 9:54 AM > To: Xing, Beilei ; David Christensen > ; Richardson, Bruce ; > Ananyev, Konstantin ; Ruifeng Wang > > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang ; > Honnappa Nagarahalli > Subject: [PATCH v1] net/i40e:

RE: release candidate 22.03-rc2

2022-03-02 Thread Jiang, YuX
> -Original Message- > From: Jiang, YuX > Sent: Tuesday, March 1, 2022 6:57 PM > To: Thomas Monjalon ; dev (dev@dpdk.org) > > Cc: Devlin, Michelle ; Mcnamara, John > ; Yigit, Ferruh ; Sun, > QingX > Subject: RE: release candidate 22.03-rc2 > > > -Original Message- > > From: Thom

Re: [PATCH v2 1/1] common/cnxk: fix static assertion failure

2022-03-02 Thread Jerin Jacob
On Wed, Mar 2, 2022 at 7:18 PM Vamsi Attunuru wrote: > > Use dynamically allocated memory for storing soft expiry > ring base addresses which fixes the static assertion failure, > as the size of dynamic allocation depends on RTE_MAX_ETHPORTS > which varies based on the build config. > > Bugzilla I

[RFC] ethdev: introduce protocol type based header split

2022-03-02 Thread xuan . ding
From: Xuan Ding Header split consists of splitting a received packet into two separate regions based on the packet content. Splitting is usually between the packet header that can be posted to a dedicated buffer and the packet payload that can be posted to a different buffer. This kind of splitti

RE: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments

2022-03-02 Thread Zhang, Yuying
LGTM. > > -Original Message- > > From: Liu, KevinX > > Sent: Wednesday, December 29, 2021 5:37 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhang, Qi Z > > ; Yang, SteveX ; Yigit, > > Ferruh ; Liu, KevinX ; > > sta...@dpdk.org > > Subject: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum

[RFC 0/2] net/ice: support header split in Rx data path

2022-03-02 Thread xuan . ding
From: Xuan Ding Header split is useful in some scenarios, such as GPU acceleration. The spliting will help to enable true zero copy and hence improve the performance significantly. This patchset enables header split in normal Rx data paths. When Rx queue is configured with header split feature w

[RFC 1/2] app/testpmd: add header split configuration

2022-03-02 Thread xuan . ding
From: Xuan Ding This patch adds header split configuration in testpmd. The header split feature is off by default. To enable header split, you need: 1. Configure Rx queue with rx_offload header split on. 2. Set the protocol type of header split. Command for set header split protocol type: testpm

[RFC 2/2] net/ice: support header split in Rx data path

2022-03-02 Thread xuan . ding
From: Xuan Ding This patch adds support for header split in normal Rx data paths. When Rx queue is configured with header split feature, packets received will be directly splited into header and payload parts. And the two parts will be put into different mempools. Currently, the vectorized path

RE: [PATCH] examples/vdpa: fix disabled VirtQ statistics query

2022-03-02 Thread Xia, Chenbo
Hi Xueming, > -Original Message- > From: Xueming Li > Sent: Thursday, February 24, 2022 9:24 PM > To: dev@dpdk.org > Cc: xuemi...@nvidia.com; sta...@dpdk.org; Maxime Coquelin > ; Xia, Chenbo ; Matan Azrad > > Subject: [PATCH] examples/vdpa: fix disabled VirtQ statistics query > > Quit V

[Bug 940] [dpdk 22.03-rc2] drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_nix_inl_dev.c.o: meson build failed with -Dmax_ethports=1024 parameter

2022-03-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=940 Jerin (jerinjac...@gmail.com) changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRM

RE: [PATCH v1] net/vhost: clear data of packet mbuf after sending pkts

2022-03-02 Thread Xia, Chenbo
> -Original Message- > From: Zhang, Yuying > Sent: Wednesday, March 2, 2022 4:59 PM > To: David Marchand > Cc: dev ; Maxime Coquelin ; Xia, > Chenbo ; dpdk stable ; > step...@networkplumber.org > Subject: RE: [PATCH v1] net/vhost: clear data of packet mbuf after sending > pkts > > Hi Mar

Re: [PATCH 1/2] event/cnxk: fix incorrect mask length

2022-03-02 Thread Jerin Jacob
On Wed, Mar 2, 2022 at 4:23 AM wrote: > > From: Pavan Nikhilesh > > Fix incorrect mask used when clearing subevent type masking out > useful data. > > Fixes: e239e0d3faf7 ("event/cnxk: add SSO HW device operations") > > Signed-off-by: Pavan Nikhilesh Series applied to dpdk-next-net-eventdev/for

[PATCH 1/2] common/cnxk: revert check on bitmap for tm

2022-03-02 Thread Nithin Dabilpuram
Revert change to return error on case where no slab of free resources is found. That error check break's a case where there is a spare schq to be reused that was just allocated for sake of contiguous static TM nodes. Fixes: 14f7e5d4bf2d ("common/cnxk: add missing checks of return values") Cc: gmut

[PATCH 2/2] common/cnxk: fix VF data offset

2022-03-02 Thread Nithin Dabilpuram
From: Harman Kalra Data offset should be adjusted for VF to skip extra 8 bytes of timestamp, if its PF has PTP enabled. Fixes: c443e0d326e1 ("common/cnxk: support NIX PTP") Cc: sk...@marvell.com Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_nix.h | 1 + drivers/common/cnxk/roc_n

Re: [PATCH 16/20] net/sfc: fix a memory leak in error handling

2022-03-02 Thread Andrew Rybchenko
On 2/22/22 21:18, Weiguo Li wrote: When efx_nic_get_board_info() failed then function return, the memory in 'id' is not released, this leads to a memory leak. Fixes: e86b48aa46d4 ("net/sfc: add HW switch ID helpers") Signed-off-by: Weiguo Li Reviewed-by: Andrew Rybchenko