[PATCH v2] doc: add steps to configure VF interface as trusted

2022-02-28 Thread Asaf Penso
Trusted VF is needed to offload rules with rte_flow to a group that is bigger than 0. The configuration is done in two parts: driver and FW. This patch adds the needed steps to configure a VF to be trusted. Signed-off-by: Asaf Penso Reviewed-by: Raslan Darawsheh --- v3: cleanup the patches v2:

[PATCH v3] doc: add steps to configure VF interface as trusted

2022-02-28 Thread Asaf Penso
Trusted VF is needed to offload rules with rte_flow to a group that is bigger than 0. The configuration is done in two parts: driver and FW. This patch adds the needed steps to configure a VF to be trusted. Signed-off-by: Asaf Penso Reviewed-by: Raslan Darawsheh --- v3: cleanup the patches v2:

RE: [PATCH 1/1] doc: add steps to configure VF interface as trusted

2022-02-28 Thread Asaf Penso
Thank you for the comment, Stephen. I also saw you update the tool, which is why I didn't see the missing line. I uploaded v3: http://patches.dpdk.org/project/dpdk/patch/20220228081117.3013452-1-as...@nvidia.com/ Regards, Asaf Penso >-Original Message- >From: Stephen Hemminger >Sent: Su

[PATCH] net/tap: do not include l2 header in gso size when compared with mtu

2022-02-28 Thread Harold Huang
The gso size is calculated with all of the headers and payload. As a result, the l2 header should not be included when comparing gso size with mtu. Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") Cc: sta...@dpdk.org Signed-off-by: Harold Huang --- drivers/net/tap/rte_eth_tap.c

[Bug 939] [dpdk 22.03-rc2] drivers/net/cnxk/cnxk_ethdev_mtr meson build failed with cflag parm optimization=1 on Ubuntu20.04 with GCC10.3

2022-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=939 Bug ID: 939 Summary: [dpdk 22.03-rc2] drivers/net/cnxk/cnxk_ethdev_mtr meson build failed with cflag parm optimization=1 on Ubuntu20.04 with GCC10.3 Product: DPDK Version

Re: [PATCH] app/testpmd: add help messages for multi-process

2022-02-28 Thread Thomas Monjalon
28/02/2022 04:26, Min Hu (Connor): > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -210,6 +210,8 @@ usage(char* progname) > printf(" --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n" > "0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"

Re: [PATCH v3 4/8] lib: document existing free functions

2022-02-28 Thread Bruce Richardson
On Sun, Feb 27, 2022 at 09:48:57PM +0100, Thomas Monjalon wrote: > 20/02/2022 19:21, Stephen Hemminger: > > + * If NULL then, the function does nothing. > > I'm not English native, but I thought it should be one of these 2 forms: > - If NULL, the function does nothing. > - If NULL th

Re: [PATCH] ci: remove redundant drivers enabling

2022-02-28 Thread Bruce Richardson
On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote: > No need to explicitly enable drivers bus/vdev and mempool/ring. > > bus/vdev is always enabled since > commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds") > > mempool/ring is always enabled since > commit 81c2337e

[PATCH] net/mlx5: fix GRE item translation in Verbs API

2022-02-28 Thread Gregory Etelson
GRE item translation must set inner protocol value. For that reason the item is not translated inplace when PMD translation iterates over flow items, but moved after the loop, when all inner types are discovered. If PMD does not translate GRE flow item inside the translation loop it must save the

[PATCH v1] net/iavf: fix function pointer in multi-process

2022-02-28 Thread Steve Yang
This patch uses the index value to call the function, instead of the function pointer assignment to save the selection of Receive Flex Descriptor profile ID. Otherwise the secondary process will run with wrong function address from primary process. Fixes: 12b435bf8f2f ("net/iavf: support flex des

[PATCH v4] app/pdump: check lcore is not the maximum core

2022-02-28 Thread Reshma Pattan
Check lcore id value is not the maximum core supported. Using lcore id without this check might cause out of bound access inside the rte_eal_wait_lcore. Coverity issue: 375841 Fixes: b2854d5317e8 ("app/pdump: support multi-core capture") Cc: vipin.vargh...@intel.com Cc: sta...@dpdk.org Signed-off

[PATCH] net/mlx5: fix flex item flow handle size

2022-02-28 Thread Gregory Etelson
Reduce flex item flow handle size from 32 bits to 8 bits for each flow. The patch will save memory in setups with millions of flows. Cc: sta...@dpdk.org Fixes: a23e9b6e3ee9 ("net/mlx5: handle flex item in flows") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx

[Bug 940] [dpdk 22.03-rc2] drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_nix_inl_dev.c.o: meson build failed with -Dmax_ethports=1024 parameter

2022-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=940 Bug ID: 940 Summary: [dpdk 22.03-rc2] drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_nix _inl_dev.c.o: meson build failed with -Dmax_ethports=1024 parameter P

Re: [PATCH] ci: remove redundant drivers enabling

2022-02-28 Thread David Marchand
On Mon, Feb 28, 2022 at 10:46 AM Bruce Richardson wrote: > > On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote: > > No need to explicitly enable drivers bus/vdev and mempool/ring. > > > > bus/vdev is always enabled since > > commit 2e33309ebe03 ("config: enable/disable drivers in Arm

Re: [PATCH] ci: remove redundant drivers enabling

2022-02-28 Thread Bruce Richardson
On Mon, Feb 28, 2022 at 11:17:07AM +0100, David Marchand wrote: > On Mon, Feb 28, 2022 at 10:46 AM Bruce Richardson > wrote: > > > > On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote: > > > No need to explicitly enable drivers bus/vdev and mempool/ring. > > > > > > bus/vdev is always

[PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6

2022-02-28 Thread Bing Zhao
On TCP/IP-based layered network, ICMP is considered and implemented as part of layer 3 IP protocol. Actually, it is a user of the IP protocol and must be encapsulated within IP packets. There is no layer 4 protocol over ICMP. The rule with layer 4 should be matched prior to the rule only with laye

Re:RE: [PATCH v3] ip_frag: add IPv4 options fragment and test data

2022-02-28 Thread Huichao Cai
Hi Konstantin, > These macros are dups for what we have in rte_ipv4_fragmentation.c > Would probably make sense to name them RTE_IPV4_IPOPT_... and put them > in some public .h to avoid duplication. I named them RTE_IPV4_IPOPT_xxx and put them in "rte_ip_frag.h". > Could you clarify what this ma

Re: [PATCH] net/ark: support multi-port pkt generation

2022-02-28 Thread Ferruh Yigit
On 2/26/2022 12:44 PM, John Miller wrote: Added support for packet generation in multi-port Arkville implementations. The packet generator is a singleton within the device but is capable of generating packets for any port within one device. Signed-off-by: John Miller --- drivers/net/ark/ark_e

[PATCH v2] net/iavf: add NAT-T / UDP encapsulation support

2022-02-28 Thread Radu Nicolau
Add support for NAT-T / UDP encapsulated ESP. This fixes the inline crypto feature for iAVF which will not function properly without setting the UDP encapsulation options. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/c

[PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs

2022-02-28 Thread Jeff Daly
From: Stephen Douthit Currently all X500EM* MAC types fallthrough to the default case and get reported as non-SFP regardless of media type, which isn't correct. Fixes: 0790adeb567 ("ixgbe/base: support X550em_a device") Cc: sta...@dpdk.org Signed-off-by: Stephen Douthit Signed-off-by: Jeff Dal

[PATCH v4 0/3] ixgbe SFP handling fixes

2022-02-28 Thread Jeff Daly
Hello all, We have several platforms based on Intel's C3000 series of SoCs that have integrated ixgbe devices (X550EM) operating in the "Native SFI" mode (the 0x15c4 device ID). This set of patches address issues with detection and hotplug of SPFs. This is the first of a series of patches to ref

[PATCH v4 2/3] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices

2022-02-28 Thread Jeff Daly
1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to the SFP cage on these cards) is not asserted to avoid incorrectly reporting link up when the SFP's laser is turned off. ff8162cb957 limited this workaround to fiber ports This patch: * Adds additional check for 82599 type, not al

[PATCH v4 3/3] net/ixgbe: Fix SFP detection and linking on hotplug

2022-02-28 Thread Jeff Daly
Currently the ixgbe driver does not ID any SFP except for the first one plugged in. This can lead to no-link, or incorrect speed conditions. For example: * If link is initially established with a 1G SFP, and later a 1G/10G multispeed part is later installed, then the MAC link setup functions are

[patch] allow using standard ar from the build ini files instead of 'ar' string

2022-02-28 Thread aisha
Hi, I've attached a patch, from Gentoo, which uses the *ar* binary passed to meson when available, instead of 'ar', which may not be available, for instance when cross compiling, or having multiple gcc versions present, like in Gentoo. This should not have any regressions, as when the binary

RE: [PATCH] net/mlx5: fix destroying empty matchers list

2022-02-28 Thread Idan Hackmon
> -Original Message- > From: Adham Masarwah > Sent: Sunday, February 27, 2022 2:33 PM > To: Idan Hackmon > Subject: RE: [PATCH] net/mlx5: fix destroying empty matchers list > > > Subject: [PATCH] net/mlx5: fix destroying empty matchers list > > > > The table remove callback function i

[PATCH] crypto/qat: fix structurally dead code

2022-02-28 Thread Arek Kusztal
This patch fixes structurally dead code in QAT asym pmd. Coverity issue: 376563 Fixes: ef2f4238a04d ("crypto/qat: refactor asymmetric session") Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_asym.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/qat/qat_asym.c b/driver

Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-02-28 Thread Ferruh Yigit
On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: From: Huisong Li RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be set in dev_configure phase. However, if this flag isn't set, RSS can be enabled through the ethdev ops and rte_flow API. This behavior is contrary to each other. Fixes:

Re: [patch] allow using standard ar from the build ini files instead of 'ar' string

2022-02-28 Thread Stephen Hemminger
On Mon, 28 Feb 2022 10:54:28 -0500 aisha wrote: > Hi, > > I've attached a patch, from Gentoo, which uses the *ar* binary passed to > meson when available, instead of 'ar', which may not be available, for > instance when cross compiling, or having multiple gcc versions present, > like in Gento

Re: [PATCH v3 4/8] lib: document existing free functions

2022-02-28 Thread Stephen Hemminger
On Mon, 28 Feb 2022 09:42:47 + Bruce Richardson wrote: > On Sun, Feb 27, 2022 at 09:48:57PM +0100, Thomas Monjalon wrote: > > 20/02/2022 19:21, Stephen Hemminger: > > > + * If NULL then, the function does nothing. > > > > I'm not English native, but I thought it should be one of these

Re: [PATCH v4] app/pdump: check lcore is not the maximum core

2022-02-28 Thread Stephen Hemminger
On Mon, 28 Feb 2022 09:58:56 + Reshma Pattan wrote: > Check lcore id value is not the maximum core supported. > Using lcore id without this check might cause > out of bound access inside the rte_eal_wait_lcore. > > Coverity issue: 375841 > Fixes: b2854d5317e8 ("app/pdump: support multi-core

Re: [PATCH 4/6] net/hns3: fix the time waiting for PF reset completion

2022-02-28 Thread Ferruh Yigit
On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: @@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns) return 0; wait_data->check_completion = NULL; - wait_data->interval = 1 * MSEC_PER_SEC * USEC_PER_MSEC; + wait_data

Re: [patch] allow using standard ar from the build ini files instead of 'ar' string

2022-02-28 Thread Bruce Richardson
On Mon, Feb 28, 2022 at 10:54:28AM -0500, aisha wrote: > Hi, > > I've attached a patch, from Gentoo, which uses the *ar* binary passed to > meson when available, instead of 'ar', which may not be available, for > instance when cross compiling, or having multiple gcc versions present, like > in Gen

[dpdk-dev] crypto/qat: fix process type handling

2022-02-28 Thread Kai Ji
This patch fix the process type handling in QAT PMDs where only primary and secondary process are supported in qat build request Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 3 +++ drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 3 +++ drivers/crypto/qat/dev/qat_sym_pm

Re: [PATCH 1/6] net/hns3: remove duplicate macro definition

2022-02-28 Thread Ferruh Yigit
On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: From: Jie Hai This patch fixes duplicate macro definition of HNS3_RSS_CFG_TBL_SIZE. Fixes: 737f30e1c3ab ("net/hns3: support command interface with firmware") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Except from 2/6, 3/6, 4/6 Series applied to

Re: [patch] allow using standard ar from the build ini files instead of 'ar' string

2022-02-28 Thread Bruce Richardson
On Mon, Feb 28, 2022 at 10:54:28AM -0500, aisha wrote: > Hi, > > I've attached a patch, from Gentoo, which uses the *ar* binary passed to > meson when available, instead of 'ar', which may not be available, for > instance when cross compiling, or having multiple gcc versions present, like > in Gen

Re: [PATCH] build: try to get kernel version from kernel source

2022-02-28 Thread Bruce Richardson
On Sat, Feb 26, 2022 at 10:40:45PM +0100, Ferdinand Thiessen wrote: > When building the kernel modules, try to get the kernel > version from the kernel sources first. This fixes the > kernel modules installation directory if the target kernel > version differs from the host kernel version, like for

RE: [PATCH v3 1/2] examples/l3fwd: use single set of variables throughout the code

2022-02-28 Thread Han, YingyaX
-Original Message- From: Honnappa Nagarahalli Sent: Wednesday, February 23, 2022 2:10 PM To: dev@dpdk.org; honnappa.nagaraha...@arm.com; Tu, Lijuan ; juraj.lin...@pantheon.tech; ohily...@iol.unh.edu; david.march...@redhat.com; tho...@monjalon.net; jer...@marvell.com; Richardson, Bru

[PATCH] app/testpmd: fix issue with memory leaks when quit testpmd

2022-02-28 Thread Ke Zhang
when dpdk is compiled in ASan, there is a memory leaks after quit testpmd if set mcast_addr, this patch fix this issue. Error info as following: ERROR: LeakSanitizer: detected memory leaksDirect leak of 192 byte(s) 0 0x7f6a2e0aeffe in __interceptor_realloc (/lib/x86_64-linux-gnu/lib

RE: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs

2022-02-28 Thread Wang, Haiyue
> -Original Message- > From: Jeff Daly > Sent: Monday, February 28, 2022 23:30 > To: dev@dpdk.org > Cc: Stephen Douthit ; sta...@dpdk.org; Wang, Haiyue > ; > Lu, Wenzhuo > Subject: [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result > for X550EM_a devs > > From: Stephen

[PATCH v3] sched: remove useless malloc in pie data init

2022-02-28 Thread Weiguo Li
'rte_pie_rt_data_init(NULL)' is not expected, and it's ought to fail when this happen. The malloc inside the function didn't work. So remove the malloc otherwise will lead to a memory leak. Fixes: 44c730b0e37971 ("sched: add PIE based congestion management") Signed-off-by: Weiguo Li --- v3: * fi

[PATCH] net/txgbe: fix a bit with boolean operator

2022-02-28 Thread Weiguo Li
Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a typo error with "if (A & !B)", and more probably to use "if (A & ~B)" instead. Fixes: c1d4e9d37abdc6 ("net/txgbe: add queue stats mapping") Signed-off-by: Weiguo Li ---

[Bug 941] [dpdk-22.03] core dump when create fdir rule with bad arguments

2022-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=941 Bug ID: 941 Summary: [dpdk-22.03] core dump when create fdir rule with bad arguments Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: U

[Bug 942] i40e: condition in `i40e_flow_parse_fdir_pattern()` is always false

2022-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=942 Bug ID: 942 Summary: i40e: condition in `i40e_flow_parse_fdir_pattern()` is always false Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCON

[PATCH v1] net/vhost: clear data of packet mbuf after sending pkts

2022-02-28 Thread Yuying Zhang
The PMD frees a packet mbuf back into its original mempool after sending a packet. However, old data is not cleaned up which causes error in payload of new packets. This patch clear data of packet mbuf before freeing mbuf. Fixes: ee584e9710b9 ("vhost: add driver on top of the library") Cc: sta...@