Thank you for the comment, Stephen. I also saw you update the tool, which is why I didn't see the missing line. I uploaded v3: http://patches.dpdk.org/project/dpdk/patch/20220228081117.3013452-1-as...@nvidia.com/
Regards, Asaf Penso >-----Original Message----- >From: Stephen Hemminger <step...@networkplumber.org> >Sent: Sunday, February 27, 2022 8:25 PM >To: NBU-Contact-Thomas Monjalon (EXTERNAL) <tho...@monjalon.net> >Cc: Asaf Penso <as...@nvidia.com>; dev@dpdk.org; Slava Ovsiienko ><viachesl...@nvidia.com>; Matan Azrad <ma...@nvidia.com>; Raslan >Darawsheh <rasl...@nvidia.com>; Michael Baum <michae...@nvidia.com> >Subject: Re: [PATCH 1/1] doc: add steps to configure VF interface as trusted > >On Sun, 27 Feb 2022 18:24:42 +0100 >Thomas Monjalon <tho...@monjalon.net> wrote: > >> 27/02/2022 17:44, Stephen Hemminger: >> > On Sun, 27 Feb 2022 17:46:17 +0200 >> > Asaf Penso <as...@nvidia.com> wrote: >> > >> > > +#. For each VF PCIe, using the following command to bind the driver:: >> > > + >> > > + $ echo "0000:82:00.2" >> /sys/bus/pci/drivers/mlx5_core/bind >> > > \ No newline at end of file >> > >> > Please change your editor and/or git settings so there is a new line >> > at the end of all text files. >> >> Isn't it a problem with Eclipse editor? > >It is a configuration option in almost all editors: > >Eclipse: >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww >.newt.com%2Fjava%2Feclipse%2F&data=04%7C01%7Casafp%40nvidia.co >m%7Cbd5c204df1c9488605ae08d9fa1e6adf%7C43083d15727340c1b7db39efd9 >ccc17a%7C0%7C0%7C637815831547239436%7CUnknown%7CTWFpbGZsb3d8e >yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D >%7C2000&sdata=sutVpcYtoUmUX2TJmK8bWqTss4kefKYcu%2BLYTt%2B% >2FrDk%3D&reserved=0 > >Customize code formatting >Go to Windows > Preferences > Java > Code Style > Code Formatter and click >on the Edit button. > >Check New Lines > Insert new line at end of file > >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fthou >ghtbot.com%2Fblog%2Fno-newline-at-end-of- >file&data=04%7C01%7Casafp%40nvidia.com%7Cbd5c204df1c9488605ae0 >8d9fa1e6adf%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63781583 >1547239436%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj >oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=dJuXju04 >tJauNDNRmj%2BXwcXykJQq2MgRbLNNtSaMgM4%3D&reserved=0 > >Following the rules in your editor >You can make sure you follow this rule easily: > >For Vim users, you're all set out of the box! Just don't change your eol >setting. >For Emacs users, add (setq require-final-newline t) to your .emacs or >.emacs.d/init.el file. >For Android Studio, RubyMine, PyCharm, and other IntelliJ, set "Ensure line >feed at file end on Save" under "Editor." >For Atom, you're also all set out of the box. Keep that via the Whitespace >plugin. >For VS Code, set "files.insertFinalNewline": true. >For Sublime, set the ensure_newline_at_eof_on_save option to true. >For TextMate, you can install the Avian Missing Bundle and add >TM_STRIP_WHITESPACE_ON_SAVE = true to your .tm_properties file.
