Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread David Marchand
On Wed, Feb 16, 2022 at 3:27 AM Zhang, RobinX wrote: > The idea behind this is to monitor the quality of the link in the field > during testpmd operations. > It is supported in Linux driver with ethtool command "ethtool -m xxx", but > missing in DPDK. > > This feature is requested by customer 6W

RE: [PATCH] eal/linux: fix fail to stop device monitor error

2022-02-16 Thread Long Li
> Subject: [PATCH] eal/linux: fix fail to stop device monitor error > > [You don't often get email from wenxuanx...@intel.com. Learn why this is > important at http://aka.ms/LearnAboutSenderIdentification.] > > From: Wenxuan Wu > > The ret value stands for whether the device monitor has been su

RE: [External] : Re:

2022-02-16 Thread Long Li
> Subject: Re: [External] : Re: > > On Fri, Feb 11, 2022, at 10:37, Madhuker Mythri wrote: > > Hi Gaetan and Ferruh, > > > >> > >>-Original Message- > >>From: Gaëtan Rivet > >>Sent: 10 फरवरी 2022 21:39 > >>To: Ferruh Yigit ; Madhuker Mythri > >> > >>Cc: dev@dpdk.org > >>Subject: [Externa

Re: [PATCH v5] app/eventdev: add crypto producer mode

2022-02-16 Thread Jerin Jacob
On Wed, Feb 16, 2022 at 1:19 PM Gujjar, Abhinandan S wrote: > > Hi Shijith, > > > -Original Message- > > From: Shijith Thotton > > Sent: Wednesday, February 16, 2022 12:39 PM > > To: Gujjar, Abhinandan S > > Cc: Jerin Jacob Kollanukkaran ; dev@dpdk.org > > Subject: RE: [PATCH v5] app/eve

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread Thomas Monjalon
16/02/2022 09:03, David Marchand: > On Wed, Feb 16, 2022 at 3:27 AM Zhang, RobinX wrote: > > The idea behind this is to monitor the quality of the link in the field > > during testpmd operations. > > It is supported in Linux driver with ethtool command "ethtool -m xxx", but > > missing in DPDK.

Re: [PATCH v5] app/eventdev: add crypto producer mode

2022-02-16 Thread Jerin Jacob
+ @Van Haaren, Harry On Wed, Feb 16, 2022 at 2:14 PM Jerin Jacob wrote: > > On Wed, Feb 16, 2022 at 1:19 PM Gujjar, Abhinandan S > wrote: > > > > Hi Shijith, > > > > > -Original Message- > > > From: Shijith Thotton > > > Sent: Wednesday, February 16, 2022 12:39 PM > > > To: Gujjar, Abhi

RE: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 16 February 2022 00.01 > > Yet another case of applying Linux kernel best practices > to DPDK. Flexible arrays are supported by Clang, GCC and > Microsoft compilers (part of C99). > > Stephen Hemminger (2): > devto

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread Bruce Richardson
On Wed, Feb 16, 2022 at 09:45:33AM +0100, Thomas Monjalon wrote: > 16/02/2022 09:03, David Marchand: > > On Wed, Feb 16, 2022 at 3:27 AM Zhang, RobinX > > wrote: > > > The idea behind this is to monitor the quality of the link in the field > > > during testpmd operations. > > > It is supported i

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Bruce Richardson
On Tue, Feb 15, 2022 at 03:00:56PM -0800, Stephen Hemminger wrote: > Yet another case of applying Linux kernel best practices > to DPDK. Flexible arrays are supported by Clang, GCC and > Microsoft compilers (part of C99). > Do we need to start explicitly stating that DPDK uses C99 features, and add

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread David Marchand
On Wed, Feb 16, 2022 at 10:31 AM Bruce Richardson wrote: > > > I see that we have other telemetry callbacks for stats, link status > > > which might already have the issue. > > > > You mean there is no lock protection? > > Neither in the API, nor in telemetry? > > > For reporting out stats or link

Re: [PATCH] eal/linux: fix fail to stop device monitor error

2022-02-16 Thread David Marchand
On Wed, Feb 16, 2022 at 9:10 AM Long Li wrote: > > > Subject: [PATCH] eal/linux: fix fail to stop device monitor error > > > > [You don't often get email from wenxuanx...@intel.com. Learn why this is > > important at http://aka.ms/LearnAboutSenderIdentification.] > > > > From: Wenxuan Wu > > > >

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread Bruce Richardson
On Wed, Feb 16, 2022 at 10:41:43AM +0100, David Marchand wrote: > On Wed, Feb 16, 2022 at 10:31 AM Bruce Richardson > wrote: > > > > I see that we have other telemetry callbacks for stats, link status > > > > which might already have the issue. > > > > > > You mean there is no lock protection? Ne

RE: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 16 February 2022 10.33 > > On Tue, Feb 15, 2022 at 03:00:56PM -0800, Stephen Hemminger wrote: > > Yet another case of applying Linux kernel best practices > > to DPDK. Flexible arrays are supported by Clang, GCC and >

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Bruce Richardson
On Wed, Feb 16, 2022 at 11:05:09AM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Wednesday, 16 February 2022 10.33 > > > > On Tue, Feb 15, 2022 at 03:00:56PM -0800, Stephen Hemminger wrote: > > > Yet another case of applying Linux kernel best

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-16 Thread David Marchand
On Wed, Feb 16, 2022 at 11:02 AM Bruce Richardson wrote: > On Wed, Feb 16, 2022 at 10:41:43AM +0100, David Marchand wrote: > > On Wed, Feb 16, 2022 at 10:31 AM Bruce Richardson > > wrote: > > > > > I see that we have other telemetry callbacks for stats, link status > > > > > which might already h

Re: [PATCH v3 1/7] net/ark: add device capabilities record

2022-02-16 Thread Ferruh Yigit
On 2/15/2022 10:19 PM, John Miller wrote: Add a device capabilities record for supported features. Certain variants require that PCIe read-requests be correctly throttled. This is called "rqpacing" in Arkville, and has to do with credit and flow control on certain Arkville implementations. Signe

Re: [PATCH 1/3] ethdev: fix missing cast for C++ compatibility

2022-02-16 Thread Ferruh Yigit
On 2/15/2022 5:30 PM, Bruce Richardson wrote: C++ does not allow implicit conversion to/from void*, so we need an explicit cast to allow the driver sdk header to be included from C++ code. I remember patches removing explicit "void *" cast, in the past, to document, is the rule as following:

RE: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Morten Brørup
My answer is at the end.Sent from a smartphone. Please pardon brevity and spelling. Oprindelig besked Fra: Bruce Richardson Dato: 16/02/2022 11.15 (GMT+01:00) Til: Morten Brørup Cc: Stephen Hemminger , dev@dpdk.org Emne: Re: [RFC 0/2] Eliminate zero length arrays in DPDK O

Re: [PATCH 1/3] ethdev: fix missing cast for C++ compatibility

2022-02-16 Thread Bruce Richardson
On Wed, Feb 16, 2022 at 10:32:43AM +, Ferruh Yigit wrote: > On 2/15/2022 5:30 PM, Bruce Richardson wrote: > > C++ does not allow implicit conversion to/from void*, so we need an > > explicit cast to allow the driver sdk header to be included from C++ > > code. > > > > I remember patches remov

RE: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-16 Thread Loftus, Ciara
> Subject: RE: [PATCH v4] net/af_xdp: re-enable secondary process support > > > > > On 2/11/2022 1:01 PM, Loftus, Ciara wrote: > > >> > > >> On 2/11/2022 9:26 AM, Loftus, Ciara wrote: > > > > > > On 2/10/2022 5:47 PM, Loftus, Ciara wrote: > > >>> Subject: Re: [PATCH v4] net/af_xdp: re-

[PATCH V2] app/testpmd: fix GENEVE parsing in csum forward mode

2022-02-16 Thread Raja Zidane
The csum FWD mode parses any received packet to set mbuf offloads for the transmitting burst, mainly in the checksum/TSO areas. In the case of a tunnel header, the csum FWD tries to detect known tunnels by the standard definition using the header'sdata and fallback to check the packet type in the m

Re: [PATCH v5 01/10] ethdev: introduce flow pre-configuration hints

2022-02-16 Thread Andrew Rybchenko
On 2/11/22 21:47, Alexander Kozyrev wrote: On Friday, February 11, 2022 5:17 Andrew Rybchenko wrote: Sent: Friday, February 11, 2022 5:17 To: Alexander Kozyrev ; dev@dpdk.org Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; ivan.ma...@oktetlabs.ru; ferruh.yi...@intel.com; mohammad.abdul.

Re: [PATCH v5 02/10] ethdev: add flow item/action templates

2022-02-16 Thread Andrew Rybchenko
On 2/12/22 01:25, Alexander Kozyrev wrote: On Fri, Feb 11, 2022 6:27 Andrew Rybchenko wrote: On 2/11/22 05:26, Alexander Kozyrev wrote: Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an applicatio

Re: [PATCH v2 2/2] net/bonding: fix slaves initializing on mtu setting

2022-02-16 Thread Ferruh Yigit
On 2/15/2022 10:59 AM, Wan Junjie wrote: If a initial process for the bonding device is like: rte_eth_dev_configure rte_eth_dev_set_mtu queue setup and start, etc. Pass the vdev args to application, and init bonding device only. -a :af:00.0 --vdev="net_bonding0,mode=2,slave=:af:00.0" It

Re: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-16 Thread Andrew Rybchenko
On 2/12/22 05:19, Alexander Kozyrev wrote: On Fri, Feb 11, 2022 7:42 Andrew Rybchenko : On 2/11/22 05:26, Alexander Kozyrev wrote: A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechani

Re: [PATCH] net/cnxk: resolve mbuf data length update issue

2022-02-16 Thread Jerin Jacob
On Wed, Jan 19, 2022 at 4:22 PM Rahul Bhansali wrote: > > If multi-segment is enabled and single segment/packet > is received, then mbuf data_len is not updated in > cn9k_nix_cqe_to_mbuf function. > Also, in case of timestamp is enabled, mbuf data_len > and pkt_len will be updated for all packets

[PATCH] ethdev: fix MAC address in telemetry device info

2022-02-16 Thread David Marchand
The right size for a human readable mac is RTE_ETHER_ADDR_FMT_SIZE. While at it, the net library provides a helper for mac address formatting. Prefer it. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: sta...@dpdk.org Reported-by: Christophe Fontaine Signed-off-by: Dav

Re: [dpdk-dev] [PATCH v2 0/3] fixes for ixgbe/txgbe/iavf

2022-02-16 Thread Ferruh Yigit
On 2/15/2022 2:27 PM, Ferruh Yigit wrote: On 2/15/2022 1:01 PM, Yunjian Wang wrote: This series include three fixes patches for ixgbe/txgbe/iavf. --- v2:     * update patch 1/3 code styles suggested by Haiyue Wang Yunjian Wang (3):    net/ixgbe: set pointer to NULL after free    net/txgbe: set

RE: [PATCH v5 02/10] ethdev: add flow item/action templates

2022-02-16 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Subject: Re: [PATCH v5 02/10] ethdev: add flow item/action templates > > On 2/12/22 01:25, Alexander Kozyrev wrote: > > On Fri, Feb 11, 2022 6:27 Andrew Rybchenko > > wrote: > >> On 2/11/22 05:26, Alexander Kozyrev wrote: > >>>

Re: [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03

2022-02-16 Thread Ferruh Yigit
On 2/12/2022 2:01 PM, Yanling Song wrote: But my question was more related to the HW, is there any relation between the hinic HW and spnic HW? Like one is derived from other etc... I'm not clear what's the relation between hinic/spnic hw since we do not know what's the hinic hw. So there is n

RE: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-16 Thread Ori Kam
Hi Andew, > -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, February 16, 2022 3:34 PM > Subject: Re: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules > operations > > On 2/12/22 05:19, Alexander Kozyrev wrote: > > On Fri, Feb 11, 2022 7:42 Andrew Rybchenko :

[PATCH v2 00/11] add missing C++ guards

2022-02-16 Thread Brian Dooley
Public header files were missing 'extern "C"' guards. This set adds them in. v2: - Fixed checkpatch errors Brian Dooley (11): eal: fix missing C++ guards telemetry: fix missing C++ guards ethdev: fix missing C++ guards metrics: fix missing C++ guards acl: fix missing C++ guards compre

[PATCH v2 01/11] eal: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: af75078fece3 ("first public release") Fixes: 7f3aa0863903 ("eal: introduce bit operations API") Fixes: 166a743c53fa ("compat: add infrastructure to support symbol

[PATCH v2 02/11] telemetry: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") Cc: ciara.po...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley Acked-by: Bruce Richardson ---

[PATCH v2 03/11] ethdev: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: 7a3f27cbf59b ("ethdev: add access to specific device info") Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers") Fixes: 7f0a669e7b04 ("ethdev: add allocation he

[PATCH v2 04/11] metrics: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: c5b7197f662e ("telemetry: move some functions to metrics library") Cc: ciara.po...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley Acked-by: Bruce Ric

[PATCH v2 05/11] acl: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: dc276b5780c2 ("acl: new library") Cc: konstantin.anan...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley Acked-by: Bruce Richardson --- v2: Added mi

[PATCH v2 06/11] compressdev: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: ed7dd94f7f66 ("compressdev: add basic device management") Cc: fiona.tr...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley Acked-by: Bruce Richardson

[PATCH v2 07/11] eventdev: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: dc39e2f359b5 ("eventdev: add ring structure for events") Fixes: 7a3357205755 ("lib: remove C++ include guard from private headers") Cc: bruce.richard...@intel.com

[PATCH v2 08/11] kni: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: 3fc5ca2f6352 ("kni: initial import") Cc: sta...@dpdk.org Signed-off-by: Brian Dooley Acked-by: Bruce Richardson --- v2: Added missing apostrophe to commit mes

[PATCH v2 09/11] vhost: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: d7280c9fffcb ("vhost: support selective datapath") Fixes: 78639d54563a ("vhost: introduce async enqueue registration API") Fixes: 3bb595ecd682 ("vhost/crypto: add

[PATCH v2 10/11] bpf: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: 7a3357205755 ("lib: remove C++ include guard from private headers") Cc: tho...@monjalon.net Cc: sta...@dpdk.org Signed-off-by: Brian Dooley Acked-by: Bruce Rich

[PATCH v2 11/11] cryptodev: fix missing C++ guards

2022-02-16 Thread Brian Dooley
Some public header files were missing 'extern "C"' C++ guards, and couldn't be used by C++ applications. Add the missing guards. Fixes: 7a3357205755 ("lib: remove C++ include guard from private headers") Cc: tho...@monjalon.net Cc: sta...@dpdk.org Signed-off-by: Brian Dooley Acked-by: Bruce Rich

RE: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-16 Thread Ori Kam
Hi Andew, I missed on comments PSB, > -Original Message- > From: Andrew Rybchenko > Subject: Re: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules > operations > > On 2/12/22 05:19, Alexander Kozyrev wrote: > > On Fri, Feb 11, 2022 7:42 Andrew Rybchenko : > >> On 2/11/22 0

[PATCH] net/af_xdp: allow operation when multiprocess is disabled

2022-02-16 Thread Junxiao Shi
If EAL multiprocess feature has been disabled via rte_mp_disable() function, AF_XDP driver may not be able to register its IPC callback. Previously this leads to probe failure. This commit adds a check for this condition so that AF_XDP can still be used even if multiprocess is disabled. Fixes: 987

[PATCH 3/3] doc/dmadev/idxd: improve configuration examples

2022-02-16 Thread Bruce Richardson
The documentation on how to configure device instances using accel-config can be improved by a number of changes: * For initial example, when only configuring one queue, omit configuration of a second engine, which is unused later. * Add the "max-batch-size" setting to the options being configur

[PATCH 2/3] dma/idxd: configure max batch size to high value

2022-02-16 Thread Bruce Richardson
When configuring an Intel DSA instance using the utility script dpdk_idxd_cfg.py, explicitly set the max supported batch size value to a high value, to ensure large bursts are supported if so desired. The default in the linux kernel is now just 32 [1], which may not be sufficient for all DPDK apps.

[PATCH 1/3] app/test: fix missing checks for DMA device capacity

2022-02-16 Thread Bruce Richardson
For some DMA HW devices, e.g. those using the idxd driver, the maximum burst size is configurable, which can lead to test failures if the value is set too small. Add explicit check for this to give reasonable error messages for devices which need their config adjusted. Fixes: 1b86a66a30c2 ("test/d

[PATCH 0/3] idxd driver update fixes

2022-02-16 Thread Bruce Richardson
This set contains a number of small fixes and updates for the idxd dma driver, mainly in the area of properly handling cases where the default max batch size is configured to a lower than expected value. Bruce Richardson (3): app/test: fix missing checks for DMA device capacity dma/idxd: confi

Re: [PATCH] ethdev: fix MAC address in telemetry device info

2022-02-16 Thread Ferruh Yigit
On 2/16/2022 2:13 PM, David Marchand wrote: The right size for a human readable mac is RTE_ETHER_ADDR_FMT_SIZE. While at it, the net library provides a helper for mac address formatting. Prefer it. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc:sta...@dpdk.org Reporte

Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

2022-02-16 Thread Gaëtan Rivet
On Tue, Feb 15, 2022, at 16:27, David Marchand wrote: > On Thu, Feb 10, 2022 at 6:01 PM Gaetan Rivet wrote: >> >> The function rte_devargs_parse() previously was safe to call with >> non-initialized devargs structure as parameter. >> >> When adding the support for the global device syntax, >> this

[Bug 936] DPDK init for i40e pmd fails

2022-02-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=936 Bug ID: 936 Summary: DPDK init for i40e pmd fails Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major Priority: Norm

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Stephen Hemminger
On Wed, 16 Feb 2022 09:33:02 + Bruce Richardson wrote: > On Tue, Feb 15, 2022 at 03:00:56PM -0800, Stephen Hemminger wrote: > > Yet another case of applying Linux kernel best practices > > to DPDK. Flexible arrays are supported by Clang, GCC and > > Microsoft compilers (part of C99). > > >

[PATCH 1/2] event/dlb2: update rolling mask used for dequeue

2022-02-16 Thread Timothy McDaniel
Update the rolling mask used in dequeue operations. Fixes vector optimized dequeue. Fixes: 000a7b8e7582 ("event/dlb2: optimize dequeue operation") Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) d

[PATCH 2/2] event/dlb2: poll HW CQ inflights before mapping queue

2022-02-16 Thread Timothy McDaniel
When attempting to link a port and queue immediately after unlinking, the CQ inflights may not all be processed. Poll the h/w register for outstanding inflights instead of reading once, in case the inflights are still being processed. Also return EBUSY if the inflight processing is not completed in

[PATCH 0/4] eal: remove some experimental tags

2022-02-16 Thread Stephen Hemminger
These are all functions that have been in DPDK for two years or more and should no longer be experimental. Stephen Hemminger (4): rte_log: take of some experimental tags lcore: change rte_lcore_to_cpu_id and rte_lcore_cpuset as not experimental eal: make some intr functions not experimen

[PATCH 1/4] rte_log: take of some experimental tags

2022-02-16 Thread Stephen Hemminger
The RTE_LOG_REGISTER is not experimental, and the experimental tag was never enforced on these. Make rte_log_can_log a fully supported function. It was introduced nearly 2yrs ago. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_log.h | 10 -- lib/eal/version.map | 2 +-

[PATCH 2/4] lcore: change rte_lcore_to_cpu_id and rte_lcore_cpuset as not experimental

2022-02-16 Thread Stephen Hemminger
These API's have been around for a long time and by now are fixed. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_lcore.h | 9 + lib/eal/version.map | 4 ++-- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/r

[PATCH 3/4] eal: make some intr functions not experimental

2022-02-16 Thread Stephen Hemminger
These are functions related to interrupts that have been in since 20.02 release or earlier. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_interrupts.h | 12 +--- lib/eal/version.map | 10 +++--- 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/l

[PATCH 4/4] eal: mark rte_delay_us_sleep as not experimental

2022-02-16 Thread Stephen Hemminger
This has been around since 2018 release. Signed-off-by: Stephen Hemminger --- lib/eal/include/generic/rte_cycles.h | 4 +--- lib/eal/version.map | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/include/generic/rte_cycles.h b/lib/eal/include/generic

RE: [PATCH v5 01/10] ethdev: introduce flow pre-configuration hints

2022-02-16 Thread Alexander Kozyrev
On Wed, Feb 16, 2022 8:03 Andrew Rybchenko : > On 2/11/22 21:47, Alexander Kozyrev wrote: > > On Friday, February 11, 2022 5:17 Andrew Rybchenko > wrote: > >> Sent: Friday, February 11, 2022 5:17 > >> To: Alexander Kozyrev ; dev@dpdk.org > >> Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > (EXTERNAL)

RE: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-16 Thread Alexander Kozyrev
On Sat, Feb 12, 2022 4:25 Thomas Monjalon wrote: > 12/02/2022 03:19, Alexander Kozyrev: > > On Fri, Feb 11, 2022 7:42 Andrew Rybchenko > : > > > On 2/11/22 05:26, Alexander Kozyrev wrote: > > > > +__rte_experimental > > > > +struct rte_flow * > > > > +rte_flow_q_flow_create(uint16_t port_id, > > >

Re: [dpdk-dev] [PATCH] common/cnxk: fix missing null check in IPv6 flow parsing

2022-02-16 Thread Jerin Jacob
On Tue, Jan 25, 2022 at 9:43 AM wrote: > > From: Satheesh Paul > > Added null check in IPv6 flow pattern parsing. > > Fixes: a55dc02af5 ("common/cnxk: support extensions attributes in IPv6 item") The changeset is not correct. > Cc: sta...@dpdk.org > > Signed-off-by: Satheesh Paul > Reviewed-by

RE: release candidate 22.03-rc1

2022-02-16 Thread Jiang, YuX
> -Original Message- > From: Thomas Monjalon > Sent: Monday, February 14, 2022 8:58 AM > To: annou...@dpdk.org > Subject: release candidate 22.03-rc1 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v22.03-rc1 > > There are 481 new patches in

RE: [PATCH v5] app/eventdev: add crypto producer mode

2022-02-16 Thread Gujjar, Abhinandan S
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Wednesday, February 16, 2022 2:25 PM > To: Gujjar, Abhinandan S ; Hemant Agrawal > ; Nipun Gupta ; Van > Haaren, Harry > Cc: Shijith Thotton ; Jerin Jacob Kollanukkaran > ; dev@dpdk.org > Subject: Re: [PATCH v5] app/eventdev: add

[PATCH] net/mlx5: support matching optional fields of GRE

2022-02-16 Thread Sean Zhang
This patch adds matching on the optional fields (checksum/key/sequence) of GRE header. The matching on checksum and sequence fields requests support from rdma-core with the capability of misc5 and tunnel_header 0-3. For patterns without checksum and sequence specified, keep using misc for matching

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

2022-02-16 Thread Singh, Aman Deep
On 2/16/2022 3:47 AM, Thomas Monjalon wrote: 15/02/2022 19:51, Singh, Aman Deep: On 2/11/2022 10:58 PM, Thomas Monjalon wrote: 11/02/2022 09:07, Singh, Aman Deep: On 2/10/2022 9:00 PM, Thomas Monjalon wrote: 10/02/2022 14:26, Singh, Aman Deep: On 2/4/2022 1:17 PM, Thomas Monjalon wrote: 0

Re: [dpdk-dev] [PATCH] common/cnxk: fix missing RTE Flow counter deletion

2022-02-16 Thread Jerin Jacob
On Tue, Jan 25, 2022 at 9:45 AM wrote: > > From: Satheesh Paul > > Added code to clear and delete counters upon flow deletion. > > Fixes: a07f7ced43 ("common/cnxk: add NPC init and fini") > Cc: sta...@dpdk.org > > Signed-off-by: Satheesh Paul > Reviewed-by: Jerin Jacob Kollanukkaran Updated th

RE: [EXT] [PATCH v5] app/eventdev: add crypto producer mode

2022-02-16 Thread Akhil Goyal
Hi Shijith, Few comments inline. With those fixed. Acked-by: Akhil Goyal > +static int > +perf_event_crypto_adapter_setup(struct test_perf *t, struct prod_data *p) > +{ > + struct evt_options *opt = t->opt; > + uint32_t cap; > + int ret; > + > + ret = rte_event_crypto_adapter_cap

[PATCH] net/vhost: get csum offload capabilities of vhost backend

2022-02-16 Thread Wenwu Ma
The current vhost backend lacks csum offloads information, which will cause testpmd command such as "csum set tcp hw " to fail. This patch adds the information according to the device features. Signed-off-by: Wenwu Ma --- drivers/net/vhost/rte_eth_vhost.c | 18 ++ 1 file changed,

[PATCH] examples/vhost: add option to control mbuf pool size

2022-02-16 Thread Wenwu Ma
dpdk-vhost will fail to launch with a 40G i40e port because there are not enough mbufs. This patch adds a new option --total-num-mbufs, through which the user can set larger mbuf pool to avoid this problem. Signed-off-by: Wenwu Ma --- examples/vhost/main.c | 83 +++---

[PATCH] examples/multi_process: add options to control port configuration

2022-02-16 Thread Wenwu Ma
The default values of rx mq_mode and rx offloads for port will cause symmetric_mp startup failure if the port do not support rss or csum. Therefore, we added two new options --rx-mq-mode and --rx-offloads, through which the user can set the values appropriately according to the situation to make ap

Re: [dpdk-dev] [PATCH] common/cnxk: fix log level during MCAM allocation

2022-02-16 Thread Jerin Jacob
On Tue, Jan 25, 2022 at 9:46 AM wrote: > > From: Satheesh Paul > > Changed log level from info to debug for a couple of log > messages printed during MCAM allocation. > > Fixes: 1f66919817 ("common/cnxk: improve MCAM entries management") > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kuma

RE: [PATCH] vhost: fix unsafe vrings addresses modifications

2022-02-16 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, January 27, 2022 7:10 PM > To: dev@dpdk.org; Xia, Chenbo ; Wang, YuanX > ; david.march...@redhat.com > Cc: sta...@dpdk.org; Maxime Coquelin > Subject: [PATCH] vhost: fix unsafe vrings addresses modifications > > This patch ad

RE: [PATCH] examples/vhost: delete DMA type parameter help info

2022-02-16 Thread Xia, Chenbo
> -Original Message- > From: Chengwen Feng > Sent: Thursday, February 17, 2022 11:25 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Subject: [PATCH] examples/vhost: delete DMA type parameter help info > > The dma-type parameter was not suppor

Re: [RFC 0/2] Eliminate zero length arrays in DPDK

2022-02-16 Thread Tyler Retzlaff
On Wed, Feb 16, 2022 at 10:10:01AM +, Bruce Richardson wrote: > On Wed, Feb 16, 2022 at 11:05:09AM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Wednesday, 16 February 2022 10.33 > > > > > > On Tue, Feb 15, 2022 at 03:00:56PM -0800, St

RE: [PATCH v2 09/11] vhost: fix missing C++ guards

2022-02-16 Thread Xia, Chenbo
> -Original Message- > From: Dooley, Brian > Sent: Wednesday, February 16, 2022 11:15 PM > To: dev@dpdk.org > Cc: Dooley, Brian ; zhihong.w...@intel.com; > patrick...@intel.com; Zhang, Roy Fan ; > maxime.coque...@redhat.com; sta...@dpdk.org; Richardson, Bruce > ; Xia, Chenbo ; Jay Zhou > ;

RE: [PATCH v9 06/50] vhost: remove unneeded header includes

2022-02-16 Thread Xia, Chenbo
> -Original Message- > From: Morrissey, Sean > Sent: Tuesday, February 15, 2022 8:30 PM > To: Maxime Coquelin ; Xia, Chenbo > > Cc: dev@dpdk.org; Morrissey, Sean > Subject: [PATCH v9 06/50] vhost: remove unneeded header includes > > These header includes have been flagged by the iwyu_to