> -----Original Message-----
> From: Morrissey, Sean <sean.morris...@intel.com>
> Sent: Tuesday, February 15, 2022 8:30 PM
> To: Maxime Coquelin <maxime.coque...@redhat.com>; Xia, Chenbo
> <chenbo....@intel.com>
> Cc: dev@dpdk.org; Morrissey, Sean <sean.morris...@intel.com>
> Subject: [PATCH v9 06/50] vhost: remove unneeded header includes
> 
> These header includes have been flagged by the iwyu_tool
> and removed.
> 
> Signed-off-by: Sean Morrissey <sean.morris...@intel.com>
> ---
>  lib/vhost/fd_man.c     | 6 ------
>  lib/vhost/fd_man.h     | 1 -
>  lib/vhost/socket.c     | 1 -
>  lib/vhost/vdpa.c       | 1 -
>  lib/vhost/vhost.c      | 4 ----
>  lib/vhost/vhost.h      | 2 --
>  lib/vhost/vhost_user.c | 2 --
>  7 files changed, 17 deletions(-)
> 
> diff --git a/lib/vhost/fd_man.c b/lib/vhost/fd_man.c
> index 55d4856f9e..1876fada33 100644
> --- a/lib/vhost/fd_man.c
> +++ b/lib/vhost/fd_man.c
> @@ -2,14 +2,8 @@
>   * Copyright(c) 2010-2014 Intel Corporation
>   */
> 
> -#include <stdint.h>
>  #include <stdio.h>
> -#include <stdlib.h>
> -#include <sys/socket.h>
> -#include <sys/time.h>
> -#include <sys/types.h>
>  #include <unistd.h>
> -#include <string.h>
> 
>  #include <rte_common.h>
>  #include <rte_log.h>
> diff --git a/lib/vhost/fd_man.h b/lib/vhost/fd_man.h
> index 3ab5cfdd60..6f4499bdfa 100644
> --- a/lib/vhost/fd_man.h
> +++ b/lib/vhost/fd_man.h
> @@ -4,7 +4,6 @@
> 
>  #ifndef _FD_MAN_H_
>  #define _FD_MAN_H_
> -#include <stdint.h>
>  #include <pthread.h>
>  #include <poll.h>
> 
> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
> index c2f8013cd5..b304339de9 100644
> --- a/lib/vhost/socket.c
> +++ b/lib/vhost/socket.c
> @@ -8,7 +8,6 @@
>  #include <stdlib.h>
>  #include <unistd.h>
>  #include <string.h>
> -#include <sys/types.h>
>  #include <sys/socket.h>
>  #include <sys/un.h>
>  #include <sys/queue.h>
> diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c
> index 6df2230a67..8fa2153023 100644
> --- a/lib/vhost/vdpa.c
> +++ b/lib/vhost/vdpa.c
> @@ -8,7 +8,6 @@
>   * Device specific vhost lib
>   */
> 
> -#include <stdbool.h>
>  #include <sys/queue.h>
> 
>  #include <rte_class.h>
> diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
> index 6bcb716de0..bc88148347 100644
> --- a/lib/vhost/vhost.c
> +++ b/lib/vhost/vhost.c
> @@ -4,7 +4,6 @@
> 
>  #include <linux/vhost.h>
>  #include <linux/virtio_net.h>
> -#include <stddef.h>
>  #include <stdint.h>
>  #include <stdlib.h>
>  #ifdef RTE_LIBRTE_VHOST_NUMA
> @@ -13,13 +12,10 @@
>  #endif
> 
>  #include <rte_errno.h>
> -#include <rte_ethdev.h>
>  #include <rte_log.h>
> -#include <rte_string_fns.h>
>  #include <rte_memory.h>
>  #include <rte_malloc.h>
>  #include <rte_vhost.h>
> -#include <rte_rwlock.h>
> 
>  #include "iotlb.h"
>  #include "vhost.h"
> diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
> index 1c2ee29600..64ec76b80e 100644
> --- a/lib/vhost/vhost.h
> +++ b/lib/vhost/vhost.h
> @@ -17,12 +17,10 @@
> 
>  #include <rte_log.h>
>  #include <rte_ether.h>
> -#include <rte_rwlock.h>
>  #include <rte_malloc.h>
>  #include <rte_dmadev.h>
> 
>  #include "rte_vhost.h"
> -#include "rte_vdpa.h"
>  #include "vdpa_driver.h"
> 
>  #include "rte_vhost_async.h"
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 1d3f89afd8..4f135f1f72 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -27,10 +27,8 @@
>  #include <fcntl.h>
>  #include <sys/ioctl.h>
>  #include <sys/mman.h>
> -#include <sys/types.h>
>  #include <sys/stat.h>
>  #include <sys/syscall.h>
> -#include <assert.h>
>  #ifdef RTE_LIBRTE_VHOST_NUMA
>  #include <numaif.h>
>  #endif
> --
> 2.25.1

Reviewed-by: Chenbo Xia <chenbo....@intel.com>

Reply via email to