RE: [PATCH v1] net/i40e: add flow mark capability to NEON vector routine

2022-02-15 Thread Zhang, Qi Z
> -Original Message- > From: Joyce Kong > Sent: Friday, December 17, 2021 1:36 PM > To: Ruifeng Wang ; Xing, Beilei > > Cc: dev@dpdk.org; n...@arm.com; Joyce Kong > Subject: [PATCH v1] net/i40e: add flow mark capability to NEON vector routine > > This commit adds a flow director supp

[PATCH v4 0/2] support L2TPv2 for AVF RSS and FDIR

2022-02-15 Thread Jie Wang
Support L2TPv2(include PPP over L2tpv2) for AVF RSS and FDIR based on outer MAC src/dst address and L2TPv2 session ID. Support PPPoL2TPv2oUDP for AVF FDIR based on inner IP src/dst address and TCP/UDP src/dst port. --- v4: rebase main branch. v3: update commit log and release notes. v2: upadte re

[PATCH v4 1/2] net/iavf: support L2TPv2 for AVF RSS

2022-02-15 Thread Jie Wang
Add support for L2TPv2(include PPP over L2TPv2) protocols RSS based on outer MAC src/dst address and L2TPv2 session ID. Patterns are listed below: eth/ipv4/udp/l2tpv2 eth/ipv4/udp/l2tpv2/ppp eth/ipv6/udp/l2tpv2 eth/ipv6/udp/l2tpv2/ppp Signed-off-by: Jie Wang Acked-by: Beilei Xing --- doc/guide

[PATCH v4 2/2] net/iavf: support L2TPv2 for AVF FDIR

2022-02-15 Thread Jie Wang
Add support for L2TPv2(include PPP over L2TPv2) protocols FDIR based on outer MAC src/dst address and L2TPv2 session ID. Add support for PPPoL2TPv2oUDP protocols FDIR based on inner IP src/dst address and UDP/TCP src/dst port. Patterns are listed below: eth/ipv4(6)/udp/l2tpv2 eth/ipv4(6)/udp/l2tp

RE: [PATCH v4 0/2] support L2TPv2 for AVF RSS and FDIR

2022-02-15 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Jie1X > Sent: Tuesday, February 15, 2022 4:26 PM > To: dev@dpdk.org > Cc: Yang, SteveX ; Wu, Jingjing > ; Xing, Beilei ; Zhang, Qi Z > ; Wang, Jie1X > Subject: [PATCH v4 0/2] support L2TPv2 for AVF RSS and FDIR > > Support L2TPv2(include PPP over L2t

[PATCH v2] ip_frag: add IPv4 options fragment and test data

2022-02-15 Thread Huichao Cai
According to RFC791,the options may appear or not in datagrams. They must be implemented by all IP modules (host and gateways). What is optional is their transmission in any particular datagram, not their implementation.So we have to deal with it during the fragmenting process.Add some test data fo

Re: out of tree driver builds broken with C++

2022-02-15 Thread Thomas Monjalon
15/02/2022 07:10, Tyler Retzlaff: > On Mon, Feb 14, 2022 at 10:22:08AM +0100, Thomas Monjalon wrote: > > 14/02/2022 10:13, Tyler Retzlaff: > > > while the driver api is "internal" we agreed some time ago that drivers > > > could be built external to the dpdk tree. by enabling the meson setup > > >

Re: [PATCH v1] ethdev: beautify the Rx desc number check indent

2022-02-15 Thread Ferruh Yigit
On 2/15/2022 7:04 AM, Haiyue Wang wrote: Align to Tx desc number check indent, which may help to understand Rx descriptor limits member in the alignment comparison view. And remove the extra empty line. Signed-off-by: Haiyue Wang --- lib/ethdev/rte_ethdev.c | 5 ++--- 1 file changed, 2 inser

RE: [PATCH] build: make ring mempool driver mandatory

2022-02-15 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 14 February 2022 16.31 > > The default mempool driver is one based on the rte_ring, and as such it > needs to be present to have just about any app (which doesn't override > the mempool) run. Given this state of affairs i

[PATCH] net/mlx5: remove unused function

2022-02-15 Thread Suanming Mou
The mlx5_l3t_prepare_entry() function is not used anymore. This commit removes the unused mlx5_l3t_prepare_entry() function. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_utils.c | 41 --- drivers/net/mlx5/mlx5_utils.h | 28

Re: [External] Re: [PATCH 1/2] net/bonding: add error hint for invald args

2022-02-15 Thread Wan Junjie
Hi Min Hu, Thanks for the reply Will fix it in v2. Regards, Wan Junjie On Tue, Feb 15, 2022 at 5:12 PM Min Hu (Connor) wrote: > > Hi, wan, > The headline has spelling errors. > > 在 2022/2/14 16:13, Wan Junjie 写道: > > When invalid args exsit, application exits with no error hint. > > Add

Re: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-15 Thread Ferruh Yigit
On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for TSO packets. Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, are we having

[PATCH] net/mlx5: fix error infomation missing

2022-02-15 Thread Suanming Mou
While mlx5_hlist_create() failed, the rte_flow_error was not filled with the corresponding error information. This commit adds the missing rte_flow_error_set() for the failure case. Fixes: f3020a331dca ("net/mlx5: optimize hash list table allocate on demand") Cc: sta...@dpdk.org Signed-off-by: S

[PATCH] app/testpmd: format dump information of module EEPROM

2022-02-15 Thread Robin Zhang
This patch add a format specific information of different module eeprom. The format support for SFP(Small Formfactor Pluggable)/SFP+ /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on SFF(Small Form Factor) Committee specifications SFF-8079/SFF-8472/SFF-8024/SFF-8636. Signed-off-by: R

Re: [External] Re: [PATCH 2/2] net/bonding: fix slaves initilizing on mtu setting

2022-02-15 Thread Wan Junjie
Hi Min Hu, On Tue, Feb 15, 2022 at 5:26 PM Min Hu (Connor) wrote: > > Hi, wan, > two comments: > 1. wrong spelling in headline Will fix it in v2. > 2. comment info should be detailed, such as, > show the testpmd commands about how to operate > in this two situations. > Testpmd did not show the

Re: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-15 Thread Kevin Traynor
On 15/02/2022 10:06, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for TSO packets. Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") Commit 'ff8b8bcd2ebe' was already

Re: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-15 Thread Nicolau, Radu
On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for TSO packets. Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") Commit 'ff8b8bcd2ebe' was alr

Re: [PATCH v3] vdpa/sfc: make MCDI memzone name unique

2022-02-15 Thread Maxime Coquelin
On 2/14/22 11:51, abhimanyu.sa...@xilinx.com wrote: From: Abhimanyu Saini Buffer for MCDI channel is allocated using rte_memzone_reserve_aligned with zone name 'mcdi'. Since multiple MCDI channels are needed to support multiple VF(s) and rte_memzone_reserve_aligned expects unique zone names,

[PATCH v2 1/2] net/bonding: add error hint for invalid args

2022-02-15 Thread Wan Junjie
When invalid args exist, application exits with no error hint. Adding a log message here will help users to know the reason. Signed-off-by: Wan Junjie --- v2: fix typo in commit msg --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH v3] vdpa/sfc: make MCDI memzone name unique

2022-02-15 Thread Maxime Coquelin
On 2/15/22 11:56, Maxime Coquelin wrote: On 2/14/22 11:51, abhimanyu.sa...@xilinx.com wrote: From: Abhimanyu Saini Buffer for MCDI channel is allocated using rte_memzone_reserve_aligned with zone name 'mcdi'. Since multiple MCDI channels are needed to support multiple VF(s) and rte_memzon

[PATCH v2 2/2] net/bonding: fix slaves initializing on mtu setting

2022-02-15 Thread Wan Junjie
If a initial process for the bonding device is like: rte_eth_dev_configure rte_eth_dev_set_mtu queue setup and start, etc. Pass the vdev args to application, and init bonding device only. -a :af:00.0 --vdev="net_bonding0,mode=2,slave=:af:00.0" It will fail and compain for the slave device

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

2022-02-15 Thread Karl Bonde Torp
On Mon, 14 Feb 2022 at 14:48, Bruce Richardson wrote: > > On Mon, Feb 14, 2022 at 12:43:13PM +0100, Karl Bonde Torp wrote: > > When building with Meson 0.61.1 on FreeBSD some archives become > > corrupted. This can be avoided by using 'llvm-ar' instead of 'ar'. > > > > Signed-off-by: Karl Bonde To

[PATCH] crypto/ipsec_mb: fix qp cleanup unreachable code

2022-02-15 Thread Ciara Power
The qp is never NULL when it reaches the qp_setup_cleanup error handling code. This is due to checks earlier in the function that return an error if qp is NULL. Coverity issue: 375013 Fixes: 581c39b1cb7d ("crypto/ipsec_mb: fix queue cleanup null pointer dereference") Cc: sta...@dpdk.org Signed-o

Re: [PATCH] net/ice/base: support E824S and E825 devices

2022-02-15 Thread Ferruh Yigit
On 1/25/2022 2:50 PM, Ferruh Yigit wrote: On 12/29/2021 9:25 AM, Robin Zhang wrote: Add support for E824S and E825 family devices. Signed-off-by: Robin Zhang What do you think documenting these new device support on release notes? Hi Qi, There was a change request on this patch, it is stil

Re: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-15 Thread Ferruh Yigit
On 2/15/2022 10:47 AM, Nicolau, Radu wrote: On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for TSO packets. Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload c

RE: [External] : Re: [PATCH] devargs: Fix crash due to global devargs uninitailization from secondary process

2022-02-15 Thread Madhuker Mythri
>-Original Message- >From: Ferruh Yigit >Sent: 14 फरवरी 2022 23:03 >To: Madhuker Mythri >Cc: dev@dpdk.org; Gaetan Rivet ; Thomas Monjalon >; David Marchand >Subject: [External] : Re: [PATCH] devargs: Fix crash due to global devargs >uninitailization from secondary process > >On 2/14/

Re: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-15 Thread Ferruh Yigit
On 2/15/2022 10:46 AM, Kevin Traynor wrote: On 15/02/2022 10:06, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for TSO packets. Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload cond

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

2022-02-15 Thread Bruce Richardson
On Tue, Feb 15, 2022 at 12:07:55PM +0100, Karl Bonde Torp wrote: > On Mon, 14 Feb 2022 at 14:48, Bruce Richardson > wrote: > > > > On Mon, Feb 14, 2022 at 12:43:13PM +0100, Karl Bonde Torp wrote: > > > When building with Meson 0.61.1 on FreeBSD some archives become > > > corrupted. This can be avo

RE: [PATCH v1] ethdev: beautify the Rx desc number check indent

2022-02-15 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, February 15, 2022 17:20 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Thomas Monjalon ; Andrew Rybchenko > > Subject: Re: [PATCH v1] ethdev: beautify the Rx desc number check indent > > On 2/15/2022 7:04 AM, Haiyue Wang wrote: > > Al

Re: [PATCH v2 1/2] net/bonding: add error hint for invalid args

2022-02-15 Thread Ferruh Yigit
On 2/15/2022 10:56 AM, Wan Junjie wrote: When invalid args exist, application exits with no error hint. Adding a log message here will help users to know the reason. Signed-off-by: Wan Junjie Acked-by: Ferruh Yigit

RE: [dpdk-dev] [PATCH 1/3] net/ixgbe: set pointer to NULL after free

2022-02-15 Thread Wang, Haiyue
> -Original Message- > From: Yunjian Wang > Sent: Tuesday, February 15, 2022 18:25 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Wu, Jingjing > ; Xing, Beilei > ; Wang, Haiyue ; > jiawe...@trustnetic.com; > jianw...@trustnetic.com; dingxiaoxi...@huawei.com; huangshaozh...@huawei.com; > Yunji

RE: [dpdk-dev] [PATCH 3/3] net/iavf: set pointer to NULL after free

2022-02-15 Thread Wang, Haiyue
> -Original Message- > From: Yunjian Wang > Sent: Tuesday, February 15, 2022 18:25 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Wu, Jingjing > ; Xing, Beilei > ; Wang, Haiyue ; > jiawe...@trustnetic.com; > jianw...@trustnetic.com; dingxiaoxi...@huawei.com; huangshaozh...@huawei.com; > Yunji

Re: [PATCH v3] vdpa/sfc: make MCDI memzone name unique

2022-02-15 Thread Maxime Coquelin
On 2/14/22 11:51, abhimanyu.sa...@xilinx.com wrote: From: Abhimanyu Saini Buffer for MCDI channel is allocated using rte_memzone_reserve_aligned with zone name 'mcdi'. Since multiple MCDI channels are needed to support multiple VF(s) and rte_memzone_reserve_aligned expects unique zone names,

Re: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-15 Thread Nicolau, Radu
On 2/15/2022 11:19 AM, Ferruh Yigit wrote: On 2/15/2022 10:47 AM, Nicolau, Radu wrote: On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for TSO packets. Fixes: ff8b

[PATCH v9 00/50] introduce IWYU

2022-02-15 Thread Sean Morrissey
This patchset introduces the include-what-you-use script which removes unused header includes. IWYU GitHub: https://github.com/include-what-you-use/include-what-you-use Along with the script there are some patches which make a start on removing unneeded headers. V4: * Re-added removed headers th

[PATCH v9 01/50] devtools: script to remove unused headers includes

2022-02-15 Thread Sean Morrissey
This script can be used for removing headers flagged for removal by the include-what-you-use (IWYU) tool. The script has the ability to remove headers from specified sub-directories or dpdk as a whole and tests the build after each removal by calling meson compile. example usages: Remove headers

[PATCH v9 02/50] telemetry: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ciara Power --- lib/telemetry/telemetry.c | 1 - lib/telemetry/telemetry_data.h | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telem

[PATCH v9 03/50] ring: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ring/rte_ring.c | 9 - 1 file changed, 9 deletions(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index 6a94a038c4..cddaf6b287 100644 --- a/lib/ring/rte_ring.c +++ b/li

[PATCH v9 04/50] kvargs: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kvargs/rte_kvargs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c index 11f624ef14..c77bb82feb 100644 --- a/lib/kvargs/rte_kvargs.c +

[PATCH v9 05/50] eal: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Reviewed-by: Harry van Haaren Reviewed-by: Mattias Rönnblom Reviewed-by: David Christensen --- lib/eal/common/eal_common_dev.c| 5 - lib/eal/common/eal_common_devargs.c| 1 -

[PATCH v9 07/50] timer: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Erik Gabriel Carrillo --- lib/timer/rte_timer.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 6d19ce469b..c51a393e5c 10064

[PATCH v9 06/50] vhost: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/vhost/fd_man.c | 6 -- lib/vhost/fd_man.h | 1 - lib/vhost/socket.c | 1 - lib/vhost/vdpa.c | 1 - lib/vhost/vhost.c | 4 lib/vhost/vhost.h | 2 -- lib

[PATCH v9 09/50] stack: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/stack/rte_stack.c | 2 -- lib/stack/rte_stack.h | 1 - 2 files changed, 3 deletions(-) diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c index 56bf2c8d6d..1fabec2bfe 100644 --- a

[PATCH v9 11/50] sched: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/sched/rte_pie.c | 2 -- lib/sched/rte_red.h | 1 - lib/sched/rte_sched.c | 1 - lib/sched/rte_sched.h | 1 - 4 files changed, 5 deletions(-) diff --git a/lib/sched/rte_pie.c b/lib/sch

[PATCH v9 08/50] table: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/table/rte_swx_table_em.c | 1 - lib/table/rte_swx_table_em.h | 1 - lib/table/rte_swx_table_learner.c | 1 - lib/table/rte_swx_table_learner.h | 1 - lib/table/rte_swx_table_

[PATCH v9 10/50] security: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/security/rte_security.c | 2 -- lib/security/rte_security.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index 6e45a03fa

[PATCH v9 12/50] rib: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rib/rte_rib.c | 2 -- lib/rib/rte_rib.h | 1 - lib/rib/rte_rib6.c | 2 -- lib/rib/rte_rib6.h | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c in

[PATCH v9 13/50] reorder: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/reorder/rte_reorder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index bc0241bfb3..385ee479da 100644 --- a/lib/reorder/rte_reo

[PATCH v9 14/50] regexdev: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ori Kam --- lib/regexdev/rte_regexdev.c | 2 -- lib/regexdev/rte_regexdev.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/lib/regexdev/rte_regexdev.c b/lib/regexdev/rte_regexde

[PATCH v9 15/50] rcu: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rcu/rte_rcu_qsbr.c | 4 lib/rcu/rte_rcu_qsbr.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c index 7510db2f81..17be93e830 100

[PATCH v9 16/50] rawdev: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Hemant Agrawal --- lib/rawdev/rte_rawdev.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c index a6134e76ea..2f0a4f1

[PATCH v9 17/50] power: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Also added rte_string_fns.h to example app vm_power_manager for users without libbsd. Signed-off-by: Sean Morrissey Acked-by: David Hunt --- examples/vm_power_manager/guest_cli/main.c | 1 + lib/power/guest_channel.c

[PATCH v9 18/50] port: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/port/rte_port_fd.h | 1 - lib/port/rte_port_frag.c| 2 -- lib/port/rte_port_frag.h| 1 - lib/port/rte_port_kni.c | 1 - lib/port/rte_port_kni.h | 1

[PATCH v9 19/50] pipeline: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pipeline/rte_pipeline.c | 4 lib/pipeline/rte_port_in_action.c| 2 -- lib/pipeline/rte_swx_ctl.h | 2 -- lib/pipeline/rte_swx_pipeline.c | 1 - lib/pipelin

[PATCH v9 20/50] pdump: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pdump/rte_pdump.c | 1 - lib/pdump/rte_pdump.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index af450695ec..b3a62df591 100644 --- a

[PATCH v9 21/50] pci: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pci/rte_pci.c | 15 +-- lib/pci/rte_pci.h | 1 - 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/lib/pci/rte_pci.c b/lib/pci/rte_pci.c index c91be8b167..355772f

[PATCH v9 22/50] pcapng: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 1 - lib/pcapng/rte_pcapng.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c inde

[PATCH v9 23/50] node: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/node/ethdev_ctrl.c | 2 -- lib/node/ethdev_rx.c | 1 - lib/node/ethdev_tx.c | 1 - lib/node/ip4_lookup.c | 5 - lib/node/ip4_rewrite.c | 4 lib/node/pkt_cls.c | 4 l

[PATCH v9 24/50] net: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/net/net_crc_avx512.c | 3 --- lib/net/net_crc_sse.c| 1 - lib/net/rte_arp.c| 1 - lib/net/rte_ether.h | 1 - lib/net/rte_net_crc.c| 2 -- 5 files changed, 8 deletions(

[PATCH v9 25/50] metrics: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/metrics/rte_metrics.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c index e2a0fbeda8..0c7878e65f 100644 --- a/lib/metrics/rte_

[PATCH v9 26/50] mempool: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mempool/rte_mempool.c | 7 --- lib/mempool/rte_mempool.h | 4 2 files changed, 11 deletions(-) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index c5a699b1d6

[PATCH v9 27/50] member: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/member/rte_member.c | 2 -- lib/member/rte_member.h | 1 - lib/member/rte_member_vbf.c | 1 - 3 files changed, 4 deletions(-) diff --git a/lib/member/rte_member.c b/lib/member/rte

[PATCH v9 28/50] mbuf: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mbuf/rte_mbuf.c | 11 --- lib/mbuf/rte_mbuf.h | 2 -- lib/mbuf/rte_mbuf_dyn.h | 2 -- lib/mbuf/rte_mbuf_pool_ops.c | 1 - lib/mbuf/rte_mbuf_pool_ops.h |

[PATCH v9 29/50] lpm: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/lpm/rte_lpm.c | 7 --- lib/lpm/rte_lpm.h | 4 lib/lpm/rte_lpm6.c | 7 --- lib/lpm/rte_lpm6.h | 1 - 4 files changed, 19 deletions(-) diff --git a/lib/lpm/rte_lpm.c b/lib/lp

[PATCH v9 30/50] latencystats: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/latencystats/rte_latencystats.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c index ab8db7a139..8985a377

[PATCH v9 31/50] kni: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kni/rte_kni.c | 2 -- lib/kni/rte_kni.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c index fc8f0e7b5a..7971c56bb4 100644 --- a/lib/kni/rte_kn

[PATCH v9 32/50] jobstats: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/jobstats/rte_jobstats.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c index 9b8fde5d55..af565a14ea 100644 --- a/lib/jobsta

[PATCH v9 33/50] ipsec: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ipsec/esp_inb.c | 1 - lib/ipsec/esp_outb.c | 1 - lib/ipsec/ipsec_sad.c | 1 - lib/ipsec/sa.c| 3 --- lib/ipsec/sa.h| 1 - 5 files changed, 7 deletions(-) diff --git a

[PATCH v9 34/50] ip_frag: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ip_frag/rte_ip_frag_common.c | 1 - lib/ip_frag/rte_ipv4_fragmentation.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/ip_frag/rte_ip_frag_common.c b/lib/ip_frag/rte_ip_fra

[PATCH v9 35/50] hash: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/hash/rte_cuckoo_hash.c | 4 lib/hash/rte_fbk_hash.c| 6 -- lib/hash/rte_fbk_hash.h| 1 - lib/hash/rte_thash.c | 1 - lib/hash/rte_thash.h | 1 - 5 files change

[PATCH v9 36/50] gro: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gro/gro_tcp4.c | 1 - lib/gro/gro_tcp4.h | 2 -- lib/gro/gro_udp4.c | 1 - lib/gro/gro_udp4.h | 2 -- lib/gro/gro_vxlan_tcp4.c | 1 - lib/gro/gro_vxlan_udp4.c | 1 -

[PATCH v9 37/50] graph: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/graph/graph_debug.c| 2 -- lib/graph/graph_ops.c | 1 - lib/graph/graph_populate.c | 2 -- lib/graph/node.c | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/grap

[PATCH v9 38/50] gpudev: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index ce92d63257..55a087bfb6 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/

[PATCH v9 39/50] flow_classify: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/flow_classify/rte_flow_classify.c | 3 --- lib/flow_classify/rte_flow_classify.h | 4 lib/flow_classify/rte_flow_classify_parse.c | 1 - lib/flow_classify/rte_flow_classif

[PATCH v9 40/50] fib: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/fib/dir24_8.c | 4 lib/fib/rte_fib.c | 2 -- lib/fib/rte_fib.h | 1 - lib/fib/rte_fib6.c | 2 -- lib/fib/rte_fib6.h | 1 - lib/fib/trie.c | 5 - lib/fib/trie.h | 2 --

[PATCH v9 41/50] eventdev: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/eventdev/rte_event_ring.c | 6 -- lib/eventdev/rte_event_ring.h | 2 -- lib/eventdev/rte_event_timer_adapter.c | 5 - lib/eventdev/rte_event_timer_adapter.h |

[PATCH v9 42/50] efd: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/efd/rte_efd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index 86ef46863c..560cd78961 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.

[PATCH v9 43/50] dmadev: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/dmadev/rte_dmadev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h index 4abe79c536..ad9e7a0975 100644 --- a/lib/dmadev/rte_dmadev.h +

[PATCH v9 44/50] distributor: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: David Hunt --- lib/distributor/rte_distributor.c | 2 -- lib/distributor/rte_distributor_match_sse.c | 2 -- lib/distributor/rte_distributor_single.c| 2 -- 3 files change

[PATCH v9 45/50] compressdev: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/compressdev/rte_comp.c| 1 - lib/compressdev/rte_comp.h| 1 - lib/compressdev/rte_compressdev.c | 1 - lib/compressdev/rte_compressdev.h | 1 - lib/compress

[PATCH v9 47/50] bpf: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bpf/bpf.c | 4 lib/bpf/bpf_exec.c | 6 -- lib/bpf/bpf_jit_x86.c | 5 - lib/bpf/bpf_load.c | 8 lib/bpf/bpf_pkt.c | 12 lib/bpf

[PATCH v9 48/50] bbdev: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bbdev/rte_bbdev.c | 4 lib/bbdev/rte_bbdev.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index 7f353d4f7e..aaee7b7872 100644

[PATCH v9 46/50] cmdline: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cmdline/cmdline.c| 2 -- lib/cmdline/cmdline_parse.c | 3 --- lib/cmdline/cmdline_parse_portlist.c | 3 --- lib/cmdline/cmdline_parse_string.c | 4 lib/cmdl

[PATCH v9 49/50] cryptodev: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cryptodev/cryptodev_pmd.h | 4 lib/cryptodev/rte_cryptodev.c | 11 --- lib/cryptodev/rte_cryptodev.h | 2 -- 3 files changed, 17 deletions(-) diff --git a/lib/cryptodev/cry

[PATCH v9 50/50] acl: remove unneeded header includes

2022-02-15 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/acl/rte_acl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/acl/rte_acl.c b/lib/acl/rte_acl.c index 4e693b2488..a61c3ba188 100644 --- a/lib/acl/rte_acl.c +++ b/lib/acl/rte_acl.c @

Re: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-15 Thread Ferruh Yigit
On 2/15/2022 12:30 PM, Nicolau, Radu wrote: On 2/15/2022 11:19 AM, Ferruh Yigit wrote: On 2/15/2022 10:47 AM, Nicolau, Radu wrote: On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size b

Re: [PATCH] net/iavf: fix segmentation offload buffer size

2022-02-15 Thread Ferruh Yigit
On 2/15/2022 12:44 PM, Ferruh Yigit wrote: On 2/15/2022 12:30 PM, Nicolau, Radu wrote: On 2/15/2022 11:19 AM, Ferruh Yigit wrote: On 2/15/2022 10:47 AM, Nicolau, Radu wrote: On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2eb

Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

2022-02-15 Thread Ferruh Yigit
On 2/10/2022 5:01 PM, Gaetan Rivet wrote: The function rte_devargs_parse() previously was safe to call with non-initialized devargs structure as parameter. When adding the support for the global device syntax, this assumption was broken. Restore it by forcing memset as part of the call itself.

[PATCH v2 0/5] net/nfb: add missing libfdt dependency for build

2022-02-15 Thread spinler
From: Martin Spinler This series introduces standard RX timestamp offload flag support together with multiple MAC addresses support for NFB devices. Also fixes a promisc/multicast switch issue and minor annoyances. --- v2: * Removed libfdt dependency patch from series, is needless. * Added the

[PATCH v2 1/5] net/nfb: fix array indexes in deinit functions

2022-02-15 Thread spinler
From: Martin Spinler The indexes in the for cycle were wrongly used and the code accessed outside of the rxmac/txmac array. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Cc: cer...@netcope.com Cc: sta...@dpdk.org Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_ethdev.c | 14 +++

[PATCH v2 2/5] net/nfb: do not report zero-sized TX burst

2022-02-15 Thread spinler
From: Martin Spinler Zero-sized TX burst floods the log no more. Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_tx.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfb/nfb_tx.h b/drivers/net/nfb/nfb_tx.h index d3cbe3e6b3..910020e9e9 100644 --- a/driv

[PATCH v2 3/5] net/nfb: use RTE_ETH_RX_OFFLOAD_TIMESTAMP flag

2022-02-15 Thread spinler
From: Martin Spinler Rewrite the RX timestamp setup code to use standard offload flag. Signed-off-by: Martin Spinler --- doc/guides/nics/nfb.rst | 8 ++ drivers/net/nfb/nfb.h| 3 +- drivers/net/nfb/nfb_ethdev.c | 19 - drivers/net/nfb/nfb_rx.c | 53 --

[PATCH v2 4/5] net/nfb: fix multicast/promiscuous mode switching

2022-02-15 Thread spinler
From: Martin Spinler In the firmware, the promisc mode overrides the multicast mode. So when the promisc mode is turned off, driver must check if the multicast mode was active before and conditionally reactivate it. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Cc: cer...@netcope.com C

[PATCH v2 5/5] net/nfb: add support for more MAC addresses

2022-02-15 Thread spinler
From: Martin Spinler Extend the eth_dev_ops by add/remove MAC address functions. Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_ethdev.c | 90 ++-- 1 file changed, 77 insertions(+), 13 deletions(-) diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/

Re: [PATCH] net/enic: fix dereference before null check

2022-02-15 Thread Ferruh Yigit
On 2/14/2022 8:46 PM, John Daley wrote: This patch fixes an issue found by coverity. It checks for a possible null value of "error" before dereferencing it. CID: 375064: Dereference after null check Either the check against null is unnecessary, or there may be a null pointer dereference. Coveri

Re: [PATCH 6/6] drivers/nfb: add support for more MAC addresses

2022-02-15 Thread Martin Spinler
On Mon, 2022-02-14 at 17:54 +, Ferruh Yigit wrote: > > > > @@ -530,7 +577,7 @@ nfb_eth_dev_init(struct rte_eth_dev *dev) > > > > eth_addr_init.addr_bytes[1] = eth_addr.addr_bytes[1]; > > > > eth_addr_init.addr_bytes[2] = eth_addr.addr_bytes[2]; > > > >     > > > > - nfb_e

Re: [PATCH] app/testpmd: format dump information of module EEPROM

2022-02-15 Thread Ferruh Yigit
On 2/15/2022 10:18 AM, Robin Zhang wrote: This patch add a format specific information of different module eeprom. The format support for SFP(Small Formfactor Pluggable)/SFP+ /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on SFF(Small Form Factor) Committee specifications SFF-8079/S

Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

2022-02-15 Thread Gaëtan Rivet
On Tue, Feb 15, 2022, at 13:51, Ferruh Yigit wrote: > On 2/10/2022 5:01 PM, Gaetan Rivet wrote: >> The function rte_devargs_parse() previously was safe to call with >> non-initialized devargs structure as parameter. >> >> When adding the support for the global device syntax, >> this assumption was

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

2022-02-15 Thread Karl Bonde Torp
On Tue, 15 Feb 2022 at 12:27, Bruce Richardson wrote: > > On Tue, Feb 15, 2022 at 12:07:55PM +0100, Karl Bonde Torp wrote: > > On Mon, 14 Feb 2022 at 14:48, Bruce Richardson > > wrote: > > > > > > On Mon, Feb 14, 2022 at 12:43:13PM +0100, Karl Bonde Torp wrote: > > > > When building with Meson 0.

Re: [PATCH v2 0/5] net/nfb: add missing libfdt dependency for build

2022-02-15 Thread Ferruh Yigit
On 2/15/2022 12:55 PM, spin...@cesnet.cz wrote: From: Martin Spinler This series introduces standard RX timestamp offload flag support together with multiple MAC addresses support for NFB devices. Also fixes a promisc/multicast switch issue and minor annoyances. --- v2: * Removed libfdt depe

  1   2   >