On February 10, 2022 3:07 AM, Ferruh Yigit wrote:
> On 2/9/2022 10:42 AM, Jiawen Wu wrote:
> > Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix
> > that double line was added by using 'DEBUGOUT'.
> >
> > Fixes: cc934df178ab ("net/ngbe: add log and error types")
> > Cc: sta...@dp
Hi Ruifeng,
Patch looks reasonable, thank you.
Just curious - did you see the real issue with re-ordering in this code
fragment?
And, please, let us do performance check.
With best regards,
Slava
> -Original Message-
> From: Ruifeng Wang
> Sent: Thursday, February 10, 2022 8:25
> To: M
> -Original Message-
> From: Slava Ovsiienko
> Sent: Thursday, February 10, 2022 4:17 PM
> To: Ruifeng Wang ; Matan Azrad
>
> Cc: dev@dpdk.org; Honnappa Nagarahalli
> ; sta...@dpdk.org; nd ;
> nd
> Subject: RE: [PATCH] net/mlx5: fix risk in Rx descriptor read in NEON vector
> path
>
> H
> Subject: [PATCH v1] net/af_xdp: make umem configure code more readable
>
> The below compile time defined style make the code not so readable, the
> first function end block is after "#endif" segment.
>
> #if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG)
>
> xdp_umem_configure()
> {
On 2/8/2022 10:20 PM, Akhil Goyal wrote:
Hardware IP reassembly may be incomplete for multiple reasons like
reassembly timeout reached, duplicate fragments, etc.
To save application cycles to process these packets again, a new
mbuf dynflag is added to show that the mbuf received is not
reassemble
On 2/8/2022 10:20 PM, Akhil Goyal wrote:
IP Reassembly is a costly operation if it is done in software.
The operation becomes even more costlier if IP fragments are encrypted.
However, if it is offloaded to HW, it can considerably save application
cycles.
Hence, a new offload feature is exposed
On 2/8/2022 10:20 PM, Akhil Goyal wrote:
As discussed in the RFC[1] sent in 21.11, a new offload is
introduced in ethdev for IP reassembly.
This patchset add the IP reassembly RX offload.
Currently, the offload is tested along with inline IPsec processing.
It can also be updated as a standalone
The stubs header is included as part of rte_stack.h for architectures
other than x86_64 and aarch64 (i.e. x86 32 bits and ppc).
Note: chkincs won't catch this issue since it checks headers from within
the source directory.
Fixes: 7911ba0473e0 ("stack: enable lock-free implementation for aarch64")
On 2/9/2022 10:46 PM, Stephen Hemminger wrote:
On Wed, 9 Feb 2022 22:18:24 +
Ferruh Yigit wrote:
On 2/9/2022 6:03 PM, Ansar Kannankattil wrote:
Hi
My intention is to decrease the number of rte_tx_eth_burst calls, I know that
mentioning nb_pkts will result in sending multiple packets in a
On 2/10/2022 7:38 AM, Loftus, Ciara wrote:
Subject: [PATCH] ethdev: introduce generic dummy packet burst function
Multiple PMDs have dummy/noop Rx/Tx packet burst functions.
These dummy functions are very simple, introduce a common function in
the ethdev and update drivers to use it instead of
On 2/10/2022 8:03 AM, Jiawen Wu wrote:
On February 10, 2022 3:07 AM, Ferruh Yigit wrote:
On 2/9/2022 10:42 AM, Jiawen Wu wrote:
Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix
that double line was added by using 'DEBUGOUT'.
Fixes: cc934df178ab ("net/ngbe: add log and error
Move 'test-pmd/cmdline_tm.*' files under
"Traffic Management API" component.
Move 'test-pmd/cmdline_mtr.*' files under
"Traffic Metering and Policing API" component.
Signed-off-by: Yuying Zhang
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
On Thu, Feb 10, 2022 at 12:23:32PM +0530, Ankur Dwivedi wrote:
> Adds telemetry function for inline ipsec in net CNXK driver.
>
> This series depends on the following patch series:
>
> Series: Adding new features and improvements in cnxk crypto PMD
> http://patches.dpdk.org/project/dpdk/list/?ser
> -Original Message-
> From: Ling, WeiX
> Sent: Thursday, February 10, 2022 11:09 AM
> To: Zhou, YidingX ; Richardson, Bruce
> ; Wang, Haiyue
> Cc: Yang, Qiming ; Zhang, Qi Z
> ; dev@dpdk.org
> Subject: RE: [PATCH] net/ice: fix gcc error with -
> DRTE_LIBRTE_ICE_16BYTE_RX_DESC
>
> > -
09/02/2022 22:38, Alexander Kozyrev:
> Add testpmd support for the rte_flow_configure API.
A note about the titles for testpmd patches in this series:
You don't "implement" because it was implemented in rte_flow.c.
Instead, better to say "add" in the testpmd app context.
Also you should not menti
On February 10, 2022 5:03 PM, Ferruh Yigit wrote:
> On 2/10/2022 8:03 AM, Jiawen Wu wrote:
> > On February 10, 2022 3:07 AM, Ferruh Yigit wrote:
> >> On 2/9/2022 10:42 AM, Jiawen Wu wrote:
> >>> Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix
> >>> that double line was added by
Hi Bruce,
Please see my comment inline.
Regards,
Ankur
>-Original Message-
>From: Bruce Richardson
>Sent: Thursday, February 10, 2022 2:42 PM
>To: Ankur Dwivedi
>Cc: dev@dpdk.org; Nithin Kumar Dabilpuram ;
>Kiran Kumar Kokkilagadda ; Sunil Kumar Kori
>; Satha Koteswara Rao Kottidi
>; J
On 2/9/22 01:20, Akhil Goyal wrote:
IP Reassembly is a costly operation if it is done in software.
The operation becomes even more costlier if IP fragments are encrypted.
However, if it is offloaded to HW, it can considerably save application
cycles.
Hence, a new offload feature is exposed in et
On 2/10/2022 5:11 PM, Yuying Zhang wrote:
Move 'test-pmd/cmdline_tm.*' files under
"Traffic Management API" component.
Move 'test-pmd/cmdline_mtr.*' files under
"Traffic Metering and Policing API" component.
Signed-off-by: Yuying Zhang
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
On 2/10/2022 9:30 AM, Zhang, Qi Z wrote:
-Original Message-
From: Ling, WeiX
Sent: Thursday, February 10, 2022 11:09 AM
To: Zhou, YidingX ; Richardson, Bruce
; Wang, Haiyue
Cc: Yang, Qiming ; Zhang, Qi Z
; dev@dpdk.org
Subject: RE: [PATCH] net/ice: fix gcc error with -
DRTE_LIBRTE_IC
From: Pavan Nikhilesh
Tx command is prepared based on offloads enabled and stored in
Tx queue structure at tx_queue_setup phase.
In fastpath the command is copied from Tx queue to LMT line for
all the packets.
Since, the command contents are mostly constants we can move the
command preparation to
On 2/10/2022 9:49 AM, Jiawen Wu wrote:
On February 10, 2022 5:03 PM, Ferruh Yigit wrote:
On 2/10/2022 8:03 AM, Jiawen Wu wrote:
On February 10, 2022 3:07 AM, Ferruh Yigit wrote:
On 2/9/2022 10:42 AM, Jiawen Wu wrote:
Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix
that do
> This patch adds crypto uint typedef so adding comment
> about byte-order becomes unnecessary.
>
> It makes API comments more tidy, and more consistent
> with other asymmetric crypto APIs.
>
> Additionally it reorganizes code that enums, externs
> and forward declarations are moved to the top of
On Thu, Feb 10, 2022 at 3:43 PM wrote:
>
> From: Pavan Nikhilesh
>
> Tx command is prepared based on offloads enabled and stored in
> Tx queue structure at tx_queue_setup phase.
> In fastpath the command is copied from Tx queue to LMT line for
> all the packets.
> Since, the command contents are
From: Pavan Nikhilesh
Store and reuse workslot status for TT, GRP and HEAD status
instead of reading from GWC as reading from GWC imposes
additional latency.
Signed-off-by: Pavan Nikhilesh
---
Depends-on: 21590
v3 Changes:
- Split and rebase patches.
v2 Changes:
- Rebase.
- Fix incorrec
From: Pavan Nikhilesh
Setting WAITW bit enables default min dequeue timeout of 1us.
Avoid the min dequeue timeout by setting WAITW only when dequeue_timeout
is configured.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/cnxk/cn10k_eventdev.c | 8 +--
drivers/event/cnxk/cn9k_eventdev.c |
From: Pavan Nikhilesh
Improve vWQE and CQ Rx performance by tuning perfetches to 64B
cacheline size.
Also, prefetch the vWQE array offsets at cacheline boundaries.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/cnxk/cn10k_worker.h | 25 +++--
drivers/net/cnxk/cn10k_rx.h
On 2/10/2022 10:08 AM, Andrew Rybchenko wrote:
On 2/9/22 01:20, Akhil Goyal wrote:
IP Reassembly is a costly operation if it is done in software.
The operation becomes even more costlier if IP fragments are encrypted.
However, if it is offloaded to HW, it can considerably save application
cycles
This patch fixes misspelled RTE_RSA_KEY_TYPE_QT,
this will prevent checkpach from complaining wherever
change to RSA is being made.
Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions")
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 2 +-
app/t
On 2/10/2022 10:20 AM, Ferruh Yigit wrote:
On 2/10/2022 10:08 AM, Andrew Rybchenko wrote:
On 2/9/22 01:20, Akhil Goyal wrote:
IP Reassembly is a costly operation if it is done in software.
The operation becomes even more costlier if IP fragments are encrypted.
However, if it is offloaded to HW,
On 2/10/2022 8:53 AM, Loftus, Ciara wrote:
Subject: [PATCH v1] net/af_xdp: make umem configure code more readable
The below compile time defined style make the code not so readable, the
first function end block is after "#endif" segment.
#if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG)
> From: Wang, Haiyue
> Date: Thursday, 27 January 2022 at 07:56
> To: Elena Agostini , dev@dpdk.org
> Subject: RE: [PATCH v4 1/2] gpudev: expose GPU memory to CPU
> External email: Use caution opening links or attachments
>
>
> > -Original Message-
> > From: eagost...@nvidia.com
> > Sent
On 2/10/2022 10:37 AM, Ansar Kannankattil wrote:
moved down, please avoid top post
On Thu, Feb 10, 2022 at 2:26 PM Ferruh Yigit mailto:ferruh.yi...@intel.com>> wrote:
On 2/9/2022 10:46 PM, Stephen Hemminger wrote:
> On Wed, 9 Feb 2022 22:18:24 +
> Ferruh Yigit mailto:ferruh.y
> -Original Message-
> From: Guo, Junfeng
> Sent: Thursday, February 10, 2022 15:18
> To: Wu, Jingjing
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering
>
>
>
> > -Original Message-
> > From: Wu, Jingjing
> > Sent:
lv_enabled is used to remember if large VF setting is configured, but
its value is not initialized at startup. This can lead to a different
configuration regarding the initial configuration of the PF.
For example, a first start is done with 8 rx and 8 tx queues. Large VF
is not needed and reta size
v4-change-log
* fix i386 compilation
v3-change-log
* fix checkpatch issues
* use devargs for strict ordering
* fix AES_CMAC capabilities
* remove GMAC patch from this series. I will send
it as separate patch.
v2-change-log
* using dev args for both DPAA1 and DPAA2 drivers to
dump debug prints on
From: Franck LENORMAND
DPAA1 and DPAA2 platforms use SEC ERA 8 and 10 only.
This patch removes code in SDAP and PDCP header related to these
ERA to simplify the codebase:
- Simplify logic using RTA_SEC_ERA_<> macro
- Remove era_2_sw_hfn_ovrd dedicated to RTA_SEC_ERA_2
Signed-off-by: Franck LE
For PDCP SDAP test cases, HW sec engine process the
jobs in WAIT mode.
Signed-off-by: Gagandeep Singh
---
drivers/common/dpaax/caamflib/desc/sdap.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/common/dpaax/caamflib/desc/sdap.h
b/drivers/comm
From: Hemant Agrawal
Add IV size and change the digest size to supported
value by the HW engine.
Signed-off-by: Hemant Agrawal
Signed-off-by: Gagandeep Singh
---
drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/d
Few useful debug prints added in dequeue function.
Signed-off-by: Gagandeep Singh
---
doc/guides/cryptodevs/dpaa2_sec.rst | 10 ++
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 136 +++-
2 files changed, 144 insertions(+), 2 deletions(-)
diff --git a/doc/guides/cryptode
From: Hemant Agrawal
This patch add more checks on next type for PDCP cases.
Fixes: 45e019608f31 ("crypto/dpaa2_sec: support integrity only PDCP")
Fixes: a1173d55598c ("crypto/dpaa_sec: support PDCP offload")
Cc: sta...@dpdk.org
Signed-off-by: Hemant Agrawal
---
drivers/crypto/dpaa2_sec/dpaa2
From: Nipun Gupta
This patch supports ordered queue for DPAA2 platform.
Signed-off-by: Nipun Gupta
Signed-off-by: Gagandeep Singh
---
doc/guides/cryptodevs/dpaa2_sec.rst | 7 +
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 288 ++--
drivers/crypto/dpaa2_sec/dpaa2_sec
Adding useful debug prints in DPAA driver for
easy debugging.
Signed-off-by: Gagandeep Singh
---
doc/guides/cryptodevs/dpaa_sec.rst | 10 ++
drivers/bus/dpaa/dpaa_bus.c| 16 ++-
drivers/crypto/dpaa_sec/dpaa_sec.c | 192 -
3 files changed, 213 insertions(+),
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Tuesday, 8 February 2022 20.45
>
> Multiple PMDs have dummy/noop Rx/Tx packet burst functions.
>
> These dummy functions are very simple, introduce a common function in
> the ethdev and update drivers to use it instead of each driver ha
On 2/9/2022 3:32 PM, Stephen Hemminger wrote:
On Wed, 9 Feb 2022 20:24:10 +0800
Yunjian Wang wrote:
This NULL check is unnecessary, 'eth_dev' is never NULL.
Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
Acked-by: St
Thanks for the responses,
Then what is the advantage of chaining mbuffs over using the mbuff array?
On Thu, Feb 10, 2022 at 2:26 PM Ferruh Yigit wrote:
> On 2/9/2022 10:46 PM, Stephen Hemminger wrote:
> > On Wed, 9 Feb 2022 22:18:24 +
> > Ferruh Yigit wrote:
> >
> >> On 2/9/2022 6:03 PM, An
On Thu, Feb 10, 2022 at 10:04:22AM +, Ankur Dwivedi wrote:
> Hi Bruce,
>
> Please see my comment inline.
>
> Regards,
> Ankur
>
> >-Original Message-
> >From: Bruce Richardson
> >Sent: Thursday, February 10, 2022 2:42 PM
> >To: Ankur Dwivedi
> >Cc: dev@dpdk.org; Nithin Kumar Dabilp
On Thu, Feb 10, 2022 at 04:07:02PM +0530, Ansar Kannankattil wrote:
>Thanks for the responses,
>Then what is the advantage of chaining mbuffs over using the mbuff
>array?
>
They imply different things.
* An array of mbufs represents multiple packets.
* A chain of mbufs is a single pack
On 2/10/22 14:04, Morten Brørup wrote:
From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
Sent: Tuesday, 8 February 2022 20.45
Multiple PMDs have dummy/noop Rx/Tx packet burst functions.
These dummy functions are very simple, introduce a common function in
the ethdev and update drivers to use i
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
> Sent: Thursday, 10 February 2022 12.39
>
> On 2/10/22 14:04, Morten Brørup wrote:
> >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> >> Sent: Tuesday, 8 February 2022 20.45
> >>
> >> Multiple PMDs have dummy/noop Rx/Tx packet
Fix bug in batch alloc issue failure path.
Fixes: 91531e63f4 ("mempool/cnxk: add cn10k batch dequeue")
Signed-off-by: Ashwin Sekhar T K
---
drivers/mempool/cnxk/cn10k_mempool_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mempool/cnxk/cn10k_mempool_ops.c
b/dr
On 2/10/22 14:47, Morten Brørup wrote:
From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
Sent: Thursday, 10 February 2022 12.39
On 2/10/22 14:04, Morten Brørup wrote:
From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
Sent: Tuesday, 8 February 2022 20.45
Multiple PMDs have dummy/no
This patchset expands upon the exiting chkincs infrastructure to build a
C++ test application as well as the existing C test app, which helps
catch any build errors when the public DPDK headers are included in C++
code. The rest of this patchset fixes the errors caught by this
additional check - mo
C++ files could not include some headers because:
* "new" is a keyword in C++, so can't be a variable name
* there is no automatic casting to/from void *
Fixes: 184104fc6121 ("ticketlock: introduce fair ticket based locking")
Fixes: ebaee6409702 ("trace: simplify trace point headers")
Cc: joyce.k
The eventdev headers had issues when used from C++
* Missing closing "}" for the extern "C" block
* No automatic casting to/from void *
Fixes: a6562f6d6f8e ("eventdev: introduce event timer adapter")
Fixes: 32e326869ed6 ("eventdev: add tracepoints")
Cc: erik.g.carri...@intel.com
Cc: sk...@marvell
C++ does not have automatic casting to/from void pointers, so need
explicit cast if header is to be included in C++ code
Fixes: 40d4f51403ec ("graph: implement fastpath routines")
Cc: jer...@marvell.com
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
Acked-by: Jerin Jacob
---
lib/graph/rte
C++ does not have automatic casting to/from void pointers, so need
explicit cast if header is to be included in C++ code
Fixes: f901d9c82688 ("ipsec: add helpers to group completed crypto-ops")
Cc: konstantin.anan...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
lib/ipsec/rt
Since C++ doesn't support automatic casting from void * to other types,
we need to explicitly add the casts to any header files in DPDK.
Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers")
Cc: kevin.la...@intel.com
Cc: cristian.dumitre...@intel.com
Cc: sta...@dpdk.org
Signed-off-b
The virtio kernel header includes are already noted as being
incompatible with C++. We can ensure that the header is safe for
inclusion in C++ code by not including those headers during C++ builds.
While not ideal, this does ensure that all DPDK headers can be included
in C++ code without errors.
Add support for checking each of our headers for issues when included in
a C++ file.
Signed-off-by: Bruce Richardson
---
buildtools/chkincs/main.cpp| 4
buildtools/chkincs/meson.build | 20
2 files changed, 24 insertions(+)
create mode 100644 buildtools/chkincs/ma
>
> According to RFC791,the options may appear or not in datagrams.
> They must be implemented by all IP modules (host and gateways).
> What is optional is their transmission in any particular datagram,
> not their implementation.So we have to deal with it during the
> fragmenting process.Add s
On 2/9/2022 1:21 AM, Min Hu (Connor) wrote:
Added the ethdev dump API which provides querying private info from ethdev.
There exists many private properties in different PMD drivers, such as
adapter state, Rx/Tx func algorithm in hns3 PMD. The information of these
properties is important for debu
On 2/10/2022 12:32 PM, Ferruh Yigit wrote:
On 2/9/2022 1:21 AM, Min Hu (Connor) wrote:
Added the ethdev dump API which provides querying private info from ethdev.
There exists many private properties in different PMD drivers, such as
adapter state, Rx/Tx func algorithm in hns3 PMD. The informati
On 2/9/2022 1:21 AM, Min Hu (Connor) wrote:
Added the ethdev dump API which provides querying private info from ethdev.
There exists many private properties in different PMD drivers, such as
adapter state, Rx/Tx func algorithm in hns3 PMD. The information of these
properties is important for debu
> C++ does not have automatic casting to/from void pointers, so need
> explicit cast if header is to be included in C++ code
>
> Fixes: f901d9c82688 ("ipsec: add helpers to group completed crypto-ops")
> Cc: konstantin.anan...@intel.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Bruce Richardson
On Thu, Feb 10, 2022 at 1:03 PM Bruce Richardson
wrote:
>
> C++ files could not include some headers because:
>
> * "new" is a keyword in C++, so can't be a variable name
> * there is no automatic casting to/from void *
>
> Fixes: 184104fc6121 ("ticketlock: introduce fair ticket based locking")
>
This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size
being computed for TSO packets.
Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition")
Signed-off-by: Radu Nicolau
---
drivers/net/iavf/iavf_rxtx.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-
From: Pavan Nikhilesh
Tx command is prepared based on offloads enabled and stored in
Tx queue structure at tx_queue_setup phase.
In fastpath the command is copied from Tx queue to LMT line for
all the packets.
Since, the command contents are mostly constants we can move the
command preparation to
From: Pavan Nikhilesh
Store and reuse workslot status for TT, GRP and HEAD status
instead of reading from GWC as reading from GWC imposes
additional latency.
Signed-off-by: Pavan Nikhilesh
---
Depends-on: 21590
v4 Changes:
- Update commit title for 3/3
v3 Changes:
- Split and rebase patc
From: Pavan Nikhilesh
Setting WAITW bit enables default min dequeue timeout of 1us.
Avoid the min dequeue timeout by setting WAITW only when dequeue_timeout
is configured.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/cnxk/cn10k_eventdev.c | 8 +--
drivers/event/cnxk/cn9k_eventdev.c |
From: Pavan Nikhilesh
Improve vWQE and CQ Rx performance by tuning perfetches to 64B
cacheline size.
Also, prefetch the vWQE array offsets at cacheline boundaries.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/cnxk/cn10k_worker.h | 25 +++--
drivers/net/cnxk/cn10k_rx.h
On 2/10/2022 1:16 PM, Min Hu (Connor) wrote:
Hi, Ferruh,
在 2022/2/10 20:37, Ferruh Yigit 写道:
On 2/9/2022 1:21 AM, Min Hu (Connor) wrote:
Added the ethdev dump API which provides querying private info from ethdev.
There exists many private properties in different PMD drivers, such as
adapter st
On 2/4/2022 1:17 PM, Thomas Monjalon wrote:
04/02/2022 07:13, Singh, Aman Deep:
Hi Thomas
On 2/3/2022 2:31 AM, Thomas Monjalon wrote:
23/01/2022 18:20, Aman Singh:
Added two specific exceptions for ETH_SPEED_10G
and ETH_SPEED_25G to avoid there name change.
Added check for ETH_TUNNEL_FILTER
>-Original Message-
>From: Bruce Richardson
>Sent: Thursday, February 10, 2022 5:02 PM
>To: Ankur Dwivedi
>Cc: dev@dpdk.org; Nithin Kumar Dabilpuram ;
>Kiran Kumar Kokkilagadda ; Sunil Kumar Kori
>; Satha Koteswara Rao Kottidi
>; Jerin Jacob Kollanukkaran
>; Anoob Joseph ; Tejasree
>Ko
On 2/8/2022 11:26 PM, Ivan Malov wrote:
Doing so is wrong since fast free is an adapter-wide offload.
Technically, the offending commit (see "Fixes" tag) does not
induce failures, however, such started to occur after commit
a4996bd89c42 ("ethdev: new Rx/Tx offloads API") had shown up,
because of
On 2/9/22 13:51, Jiayu Hu wrote:
Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA
abstraction layer and simplify application logics, this patch integrates
dmadev in asynchronous data path.
Signed-off-by: Jiayu Hu
Signed-off-by: Sunil Pai G
---
doc/guides/prog_guide/
On 2/8/2022 7:44 PM, Ferruh Yigit wrote:
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index aecdc5a68abb..bbe05bb837e0 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -1623,8 +1623,8 @@ mlx5_dev_spawn(struct rte_device *d
This patchset includes improvements for the asymmetric session.
The main change is to the session structure, which is now a single
mempool object, rather than having pointers to private data elsewhere.
This session structure is now hidden in an internal header,
so the app will never use it directly
The programmer's guide for cryptodev included sample code for using
Asymmetric crypto. This is now replaced with direct code from the test
application, using literal includes. It is broken into snippets as the
test application didn't have all of the required code in one function.
Signed-off-by: Ci
Rather than using a session buffer that contains pointers to private
session data elsewhere, have a single session buffer.
This session is created for a driver ID, and the mempool element
contains space for the max session private data needed for any driver.
Signed-off-by: Ciara Power
Acked-by: F
The rte_cryptodev_asym_session structure is now moved to an internal
header. This will no longer be used directly by apps,
private session data can be accessed via get API.
Signed-off-by: Ciara Power
Acked-by: Fan Zhang
---
v4:
- Initialised session variables as NULL.
- Removed docs code ad
A user data field is added to the asymmetric session structure.
Relevant API added to get/set the field.
Signed-off-by: Ciara Power
Acked-by: Fan Zhang
Acked-by: Anoob Joseph
---
v4:
- Reworded release notes.
- Added possible error return values in function comment.
- Removed docs code a
Rather than the asym session create function returning a session on
success, and a NULL value on error, it is modified to now return int
values - 0 on success or -EINVAL/-ENOTSUP/-ENOMEM on failure.
The session to be used is passed as input.
This adds clarity on the failure of the create function,
This patchset expands upon the exiting chkincs infrastructure to build a
C++ test application as well as the existing C test app, which helps
catch any build errors when the public DPDK headers are included in C++
code. The rest of this patchset fixes the errors caught by this
additional check - mo
C++ files could not include some headers because:
* "new" is a keyword in C++, so can't be a variable name
* there is no automatic casting to/from void *
Fixes: 184104fc6121 ("ticketlock: introduce fair ticket based locking")
Fixes: ebaee6409702 ("trace: simplify trace point headers")
Cc: joyce.k
The eventdev headers had issues when used from C++
* Missing closing "}" for the extern "C" block
* No automatic casting to/from void *
Fixes: a6562f6d6f8e ("eventdev: introduce event timer adapter")
Fixes: 32e326869ed6 ("eventdev: add tracepoints")
Cc: erik.g.carri...@intel.com
Cc: sk...@marvell
C++ does not have automatic casting to/from void pointers, so need
explicit cast if header is to be included in C++ code
Fixes: 40d4f51403ec ("graph: implement fastpath routines")
Cc: jer...@marvell.com
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
Acked-by: Jerin Jacob
---
lib/graph/rte
C++ does not have automatic casting to/from void pointers, so need
explicit cast if header is to be included in C++ code
Fixes: f901d9c82688 ("ipsec: add helpers to group completed crypto-ops")
Cc: konstantin.anan...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
lib/ipsec/rt
Since C++ doesn't support automatic casting from void * to other types,
we need to explicitly add the casts to any header files in DPDK.
Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers")
Cc: kevin.la...@intel.com
Cc: cristian.dumitre...@intel.com
Cc: sta...@dpdk.org
Signed-off-b
The virtio kernel header includes are already noted as being
incompatible with C++. We can ensure that the header is safe for
inclusion in C++ code by not including those headers during C++ builds.
While not ideal, this does ensure that all DPDK headers can be included
in C++ code without errors.
Add support for checking each of our headers for issues when included in
a C++ file.
Signed-off-by: Bruce Richardson
---
.ci/linux-build.sh | 1 +
buildtools/chkincs/main.cpp| 4
buildtools/chkincs/meson.build | 20
3 files changed, 25 insertions(+)
c
Hi Luc,
> > > Calls to rte_memcpy_generic could result in unaligned loads/stores for
> > > 1 < n < 16. This is undefined behavior according to the C standard,
> > > and it gets flagged by the clang undefined behavior sanitizer.
> > >
> > > rte_memcpy_generic is called with unaligned src and dst ad
On Thu, Feb 10, 2022 at 01:57:09PM +0100, David Marchand wrote:
> On Thu, Feb 10, 2022 at 1:03 PM Bruce Richardson
> wrote:
> >
> > C++ files could not include some headers because:
> >
> > * "new" is a keyword in C++, so can't be a variable name
> > * there is no automatic casting to/from void *
> -Original Message-
> From: Ghalem Boudour
> Sent: Thursday, February 10, 2022 6:49 PM
> To: Wu, Jingjing ; Xing, Beilei
> Cc: dev@dpdk.org; Xu, Ting ; Ghalem Boudour
> ; Thibaut Collet ;
> Olivier Matz
> Subject: [PATCH v2] net/iavf: initialize large VF setting at startup
>
> lv_enabl
Hi Ciara,
Minor nit inline. With that
Series Acked-by: Anoob Joseph
Thanks,
Anoob
> -Original Message-
> From: Ciara Power
> Sent: Thursday, February 10, 2022 7:32 PM
> To: dev@dpdk.org
> Cc: roy.fan.zh...@intel.com; Akhil Goyal ; Anoob Joseph
> ; m...@ashroe.eu; Ciara Power
> ; Decla
---
v2:
Certain variants require that PCIe read-requests be correctly
throttled. This is called "rqpacing" in Arkville, and has to do
with credit and flow control on certain Arkville implementations.
Improved code readability and comments.
---
Signed-off-by: John Miller
---
drivers/net/ark/a
---
v2:
Added arbitrary mbuf size per queue capability.
Updated ARK_UDM_CONST3 value to reflect the version number
read from the HW that is required to support this change.
---
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c| 8
drivers/net/ark/ark_ethdev_rx.c | 23 +
---
v2:
Various performance optimizations and behavior fixes
- Chunk mpu transfer use 64 objects (512 byte) to maintain memory
read alignment
- Align mpu memory allocation to be at 512 byte boundaries
- Reduce force-close allocation from 1 objects to 64 objects
- Add memory write barriers
On Thu, Feb 10, 2022 at 3:05 PM Bruce Richardson
wrote:
>
> Add support for checking each of our headers for issues when included in
> a C++ file.
>
> Signed-off-by: Bruce Richardson
> ---
> .ci/linux-build.sh | 1 +
> buildtools/chkincs/main.cpp| 4
> buildtools/chkincs/m
Hi,
On 2/4/22 12:56, Weiguo Li wrote:
The macro sfc_vdpa_info(sva, ...) will invoke sva->logtype_main,
It'll trigger a NULL dereference when sva is NULL.
This patch fix it.
BTW this patch is not superseded by another one:
[v2] vdpa/sfc: fix null dereference
(http://dpdk.org/patch/106720)
1 - 100 of 239 matches
Mail list logo
