RE: [PATCH v4 5/6] net/iavf: support L2TPv2 for AVF HASH

2022-02-09 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, February 9, 2022 3:02 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; Yigit, Ferruh ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Wu, Jingjing > ; Zhang, Qi Z ; > olivi

RE: [PATCH v4 0/6] support L2TPv2 for AVF RSS hash and FDIR

2022-02-09 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, February 8, 2022 10:45 PM > To: Wang, Jie1X ; dev@dpdk.org; Zhang, Qi Z > > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Wu, Jingjing ; > Xing, Beilei ; olivier

RE: [PATCH v2 1/2] net/mlx5: fix metadata endianness in modify field action

2022-02-09 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Thursday, February 3, 2022 10:47 AM > To: dev@dpdk.org > Cc: ferruh.yi...@intel.com; Matan Azrad ; Raslan > Darawsheh ; sta...@dpdk.org > Subject: [PATCH v2 1/2] net/mlx5: fix metadata endianness in modify field > action > > As mod

RE: [PATCH] doc: add limitation on MPRQ usage in multi-process app

2022-02-09 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Friday, February 4, 2022 5:19 AM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] doc: add limitation on MPRQ usage in multi-process app > > MPRQ cannot be used in multi-process appli

RE: [PATCH] net/mlx5: fix Committed Bucket Size calculation

2022-02-09 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Monday, February 7, 2022 3:29 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Suanming Mou > Subject: [PATCH] net/mlx5: fix Committed Bucket Size calculation > > Committed Buck

Re: [RFC] Testpmd Maintenance affecting DTS

2022-02-09 Thread Thomas Monjalon
08/02/2022 22:34, Owen Hilyard: > Currently, DTS tests DPDK via the example applications (/examples) and the > apps (/app) included with DPDK. The DTS Working group has been trying to > move to primarily using Testpmd, since it is the most complete and only > using one application causes less maint

RE: [PATCH] net/mlx5: fix Meter capabilities reporting

2022-02-09 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Monday, February 7, 2022 3:30 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Suanming Mou > Subject: [PATCH] net/mlx5: fix Meter capabilities reporting > > Meter capabilities

RE: [PATCH] net/mlx5: fix inline length for multi-segment TSO

2022-02-09 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Monday, February 7, 2022 5:49 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix inline length for multi-segment TSO > > This patch removes a redund

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

2022-02-09 Thread Zhang, Yuying
Hi Dmitry, > -Original Message- > From: Singh, Aman Deep > Sent: Thursday, February 3, 2022 9:52 PM > To: Dmitry Kozlyuk ; dev@dpdk.org > Cc: Li, Xiaoyun ; Zhang, Yuying > ; jing.d.c...@intel.com; sta...@dpdk.org; Raslan > Darawsheh > Subject: Re: [PATCH] app/testpmd: skip stopped queues

RE: [PATCH 6/7] vhost: remove non-C++ compatible includes

2022-02-09 Thread Wang, Xiao W
Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Saturday, February 5, 2022 2:19 AM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Xia, Chenbo > ; Wang, Xiao W ; Matan > Azrad ; Viacheslav Ovsiienko > > Subject: Re: [PATCH 6/7] vhost: remove non-C++ compatible includes > > O

Re: [PATCH v3 3/3] eal: move common filesystem setup code into one file

2022-02-09 Thread Bruce Richardson
On Tue, Feb 08, 2022 at 10:54:03PM -0800, Stephen Hemminger wrote: > Both Linux and FreeBSD have same code for creating runtime > directory and reading sysfs files. Put them in the new lib/eal/unix > subdirectory. > > Signed-off-by: Stephen Hemminger LGTM, apart from one minor nit inline below.

Re: [PATCH 6/7] vhost: remove non-C++ compatible includes

2022-02-09 Thread Bruce Richardson
On Wed, Feb 09, 2022 at 09:10:36AM +, Wang, Xiao W wrote: > Hi Bruce, > > > -Original Message- From: Richardson, Bruce > > Sent: Saturday, February 5, 2022 2:19 AM > > To: dev@dpdk.org Cc: Maxime Coquelin ; Xia, > > Chenbo ; Wang, Xiao W ; > > Matan Azrad ; Viacheslav Ovsiienko > > S

RE: [PATCH v1] maintainers: update for testpmd

2022-02-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Yuying > Sent: Wednesday, February 9, 2022 3:01 PM > To: dev@dpdk.org; Yigit, Ferruh ; Li, Xiaoyun > ; Dumitrescu, Cristian > ; tho...@monjalon.net > Cc: Zhang, Yuying > Subject: [PATCH v1] maintainers: update for testpmd > > Add Cristian as maintai

Re: [PATCH v2 06/16] net/netvsc: add define guards to avoid multi-inclusion

2022-02-09 Thread Bruce Richardson
On Tue, Feb 08, 2022 at 10:28:01PM -0800, Stephen Hemminger wrote: > On Wed, 9 Feb 2022 11:02:14 +0800 > Weiguo Li wrote: > > > Supplement define guards to prevent multiple inclusion. > > > > Signed-off-by: Weiguo Li > > Why bother these are just driver specific includes, not a public API On

[PATCH v1] maintainers: update for testpmd

2022-02-09 Thread Yuying Zhang
Add Konstantin as maintainer of test-pmd/bpf_cmd.* files. Signed-off-by: Yuying Zhang --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c65b753c6b..bf05e726b4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1615,6 +1615,7 @@ M: Konstantin Ananyev

[PATCH v5 0/6] support L2TPv2 for AVF RSS hash and FDIR

2022-02-09 Thread Jie Wang
Support IAVF L2TPv2(include PPP over L2tpv2) RSS hash and flow director. Required to distribute packets based on outer MAC src address and L2TPv2 session ID. Support IAVF PPPoL2TPv2oUDP flow director. Required to distribute packets based on inner IP src+dest address and TCP/UDP src+dest port. ---

[PATCH v5 1/6] ethdev: add L2TPv2 RSS offload type

2022-02-09 Thread Jie Wang
This patch defines new RSS offload type for L2TPv2, which is required when users want to distribute packets based on the L2TPv2 session ID field. Signed-off-by: Jie Wang --- app/test-pmd/cmdline.c | 16 +--- app/test-pmd/config.c | 3 ++- d

[PATCH v5 2/6] net: fix L2TPv2 common header

2022-02-09 Thread Jie Wang
The fields of L2TPv2 common header were reversed in big endian and little endian. This patch fixes this error to ensure L2TPv2 can be parsed correctly. For L2TP reference: https://datatracker.ietf.org/doc/html/rfc2661#section-3.1 Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") Cc

[PATCH v5 3/6] app/testpmd: add 6 types of L2TPv2 message

2022-02-09 Thread Jie Wang
This patch adds L2TPv2 control message and 5 types of data message support for testpmd. The added L2TPv2 message types are listed below: 1. L2TPv2 control 2. L2TPv2 3. L2TPv2 + length option 4. L2TPv2 + sequence option 5. L2TPv2 + offset option 6. L2TPv2 + length option + sequence option Signed-o

[PATCH v5 5/6] net/iavf: support L2TPv2 for AVF HASH

2022-02-09 Thread Jie Wang
Add support for PPP over L2TPv2 over UDP protocol and L2TPv2 protocol RSS hash based on outer MAC src address and L2TPv2 session ID. Patterns are listed below: eth/ipv4/udp/l2tpv2 eth/ipv4/udp/l2tpv2/ppp eth/ipv6/udp/l2tpv2 eth/ipv6/udp/l2tpv2/ppp Signed-off-by: Jie Wang --- doc/guides/rel_note

[PATCH v5 4/6] common/iavf: add session ID fields for L2TPv2

2022-02-09 Thread Jie Wang
Add virtchnl fields session ID of L2TPv2 for AVF HASH. Signed-off-by: Jie Wang --- drivers/common/iavf/virtchnl.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 80e754a1b2..3e44eca7d8 100644 --- a/drivers/common/iavf/

[PATCH v5 6/6] net/iavf: support L2TPv2 for AVF FDIR

2022-02-09 Thread Jie Wang
Add support for L2TPv2(include PPP over L2TPv2) protocols FDIR based on outer MAC src address and L2TPv2 session ID. Add support for PPPoL2TPv2oUDP protocols FDIR based on inner IP src/dst address and UDP/TCP src/dst port. Patterns are listed below: eth/ipv4(6)/udp/l2tpv2 eth/ipv4(6)/udp/l2tpv2/p

RE: [PATCH v2 12/16] acl: add define guards to avoid multi-inclusion

2022-02-09 Thread Ananyev, Konstantin
> Supplement define guards to prevent multiple inclusion. > It should noted that there is an exceptional case: > lib/acl/acl_run_avx512_common.h is designed to be included > several times. > > Signed-off-by: Weiguo Li > --- > lib/acl/acl_run_altivec.h | 5 + > lib/acl/acl_run_avx2.h

[PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-09 Thread Ciara Loftus
Secondary process support had been disabled for the AF_XDP PMD because there was no logic in place to share the AF_XDP socket file descriptors between the processes. This commit introduces this logic using the IPC APIs. Rx and Tx are disabled in the secondary process due to memory mapping of the A

RE: [PATCH v2 12/16] acl: add define guards to avoid multi-inclusion

2022-02-09 Thread Weiguo Li
On Wed, 9 Feb 2022 09:42:28 +, Ananyev, Konstantin wrote: > > Do we really need these changes? > All these headers are internal ones for acl_run_*.c and not > supposed to be included multiple times anyway. > Got it. This v2 series are superseded. I've updated it by a new verision v3[1] whic

RE: [dpdk-dev v7 00/10] drivers/qat: QAT symmetric crypto datapatch rework

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 00/10] drivers/qat: QAT symmetric crypto datapatch > rework > > This patch reworks QAT symmetric crypto datapatch implementation wher

RE: [dpdk-dev v7 01/10] common/qat: define build op request and dequeue op

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 01/10] common/qat: define build op request and > dequeue op > > This patch introduce build request op and dequeue op function > point

RE: [dpdk-dev v7 02/10] crypto/qat: sym build op request specific implementation

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 02/10] crypto/qat: sym build op request specific > implementation > > This patch adds common inline functions for QAT symmetric > cry

RE: [dpdk-dev v7 03/10] crypto/qat: qat generation specific enqueue

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 03/10] crypto/qat: qat generation specific enqueue > > This patch add in specific aead & auth build op enqueue functions > for QAT Ge

RE: [dpdk-dev v7 04/10] crypto/qat: rework session APIs

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 04/10] crypto/qat: rework session APIs > > This patch introduces the set_session methods for different > generations of QAT. In addit

RE: [dpdk-dev v7 05/10] crypto/qat: rework asymmetric crypto build operation

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 05/10] crypto/qat: rework asymmetric crypto build > operation > > This patch reworks the asymmetric crypto data path > implementation

RE: [dpdk-dev v7 06/10] crypto/qat: unify qat sym pmd apis

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 06/10] crypto/qat: unify qat sym pmd apis > > This patch removes qat_sym_pmd.c and integrates all the apis into > qat_sym.c. The unif

RE: [dpdk-dev v7 07/10] crypto/qat: unify qat asym pmd apis

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 07/10] crypto/qat: unify qat asym pmd apis > > This patch removes qat_asym_pmd.c and integrates all the > functions into qat_asym.c.

RE: [dpdk-dev v7 08/10] crypto/qat: op burst data path rework

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 08/10] crypto/qat: op burst data path rework > > This patch enable op_build_request function in qat_enqueue_op_burst, > and qat_deque

RE: [dpdk-dev v7 09/10] crypto/qat: raw dp api integration

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 09/10] crypto/qat: raw dp api integration > > This patch "unifies" QAT's raw dp api implementations > to share the same enqueue/deque

RE: [dpdk-dev v7 10/10] crypto/qat: support out of place SG list

2022-02-09 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, February 8, 2022 6:15 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v7 10/10] crypto/qat: support out of place SG list > > This patch adds the SGL out of place support to QAT PMD > > Signed-off-by: Kai J

[PATCH v2 00/12] Wangxun fixes and supports

2022-02-09 Thread Jiawen Wu
Fixed some bugs for txgbe and ngbe, and support more custom functions. v2: - Add more detail describe in commit logs and release notes. - Fix build error. - Fix debug logs. Jiawen Wu (12): net/ngbe: fix failed to receive packets net/ngbe: fix link interrupt sometimes lost net/ngbe: fix Tx p

[PATCH v2 02/12] net/ngbe: fix link interrupt sometimes lost

2022-02-09 Thread Jiawen Wu
When the port is started and stopped continuously and quickly, one interrupt cannot be handled in time, which will cause subsequent interrupts to be lost, so that link status will cannot be updated. Fixes: b9246b8fa280 ("net/ngbe: support link update") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu

[PATCH v2 01/12] net/ngbe: fix failed to receive packets

2022-02-09 Thread Jiawen Wu
Initialize Rx packet buffer before starting RxTx, ensure to receive packets. Fixes: 62fc35e63d0e ("net/ngbe: support Rx queue start/stop") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 4 drivers/net/ngbe/base/ngbe_hw.c| 27 +

[PATCH v2 03/12] net/ngbe: fix Tx pending

2022-02-09 Thread Jiawen Wu
Add commands requesting firmware to enable or disable PCIe bus master. Disable PCIe master access to clear BME when stop hardware, and verify there are no pending requests. Move disabling Tx queue after disabling PCIe bus master, to ensure that there are no packets left to cause Tx hang. Fixes: 7

[PATCH v2 06/12] net/ngbe: add support to custom PHY interfaces

2022-02-09 Thread Jiawen Wu
Support sub_device ID 61/62/64 for YT8521S SFP, and 51/52 for M88E1512 PHY. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_22_03.rst | 7 + drivers/net/ngbe/base/ngbe_devids.h| 12 +- drivers/net/ngbe/base/ngbe_hw.c| 50 +-- drivers/net/ngbe/base/ngbe_phy.c |

[PATCH v2 05/12] net/ngbe: optimize the PHY initialization process

2022-02-09 Thread Jiawen Wu
Reduce the probability of PHY init failure, And add its error return. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_hw.c | 7 ++--- drivers/net/ngbe/base/ngbe_phy_rtl.c | 40 +--- drivers/net/ngbe/ngbe_ethdev.c | 6 - 3 files changed, 28 inserti

[PATCH v2 04/12] net/ngbe: fix RxTx packet statistics

2022-02-09 Thread Jiawen Wu
Fix specific length packet statistics caused by wrong register addresses. Fixes: ed5f3bd3373e ("net/ngbe: define registers") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 48 +++ 1 file changed, 24 insertions(+), 24 deletions(-)

[PATCH v2 07/12] net/ngbe: add LED OEM support

2022-02-09 Thread Jiawen Wu
Support to get OEM customized LED configuration information from firmware. And driver needs to adjust the process of PHY setup link, based on this LED configuration. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_22_03.rst | 1 + drivers/net/ngbe/base/ngbe_dummy.h | 5 +++ drive

[PATCH v2 09/12] net/txgbe: add LED OEM support

2022-02-09 Thread Jiawen Wu
Support to configure LED in firmware. Driver commands firmware to turn the LED on and off. And OEM customize their LED solutions in firmware. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/rel_notes/release_22_03.rst | 4 ++ drivers/net/txgbe/base/txgbe_h

[PATCH v2 08/12] net/ngbe: fix debug log

2022-02-09 Thread Jiawen Wu
Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix that double line was added by using 'DEBUGOUT'. Fixes: cc934df178ab ("net/ngbe: add log and error types") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_logs.h | 11 +++ 1 file changed, 7 insert

[PATCH v2 11/12] net/txgbe: fix to set link up and down

2022-02-09 Thread Jiawen Wu
Add hw->dev_start status in the flow of setting link up/down, to avoid obtaining link status inconsistent with the settings. Fixes: 12a653eb53e1 ("net/txgbe: fix link status when device stopped") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 2 ++ 1 file ch

[PATCH v2 10/12] net/txgbe: fix debug log

2022-02-09 Thread Jiawen Wu
Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix that double line was added by using 'DEBUGOUT'. Fixes: 7dc117068a7c ("net/txgbe: support probe and remove") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_logs.h | 9 ++--- 1 file changed, 6 inser

[PATCH v2 12/12] net/txgbe: fix KR auto-negotiation

2022-02-09 Thread Jiawen Wu
Fix failure to enter auto-negotiation mode on some firmware versions for KR NICs. Fixes: f611dada1af8 ("net/txgbe: update link setup process of backplane NICs") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_phy.c | 4 1 file changed, 4 insertions(+) diff --

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

2022-02-09 Thread Dmitry Kozlyuk
Hi Aman, Yuying, You share some concerns, so I'm answering in one thread. > From: Zhang, Yuying > Sent: Wednesday, February 9, 2022 12:00 PM [...] > > > +2225,20 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, > packet_fwd_t > > pkt_fwd) > > > static int > > > start_pkt_forward_on_core(void *f

[PATCH] app/testpmd : fix testpmd quit error

2022-02-09 Thread wenxuanx . wu
From: Wenxuan Wu when testpmd starup with pf and vfs, it is ok when running, while exiting, it will result in heap-free-after-use which means pf is released but vf is still accessing. Change the logic of func port_is_bonding_slave ,this func eth_dev_info_get_print_err while pf is released would

[PATCH] app/testpmd : fix testpmd quit error

2022-02-09 Thread wenxuanx . wu
From: Wenxuan Wu when testpmd startup with pf and vfs, it is ok when running, while exiting, it will result in heap-free-after-use which means pf is released but vf is still accessing. Change the logic of func port_is_bonding_slave ,this func eth_dev_info_get_print_err while pf is released would

Re: [PATCH v5 1/2] eal: add API for bus close

2022-02-09 Thread David Marchand
On Mon, Jan 10, 2022 at 6:26 AM wrote: > > From: Rohit Raj > > As per the current code we have API for bus probe, but the > bus close API is missing. This breaks the multi process > scenarios as objects are not cleaned while terminating the > secondary processes. After an application crash, how

[PATCH v2] doc: update FIPS docs

2022-02-09 Thread Jakub Poczatek
Added missing step for converting SHA request files to correct format. Replaced AES_GCM with GCM to follow the correct naming format. Fixes: 3d0fad56b74 ("examples/fips_validation: add crypto FIPS application") Cc: sta...@dpdk.org Signed-off-by: Jakub Poczatek Acked-by: Fan Zhang --- doc/guide

[PATCH] examples/ipsec-secgw: add check for unprotected port mask

2022-02-09 Thread Volodymyr Fialko
Usage of unprotected port mask without any configured SA inbound, will cause use of uninitialized SA context, so disallow such configuration. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-

RE: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-09 Thread Ananyev, Konstantin
> > >> Or have a generic library for reading LPM entries. L3fwd is supposed > > >> to be as small as possible (it no longer is), and the real work should > > >> be done by libraries to make it easier to build other applications. > > > > > > I never heard users ask about such thing, > > > but if

RE: [PATCH v18 8/8] eal: implement functions for mutex management

2022-02-09 Thread Ananyev, Konstantin
> On Mon, Feb 07, 2022 at 04:02:54PM +, Ananyev, Konstantin wrote: > > > Add functions for mutex init, destroy, lock, unlock, trylock. > > > > > > Windows does not have a static initializer. Initialization > > > is only done through InitializeCriticalSection(). To overcome this, > > > RTE_INIT_

RE: [PATCH v5 5/6] net/iavf: support L2TPv2 for AVF HASH

2022-02-09 Thread Xing, Beilei
> -Original Message- > From: Wang, Jie1X > Sent: Wednesday, February 9, 2022 5:39 PM > To: dev@dpdk.org > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; Yigit, Ferruh ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Wu, Jingjing > ; Xing, Beilei ; Zhang, Qi Z > ; olivi

Re: [PATCH] kni: fix use-after-free when kni release

2022-02-09 Thread Igor Ryzhov
Acked-by: Igor Ryzhov On Wed, Feb 9, 2022 at 10:36 AM Min Hu (Connor) wrote: > Hi, Igor, > fixed in v2, please check it, thanks. > > 在 2022/2/8 20:41, Igor Ryzhov 写道: > > Looks correct. > > Could you, please, also change the order of `list_del` and > > `kni_dev_remove` in `kni_release`? It suff

[PATCH v1] net/af_xdp: make umem configure code more readable

2022-02-09 Thread Haiyue Wang
The below compile time defined style make the code not so readable, the first function end block is after "#endif" segment. #if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG) xdp_umem_configure() { #else xdp_umem_configure() { #endif

Re: [PATCH v5 1/2] eal: add API for bus close

2022-02-09 Thread Thomas Monjalon
09/02/2022 12:04, David Marchand: > On Mon, Jan 10, 2022 at 6:26 AM wrote: > > > > From: Rohit Raj > > > > As per the current code we have API for bus probe, but the > > bus close API is missing. This breaks the multi process > > scenarios as objects are not cleaned while terminating the > > seco

Re: [PATCH v5 00/11] Add cnxk_gpio

2022-02-09 Thread Thomas Monjalon
18/01/2022 14:24, Tomasz Duszynski: > doc/guides/platform/cnxk.rst | 2 + > doc/guides/rawdevs/cnxk_gpio.rst | 200 ++ > doc/guides/rawdevs/index.rst | 1 + > doc/guides/rel_notes/release_22_03.rst | 9 + > drivers/raw/cnxk_gpio/cnxk_gpio.c

Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-09 Thread Ferruh Yigit
On 2/9/2022 4:00 AM, Wang, Haiyue wrote: -Original Message- From: Yigit, Ferruh Sent: Tuesday, February 8, 2022 22:52 To: Daly, Jeff ; Wang, Haiyue ; Stephen Douthit ; Morten Brørup ; Lu, Wenzhuo ; Zhang, Helin ; Zhang, Qi Z Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org Subject: Re:

Re: [PATCH] ci: remove outdated default reference tag for ABI

2022-02-09 Thread Thomas Monjalon
08/02/2022 16:08, Aaron Conole: > Thomas Monjalon writes: > > > The variable REF_GIT_TAG is set in the CI configuration > > like .travis.yml or .github/workflows/build.yml. > > The default value is outdated and probably unused. > > It is removed completely to avoid forgetting an update in future.

RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2022-02-09 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, February 9, 2022 21:33 > To: Wang, Haiyue ; Daly, Jeff ; > Stephen Douthit > ; Morten Brørup ; Lu, > Wenzhuo > ; Zhang, Helin ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, Wen ; sta...@dpdk.org > Subject: Re: [PATCH v2 3/7] net/

Re: [PATCH v3 1/4] kni: add define guards to avoid multi-inclusion

2022-02-09 Thread Ferruh Yigit
On 2/9/2022 7:24 AM, Weiguo Li wrote: Supplement define guards to prevent multiple inclusion. It is kind of private header and only 'rte_kni.c' includes it, that is why missing guards doesn't cause trouble but no harm/objection to have them. Signed-off-by: Weiguo Li Acked-by: Ferruh Yigit

Re: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-09 Thread Bruce Richardson
On Wed, Feb 09, 2022 at 12:00:40PM +, Ananyev, Konstantin wrote: > > > > > >> Or have a generic library for reading LPM entries. L3fwd is supposed > > > >> to be as small as possible (it no longer is), and the real work should > > > >> be done by libraries to make it easier to build other ap

Re: [PATCH v2] net/memif: remove pointer deference before null check

2022-02-09 Thread Ferruh Yigit
On 2/9/2022 7:39 AM, Weiguo Li wrote: There are duplicates of assignment here, the one before null check may cause a null pointer deference, so remove the previous one. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc: sta...@dpdk.org Signed-off-by: Weiguo Li Reviewed

RE: [PATCH v18 8/8] eal: implement functions for mutex management

2022-02-09 Thread Ananyev, Konstantin
> > Actually, please scrap that comment. > > Obviously it wouldn't work for static variables, > > and doesn't make much sense. > > Though few thoughts remain: > > for posix we probably don't need an indirection and > > rte_thread_mutex can be just typedef of pthread_mutex_t. > > also for posix we

[PATCH v2 0/5] crypto/qat: add asymmetric crypto algorithms

2022-02-09 Thread Arek Kusztal
This patchset adds following asymmetric crypto algorithms to Intel QuickAssist Technology driver: - ECDSA - ECPM Code also was refactored to be more readable and easier scalable. v2: - add actual implementation Arek Kusztal (5): crypto/qat: refactor asymmetric crypto functions crypto/qat: a

[PATCH v2 1/5] crypto/qat: refactor asymmetric crypto functions

2022-02-09 Thread Arek Kusztal
This commit refactors asummetric crypto functions in Intel QuickAssist Technology PMD. Functions right now are shorter and far easier readable, plus it facilitates addition of new algorithms. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst |1 + drivers/com

[PATCH v2 2/5] crypto/qat: add named elliptic curves

2022-02-09 Thread Arek Kusztal
This patch adds secp256r1 and secp521r1 elliptic curves to Intel QuickAssist Technology PMD. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_asym.c | 15 +++ drivers/crypto/qat/qat_ec.h | 206 ++ 2 files changed, 221 insertions(+) create mode 10

[PATCH v2 3/5] crypto/qat: add ecdsa algorithm

2022-02-09 Thread Arek Kusztal
This patch adds ECDSA algorithm to Intel QuickAssist Technology PMD. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 1 + doc/guides/rel_notes/release_22_03.rst | 5 ++ drivers/common/qat/qat_adf/qat_pke.h | 40 + drivers/crypto/qat/qat_asym.c | 1

[PATCH v2 4/5] crypto/qat: add ecpm algorithm

2022-02-09 Thread Arek Kusztal
This patch adds Elliptic Curve Multiplication algorithm to Intel QuickAssist Technology PMD. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 1 + doc/guides/rel_notes/release_22_03.rst | 5 ++ drivers/common/qat/qat_adf/qat_pke.h | 20 drivers/crypto/qat/qat

[PATCH v2 5/5] crypto/qat: refactor asymmetric session

2022-02-09 Thread Arek Kusztal
This patch refactors asymmetric session in Intel QuickAssist Technology PMD and fixes some issues with xform. Code will be now bit more scalable, and easier readable. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_asym.c | 441 -- drivers/crypto/qa

Re: [PATCH] ci: remove outdated default reference tag for ABI

2022-02-09 Thread David Marchand
On Wed, Feb 9, 2022 at 2:38 PM Thomas Monjalon wrote: > > 08/02/2022 16:08, Aaron Conole: > > Thomas Monjalon writes: > > > > > The variable REF_GIT_TAG is set in the CI configuration > > > like .travis.yml or .github/workflows/build.yml. > > > The default value is outdated and probably unused. >

Re: [PATCH v1] maintainers: update for testpmd

2022-02-09 Thread Ferruh Yigit
On 2/9/2022 9:23 AM, Dumitrescu, Cristian wrote: -Original Message- From: Zhang, Yuying Sent: Wednesday, February 9, 2022 3:01 PM To: dev@dpdk.org; Yigit, Ferruh ; Li, Xiaoyun ; Dumitrescu, Cristian ; tho...@monjalon.net Cc: Zhang, Yuying Subject: [PATCH v1] maintainers: update for t

Re: [PATCH v1] maintainers: update for testpmd

2022-02-09 Thread Ferruh Yigit
On 2/9/2022 5:28 PM, Yuying Zhang wrote: Add Konstantin as maintainer of test-pmd/bpf_cmd.* files. I think makes sense, files are related to the bpf library. Signed-off-by: Yuying Zhang Acked-by: Ferruh Yigit --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTA

Re: [PATCH v1] maintainers: update for testpmd

2022-02-09 Thread Ferruh Yigit
On 2/9/2022 3:01 PM, Yuying Zhang wrote: Add Cristian as maintainer of test-pmd/cmdline_tm.* files. Hi Yuying, Can you please update above wording slightly, instead of referring to maintainer name, can you please say something like: Move ' test-pmd/cmdline_tm.' under "Traffic Management API"

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

2022-02-09 Thread Li, Xiaoyun
Hi Dmitry Sorry to be direct, but I don't think this patch makes sense. I need the code to clarify the problems so I'll use this thread not the one you're answering. > -Original Message- > From: Zhang, Yuying > Sent: Wednesday, February 9, 2022 09:00 > To: Singh, Aman Deep ; Dmitry Kozl

Re: [PATCH] eal: remove unnecessary argv[0] handling

2022-02-09 Thread Thomas Monjalon
02/02/2022 20:47, Stephen Hemminger: > The rte_eal_init function looks at argv[0] to determine > the program name to pass to the log init function. > This is both unnecessary and in a corner case a problem. > > Parsing argv[0] is unnecessary because the function openlog() > already determines the

Re: [PATCH v5] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-02-09 Thread Luc Pelletier
> > Calls to rte_memcpy_generic could result in unaligned loads/stores for > > 1 < n < 16. This is undefined behavior according to the C standard, > > and it gets flagged by the clang undefined behavior sanitizer. > > > > rte_memcpy_generic is called with unaligned src and dst addresses. > > When 1

Re: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-09 Thread Stephen Hemminger
On Wed, 9 Feb 2022 09:48:08 + Ciara Loftus wrote: > Secondary process support had been disabled for the AF_XDP PMD because > there was no logic in place to share the AF_XDP socket file descriptors > between the processes. This commit introduces this logic using the IPC > APIs. > > Rx and Tx

Re: [dpdk-dev] [PATCH] ethdev: remove unnecessary NULL check

2022-02-09 Thread Stephen Hemminger
On Wed, 9 Feb 2022 20:24:10 +0800 Yunjian Wang wrote: > This NULL check is unnecessary, 'eth_dev' is never NULL. > > Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang Acked-by: Stephen Hemminger

Re: [RFC] Testpmd Maintenance affecting DTS

2022-02-09 Thread Owen Hilyard
> > Yes, any feature in ethdev should have a testpmd entry. > Which part of rte_flow is not testable with testpmd? > In general, any device API should be testable with the app/ directory. There are currently a lot of fields that appear in the documentation for rte_flow that are not exposed in

Re: [PATCH] eal: remove unnecessary argv[0] handling

2022-02-09 Thread Stephen Hemminger
On Wed, 09 Feb 2022 15:58:26 +0100 Thomas Monjalon wrote: > 02/02/2022 20:47, Stephen Hemminger: > > The rte_eal_init function looks at argv[0] to determine > > the program name to pass to the log init function. > > This is both unnecessary and in a corner case a problem. > > > > Parsing argv[0]

Re: [PATCH] net/bnxt: set HW coalescing parameters

2022-02-09 Thread Ajit Khaparde
On Tue, Feb 8, 2022 at 9:57 PM Ajit Khaparde wrote: > > Set coalescing parameters correctly for Rx completion rings. > This is not being done for the Rx completion rings currently. > > Fixes: 657c2a7f1dd4 ("net/bnxt: create aggregation rings when needed") > Cc: sta...@dpdk.org > > Signed-off-by: A

Re: [PATCH] net/bnxt: fix ring calculation for representors

2022-02-09 Thread Ajit Khaparde
On Tue, Feb 8, 2022 at 9:58 PM Ajit Khaparde wrote: > > Currently the Tx and Rx ring count for representors is fixed. > It does not consider the number of rings created for the parent > function. And that can cause issues not only during initialization > but while running traffic. > Instead check

[PATCH v4 0/5] crypto: improve asym session usage

2022-02-09 Thread Ciara Power
This patchset includes improvements for the asymmetric session. The main change is to the session structure, which is now a single mempool object, rather than having pointers to private data elsewhere. This session structure is now hidden in an internal header, so the app will never use it directly

[PATCH v4 1/5] doc: replace asym crypto code with literal includes

2022-02-09 Thread Ciara Power
The programmer's guide for cryptodev included sample code for using Asymmetric crypto. This is now replaced with direct code from the test application, using literal includes. It is broken into snippets as the test application didn't have all of the required code in one function. Signed-off-by: Ci

[PATCH v4 2/5] crypto: use single buffer for asymmetric session

2022-02-09 Thread Ciara Power
Rather than using a session buffer that contains pointers to private session data elsewhere, have a single session buffer. This session is created for a driver ID, and the mempool element contains space for the max session private data needed for any driver. Signed-off-by: Ciara Power Acked-by: F

[PATCH v4 3/5] crypto: hide asym session structure

2022-02-09 Thread Ciara Power
The rte_cryptodev_asym_session structure is now moved to an internal header. This will no longer be used directly by apps, private session data can be accessed via get API. Signed-off-by: Ciara Power Acked-by: Fan Zhang --- v4: - Initialised session variables as NULL. - Removed docs code ad

[PATCH v4 4/5] crypto: add asym session user data API

2022-02-09 Thread Ciara Power
A user data field is added to the asymmetric session structure. Relevant API added to get/set the field. Signed-off-by: Ciara Power Acked-by: Fan Zhang Acked-by: Anoob Joseph --- v4: - Reworded release notes. - Added possible error return values in function comment. - Removed docs code a

[PATCH v4 5/5] crypto: modify return value for asym session create

2022-02-09 Thread Ciara Power
Rather than the asym session create function returning a session on success, and a NULL value on error, it is modified to now return int values - 0 on success or -EINVAL/-ENOTSUP/-ENOMEM on failure. The session to be used is passed as input. This adds clarity on the failure of the create function,

Re: [PATCH] eal: remove unnecessary argv[0] handling

2022-02-09 Thread Stephen Hemminger
On Wed, 09 Feb 2022 15:58:26 +0100 Thomas Monjalon wrote: > 02/02/2022 20:47, Stephen Hemminger: > > The rte_eal_init function looks at argv[0] to determine > > the program name to pass to the log init function. > > This is both unnecessary and in a corner case a problem. > > > > Parsing argv[0]

[PATCH v2] Subject: eal: remove unnecessary argv[0] handling

2022-02-09 Thread Stephen Hemminger
The rte_eal_init function only evalutes argv[0] to determine the program name to pass to the log init function. This is both unnecessary and in a corner case a problem. It is possible to run a program with argc=0 and argv[0]=NULL. This would cause rte_eal_init() to dereference a null pointer. Not

Re: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-09 Thread Medvedkin, Vladimir
Hi, On 09/02/2022 13:54, Bruce Richardson wrote: On Wed, Feb 09, 2022 at 12:00:40PM +, Ananyev, Konstantin wrote: Or have a generic library for reading LPM entries. L3fwd is supposed to be as small as possible (it no longer is), and the real work should be done by libraries to make it e

[dpdk-dev] [PATCH] net/cnxk: unify the file name

2022-02-09 Thread jerinj
From: Jerin Jacob expect cn*_rte_flow* files, none of the other file has rte in the file name, remove the rte to unify the file name across the directory. Signed-off-by: Jerin Jacob --- drivers/net/cnxk/cn10k_rte_flow.c | 2 +- drivers/net/cnxk/cn9k_rte_flow.c

Re: [PATCH] net/bnxt: fix ring calculation for representors

2022-02-09 Thread Ajit Khaparde
On Wed, Feb 9, 2022 at 7:37 AM Ajit Khaparde wrote: > > On Tue, Feb 8, 2022 at 9:58 PM Ajit Khaparde > wrote: > > > > Currently the Tx and Rx ring count for representors is fixed. > > It does not consider the number of rings created for the parent > > function. And that can cause issues not only

[PATCH v2] net/bnxt: fix ring calculation for representors

2022-02-09 Thread Ajit Khaparde
Currently the Tx and Rx ring count for representors is fixed. It does not consider the number of rings created for the parent function. And that can cause issues not only during initialization but while running traffic. Instead check the number of rings created for the parent function while configu

  1   2   3   >